Conditions | 1 |
Paths | 1 |
Total Lines | 82 |
Code Lines | 46 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
20 | public function up(Schema $schema) |
||
21 | { |
||
22 | $entityManage = $this->getEntityManager(); |
||
23 | |||
24 | $deleteOptions = $entityManage->createQueryBuilder(); |
||
25 | $deleteSettings = $entityManage->createQueryBuilder(); |
||
26 | |||
27 | $deleteOptions->delete('ChamiloCoreBundle:SettingsOptions', 'o') |
||
28 | ->andWhere( |
||
29 | $deleteOptions->expr()->in( |
||
30 | 'o.variable', |
||
31 | [ |
||
32 | 'display_mini_month_calendar' |
||
33 | ] |
||
34 | ) |
||
35 | ); |
||
36 | $deleteOptions->getQuery()->execute(); |
||
37 | |||
38 | $deleteSettings->delete('ChamiloCoreBundle:SettingsCurrent', 's') |
||
39 | ->andWhere( |
||
40 | $deleteSettings->expr()->in( |
||
41 | 's.variable', |
||
42 | [ |
||
43 | 'display_mini_month_calendar' |
||
44 | ] |
||
45 | ) |
||
46 | ); |
||
47 | $deleteSettings->getQuery()->execute(); |
||
48 | $deleteOptions->delete('ChamiloCoreBundle:SettingsOptions', 'o') |
||
49 | ->andWhere( |
||
50 | $deleteOptions->expr()->in( |
||
51 | 'o.variable', |
||
52 | [ |
||
53 | 'display_upcoming_events' |
||
54 | ] |
||
55 | ) |
||
56 | ); |
||
57 | $deleteOptions->getQuery()->execute(); |
||
58 | |||
59 | $deleteSettings->delete('ChamiloCoreBundle:SettingsCurrent', 's') |
||
60 | ->andWhere( |
||
61 | $deleteSettings->expr()->in( |
||
62 | 's.variable', |
||
63 | [ |
||
64 | 'display_upcoming_events' |
||
65 | ] |
||
66 | ) |
||
67 | ); |
||
68 | $deleteSettings->getQuery()->execute(); |
||
69 | $deleteSettings->delete('ChamiloCoreBundle:SettingsCurrent', 's') |
||
70 | ->andWhere( |
||
71 | $deleteSettings->expr()->in( |
||
72 | 's.variable', |
||
73 | [ |
||
74 | 'number_of_upcoming_events' |
||
75 | ] |
||
76 | ) |
||
77 | ); |
||
78 | $deleteSettings->getQuery()->execute(); |
||
79 | |||
80 | $deleteOptions->delete('ChamiloCoreBundle:SettingsOptions', 'o') |
||
81 | ->andWhere( |
||
82 | $deleteOptions->expr()->in( |
||
83 | 'o.variable', |
||
84 | [ |
||
85 | 'allow_reservation' |
||
86 | ] |
||
87 | ) |
||
88 | ); |
||
89 | $deleteOptions->getQuery()->execute(); |
||
90 | |||
91 | $deleteSettings->delete('ChamiloCoreBundle:SettingsCurrent', 's') |
||
92 | ->andWhere( |
||
93 | $deleteSettings->expr()->in( |
||
94 | 's.variable', |
||
95 | [ |
||
96 | 'allow_reservation' |
||
97 | ] |
||
98 | ) |
||
99 | ); |
||
100 | $deleteSettings->getQuery()->execute(); |
||
101 | } |
||
102 | |||
179 |