chamilo / chamilo-lms

main/lp/aiccItem.class.php

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
         $abs_order++;
         $i = 1;
         foreach ($this->sub_items as $id => $dummy) {
-            $oSubitem =& $this->sub_items[$id];
+            $oSubitem = & $this->sub_items[$id];
             $oSubitem->get_flat_list($list, $abs_order, $i, $level + 1);
             $i++;
         }

main/lp/lp_subscribe_users.php

Spacing +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
     exit;
 } else {
     $headers = [get_lang('SubscribeUsersToLp'), get_lang('SubscribeGroupsToLp')];
-    $tabs = Display::tabs($headers, [$formUsers->toHtml(),$form->toHtml()]);
+    $tabs = Display::tabs($headers, [$formUsers->toHtml(), $form->toHtml()]);
     $tpl->assign('tabs', $tabs);
 }
 

main/lp/scormOrganization.class.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
         foreach ($this->items as $id => $dummy) {
             $abs_order = 0;
             // Passes the array as a pointer so it is modified in $list directly.
-            $this->items[$id]->get_flat_list($list,$abs_order, $i, 0);
+            $this->items[$id]->get_flat_list($list, $abs_order, $i, 0);
             $i++;
         }
 

main/lp/aicc.class.php

Spacing +27 added lines, -27 removed lines

@@ -12,7 +12,7 @@ 
 class aicc extends learnpath
 {
     public $config = array();
-    public $config_basename = '';	// The configuration files might be multiple and might have
+    public $config_basename = ''; // The configuration files might be multiple and might have
                                     // funny names. We need to keep the name of that file while we
                                     // install the content.
     public $config_files = array();
@@ -32,9 +32,9 @@ 
     public $cstlist = array();
     public $orelist = array();
 
-    public $subdir = '';	// Path between the scorm/ directory and the config files e.g. maritime_nav/maritime_nav. This is the path that will be used in the lp_path when importing a package.
-    public $zipname = '';	// Keeps the zipfile safe for the object's life so that we can use it if there is no title available.
-    public $lastzipnameindex = 0;	// Keeps an index of the number of uses of the zipname so far.
+    public $subdir = ''; // Path between the scorm/ directory and the config files e.g. maritime_nav/maritime_nav. This is the path that will be used in the lp_path when importing a package.
+    public $zipname = ''; // Keeps the zipfile safe for the object's life so that we can use it if there is no title available.
+    public $lastzipnameindex = 0; // Keeps an index of the number of uses of the zipname so far.
     public $config_encoding = 'ISO-8859-1';
     public $debug = 0;
 
@@ -132,7 +132,7 @@ 
             //echo '<pre>des:'.print_r($des_params, true).'</pre>';
             if ($this->debug > 1) { error_log('New LP - In aicc::parse_config_files() - '.$des_file.' has been parsed', 0); }
             // Distribute des params into the aicc object.
-            foreach ($des_params as $des){
+            foreach ($des_params as $des) {
                 // One AU in AICC is equivalent to one SCO in SCORM (scormItem class).
                 $oDes = new aiccResource('config', $des);
                 $this->deslist[$oDes->identifier] = $oDes;
@@ -242,12 +242,12 @@ 
 
         $this->config_encoding = "ISO-8859-1"; // TODO: We may apply detection for this value, see the function api_detect_encoding().
 
-        $sql = "INSERT INTO $new_lp (c_id, lp_type, name, ref, description, path, force_commit, default_view_mod, default_encoding, js_lib, content_maker,display_order)" .
-                "VALUES " .
-                "($course_id, 3, '".$this->course_title."', '".$this->course_id."','".$this->course_description."'," .
-                "'".$this->subdir."', 0, 'embedded', '".$this->config_encoding."'," .
+        $sql = "INSERT INTO $new_lp (c_id, lp_type, name, ref, description, path, force_commit, default_view_mod, default_encoding, js_lib, content_maker,display_order)".
+                "VALUES ".
+                "($course_id, 3, '".$this->course_title."', '".$this->course_id."','".$this->course_description."',".
+                "'".$this->subdir."', 0, 'embedded', '".$this->config_encoding."',".
                 "'aicc_api.php','".$this->course_creator."',$dsp)";
-        if ($this->debug > 2) { error_log('New LP - In import_aicc(), inserting path: '. $sql, 0); }
+        if ($this->debug > 2) { error_log('New LP - In import_aicc(), inserting path: '.$sql, 0); }
         Database::query($sql);
         $lp_id = Database::insert_id();
 
@@ -276,7 +276,7 @@ 
 
         $previous = 0;
         foreach ($this->aulist as $identifier => $dummy) {
-            $oAu =& $this->aulist[$identifier];
+            $oAu = & $this->aulist[$identifier];
             //echo "Item ".$oAu->identifier;
             $field_add = '';
             $value_add = '';
@@ -294,12 +294,12 @@ 
             $parent = 0; // TODO: Deal with the parent.
             $previous = 0;
             $prereq = $oAu->prereq_string;
-            $sql_item = "INSERT INTO $new_lp_item (c_id, lp_id,item_type,ref,title, path,min_score,max_score, $field_add parent_item_id,previous_item_id,next_item_id, prerequisite,display_order,parameters) " .
-                    "VALUES " .
-                    "($course_id, $lp_id, 'au','".$oAu->identifier."','".$title."'," .
-                    "'$path',0,100, $value_add" .
-                    "$parent, $previous, 0, " .
-                    "'$prereq', 0,'".(!empty($oAu->parameters)?Database::escape_string($oAu->parameters):'')."'" .
+            $sql_item = "INSERT INTO $new_lp_item (c_id, lp_id,item_type,ref,title, path,min_score,max_score, $field_add parent_item_id,previous_item_id,next_item_id, prerequisite,display_order,parameters) ".
+                    "VALUES ".
+                    "($course_id, $lp_id, 'au','".$oAu->identifier."','".$title."',".
+                    "'$path',0,100, $value_add".
+                    "$parent, $previous, 0, ".
+                    "'$prereq', 0,'".(!empty($oAu->parameters) ? Database::escape_string($oAu->parameters) : '')."'".
                     ")";
             Database::query($sql_item);
             if ($this->debug > 1) { error_log('New LP - In aicc::import_aicc() - inserting item : '.$sql_item.' : ', 0); }
@@ -350,7 +350,7 @@ 
         $zip_file_name = $zip_file_info['name'];
 
         if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Zip file path = '.$zip_file_path.', zip file name = '.$zip_file_name, 0); }
-        $course_rel_dir  = api_get_course_path().'/scorm'; // Scorm dir web path starting from /courses
+        $course_rel_dir = api_get_course_path().'/scorm'; // Scorm dir web path starting from /courses
         $course_sys_dir = api_get_path(SYS_COURSE_PATH).$course_rel_dir; // The absolute system path of this course.
         $current_dir = api_replace_dangerous_char(trim($current_dir)); // Current dir we are in, inside scorm/
         if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Current_dir = '.$current_dir, 0); }
@@ -367,7 +367,7 @@ 
         if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Base file name is : '.$file_base_name, 0); }
         $new_dir = api_replace_dangerous_char(trim($file_base_name));
         $this->subdir = $new_dir;
-        if($this->debug > 0) { error_log('New LP - aicc::import_package() - Subdir is first set to : '.$this->subdir, 0); }
+        if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Subdir is first set to : '.$this->subdir, 0); }
 
         /*
         if (check_name_exist($course_sys_dir.$current_dir.'/'.$new_dir)) {
@@ -413,7 +413,7 @@ 
                         $subdir_isset = true;
                     } else {
                         if (!$subdir_isset) {
-                            if (preg_match('?^.*/aicc$?i',dirname($thisContent['filename']))) {
+                            if (preg_match('?^.*/aicc$?i', dirname($thisContent['filename']))) {
                                 //echo "Cutting subdir<br/>";
                                 $this->subdir .= '/'.substr(dirname($thisContent['filename']), 0, -5);
                             } else {
@@ -516,7 +516,7 @@ 
                         // TODO: RENAMING FILES CAN BE VERY DANGEROUS AICC-WISE, avoid that as much as possible!
                         //$safe_file = api_replace_dangerous_char($file, 'strict');
                         $find_str = array('\\', '.php', '.phtml');
-                        $repl_str = array('/',  '.txt', '.txt');
+                        $repl_str = array('/', '.txt', '.txt');
                         $safe_file = str_replace($find_str, $repl_str, $file);
 
                         if ($safe_file != $file) {
@@ -717,7 +717,7 @@ 
         if ($this->debug > 0) { error_log('In aicc::get_res_path('.$id.') method', 0); }
         $path = '';
         if (isset($this->resources[$id])) {
-            $oRes =& $this->resources[$id];
+            $oRes = & $this->resources[$id];
             $path = @$oRes->get_path();
         }
         return $path;
@@ -733,7 +733,7 @@ 
         if ($this->debug > 0) { error_log('In aicc::get_res_type('.$id.') method', 0); }
         $type = '';
         if (isset($this->resources[$id])) {
-            $oRes =& $this->resources[$id];
+            $oRes = & $this->resources[$id];
             $temptype = $oRes->get_scorm_type();
             if (!empty($temptype)) {
                 $type = $temptype;
@@ -746,7 +746,7 @@ 
      * Gets the default organisation's title
      * @return	string	The organization's title
      */
-    function get_title(){
+    function get_title() {
         if ($this->debug > 0) { error_log('In aicc::get_title() method', 0); }
         $title = '';
         if (isset($this->config['organizations']['default'])) {
@@ -907,7 +907,7 @@ 
             $chr = $data{$i};
             switch ($chr) {
                 case $enclosure:
-                    if ($enclosed && $data{$i+1} == $enclosure) {
+                    if ($enclosed && $data{$i + 1} == $enclosure) {
                         $fldval .= $chr;
                         ++$i; // Skip the next character.
                     } else
@@ -921,7 +921,7 @@ 
                         $fldval .= $chr;
                     break;
                 case "\r":
-                    if (!$enclosed&&$data{$i+1} == "\n")
+                    if (!$enclosed && $data{$i + 1} == "\n")
                         continue;
                 case "\n":
                     if (!$enclosed) {
@@ -932,7 +932,7 @@ 
                         $fldval .= $chr;
                     break;
                 case "\\r":
-                    if (!$enclosed&&$data{$i+1} == "\\n")
+                    if (!$enclosed && $data{$i + 1} == "\\n")
                         continue;
                 case "\\n":
                     if (!$enclosed) {

main/lp/aicc_api.php

Spacing +23 added lines, -23 removed lines

@@ -78,33 +78,33 @@ 
 var commit = false ;
 
 // Strictly SCORM variables.
-var score=<?php echo $oItem->get_score();?>;
-var max=<?php echo $oItem->get_max();?>;
-var min=<?php echo $oItem->get_min();?>;
-var lesson_status='<?php echo $oItem->get_status();?>';
-var session_time='<?php echo $oItem->get_scorm_time('js');?>';
-var suspend_data = '<?php echo $oItem->get_suspend_data();?>';
-var lesson_location = '<?php echo $oItem->get_lesson_location();?>';
-var total_time = '<?php echo $oItem->get_scorm_time('js');?>';
+var score=<?php echo $oItem->get_score(); ?>;
+var max=<?php echo $oItem->get_max(); ?>;
+var min=<?php echo $oItem->get_min(); ?>;
+var lesson_status='<?php echo $oItem->get_status(); ?>';
+var session_time='<?php echo $oItem->get_scorm_time('js'); ?>';
+var suspend_data = '<?php echo $oItem->get_suspend_data(); ?>';
+var lesson_location = '<?php echo $oItem->get_lesson_location(); ?>';
+var total_time = '<?php echo $oItem->get_scorm_time('js'); ?>';
 
 // Chamilo internal variables.
 var saved_lesson_status = 'not attempted';
-var lms_lp_id = <?php echo $oLP->get_id();?>;
-var lms_item_id = <?php echo $oItem->get_id();?>;
+var lms_lp_id = <?php echo $oLP->get_id(); ?>;
+var lms_item_id = <?php echo $oItem->get_id(); ?>;
 //var lms_new_item_id = 0; //temporary value (only there between a load_item() and a LMSInitialize())
 var lms_been_synchronized = 0;
 var lms_initialized = 0;
 var lms_total_lessons = <?php echo $oLP->get_total_items_count(); ?>;
-var lms_complete_lessons = <?php echo $oLP->get_complete_items_count();?>;
-var lms_progress_bar_mode = '<?php echo $oLP->progress_bar_mode;?>';
+var lms_complete_lessons = <?php echo $oLP->get_complete_items_count(); ?>;
+var lms_progress_bar_mode = '<?php echo $oLP->progress_bar_mode; ?>';
 if(lms_progress_bar_mode == ''){lms_progress_bar_mode='%';}
-var lms_view_id = '<?php echo $oLP->get_view();?>';
+var lms_view_id = '<?php echo $oLP->get_view(); ?>';
 if(lms_view_id == ''){ lms_view_id = 1;}
-var lms_user_id = '<?php echo $_user['user_id'];?>';
-var lms_next_item = '<?php echo $oLP->get_next_item_id();?>';
-var lms_previous_item = '<?php echo $oLP->get_previous_item_id();?>';
-var lms_lp_type = '<?php echo $oLP->get_type();?>';
-var lms_item_type = '<?php echo $oItem->get_type();?>';
+var lms_user_id = '<?php echo $_user['user_id']; ?>';
+var lms_next_item = '<?php echo $oLP->get_next_item_id(); ?>';
+var lms_previous_item = '<?php echo $oLP->get_previous_item_id(); ?>';
+var lms_lp_type = '<?php echo $oLP->get_type(); ?>';
+var lms_item_type = '<?php echo $oItem->get_type(); ?>';
 
 // Backup for old values.
 var old_score = 0;
@@ -162,11 +162,11 @@ 
     }else if(param == 'cmi.core.lesson_mode'){
         result='normal';
     }else if(param == 'cmi.suspend_data'){
-        result='<?php echo $oItem->get_suspend_data();?>';
+        result='<?php echo $oItem->get_suspend_data(); ?>';
     }else if(param == 'cmi.launch_data'){
         result='';
     }else if(param == 'cmi.objectives._count'){
-        result='<?php echo $oItem->get_view_count();?>';
+        result='<?php echo $oItem->get_view_count(); ?>';
     }
     /*
     // Switch not working??? WTF???
@@ -227,13 +227,13 @@ 
             result='normal';
             break;
         case 'cmi.suspend_data'		:
-            result='<?php echo $oItem->get_suspend_data();?>';
+            result='<?php echo $oItem->get_suspend_data(); ?>';
             break;
         case 'cmi.launch_data'		:
             result='';
             break;
         case 'cmi.objectives._count':
-            result='<?php echo $oItem->get_view_count();?>';
+            result='<?php echo $oItem->get_view_count(); ?>';
             break;
         default 					:
             result='';
@@ -285,7 +285,7 @@ 
     $url = $_SERVER['HTTP_HOST'].$self;
     $url = substr($url, 0, -14); // 14 is the length of this file's name (/scorm_api.php).
     echo $url;
-    ?>/lp_controller.php?<?php echo api_get_cidreq(); ?>&action=save&lp_id=<?php echo $oLP->get_id();?>&" + param + "";
+    ?>/lp_controller.php?<?php echo api_get_cidreq(); ?>&action=save&lp_id=<?php echo $oLP->get_id(); ?>&" + param + "";
     logit_lms('saving data (status='+lesson_status+')',1);
     xajax_save_item(lms_lp_id, lms_user_id, lms_view_id, lms_item_id, score, max, min, lesson_status, session_time, suspend_data, lesson_location);
     //xajax_update_pgs();

main/lp/scormMetadata.class.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
                      //$keep_href = '';
                      if (is_array($attributes)) {
                          foreach ($attributes as $attrib) {
-                             if (trim($attrib->value) != ''){
+                             if (trim($attrib->value) != '') {
                                  $this->attribs[$attrib->name] = $attrib->value;
                              }
                          }

main/lp/lp_ajax_switch_item.php

Spacing +1 added lines, -1 removed lines

@@ -198,7 +198,7 @@
         //"lms_progress_bar_mode='".$myprogress_mode."';" .
         "olms.lms_view_id=".$view_id.";".
         "olms.lms_user_id=".$user_id.";".
-        "olms.next_item=".$new_item_id.";". // This one is very important to replace possible literal strings.
+        "olms.next_item=".$new_item_id.";".// This one is very important to replace possible literal strings.
         "olms.lms_next_item=".$mynext.";".
         "olms.lms_previous_item=".$myprevious.";".
         "olms.lms_item_type = '".$myitemtype."';".

main/lp/lp_edit_item.php

Spacing +4 added lines, -4 removed lines

@@ -99,7 +99,7 @@ 
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.$_SESSION['gradebook_dest'],
         'name' => get_lang('ToolGradebook')
     );
@@ -112,7 +112,7 @@ 
 $show_learn_path = true;
 $lp_theme_css = $_SESSION['oLP']->get_theme();
 
-Display::display_header(get_lang('Edit'),'Path');
+Display::display_header(get_lang('Edit'), 'Path');
 $suredel = trim(get_lang('AreYouSureToDeleteJS'));
 
 ?>
@@ -165,8 +165,8 @@ 
 $path_item = isset($_GET['path_item']) ? $_GET['path_item'] : 0;
 $path_item = Database::escape_string($path_item);
 $tbl_doc = Database :: get_course_table(TABLE_DOCUMENT);
-$sql_doc = "SELECT path FROM " . $tbl_doc . "
-            WHERE c_id = $course_id AND id = '". $path_item."' ";
+$sql_doc = "SELECT path FROM ".$tbl_doc."
+            WHERE c_id = $course_id AND id = '".$path_item."' ";
 
 $res_doc = Database::query($sql_doc);
 $path_file = Database::result($res_doc, 0, 0);

main/lp/lp_ajax_save_objectives.php

Spacing +4 added lines, -4 removed lines

@@ -28,10 +28,10 @@
         error_log('In xajax_save_objectives('.$lp_id.','.$user_id.','.$view_id.','.$item_id.',"'.(count($objectives) > 0 ? count($objectives) : '').'")', 0);
     }
     $mylp = learnpath::getLpFromSession(api_get_course_id(), $lp_id, $user_id);
-    $mylpi =& $mylp->items[$item_id];
-    if (is_array($objectives) && count($objectives)>0){
-        foreach ($objectives as $index=>$objective){
-            $mylpi->add_objective($index,$objectives[$index]);
+    $mylpi = & $mylp->items[$item_id];
+    if (is_array($objectives) && count($objectives) > 0) {
+        foreach ($objectives as $index=>$objective) {
+            $mylpi->add_objective($index, $objectives[$index]);
         }
         $mylpi->write_objectives_to_db();
     }