Inspection of "Fix Individual Work correction ajax loader" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.11.x (#1262)

by José

created 2016-07-04 17:41 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -203,7 +203,7 @@  discard block
 block discarded – undo
                 $limit
             );
         } else {
-            header('Location: ' . api_get_self());
+            header('Location: '.api_get_self());
         }
         break;
     case 'display_random_courses':
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
                 $continueWithSubscription = SequenceResourceManager::checkSequenceAreCompleted($requirementsData);
 
                 if (!$continueWithSubscription) {
-                    header('Location: ' .  api_get_path(WEB_CODE_PATH) . 'auth/courses.php');
+                    header('Location: '.api_get_path(WEB_CODE_PATH).'auth/courses.php');
                     exit;
                 }
             }
@@ -296,16 +296,16 @@  discard block
 block discarded – undo
 
             if ($count <= 0) {
                 // no course in session -> return to catalog
-                $url = api_get_path(WEB_CODE_PATH) . 'auth/courses.php';
+                $url = api_get_path(WEB_CODE_PATH).'auth/courses.php';
             } elseif ($count == 1) {
                 // only one course, so redirect directly to this course
                 foreach ($coursesList as $course) {
-                    $url = api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . intval($_GET['session_id']);
+                    $url = api_get_path(WEB_COURSE_PATH).$course['directory'].'/index.php?id_session='.intval($_GET['session_id']);
                 }
             } else {
-                $url = api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . intval($_GET['session_id']);
+                $url = api_get_path(WEB_CODE_PATH).'session/index.php?session_id='.intval($_GET['session_id']);
             }
-            header('Location: ' . $url);
+            header('Location: '.$url);
             exit;
         }
         //else show error message?

Please login to merge, or discard this patch.

main/auth/gotocourse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@
 block discarded – undo
 
     $msg .= '<div class="well_login">';
     $msg .= $form->return_form();
-    $msg .='</div>';
+    $msg .= '</div>';
     if (api_is_cas_activated()) {
         $msg .= "</div>";
     }

Please login to merge, or discard this patch.

main/auth/conditional_login/complete_phone_number.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -2,9 +2,9 @@  discard block
 block discarded – undo
 /* For licensing terms, see /license.txt */
 
 require_once dirname(__FILE__).'/../../inc/global.inc.php';
-$url =  api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
+$url = api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
 
-if (! isset($_SESSION['conditional_login']['uid']))
+if (!isset($_SESSION['conditional_login']['uid']))
   die("Not Authorised");
 ?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
   </body>
 </html>
 <?php
-if (isset($_POST['submit'])){
+if (isset($_POST['submit'])) {
     $u = api_get_user_info($_SESSION['conditional_login']['uid']);
     $u['phone'] = $_POST['phone_number'];
     $password = null; // we don't want to change the password

Please login to merge, or discard this patch.

main/auth/my_progress.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -54,16 +54,16 @@  discard block
 block discarded – undo
         }
         $course_info = api_get_course_info_by_id($result['c_id']);
         $course_image = '<img src="'.$course_info['course_image_large'].'">';
-        $dates .= '<li><a href="#'.$login.'">' . api_convert_and_format_date($login, DATE_FORMAT_SHORT) . '</a></li>';
+        $dates .= '<li><a href="#'.$login.'">'.api_convert_and_format_date($login, DATE_FORMAT_SHORT).'</a></li>';
         $issues .= '<li id ="'.$login.'">';
         $issues .= '<div class="img-course">'.$course_image.'</div>';
         
         $issues .= '<div class="text-course">';
-        $issues .= '<p>' . sprintf(
+        $issues .= '<p>'.sprintf(
                 get_lang('YouHaveEnteredTheCourseXInY'),
-                '" '. $courseInfo['name'] .' "',
+                '" '.$courseInfo['name'].' "',
                 api_convert_and_format_date($login, DATE_TIME_FORMAT_LONG) 
-                ) . '</p>';
+                ).'</p>';
         $issues .= '</div>'; 
         $issues .= '</li>';
         $count++;
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
     $content .= '<div class="row">';
     $content .= '<div class="col-md-12">';
     $content .= '<div id="my_timeline">';
-    $content .= '<ul id="dates">' . $dates . '</ul>';
-    $content .= '<ul id="issues">' . $issues . '</ul>';
+    $content .= '<ul id="dates">'.$dates.'</ul>';
+    $content .= '<ul id="issues">'.$issues.'</ul>';
     $content .= '<div id="grad_left"></div>';
     $content .= '<div id="grad_right"></div>';
     $content .= '<a href="#" id="prev"></a>';

Please login to merge, or discard this patch.

facebook-php-sdk/src/Facebook/FacebookSignedRequestFromInputHelper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -157,8 +157,8 @@
 block discarded – undo
    */
   public function getRawSignedRequestFromCookie()
   {
-    if (isset($_COOKIE['fbsr_' . $this->appId])) {
-      return $_COOKIE['fbsr_' . $this->appId];
+    if (isset($_COOKIE['fbsr_'.$this->appId])) {
+      return $_COOKIE['fbsr_'.$this->appId];
     }
     return null;
   }

Please login to merge, or discard this patch.

facebook-php-sdk/src/Facebook/FacebookRedirectLoginHelper.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -99,7 +99,7 @@  discard block
 block discarded – undo
       'client_id' => $this->appId,
       'redirect_uri' => $this->redirectUrl,
       'state' => $this->state,
-      'sdk' => 'php-sdk-' . FacebookRequest::VERSION,
+      'sdk' => 'php-sdk-'.FacebookRequest::VERSION,
       'scope' => implode(',', $scope)
     );
     
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
       $params['display'] = 'popup';
     }
     
-    return 'https://www.facebook.com/' . $version . '/dialog/oauth?' .
+    return 'https://www.facebook.com/'.$version.'/dialog/oauth?'.
       http_build_query($params, null, '&');
   }
 
@@ -129,11 +129,11 @@  discard block
 block discarded – undo
       'client_id' => $this->appId,
       'redirect_uri' => $this->redirectUrl,
       'state' => $this->state,
-      'sdk' => 'php-sdk-' . FacebookRequest::VERSION,
+      'sdk' => 'php-sdk-'.FacebookRequest::VERSION,
       'auth_type' => 'rerequest',
       'scope' => implode(',', $scope)
     );
-    return 'https://www.facebook.com/' . $version . '/dialog/oauth?' .
+    return 'https://www.facebook.com/'.$version.'/dialog/oauth?'.
       http_build_query($params, null, '&');
   }
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
       'next' => $next,
       'access_token' => $session->getToken()
     );
-    return 'https://www.facebook.com/logout.php?' . http_build_query($params, null, '&');
+    return 'https://www.facebook.com/logout.php?'.http_build_query($params, null, '&');
   }
 
   /**
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
         'Session not active, could not store state.', 720
       );
     }
-    $_SESSION[$this->sessionPrefix . 'state'] = $state;
+    $_SESSION[$this->sessionPrefix.'state'] = $state;
   }
 
   /**
@@ -255,8 +255,8 @@  discard block
 block discarded – undo
         'Session not active, could not load state.', 721
       );
     }
-    if (isset($_SESSION[$this->sessionPrefix . 'state'])) {
-      $this->state = $_SESSION[$this->sessionPrefix . 'state'];
+    if (isset($_SESSION[$this->sessionPrefix.'state'])) {
+      $this->state = $_SESSION[$this->sessionPrefix.'state'];
       return $this->state;
     }
     return null;
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
       if ($fp !== FALSE) {
         $buf = fread($fp, $bytes);
         fclose($fp);
-        if($buf !== FALSE) {
+        if ($buf !== FALSE) {
           return bin2hex($buf);
         }
       }

Please login to merge, or discard this patch.

main/auth/external_login/facebook-php-sdk/src/Facebook/FacebookResponse.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -189,7 +189,7 @@
 block discarded – undo
       $url = parse_url($this->responseData->paging->$direction);
       parse_str($url['query'], $params);
 
-      if (isset($params['type']) && strpos($this->request->getPath(), $params['type']) !== false){
+      if (isset($params['type']) && strpos($this->request->getPath(), $params['type']) !== false) {
         unset($params['type']);
       }
       return new FacebookRequest(

Please login to merge, or discard this patch.

facebook-php-sdk/src/Facebook/HttpClients/FacebookCurlHttpClient.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -177,7 +177,7 @@  discard block
 block discarded – undo
       CURLOPT_HEADER         => true, // Enable header processing
       CURLOPT_SSL_VERIFYHOST => 2,
       CURLOPT_SSL_VERIFYPEER => true,
-      CURLOPT_CAINFO         => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem',
+      CURLOPT_CAINFO         => __DIR__.'/certs/DigiCertHighAssuranceEVRootCA.pem',
     );
 
     if ($method !== "GET") {
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
     $return = array();
 
     foreach ($this->requestHeaders as $key => $value) {
-      $return[] = $key . ': ' . $value;
+      $return[] = $key.': '.$value;
     }
 
     return $return;
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
     $headerSize = self::$facebookCurl->getinfo(CURLINFO_HEADER_SIZE);
     // This corrects a Curl bug where header size does not account
     // for additional Proxy headers.
-    if ( self::needsCurlProxyFix() ) {
+    if (self::needsCurlProxyFix()) {
       // Additional way to calculate the request body size.
       if (preg_match('/Content-Length: (\d+)/', $this->rawResponse, $m)) {
           $headerSize = mb_strlen($this->rawResponse) - $m[1];

Please login to merge, or discard this patch.

facebook-php-sdk/src/Facebook/HttpClients/FacebookGuzzleHttpClient.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -108,11 +108,11 @@
 block discarded – undo
       $options = array('body' => $parameters);
     }
 
-    $options['verify'] = __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem';
+    $options['verify'] = __DIR__.'/certs/DigiCertHighAssuranceEVRootCA.pem';
 
     $request = self::$guzzleClient->createRequest($method, $url, $options);
 
-    foreach($this->requestHeaders as $k => $v) {
+    foreach ($this->requestHeaders as $k => $v) {
       $request->setHeader($k, $v);
     }
 

Please login to merge, or discard this patch.

		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	$limit
204	204	);
205	205	} else {
206		- header('Location: ' . api_get_self());
	206	+ header('Location: '.api_get_self());
207	207	}
208	208	break;
209	209	case 'display_random_courses':
		@@ -278,7 +278,7 @@ discard block
		block discarded – undo
278	278	$continueWithSubscription = SequenceResourceManager::checkSequenceAreCompleted($requirementsData);
279	279
280	280	if (!$continueWithSubscription) {
281		- header('Location: ' . api_get_path(WEB_CODE_PATH) . 'auth/courses.php');
	281	+ header('Location: '.api_get_path(WEB_CODE_PATH).'auth/courses.php');
282	282	exit;
283	283	}
284	284	}
		@@ -296,16 +296,16 @@ discard block
		block discarded – undo
296	296
297	297	if ($count <= 0) {
298	298	// no course in session -> return to catalog
299		- $url = api_get_path(WEB_CODE_PATH) . 'auth/courses.php';
	299	+ $url = api_get_path(WEB_CODE_PATH).'auth/courses.php';
300	300	} elseif ($count == 1) {
301	301	// only one course, so redirect directly to this course
302	302	foreach ($coursesList as $course) {
303		- $url = api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . intval($_GET['session_id']);
	303	+ $url = api_get_path(WEB_COURSE_PATH).$course['directory'].'/index.php?id_session='.intval($_GET['session_id']);
304	304	}
305	305	} else {
306		- $url = api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . intval($_GET['session_id']);
	306	+ $url = api_get_path(WEB_CODE_PATH).'session/index.php?session_id='.intval($_GET['session_id']);
307	307	}
308		- header('Location: ' . $url);
	308	+ header('Location: '.$url);
309	309	exit;
310	310	}
311	311	//else show error message?

		@@ -41,7 +41,7 @@
		block discarded – undo
41	41
42	42	$msg .= '<div class="well_login">';
43	43	$msg .= $form->return_form();
44		- $msg .='</div>';
	44	+ $msg .= '</div>';
45	45	if (api_is_cas_activated()) {
46	46	$msg .= "</div>";
47	47	}

		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	'client_id' => $this->appId,
100	100	'redirect_uri' => $this->redirectUrl,
101	101	'state' => $this->state,
102		- 'sdk' => 'php-sdk-' . FacebookRequest::VERSION,
	102	+ 'sdk' => 'php-sdk-'.FacebookRequest::VERSION,
103	103	'scope' => implode(',', $scope)
104	104	);
105	105
		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	$params['display'] = 'popup';
109	109	}
110	110
111		- return 'https://www.facebook.com/' . $version . '/dialog/oauth?' .
	111	+ return 'https://www.facebook.com/'.$version.'/dialog/oauth?'.
112	112	http_build_query($params, null, '&');
113	113	}
114	114
		@@ -129,11 +129,11 @@ discard block
		block discarded – undo
129	129	'client_id' => $this->appId,
130	130	'redirect_uri' => $this->redirectUrl,
131	131	'state' => $this->state,
132		- 'sdk' => 'php-sdk-' . FacebookRequest::VERSION,
	132	+ 'sdk' => 'php-sdk-'.FacebookRequest::VERSION,
133	133	'auth_type' => 'rerequest',
134	134	'scope' => implode(',', $scope)
135	135	);
136		- return 'https://www.facebook.com/' . $version . '/dialog/oauth?' .
	136	+ return 'https://www.facebook.com/'.$version.'/dialog/oauth?'.
137	137	http_build_query($params, null, '&');
138	138	}
139	139
		@@ -159,7 +159,7 @@ discard block
		block discarded – undo
159	159	'next' => $next,
160	160	'access_token' => $session->getToken()
161	161	);
162		- return 'https://www.facebook.com/logout.php?' . http_build_query($params, null, '&');
	162	+ return 'https://www.facebook.com/logout.php?'.http_build_query($params, null, '&');
163	163	}
164	164
165	165	/**
		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	'Session not active, could not store state.', 720
235	235	);
236	236	}
237		- $_SESSION[$this->sessionPrefix . 'state'] = $state;
	237	+ $_SESSION[$this->sessionPrefix.'state'] = $state;
238	238	}
239	239
240	240	/**
		@@ -255,8 +255,8 @@ discard block
		block discarded – undo
255	255	'Session not active, could not load state.', 721
256	256	);
257	257	}
258		- if (isset($_SESSION[$this->sessionPrefix . 'state'])) {
259		- $this->state = $_SESSION[$this->sessionPrefix . 'state'];
	258	+ if (isset($_SESSION[$this->sessionPrefix.'state'])) {
	259	+ $this->state = $_SESSION[$this->sessionPrefix.'state'];
260	260	return $this->state;
261	261	}
262	262	return null;
		@@ -293,7 +293,7 @@ discard block
		block discarded – undo
293	293	if ($fp !== FALSE) {
294	294	$buf = fread($fp, $bytes);
295	295	fclose($fp);
296		- if($buf !== FALSE) {
	296	+ if ($buf !== FALSE) {
297	297	return bin2hex($buf);
298	298	}
299	299	}

		@@ -189,7 +189,7 @@
		block discarded – undo
189	189	$url = parse_url($this->responseData->paging->$direction);
190	190	parse_str($url['query'], $params);
191	191
192		- if (isset($params['type']) && strpos($this->request->getPath(), $params['type']) !== false){
	192	+ if (isset($params['type']) && strpos($this->request->getPath(), $params['type']) !== false) {
193	193	unset($params['type']);
194	194	}
195	195	return new FacebookRequest(

		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	CURLOPT_HEADER => true, // Enable header processing
178	178	CURLOPT_SSL_VERIFYHOST => 2,
179	179	CURLOPT_SSL_VERIFYPEER => true,
180		- CURLOPT_CAINFO => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem',
	180	+ CURLOPT_CAINFO => __DIR__.'/certs/DigiCertHighAssuranceEVRootCA.pem',
181	181	);
182	182
183	183	if ($method !== "GET") {
		@@ -236,7 +236,7 @@ discard block
		block discarded – undo
236	236	$return = array();
237	237
238	238	foreach ($this->requestHeaders as $key => $value) {
239		- $return[] = $key . ': ' . $value;
	239	+ $return[] = $key.': '.$value;
240	240	}
241	241
242	242	return $return;
		@@ -300,7 +300,7 @@ discard block
		block discarded – undo
300	300	$headerSize = self::$facebookCurl->getinfo(CURLINFO_HEADER_SIZE);
301	301	// This corrects a Curl bug where header size does not account
302	302	// for additional Proxy headers.
303		- if ( self::needsCurlProxyFix() ) {
	303	+ if (self::needsCurlProxyFix()) {
304	304	// Additional way to calculate the request body size.
305	305	if (preg_match('/Content-Length: (\d+)/', $this->rawResponse, $m)) {
306	306	$headerSize = mb_strlen($this->rawResponse) - $m[1];

		@@ -2,9 +2,9 @@ discard block
		block discarded – undo
2	2	/* For licensing terms, see /license.txt */
3	3
4	4	require_once dirname(__FILE__).'/../../inc/global.inc.php';
5		-$url = api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
	5	+$url = api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
6	6
7		-if (! isset($_SESSION['conditional_login']['uid']))
	7	+if (!isset($_SESSION['conditional_login']['uid']))
8	8	die("Not Authorised");
9	9	?>
10	10	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	</body>
21	21	</html>
22	22	<?php
23		-if (isset($_POST['submit'])){
	23	+if (isset($_POST['submit'])) {
24	24	$u = api_get_user_info($_SESSION['conditional_login']['uid']);
25	25	$u['phone'] = $_POST['phone_number'];
26	26	$password = null; // we don't want to change the password

		@@ -54,16 +54,16 @@ discard block
		block discarded – undo
54	54	}
55	55	$course_info = api_get_course_info_by_id($result['c_id']);
56	56	$course_image = '<img src="'.$course_info['course_image_large'].'">';
57		- $dates .= '<li><a href="#'.$login.'">' . api_convert_and_format_date($login, DATE_FORMAT_SHORT) . '</a></li>';
	57	+ $dates .= '<li><a href="#'.$login.'">'.api_convert_and_format_date($login, DATE_FORMAT_SHORT).'</a></li>';
58	58	$issues .= '<li id ="'.$login.'">';
59	59	$issues .= '<div class="img-course">'.$course_image.'</div>';
60	60
61	61	$issues .= '<div class="text-course">';
62		- $issues .= '<p>' . sprintf(
	62	+ $issues .= '<p>'.sprintf(
63	63	get_lang('YouHaveEnteredTheCourseXInY'),
64		- '" '. $courseInfo['name'] .' "',
	64	+ '" '.$courseInfo['name'].' "',
65	65	api_convert_and_format_date($login, DATE_TIME_FORMAT_LONG)
66		- ) . '</p>';
	66	+ ).'</p>';
67	67	$issues .= '</div>';
68	68	$issues .= '</li>';
69	69	$count++;
		@@ -82,8 +82,8 @@ discard block
		block discarded – undo
82	82	$content .= '<div class="row">';
83	83	$content .= '<div class="col-md-12">';
84	84	$content .= '<div id="my_timeline">';
85		- $content .= '<ul id="dates">' . $dates . '</ul>';
86		- $content .= '<ul id="issues">' . $issues . '</ul>';
	85	+ $content .= '<ul id="dates">'.$dates.'</ul>';
	86	+ $content .= '<ul id="issues">'.$issues.'</ul>';
87	87	$content .= '<div id="grad_left"></div>';
88	88	$content .= '<div id="grad_right"></div>';
89	89	$content .= '<a href="#" id="prev"></a>';

		@@ -157,8 +157,8 @@
		block discarded – undo
157	157	*/
158	158	public function getRawSignedRequestFromCookie()
159	159	{
160		- if (isset($_COOKIE['fbsr_' . $this->appId])) {
161		- return $_COOKIE['fbsr_' . $this->appId];
	160	+ if (isset($_COOKIE['fbsr_'.$this->appId])) {
	161	+ return $_COOKIE['fbsr_'.$this->appId];
162	162	}
163	163	return null;
164	164	}

		@@ -108,11 +108,11 @@
		block discarded – undo
108	108	$options = array('body' => $parameters);
109	109	}
110	110
111		- $options['verify'] = __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem';
	111	+ $options['verify'] = __DIR__.'/certs/DigiCertHighAssuranceEVRootCA.pem';
112	112
113	113	$request = self::$guzzleClient->createRequest($method, $url, $options);
114	114
115		- foreach($this->requestHeaders as $k => $v) {
	115	+ foreach ($this->requestHeaders as $k => $v) {
116	116	$request->setHeader($k, $v);
117	117	}
118	118

chamilo / chamilo-lms

Pull Request — 1.11.x (#1262)

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch