LegacyController::classicAction() - Code Metrics - Inspection of "Fix template" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 81699d...a5d7cd )

by Julito

created 2017-01-02 14:39 UTC

LegacyController::classicAction() C

↳ Parent: LegacyController

Complexity

Conditions	9
Paths	49

Size

Total Lines	80
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	42
nc	49
nop	3
dl	0
loc	80
rs	5.6205
c	1
b	0
f	0

How to fix Long Method

<?php
/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CourseBundle\Controller\ToolBaseController;
use Doctrine\DBAL\Connection;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Chamilo\CoreBundle\Framework\Container;
use Display;

/**
 * Class LegacyController
 * Manages the chamilo pages starting with Display::display_header and $tpl = new Template();
 * @package Chamilo\CoreBundle\Controller
 * @author Julio Montoya <[email protected]>
 */
class LegacyController extends ToolBaseController
{
    public $section;

    private function setContainerValuesToLegacy()
    {
          /** @var Connection $dbConnection */
        $dbConnection = $this->container->get('database_connection');
        $em = $this->get('kernel')->getContainer()->get('doctrine.orm.entity_manager');

        $database = new \Database($dbConnection, array());

        $database->setConnection($dbConnection);
        $database->setManager($em);
        Container::$container = $this->container;
        Container::$dataDir = $this->container->get('kernel')->getDataDir();
        Container::$courseDir = $this->container->get('kernel')->getDataDir();
        $this->container->get('twig')->addGlobal('api_get_cidreq', api_get_cidreq());
    }

    /**
     * Handles all request in old legacy files inside 'main/' folder
     * @param string $name
     * @param Request $request
     * @return Response
     */
    public function classicAction($name, Request $request, $folder = 'main')
    {
        // get.
        $_GET = $request->query->all();
        // post.
        $_POST = $request->request->all();
        $rootDir = $this->get('kernel')->getRealRootDir();
        $mainPath = $rootDir.$folder.'/';
        $fileToLoad = $mainPath.$name;

        // Setting legacy values inside the container
        $this->setContainerValuesToLegacy();

        if (is_file($fileToLoad) &&
            \Security::check_abs_path($fileToLoad, $mainPath)
        ) {
            /**
             * Some legacy Chamilo files still use this variables directly,
             * instead of using a function.
            **/
            $is_allowed_in_course = api_is_allowed_in_course();
            $is_courseAdmin = api_is_course_admin();
            $is_platformAdmin = api_is_platform_admin();
            $toolNameFromFile = basename(dirname($fileToLoad));
            $charset = 'UTF-8';
            // Default values
            $_course = api_get_course_info();
            $_user = api_get_user_info();
            $_cid = api_get_course_id();
            $debug = $this->container->get('kernel')->getEnvironment() == 'dev' ? true : false;

            // Loading legacy file
            ob_start();
            require_once $fileToLoad;
            $out = ob_get_contents();
            ob_end_clean();

            // No browser cache when executing an exercise.
            if ($name == 'exercise/exercise_submit.php') {
                $responseHeaders = array(
                    'cache-control' => 'no-store, no-cache, must-revalidate'
                );
            }

            // Loading code to be added
            $js = isset($htmlHeadXtra) ? $htmlHeadXtra : array();


            // Loading legacy breadcrumb $interbreadcrumb
            $interbreadcrumb = isset($interbreadcrumb) ? $interbreadcrumb : null;


            // We change the layout based in this variable
            // This could be changed on the fly by a legacy script.
            $template = Container::$legacyTemplate;
            $params = [
                'legacy_breadcrumb' => $interbreadcrumb,
                'js' => $js
            ];

            // This means the page comes from legacy use Display::display_header
            if (!empty($out)) {
                $params['content'] = $out;
            } else {
                // This means the page comes from legacy use of $tpl = new Template();
                $legacyParams = \Template::$params;
                if (!empty($legacyParams)) {
                    $params = array_merge($legacyParams, $params);
                }
            }

            // Render using Symfony2 layouts see folder:
            // src/Chamilo/ThemeBundle/Resources/views/Layout
            return $this->render(
                $template,
                $params
            );
        } else {
            // Found does not exist
            throw new NotFoundHttpException();
        }
    }

    public function pluginAction($name, Request $request)
    {
        return $this->classicAction($name, $request, 'plugin');
    }
}


1			<?php
2			/* For licensing terms, see /license.txt */
3
4			namespace Chamilo\CoreBundle\Controller;
5
6			use Chamilo\CourseBundle\Controller\ToolBaseController;
7			use Doctrine\DBAL\Connection;
8			use Symfony\Component\HttpFoundation\Response;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
11			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
12			use Chamilo\CoreBundle\Framework\Container;
13			use Display;
14
15			/**
16			* Class LegacyController
17			* Manages the chamilo pages starting with Display::display_header and $tpl = new Template();
18			* @package Chamilo\CoreBundle\Controller
19			* @author Julio Montoya <[email protected]>
20			*/
21			class LegacyController extends ToolBaseController
22			{
23			public $section;
24
25			private function setContainerValuesToLegacy()
26			{
27			/** @var Connection $dbConnection */
28			$dbConnection = $this->container->get('database_connection');
29			$em = $this->get('kernel')->getContainer()->get('doctrine.orm.entity_manager');
30
31			$database = new \Database($dbConnection, array());
32
33			$database->setConnection($dbConnection);
34			$database->setManager($em);
35			Container::$container = $this->container;
36			Container::$dataDir = $this->container->get('kernel')->getDataDir();
37			Container::$courseDir = $this->container->get('kernel')->getDataDir();
38			$this->container->get('twig')->addGlobal('api_get_cidreq', api_get_cidreq());
39			}
40
41			/**
42			* Handles all request in old legacy files inside 'main/' folder
43			* @param string $name
44			* @param Request $request
45			* @return Response
46			*/
47			public function classicAction($name, Request $request, $folder = 'main')
48			{
49			// get.
50			$_GET = $request->query->all();
51			// post.
52			$_POST = $request->request->all();
53			$rootDir = $this->get('kernel')->getRealRootDir();
54			$mainPath = $rootDir.$folder.'/';
55			$fileToLoad = $mainPath.$name;
56
57			// Setting legacy values inside the container
58			$this->setContainerValuesToLegacy();
59
60			if (is_file($fileToLoad) &&
61			\Security::check_abs_path($fileToLoad, $mainPath)
62			) {
63			/**
64			* Some legacy Chamilo files still use this variables directly,
65			* instead of using a function.
66			**/
67			$is_allowed_in_course = api_is_allowed_in_course();
68			$is_courseAdmin = api_is_course_admin();
69			$is_platformAdmin = api_is_platform_admin();
70			$toolNameFromFile = basename(dirname($fileToLoad));
71			$charset = 'UTF-8';
72			// Default values
73			$_course = api_get_course_info();
74			$_user = api_get_user_info();
75			$_cid = api_get_course_id();
76			$debug = $this->container->get('kernel')->getEnvironment() == 'dev' ? true : false;
77
78			// Loading legacy file
79			ob_start();
80			require_once $fileToLoad;
81			$out = ob_get_contents();
82			ob_end_clean();
83
84			// No browser cache when executing an exercise.
85			if ($name == 'exercise/exercise_submit.php') {
86			$responseHeaders = array(
87			'cache-control' => 'no-store, no-cache, must-revalidate'
88			);
89			}
90
91			// Loading code to be added
92			$js = isset($htmlHeadXtra) ? $htmlHeadXtra : array();
			0 ignored issues – show Bug introduced 2016-03-01 01:58 UTC by Report Bug Copy Issue Report The variable `$htmlHeadXtra` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
93
94			// Loading legacy breadcrumb $interbreadcrumb
95			$interbreadcrumb = isset($interbreadcrumb) ? $interbreadcrumb : null;
			0 ignored issues – show Bug introduced 2016-03-01 01:58 UTC by Report Bug Copy Issue Report The variable `$interbreadcrumb` seems only to be defined at a later point. As such the call to `isset()` seems to always evaluate to `false`. This check marks calls to `isset(...)` or `empty(...)` that are found before the variable itself is defined. These will always have the same result. This is likely the result of code being shifted around. Consider removing these calls. Loading history...
96
97			// We change the layout based in this variable
98			// This could be changed on the fly by a legacy script.
99			$template = Container::$legacyTemplate;
100			$params = [
101			'legacy_breadcrumb' => $interbreadcrumb,
102			'js' => $js
103			];
104
105			// This means the page comes from legacy use Display::display_header
106			if (!empty($out)) {
107			$params['content'] = $out;
108			} else {
109			// This means the page comes from legacy use of $tpl = new Template();
110			$legacyParams = \Template::$params;
111			if (!empty($legacyParams)) {
112			$params = array_merge($legacyParams, $params);
113			}
114			}
115
116			// Render using Symfony2 layouts see folder:
117			// src/Chamilo/ThemeBundle/Resources/views/Layout
118			return $this->render(
119			$template,
120			$params
121			);
122			} else {
123			// Found does not exist
124			throw new NotFoundHttpException();
125			}
126			}
127
128			public function pluginAction($name, Request $request)
129			{
130			return $this->classicAction($name, $request, 'plugin');
131			}
132			}
133

chamilo / chamilo-lms

Push — master ( 81699d...a5d7cd )

LegacyController::classicAction() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like