CreateDropboxFileAction::buildLinks() - Code Metrics - Inspection of "Dropbox: Restore dropbox tool #6757 - refs #6757" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6795)

unknown

created 2025-09-23 17:36 UTC

CreateDropboxFileAction::buildLinks() C

↳ Parent: CreateDropboxFileAction

Complexity

Conditions	16
Paths	6

Size

Total Lines	36
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	16
eloc	24
c	1
b	0
f	0
nc	6
nop	4
dl	0
loc	36
rs	5.5666

How to fix Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller\Api;

use Chamilo\CoreBundle\Entity\ResourceLink;
use Chamilo\CoreBundle\Helpers\UserHelper;
use Chamilo\CoreBundle\Repository\Node\CourseRepository;
use Chamilo\CoreBundle\Repository\SessionRepository;
use Chamilo\CourseBundle\Entity\CDropboxFile;
use Chamilo\CourseBundle\Entity\CDropboxPerson;
use Chamilo\CourseBundle\Entity\CDropboxPost;
use Chamilo\CourseBundle\Repository\CDropboxFileRepository;
use DateTime;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Attribute\AsController;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;

#[AsController]
final class CreateDropboxFileAction
{
    public function __invoke(
        Request $request,
        CDropboxFileRepository $repo,
        CourseRepository $courseRepo,
        SessionRepository $sessionRepo,
        EntityManagerInterface $em,
        UserHelper $userHelper
    ): JsonResponse {

        $cid = (int) $request->query->get('cid', 0);
        $sid = (int) $request->query->get('sid', 0);
        $gid = (int) $request->query->get('gid', 0);
        if ($cid <= 0) {
            throw new BadRequestHttpException('Missing or invalid "cid".');
        }
        $user = $userHelper->getCurrent();
        if (!$user) {
            throw new UnauthorizedHttpException('', 'Unauthorized.');
        }

        /** @var UploadedFile|null $file */
        $file = $request->files->get('uploadFile');
        if (!$file) {
            foreach ($request->files as $val) {
                if ($val instanceof UploadedFile) {
                    $file = $val;
                    $request->files->set('uploadFile', $val);
                    break;
                }
            }
        }
        if (!$file) {
            throw new BadRequestHttpException('"uploadFile" is required');
        }

        $parentId = (int) $request->request->get('parentResourceNodeId', 0);
        if ($parentId === 0) {
            $course = $courseRepo->find($cid);
            $parentId = $course?->getResourceNode()?->getId() ?? 0;
            if ($parentId === 0) {
                throw new BadRequestHttpException('parentResourceNodeId (categoryId) is required');
            }
        }

        $description = (string) $request->request->get('description', '');
        $categoryId  = (int) $request->request->get('categoryId', 0);
        /** @var string[] $tokens */
        $tokens      = (array) ($request->request->all('recipients') ?? []);

        $original  = $file->getClientOriginalName() ?: 'upload.bin';
        $candidate = $original;
        $i = 1;
        while ($repo->findOneBy(['filename' => $candidate])) {
            $pi   = pathinfo($original);
            $name = $pi['filename'] ?? 'file';
            $ext  = isset($pi['extension']) ? '.'.$pi['extension'] : '';
            $candidate = $name.'_'.$i.$ext;
            $i++;
        }

        $now = new DateTime();
        $e = new CDropboxFile();
        $e->setFiletype('file');
        $e->setParentResourceNode($parentId);
        $e->setUploadFile($file);

        $e->setCId($cid);
        $e->setSessionId($sid);
        $e->setUploaderId($user->getId());
        $e->setTitle($candidate);
        $e->setFilename($candidate);
        $e->setFilesize((int) ($file->getSize() ?: 0));
        $e->setDescription($description);
        $e->setAuthor((string) $user->getFullName());
        $e->setUploadDate($now);
        $e->setLastUploadDate($now);
        $e->setCatId($categoryId);

        $e->setResourceLinkArray($this->buildLinks($tokens, $cid, $sid, $gid));

        $em->persist($e);
        $em->flush();

        $up = new CDropboxPerson();
        $up->setCId($cid);
        $up->setUserId($user->getId());
        $up->setFileId($e->getIid());
        $em->persist($up);

        $destUserIds = $this->extractUserIdsFromTokens($tokens, $user->getId());
        if (!$destUserIds) {

            $destUserIds = [$user->getId()];
        }

        foreach ($destUserIds as $destUid) {
            $post = new CDropboxPost();
            $post->setCId($cid);
            $post->setSessionId($sid ?? 0);
            $post->setFileId($e->getIid());
            $post->setDestUserId($destUid);
            $post->setCatId($categoryId);
            $post->setFeedbackDate(new DateTime());
            $em->persist($post);

            if ($destUid !== $user->getId()) {
                $p = new CDropboxPerson();
                $p->setCId($cid);
                $p->setUserId($destUid);
                $p->setFileId($e->getIid());
                $em->persist($p);
            }
        }

        $em->flush();

        return new JsonResponse([
            'ok'         => true,
            'iid'        => (int) $e->getIid(),
            'title'      => $e->getTitle(),
            'filename'   => $e->getFilename(),
            'filesize'   => $e->getFilesize(),
            'categoryId' => $e->getCatId(),
            'message'    => 'File uploaded successfully',
        ], 201);
    }

    private function buildLinks(array $tokens, int $cid, int $sid, int $gid): array
    {
        $tokens = array_values(array_filter(array_map('strval', $tokens)));

        if (empty($tokens) || (count($tokens) === 1 && strtolower($tokens[0]) === 'self')) {
            return [[
                'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
                'cid' => $cid,
                'sid' => $sid ?: null,
                'gid' => $gid ?: null,
            ]];
        }

        $out = [];
        foreach ($tokens as $t) {
            if (preg_match('/^USER:(\d+)$/i', $t, $m)) {
                $out[] = [
                    'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
                    'cid' => $cid, 'sid' => $sid ?: null, 'uid' => (int) $m[1],
                ];
            } elseif (preg_match('/^GROUP:(\d+)$/i', $t, $m)) {
                $out[] = [
                    'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
                    'cid' => $cid, 'sid' => $sid ?: null, 'gid' => (int) $m[1],
                ];
            } elseif (preg_match('/^user_(\d+)$/i', $t, $m)) {
                $out[] = [
                    'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
                    'cid' => $cid, 'sid' => $sid ?: null, 'uid' => (int) $m[1],
                ];
            }
        }

        return $out ?: [[
            'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
            'cid' => $cid, 'sid' => $sid ?: null, 'gid' => $gid ?: null,
        ]];
    }

    private function extractUserIdsFromTokens(array $tokens, int $uploaderId): array
    {
        $ids = [];
        foreach ($tokens as $t) {
            $s = (string) $t;
            if (strtolower($s) === 'self') {
                $ids[] = $uploaderId;
            } elseif (preg_match('/^USER:(\d+)$/i', $s, $m)) {
                $ids[] = (int) $m[1];
            } elseif (preg_match('/^user_(\d+)$/i', $s, $m)) {
                $ids[] = (int) $m[1];
            }
        }
        return array_values(array_unique(array_filter($ids, fn($v) => (int)$v > 0)));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Controller\Api;
8
9			use Chamilo\CoreBundle\Entity\ResourceLink;
10			use Chamilo\CoreBundle\Helpers\UserHelper;
11			use Chamilo\CoreBundle\Repository\Node\CourseRepository;
12			use Chamilo\CoreBundle\Repository\SessionRepository;
13			use Chamilo\CourseBundle\Entity\CDropboxFile;
14			use Chamilo\CourseBundle\Entity\CDropboxPerson;
15			use Chamilo\CourseBundle\Entity\CDropboxPost;
16			use Chamilo\CourseBundle\Repository\CDropboxFileRepository;
17			use DateTime;
18			use Doctrine\ORM\EntityManagerInterface;
19			use Symfony\Component\HttpFoundation\File\UploadedFile;
20			use Symfony\Component\HttpFoundation\JsonResponse;
21			use Symfony\Component\HttpFoundation\Request;
22			use Symfony\Component\HttpKernel\Attribute\AsController;
23			use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
24			use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
25
26			#[AsController]
27			final class CreateDropboxFileAction
28			{
29			public function __invoke(
30			Request $request,
31			CDropboxFileRepository $repo,
32			CourseRepository $courseRepo,
33			SessionRepository $sessionRepo,
34			EntityManagerInterface $em,
35			UserHelper $userHelper
36			): JsonResponse {
37
38			$cid = (int) $request->query->get('cid', 0);
39			$sid = (int) $request->query->get('sid', 0);
40			$gid = (int) $request->query->get('gid', 0);
41			if ($cid <= 0) {
42			throw new BadRequestHttpException('Missing or invalid "cid".');
43			}
44			$user = $userHelper->getCurrent();
45			if (!$user) {
46			throw new UnauthorizedHttpException('', 'Unauthorized.');
47			}
48
49			/** @var UploadedFile\|null $file */
50			$file = $request->files->get('uploadFile');
51			if (!$file) {
52			foreach ($request->files as $val) {
53			if ($val instanceof UploadedFile) {
54			$file = $val;
55			$request->files->set('uploadFile', $val);
56			break;
57			}
58			}
59			}
60			if (!$file) {
61			throw new BadRequestHttpException('"uploadFile" is required');
62			}
63
64			$parentId = (int) $request->request->get('parentResourceNodeId', 0);
65			if ($parentId === 0) {
66			$course = $courseRepo->find($cid);
67			$parentId = $course?->getResourceNode()?->getId() ?? 0;
68			if ($parentId === 0) {
69			throw new BadRequestHttpException('parentResourceNodeId (categoryId) is required');
70			}
71			}
72
73			$description = (string) $request->request->get('description', '');
74			$categoryId = (int) $request->request->get('categoryId', 0);
75			/** @var string[] $tokens */
76			$tokens = (array) ($request->request->all('recipients') ?? []);
77
78			$original = $file->getClientOriginalName() ?: 'upload.bin';
79			$candidate = $original;
80			$i = 1;
81			while ($repo->findOneBy(['filename' => $candidate])) {
82			$pi = pathinfo($original);
83			$name = $pi['filename'] ?? 'file';
84			$ext = isset($pi['extension']) ? '.'.$pi['extension'] : '';
85			$candidate = $name.'_'.$i.$ext;
86			$i++;
87			}
88
89			$now = new DateTime();
90			$e = new CDropboxFile();
91			$e->setFiletype('file');
92			$e->setParentResourceNode($parentId);
93			$e->setUploadFile($file);
94
95			$e->setCId($cid);
96			$e->setSessionId($sid);
97			$e->setUploaderId($user->getId());
98			$e->setTitle($candidate);
99			$e->setFilename($candidate);
100			$e->setFilesize((int) ($file->getSize() ?: 0));
101			$e->setDescription($description);
102			$e->setAuthor((string) $user->getFullName());
103			$e->setUploadDate($now);
104			$e->setLastUploadDate($now);
105			$e->setCatId($categoryId);
106
107			$e->setResourceLinkArray($this->buildLinks($tokens, $cid, $sid, $gid));
108
109			$em->persist($e);
110			$em->flush();
111
112			$up = new CDropboxPerson();
113			$up->setCId($cid);
114			$up->setUserId($user->getId());
115			$up->setFileId($e->getIid());
116			$em->persist($up);
117
118			$destUserIds = $this->extractUserIdsFromTokens($tokens, $user->getId());
119			if (!$destUserIds) {
			0 ignored issues – show Bug Best Practice introduced 2025-09-23 17:39 UTC by Report Bug Copy Issue Report The expression `$destUserIds` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
120			$destUserIds = [$user->getId()];
121			}
122
123			foreach ($destUserIds as $destUid) {
124			$post = new CDropboxPost();
125			$post->setCId($cid);
126			$post->setSessionId($sid ?? 0);
127			$post->setFileId($e->getIid());
128			$post->setDestUserId($destUid);
129			$post->setCatId($categoryId);
130			$post->setFeedbackDate(new DateTime());
131			$em->persist($post);
132
133			if ($destUid !== $user->getId()) {
134			$p = new CDropboxPerson();
135			$p->setCId($cid);
136			$p->setUserId($destUid);
137			$p->setFileId($e->getIid());
138			$em->persist($p);
139			}
140			}
141
142			$em->flush();
143
144			return new JsonResponse([
145			'ok' => true,
146			'iid' => (int) $e->getIid(),
147			'title' => $e->getTitle(),
148			'filename' => $e->getFilename(),
149			'filesize' => $e->getFilesize(),
150			'categoryId' => $e->getCatId(),
151			'message' => 'File uploaded successfully',
152			], 201);
153			}
154
155			private function buildLinks(array $tokens, int $cid, int $sid, int $gid): array
156			{
157			$tokens = array_values(array_filter(array_map('strval', $tokens)));
158
159			if (empty($tokens) \|\| (count($tokens) === 1 && strtolower($tokens[0]) === 'self')) {
160			return [[
161			'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
162			'cid' => $cid,
163			'sid' => $sid ?: null,
164			'gid' => $gid ?: null,
165			]];
166			}
167
168			$out = [];
169			foreach ($tokens as $t) {
170			if (preg_match('/^USER:(\d+)$/i', $t, $m)) {
171			$out[] = [
172			'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
173			'cid' => $cid, 'sid' => $sid ?: null, 'uid' => (int) $m[1],
174			];
175			} elseif (preg_match('/^GROUP:(\d+)$/i', $t, $m)) {
176			$out[] = [
177			'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
178			'cid' => $cid, 'sid' => $sid ?: null, 'gid' => (int) $m[1],
179			];
180			} elseif (preg_match('/^user_(\d+)$/i', $t, $m)) {
181			$out[] = [
182			'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
183			'cid' => $cid, 'sid' => $sid ?: null, 'uid' => (int) $m[1],
184			];
185			}
186			}
187
188			return $out ?: [[
189			'visibility' => ResourceLink::VISIBILITY_PUBLISHED,
190			'cid' => $cid, 'sid' => $sid ?: null, 'gid' => $gid ?: null,
191			]];
192			}
193
194			private function extractUserIdsFromTokens(array $tokens, int $uploaderId): array
195			{
196			$ids = [];
197			foreach ($tokens as $t) {
198			$s = (string) $t;
199			if (strtolower($s) === 'self') {
200			$ids[] = $uploaderId;
201			} elseif (preg_match('/^USER:(\d+)$/i', $s, $m)) {
202			$ids[] = (int) $m[1];
203			} elseif (preg_match('/^user_(\d+)$/i', $s, $m)) {
204			$ids[] = (int) $m[1];
205			}
206			}
207			return array_values(array_unique(array_filter($ids, fn($v) => (int)$v > 0)));
208			}
209			}
210

chamilo / chamilo-lms

Pull Request — master (#6795)

CreateDropboxFileAction::buildLinks() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like