AdminController::listResourcesInfo() - Code Metrics - Inspection of "Admin: Add content type items report - refs #5731" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6243)

unknown

created 2025-04-20 05:45 UTC

AdminController::listResourcesInfo() B

↳ Parent: AdminController

Complexity

Conditions	11
Paths	2

Size

Total Lines	60
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	43
nc	2
nop	3
dl	0
loc	60
rs	7.3166
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller\Admin;

use Chamilo\CoreBundle\Controller\BaseController;
use Chamilo\CoreBundle\Entity\ResourceLink;
use Chamilo\CoreBundle\Entity\ResourceType;
use Chamilo\CoreBundle\Repository\ResourceFileRepository;
use Chamilo\CoreBundle\Repository\ResourceNodeRepository;
use Chamilo\CoreBundle\ServiceHelper\AccessUrlHelper;
use Chamilo\CoreBundle\Settings\SettingsManager;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Http\Attribute\IsGranted;

#[Route('/admin')]
class AdminController extends BaseController
{
    private const ITEMS_PER_PAGE = 50;

    public function __construct(
        private readonly ResourceNodeRepository $resourceNodeRepository,
        private readonly AccessUrlHelper $accessUrlHelper
    ) {}

    #[IsGranted('ROLE_ADMIN')]
    #[Route('/register-campus', name: 'admin_register_campus', methods: ['POST'])]
    public function registerCampus(Request $request, SettingsManager $settingsManager): Response
    {
        $requestData = $request->toArray();
        $doNotListCampus = (bool) $requestData['donotlistcampus'];

        $settingsManager->setUrl($this->accessUrlHelper->getCurrent());
        $settingsManager->updateSetting('platform.registered', 'true');

        $settingsManager->updateSetting(
            'platform.donotlistcampus',
            $doNotListCampus ? 'true' : 'false'
        );

        return new Response('', Response::HTTP_NO_CONTENT);
    }

    #[IsGranted('ROLE_ADMIN')]
    #[Route('/files_info', name: 'admin_files_info', methods: ['GET'])]
    public function listFilesInfo(Request $request, ResourceFileRepository $resourceFileRepository): Response
    {
        $page = $request->query->getInt('page', 1);
        $search = $request->query->get('search', '');
        $offset = ($page - 1) * self::ITEMS_PER_PAGE;

        $files = $resourceFileRepository->searchFiles($search, $offset, self::ITEMS_PER_PAGE);
        $totalItems = $resourceFileRepository->countFiles($search);
        $totalPages = $totalItems > 0 ? ceil($totalItems / self::ITEMS_PER_PAGE) : 1;

        $fileUrls = [];
        $filePaths = [];
        foreach ($files as $file) {
            $resourceNode = $file->getResourceNode();
            if ($resourceNode) {
                $fileUrls[$file->getId()] = $this->resourceNodeRepository->getResourceFileUrl($resourceNode);
                $creator = $resourceNode->getCreator();
            } else {
                $fileUrls[$file->getId()] = null;
                $creator = null;
            }
            $filePaths[$file->getId()] = '/upload/resource'.$this->resourceNodeRepository->getFilename($file);
        }

        return $this->render('@ChamiloCore/Admin/files_info.html.twig', [
            'files' => $files,
            'fileUrls' => $fileUrls,
            'filePaths' => $filePaths,
            'totalPages' => $totalPages,
            'currentPage' => $page,
            'search' => $search,
        ]);
    }

    #[IsGranted('ROLE_ADMIN')]
    #[Route('/resources_info', name: 'admin_resources_info', methods: ['GET'])]
    public function listResourcesInfo(Request $request, ResourceNodeRepository $resourceNodeRepo, EntityManagerInterface $em): Response
    {
        $resourceTypeId = $request->query->getInt('type');
        $resourceTypes = $em->getRepository(ResourceType::class)->findAll();

        $courses = [];
        if ($resourceTypeId > 0) {
            $resourceLinks = $em->getRepository(ResourceLink::class)->createQueryBuilder('rl')
                ->join('rl.resourceNode', 'rn')
                ->where('rn.resourceType = :type')
                ->setParameter('type', $resourceTypeId)
                ->getQuery()
                ->getResult();

            $seen = [];
            foreach ($resourceLinks as $link) {
                $course = $link->getCourse();
                $session = $link->getSession();
                $node = $link->getResourceNode();

                if (!$course) {
                    continue;
                }

                $key = $session
                    ? 's'.$session->getId().'-'.$course->getId()
                    : 'c'.$course->getId();

                if (!isset($seen[$key])) {
                    $seen[$key] = [
                        'type' => $session ? 'session' : 'course',
                        'id' => $session ? $session->getId() : $course->getId(),
                        'title' => $session ? $session->getTitle().' - '.$course->getTitle() : $course->getTitle(),
                        'url' => $session
                            ? '/course/'.$course->getId().'/home?sid='.$session->getId()
                            : '/course/'.$course->getId().'/home',
                        'count' => 0,
                        'items' => [],
                        'firstCreatedAt' => $node->getCreatedAt(),
                    ];
                }

                $seen[$key]['count']++;
                $seen[$key]['items'][] = $node->getTitle();

                if ($node->getCreatedAt() < $seen[$key]['firstCreatedAt']) {
                    $seen[$key]['firstCreatedAt'] = $node->getCreatedAt();
                }
            }

            $courses = array_values($seen);
            usort($courses, fn($a, $b) => strnatcasecmp($a['title'], $b['title']));
        }

        return $this->render('@ChamiloCore/Admin/resources_info.html.twig', [
            'resourceTypes' => $resourceTypes,
            'selectedType' => $resourceTypeId,
            'courses' => $courses,
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Controller\Admin;
8
9			use Chamilo\CoreBundle\Controller\BaseController;
10			use Chamilo\CoreBundle\Entity\ResourceLink;
11			use Chamilo\CoreBundle\Entity\ResourceType;
12			use Chamilo\CoreBundle\Repository\ResourceFileRepository;
13			use Chamilo\CoreBundle\Repository\ResourceNodeRepository;
14			use Chamilo\CoreBundle\ServiceHelper\AccessUrlHelper;
15			use Chamilo\CoreBundle\Settings\SettingsManager;
16			use Doctrine\ORM\EntityManagerInterface;
17			use Symfony\Component\HttpFoundation\Request;
18			use Symfony\Component\HttpFoundation\Response;
19			use Symfony\Component\Routing\Annotation\Route;
20			use Symfony\Component\Security\Http\Attribute\IsGranted;
21
22			#[Route('/admin')]
23			class AdminController extends BaseController
24			{
25			private const ITEMS_PER_PAGE = 50;
26
27			public function __construct(
28			private readonly ResourceNodeRepository $resourceNodeRepository,
29			private readonly AccessUrlHelper $accessUrlHelper
30			) {}
31
32			#[IsGranted('ROLE_ADMIN')]
33			#[Route('/register-campus', name: 'admin_register_campus', methods: ['POST'])]
34			public function registerCampus(Request $request, SettingsManager $settingsManager): Response
35			{
36			$requestData = $request->toArray();
37			$doNotListCampus = (bool) $requestData['donotlistcampus'];
38
39			$settingsManager->setUrl($this->accessUrlHelper->getCurrent());
40			$settingsManager->updateSetting('platform.registered', 'true');
41
42			$settingsManager->updateSetting(
43			'platform.donotlistcampus',
44			$doNotListCampus ? 'true' : 'false'
45			);
46
47			return new Response('', Response::HTTP_NO_CONTENT);
48			}
49
50			#[IsGranted('ROLE_ADMIN')]
51			#[Route('/files_info', name: 'admin_files_info', methods: ['GET'])]
52			public function listFilesInfo(Request $request, ResourceFileRepository $resourceFileRepository): Response
53			{
54			$page = $request->query->getInt('page', 1);
55			$search = $request->query->get('search', '');
56			$offset = ($page - 1) * self::ITEMS_PER_PAGE;
57
58			$files = $resourceFileRepository->searchFiles($search, $offset, self::ITEMS_PER_PAGE);
59			$totalItems = $resourceFileRepository->countFiles($search);
60			$totalPages = $totalItems > 0 ? ceil($totalItems / self::ITEMS_PER_PAGE) : 1;
61
62			$fileUrls = [];
63			$filePaths = [];
64			foreach ($files as $file) {
65			$resourceNode = $file->getResourceNode();
66			if ($resourceNode) {
67			$fileUrls[$file->getId()] = $this->resourceNodeRepository->getResourceFileUrl($resourceNode);
68			$creator = $resourceNode->getCreator();
69			} else {
70			$fileUrls[$file->getId()] = null;
71			$creator = null;
72			}
73			$filePaths[$file->getId()] = '/upload/resource'.$this->resourceNodeRepository->getFilename($file);
74			}
75
76			return $this->render('@ChamiloCore/Admin/files_info.html.twig', [
77			'files' => $files,
78			'fileUrls' => $fileUrls,
79			'filePaths' => $filePaths,
80			'totalPages' => $totalPages,
81			'currentPage' => $page,
82			'search' => $search,
83			]);
84			}
85
86			#[IsGranted('ROLE_ADMIN')]
87			#[Route('/resources_info', name: 'admin_resources_info', methods: ['GET'])]
88			public function listResourcesInfo(Request $request, ResourceNodeRepository $resourceNodeRepo, EntityManagerInterface $em): Response
89			{
90			$resourceTypeId = $request->query->getInt('type');
91			$resourceTypes = $em->getRepository(ResourceType::class)->findAll();
92
93			$courses = [];
94			if ($resourceTypeId > 0) {
95			$resourceLinks = $em->getRepository(ResourceLink::class)->createQueryBuilder('rl')
96			->join('rl.resourceNode', 'rn')
97			->where('rn.resourceType = :type')
98			->setParameter('type', $resourceTypeId)
99			->getQuery()
100			->getResult();
101
102			$seen = [];
103			foreach ($resourceLinks as $link) {
104			$course = $link->getCourse();
105			$session = $link->getSession();
106			$node = $link->getResourceNode();
107
108			if (!$course) {
109			continue;
110			}
111
112			$key = $session
113			? 's'.$session->getId().'-'.$course->getId()
114			: 'c'.$course->getId();
115
116			if (!isset($seen[$key])) {
117			$seen[$key] = [
118			'type' => $session ? 'session' : 'course',
119			'id' => $session ? $session->getId() : $course->getId(),
120			'title' => $session ? $session->getTitle().' - '.$course->getTitle() : $course->getTitle(),
121			'url' => $session
122			? '/course/'.$course->getId().'/home?sid='.$session->getId()
123			: '/course/'.$course->getId().'/home',
124			'count' => 0,
125			'items' => [],
126			'firstCreatedAt' => $node->getCreatedAt(),
127			];
128			}
129
130			$seen[$key]['count']++;
131			$seen[$key]['items'][] = $node->getTitle();
132
133			if ($node->getCreatedAt() < $seen[$key]['firstCreatedAt']) {
134			$seen[$key]['firstCreatedAt'] = $node->getCreatedAt();
135			}
136			}
137
138			$courses = array_values($seen);
139			usort($courses, fn($a, $b) => strnatcasecmp($a['title'], $b['title']));
140			}
141
142			return $this->render('@ChamiloCore/Admin/resources_info.html.twig', [
143			'resourceTypes' => $resourceTypes,
144			'selectedType' => $resourceTypeId,
145			'courses' => $courses,
146			]);
147			}
148			}
149

chamilo / chamilo-lms

Pull Request — master (#6243)

AdminController::listResourcesInfo() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like