| Conditions | 5 |
| Paths | 12 |
| Total Lines | 71 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | #[IsGranted('ROLE_ADMIN')] |
||
| 52 | #[Route('/files_info', name: 'admin_files_info', methods: ['GET'])] |
||
| 53 | public function listFilesInfo(Request $request): Response |
||
| 54 | { |
||
| 55 | $page = $request->query->getInt('page', 1); |
||
| 56 | $search = $request->query->get('search', ''); |
||
| 57 | $offset = ($page - 1) * self::ITEMS_PER_PAGE; |
||
| 58 | |||
| 59 | $queryBuilder = $this->entityManager->getRepository(ResourceFile::class)->createQueryBuilder('rf') |
||
| 60 | ->leftJoin('rf.resourceNode', 'rn') |
||
| 61 | ->leftJoin('rn.resourceLinks', 'rl') |
||
| 62 | ->leftJoin('rl.course', 'c') |
||
| 63 | ->leftJoin('rl.user', 'u') |
||
| 64 | ->addSelect('rn', 'rl', 'c', 'u'); |
||
| 65 | |||
| 66 | if ($search) { |
||
| 67 | $queryBuilder->where('rf.title LIKE :search') |
||
| 68 | ->orWhere('rf.originalName LIKE :search') |
||
| 69 | ->orWhere('c.title LIKE :search') |
||
| 70 | ->orWhere('u.username LIKE :search') |
||
| 71 | ->orWhere('rn.uuid LIKE :search') |
||
| 72 | ->setParameter('search', '%' . $search . '%'); |
||
| 73 | } |
||
| 74 | |||
| 75 | $queryBuilder->orderBy('rf.id', 'DESC') |
||
| 76 | ->setFirstResult($offset) |
||
| 77 | ->setMaxResults(self::ITEMS_PER_PAGE); |
||
| 78 | |||
| 79 | $files = $queryBuilder->getQuery()->getResult(); |
||
| 80 | |||
| 81 | $totalItemsQuery = $this->entityManager->getRepository(ResourceFile::class) |
||
| 82 | ->createQueryBuilder('rf') |
||
| 83 | ->leftJoin('rf.resourceNode', 'rn') |
||
| 84 | ->leftJoin('rn.resourceLinks', 'rl') |
||
| 85 | ->leftJoin('rl.course', 'c') |
||
| 86 | ->leftJoin('rl.user', 'u') |
||
| 87 | ->select('COUNT(rf.id)'); |
||
| 88 | |||
| 89 | if ($search) { |
||
| 90 | $totalItemsQuery->where('rf.title LIKE :search') |
||
| 91 | ->orWhere('rf.originalName LIKE :search') |
||
| 92 | ->orWhere('c.title LIKE :search') |
||
| 93 | ->orWhere('u.username LIKE :search') |
||
| 94 | ->orWhere('rn.uuid LIKE :search') |
||
| 95 | ->setParameter('search', '%' . $search . '%'); |
||
| 96 | } |
||
| 97 | |||
| 98 | $totalItems = $totalItemsQuery->getQuery()->getSingleScalarResult(); |
||
| 99 | $totalPages = ceil($totalItems / self::ITEMS_PER_PAGE); |
||
| 100 | |||
| 101 | $fileUrls = []; |
||
| 102 | $filePaths = []; |
||
| 103 | foreach ($files as $file) { |
||
| 104 | $resourceNode = $file->getResourceNode(); |
||
| 105 | if ($resourceNode) { |
||
| 106 | $fileUrls[$file->getId()] = $this->resourceNodeRepository->getResourceFileUrl($resourceNode); |
||
| 107 | $creator = $resourceNode->getCreator(); |
||
| 108 | } else { |
||
| 109 | $fileUrls[$file->getId()] = null; |
||
| 110 | $creator = null; |
||
| 111 | } |
||
| 112 | $filePaths[$file->getId()] = $this->resourceNodeRepository->getFilename($file); |
||
| 113 | } |
||
| 114 | |||
| 115 | return $this->render('@ChamiloCore/Admin/files_info.html.twig', [ |
||
| 116 | 'files' => $files, |
||
| 117 | 'fileUrls' => $fileUrls, |
||
| 118 | 'filePaths' => $filePaths, |
||
| 119 | 'totalPages' => $totalPages, |
||
| 120 | 'currentPage' => $page, |
||
| 121 | 'search' => $search, |
||
| 122 | ]); |
||
| 125 |