Completed
Push — 1.11.x ( 0609ac...d3f3e5 )
by José
161:19 queued 122:35
created
main/auth/cas/logout.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,5 +9,5 @@
 block discarded – undo
9 9
 require_once('authcas.php');
10 10
 global $cas_auth_ver, $cas_auth_server, $cas_auth_port, $cas_auth_uri;
11 11
 
12
-phpCAS::client($cas_auth_ver,$cas_auth_server,$cas_auth_port,$cas_auth_uri);
12
+phpCAS::client($cas_auth_ver, $cas_auth_server, $cas_auth_port, $cas_auth_uri);
13 13
 phpCAS::logout();
Please login to merge, or discard this patch.
main/auth/cas/logincas.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
         $firstpage = $_GET['firstpage'];
40 40
         setcookie("GotoCourse", $firstpage);
41 41
     }
42
-    if (!is_object($PHPCAS_CLIENT) ) {
42
+    if (!is_object($PHPCAS_CLIENT)) {
43 43
         phpCAS::client(
44 44
             $cas_auth_ver,
45 45
             $cas_auth_server,
Please login to merge, or discard this patch.
main/auth/courses.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
                 $limit
204 204
             );
205 205
         } else {
206
-            header('Location: ' . api_get_self());
206
+            header('Location: '.api_get_self());
207 207
         }
208 208
         break;
209 209
     case 'display_random_courses':
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
                 $continueWithSubscription = SequenceResourceManager::checkSequenceAreCompleted($requirementsData);
279 279
 
280 280
                 if (!$continueWithSubscription) {
281
-                    header('Location: ' .  api_get_path(WEB_CODE_PATH) . 'auth/courses.php');
281
+                    header('Location: '.api_get_path(WEB_CODE_PATH).'auth/courses.php');
282 282
                     exit;
283 283
                 }
284 284
             }
@@ -296,16 +296,16 @@  discard block
 block discarded – undo
296 296
 
297 297
             if ($count <= 0) {
298 298
                 // no course in session -> return to catalog
299
-                $url = api_get_path(WEB_CODE_PATH) . 'auth/courses.php';
299
+                $url = api_get_path(WEB_CODE_PATH).'auth/courses.php';
300 300
             } elseif ($count == 1) {
301 301
                 // only one course, so redirect directly to this course
302 302
                 foreach ($coursesList as $course) {
303
-                    $url = api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . intval($_GET['session_id']);
303
+                    $url = api_get_path(WEB_COURSE_PATH).$course['directory'].'/index.php?id_session='.intval($_GET['session_id']);
304 304
                 }
305 305
             } else {
306
-                $url = api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . intval($_GET['session_id']);
306
+                $url = api_get_path(WEB_CODE_PATH).'session/index.php?session_id='.intval($_GET['session_id']);
307 307
             }
308
-            header('Location: ' . $url);
308
+            header('Location: '.$url);
309 309
             exit;
310 310
         }
311 311
         //else show error message?
Please login to merge, or discard this patch.
Switch Indentation   +135 added lines, -135 removed lines patch added patch discarded remove patch
@@ -171,28 +171,52 @@  discard block
 block discarded – undo
171 171
 }
172 172
 
173 173
 switch ($action) {
174
-    case 'subscribe_user_with_password':
175
-        $courses_controller->subscribe_user(
176
-            isset($_POST['subscribe_user_with_password']) ? $_POST['subscribe_user_with_password'] : '',
177
-            isset($_POST['search_term']) ? $_POST['search_term'] : '',
178
-            isset($_POST['category_code']) ? $_POST['category_code'] : ''
179
-        );
180
-        break;
181
-    case 'createcoursecategory':
182
-        $courses_controller->categories_list($action);
183
-        break;
184
-    case 'deletecoursecategory':
185
-        $courses_controller->courses_list($action);
186
-        break;
187
-    case 'sortmycourses':
188
-        $courses_controller->courses_list($action);
189
-        break;
190
-    case 'subscribe':
191
-        if (!$user_can_view_page) {
192
-            api_not_allowed(true);
193
-        }
194
-
195
-        if (!CoursesAndSessionsCatalog::is(CATALOG_SESSIONS)) {
174
+        case 'subscribe_user_with_password':
175
+            $courses_controller->subscribe_user(
176
+                isset($_POST['subscribe_user_with_password']) ? $_POST['subscribe_user_with_password'] : '',
177
+                isset($_POST['search_term']) ? $_POST['search_term'] : '',
178
+                isset($_POST['category_code']) ? $_POST['category_code'] : ''
179
+            );
180
+            break;
181
+        case 'createcoursecategory':
182
+            $courses_controller->categories_list($action);
183
+            break;
184
+        case 'deletecoursecategory':
185
+            $courses_controller->courses_list($action);
186
+            break;
187
+        case 'sortmycourses':
188
+            $courses_controller->courses_list($action);
189
+            break;
190
+        case 'subscribe':
191
+            if (!$user_can_view_page) {
192
+                api_not_allowed(true);
193
+            }
194
+
195
+            if (!CoursesAndSessionsCatalog::is(CATALOG_SESSIONS)) {
196
+                $courses_controller->courses_categories(
197
+                    $action,
198
+                    $categoryCode,
199
+                    null,
200
+                    null,
201
+                    null,
202
+                    $limit
203
+                );
204
+            } else {
205
+                header('Location: ' . api_get_self());
206
+            }
207
+            break;
208
+        case 'display_random_courses':
209
+            if (!$user_can_view_page) {
210
+                api_not_allowed(true);
211
+            }
212
+
213
+            $courses_controller->courses_categories($action);
214
+            break;
215
+        case 'display_courses':
216
+            if (!$user_can_view_page) {
217
+                api_not_allowed(true);
218
+            }
219
+
196 220
             $courses_controller->courses_categories(
197 221
                 $action,
198 222
                 $categoryCode,
@@ -201,126 +225,102 @@  discard block
 block discarded – undo
201 225
                 null,
202 226
                 $limit
203 227
             );
204
-        } else {
205
-            header('Location: ' . api_get_self());
206
-        }
207
-        break;
208
-    case 'display_random_courses':
209
-        if (!$user_can_view_page) {
210
-            api_not_allowed(true);
211
-        }
212
-
213
-        $courses_controller->courses_categories($action);
214
-        break;
215
-    case 'display_courses':
216
-        if (!$user_can_view_page) {
217
-            api_not_allowed(true);
218
-        }
219
-
220
-        $courses_controller->courses_categories(
221
-            $action,
222
-            $categoryCode,
223
-            null,
224
-            null,
225
-            null,
226
-            $limit
227
-        );
228
-        break;
229
-    case 'display_sessions':
230
-        if (!$user_can_view_page) {
231
-            api_not_allowed(true);
232
-        }
233
-
234
-        $courses_controller->sessionsList($action, $nameTools, $limit);
235
-        break;
236
-    case 'subscribe_to_session':
237
-        if (!$user_can_view_page) {
238
-            api_not_allowed(true);
239
-        }
240
-
241
-        $userId = api_get_user_id();
242
-        $confirmed = isset($_GET['confirm']);
243
-        $sessionId = intval($_GET['session_id']);
244
-
245
-        if (empty($userId)) {
246
-            api_not_allowed();
247
-            exit;
248
-        }
249
-
250
-        if (!$confirmed) {
251
-            $template = new Template(null, false, false, false, false, false);
252
-            $template->assign('session_id', $sessionId);
253
-
254
-            $layout = $template->get_template('auth/confirm_session_subscription.tpl');
255
-
256
-            echo $template->fetch($layout);
257
-            exit;
258
-        }
259
-
260
-        $registrationAllowed = api_get_setting('catalog_allow_session_auto_subscription');
261
-        if ($registrationAllowed === 'true') {
262
-            $entityManager = Database::getManager();
263
-            $repository = $entityManager->getRepository('ChamiloCoreBundle:SequenceResource');
264
-
265
-            $sequences = $repository->getRequirements(
266
-                $sessionId,
267
-                SequenceResource::SESSION_TYPE
268
-            );
228
+            break;
229
+        case 'display_sessions':
230
+            if (!$user_can_view_page) {
231
+                api_not_allowed(true);
232
+            }
233
+
234
+            $courses_controller->sessionsList($action, $nameTools, $limit);
235
+            break;
236
+        case 'subscribe_to_session':
237
+            if (!$user_can_view_page) {
238
+                api_not_allowed(true);
239
+            }
240
+
241
+            $userId = api_get_user_id();
242
+            $confirmed = isset($_GET['confirm']);
243
+            $sessionId = intval($_GET['session_id']);
269 244
 
270
-            if (count($sequences) > 0) {
271
-                $requirementsData = SequenceResourceManager::checkRequirementsForUser(
272
-                    $sequences,
273
-                    SequenceResource::SESSION_TYPE,
274
-                    $userId
245
+            if (empty($userId)) {
246
+                api_not_allowed();
247
+                exit;
248
+            }
249
+
250
+            if (!$confirmed) {
251
+                $template = new Template(null, false, false, false, false, false);
252
+                $template->assign('session_id', $sessionId);
253
+
254
+                $layout = $template->get_template('auth/confirm_session_subscription.tpl');
255
+
256
+                echo $template->fetch($layout);
257
+                exit;
258
+            }
259
+
260
+            $registrationAllowed = api_get_setting('catalog_allow_session_auto_subscription');
261
+            if ($registrationAllowed === 'true') {
262
+                $entityManager = Database::getManager();
263
+                $repository = $entityManager->getRepository('ChamiloCoreBundle:SequenceResource');
264
+
265
+                $sequences = $repository->getRequirements(
266
+                    $sessionId,
267
+                    SequenceResource::SESSION_TYPE
275 268
                 );
276 269
 
277
-                $continueWithSubscription = SequenceResourceManager::checkSequenceAreCompleted($requirementsData);
270
+                if (count($sequences) > 0) {
271
+                    $requirementsData = SequenceResourceManager::checkRequirementsForUser(
272
+                        $sequences,
273
+                        SequenceResource::SESSION_TYPE,
274
+                        $userId
275
+                    );
276
+
277
+                    $continueWithSubscription = SequenceResourceManager::checkSequenceAreCompleted($requirementsData);
278 278
 
279
-                if (!$continueWithSubscription) {
280
-                    header('Location: ' .  api_get_path(WEB_CODE_PATH) . 'auth/courses.php');
281
-                    exit;
279
+                    if (!$continueWithSubscription) {
280
+                        header('Location: ' .  api_get_path(WEB_CODE_PATH) . 'auth/courses.php');
281
+                        exit;
282
+                    }
282 283
                 }
283
-            }
284 284
 
285
-            SessionManager::suscribe_users_to_session(
286
-                $_GET['session_id'],
287
-                array($userId),
288
-                SESSION_VISIBLE_READ_ONLY,
289
-                false
290
-            );
285
+                SessionManager::suscribe_users_to_session(
286
+                    $_GET['session_id'],
287
+                    array($userId),
288
+                    SESSION_VISIBLE_READ_ONLY,
289
+                    false
290
+                );
291 291
 
292
-            $coursesList = SessionManager::get_course_list_by_session_id($_GET['session_id']);
293
-            $count = count($coursesList);
294
-            $url = '';
295
-
296
-            if ($count <= 0) {
297
-                // no course in session -> return to catalog
298
-                $url = api_get_path(WEB_CODE_PATH) . 'auth/courses.php';
299
-            } elseif ($count == 1) {
300
-                // only one course, so redirect directly to this course
301
-                foreach ($coursesList as $course) {
302
-                    $url = api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . intval($_GET['session_id']);
292
+                $coursesList = SessionManager::get_course_list_by_session_id($_GET['session_id']);
293
+                $count = count($coursesList);
294
+                $url = '';
295
+
296
+                if ($count <= 0) {
297
+                    // no course in session -> return to catalog
298
+                    $url = api_get_path(WEB_CODE_PATH) . 'auth/courses.php';
299
+                } elseif ($count == 1) {
300
+                    // only one course, so redirect directly to this course
301
+                    foreach ($coursesList as $course) {
302
+                        $url = api_get_path(WEB_COURSE_PATH) . $course['directory'] . '/index.php?id_session=' . intval($_GET['session_id']);
303
+                    }
304
+                } else {
305
+                    $url = api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . intval($_GET['session_id']);
303 306
                 }
304
-            } else {
305
-                $url = api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . intval($_GET['session_id']);
307
+                header('Location: ' . $url);
308
+                exit;
306 309
             }
307
-            header('Location: ' . $url);
308
-            exit;
309
-        }
310
-        //else show error message?
311
-        break;
312
-    case 'search_tag':
313
-        if (!$user_can_view_page) {
314
-            api_not_allowed(true);
315
-        }
316
-
317
-        $courses_controller->sessionsListByCoursesTag($limit);
318
-        break;
319
-    case 'search_session':
320
-        if (!$user_can_view_page) {
321
-            api_not_allowed(true);
322
-        }
323
-
324
-        $courses_controller->sessionListBySearch($limit);
325
-        break;
310
+            //else show error message?
311
+            break;
312
+        case 'search_tag':
313
+            if (!$user_can_view_page) {
314
+                api_not_allowed(true);
315
+            }
316
+
317
+            $courses_controller->sessionsListByCoursesTag($limit);
318
+            break;
319
+        case 'search_session':
320
+            if (!$user_can_view_page) {
321
+                api_not_allowed(true);
322
+            }
323
+
324
+            $courses_controller->sessionListBySearch($limit);
325
+            break;
326 326
 }
Please login to merge, or discard this patch.
main/auth/gotocourse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 
42 42
     $msg .= '<div class="well_login">';
43 43
     $msg .= $form->return_form();
44
-    $msg .='</div>';
44
+    $msg .= '</div>';
45 45
     if (api_is_cas_activated()) {
46 46
         $msg .= "</div>";
47 47
     }
Please login to merge, or discard this patch.
main/auth/conditional_login/complete_phone_number.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 $url =  api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
6 6
 
7 7
 if (! isset($_SESSION['conditional_login']['uid']))
8
-  die("Not Authorised");
8
+    die("Not Authorised");
9 9
 ?>
10 10
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
11 11
 <html lang="fr" xml:lang="fr" xmlns="http://www.w3.org/1999/xhtml">
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@  discard block
 block discarded – undo
2 2
 /* For licensing terms, see /license.txt */
3 3
 
4 4
 require_once dirname(__FILE__).'/../../inc/global.inc.php';
5
-$url =  api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
5
+$url = api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
6 6
 
7
-if (! isset($_SESSION['conditional_login']['uid']))
7
+if (!isset($_SESSION['conditional_login']['uid']))
8 8
   die("Not Authorised");
9 9
 ?>
10 10
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
   </body>
21 21
 </html>
22 22
 <?php
23
-if (isset($_POST['submit'])){
23
+if (isset($_POST['submit'])) {
24 24
     $u = api_get_user_info($_SESSION['conditional_login']['uid']);
25 25
     $u['phone'] = $_POST['phone_number'];
26 26
     $password = null; // we don't want to change the password
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,9 @@
 block discarded – undo
4 4
 require_once dirname(__FILE__).'/../../inc/global.inc.php';
5 5
 $url =  api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
6 6
 
7
-if (! isset($_SESSION['conditional_login']['uid']))
7
+if (! isset($_SESSION['conditional_login']['uid'])) {
8 8
   die("Not Authorised");
9
+}
9 10
 ?>
10 11
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
11 12
 <html lang="fr" xml:lang="fr" xmlns="http://www.w3.org/1999/xhtml">
Please login to merge, or discard this patch.
main/auth/my_progress.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -54,16 +54,16 @@  discard block
 block discarded – undo
54 54
         }
55 55
         $course_info = api_get_course_info_by_id($result['c_id']);
56 56
         $course_image = '<img src="'.$course_info['course_image_large'].'">';
57
-        $dates .= '<li><a href="#'.$login.'">' . api_convert_and_format_date($login, DATE_FORMAT_SHORT) . '</a></li>';
57
+        $dates .= '<li><a href="#'.$login.'">'.api_convert_and_format_date($login, DATE_FORMAT_SHORT).'</a></li>';
58 58
         $issues .= '<li id ="'.$login.'">';
59 59
         $issues .= '<div class="img-course">'.$course_image.'</div>';
60 60
         
61 61
         $issues .= '<div class="text-course">';
62
-        $issues .= '<p>' . sprintf(
62
+        $issues .= '<p>'.sprintf(
63 63
                 get_lang('YouHaveEnteredTheCourseXInY'),
64
-                '" '. $courseInfo['name'] .' "',
64
+                '" '.$courseInfo['name'].' "',
65 65
                 api_convert_and_format_date($login, DATE_TIME_FORMAT_LONG) 
66
-                ) . '</p>';
66
+                ).'</p>';
67 67
         $issues .= '</div>'; 
68 68
         $issues .= '</li>';
69 69
         $count++;
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     $content .= '<div class="row">';
83 83
     $content .= '<div class="col-md-12">';
84 84
     $content .= '<div id="my_timeline">';
85
-    $content .= '<ul id="dates">' . $dates . '</ul>';
86
-    $content .= '<ul id="issues">' . $issues . '</ul>';
85
+    $content .= '<ul id="dates">'.$dates.'</ul>';
86
+    $content .= '<ul id="issues">'.$issues.'</ul>';
87 87
     $content .= '<div id="grad_left"></div>';
88 88
     $content .= '<div id="grad_right"></div>';
89 89
     $content .= '<a href="#" id="prev"></a>';
Please login to merge, or discard this patch.
main/auth/external_login/login.ws.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 $wsUrl = '';
15 15
 
16 16
 // include common authentication functions
17
-require_once dirname(__FILE__) . '/functions.inc.php';
17
+require_once dirname(__FILE__).'/functions.inc.php';
18 18
 // call the login checker (defined below)
19 19
 $isValid = loginWSAuthenticate($login, $password, $wsUrl);
20 20
 
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
     $key = '-+*%$({[]})$%*+-';
62 62
     // Complete password con PKCS7-specific padding
63 63
     $blockSize = 16;
64
-    $padding = $blockSize - (strlen($password)%$blockSize);
65
-    $password .= str_repeat(chr($padding),$padding);
64
+    $padding = $blockSize - (strlen($password) % $blockSize);
65
+    $password .= str_repeat(chr($padding), $padding);
66 66
     $cipher = new Crypt_AES(CRYPT_AES_MODE_CFB);
67 67
     $cipher->setKeyLength(128);
68 68
     $cipher->setKey($key);
Please login to merge, or discard this patch.
main/auth/external_login/updateUser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 
8 8
 use ChamiloSession as Session;
9 9
 
10
-require_once(dirname(__FILE__) . '/functions.inc.php');
10
+require_once(dirname(__FILE__).'/functions.inc.php');
11 11
 
12 12
 //MAIN CODE
13 13
 //$uData variable is set in local.inc.php
@@ -36,6 +36,6 @@  discard block
 block discarded – undo
36 36
     //User cannot login
37 37
     $loginFailed = true;
38 38
     Session::erase('_uid');
39
-    header('Location: ' . api_get_path(WEB_PATH) . 'index.php?loginFailed=1&error=user_password_incorrect');
39
+    header('Location: '.api_get_path(WEB_PATH).'index.php?loginFailed=1&error=user_password_incorrect');
40 40
     exit;
41 41
 }
Please login to merge, or discard this patch.
main/auth/external_login/newUser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 
11 11
 use ChamiloSession as Session;
12 12
 
13
-require_once(dirname(__FILE__) . '/functions.inc.php');
13
+require_once(dirname(__FILE__).'/functions.inc.php');
14 14
 
15 15
 //MAIN CODE
16 16
 //$login and $password variables are setted in main/inc/local.inc.php
Please login to merge, or discard this patch.