Total Complexity | 41 |
Total Lines | 598 |
Duplicated Lines | 0 % |
Changes | 5 | ||
Bugs | 0 | Features | 0 |
Complex classes like ResourceController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResourceController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
43 | class ResourceController extends AbstractResourceController implements CourseControllerInterface |
||
44 | { |
||
45 | use CourseControllerTrait; |
||
46 | use ResourceControllerTrait; |
||
47 | use ControllerTrait; |
||
48 | |||
49 | private string $fileContentName = 'file_content'; |
||
50 | |||
51 | /** |
||
52 | * @Route("/{tool}/{type}/{id}/disk_space", methods={"GET", "POST"}, name="chamilo_core_resource_disk_space") |
||
53 | */ |
||
54 | public function diskSpaceAction(Request $request): Response |
||
55 | { |
||
56 | $nodeId = $request->get('id'); |
||
57 | $repository = $this->getRepositoryFromRequest($request); |
||
58 | |||
59 | /** @var ResourceNode $resourceNode */ |
||
60 | $resourceNode = $repository->getResourceNodeRepository()->find($nodeId); |
||
61 | |||
62 | $this->denyAccessUnlessGranted( |
||
63 | ResourceNodeVoter::VIEW, |
||
64 | $resourceNode, |
||
65 | $this->trans('Unauthorised access to resource') |
||
66 | ); |
||
67 | |||
68 | $this->setBreadCrumb($request, $resourceNode); |
||
69 | |||
70 | $course = $this->getCourse(); |
||
71 | $totalSize = 0; |
||
72 | if (null !== $course) { |
||
73 | $totalSize = $course->getDiskQuota(); |
||
74 | } |
||
75 | |||
76 | $size = $repository->getResourceNodeRepository()->getSize( |
||
77 | $resourceNode, |
||
78 | $repository->getResourceType(), |
||
79 | $course |
||
80 | ); |
||
81 | |||
82 | $labels[] = $course->getTitle(); |
||
|
|||
83 | $data[] = $size; |
||
84 | $sessions = $course->getSessions(); |
||
85 | |||
86 | foreach ($sessions as $sessionRelCourse) { |
||
87 | $session = $sessionRelCourse->getSession(); |
||
88 | |||
89 | $labels[] = $course->getTitle().' - '.$session->getName(); |
||
90 | $size = $repository->getResourceNodeRepository()->getSize( |
||
91 | $resourceNode, |
||
92 | $repository->getResourceType(), |
||
93 | $course, |
||
94 | $session |
||
95 | ); |
||
96 | $data[] = $size; |
||
97 | } |
||
98 | |||
99 | /*$groups = $course->getGroups(); |
||
100 | foreach ($groups as $group) { |
||
101 | $labels[] = $course->getTitle().' - '.$group->getName(); |
||
102 | $size = $repository->getResourceNodeRepository()->getSize( |
||
103 | $resourceNode, |
||
104 | $repository->getResourceType(), |
||
105 | $course, |
||
106 | null, |
||
107 | $group |
||
108 | ); |
||
109 | $data[] = $size; |
||
110 | }*/ |
||
111 | |||
112 | $used = array_sum($data); |
||
113 | $labels[] = $this->trans('Free'); |
||
114 | $data[] = $totalSize - $used; |
||
115 | |||
116 | return $this->render( |
||
117 | $repository->getTemplates()->getFromAction(__FUNCTION__), |
||
118 | [ |
||
119 | 'resourceNode' => $resourceNode, |
||
120 | 'labels' => $labels, |
||
121 | 'data' => $data, |
||
122 | ] |
||
123 | ); |
||
124 | } |
||
125 | |||
126 | /** |
||
127 | * @deprecated Use Vue |
||
128 | * |
||
129 | * @Route("/{tool}/{type}/{id}/edit", methods={"GET", "POST"}) |
||
130 | */ |
||
131 | public function editAction(Request $request, IllustrationRepository $illustrationRepo): Response |
||
132 | { |
||
133 | $resourceNodeId = $request->get('id'); |
||
134 | |||
135 | $repository = $this->getRepositoryFromRequest($request); |
||
136 | $resource = $repository->getResourceFromResourceNode($resourceNodeId); |
||
137 | $this->denyAccessUnlessValidResource($resource); |
||
138 | $settings = $repository->getResourceSettings(); |
||
139 | $resourceNode = $resource->getResourceNode(); |
||
140 | |||
141 | $this->denyAccessUnlessGranted( |
||
142 | ResourceNodeVoter::EDIT, |
||
143 | $resourceNode, |
||
144 | $this->trans('Unauthorised access to resource') |
||
145 | ); |
||
146 | |||
147 | $this->setBreadCrumb($request, $resourceNode); |
||
148 | $resourceNodeParentId = $resourceNode->getId(); |
||
149 | |||
150 | $routeParams = $this->getResourceParams($request); |
||
151 | $routeParams['id'] = $resourceNodeParentId; |
||
152 | |||
153 | $form = $repository->getForm($this->container->get('form.factory'), $resource); |
||
154 | |||
155 | if ($resourceNode->hasEditableTextContent() && $settings->isAllowToSaveEditorToResourceFile()) { |
||
156 | /*$form->add( |
||
157 | $this->fileContentName, |
||
158 | CKEditorType::class, |
||
159 | [ |
||
160 | 'mapped' => false, |
||
161 | 'config' => [ |
||
162 | 'filebrowserImageBrowseRoute' => 'resources_filemanager', |
||
163 | 'filebrowserImageBrowseRouteParameters' => $routeParams, |
||
164 | ], |
||
165 | ] |
||
166 | ); |
||
167 | $content = $repository->getResourceNodeFileContent($resourceNode); |
||
168 | $form->get($this->fileContentName)->setData($content);*/ |
||
169 | } |
||
170 | |||
171 | $form->handleRequest($request); |
||
172 | |||
173 | if ($form->isSubmitted() && $form->isValid()) { |
||
174 | /** @var AbstractResource|ResourceInterface $newResource */ |
||
175 | $newResource = $form->getData(); |
||
176 | |||
177 | if ($form->has($this->fileContentName)) { |
||
178 | $data = $form->get($this->fileContentName)->getData(); |
||
179 | $repository->updateResourceFileContent($newResource, $data); |
||
180 | } |
||
181 | |||
182 | $repository->updateNodeForResource($newResource); |
||
183 | |||
184 | if ($form->has('illustration')) { |
||
185 | $illustration = $form->get('illustration')->getData(); |
||
186 | if ($illustration) { |
||
187 | $illustrationRepo->addIllustration($newResource, $this->getUser(), $illustration); |
||
188 | } |
||
189 | } |
||
190 | |||
191 | $this->addFlash('success', $this->trans('Updated')); |
||
192 | $resourceNodeParentId = $newResource->getResourceNode()->getParent()->getId(); |
||
193 | $routeParams['id'] = $resourceNodeParentId; |
||
194 | |||
195 | return $this->redirectToRoute('chamilo_core_resource_list', $routeParams); |
||
196 | } |
||
197 | |||
198 | return $this->render( |
||
199 | $repository->getTemplates()->getFromAction(__FUNCTION__), |
||
200 | [ |
||
201 | 'form' => $form->createView(), |
||
202 | 'parent' => $resourceNodeParentId, |
||
203 | ] |
||
204 | ); |
||
205 | } |
||
206 | |||
207 | /** |
||
208 | * Shows resource information. |
||
209 | * |
||
210 | * @Route("/{tool}/{type}/{id}/info", methods={"GET", "POST"}, name="chamilo_core_resource_info") |
||
211 | */ |
||
212 | public function infoAction(Request $request): Response |
||
213 | { |
||
214 | $nodeId = (int) $request->get('id'); |
||
215 | $repository = $this->getRepositoryFromRequest($request); |
||
216 | |||
217 | $resource = $repository->getResourceFromResourceNode($nodeId); |
||
218 | $this->denyAccessUnlessValidResource($resource); |
||
219 | |||
220 | $resourceNode = $resource->getResourceNode(); |
||
221 | |||
222 | $this->denyAccessUnlessGranted( |
||
223 | ResourceNodeVoter::VIEW, |
||
224 | $resourceNode, |
||
225 | $this->trans(sprintf('Unauthorised access to resource #%s', $nodeId)) |
||
226 | ); |
||
227 | |||
228 | $this->setBreadCrumb($request, $resourceNode); |
||
229 | |||
230 | $tool = $request->get('tool'); |
||
231 | $type = $request->get('type'); |
||
232 | |||
233 | $form = $this->createForm(ResourceCommentType::class, null); |
||
234 | |||
235 | $params = [ |
||
236 | 'resource' => $resource, |
||
237 | 'course' => $this->getCourse(), |
||
238 | 'tool' => $tool, |
||
239 | 'type' => $type, |
||
240 | 'comment_form' => $form->createView(), |
||
241 | ]; |
||
242 | |||
243 | return $this->render( |
||
244 | $repository->getTemplates()->getFromAction(__FUNCTION__, $request->isXmlHttpRequest()), |
||
245 | $params |
||
246 | ); |
||
247 | } |
||
248 | |||
249 | /** |
||
250 | * Preview a file. Mostly used when using a modal. |
||
251 | * |
||
252 | * @Route("/{tool}/{type}/{id}/preview", methods={"GET"}, name="chamilo_core_resource_preview") |
||
253 | */ |
||
254 | /*public function previewAction(Request $request): Response |
||
255 | { |
||
256 | $nodeId = $request->get('id'); |
||
257 | $repository = $this->getRepositoryFromRequest($request); |
||
258 | |||
259 | $resource = $repository->getResourceFromResourceNode($nodeId); |
||
260 | $this->denyAccessUnlessValidResource($resource); |
||
261 | |||
262 | $resourceNode = $resource->getResourceNode(); |
||
263 | $this->denyAccessUnlessGranted( |
||
264 | ResourceNodeVoter::VIEW, |
||
265 | $resourceNode, |
||
266 | $this->trans('Unauthorised access to resource') |
||
267 | ); |
||
268 | |||
269 | $this->setBreadCrumb($request, $resourceNode); |
||
270 | |||
271 | $tool = $request->get('tool'); |
||
272 | $type = $request->get('type'); |
||
273 | |||
274 | $params = [ |
||
275 | 'resource' => $resource, |
||
276 | 'tool' => $tool, |
||
277 | 'type' => $type, |
||
278 | ]; |
||
279 | |||
280 | return $this->render($repository->getTemplates()->getFromAction(__FUNCTION__), $params); |
||
281 | }*/ |
||
282 | |||
283 | /** |
||
284 | * @deprecated use vue |
||
285 | * |
||
286 | * @Route("/{tool}/{type}/{id}/change_visibility", name="chamilo_core_resource_change_visibility") |
||
287 | */ |
||
288 | public function changeVisibilityAction(Request $request): Response |
||
289 | { |
||
290 | $id = (int) $request->get('id'); |
||
291 | |||
292 | $repository = $this->getRepositoryFromRequest($request); |
||
293 | |||
294 | $resource = $repository->getResourceFromResourceNode($id); |
||
295 | $this->denyAccessUnlessValidResource($resource); |
||
296 | /** @var AbstractResource $resource */ |
||
297 | $resourceNode = $resource->getResourceNode(); |
||
298 | |||
299 | $this->denyAccessUnlessGranted( |
||
300 | ResourceNodeVoter::EDIT, |
||
301 | $resourceNode, |
||
302 | $this->trans('Unauthorised access to resource') |
||
303 | ); |
||
304 | |||
305 | if ($this->hasCourse()) { |
||
306 | $link = $resource->getFirstResourceLinkFromCourseSession($this->getCourse(), $this->getSession()); |
||
307 | } else { |
||
308 | $link = $resource->getFirstResourceLink(); |
||
309 | } |
||
310 | |||
311 | // Use repository to change settings easily. |
||
312 | if ($link && ResourceLink::VISIBILITY_PUBLISHED === $link->getVisibility()) { |
||
313 | $repository->setVisibilityDraft($resource); |
||
314 | } else { |
||
315 | $repository->setVisibilityPublished($resource); |
||
316 | } |
||
317 | |||
318 | $result = [ |
||
319 | 'visibility' => $link->getVisibility(), |
||
320 | 'ok' => true, |
||
321 | ]; |
||
322 | |||
323 | return new JsonResponse($result); |
||
324 | } |
||
325 | |||
326 | /** |
||
327 | * @deprecated Use Vue + api platform |
||
328 | * |
||
329 | * @Route("/{tool}/{type}/{id}/delete", name="chamilo_core_resource_delete") |
||
330 | */ |
||
331 | public function deleteAction(Request $request): Response |
||
362 | } |
||
363 | |||
364 | /** |
||
365 | * Shows the associated resource file. |
||
366 | * |
||
367 | * @deprecated use vue |
||
368 | * |
||
369 | * @Route("/{tool}/{type}/{id}/view_resource", methods={"GET"}, name="chamilo_core_resource_view_resource") |
||
370 | */ |
||
371 | /*public function viewResourceAction(Request $request, RouterInterface $router): Response |
||
372 | { |
||
373 | $id = $request->get('id'); |
||
374 | |||
375 | $resourceNode = $this->getResourceNodeRepository()->find($id); |
||
376 | |||
377 | if (null === $resourceNode) { |
||
378 | throw new FileNotFoundException('Resource not found'); |
||
379 | } |
||
380 | |||
381 | $this->denyAccessUnlessGranted( |
||
382 | ResourceNodeVoter::VIEW, |
||
383 | $resourceNode, |
||
384 | $this->trans('Unauthorised access to resource') |
||
385 | ); |
||
386 | |||
387 | $repository = $this->getRepositoryFromRequest($request); |
||
388 | |||
389 | $resource = $repository->getResourceFromResourceNode($id); |
||
390 | |||
391 | $tool = $request->get('tool'); |
||
392 | $type = $request->get('type'); |
||
393 | $this->setBreadCrumb($request, $resourceNode); |
||
394 | |||
395 | $params = [ |
||
396 | 'resource' => $resource, |
||
397 | 'tool' => $tool, |
||
398 | 'type' => $type, |
||
399 | ]; |
||
400 | |||
401 | return $this->render($repository->getTemplates()->getFromAction(__FUNCTION__), $params); |
||
402 | }*/ |
||
403 | |||
404 | /** |
||
405 | * View file of a resource node. |
||
406 | * |
||
407 | * @Route("/{tool}/{type}/{id}/view", methods={"GET"}, name="chamilo_core_resource_view") |
||
408 | */ |
||
409 | public function viewAction(Request $request): Response |
||
420 | } |
||
421 | |||
422 | /** |
||
423 | * Redirect resource to link. |
||
424 | * |
||
425 | * @Route("/{tool}/{type}/{id}/link", methods={"GET"}, name="chamilo_core_resource_link") |
||
426 | * |
||
427 | * @return RedirectResponse|void |
||
428 | */ |
||
429 | public function linkAction(Request $request, RouterInterface $router) |
||
430 | { |
||
431 | $id = $request->get('id'); |
||
432 | $resourceNode = $this->getResourceNodeRepository()->find($id); |
||
433 | |||
434 | if (null === $resourceNode) { |
||
435 | throw new FileNotFoundException('Resource not found'); |
||
436 | } |
||
437 | |||
438 | $repo = $this->getRepositoryFromRequest($request); |
||
439 | if ($repo instanceof ResourceWithLinkInterface) { |
||
440 | $resource = $repo->getResourceFromResourceNode($resourceNode->getId()); |
||
441 | $url = $repo->getLink($resource, $router, $this->getCourseUrlQueryToArray()); |
||
442 | |||
443 | return $this->redirect($url); |
||
444 | } |
||
445 | |||
446 | $this->abort('No redirect'); |
||
447 | } |
||
448 | |||
449 | /** |
||
450 | * Download file of a resource node. |
||
451 | * |
||
452 | * @Route("/{tool}/{type}/{id}/download", methods={"GET"}, name="chamilo_core_resource_download") |
||
453 | * |
||
454 | * @return RedirectResponse|StreamedResponse |
||
455 | */ |
||
456 | public function downloadAction(Request $request) |
||
532 | } |
||
533 | |||
534 | /** |
||
535 | * @return mixed|StreamedResponse |
||
536 | */ |
||
537 | private function processFile(Request $request, ResourceNode $resourceNode, string $mode = 'show', string $filter = '') |
||
641 | } |
||
642 | } |
||
643 |