ChatController::ajaxAction() - Code Metrics - Inspection of "Upgrade" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5329)

by Angel Fernando Quiroz

created 2024-04-04 16:49 UTC

ChatController::ajaxAction() C

↳ Parent: Project

Complexity

Conditions	12
Paths	16

Size

Total Lines	100
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	62
c	0
b	0
f	0
nc	16
nop	2
dl	0
loc	100
rs	6.4024

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CoreBundle\Repository\ResourceNodeRepository;
use Chamilo\CoreBundle\Traits\ControllerTrait;
use Chamilo\CoreBundle\Traits\CourseControllerTrait;
use Chamilo\CoreBundle\Traits\ResourceControllerTrait;
use Chamilo\CourseBundle\Controller\CourseControllerInterface;
use Chamilo\CourseBundle\Repository\CChatConversationRepository;
use CourseChatUtils;
use Event;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

class ChatController extends AbstractResourceController implements CourseControllerInterface
{
    use ControllerTrait;
    use CourseControllerTrait;
    use ResourceControllerTrait;

    #[Route(path: '/resources/chat/', name: 'chat_home', options: ['expose' => true])]
    public function index(): Response
    {
        Event::event_access_tool(TOOL_CHAT);
               event_access_tool(TOOL_CHAT);
        $logInfo = [
            'tool' => TOOL_CHAT,
            'action' => 'start',
            'action_details' => 'start-chat',
        ];
        Event::registerLog($logInfo);
               registerLog($logInfo);

        return $this->render(
            '@ChamiloCore/Chat/chat.html.twig',
            [
                'restrict_to_coach' => ('true' === api_get_setting('chat.course_chat_restrict_to_coach')),
                'user' => api_get_user_info(),
            ]
        );
    }

    #[Route(path: '/resources/chat/conversations/', name: 'chat_ajax', options: ['expose' => true])]
    public function ajax(Request $request, ResourceNodeRepository $repo): Response
    {
        if (!api_protect_course_script(false)) {
            exit;
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        }

        /** @var CChatConversationRepository $resourceRepo */
        $resourceRepo = $this->getRepository('chat', 'conversations');

        $courseId = api_get_course_int_id();
        $userId = api_get_user_id();
        $sessionId = api_get_session_id();
        $groupId = api_get_group_id();
        $json = [
            'status' => false,
        ];
        $parentResourceNode = $this->getParentResourceNode($request);

        $courseChatUtils = new CourseChatUtils(
            $courseId,
            $userId,
            $sessionId,
            $groupId,
            $parentResourceNode,
            $resourceRepo
        );

        $action = $request->get('action');

        switch ($action) {
            case 'chat_logout':
                $logInfo = [
                    'tool' => TOOL_CHAT,
                    'action' => 'exit',
                    'action_details' => 'exit-chat',
                ];
                Event::registerLog($logInfo);

                break;

            case 'track':
                $courseChatUtils->keepUserAsConnected();
                $courseChatUtils->disconnectInactiveUsers();

                $friend = isset($_REQUEST['friend']) ? (int) $_REQUEST['friend'] : 0;
                // $filePath = $courseChatUtils->getFileName(true, $friend);
                // $newFileSize = file_exists($filePath) ? filesize($filePath) : 0;
                // $oldFileSize = isset($_GET['size']) ? (int) $_GET['size'] : -1;
                $newUsersOnline = $courseChatUtils->countUsersOnline();
                $oldUsersOnline = isset($_GET['users_online']) ? (int) $_GET['users_online'] : 0;

                $json = [
                    'status' => true,
                    'data' => [
                        // 'oldFileSize' => file_exists($filePath) ? filesize($filePath) : 0,
                        'oldFileSize' => false,
                        'history' => $courseChatUtils->readMessages(false, $friend),
                        'usersOnline' => $newUsersOnline,
                        'userList' => $newUsersOnline !== $oldUsersOnline ? $courseChatUtils->listUsersOnline() : null,
                        'currentFriend' => $friend,
                    ],
                ];

                break;

            case 'preview':
                $json = [
                    'status' => true,
                    'data' => [
                        'message' => $courseChatUtils->prepareMessage($_REQUEST['message']),
                    ],
                ];

                break;

            case 'reset':
                $friend = isset($_REQUEST['friend']) ? (int) $_REQUEST['friend'] : 0;

                $json = [
                    'status' => true,
                    'data' => $courseChatUtils->readMessages(true, $friend),
                ];

                break;

            case 'write':
                $friend = isset($_REQUEST['friend']) ? (int) $_REQUEST['friend'] : 0;
                $status = $courseChatUtils->saveMessage($_REQUEST['message'], $friend);

                $json = [
                    'status' => $status,
                    'data' => [
                        'writed' => $status,
                    ],
                ];

                break;
        }

        return new JsonResponse($json);
    }
}


chamilo / chamilo-lms

Pull Request — master (#5329)

ChatController::ajaxAction() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like