Conditions | 16 |
Paths | > 20000 |
Total Lines | 97 |
Code Lines | 64 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
15 | public function up(Schema $schema): void |
||
16 | { |
||
17 | $table = $schema->getTable('gradebook_result_log'); |
||
18 | if ($table->hasColumn('id_result')) { |
||
19 | $this->addSql('DELETE FROM gradebook_result_log WHERE id_result IS NULL'); |
||
20 | $this->addSql('ALTER TABLE gradebook_result_log CHANGE id_result result_id INT NOT NULL'); |
||
21 | } |
||
22 | |||
23 | $this->addSql('ALTER TABLE gradebook_category CHANGE user_id user_id INT DEFAULT NULL'); |
||
24 | $this->addSql( |
||
25 | 'DELETE FROM gradebook_category WHERE user_id IS NOT NULL AND user_id NOT IN (SELECT id FROM user)' |
||
26 | ); |
||
27 | |||
28 | $table = $schema->getTable('gradebook_category'); |
||
29 | if (false === $table->hasColumn('c_id')) { |
||
30 | $this->addSql('ALTER TABLE gradebook_category ADD c_id INT DEFAULT NULL'); |
||
31 | $this->addSql('UPDATE gradebook_category SET c_id = (SELECT id FROM course WHERE code = course_code)'); |
||
32 | $this->addSql('ALTER TABLE gradebook_category DROP course_code'); |
||
33 | $this->addSql( |
||
34 | 'ALTER TABLE gradebook_category ADD CONSTRAINT FK_96A4C70591D79BD3 FOREIGN KEY (c_id) REFERENCES course (id);' |
||
35 | ); |
||
36 | $this->addSql('CREATE INDEX IDX_96A4C70591D79BD3 ON gradebook_category (c_id);'); |
||
37 | } |
||
38 | if (false === $table->hasColumn('depends')) { |
||
39 | $this->addSql('ALTER TABLE gradebook_category ADD depends LONGTEXT DEFAULT NULL'); |
||
40 | } |
||
41 | if (false === $table->hasColumn('minimum_to_validate')) { |
||
42 | $this->addSql('ALTER TABLE gradebook_category ADD minimum_to_validate INT DEFAULT NULL'); |
||
43 | } |
||
44 | if (false === $table->hasColumn('gradebooks_to_validate_in_dependence')) { |
||
45 | $this->addSql('ALTER TABLE gradebook_category ADD gradebooks_to_validate_in_dependence INT DEFAULT NULL'); |
||
46 | } |
||
47 | |||
48 | if (false === $table->hasIndex('idx_gb_cat_parent')) { |
||
49 | $this->addSql('CREATE INDEX idx_gb_cat_parent ON gradebook_category (parent_id)'); |
||
50 | } |
||
51 | |||
52 | if (false === $table->hasForeignKey('FK_96A4C705A76ED395')) { |
||
53 | $this->addSql( |
||
54 | 'ALTER TABLE gradebook_category ADD CONSTRAINT FK_96A4C705A76ED395 FOREIGN KEY (user_id) REFERENCES user (id)' |
||
55 | ); |
||
56 | } |
||
57 | if (false === $table->hasIndex('IDX_96A4C705A76ED395')) { |
||
58 | $this->addSql('CREATE INDEX IDX_96A4C705A76ED395 ON gradebook_category (user_id)'); |
||
59 | } |
||
60 | |||
61 | // Evaluation. |
||
62 | $table = $schema->getTable('gradebook_evaluation'); |
||
63 | if (false === $table->hasColumn('c_id')) { |
||
64 | $this->addSql('ALTER TABLE gradebook_evaluation ADD c_id INT DEFAULT NULL'); |
||
65 | $this->addSql('UPDATE gradebook_evaluation SET c_id = (SELECT id FROM course WHERE code = course_code)'); |
||
66 | $this->addSql('ALTER TABLE gradebook_evaluation DROP course_code'); |
||
67 | $this->addSql( |
||
68 | 'ALTER TABLE gradebook_evaluation ADD CONSTRAINT FK_DDDED80491D79BD3 FOREIGN KEY (c_id) REFERENCES course (id);' |
||
69 | ); |
||
70 | $this->addSql('CREATE INDEX IDX_DDDED80491D79BD3 ON gradebook_evaluation (c_id)'); |
||
71 | //$this->addSql('ALTER TABLE gradebook_evaluation RENAME INDEX fk_ddded80491d79bd3 TO IDX_DDDED80491D79BD3;'); |
||
72 | } |
||
73 | if (false === $table->hasIndex('idx_ge_cat')) { |
||
74 | $this->addSql('CREATE INDEX idx_ge_cat ON gradebook_evaluation (category_id)'); |
||
75 | } |
||
76 | |||
77 | $table = $schema->getTable('gradebook_link'); |
||
78 | if (false === $table->hasColumn('c_id')) { |
||
79 | $this->addSql('ALTER TABLE gradebook_link ADD c_id INT DEFAULT NULL'); |
||
80 | $this->addSql('UPDATE gradebook_link SET c_id = (SELECT id FROM course WHERE code = course_code)'); |
||
81 | $this->addSql('ALTER TABLE gradebook_link DROP course_code'); |
||
82 | $this->addSql( |
||
83 | 'ALTER TABLE gradebook_link ADD CONSTRAINT FK_4F0F595F91D79BD3 FOREIGN KEY (c_id) REFERENCES course (id);' |
||
84 | ); |
||
85 | $this->addSql('CREATE INDEX IDX_4F0F595F91D79BD3 ON gradebook_link (c_id);'); |
||
86 | } |
||
87 | if (false === $table->hasIndex('idx_gl_cat')) { |
||
88 | $this->addSql('CREATE INDEX idx_gl_cat ON gradebook_link (category_id)'); |
||
89 | } |
||
90 | |||
91 | $table = $schema->getTable('gradebook_result'); |
||
92 | if (false === $table->hasIndex('idx_gb_uid_eid')) { |
||
93 | $this->addSql('CREATE INDEX idx_gb_uid_eid ON gradebook_result (user_id, evaluation_id)'); |
||
94 | } |
||
95 | |||
96 | $table = $schema->getTable('gradebook_certificate'); |
||
97 | if (false === $table->hasColumn('downloaded_at')) { |
||
98 | $this->addSql('ALTER TABLE gradebook_certificate ADD downloaded_at DATETIME DEFAULT NULL;'); |
||
99 | $this->addSql( |
||
100 | 'UPDATE gradebook_certificate gc SET downloaded_at = ( |
||
101 | SELECT value from extra_field e |
||
102 | INNER JOIN extra_field_values v on v.field_id = e.id |
||
103 | WHERE variable = "downloaded_at" and extra_field_type = 11 and item_id = gc.id |
||
104 | )' |
||
105 | ); |
||
106 | } |
||
107 | |||
108 | $table = $schema->hasTable('gradebook_result_attempt'); |
||
109 | if (false === $table) { |
||
110 | $this->addSql( |
||
111 | 'CREATE TABLE gradebook_result_attempt (id INT AUTO_INCREMENT NOT NULL, comment LONGTEXT DEFAULT NULL, score DOUBLE PRECISION DEFAULT NULL, result_id INT NOT NULL, created_at DATETIME NOT NULL, updated_at DATETIME NOT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci ENGINE = InnoDB ROW_FORMAT = DYNAMIC;' |
||
112 | ); |
||
120 |