chamilo / chamilo-lms

plugin/xapi/src/ToolExperience/Activity/BaseActivity.php

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\PluginBundle\XApi\ToolExperience\Activity;

use Xabbuh\XApi\Model\Activity;

/**
 * Class BaseActivity.
 *
 * @package Chamilo\PluginBundle\XApi\ToolExperience\Activity
 */
abstract class BaseActivity
{
    /**
     * @var \Chamilo\UserBundle\Entity\User
     */
    protected $user;
    /**
     * @var \Chamilo\CoreBundle\Entity\Course|null
     */
    protected $course;
    /**
     * @var \Chamilo\CoreBundle\Entity\Session|null
     */
    protected $session;

    abstract public function generate(): Activity;

    protected function generateIri(string $path, string $resource, array $params = []): string
    {
        $cidReq = api_get_cidreq();

        $url = api_get_path($path).$resource;

        if ($params) {

The expression $params of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $url .= '?'.http_build_query($params).'&';
        } elseif (empty($params) && $cidReq) {
            $url .= '?';
        }

        if ($cidReq) {
            $url .= $cidReq;
        }

        return $url;
    }
}