Passed
Push — 1.11.x ( bce6cd...c146d9 )
by Angel Fernando Quiroz
12:25
created

plugin/toplinks/install.php (1 issue)

1
<?php
2
3
/* For license terms, see /license.txt */
4
5
$plugin = TopLinksPlugin::create()->install();
0 ignored issues
show
Are you sure the assignment to $plugin is correct as TopLinksPlugin::create()->install() targeting TopLinksPlugin::install() seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
6