Passed
Push — 1.10.x ( 08890a...2189d7 )
by Yannick
116:38 queued 75:46
created
main/inc/lib/search/ChamiloIndexer.class.php 3 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -71,6 +71,10 @@
 block discarded – undo
71 71
 
72 72
     /**
73 73
      * Get the terms stored at database
74
+     * @param string $prefix
75
+     * @param string $course_code
76
+     * @param string $tool_id
77
+     * @param integer $ref_id
74 78
      * @return  array Array of terms
75 79
      */
76 80
     function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id) {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 /**
8 8
  * code
9 9
  */
10
-require_once dirname(__FILE__) . '/../../global.inc.php';
10
+require_once dirname(__FILE__).'/../../global.inc.php';
11 11
 include_once 'xapian/XapianIndexer.class.php';
12 12
 
13 13
 /**
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         if ((count(array_diff($terms, $stored_terms)) == 0) && (count(array_diff($stored_terms, $terms)) == 0))
40 40
             return FALSE;
41 41
 
42
-        require_once api_get_path(LIBRARY_PATH) . 'search/xapian/XapianQuery.php';
42
+        require_once api_get_path(LIBRARY_PATH).'search/xapian/XapianQuery.php';
43 43
 
44 44
         // compare terms
45 45
         $doc = $this->get_document($search_did);
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 
56 56
         // save it to search engine
57 57
         foreach ($missing_terms as $term) {
58
-            $this->add_term_to_doc($prefix . $term, $doc);
58
+            $this->add_term_to_doc($prefix.$term, $doc);
59 59
         }
60 60
         foreach ($deprecated_terms as $term) {
61
-            $this->remove_term_from_doc($prefix . $term, $doc);
61
+            $this->remove_term_from_doc($prefix.$term, $doc);
62 62
         }
63 63
 
64 64
         // don't do anything if no change
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      * @return  array Array of terms
75 75
      */
76 76
     function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id) {
77
-        require_once api_get_path(LIBRARY_PATH) . 'specific_fields_manager.lib.php';
77
+        require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
78 78
         $terms = get_specific_field_values_list_by_prefix($prefix, $course_code, $tool_id, $ref_id);
79 79
         $prefix_terms = array();
80 80
         foreach ($terms as $term) {
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,8 +36,9 @@  discard block
 block discarded – undo
36 36
         $stored_terms = $this->get_terms_on_db($prefix, $course_code, $tool_id, $ref_id_high_level);
37 37
 
38 38
         // don't do anything if no change, verify only at DB, not the search engine
39
-        if ((count(array_diff($terms, $stored_terms)) == 0) && (count(array_diff($stored_terms, $terms)) == 0))
40
-            return FALSE;
39
+        if ((count(array_diff($terms, $stored_terms)) == 0) && (count(array_diff($stored_terms, $terms)) == 0)) {
40
+                    return FALSE;
41
+        }
41 42
 
42 43
         require_once api_get_path(LIBRARY_PATH) . 'search/xapian/XapianQuery.php';
43 44
 
@@ -45,8 +46,9 @@  discard block
 block discarded – undo
45 46
         $doc = $this->get_document($search_did);
46 47
         $xapian_terms = xapian_get_doc_terms($doc, $prefix);
47 48
         $xterms = array();
48
-        foreach ($xapian_terms as $xapian_term)
49
-            $xterms[] = substr($xapian_term['name'], 1);
49
+        foreach ($xapian_terms as $xapian_term) {
50
+                    $xterms[] = substr($xapian_term['name'], 1);
51
+        }
50 52
 
51 53
         $dterms = $terms;
52 54
 
Please login to merge, or discard this patch.
main/inc/lib/search/ChamiloQuery.php 3 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
     return chamilo_preprocess_results($results);
24 24
 }
25 25
 
26
+/**
27
+ * @param string $query_string
28
+ */
26 29
 function chamilo_query_simple_query($query_string, $offset=0, $length=10, $extra=NULL) {
27 30
     return xapian_query($query_string, NULL, $offset, $length, $extra);
28 31
 }
@@ -30,7 +33,7 @@  discard block
 block discarded – undo
30 33
 /**
31 34
  * Wrapper for getting boolean queries
32 35
  *
33
- * @param   string    $query_string   The term string
36
+ * @param string $term
34 37
  */
35 38
 function chamilo_get_boolean_query($term) {
36 39
   return xapian_get_boolean_query($term);
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -18,12 +18,12 @@  discard block
 block discarded – undo
18 18
  * @param   array     extra           Extra queries to join with. Optional
19 19
  * @return  array
20 20
  */
21
-function chamilo_query_query($query_string, $offset=0, $length=10, $extra=NULL) {
21
+function chamilo_query_query($query_string, $offset = 0, $length = 10, $extra = NULL) {
22 22
     list($count, $results) = xapian_query($query_string, NULL, $offset, $length, $extra);
23 23
     return chamilo_preprocess_results($results);
24 24
 }
25 25
 
26
-function chamilo_query_simple_query($query_string, $offset=0, $length=10, $extra=NULL) {
26
+function chamilo_query_simple_query($query_string, $offset = 0, $length = 10, $extra = NULL) {
27 27
     return xapian_query($query_string, NULL, $offset, $length, $extra);
28 28
 }
29 29
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 function chamilo_preprocess_results($results) {
43 43
     // group by toolid
44 44
     $results_by_tool = array();
45
-    if (count($results)>0) {
45
+    if (count($results) > 0) {
46 46
 
47 47
 	    foreach ($results as $key => $row) {
48 48
 	        $results_by_tool[$row['toolid']][] = $row;
@@ -50,8 +50,8 @@  discard block
 block discarded – undo
50 50
 
51 51
 	    $processed_results = array();
52 52
 	    foreach ($results_by_tool as $toolid => $rows) {
53
-	        $tool_processor_class = $toolid .'_processor';
54
-	        $tool_processor_path = api_get_path(LIBRARY_PATH) .'search/tool_processors/'. $tool_processor_class .'.class.php';
53
+	        $tool_processor_class = $toolid.'_processor';
54
+	        $tool_processor_path = api_get_path(LIBRARY_PATH).'search/tool_processors/'.$tool_processor_class.'.class.php';
55 55
 	        if (file_exists($tool_processor_path)) {
56 56
 	            require_once($tool_processor_path);
57 57
 	            $tool_processor = new $tool_processor_class($rows);
@@ -71,6 +71,6 @@  discard block
 block discarded – undo
71 71
  * @param string $op
72 72
  * @return XapianQuery query joined
73 73
  */
74
-function chamilo_join_queries($query1, $query2=NULL, $op='or') {
74
+function chamilo_join_queries($query1, $query2 = NULL, $op = 'or') {
75 75
 	return xapian_join_queries($query1, $query2, $op);
76 76
 }
Please login to merge, or discard this patch.
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
  * @param   string    $query_string   The term string
34 34
  */
35 35
 function chamilo_get_boolean_query($term) {
36
-  return xapian_get_boolean_query($term);
36
+    return xapian_get_boolean_query($term);
37 37
 }
38 38
 
39 39
 /**
@@ -44,22 +44,22 @@  discard block
 block discarded – undo
44 44
     $results_by_tool = array();
45 45
     if (count($results)>0) {
46 46
 
47
-	    foreach ($results as $key => $row) {
48
-	        $results_by_tool[$row['toolid']][] = $row;
49
-	    }
47
+        foreach ($results as $key => $row) {
48
+            $results_by_tool[$row['toolid']][] = $row;
49
+        }
50 50
 
51
-	    $processed_results = array();
52
-	    foreach ($results_by_tool as $toolid => $rows) {
53
-	        $tool_processor_class = $toolid .'_processor';
54
-	        $tool_processor_path = api_get_path(LIBRARY_PATH) .'search/tool_processors/'. $tool_processor_class .'.class.php';
55
-	        if (file_exists($tool_processor_path)) {
56
-	            require_once($tool_processor_path);
57
-	            $tool_processor = new $tool_processor_class($rows);
58
-	            $processed_results = array_merge($tool_processor->process(), $processed_results);
59
-	        }
60
-	    }
51
+        $processed_results = array();
52
+        foreach ($results_by_tool as $toolid => $rows) {
53
+            $tool_processor_class = $toolid .'_processor';
54
+            $tool_processor_path = api_get_path(LIBRARY_PATH) .'search/tool_processors/'. $tool_processor_class .'.class.php';
55
+            if (file_exists($tool_processor_path)) {
56
+                require_once($tool_processor_path);
57
+                $tool_processor = new $tool_processor_class($rows);
58
+                $processed_results = array_merge($tool_processor->process(), $processed_results);
59
+            }
60
+        }
61 61
 
62
-	    return array(count($processed_results), $processed_results);
62
+        return array(count($processed_results), $processed_results);
63 63
     }
64 64
 }
65 65
 
@@ -72,5 +72,5 @@  discard block
 block discarded – undo
72 72
  * @return XapianQuery query joined
73 73
  */
74 74
 function chamilo_join_queries($query1, $query2=NULL, $op='or') {
75
-	return xapian_join_queries($query1, $query2, $op);
75
+    return xapian_join_queries($query1, $query2, $op);
76 76
 }
Please login to merge, or discard this patch.
main/inc/lib/search/IndexableChunk.class.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -57,6 +57,7 @@  discard block
 block discarded – undo
57 57
      * Add a value to the indexed item
58 58
      * @param  string  Key
59 59
      * @param  string  Value
60
+     * @param string $key
60 61
      * @return  void
61 62
      */
62 63
     function addValue($key, $value) {
@@ -101,6 +102,7 @@  discard block
 block discarded – undo
101 102
 
102 103
     /**
103 104
      * Let add course id term
105
+     * @param string $course_id
104 106
      */
105 107
     public function addCourseId($course_id)
106 108
     {
@@ -109,6 +111,7 @@  discard block
 block discarded – undo
109 111
 
110 112
     /**
111 113
      * Let add tool id term
114
+     * @param string $tool_id
112 115
      */
113 116
     public function addToolId($tool_id)
114 117
     {
Please login to merge, or discard this patch.
main/inc/lib/search/search_widget.php 4 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -273,6 +273,8 @@
 block discarded – undo
273 273
 
274 274
 /**
275 275
  * Show search form
276
+ * @param string $action
277
+ * @param boolean $show_thesaurus
276 278
  */
277 279
 function display_search_form($action, $show_thesaurus, $sf_terms, $op) {
278 280
     $type = (!empty($_REQUEST['type'])? htmlentities($_REQUEST['type']): 'normal');
Please login to merge, or discard this patch.
Spacing   +67 added lines, -67 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 /**
8 8
  * Code
9 9
  */
10
-require_once dirname(__FILE__) . '/IndexableChunk.class.php';
10
+require_once dirname(__FILE__).'/IndexableChunk.class.php';
11 11
 require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
12 12
 
13 13
 /**
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
 /**
30 30
  * Get one term html select
31 31
  */
32
-function format_one_specific_field_select($prefix, $sf_term_array, $op, $extra_select_attr='size="7" class="sf-select-multiple"') {
32
+function format_one_specific_field_select($prefix, $sf_term_array, $op, $extra_select_attr = 'size="7" class="sf-select-multiple"') {
33 33
 	global $charset;
34
-    $multiple_select = '<select '. $extra_select_attr .' title="'. $prefix .'" id="sf-'. $prefix .'" name="sf_'. $prefix .'[]">';
34
+    $multiple_select = '<select '.$extra_select_attr.' title="'.$prefix.'" id="sf-'.$prefix.'" name="sf_'.$prefix.'[]">';
35 35
 
36 36
     $all_selected = '';
37
-    if (!empty($_REQUEST['sf_'. $prefix]) ) {
38
-        if (in_array('__all__', $_REQUEST['sf_'. $prefix])) {
37
+    if (!empty($_REQUEST['sf_'.$prefix])) {
38
+        if (in_array('__all__', $_REQUEST['sf_'.$prefix])) {
39 39
             $all_selected = 'selected="selected"';
40 40
         }
41 41
     }
@@ -44,17 +44,17 @@  discard block
 block discarded – undo
44 44
     } else if ($op == 'or') {
45 45
         $all_selected_name = get_lang('Any');
46 46
     }
47
-    $multiple_select .= '<option value="__all__" '. $all_selected .' >-- '. $all_selected_name .' --</option>';
47
+    $multiple_select .= '<option value="__all__" '.$all_selected.' >-- '.$all_selected_name.' --</option>';
48 48
 
49 49
     foreach ($sf_term_array as $raw_term) {
50 50
         $term = substr($raw_term, 1);
51 51
         if (empty($term)) continue;
52 52
         $html_term = htmlspecialchars($term, ENT_QUOTES, $charset);
53 53
         $selected = '';
54
-        if (!empty($_REQUEST['sf_'.$prefix]) && is_array($_REQUEST['sf_'.$prefix]) && in_array($term,$_REQUEST['sf_'.$prefix])) {
54
+        if (!empty($_REQUEST['sf_'.$prefix]) && is_array($_REQUEST['sf_'.$prefix]) && in_array($term, $_REQUEST['sf_'.$prefix])) {
55 55
             $selected = 'selected="selected"';
56 56
         }
57
-        $multiple_select .= '<option value="'. $html_term .'" '.$selected.'>'. $html_term .'</option>';
57
+        $multiple_select .= '<option value="'.$html_term.'" '.$selected.'>'.$html_term.'</option>';
58 58
     }
59 59
     $multiple_select .= '</select>';
60 60
     return $multiple_select;
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
 /**
64 64
  * Get terms html selects
65 65
  */
66
-function format_specific_fields_selects($sf_terms, $op, $prefilter_prefix='') {
66
+function format_specific_fields_selects($sf_terms, $op, $prefilter_prefix = '') {
67 67
     // Process each prefix type term
68 68
     $i = 0;
69 69
     $max = count($sf_terms);
70
-    $multiple_selects .='';
70
+    $multiple_selects .= '';
71 71
     foreach ($sf_terms as $prefix => $sf_term_array) {
72 72
         if ($prefix == $prefilter_prefix) continue;
73 73
         $multiple_select = '';
74
-        if ($i>0) {
74
+        if ($i > 0) {
75 75
             //print "+" image
76 76
             $multiple_select .= '<td><img class="sf-select-splitter" src="../img/search-big-plus.gif" alt="plus-sign-decoration"/></td>';
77 77
         }
@@ -89,9 +89,9 @@  discard block
 block discarded – undo
89 89
 
90 90
         $sf_copy = $sf_term_array;
91 91
         // get specific field name
92
-        $sf_value = get_specific_field_list(array( 'code' => "'$prefix'" ));
92
+        $sf_value = get_specific_field_list(array('code' => "'$prefix'"));
93 93
         $sf_value = array_shift($sf_value);
94
-        $multiple_select .= '<td><label class="sf-select-multiple-title" for="sf_'. $prefix .'[]">'.$icons_for_search_terms[$prefix].' '.$sf_value['name'].'</label><br />';
94
+        $multiple_select .= '<td><label class="sf-select-multiple-title" for="sf_'.$prefix.'[]">'.$icons_for_search_terms[$prefix].' '.$sf_value['name'].'</label><br />';
95 95
         $multiple_select .= format_one_specific_field_select($prefix, $sf_term_array, $op, 'multiple="multiple" size="7" class="sf-select-multiple"');
96 96
         $multiple_select .= '</td>';
97 97
         $multiple_selects .= $multiple_select;
@@ -107,11 +107,11 @@  discard block
 block discarded – undo
107 107
  */
108 108
 function search_widget_normal_form($action, $show_thesaurus, $sf_terms, $op) {
109 109
     $thesaurus_icon = Display::return_icon('thesaurus.gif', get_lang('SearchAdvancedOptions'), array('id'=>'thesaurus-icon'));
110
-    $advanced_options = '<a id="tags-toggle" href="#">'.  get_lang('SearchAdvancedOptions') .'</a>';
111
-    $display_thesaurus = ($show_thesaurus==true? 'block': 'none');
112
-    $help = '<h3>'. get_lang('SearchKeywordsHelpTitle') .'</h3>'. get_lang('SearchKeywordsHelpComment');
113
-    $mode = (!empty($_REQUEST['mode'])? htmlentities($_REQUEST['mode']): 'gallery');
114
-    $type = (!empty($_REQUEST['type'])? htmlentities($_REQUEST['type']): 'normal');
110
+    $advanced_options = '<a id="tags-toggle" href="#">'.get_lang('SearchAdvancedOptions').'</a>';
111
+    $display_thesaurus = ($show_thesaurus == true ? 'block' : 'none');
112
+    $help = '<h3>'.get_lang('SearchKeywordsHelpTitle').'</h3>'.get_lang('SearchKeywordsHelpComment');
113
+    $mode = (!empty($_REQUEST['mode']) ? htmlentities($_REQUEST['mode']) : 'gallery');
114
+    $type = (!empty($_REQUEST['type']) ? htmlentities($_REQUEST['type']) : 'normal');
115 115
 
116 116
     /**
117 117
      * POST avoid long urls, but we are using GET because
@@ -119,34 +119,34 @@  discard block
 block discarded – undo
119 119
      * could not send a form in pagination
120 120
      */
121 121
 
122
-	if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
123
-		$action='index.php';
122
+	if (isset($_GET['action']) && strcmp(trim($_GET['action']), 'search') === 0) {
123
+		$action = 'index.php';
124 124
 	}
125 125
 	$navigator_info = api_get_navigator();
126 126
 
127
-	if ($navigator_info['name']=='Internet Explorer' &&  $navigator_info['version']=='6') {
128
-		$submit_button1	= '<input type="submit" id="submit" value="'. get_lang('Search') .'" />';
129
-		$submit_button2 = '<input class="lower-submit" type="submit" value="'. get_lang('Search') .'" />';
130
-        $reset_button 	= '<input type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords') .'" />';
127
+	if ($navigator_info['name'] == 'Internet Explorer' && $navigator_info['version'] == '6') {
128
+		$submit_button1	= '<input type="submit" id="submit" value="'.get_lang('Search').'" />';
129
+		$submit_button2 = '<input class="lower-submit" type="submit" value="'.get_lang('Search').'" />';
130
+        $reset_button = '<input type="submit" id="tags-clean" value="'.get_lang('SearchResetKeywords').'" />';
131 131
 	} else {
132
-		$submit_button1 = '<button class="search" type="submit" id="submit" value="'. get_lang("Search") .'" /> '. get_lang('Search') .'</button>';
133
-		$submit_button2 = '<button class="search" type="submit" value="'. get_lang('Search') .'" />'. get_lang('Search') .'</button>';
134
-        $reset_button 	= '<button class="save"   type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords') .'" />'. get_lang('SearchResetKeywords') .'</button> ';
132
+		$submit_button1 = '<button class="search" type="submit" id="submit" value="'.get_lang("Search").'" /> '.get_lang('Search').'</button>';
133
+		$submit_button2 = '<button class="search" type="submit" value="'.get_lang('Search').'" />'.get_lang('Search').'</button>';
134
+        $reset_button = '<button class="save"   type="submit" id="tags-clean" value="'.get_lang('SearchResetKeywords').'" />'.get_lang('SearchResetKeywords').'</button> ';
135 135
 	}
136 136
 
137
-    $form = '<form id="chamilo_search" action="'. $action .'" method="GET">
137
+    $form = '<form id="chamilo_search" action="'.$action.'" method="GET">
138 138
             <input type="text" id="query" name="query" size="40" value="'.stripslashes(Security::remove_XSS($_REQUEST['query'])).'" />
139
-            <input type="hidden" name="mode" value="'. $mode .'"/>
140
-            <input type="hidden" name="type" value="'. $type .'"/>
139
+            <input type="hidden" name="mode" value="'. $mode.'"/>
140
+            <input type="hidden" name="type" value="'. $type.'"/>
141 141
             <input type="hidden" name="tablename_page_nr" value="1" />
142 142
           	'.$submit_button1.'
143 143
             <br /><br />';
144 144
     $list = get_specific_field_list();
145 145
 
146
-    if(!empty($list)) {
147
-        $form .= '<span class="search-links-box">'. $advanced_options .'&nbsp;</span>
148
-            <div id="tags" class="tags" style="display:'. $display_thesaurus .';">
149
-                <div class="search-help-box">'. $help .'</div>
146
+    if (!empty($list)) {
147
+        $form .= '<span class="search-links-box">'.$advanced_options.'&nbsp;</span>
148
+            <div id="tags" class="tags" style="display:'. $display_thesaurus.';">
149
+                <div class="search-help-box">'. $help.'</div>
150 150
                 <table>
151 151
                 <tr>';
152 152
         $form .= format_specific_fields_selects($sf_terms, $op);
@@ -160,9 +160,9 @@  discard block
 block discarded – undo
160 160
         $form .= '</tr>
161 161
                     <tr>
162 162
                         <td id="operator-select">
163
-                            '. get_lang('SearchCombineSearchWith') .':<br />
164
-                            <input type="radio" class="search-operator" name="operator" value="or" '. $or_checked .'>'. api_strtoupper(get_lang('Or')) .'</input>
165
-                            <input type="radio" class="search-operator" name="operator" value="and" '. $and_checked .'>'. api_strtoupper(get_lang('And')) .'</input>
163
+                            '. get_lang('SearchCombineSearchWith').':<br />
164
+                            <input type="radio" class="search-operator" name="operator" value="or" '. $or_checked.'>'.api_strtoupper(get_lang('Or')).'</input>
165
+                            <input type="radio" class="search-operator" name="operator" value="and" '. $and_checked.'>'.api_strtoupper(get_lang('And')).'</input>
166 166
                         </td>
167 167
                         <td></td>
168 168
                         <td>
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                     </table>
175 175
                 </div>';
176 176
     }
177
-    $form .='</form>
177
+    $form .= '</form>
178 178
     <br style="clear: both;"/>';
179 179
     return $form;
180 180
 }
@@ -184,36 +184,36 @@  discard block
 block discarded – undo
184 184
  *
185 185
  * This type allow filter all other multiple select terms by one term in a dinamic way
186 186
  */
187
-function search_widget_prefilter_form($action, $show_thesaurus, $sf_terms, $op, $prefilter_prefix=NULL) {
187
+function search_widget_prefilter_form($action, $show_thesaurus, $sf_terms, $op, $prefilter_prefix = NULL) {
188 188
     $thesaurus_icon = Display::return_icon('thesaurus.gif', get_lang('SearchAdvancedOptions'), array('id'=>'thesaurus-icon'));
189
-    $advanced_options = '<a id="tags-toggle" href="#">'.  get_lang('SearchAdvancedOptions') .'</a>';
190
-    $display_thesaurus = ($show_thesaurus==true? 'block': 'none');
191
-    $help = '<h3>'. get_lang('SearchKeywordsHelpTitle') .'</h3>'. get_lang('SearchKeywordsHelpComment');
192
-    $mode = (!empty($_REQUEST['mode'])? htmlentities($_REQUEST['mode']): 'gallery');
193
-    $type = (!empty($_REQUEST['type'])? htmlentities($_REQUEST['type']): 'normal');
189
+    $advanced_options = '<a id="tags-toggle" href="#">'.get_lang('SearchAdvancedOptions').'</a>';
190
+    $display_thesaurus = ($show_thesaurus == true ? 'block' : 'none');
191
+    $help = '<h3>'.get_lang('SearchKeywordsHelpTitle').'</h3>'.get_lang('SearchKeywordsHelpComment');
192
+    $mode = (!empty($_REQUEST['mode']) ? htmlentities($_REQUEST['mode']) : 'gallery');
193
+    $type = (!empty($_REQUEST['type']) ? htmlentities($_REQUEST['type']) : 'normal');
194 194
 
195 195
     /**
196 196
      * POST avoid long urls, but we are using GET because
197 197
      * SortableTableFromArray pagination is done with simple links, so now we
198 198
      * could not send a form in pagination
199 199
      */
200
-	if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
201
-		$action='index.php';
200
+	if (isset($_GET['action']) && strcmp(trim($_GET['action']), 'search') === 0) {
201
+		$action = 'index.php';
202 202
 	}
203 203
 
204 204
     $form = '
205
-        <form id="chamilo_search" action="'. $action .'" method="GET">
205
+        <form id="chamilo_search" action="'. $action.'" method="GET">
206 206
             <input type="text" id="query" name="query" size="40" />
207
-            <input type="hidden" name="mode" value="'. $mode .'"/>
208
-            <input type="hidden" name="type" value="'. $type .'"/>
207
+            <input type="hidden" name="mode" value="'. $mode.'"/>
208
+            <input type="hidden" name="type" value="'. $type.'"/>
209 209
             <input type="hidden" name="tablename_page_nr" value="1" />
210
-            <input type="submit" id="submit" value="'. get_lang("Search") .'" />
210
+            <input type="submit" id="submit" value="'. get_lang("Search").'" />
211 211
             <br /><br />';
212 212
         $list = get_specific_field_list();
213
-        if(!empty($list)) {
214
-            $form .=' <span class="search-links-box">'. $thesaurus_icon . $advanced_options .'&nbsp;</span>
215
-                    <div id="tags" class="tags" style="display:'. $display_thesaurus .';">
216
-                        <div class="search-help-box">'. $help .'</div>
213
+        if (!empty($list)) {
214
+            $form .= ' <span class="search-links-box">'.$thesaurus_icon.$advanced_options.'&nbsp;</span>
215
+                    <div id="tags" class="tags" style="display:'. $display_thesaurus.';">
216
+                        <div class="search-help-box">'. $help.'</div>
217 217
                         <table>
218 218
                         <tr>';
219 219
             if (!is_null($prefilter_prefix)) {
@@ -228,9 +228,9 @@  discard block
 block discarded – undo
228 228
                 $sf_term_array = $temp;
229 229
 
230 230
                 // get specific field name
231
-                $sf_value = get_specific_field_list(array( 'code' => "'$prefilter_prefix'" ));
231
+                $sf_value = get_specific_field_list(array('code' => "'$prefilter_prefix'"));
232 232
                 $sf_value = array_shift($sf_value);
233
-                $form .= '<label class="sf-select-multiple-title" for="sf_'. $prefix .'[]">'.$icons_for_search_terms[$prefix].' '.$sf_value['name'].'</label><br />';
233
+                $form .= '<label class="sf-select-multiple-title" for="sf_'.$prefix.'[]">'.$icons_for_search_terms[$prefix].' '.$sf_value['name'].'</label><br />';
234 234
 
235 235
                 $form .= format_one_specific_field_select($prefilter_prefix, $sf_term_array, $op, 'id="prefilter"');
236 236
                 $form .= format_specific_fields_selects($sf_terms, $op, $prefilter_prefix);
@@ -250,15 +250,15 @@  discard block
 block discarded – undo
250 250
                         </tr>
251 251
                         <tr>
252 252
                             <td id="operator-select">
253
-                                '. get_lang('SearchCombineSearchWith') .':<br />
254
-                                <input type="radio" class="search-operator" name="operator" value="or" '. $or_checked .'>'. api_strtoupper(get_lang('Or')) .'</input>
255
-                                <input type="radio" class="search-operator" name="operator" value="and" '. $and_checked .'>'. api_strtoupper(get_lang('And')) .'</input>
253
+                                '. get_lang('SearchCombineSearchWith').':<br />
254
+                                <input type="radio" class="search-operator" name="operator" value="or" '. $or_checked.'>'.api_strtoupper(get_lang('Or')).'</input>
255
+                                <input type="radio" class="search-operator" name="operator" value="and" '. $and_checked.'>'.api_strtoupper(get_lang('And')).'</input>
256 256
                             </td>
257 257
                             <td></td>
258 258
                             <td>
259 259
                                 <br />
260
-                                <input class="lower-submit" type="submit" value="'. get_lang('Search') .'" />
261
-                                <input type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords') .'" />
260
+                                <input class="lower-submit" type="submit" value="'. get_lang('Search').'" />
261
+                                <input type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords').'" />
262 262
                             </td>
263 263
                         </tr>
264 264
                         </table>
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
  * Show search form
276 276
  */
277 277
 function display_search_form($action, $show_thesaurus, $sf_terms, $op) {
278
-    $type = (!empty($_REQUEST['type'])? htmlentities($_REQUEST['type']): 'normal');
278
+    $type = (!empty($_REQUEST['type']) ? htmlentities($_REQUEST['type']) : 'normal');
279 279
 
280 280
     switch ($type) {
281 281
         case 'prefilter':
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
  * @param   string $action     Just in case your action is not
303 303
  * index.php
304 304
  */
305
-function search_widget_show($action='index.php')
305
+function search_widget_show($action = 'index.php')
306 306
 {
307 307
     require_once api_get_path(LIBRARY_PATH).'search/ChamiloQuery.php';
308 308
     // TODO: load images dinamically when they're avalaible from specific field ui to add
@@ -315,14 +315,14 @@  discard block
 block discarded – undo
315 315
     if (($cid = api_get_course_id()) != -1) { // with cid
316 316
 
317 317
         // get search engine terms
318
-        $course_filter = chamilo_get_boolean_query(XAPIAN_PREFIX_COURSEID . $cid);
318
+        $course_filter = chamilo_get_boolean_query(XAPIAN_PREFIX_COURSEID.$cid);
319 319
         $dkterms = chamilo_query_simple_query('', 0, 1000, array($course_filter));
320 320
 
321 321
         //prepare specific fields names (and also get possible URL param names)
322 322
         foreach ($specific_fields as $specific_field) {
323 323
             $temp = array();
324
-            if (is_array($dkterms) && count($dkterms)>0) {
325
-            	foreach($dkterms[1] as $obj) {
324
+            if (is_array($dkterms) && count($dkterms) > 0) {
325
+            	foreach ($dkterms[1] as $obj) {
326 326
                 	$temp = array_merge($obj['sf-'.$specific_field['code']], $temp);
327 327
             	}
328 328
         	}
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
     }
351 351
 
352 352
     $op = 'or';
353
-    if (!empty($_REQUEST['operator']) && in_array($op,array('or','and'))) {
353
+    if (!empty($_REQUEST['operator']) && in_array($op, array('or', 'and'))) {
354 354
         $op = $_REQUEST['operator'];
355 355
     }
356 356
 
Please login to merge, or discard this patch.
Braces   +12 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,7 +48,9 @@  discard block
 block discarded – undo
48 48
 
49 49
     foreach ($sf_term_array as $raw_term) {
50 50
         $term = substr($raw_term, 1);
51
-        if (empty($term)) continue;
51
+        if (empty($term)) {
52
+            continue;
53
+        }
52 54
         $html_term = htmlspecialchars($term, ENT_QUOTES, $charset);
53 55
         $selected = '';
54 56
         if (!empty($_REQUEST['sf_'.$prefix]) && is_array($_REQUEST['sf_'.$prefix]) && in_array($term,$_REQUEST['sf_'.$prefix])) {
@@ -69,7 +71,9 @@  discard block
 block discarded – undo
69 71
     $max = count($sf_terms);
70 72
     $multiple_selects .='';
71 73
     foreach ($sf_terms as $prefix => $sf_term_array) {
72
-        if ($prefix == $prefilter_prefix) continue;
74
+        if ($prefix == $prefilter_prefix) {
75
+            continue;
76
+        }
73 77
         $multiple_select = '';
74 78
         if ($i>0) {
75 79
             //print "+" image
@@ -342,9 +346,10 @@  discard block
 block discarded – undo
342 346
 
343 347
 	// Tool introduction
344 348
     // TODO: Settings for the online editor to be checked (insert an image for example). Probably this is a special case here.
345
-    if (api_get_course_id() !== -1)
346
-    if (!empty($groupId)) {
349
+    if (api_get_course_id() !== -1) {
350
+        if (!empty($groupId)) {
347 351
         Display::display_introduction_section(TOOL_SEARCH.$groupId);
352
+    }
348 353
     } else {
349 354
         Display::display_introduction_section(TOOL_SEARCH);
350 355
     }
@@ -366,7 +371,9 @@  discard block
 block discarded – undo
366 371
                     break;
367 372
                 }
368 373
             }
369
-            if ($thesaurus_decided) break;
374
+            if ($thesaurus_decided) {
375
+                break;
376
+            }
370 377
         }
371 378
     }
372 379
 
Please login to merge, or discard this patch.
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
  * Get one term html select
31 31
  */
32 32
 function format_one_specific_field_select($prefix, $sf_term_array, $op, $extra_select_attr='size="7" class="sf-select-multiple"') {
33
-	global $charset;
33
+    global $charset;
34 34
     $multiple_select = '<select '. $extra_select_attr .' title="'. $prefix .'" id="sf-'. $prefix .'" name="sf_'. $prefix .'[]">';
35 35
 
36 36
     $all_selected = '';
@@ -119,20 +119,20 @@  discard block
 block discarded – undo
119 119
      * could not send a form in pagination
120 120
      */
121 121
 
122
-	if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
123
-		$action='index.php';
124
-	}
125
-	$navigator_info = api_get_navigator();
122
+    if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
123
+        $action='index.php';
124
+    }
125
+    $navigator_info = api_get_navigator();
126 126
 
127
-	if ($navigator_info['name']=='Internet Explorer' &&  $navigator_info['version']=='6') {
128
-		$submit_button1	= '<input type="submit" id="submit" value="'. get_lang('Search') .'" />';
129
-		$submit_button2 = '<input class="lower-submit" type="submit" value="'. get_lang('Search') .'" />';
127
+    if ($navigator_info['name']=='Internet Explorer' &&  $navigator_info['version']=='6') {
128
+        $submit_button1	= '<input type="submit" id="submit" value="'. get_lang('Search') .'" />';
129
+        $submit_button2 = '<input class="lower-submit" type="submit" value="'. get_lang('Search') .'" />';
130 130
         $reset_button 	= '<input type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords') .'" />';
131
-	} else {
132
-		$submit_button1 = '<button class="search" type="submit" id="submit" value="'. get_lang("Search") .'" /> '. get_lang('Search') .'</button>';
133
-		$submit_button2 = '<button class="search" type="submit" value="'. get_lang('Search') .'" />'. get_lang('Search') .'</button>';
131
+    } else {
132
+        $submit_button1 = '<button class="search" type="submit" id="submit" value="'. get_lang("Search") .'" /> '. get_lang('Search') .'</button>';
133
+        $submit_button2 = '<button class="search" type="submit" value="'. get_lang('Search') .'" />'. get_lang('Search') .'</button>';
134 134
         $reset_button 	= '<button class="save"   type="submit" id="tags-clean" value="'. get_lang('SearchResetKeywords') .'" />'. get_lang('SearchResetKeywords') .'</button> ';
135
-	}
135
+    }
136 136
 
137 137
     $form = '<form id="chamilo_search" action="'. $action .'" method="GET">
138 138
             <input type="text" id="query" name="query" size="40" value="'.stripslashes(Security::remove_XSS($_REQUEST['query'])).'" />
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
      * SortableTableFromArray pagination is done with simple links, so now we
198 198
      * could not send a form in pagination
199 199
      */
200
-	if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
201
-		$action='index.php';
202
-	}
200
+    if (isset($_GET['action']) && strcmp(trim($_GET['action']),'search')===0) {
201
+        $action='index.php';
202
+    }
203 203
 
204 204
     $form = '
205 205
         <form id="chamilo_search" action="'. $action .'" method="GET">
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
                         </table>
265 265
                     </div>';
266 266
         }
267
-       $form .= '
267
+        $form .= '
268 268
         </form>
269 269
         <br style="clear: both;"/>';
270 270
 
@@ -322,10 +322,10 @@  discard block
 block discarded – undo
322 322
         foreach ($specific_fields as $specific_field) {
323 323
             $temp = array();
324 324
             if (is_array($dkterms) && count($dkterms)>0) {
325
-            	foreach($dkterms[1] as $obj) {
326
-                	$temp = array_merge($obj['sf-'.$specific_field['code']], $temp);
327
-            	}
328
-        	}
325
+                foreach($dkterms[1] as $obj) {
326
+                    $temp = array_merge($obj['sf-'.$specific_field['code']], $temp);
327
+                }
328
+            }
329 329
             $sf_terms[$specific_field['code']] = $temp;
330 330
             $url_params[] = 'sf_'.$specific_field['code'];
331 331
             unset($temp);
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
     }
341 341
     echo '<h2>'.get_lang('Search').'</h2>';
342 342
 
343
-	// Tool introduction
343
+    // Tool introduction
344 344
     // TODO: Settings for the online editor to be checked (insert an image for example). Probably this is a special case here.
345 345
     if (api_get_course_id() !== -1)
346 346
     if (!empty($groupId)) {
Please login to merge, or discard this patch.
main/inc/lib/search/xapian/XapianIndexer.class.php 3 patches
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 
99 99
     /**
100 100
      * Simple getter for the db attribute
101
-     * @return  object  The db attribute
101
+     * @return  null|XapianWritableDatabase  The db attribute
102 102
      */
103 103
     function getDb()
104 104
     {
@@ -108,6 +108,7 @@  discard block
 block discarded – undo
108 108
     /**
109 109
      * Add this chunk to the chunk array attribute
110 110
      * @param  string  Chunk of text
111
+     * @param IndexableChunk $chunk
111 112
      * @return  void
112 113
      */
113 114
     function addChunk($chunk)
@@ -179,7 +180,7 @@  discard block
 block discarded – undo
179 180
      * Get document data on a xapian document
180 181
      *
181 182
      * @param XapianDocument $doc xapian document to push into the db
182
-     * @return mixed xapian document data or FALSE if error
183
+     * @return string xapian document data or FALSE if error
183 184
      */
184 185
     function get_document_data($doc)
185 186
     {
@@ -286,7 +287,7 @@  discard block
 block discarded – undo
286 287
      * Replace a document in the actual db
287 288
      *
288 289
      * @param XapianDocument $doc xapian document to push into the db
289
-     * @param Xapian::docid $did xapian document id of the document to replace
290
+     * @param integer $did xapian document id of the document to replace
290 291
      */
291 292
     function replace_document($doc, $did)
292 293
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
  */
7 7
 
8 8
 require_once 'xapian.php';
9
-require_once dirname(__FILE__) . '/../IndexableChunk.class.php';
9
+require_once dirname(__FILE__).'/../IndexableChunk.class.php';
10 10
 
11 11
 /**
12 12
  * Abstract helper class
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
                     if (!empty($chunk->terms)) {
131 131
                         foreach ($chunk->terms as $term) {
132 132
                             /* FIXME: think of getting weight */
133
-                            $doc->add_term($term['flag'] . $term['name'], 1);
133
+                            $doc->add_term($term['flag'].$term['name'], 1);
134 134
                         }
135 135
                     }
136 136
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         $doc->clear_terms();
216 216
         foreach ($terms as $term) {
217 217
             //add directly
218
-            $doc->add_term($prefix . $term, 1);
218
+            $doc->add_term($prefix.$term, 1);
219 219
         }
220 220
         $this->db->replace_document($did, $doc);
221 221
         $this->db->flush();
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -70,13 +70,16 @@
 block discarded – undo
70 70
      */
71 71
     function connectDb($path = null, $dbMode = null, $lang = 'english')
72 72
     {
73
-        if ($this->db != null)
74
-            return $this->db;
75
-        if ($dbMode == null)
76
-            $dbMode = Xapian::DB_CREATE_OR_OPEN;
73
+        if ($this->db != null) {
74
+                    return $this->db;
75
+        }
76
+        if ($dbMode == null) {
77
+                    $dbMode = Xapian::DB_CREATE_OR_OPEN;
78
+        }
77 79
 
78
-        if ($path == null)
79
-            $path = api_get_path(SYS_UPLOAD_PATH).'plugins/xapian/searchdb/';
80
+        if ($path == null) {
81
+                    $path = api_get_path(SYS_UPLOAD_PATH).'plugins/xapian/searchdb/';
82
+        }
80 83
 
81 84
         try {
82 85
             $this->db = new XapianWritableDatabase($path, $dbMode);
Please login to merge, or discard this patch.
main/inc/lib/security.lib.php 3 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,8 @@  discard block
 block discarded – undo
45 45
      * checker path (directory)
46 46
      * @param	string	Absolute path to be checked (with trailing slash)
47 47
      * @param	string	Checker path under which the path should be (absolute path, with trailing slash, get it from api_get_path(SYS_COURSE_PATH))
48
+     * @param string $abs_path
49
+     * @param string $checker_path
48 50
      * @return	bool	True if the path is under the checker, false otherwise
49 51
      */
50 52
     public static function check_abs_path($abs_path, $checker_path)
@@ -300,6 +302,7 @@  discard block
 block discarded – undo
300 302
      * @param string	The variable to filter for XSS, this params can be a string or an array (example : array(x,y))
301 303
      * @param int The user status,constant allowed (STUDENT, COURSEMANAGER, ANONYMOUS, COURSEMANAGERLOWSECURITY)
302 304
      * @param bool $filter_terms
305
+     * @param integer $user_status
303 306
      * @return	mixed	Filtered string or array
304 307
      */
305 308
     public static function remove_XSS($var, $user_status = null, $filter_terms = false)
@@ -453,7 +456,7 @@  discard block
 block discarded – undo
453 456
      * This method provides specific protection (against XSS and other kinds of attacks) for static images (icons) used by the system.
454 457
      * Image paths are supposed to be given by programmers - people who know what they do, anyway, this method encourages
455 458
      * a safe practice for generating icon paths, without using heavy solutions based on HTMLPurifier for example.
456
-     * @param string $img_path          The input path of the image, it could be relative or absolute URL.
459
+     * @param string $image_path          The input path of the image, it could be relative or absolute URL.
457 460
      * @return string                   Returns sanitized image path or an empty string when the image path is not secure.
458 461
      * @author Ivan Tcholakov, March 2011
459 462
      */
Please login to merge, or discard this patch.
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -304,9 +304,9 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public static function remove_XSS($var, $user_status = null, $filter_terms = false)
306 306
     {
307
-    	if ($filter_terms) {
308
-    		$var = self::filter_terms($var);
309
-    	}
307
+        if ($filter_terms) {
308
+            $var = self::filter_terms($var);
309
+        }
310 310
 
311 311
         if (empty($user_status)) {
312 312
             if (api_is_anonymous()) {
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
      */
402 402
     static function filter_terms($text)
403 403
     {
404
-    	static $bad_terms = array();
404
+        static $bad_terms = array();
405 405
 
406 406
         if (empty($bad_terms)) {
407 407
             $list = api_get_setting('filter_terms');
@@ -420,14 +420,14 @@  discard block
 block discarded – undo
420 420
             }
421 421
         }
422 422
 
423
-    	$replace = '***';
423
+        $replace = '***';
424 424
 
425
-    	if (!empty($bad_terms)) {
426
-    		//Fast way
427
-    		$new_text = str_ireplace($bad_terms, $replace, $text, $count);
425
+        if (!empty($bad_terms)) {
426
+            //Fast way
427
+            $new_text = str_ireplace($bad_terms, $replace, $text, $count);
428 428
 
429
-    		//We need statistics
430
-    		/*
429
+            //We need statistics
430
+            /*
431 431
     		if (strlen($new_text) != strlen($text)) {
432 432
     			$table = Database::get_main_table(TABLE_STATISTIC_TRACK_FILTERED_TERMS);
433 433
     			$attributes = array();
@@ -442,10 +442,10 @@  discard block
 block discarded – undo
442 442
     			$sql = Database::insert($table, $attributes);
443 443
     		}
444 444
     		*/
445
-    		$text = $new_text;
445
+            $text = $new_text;
446 446
 
447
-    	}
448
-		return $text;
447
+        }
448
+        return $text;
449 449
     }
450 450
 
451 451
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
             $rel_path = '/'.$rel_path;
92 92
         }
93 93
         $abs_path = $current_path.$rel_path;
94
-        $true_path=str_replace("\\", '/', realpath($abs_path));
94
+        $true_path = str_replace("\\", '/', realpath($abs_path));
95 95
         $found = strpos($true_path.'/', $checker_path);
96 96
         if ($found === 0) {
97 97
             return true;
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
         }
322 322
 
323 323
         if ($user_status == COURSEMANAGERLOWSECURITY) {
324
-            return $var;  // No filtering.
324
+            return $var; // No filtering.
325 325
         }
326 326
 
327 327
         static $purifier = array();
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
             }
345 345
 
346 346
             // Shows _target attribute in anchors
347
-            $config->set('Attr.AllowedFrameTargets', array('_blank','_top','_self', '_parent'));
347
+            $config->set('Attr.AllowedFrameTargets', array('_blank', '_top', '_self', '_parent'));
348 348
 
349 349
             if ($user_status == STUDENT) {
350 350
                 global $allowed_html_student;
Please login to merge, or discard this patch.
main/inc/lib/sessionmanager.lib.php 4 patches
Doc Comments   +25 added lines, -20 removed lines patch added patch discarded remove patch
@@ -1336,9 +1336,9 @@  discard block
 block discarded – undo
1336 1336
      * @param integer   $sessionCategoryId
1337 1337
      * @param int       $visibility
1338 1338
      * @param string    $description
1339
-     * @param bool      $showDescription
1339
+     * @param integer      $showDescription
1340 1340
      * @param int       $duration
1341
-     * @param array     $extraFields
1341
+     * @param boolean|null     $extraFields
1342 1342
      * @param int       $sessionAdminId
1343 1343
      * @param boolean $sendSubscriptionNotification Optional.
1344 1344
      *          Whether send a mail notification to users being subscribed
@@ -1558,7 +1558,7 @@  discard block
 block discarded – undo
1558 1558
      * @param array $user_list
1559 1559
      * @param int $session_visibility
1560 1560
      * @param bool $empty_users
1561
-     * @return bool
1561
+     * @return false|null
1562 1562
      */
1563 1563
     public static function suscribe_users_to_session(
1564 1564
         $id_session,
@@ -1830,7 +1830,7 @@  discard block
 block discarded – undo
1830 1830
      * @param array $courseInfo
1831 1831
      * @param int $status
1832 1832
      * @param bool $updateTotal
1833
-     * @return bool
1833
+     * @return false|null
1834 1834
      */
1835 1835
     public static function removeUsersFromCourseSession(
1836 1836
         $userList,
@@ -1896,7 +1896,7 @@  discard block
 block discarded – undo
1896 1896
      * @param string $course_code
1897 1897
      * @param int $session_visibility
1898 1898
      * @param bool $removeUsersNotInList
1899
-     * @return bool
1899
+     * @return false|null
1900 1900
      */
1901 1901
     public static function subscribe_users_to_session_course(
1902 1902
         $user_list,
@@ -2079,7 +2079,7 @@  discard block
 block discarded – undo
2079 2079
      * @param	bool	$removeExistingCoursesWithUsers Whether to unsubscribe
2080 2080
      * existing courses and users (true, default) or not (false)
2081 2081
      * @param $copyEvaluation from base course to session course
2082
-     * @return	void	Nothing, or false on error
2082
+     * @return	false|null	Nothing, or false on error
2083 2083
      * */
2084 2084
     public static function add_courses_to_session(
2085 2085
         $sessionId,
@@ -2275,6 +2275,8 @@  discard block
 block discarded – undo
2275 2275
      *
2276 2276
      * @param int Session id
2277 2277
      * @param int Course id
2278
+     * @param integer $session_id
2279
+     * @param integer $course_id
2278 2280
      * @return bool True in case of success, false otherwise
2279 2281
      */
2280 2282
     public static function unsubscribe_course_from_session($session_id, $course_id)
@@ -2330,7 +2332,7 @@  discard block
 block discarded – undo
2330 2332
      * @param	string	$variable Field's internal variable name
2331 2333
      * @param	int		$fieldType Field's type
2332 2334
      * @param	string	$displayText Field's language var name
2333
-     * @return int     new extra field id
2335
+     * @return boolean     new extra field id
2334 2336
      */
2335 2337
     public static function create_session_extra_field($variable, $fieldType, $displayText)
2336 2338
     {
@@ -2349,7 +2351,7 @@  discard block
 block discarded – undo
2349 2351
      * @param	integer	Course ID
2350 2352
      * @param	string	Field variable name
2351 2353
      * @param	string	Field value
2352
-     * @return	boolean	true if field updated, false otherwise
2354
+     * @return	boolean|null	true if field updated, false otherwise
2353 2355
      */
2354 2356
     public static function update_session_extra_field_value($sessionId, $variable, $value = '')
2355 2357
     {
@@ -2554,7 +2556,7 @@  discard block
 block discarded – undo
2554 2556
      * @param	array	id_checked
2555 2557
      * @param	bool	include delete session
2556 2558
      * @param	bool	optional, true if the function is called by a webservice, false otherwise.
2557
-     * @return	void	Nothing, or false on error
2559
+     * @return	boolean	Nothing, or false on error
2558 2560
      * The parameters is a array to delete sessions
2559 2561
      * */
2560 2562
     public static function delete_session_category($id_checked, $delete_session = false, $from_ws = false)
@@ -2605,7 +2607,7 @@  discard block
 block discarded – undo
2605 2607
      * @param  array $conditions a list of condition example :
2606 2608
      * array('status' => STUDENT) or
2607 2609
      * array('s.name' => array('operator' => 'LIKE', value = '%$needle%'))
2608
-     * @param  array $order_by a list of fields on which sort
2610
+     * @param  string[] $order_by a list of fields on which sort
2609 2611
      * @return array An array with all sessions of the platform.
2610 2612
      * @todo   optional course code parameter, optional sorting parameters...
2611 2613
      */
@@ -3043,6 +3045,7 @@  discard block
 block discarded – undo
3043 3045
      * @param string $orderCondition
3044 3046
      * @param string $keyword
3045 3047
      * @param string $description
3048
+     * @param integer $status
3046 3049
      * @return array sessions
3047 3050
      */
3048 3051
     public static function getSessionsFollowedByUser(
@@ -3255,8 +3258,8 @@  discard block
 block discarded – undo
3255 3258
     /**
3256 3259
      * Gets the list of courses by session filtered by access_url
3257 3260
      *
3258
-     * @param $userId
3259
-     * @param $sessionId
3261
+     * @param integer $userId
3262
+     * @param null|integer $sessionId
3260 3263
      * @param null $from
3261 3264
      * @param null $limit
3262 3265
      * @param null $column
@@ -3381,6 +3384,7 @@  discard block
 block discarded – undo
3381 3384
     /**
3382 3385
      * Gets the count of courses by session filtered by access_url
3383 3386
      * @param int session id
3387
+     * @param integer $session_id
3384 3388
      * @return array list of courses
3385 3389
      */
3386 3390
     public static function getCourseCountBySessionId($session_id, $keyword = null)
@@ -3632,6 +3636,7 @@  discard block
 block discarded – undo
3632 3636
      * Updates a session status
3633 3637
      * @param	int 	session id
3634 3638
      * @param	int 	status
3639
+     * @param integer $status
3635 3640
      */
3636 3641
     public static function set_session_status($session_id, $status)
3637 3642
     {
@@ -3943,7 +3948,7 @@  discard block
 block discarded – undo
3943 3948
 
3944 3949
     /**
3945 3950
      * @param $id
3946
-     * @return bool
3951
+     * @return null|boolean
3947 3952
      */
3948 3953
     public static function protect_teacher_session_edit($id)
3949 3954
     {
@@ -4007,7 +4012,7 @@  discard block
 block discarded – undo
4007 4012
      *  true: if the session exists it will be updated.
4008 4013
      *  false: if session exists a new session will be created adding a counter session1, session2, etc
4009 4014
      * @param int $defaultUserId
4010
-     * @param mixed $logger
4015
+     * @param Logger $logger
4011 4016
      * @param array $extraFields convert a file row to an extra field. Example in CSV file there's a SessionID then it will
4012 4017
      * converted to extra_external_session_id if you set this: array('SessionId' => 'extra_external_session_id')
4013 4018
      * @param string $extraFieldId
@@ -5249,7 +5254,6 @@  discard block
 block discarded – undo
5249 5254
      * @param string $lastConnectionDate
5250 5255
      * @param array $sessionIdList
5251 5256
      * @param array $studentIdList
5252
-     * @param int $userStatus STUDENT|COURSEMANAGER constants
5253 5257
      *
5254 5258
      * @return array|int
5255 5259
      */
@@ -5401,7 +5405,7 @@  discard block
 block discarded – undo
5401 5405
     /**
5402 5406
      * Get the list of course tools that have to be dealt with in case of
5403 5407
      * registering any course to a session
5404
-     * @return array The list of tools to be dealt with (literal names)
5408
+     * @return string[] The list of tools to be dealt with (literal names)
5405 5409
      */
5406 5410
     public static function getCourseToolToBeManaged()
5407 5411
     {
@@ -5415,7 +5419,7 @@  discard block
 block discarded – undo
5415 5419
      * Calls the methods bound to each tool when a course is registered into a session
5416 5420
      * @param int $sessionId
5417 5421
      * @param int $courseId
5418
-     * @return void
5422
+     * @return boolean|null
5419 5423
      */
5420 5424
     public static function installCourse($sessionId, $courseId)
5421 5425
     {
@@ -6055,6 +6059,7 @@  discard block
 block discarded – undo
6055 6059
      * @param int $categoryId The internal ID of the session category
6056 6060
      * @param string $target Value to search for in the session field values
6057 6061
      * @param array $extraFields A list of fields to be scanned and returned
6062
+     * @param DateTime $publicationDate
6058 6063
      * @return mixed
6059 6064
      */
6060 6065
     public static function getShortSessionListAndExtraByCategory($categoryId, $target, $extraFields = null, $publicationDate = null)
@@ -7384,7 +7389,7 @@  discard block
 block discarded – undo
7384 7389
     /**
7385 7390
      * Get link to the admin page for this session
7386 7391
      * @param   int $id Session ID
7387
-     * @return mixed    URL to the admin page to manage the session, or false on error
7392
+     * @return false|string    URL to the admin page to manage the session, or false on error
7388 7393
      */
7389 7394
     public static function getAdminPath($id)
7390 7395
     {
@@ -7401,7 +7406,7 @@  discard block
 block discarded – undo
7401 7406
      * If a course is provided, build the link to the course
7402 7407
      * @param   int $id Session ID
7403 7408
      * @param   int $courseId Course ID (optional) in case the link has to send straight to the course
7404
-     * @return mixed    URL to the page to use the session, or false on error
7409
+     * @return false|string    URL to the page to use the session, or false on error
7405 7410
      */
7406 7411
     public static function getPath($id, $courseId = 0)
7407 7412
     {
@@ -7499,7 +7504,7 @@  discard block
 block discarded – undo
7499 7504
     /**
7500 7505
      * Return true if coach is allowed to access this session
7501 7506
      * @param int $sessionId
7502
-     * @return bool
7507
+     * @return integer
7503 7508
      */
7504 7509
     public static function isSessionDateOkForCoach($sessionId)
7505 7510
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6022,7 +6022,7 @@
 block discarded – undo
6022 6022
         ]);
6023 6023
     }
6024 6024
 
6025
-	/**
6025
+    /**
6026 6026
      * Get the count of user courses in session
6027 6027
      * @param int $sessionId The session id
6028 6028
      * @return array
Please login to merge, or discard this patch.
Spacing   +197 added lines, -197 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
                     return $msg;
144 144
                 }
145 145
             } else {
146
-                $rs = Database::query("SELECT 1 FROM $tbl_session WHERE name='" . $name . "'");
146
+                $rs = Database::query("SELECT 1 FROM $tbl_session WHERE name='".$name."'");
147 147
                 if (Database::num_rows($rs)) {
148 148
                     $msg = get_lang('SessionNameAlreadyExists');
149 149
                     return $msg;
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
     public static function session_name_exists($name)
257 257
     {
258 258
         $name = Database::escape_string($name);
259
-        $sql = "SELECT COUNT(*) as count FROM " . Database::get_main_table(TABLE_MAIN_SESSION) . "
259
+        $sql = "SELECT COUNT(*) as count FROM ".Database::get_main_table(TABLE_MAIN_SESSION)."
260 260
                 WHERE name = '$name'";
261 261
         $result = Database::fetch_array(Database::query($sql));
262 262
 
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
             $where .= " AND (
288 288
                             s.session_admin_id = $user_id  OR
289 289
                             sru.user_id = '$user_id' AND
290
-                            sru.relation_type = '" . SESSION_RELATION_TYPE_RRHH . "'
290
+                            sru.relation_type = '".SESSION_RELATION_TYPE_RRHH."'
291 291
                             )
292 292
                       ";
293 293
 
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
             $where_condition = str_replace('category_name', 'sc.name', $where_condition);
306 306
             $where_condition = str_replace(
307 307
                 array("AND session_active = '1'  )", " AND (  session_active = '1'  )"),
308
-                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 " )
308
+                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 ")
309 309
                 , $where_condition
310 310
             );
311 311
             $where_condition = str_replace(
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
             $access_url_id = api_get_current_access_url_id();
352 352
             if ($access_url_id != -1) {
353
-                $where.= " AND ar.access_url_id = $access_url_id ";
353
+                $where .= " AND ar.access_url_id = $access_url_id ";
354 354
 
355 355
                 $sql = "SELECT count(id) as total_rows FROM (
356 356
                 SELECT DISTINCT
@@ -400,14 +400,14 @@  discard block
 block discarded – undo
400 400
             if (api_is_session_admin() &&
401 401
                 api_get_setting('allow_session_admins_to_manage_all_sessions') == 'false'
402 402
             ) {
403
-                $where .=" AND s.session_admin_id = $user_id ";
403
+                $where .= " AND s.session_admin_id = $user_id ";
404 404
             }
405 405
         }
406 406
 
407 407
         if (!api_is_platform_admin() && api_is_teacher() &&
408 408
             api_get_setting('allow_teachers_to_create_sessions') == 'true'
409 409
         ) {
410
-            $where .=" AND s.id_coach = $user_id ";
410
+            $where .= " AND s.id_coach = $user_id ";
411 411
         }
412 412
 
413 413
         $extra_field = new ExtraField('session');
@@ -457,10 +457,10 @@  discard block
 block discarded – undo
457 457
         $query = "$select FROM $tbl_session s $inject_joins $where $inject_where";
458 458
 
459 459
         if (api_is_multiple_url_enabled()) {
460
-            $table_access_url_rel_session= Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
460
+            $table_access_url_rel_session = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
461 461
             $access_url_id = api_get_current_access_url_id();
462 462
             if ($access_url_id != -1) {
463
-                $where.= " AND ar.access_url_id = $access_url_id ";
463
+                $where .= " AND ar.access_url_id = $access_url_id ";
464 464
                 $query = "$select
465 465
                         FROM $tbl_session s $inject_joins
466 466
                         INNER JOIN $table_access_url_rel_session ar
@@ -564,7 +564,7 @@  discard block
 block discarded – undo
564 564
                 INNER JOIN $tbl_lp l ON l.id = v.lp_id
565 565
                 INNER JOIN $tbl_user u ON u.user_id = v.user_id
566 566
                 INNER JOIN $tbl_course c
567
-                WHERE v.session_id = " . $sessionId;
567
+                WHERE v.session_id = ".$sessionId;
568 568
         $result_rows = Database::query($sql);
569 569
         $row = Database::fetch_array($result_rows);
570 570
         $num = $row['total_rows'];
@@ -616,7 +616,7 @@  discard block
 block discarded – undo
616 616
 
617 617
         $limit = null;
618 618
         if (!empty($options['limit'])) {
619
-            $limit = " LIMIT " . $options['limit'];
619
+            $limit = " LIMIT ".$options['limit'];
620 620
         }
621 621
 
622 622
         if (!empty($options['where'])) {
@@ -625,7 +625,7 @@  discard block
 block discarded – undo
625 625
 
626 626
         $order = null;
627 627
         if (!empty($options['order'])) {
628
-            $order = " ORDER BY " . $options['order'];
628
+            $order = " ORDER BY ".$options['order'];
629 629
         }
630 630
 
631 631
         $sql = "SELECT u.user_id, u.lastname, u.firstname, u.username, u.email, s.c_id
@@ -684,13 +684,13 @@  discard block
 block discarded – undo
684 684
             foreach ($lessons as $lesson) {
685 685
                 $data[$lesson['id']] = (!empty($user_lessons[$lesson['id']]['progress'])) ? $user_lessons[$lesson['id']]['progress'] : 0;
686 686
                 $progress += $data[$lesson['id']];
687
-                $data[$lesson['id']] = $data[$lesson['id']] . '%';
687
+                $data[$lesson['id']] = $data[$lesson['id']].'%';
688 688
                 $count++;
689 689
             }
690 690
             if ($count == 0) {
691 691
                 $data['total'] = 0;
692 692
             } else {
693
-                $data['total'] = round($progress / $count, 2) . '%';
693
+                $data['total'] = round($progress / $count, 2).'%';
694 694
             }
695 695
             $table[] = $data;
696 696
         }
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
 
732 732
         $limit = null;
733 733
         if (!empty($options['limit'])) {
734
-            $limit = " LIMIT " . $options['limit'];
734
+            $limit = " LIMIT ".$options['limit'];
735 735
         }
736 736
 
737 737
         if (!empty($options['where'])) {
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
 
741 741
         $order = null;
742 742
         if (!empty($options['order'])) {
743
-            $order = " ORDER BY " . $options['order'];
743
+            $order = " ORDER BY ".$options['order'];
744 744
         }
745 745
 
746 746
         $sql = "SELECT u.user_id, u.lastname, u.firstname, u.username, u.email, s.c_id
@@ -842,7 +842,7 @@  discard block
 block discarded – undo
842 842
 
843 843
         $limit = null;
844 844
         if (!empty($options['limit'])) {
845
-            $limit = " LIMIT " . $options['limit'];
845
+            $limit = " LIMIT ".$options['limit'];
846 846
         }
847 847
 
848 848
         if (!empty($options['where'])) {
@@ -851,7 +851,7 @@  discard block
 block discarded – undo
851 851
 
852 852
         $order = null;
853 853
         if (!empty($options['order'])) {
854
-            $order = " ORDER BY " . $options['order'];
854
+            $order = " ORDER BY ".$options['order'];
855 855
         }
856 856
 
857 857
         //TODO, fix create report without session
@@ -884,7 +884,7 @@  discard block
 block discarded – undo
884 884
         /**
885 885
          *  Lessons
886 886
          */
887
-        $sql = "SELECT * FROM $tbl_course_lp WHERE c_id = %s ";  //AND session_id = %s
887
+        $sql = "SELECT * FROM $tbl_course_lp WHERE c_id = %s "; //AND session_id = %s
888 888
         $sql_query = sprintf($sql, $course['real_id']);
889 889
         $result = Database::query($sql_query);
890 890
         $arrLesson = array(array());
@@ -892,7 +892,7 @@  discard block
 block discarded – undo
892 892
             if (empty($arrLesson[$row['session_id']]['lessons_total'])) {
893 893
                 $arrLesson[$row['session_id']]['lessons_total'] = 1;
894 894
             } else {
895
-                $arrLesson[$row['session_id']]['lessons_total'] ++;
895
+                $arrLesson[$row['session_id']]['lessons_total']++;
896 896
             }
897 897
         }
898 898
 
@@ -959,7 +959,7 @@  discard block
 block discarded – undo
959 959
                 $course['real_id']
960 960
             );
961 961
             foreach ($user_list as $user_id) {
962
-                isset($survey_user_list[$user_id]) ? $survey_user_list[$user_id] ++ : $survey_user_list[$user_id] = 1;
962
+                isset($survey_user_list[$user_id]) ? $survey_user_list[$user_id]++ : $survey_user_list[$user_id] = 1;
963 963
             }
964 964
         }
965 965
 
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
             $assignments_done = Tracking::count_student_assignments($user['user_id'], $course['code'], $user['id_session']);
1014 1014
             $assignments_left = $assignments_total - $assignments_done;
1015 1015
             if (!empty($assignments_total)) {
1016
-                $assignments_progress = round((( $assignments_done * 100 ) / $assignments_total), 2);
1016
+                $assignments_progress = round((($assignments_done * 100) / $assignments_total), 2);
1017 1017
             } else {
1018 1018
                 $assignments_progress = 0;
1019 1019
             }
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
             $wiki_read = $row['count'];
1044 1044
             $wiki_unread = $wiki_total - $wiki_read;
1045 1045
             if (!empty($wiki_total)) {
1046
-                $wiki_progress = round((( $wiki_read * 100 ) / $wiki_total), 2);
1046
+                $wiki_progress = round((($wiki_read * 100) / $wiki_total), 2);
1047 1047
             } else {
1048 1048
                 $wiki_progress = 0;
1049 1049
             }
@@ -1052,7 +1052,7 @@  discard block
 block discarded – undo
1052 1052
             $surveys_done = (isset($survey_user_list[$user['user_id']]) ? $survey_user_list[$user['user_id']] : 0);
1053 1053
             $surveys_left = $surveys_total - $surveys_done;
1054 1054
             if (!empty($surveys_total)) {
1055
-                $surveys_progress = round((( $surveys_done * 100 ) / $surveys_total), 2);
1055
+                $surveys_progress = round((($surveys_done * 100) / $surveys_total), 2);
1056 1056
             } else {
1057 1057
                 $surveys_progress = 0;
1058 1058
             }
@@ -1065,7 +1065,7 @@  discard block
 block discarded – undo
1065 1065
             );
1066 1066
             $forums_left = $forums_total - $forums_done;
1067 1067
             if (!empty($forums_total)) {
1068
-                $forums_progress = round((( $forums_done * 100 ) / $forums_total), 2);
1068
+                $forums_progress = round((($forums_done * 100) / $forums_total), 2);
1069 1069
             } else {
1070 1070
                 $forums_progress = 0;
1071 1071
             }
@@ -1073,58 +1073,58 @@  discard block
 block discarded – undo
1073 1073
             //Overall Total
1074 1074
             $overall_total = ($course_description_progress + $exercises_progress + $forums_progress + $assignments_progress + $wiki_progress + $surveys_progress) / 6;
1075 1075
 
1076
-            $link = '<a href="' . api_get_path(WEB_CODE_PATH) . 'mySpace/myStudents.php?student=' . $user[0] . '&details=true&course=' . $course['code'] . '&id_session=' . $user['id_session'] . '"> %s </a>';
1077
-            $linkForum = '<a href="' . api_get_path(WEB_CODE_PATH) . 'forum/index.php?cidReq=' . $course['code'] . '&id_session=' . $user['id_session'] . '"> %s </a>';
1078
-            $linkWork = '<a href="' . api_get_path(WEB_CODE_PATH) . 'work/work.php?cidReq=' . $course['code'] . '&id_session=' . $user['id_session'] . '"> %s </a>';
1079
-            $linkWiki = '<a href="' . api_get_path(WEB_CODE_PATH) . 'wiki/index.php?cidReq=' . $course['code'] . '&session_id=' . $user['id_session'] . '&action=statistics"> %s </a>';
1080
-            $linkSurvey = '<a href="' . api_get_path(WEB_CODE_PATH) . 'survey/survey_list.php?cidReq=' . $course['code'] . '&id_session=' . $user['id_session'] . '"> %s </a>';
1076
+            $link = '<a href="'.api_get_path(WEB_CODE_PATH).'mySpace/myStudents.php?student='.$user[0].'&details=true&course='.$course['code'].'&id_session='.$user['id_session'].'"> %s </a>';
1077
+            $linkForum = '<a href="'.api_get_path(WEB_CODE_PATH).'forum/index.php?cidReq='.$course['code'].'&id_session='.$user['id_session'].'"> %s </a>';
1078
+            $linkWork = '<a href="'.api_get_path(WEB_CODE_PATH).'work/work.php?cidReq='.$course['code'].'&id_session='.$user['id_session'].'"> %s </a>';
1079
+            $linkWiki = '<a href="'.api_get_path(WEB_CODE_PATH).'wiki/index.php?cidReq='.$course['code'].'&session_id='.$user['id_session'].'&action=statistics"> %s </a>';
1080
+            $linkSurvey = '<a href="'.api_get_path(WEB_CODE_PATH).'survey/survey_list.php?cidReq='.$course['code'].'&id_session='.$user['id_session'].'"> %s </a>';
1081 1081
 
1082 1082
             $table[] = array(
1083 1083
                 'lastname' => $user[1],
1084 1084
                 'firstname' => $user[2],
1085 1085
                 'username' => $user[3],
1086 1086
                 #'profile'   => '',
1087
-                'total' => round($overall_total, 2) . '%',
1088
-                'courses' => sprintf($link, $course_description_progress . '%'),
1089
-                'lessons' => sprintf($link, $lessons_progress . '%'),
1090
-                'exercises' => sprintf($link, $exercises_progress . '%'),
1091
-                'forums' => sprintf($link, $forums_progress . '%'),
1092
-                'homeworks' => sprintf($link, $assignments_progress . '%'),
1093
-                'wikis' => sprintf($link, $wiki_progress . '%'),
1094
-                'surveys' => sprintf($link, $surveys_progress . '%'),
1087
+                'total' => round($overall_total, 2).'%',
1088
+                'courses' => sprintf($link, $course_description_progress.'%'),
1089
+                'lessons' => sprintf($link, $lessons_progress.'%'),
1090
+                'exercises' => sprintf($link, $exercises_progress.'%'),
1091
+                'forums' => sprintf($link, $forums_progress.'%'),
1092
+                'homeworks' => sprintf($link, $assignments_progress.'%'),
1093
+                'wikis' => sprintf($link, $wiki_progress.'%'),
1094
+                'surveys' => sprintf($link, $surveys_progress.'%'),
1095 1095
                 //course description
1096
-                'course_description_progress' => $course_description_progress . '%',
1096
+                'course_description_progress' => $course_description_progress.'%',
1097 1097
                 //lessons
1098 1098
                 'lessons_total' => sprintf($link, $lessons_total),
1099 1099
                 'lessons_done' => sprintf($link, $lessons_done),
1100 1100
                 'lessons_left' => sprintf($link, $lessons_left),
1101
-                'lessons_progress' => sprintf($link, $lessons_progress . '%'),
1101
+                'lessons_progress' => sprintf($link, $lessons_progress.'%'),
1102 1102
                 //exercises
1103 1103
                 'exercises_total' => sprintf($link, $exercises_total),
1104 1104
                 'exercises_done' => sprintf($link, $exercises_done),
1105 1105
                 'exercises_left' => sprintf($link, $exercises_left),
1106
-                'exercises_progress' => sprintf($link, $exercises_progress . '%'),
1106
+                'exercises_progress' => sprintf($link, $exercises_progress.'%'),
1107 1107
                 //forums
1108 1108
                 'forums_total' => sprintf($linkForum, $forums_total),
1109 1109
                 'forums_done' => sprintf($linkForum, $forums_done),
1110 1110
                 'forums_left' => sprintf($linkForum, $forums_left),
1111
-                'forums_progress' => sprintf($linkForum, $forums_progress . '%'),
1111
+                'forums_progress' => sprintf($linkForum, $forums_progress.'%'),
1112 1112
                 //assignments
1113 1113
                 'assignments_total' => sprintf($linkWork, $assignments_total),
1114 1114
                 'assignments_done' => sprintf($linkWork, $assignments_done),
1115 1115
                 'assignments_left' => sprintf($linkWork, $assignments_left),
1116
-                'assignments_progress' => sprintf($linkWork, $assignments_progress . '%'),
1116
+                'assignments_progress' => sprintf($linkWork, $assignments_progress.'%'),
1117 1117
                 //wiki
1118 1118
                 'wiki_total' => sprintf($linkWiki, $wiki_total),
1119 1119
                 'wiki_revisions' => sprintf($linkWiki, $wiki_revisions),
1120 1120
                 'wiki_read' => sprintf($linkWiki, $wiki_read),
1121 1121
                 'wiki_unread' => sprintf($linkWiki, $wiki_unread),
1122
-                'wiki_progress' => sprintf($linkWiki, $wiki_progress . '%'),
1122
+                'wiki_progress' => sprintf($linkWiki, $wiki_progress.'%'),
1123 1123
                 //survey
1124 1124
                 'surveys_total' => sprintf($linkSurvey, $surveys_total),
1125 1125
                 'surveys_done' => sprintf($linkSurvey, $surveys_done),
1126 1126
                 'surveys_left' => sprintf($linkSurvey, $surveys_left),
1127
-                'surveys_progress' => sprintf($linkSurvey, $surveys_progress . '%'),
1127
+                'surveys_progress' => sprintf($linkSurvey, $surveys_progress.'%'),
1128 1128
             );
1129 1129
         }
1130 1130
 
@@ -1204,7 +1204,7 @@  discard block
 block discarded – undo
1204 1204
 
1205 1205
         $limit = null;
1206 1206
         if (!empty($options['limit'])) {
1207
-            $limit = " LIMIT " . $options['limit'];
1207
+            $limit = " LIMIT ".$options['limit'];
1208 1208
         }
1209 1209
 
1210 1210
         if (!empty($options['where'])) {
@@ -1213,7 +1213,7 @@  discard block
 block discarded – undo
1213 1213
 
1214 1214
         $order = null;
1215 1215
         if (!empty($options['order'])) {
1216
-            $order = " ORDER BY " . $options['order'];
1216
+            $order = " ORDER BY ".$options['order'];
1217 1217
         }
1218 1218
 
1219 1219
         //TODO add course name
@@ -1226,7 +1226,7 @@  discard block
 block discarded – undo
1226 1226
                     " : "
1227 1227
                     u.lastname,
1228 1228
                     u.firstname,
1229
-                ") . "
1229
+                ")."
1230 1230
                 a.logout_course_date,
1231 1231
                 a.counter,
1232 1232
                 c.title,
@@ -1310,7 +1310,7 @@  discard block
 block discarded – undo
1310 1310
             if (Database::num_rows($result) > 0) {
1311 1311
                 $row = Database::fetch_array($result);
1312 1312
                 $count = $row['count'] + 1;
1313
-                $session_name = $session_name . '_' . $count;
1313
+                $session_name = $session_name.'_'.$count;
1314 1314
                 $result = self::session_name_exists($session_name);
1315 1315
                 if (!$result) {
1316 1316
                     return $session_name;
@@ -1390,7 +1390,7 @@  discard block
 block discarded – undo
1390 1390
 
1391 1391
             return false;
1392 1392
         } else {
1393
-            $sql = "SELECT id FROM $tbl_session WHERE name='" . Database::escape_string($name) . "'";
1393
+            $sql = "SELECT id FROM $tbl_session WHERE name='".Database::escape_string($name)."'";
1394 1394
             $rs = Database::query($sql);
1395 1395
             $exists = false;
1396 1396
             while ($row = Database::fetch_array($rs)) {
@@ -1488,7 +1488,7 @@  discard block
 block discarded – undo
1488 1488
         }
1489 1489
 
1490 1490
         if (SessionManager::allowed($id_checked) && !$from_ws) {
1491
-            $sql = 'SELECT session_admin_id FROM ' . $tbl_session. '
1491
+            $sql = 'SELECT session_admin_id FROM '.$tbl_session.'
1492 1492
                     WHERE id IN (' . $id_checked.')';
1493 1493
             $rs = Database::query($sql);
1494 1494
             if (Database::result($rs, 0, 0) != $userId) {
@@ -1749,7 +1749,7 @@  discard block
 block discarded – undo
1749 1749
         // Delete users from the session
1750 1750
         if ($empty_users === true) {
1751 1751
             $sql = "DELETE FROM $tbl_session_rel_user
1752
-                    WHERE session_id = $id_session AND relation_type<>" . SESSION_RELATION_TYPE_RRHH . "";
1752
+                    WHERE session_id = $id_session AND relation_type<>".SESSION_RELATION_TYPE_RRHH."";
1753 1753
             Database::query($sql);
1754 1754
         }
1755 1755
 
@@ -1760,7 +1760,7 @@  discard block
 block discarded – undo
1760 1760
             $enreg_user = Database::escape_string($enreg_user);
1761 1761
             $nbr_users++;
1762 1762
             $sql = "INSERT IGNORE INTO $tbl_session_rel_user (relation_type, session_id, user_id, registered_at)
1763
-                    VALUES (0, $id_session, $enreg_user, '" . api_get_utc_datetime() . "')";
1763
+                    VALUES (0, $id_session, $enreg_user, '".api_get_utc_datetime()."')";
1764 1764
             Database::query($sql);
1765 1765
         }
1766 1766
 
@@ -1850,9 +1850,9 @@  discard block
 block discarded – undo
1850 1850
         is_array($courseInfo) ? $courseId = $courseInfo['real_id'] : $courseId = $courseInfo;
1851 1851
 
1852 1852
         $statusCondition = null;
1853
-        if (isset($status) && !is_null($status))  {
1853
+        if (isset($status) && !is_null($status)) {
1854 1854
             $status = intval($status);
1855
-            $statusCondition  = " AND status = $status";
1855
+            $statusCondition = " AND status = $status";
1856 1856
         }
1857 1857
 
1858 1858
         foreach ($userList as $userId) {
@@ -1984,7 +1984,7 @@  discard block
 block discarded – undo
1984 1984
             if (empty($count)) {
1985 1985
                 // If user is not registered to a session then add it.
1986 1986
                 $sql = "INSERT IGNORE INTO $tbl_session_rel_user (session_id, user_id, registered_at)
1987
-                        VALUES ($session_id, $enreg_user, '" . api_get_utc_datetime() . "')";
1987
+                        VALUES ($session_id, $enreg_user, '".api_get_utc_datetime()."')";
1988 1988
                 Database::query($sql);
1989 1989
 
1990 1990
                 $sql = "UPDATE $tbl_session SET nbr_users = nbr_users + 1
@@ -2027,7 +2027,7 @@  discard block
 block discarded – undo
2027 2027
 		               WHERE
2028 2028
                             session_id = $session_id AND
2029 2029
 		                    user_id = $user_id AND
2030
-		                    relation_type <> " . SESSION_RELATION_TYPE_RRHH . "";
2030
+		                    relation_type <> ".SESSION_RELATION_TYPE_RRHH."";
2031 2031
         $result = Database::query($delete_sql);
2032 2032
         $return = Database::affected_rows($result);
2033 2033
 
@@ -2111,7 +2111,7 @@  discard block
 block discarded – undo
2111 2111
                 FROM $tbl_session_rel_user
2112 2112
                 WHERE
2113 2113
                     session_id = $sessionId AND
2114
-                    relation_type<>" . SESSION_RELATION_TYPE_RRHH;
2114
+                    relation_type<>".SESSION_RELATION_TYPE_RRHH;
2115 2115
         $result = Database::query($sql);
2116 2116
         $user_list = Database::store_result($result);
2117 2117
 
@@ -2123,7 +2123,7 @@  discard block
 block discarded – undo
2123 2123
 
2124 2124
                     $sql = "DELETE FROM $tbl_session_rel_course
2125 2125
                             WHERE
2126
-                                c_id = " . $existingCourse['c_id'] . " AND
2126
+                                c_id = ".$existingCourse['c_id']." AND
2127 2127
                                 session_id = $sessionId";
2128 2128
                     Database::query($sql);
2129 2129
 
@@ -2186,7 +2186,7 @@  discard block
 block discarded – undo
2186 2186
                             $links = $cat->get_links(null, false, $courseInfo['code'], 0);
2187 2187
 
2188 2188
                             $cat->set_session_id($sessionId);
2189
-                            $oldCategoryId= $cat->get_id();
2189
+                            $oldCategoryId = $cat->get_id();
2190 2190
                             $newId = $cat->add();
2191 2191
                             $newCategoryIdList[$oldCategoryId] = $newId;
2192 2192
 
@@ -2374,8 +2374,8 @@  discard block
 block discarded – undo
2374 2374
         $return_value = false;
2375 2375
         $sql = "SELECT c_id FROM $tbl_session_course
2376 2376
                 WHERE
2377
-                  session_id = " . intval($session_id) . " AND
2378
-                  c_id = " . intval($courseId) . "";
2377
+                  session_id = ".intval($session_id)." AND
2378
+                  c_id = " . intval($courseId)."";
2379 2379
         $result = Database::query($sql);
2380 2380
         $num = Database::num_rows($result);
2381 2381
         if ($num > 0) {
@@ -2398,8 +2398,8 @@  discard block
 block discarded – undo
2398 2398
         }
2399 2399
 
2400 2400
         $sql = 'SELECT *
2401
-		        FROM ' . $tbl_session . '
2402
-		        WHERE name = "' . Database::escape_string($session_name) . '"';
2401
+		        FROM ' . $tbl_session.'
2402
+		        WHERE name = "' . Database::escape_string($session_name).'"';
2403 2403
         $result = Database::query($sql);
2404 2404
         $num = Database::num_rows($result);
2405 2405
         if ($num > 0) {
@@ -2439,8 +2439,8 @@  discard block
 block discarded – undo
2439 2439
         $month_end = intval($smonth_end);
2440 2440
         $day_end = intval($sday_end);
2441 2441
 
2442
-        $date_start = "$year_start-" . (($month_start < 10) ? "0$month_start" : $month_start) . "-" . (($day_start < 10) ? "0$day_start" : $day_start);
2443
-        $date_end = "$year_end-" . (($month_end < 10) ? "0$month_end" : $month_end) . "-" . (($day_end < 10) ? "0$day_end" : $day_end);
2442
+        $date_start = "$year_start-".(($month_start < 10) ? "0$month_start" : $month_start)."-".(($day_start < 10) ? "0$day_start" : $day_start);
2443
+        $date_end = "$year_end-".(($month_end < 10) ? "0$month_end" : $month_end)."-".(($day_end < 10) ? "0$day_end" : $day_end);
2444 2444
 
2445 2445
         if (empty($name)) {
2446 2446
             $msg = get_lang('SessionCategoryNameIsRequired');
@@ -2512,8 +2512,8 @@  discard block
 block discarded – undo
2512 2512
         $month_end = intval($smonth_end);
2513 2513
         $day_end = intval($sday_end);
2514 2514
         $id = intval($id);
2515
-        $date_start = "$year_start-" . (($month_start < 10) ? "0$month_start" : $month_start) . "-" . (($day_start < 10) ? "0$day_start" : $day_start);
2516
-        $date_end = "$year_end-" . (($month_end < 10) ? "0$month_end" : $month_end) . "-" . (($day_end < 10) ? "0$day_end" : $day_end);
2515
+        $date_start = "$year_start-".(($month_start < 10) ? "0$month_start" : $month_start)."-".(($day_start < 10) ? "0$day_start" : $day_start);
2516
+        $date_end = "$year_end-".(($month_end < 10) ? "0$month_end" : $month_end)."-".(($day_end < 10) ? "0$day_end" : $day_end);
2517 2517
 
2518 2518
         if (empty($name)) {
2519 2519
             $msg = get_lang('SessionCategoryNameIsRequired');
@@ -2533,13 +2533,13 @@  discard block
 block discarded – undo
2533 2533
         if ($date_end <> null) {
2534 2534
             $sql = "UPDATE $tbl_session_category
2535 2535
                     SET
2536
-                        name = '" . Database::escape_string($name) . "',
2536
+                        name = '".Database::escape_string($name)."',
2537 2537
                         date_start = '$date_start' ,
2538 2538
                         date_end = '$date_end'
2539 2539
                     WHERE id= $id";
2540 2540
         } else {
2541 2541
             $sql = "UPDATE $tbl_session_category SET
2542
-                        name = '" . Database::escape_string($name) . "',
2542
+                        name = '".Database::escape_string($name)."',
2543 2543
                         date_start = '$date_start',
2544 2544
                         date_end = NULL
2545 2545
                     WHERE id= $id";
@@ -2569,10 +2569,10 @@  discard block
 block discarded – undo
2569 2569
 
2570 2570
         //Setting session_category_id to 0
2571 2571
         $sql = "UPDATE $tbl_session SET session_category_id = 0
2572
-                WHERE session_category_id IN (" . $id_checked . ")";
2572
+                WHERE session_category_id IN (".$id_checked.")";
2573 2573
         Database::query($sql);
2574 2574
 
2575
-        $sql = "SELECT id FROM $tbl_session WHERE session_category_id IN (" . $id_checked . ")";
2575
+        $sql = "SELECT id FROM $tbl_session WHERE session_category_id IN (".$id_checked.")";
2576 2576
         $result = Database::query($sql);
2577 2577
         while ($rows = Database::fetch_array($result)) {
2578 2578
             $session_id = $rows['id'];
@@ -2584,7 +2584,7 @@  discard block
 block discarded – undo
2584 2584
                 }
2585 2585
             }
2586 2586
         }
2587
-        $sql = "DELETE FROM $tbl_session_category WHERE id IN (" . $id_checked . ")";
2587
+        $sql = "DELETE FROM $tbl_session_category WHERE id IN (".$id_checked.")";
2588 2588
         Database::query($sql);
2589 2589
 
2590 2590
         // Add event to system log
@@ -2657,7 +2657,7 @@  discard block
 block discarded – undo
2657 2657
                 $value = Database::escape_string($options['value']);
2658 2658
                 $sql_query .= ' AND ';
2659 2659
                 if (in_array($field, $availableFields) && in_array($operator, $availableOperator)) {
2660
-                    $sql_query .= $field . " $operator '" . $value . "'";
2660
+                    $sql_query .= $field." $operator '".$value."'";
2661 2661
                 }
2662 2662
             }
2663 2663
         }
@@ -2718,8 +2718,8 @@  discard block
 block discarded – undo
2718 2718
     {
2719 2719
         $tbl_session_category = Database::get_main_table(TABLE_MAIN_SESSION_CATEGORY);
2720 2720
         $id = api_get_current_access_url_id();
2721
-        $sql = 'SELECT * FROM ' . $tbl_session_category . '
2722
-                WHERE access_url_id = ' . $id . '
2721
+        $sql = 'SELECT * FROM '.$tbl_session_category.'
2722
+                WHERE access_url_id = ' . $id.'
2723 2723
                 ORDER BY name ASC';
2724 2724
         $result = Database::query($sql);
2725 2725
         if (Database::num_rows($result) > 0) {
@@ -2898,11 +2898,11 @@  discard block
 block discarded – undo
2898 2898
                         INNER JOIN $tbl_session_rel_access_url a ON (a.session_id = s.session_id)
2899 2899
                         WHERE
2900 2900
                             s.user_id = $userId AND
2901
-                            relation_type=" . SESSION_RELATION_TYPE_RRHH . " AND
2902
-                            access_url_id = " . api_get_current_access_url_id() . "";
2901
+                            relation_type=".SESSION_RELATION_TYPE_RRHH." AND
2902
+                            access_url_id = " . api_get_current_access_url_id()."";
2903 2903
             } else {
2904 2904
                 $sql = "SELECT session_id FROM $tbl_session_rel_user s
2905
-                        WHERE user_id = $userId AND relation_type=" . SESSION_RELATION_TYPE_RRHH . "";
2905
+                        WHERE user_id = $userId AND relation_type=".SESSION_RELATION_TYPE_RRHH."";
2906 2906
             }
2907 2907
             $result = Database::query($sql);
2908 2908
 
@@ -2912,7 +2912,7 @@  discard block
 block discarded – undo
2912 2912
                             WHERE
2913 2913
                                 session_id = {$row['session_id']} AND
2914 2914
                                 user_id = $userId AND
2915
-                                relation_type=" . SESSION_RELATION_TYPE_RRHH . " ";
2915
+                                relation_type=".SESSION_RELATION_TYPE_RRHH." ";
2916 2916
                     Database::query($sql);
2917 2917
                 }
2918 2918
             }
@@ -2926,8 +2926,8 @@  discard block
 block discarded – undo
2926 2926
                         VALUES (
2927 2927
                             $session_id,
2928 2928
                             $userId,
2929
-                            '" . SESSION_RELATION_TYPE_RRHH . "',
2930
-                            '" . api_get_utc_datetime() . "'
2929
+                            '".SESSION_RELATION_TYPE_RRHH."',
2930
+                            '" . api_get_utc_datetime()."'
2931 2931
                         )";
2932 2932
 
2933 2933
                 Database::query($sql);
@@ -2969,8 +2969,8 @@  discard block
 block discarded – undo
2969 2969
                     WHERE
2970 2970
                         sru.user_id = '$userId' AND
2971 2971
                         sru.session_id = '$sessionId' AND
2972
-                        sru.relation_type = '" . SESSION_RELATION_TYPE_RRHH . "' AND
2973
-                        access_url_id = " . api_get_current_access_url_id() . "
2972
+                        sru.relation_type = '".SESSION_RELATION_TYPE_RRHH."' AND
2973
+                        access_url_id = " . api_get_current_access_url_id()."
2974 2974
                         ";
2975 2975
         } else {
2976 2976
             $sql = "$select FROM $tbl_session s
@@ -2979,7 +2979,7 @@  discard block
 block discarded – undo
2979 2979
                         sru.session_id = s.id AND
2980 2980
                         sru.user_id = '$userId' AND
2981 2981
                         sru.session_id = '$sessionId' AND
2982
-                        sru.relation_type = '" . SESSION_RELATION_TYPE_RRHH . "'
2982
+                        sru.relation_type = '".SESSION_RELATION_TYPE_RRHH."'
2983 2983
                     ";
2984 2984
         }
2985 2985
 
@@ -3077,7 +3077,7 @@  discard block
 block discarded – undo
3077 3077
 
3078 3078
         $limitCondition = null;
3079 3079
         if (!empty($start) && !empty($limit)) {
3080
-            $limitCondition = " LIMIT " . intval($start) . ", " . intval($limit);
3080
+            $limitCondition = " LIMIT ".intval($start).", ".intval($limit);
3081 3081
         }
3082 3082
 
3083 3083
         if (empty($orderCondition)) {
@@ -3155,26 +3155,26 @@  discard block
 block discarded – undo
3155 3155
 
3156 3156
         $sessions = array();
3157 3157
         if (Database::num_rows($result) > 0) {
3158
-            $sysUploadPath = api_get_path(SYS_UPLOAD_PATH). 'sessions/';
3159
-            $webUploadPath = api_get_path(WEB_UPLOAD_PATH). 'sessions/';
3160
-            $imgPath = api_get_path(WEB_IMG_PATH) . 'session_default_small.png';
3158
+            $sysUploadPath = api_get_path(SYS_UPLOAD_PATH).'sessions/';
3159
+            $webUploadPath = api_get_path(WEB_UPLOAD_PATH).'sessions/';
3160
+            $imgPath = api_get_path(WEB_IMG_PATH).'session_default_small.png';
3161 3161
 
3162 3162
             $tableExtraFields = Database::get_main_table(TABLE_EXTRA_FIELD);
3163
-            $sql = "SELECT id FROM " . $tableExtraFields . "
3163
+            $sql = "SELECT id FROM ".$tableExtraFields."
3164 3164
                     WHERE extra_field_type = 3 AND variable='image'";
3165 3165
             $resultField = Database::query($sql);
3166 3166
             $imageFieldId = Database::fetch_assoc($resultField);
3167 3167
 
3168 3168
             while ($row = Database::fetch_array($result)) {
3169 3169
 
3170
-                $row['image'] =  null;
3171
-                $sessionImage = $sysUploadPath . $imageFieldId['id'] . '_' . $row['id'] . '.png';
3170
+                $row['image'] = null;
3171
+                $sessionImage = $sysUploadPath.$imageFieldId['id'].'_'.$row['id'].'.png';
3172 3172
 
3173 3173
                 if (is_file($sessionImage)) {
3174
-                    $sessionImage = $webUploadPath . $imageFieldId['id'] . '_' . $row['id'] . '.png';
3174
+                    $sessionImage = $webUploadPath.$imageFieldId['id'].'_'.$row['id'].'.png';
3175 3175
                     $row['image'] = $sessionImage;
3176 3176
                 } else {
3177
-                    $row['image'] =  $imgPath;
3177
+                    $row['image'] = $imgPath;
3178 3178
                 }
3179 3179
 
3180 3180
                 $sessions[$row['id']] = $row;
@@ -3244,7 +3244,7 @@  discard block
 block discarded – undo
3244 3244
                 return intval($count[0]);
3245 3245
             }
3246 3246
 
3247
-            while ($row = Database::fetch_array($result,'ASSOC'))	{
3247
+            while ($row = Database::fetch_array($result, 'ASSOC')) {
3248 3248
                 $courses[$row['real_id']] = $row;
3249 3249
             }
3250 3250
         }
@@ -3288,7 +3288,7 @@  discard block
 block discarded – undo
3288 3288
         }
3289 3289
 
3290 3290
         $tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
3291
-        $tbl_session_rel_course	= Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
3291
+        $tbl_session_rel_course = Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
3292 3292
 
3293 3293
         if ($getCount) {
3294 3294
             $select = "SELECT COUNT(DISTINCT(c.code)) as count ";
@@ -3313,7 +3313,7 @@  discard block
 block discarded – undo
3313 3313
 		        ";
3314 3314
         if ($getCount) {
3315 3315
             $result = Database::query($sql);
3316
-            $row = Database::fetch_array($result,'ASSOC');
3316
+            $row = Database::fetch_array($result, 'ASSOC');
3317 3317
             return $row['count'];
3318 3318
         }
3319 3319
 
@@ -3328,7 +3328,7 @@  discard block
 block discarded – undo
3328 3328
         $courses = array();
3329 3329
 
3330 3330
         if ($num_rows > 0) {
3331
-            while ($row = Database::fetch_array($result,'ASSOC'))	{
3331
+            while ($row = Database::fetch_array($result, 'ASSOC')) {
3332 3332
                 $courses[$row['id']] = $row;
3333 3333
             }
3334 3334
         }
@@ -3406,7 +3406,7 @@  discard block
 block discarded – undo
3406 3406
         $result = Database::query($sql);
3407 3407
         $num_rows = Database::num_rows($result);
3408 3408
         if ($num_rows > 0) {
3409
-            $row = Database::fetch_array($result,'ASSOC');
3409
+            $row = Database::fetch_array($result, 'ASSOC');
3410 3410
             return $row['count'];
3411 3411
         }
3412 3412
 
@@ -3518,9 +3518,9 @@  discard block
 block discarded – undo
3518 3518
 
3519 3519
             if ($access_url_id != -1) {
3520 3520
                 $sql = 'SELECT DISTINCT session.*
3521
-                    FROM ' . $session_table . ' session INNER JOIN ' . $tbl_session_rel_access_url . ' session_rel_url
3521
+                    FROM ' . $session_table.' session INNER JOIN '.$tbl_session_rel_access_url.' session_rel_url
3522 3522
                     ON (session.id = session_rel_url.session_id)
3523
-                    WHERE '.$sqlCoach.' access_url_id = ' . $access_url_id;
3523
+                    WHERE '.$sqlCoach.' access_url_id = '.$access_url_id;
3524 3524
             }
3525 3525
         }
3526 3526
         $sql .= ' ORDER by name';
@@ -3554,8 +3554,8 @@  discard block
 block discarded – undo
3554 3554
                 FROM $tbl_session_rel_course_rel_user session_rcru, $tbl_user user
3555 3555
                 WHERE
3556 3556
                     session_rcru.user_id = user.user_id AND
3557
-                    session_rcru.session_id = '" . intval($session_id) . "' AND
3558
-                    session_rcru.c_id ='" . intval($courseId) . "' AND
3557
+                    session_rcru.session_id = '".intval($session_id)."' AND
3558
+                    session_rcru.c_id ='" . intval($courseId)."' AND
3559 3559
                     user.user_id = " . intval($user_id);
3560 3560
 
3561 3561
         $result = Database::query($sql);
@@ -3586,8 +3586,8 @@  discard block
 block discarded – undo
3586 3586
         $sql = "SELECT session_rcru.status
3587 3587
                 FROM $tbl_session_rel_course_rel_user session_rcru, $tbl_user user
3588 3588
                 WHERE session_rcru.user_id = user.user_id AND
3589
-                    session_rcru.session_id = '" . intval($session_id) . "' AND
3590
-                    session_rcru.c_id ='" . intval($courseId) . "' AND
3589
+                    session_rcru.session_id = '".intval($session_id)."' AND
3590
+                    session_rcru.c_id ='" . intval($courseId)."' AND
3591 3591
                     user.user_id = " . intval($user_id);
3592 3592
         $result = Database::query($sql);
3593 3593
         $status = false;
@@ -3664,7 +3664,7 @@  discard block
 block discarded – undo
3664 3664
         // Get timestamp for now in UTC - see http://php.net/manual/es/function.time.php#117251
3665 3665
         $now = time() - date('Z');
3666 3666
         // Timestamp in one month
3667
-        $inOneMonth = $now + (30*24*3600);
3667
+        $inOneMonth = $now + (30 * 24 * 3600);
3668 3668
         $inOneMonth = api_get_local_time($inOneMonth);
3669 3669
         if (api_strtotime($s['access_start_date']) < $now) {
3670 3670
             $s['access_start_date'] = api_get_local_time($now);
@@ -3686,16 +3686,16 @@  discard block
 block discarded – undo
3686 3686
         }
3687 3687
         // Now try to create the session
3688 3688
         $sid = self::create_session(
3689
-            $s['name'] . ' ' . get_lang('CopyLabelSuffix'),
3689
+            $s['name'].' '.get_lang('CopyLabelSuffix'),
3690 3690
             $s['access_start_date'],
3691 3691
             $s['access_end_date'],
3692 3692
             $s['display_start_date'],
3693 3693
             $s['display_end_date'],
3694 3694
             $s['coach_access_start_date'],
3695 3695
             $s['coach_access_end_date'],
3696
-            (int)$s['id_coach'],
3696
+            (int) $s['id_coach'],
3697 3697
             $s['session_category_id'],
3698
-            (int)$s['visibility'],
3698
+            (int) $s['visibility'],
3699 3699
             true
3700 3700
         );
3701 3701
 
@@ -3809,7 +3809,7 @@  discard block
 block discarded – undo
3809 3809
         $session_table = Database::get_main_table(TABLE_MAIN_SESSION);
3810 3810
         $sql = "SELECT DISTINCT id
3811 3811
 	         	FROM $session_table
3812
-	         	WHERE session.id_coach =  '" . $user_id . "' AND id = '$session_id'";
3812
+	         	WHERE session.id_coach =  '".$user_id."' AND id = '$session_id'";
3813 3813
         $result = Database::query($sql);
3814 3814
         if ($result && Database::num_rows($result)) {
3815 3815
             return true;
@@ -3828,7 +3828,7 @@  discard block
 block discarded – undo
3828 3828
         $access_url_rel_session_table = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
3829 3829
         $sql = "SELECT count(id) FROM $session_table s";
3830 3830
         if (!empty($access_url_id) && $access_url_id == intval($access_url_id)) {
3831
-            $sql .= ", $access_url_rel_session_table u " .
3831
+            $sql .= ", $access_url_rel_session_table u ".
3832 3832
                 " WHERE s.id = u.session_id AND u.access_url_id = $access_url_id";
3833 3833
         }
3834 3834
         $res = Database::query($sql);
@@ -4075,7 +4075,7 @@  discard block
 block discarded – undo
4075 4075
 
4076 4076
         $tbl_session = Database::get_main_table(TABLE_MAIN_SESSION);
4077 4077
         $tbl_session_user = Database::get_main_table(TABLE_MAIN_SESSION_USER);
4078
-        $tbl_session_course  = Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
4078
+        $tbl_session_course = Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
4079 4079
         $tbl_session_course_user = Database::get_main_table(TABLE_MAIN_SESSION_COURSE_USER);
4080 4080
 
4081 4081
         $sessions = array();
@@ -4169,10 +4169,10 @@  discard block
 block discarded – undo
4169 4169
                     $suffix = null;
4170 4170
                     while (!$unique_name) {
4171 4171
                         if ($i > 1) {
4172
-                            $suffix = ' - ' . $i;
4172
+                            $suffix = ' - '.$i;
4173 4173
                         }
4174
-                        $sql = 'SELECT 1 FROM ' . $tbl_session . '
4175
-                                WHERE name="' . $session_name . $suffix . '"';
4174
+                        $sql = 'SELECT 1 FROM '.$tbl_session.'
4175
+                                WHERE name="' . $session_name.$suffix.'"';
4176 4176
                         $rs = Database::query($sql);
4177 4177
 
4178 4178
                         if (Database::result($rs, 0, 0)) {
@@ -4190,13 +4190,13 @@  discard block
 block discarded – undo
4190 4190
 
4191 4191
                     // Creating the session.
4192 4192
                     $sql = "INSERT IGNORE INTO $tbl_session SET
4193
-                            name = '" . $session_name . "',
4193
+                            name = '".$session_name."',
4194 4194
                             id_coach = '$coach_id',
4195 4195
                             access_start_date = '$date_start',
4196 4196
                             access_end_date = '$date_end',
4197 4197
                             visibility = '$visibilityAfterExpirationPerSession',
4198 4198
                             $sessionCondition
4199
-                            session_admin_id = " . intval($defaultUserId) . $extraParameters . $extraSessionParameters;
4199
+                            session_admin_id = ".intval($defaultUserId).$extraParameters.$extraSessionParameters;
4200 4200
                     Database::query($sql);
4201 4201
 
4202 4202
                     $session_id = Database::insert_id();
@@ -4236,7 +4236,7 @@  discard block
 block discarded – undo
4236 4236
                                 access_start_date = '$date_start',
4237 4237
                                 access_end_date = '$date_end',
4238 4238
                                 visibility = '$visibilityAfterExpirationPerSession',
4239
-                                session_category_id = '$session_category_id' " . $extraParameters . $extraSessionParameters;
4239
+                                session_category_id = '$session_category_id' ".$extraParameters.$extraSessionParameters;
4240 4240
 
4241 4241
                         Database::query($sql);
4242 4242
 
@@ -4256,7 +4256,7 @@  discard block
 block discarded – undo
4256 4256
 
4257 4257
                             // Delete session-user relation only for students
4258 4258
                             $sql = "DELETE FROM $tbl_session_user
4259
-                                    WHERE session_id = '$session_id' AND relation_type <> " . SESSION_RELATION_TYPE_RRHH;
4259
+                                    WHERE session_id = '$session_id' AND relation_type <> ".SESSION_RELATION_TYPE_RRHH;
4260 4260
                             Database::query($sql);
4261 4261
 
4262 4262
                             $sql = "DELETE FROM $tbl_session_course WHERE session_id = '$session_id'";
@@ -4344,7 +4344,7 @@  discard block
 block discarded – undo
4344 4344
 
4345 4345
                             // Delete session-user relation only for students
4346 4346
                             $sql = "DELETE FROM $tbl_session_user
4347
-                                    WHERE session_id = '$session_id' AND relation_type <> " . SESSION_RELATION_TYPE_RRHH;
4347
+                                    WHERE session_id = '$session_id' AND relation_type <> ".SESSION_RELATION_TYPE_RRHH;
4348 4348
                             Database::query($sql);
4349 4349
 
4350 4350
                             $sql = "DELETE FROM $tbl_session_course WHERE session_id = '$session_id'";
@@ -4387,7 +4387,7 @@  discard block
 block discarded – undo
4387 4387
                             $sql = "INSERT IGNORE INTO $tbl_session_user SET
4388 4388
                                     user_id = '$user_id',
4389 4389
                                     session_id = '$session_id',
4390
-                                    registered_at = '" . api_get_utc_datetime() . "'";
4390
+                                    registered_at = '".api_get_utc_datetime()."'";
4391 4391
                             Database::query($sql);
4392 4392
                             if ($debug) {
4393 4393
                                 $logger->addInfo("Sessions - Adding User #$user_id ($user) to session #$session_id");
@@ -5025,7 +5025,7 @@  discard block
 block discarded – undo
5025 5025
 
5026 5026
         if (!empty($lastConnectionDate)) {
5027 5027
             $lastConnectionDate = Database::escape_string($lastConnectionDate);
5028
-            $userConditions .=  " AND u.last_login <= '$lastConnectionDate' ";
5028
+            $userConditions .= " AND u.last_login <= '$lastConnectionDate' ";
5029 5029
         }
5030 5030
 
5031 5031
         if (!empty($keyword)) {
@@ -5084,7 +5084,7 @@  discard block
 block discarded – undo
5084 5084
         $result = Database::query($sql);
5085 5085
         $result = Database::store_result($result);
5086 5086
 
5087
-        return $result ;
5087
+        return $result;
5088 5088
     }
5089 5089
 
5090 5090
     /**
@@ -5144,7 +5144,7 @@  discard block
 block discarded – undo
5144 5144
                     $userToString = null;
5145 5145
                     foreach ($userList as $userInfo) {
5146 5146
                         $newUserList[] = $userInfo['user_id'];
5147
-                        $userToString .= $userInfo['firstname'] . ' ' . $userInfo['lastname'] . '<br />';
5147
+                        $userToString .= $userInfo['firstname'].' '.$userInfo['lastname'].'<br />';
5148 5148
                     }
5149 5149
 
5150 5150
                     if (!empty($sessionsDestination)) {
@@ -5157,7 +5157,7 @@  discard block
 block discarded – undo
5157 5157
                                 $messages[] = Display::return_message(sprintf(get_lang('SessionXSkipped'), $sessionDestinationId), 'warning', false);
5158 5158
                                 continue;
5159 5159
                             }
5160
-                            $messages[] = Display::return_message(get_lang('StudentList') . '<br />' . $userToString, 'info', false);
5160
+                            $messages[] = Display::return_message(get_lang('StudentList').'<br />'.$userToString, 'info', false);
5161 5161
                             SessionManager::suscribe_users_to_session(
5162 5162
                                 $sessionDestinationId,
5163 5163
                                 $newUserList,
@@ -5208,7 +5208,7 @@  discard block
 block discarded – undo
5208 5208
                 }
5209 5209
             }
5210 5210
         }
5211
-        $sessionUrl = api_get_path(WEB_CODE_PATH) . 'admin/resume_session.php?id_session=';
5211
+        $sessionUrl = api_get_path(WEB_CODE_PATH).'admin/resume_session.php?id_session=';
5212 5212
 
5213 5213
         $htmlResult = null;
5214 5214
 
@@ -5223,7 +5223,7 @@  discard block
 block discarded – undo
5223 5223
                     $sessionInfo = self::fetch($sessionId);
5224 5224
                     $htmlResult .= '<br />';
5225 5225
                     $htmlResult .= Display::url(
5226
-                        get_lang('Session') . ': ' . $sessionInfo['name'] . ' <br />', $sessionUrl . $sessionId, array('target' => '_blank')
5226
+                        get_lang('Session').': '.$sessionInfo['name'].' <br />', $sessionUrl.$sessionId, array('target' => '_blank')
5227 5227
                     );
5228 5228
                     $teacherList = array();
5229 5229
                     foreach ($coachList as $coachId) {
@@ -5336,7 +5336,7 @@  discard block
 block discarded – undo
5336 5336
                 }
5337 5337
 
5338 5338
                 $sessionIdList = array_map('intval', $sessionIdList);
5339
-                $sessionToString = implode("', '",  $sessionIdList);
5339
+                $sessionToString = implode("', '", $sessionIdList);
5340 5340
 
5341 5341
                 $course = Database::get_main_table(TABLE_MAIN_COURSE);
5342 5342
                 $sessionCourse = Database::get_main_table(TABLE_MAIN_SESSION_COURSE);
@@ -5348,7 +5348,7 @@  discard block
 block discarded – undo
5348 5348
                         INNER JOIN $courseUser cu ON (cu.c_id = c.id)
5349 5349
 		                WHERE src.session_id IN ('$sessionToString') AND cu.status = 1";
5350 5350
                 $result = Database::query($sql);
5351
-                while($row = Database::fetch_array($result, 'ASSOC')) {
5351
+                while ($row = Database::fetch_array($result, 'ASSOC')) {
5352 5352
                     $teacherListId[$row['user_id']] = $row['user_id'];
5353 5353
                 }
5354 5354
             } else {
@@ -5423,7 +5423,7 @@  discard block
 block discarded – undo
5423 5423
         $toolList = self::getCourseToolToBeManaged();
5424 5424
 
5425 5425
         foreach ($toolList as $tool) {
5426
-            $method = 'add' . $tool;
5426
+            $method = 'add'.$tool;
5427 5427
             if (method_exists(get_class(), $method)) {
5428 5428
                 self::$method($sessionId, $courseId);
5429 5429
             }
@@ -5442,7 +5442,7 @@  discard block
 block discarded – undo
5442 5442
         $toolList = self::getCourseToolToBeManaged();
5443 5443
 
5444 5444
         foreach ($toolList as $tool) {
5445
-            $method = 'remove' . $tool;
5445
+            $method = 'remove'.$tool;
5446 5446
             if (method_exists(get_class(), $method)) {
5447 5447
                 self::$method($sessionId, $courseId);
5448 5448
             }
@@ -5560,18 +5560,18 @@  discard block
 block discarded – undo
5560 5560
                         }
5561 5561
                     }
5562 5562
 
5563
-                    $message .= '<strong>' . get_lang('User') . '</strong> ' . $userInfo['complete_name'] . ' <br />';
5563
+                    $message .= '<strong>'.get_lang('User').'</strong> '.$userInfo['complete_name'].' <br />';
5564 5564
 
5565 5565
                     if (!in_array($userInfo['status'], array(DRH)) && !api_is_platform_admin_by_id($userInfo['user_id'])) {
5566
-                        $message .= get_lang('UserMustHaveTheDrhRole') . '<br />';
5566
+                        $message .= get_lang('UserMustHaveTheDrhRole').'<br />';
5567 5567
                         continue;
5568 5568
                     }
5569 5569
 
5570 5570
                     if (!empty($sessionList)) {
5571
-                        $message .= '<strong>' . get_lang('Sessions') . ':</strong> <br />';
5572
-                        $message .= implode(', ', $sessionList) . '<br /><br />';
5571
+                        $message .= '<strong>'.get_lang('Sessions').':</strong> <br />';
5572
+                        $message .= implode(', ', $sessionList).'<br /><br />';
5573 5573
                     } else {
5574
-                        $message .= get_lang('NoSessionProvided') . ' <br /><br />';
5574
+                        $message .= get_lang('NoSessionProvided').' <br /><br />';
5575 5575
                     }
5576 5576
                 }
5577 5577
             }
@@ -5751,8 +5751,8 @@  discard block
 block discarded – undo
5751 5751
 
5752 5752
         $firstAccess = api_strtotime($courseAccess['login_course_date'], 'UTC');
5753 5753
 
5754
-        $endDateInSeconds = $firstAccess + $duration*24*60*60;
5755
-        $leftDays = round(($endDateInSeconds- $currentTime) / 60 / 60 / 24);
5754
+        $endDateInSeconds = $firstAccess + $duration * 24 * 60 * 60;
5755
+        $leftDays = round(($endDateInSeconds - $currentTime) / 60 / 60 / 24);
5756 5756
 
5757 5757
         return $leftDays;
5758 5758
     }
@@ -6034,7 +6034,7 @@  discard block
 block discarded – undo
6034 6034
         $sql = "SELECT COUNT(1) as count, u.id, scu.status status_in_session, u.status user_status
6035 6035
                 FROM $tableSessionRelCourseRelUser scu
6036 6036
                 INNER JOIN $tableUser u ON scu.user_id = u.id
6037
-                WHERE scu.session_id = " . intval($sessionId) ."
6037
+                WHERE scu.session_id = ".intval($sessionId)."
6038 6038
                 GROUP BY u.id";
6039 6039
 
6040 6040
         $result = Database::query($sql);
@@ -6069,7 +6069,7 @@  discard block
 block discarded – undo
6069 6069
             $sfTable = Database::get_main_table(TABLE_EXTRA_FIELD);
6070 6070
             $sfvTable = Database::get_main_table(TABLE_EXTRA_FIELD_VALUES);
6071 6071
             // Join session field and session field values tables
6072
-            $joinTable = $sfTable . ' sf INNER JOIN ' . $sfvTable . ' sfv ON sf.id = sfv.field_id';
6072
+            $joinTable = $sfTable.' sf INNER JOIN '.$sfvTable.' sfv ON sf.id = sfv.field_id';
6073 6073
             $fieldsArray = array();
6074 6074
             foreach ($extraFields as $field) {
6075 6075
                 $fieldsArray[] = Database::escape_string($field);
@@ -6112,14 +6112,14 @@  discard block
 block discarded – undo
6112 6112
                 for ($i = 1; $i < count($fieldsArray); $i++) {
6113 6113
                     $whereParams .= ', ?';
6114 6114
                 }
6115
-                $whereFieldVariables = ' variable IN ( ' . $whereParams .' )';
6116
-                $whereFieldIds = 'field_id IN ( ' . $whereParams .  ' )';
6115
+                $whereFieldVariables = ' variable IN ( '.$whereParams.' )';
6116
+                $whereFieldIds = 'field_id IN ( '.$whereParams.' )';
6117 6117
             }
6118 6118
             // Get session fields
6119 6119
             $extraField = new ExtraField('session');
6120 6120
             $questionMarks = substr(str_repeat('?, ', count($fieldsArray)), 0, -2);
6121 6121
             $fieldsList = $extraField->get_all(array(
6122
-                ' variable IN ( ' . $questionMarks . ' )' => $fieldsArray,
6122
+                ' variable IN ( '.$questionMarks.' )' => $fieldsArray,
6123 6123
             ));
6124 6124
             // Index session fields
6125 6125
             foreach ($fieldsList as $field) {
@@ -6128,7 +6128,7 @@  discard block
 block discarded – undo
6128 6128
             // Get session field values
6129 6129
             $extra = new ExtraFieldValue('session');
6130 6130
             $questionMarksFields = substr(str_repeat('?, ', count($fields)), 0, -2);
6131
-            $sessionFieldValueList = $extra->get_all(array ('where' => array('field_id IN ( ' . $questionMarksFields . ' )' => array_keys($fields))));
6131
+            $sessionFieldValueList = $extra->get_all(array('where' => array('field_id IN ( '.$questionMarksFields.' )' => array_keys($fields))));
6132 6132
             // Add session fields values to session list
6133 6133
             foreach ($sessionList as $id => &$session) {
6134 6134
                 foreach ($sessionFieldValueList as $sessionFieldValue) {
@@ -6181,7 +6181,7 @@  discard block
 block discarded – undo
6181 6181
             // Check the result
6182 6182
             if ($result < 1) {
6183 6183
                 // If not found any result, update error message
6184
-                $errorResult['errorMessage'] = 'Not found any session category name ' . $categoryName;
6184
+                $errorResult['errorMessage'] = 'Not found any session category name '.$categoryName;
6185 6185
             } elseif (count($result) > 1 && !$force) {
6186 6186
                 // If found more than one result and force is disabled, update error message
6187 6187
                 $errorResult['errorMessage'] = 'Found many session categories';
@@ -6240,7 +6240,7 @@  discard block
 block discarded – undo
6240 6240
             // Check if session list query had result
6241 6241
             if (!empty($sessionList)) {
6242 6242
                 // implode all session id
6243
-                $sessionIdsString = '(' . implode(', ', array_keys($sessionList)) . ')';
6243
+                $sessionIdsString = '('.implode(', ', array_keys($sessionList)).')';
6244 6244
                 // Get all field variables
6245 6245
                 $sessionFieldList = Database::select(
6246 6246
                     'id, variable',
@@ -6327,7 +6327,7 @@  discard block
 block discarded – undo
6327 6327
                 return $sessionList;
6328 6328
             } else {
6329 6329
                 // Not found result, update error message
6330
-                $errorResult['errorMessage'] = 'Not found any session for session category id ' . $sessionCategoryId;
6330
+                $errorResult['errorMessage'] = 'Not found any session for session category id '.$sessionCategoryId;
6331 6331
             }
6332 6332
         }
6333 6333
 
@@ -6431,7 +6431,7 @@  discard block
 block discarded – undo
6431 6431
 
6432 6432
         $sessionExtraField = new ExtraField('session');
6433 6433
         $fieldList = $sessionExtraField->get_all(array(
6434
-            "variable IN ( " . implode(", ", $variablePlaceHolders) . " ) " => $variables,
6434
+            "variable IN ( ".implode(", ", $variablePlaceHolders)." ) " => $variables,
6435 6435
         ));
6436 6436
 
6437 6437
         $fields = array();
@@ -6445,7 +6445,7 @@  discard block
 block discarded – undo
6445 6445
         $extra = new ExtraFieldValue('session');
6446 6446
         $sessionFieldValueList = $extra->get_all(
6447 6447
             array(
6448
-                "field_id IN ( " . implode(", ", $variablePlaceHolders) . " )" => array_keys($fields),
6448
+                "field_id IN ( ".implode(", ", $variablePlaceHolders)." )" => array_keys($fields),
6449 6449
             )
6450 6450
         );
6451 6451
 
@@ -6516,7 +6516,7 @@  discard block
 block discarded – undo
6516 6516
                 FROM $sessionTable s
6517 6517
                 INNER JOIN $sessionUserTable sru ON s.id = sru.id_session
6518 6518
                 WHERE
6519
-                    (sru.id_user IN (" . implode(', ', $userIdList) . ")
6519
+                    (sru.id_user IN (".implode(', ', $userIdList).")
6520 6520
                     AND sru.relation_type = 0
6521 6521
                 )";
6522 6522
 
@@ -6532,7 +6532,7 @@  discard block
 block discarded – undo
6532 6532
                         WHERE
6533 6533
                             srau.access_url_id = $accessUrlId
6534 6534
                             AND (
6535
-                                sru.id_user IN (" . implode(', ', $userIdList) . ")
6535
+                                sru.id_user IN (".implode(', ', $userIdList).")
6536 6536
                                 AND sru.relation_type = 0
6537 6537
                             )";
6538 6538
             }
@@ -6553,7 +6553,7 @@  discard block
 block discarded – undo
6553 6553
      */
6554 6554
     public static function getSessionVisibility($sessionInfo)
6555 6555
     {
6556
-        switch($sessionInfo['visibility']) {
6556
+        switch ($sessionInfo['visibility']) {
6557 6557
             case 1:
6558 6558
                 return get_lang('ReadOnly');
6559 6559
             case 2:
@@ -6584,7 +6584,7 @@  discard block
 block discarded – undo
6584 6584
 
6585 6585
         $result = '';
6586 6586
         if (!empty($startDateToLocal) && !empty($endDateToLocal)) {
6587
-            $result =  sprintf(get_lang('FromDateXToDateY'), $startDateToLocal, $endDateToLocal);
6587
+            $result = sprintf(get_lang('FromDateXToDateY'), $startDateToLocal, $endDateToLocal);
6588 6588
         } else {
6589 6589
             if (!empty($startDateToLocal)) {
6590 6590
                 $result = get_lang('From').' '.$startDateToLocal;
@@ -6727,7 +6727,7 @@  discard block
 block discarded – undo
6727 6727
                     get_lang('CoachName'),
6728 6728
                     null,
6729 6729
                     [
6730
-                        'url' => api_get_path(WEB_AJAX_PATH) . 'session.ajax.php?a=search_general_coach',
6730
+                        'url' => api_get_path(WEB_AJAX_PATH).'session.ajax.php?a=search_general_coach',
6731 6731
                         'width' => '100%',
6732 6732
                     ]
6733 6733
                 );
@@ -6738,7 +6738,7 @@  discard block
 block discarded – undo
6738 6738
         $form->addHtml('<div id="ajax_list_coachs"></div>');
6739 6739
 
6740 6740
         $form->addButtonAdvancedSettings('advanced_params');
6741
-        $form->addElement('html','<div id="advanced_params_options" style="display:none">');
6741
+        $form->addElement('html', '<div id="advanced_params_options" style="display:none">');
6742 6742
 
6743 6743
         $form->addSelect('session_category', get_lang('SessionCategory'), $categoriesOptions, array(
6744 6744
             'id' => 'session_category'
@@ -6876,7 +6876,7 @@  discard block
 block discarded – undo
6876 6876
         $extra_field = new ExtraField('session');
6877 6877
         $extra = $extra_field->addElements($form, $sessionId);
6878 6878
 
6879
-        $form->addElement('html','</div>');
6879
+        $form->addElement('html', '</div>');
6880 6880
 
6881 6881
         $js = $extra['jquery_ready_content'];
6882 6882
 
@@ -6907,16 +6907,16 @@  discard block
 block discarded – undo
6907 6907
         if (api_is_session_admin() &&
6908 6908
             api_get_setting('allow_session_admins_to_see_all_sessions') == 'false'
6909 6909
         ) {
6910
-            $where.=" WHERE s.session_admin_id = $user_id ";
6910
+            $where .= " WHERE s.session_admin_id = $user_id ";
6911 6911
         }
6912 6912
 
6913 6913
         if (!empty($options['where'])) {
6914 6914
             $options['where'] = str_replace('course_title', 'c.title', $options['where']);
6915
-            $options['where'] = str_replace("( session_active = '0' )", '1=1',  $options['where']);
6915
+            $options['where'] = str_replace("( session_active = '0' )", '1=1', $options['where']);
6916 6916
 
6917 6917
             $options['where'] = str_replace(
6918 6918
                 array("AND session_active = '1'  )", " AND (  session_active = '1'  )"),
6919
-                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 " )
6919
+                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 ")
6920 6920
                 , $options['where']
6921 6921
             );
6922 6922
 
@@ -6958,10 +6958,10 @@  discard block
 block discarded – undo
6958 6958
                        $where ";
6959 6959
 
6960 6960
         if (api_is_multiple_url_enabled()) {
6961
-            $table_access_url_rel_session= Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
6961
+            $table_access_url_rel_session = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
6962 6962
             $access_url_id = api_get_current_access_url_id();
6963 6963
             if ($access_url_id != -1) {
6964
-                $where.= " AND ar.access_url_id = $access_url_id ";
6964
+                $where .= " AND ar.access_url_id = $access_url_id ";
6965 6965
 
6966 6966
                 $query_rows = "SELECT count(*) as total_rows
6967 6967
                                FROM $tbl_session s
@@ -7006,12 +7006,12 @@  discard block
 block discarded – undo
7006 7006
                     //get_lang('CourseTitle'),
7007 7007
                     get_lang('Visibility'),
7008 7008
                 );
7009
-                $column_model = array (
7010
-                    array('name'=>'name', 'index'=>'s.name', 'width'=>'160',  'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7011
-                    array('name'=>'category_name', 'index'=>'category_name', 'width'=>'40',  'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7012
-                    array('name'=>'display_start_date', 'index'=>'display_start_date', 'width'=>'50',   'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_today', 'sopt' => $date_operators)),
7013
-                    array('name'=>'display_end_date', 'index'=>'display_end_date', 'width'=>'50',   'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_one_month', 'sopt' => $date_operators)),
7014
-                    array('name'=>'visibility', 'index'=>'visibility',      'width'=>'40',   'align'=>'left', 'search' => 'false'),
7009
+                $column_model = array(
7010
+                    array('name'=>'name', 'index'=>'s.name', 'width'=>'160', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7011
+                    array('name'=>'category_name', 'index'=>'category_name', 'width'=>'40', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7012
+                    array('name'=>'display_start_date', 'index'=>'display_start_date', 'width'=>'50', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_today', 'sopt' => $date_operators)),
7013
+                    array('name'=>'display_end_date', 'index'=>'display_end_date', 'width'=>'50', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_one_month', 'sopt' => $date_operators)),
7014
+                    array('name'=>'visibility', 'index'=>'visibility', 'width'=>'40', 'align'=>'left', 'search' => 'false'),
7015 7015
                 );
7016 7016
                 break;
7017 7017
             case 'complete':
@@ -7024,12 +7024,12 @@  discard block
 block discarded – undo
7024 7024
                     get_lang('Visibility'),
7025 7025
                     get_lang('CourseTitle'),
7026 7026
                 );
7027
-                $column_model = array (
7028
-                    array('name'=>'name', 'index'=>'s.name', 'width'=>'200',  'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7029
-                    array('name'=>'display_start_date', 'index'=>'display_start_date', 'width'=>'70',   'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_today', 'sopt' => $date_operators)),
7030
-                    array('name'=>'display_end_date', 'index'=>'display_end_date', 'width'=>'70',   'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_one_month', 'sopt' => $date_operators)),
7031
-                    array('name'=>'coach_name', 'index'=>'coach_name',     'width'=>'70',   'align'=>'left', 'search' => 'false', 'searchoptions' => array('sopt' => $operators)),
7032
-                    array('name'=>'session_active', 'index'=>'session_active', 'width'=>'25',   'align'=>'left', 'search' => 'true', 'stype'=>'select',
7027
+                $column_model = array(
7028
+                    array('name'=>'name', 'index'=>'s.name', 'width'=>'200', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('sopt' => $operators)),
7029
+                    array('name'=>'display_start_date', 'index'=>'display_start_date', 'width'=>'70', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_today', 'sopt' => $date_operators)),
7030
+                    array('name'=>'display_end_date', 'index'=>'display_end_date', 'width'=>'70', 'align'=>'left', 'search' => 'true', 'searchoptions' => array('dataInit' => 'date_pick_one_month', 'sopt' => $date_operators)),
7031
+                    array('name'=>'coach_name', 'index'=>'coach_name', 'width'=>'70', 'align'=>'left', 'search' => 'false', 'searchoptions' => array('sopt' => $operators)),
7032
+                    array('name'=>'session_active', 'index'=>'session_active', 'width'=>'25', 'align'=>'left', 'search' => 'true', 'stype'=>'select',
7033 7033
                         // for the bottom bar
7034 7034
                         'searchoptions' => array(
7035 7035
                             'defaultValue'  => '1',
@@ -7037,8 +7037,8 @@  discard block
 block discarded – undo
7037 7037
                         // for the top bar
7038 7038
                         'editoptions' => array('value' => '" ":'.get_lang('All').';1:'.get_lang('Active').';0:'.get_lang('Inactive')),
7039 7039
                     ),
7040
-                    array('name'=>'visibility',     'index'=>'visibility',      'width'=>'40',   'align'=>'left', 'search' => 'false'),
7041
-                    array('name'=>'course_title',    'index'=>'course_title',   'width'=>'50',   'hidden' => 'true', 'search' => 'true', 'searchoptions' => array('searchhidden' =>'true','sopt' => $operators)),
7040
+                    array('name'=>'visibility', 'index'=>'visibility', 'width'=>'40', 'align'=>'left', 'search' => 'false'),
7041
+                    array('name'=>'course_title', 'index'=>'course_title', 'width'=>'50', 'hidden' => 'true', 'search' => 'true', 'searchoptions' => array('searchhidden' =>'true', 'sopt' => $operators)),
7042 7042
                 );
7043 7043
                 break;
7044 7044
         }
@@ -7047,14 +7047,14 @@  discard block
 block discarded – undo
7047 7047
         $session_field = new ExtraField('session');
7048 7048
         $rules = $session_field->getRules($columns, $column_model);
7049 7049
 
7050
-        $column_model[] = array('name'=>'actions', 'index'=>'actions', 'width'=>'80',  'align'=>'left','formatter'=>'action_formatter','sortable'=>'false', 'search' => 'false');
7050
+        $column_model[] = array('name'=>'actions', 'index'=>'actions', 'width'=>'80', 'align'=>'left', 'formatter'=>'action_formatter', 'sortable'=>'false', 'search' => 'false');
7051 7051
         $columns[] = get_lang('Actions');
7052 7052
 
7053 7053
         foreach ($column_model as $col_model) {
7054 7054
             $simple_column_name[] = $col_model['name'];
7055 7055
         }
7056 7056
 
7057
-        $return_array =  array(
7057
+        $return_array = array(
7058 7058
             'columns' => $columns,
7059 7059
             'column_model' => $column_model,
7060 7060
             'rules' => $rules,
@@ -7143,7 +7143,7 @@  discard block
 block discarded – undo
7143 7143
             if (api_is_session_admin() &&
7144 7144
                 api_get_setting('allow_session_admins_to_manage_all_sessions') == 'false'
7145 7145
             ) {
7146
-                $where.=" AND s.session_admin_id = $user_id ";
7146
+                $where .= " AND s.session_admin_id = $user_id ";
7147 7147
             }
7148 7148
         }
7149 7149
 
@@ -7226,11 +7226,11 @@  discard block
 block discarded – undo
7226 7226
             }
7227 7227
             $options['where'] = str_replace('course_title', 'c.title', $options['where']);
7228 7228
 
7229
-            $options['where'] = str_replace("( session_active = '0' )", '1=1',  $options['where']);
7229
+            $options['where'] = str_replace("( session_active = '0' )", '1=1', $options['where']);
7230 7230
 
7231 7231
             $options['where'] = str_replace(
7232 7232
                 array("AND session_active = '1'  )", " AND (  session_active = '1'  )"),
7233
-                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 " )
7233
+                array(') GROUP BY s.name HAVING session_active = 1 ', " GROUP BY s.name HAVING session_active = 1 ")
7234 7234
                 , $options['where']
7235 7235
             );
7236 7236
 
@@ -7265,10 +7265,10 @@  discard block
 block discarded – undo
7265 7265
             $where;
7266 7266
 
7267 7267
         if (api_is_multiple_url_enabled()) {
7268
-            $table_access_url_rel_session= Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
7268
+            $table_access_url_rel_session = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_SESSION);
7269 7269
             $access_url_id = api_get_current_access_url_id();
7270 7270
             if ($access_url_id != -1) {
7271
-                $where.= " AND ar.access_url_id = $access_url_id ";
7271
+                $where .= " AND ar.access_url_id = $access_url_id ";
7272 7272
                 $query = "$select
7273 7273
                     FROM $tbl_session s
7274 7274
                     LEFT JOIN $tbl_session_field_values fv ON (fv.session_id = s.id)
@@ -7295,7 +7295,7 @@  discard block
 block discarded – undo
7295 7295
         $formatted_sessions = array();
7296 7296
 
7297 7297
         if (Database::num_rows($result)) {
7298
-            $sessions   = Database::store_result($result, 'ASSOC');
7298
+            $sessions = Database::store_result($result, 'ASSOC');
7299 7299
             foreach ($sessions as $session) {
7300 7300
                 $session_id = $session['id'];
7301 7301
                 $session['name'] = Display::url($session['name'], "resume_session.php?id_session=".$session['id']);
@@ -7310,14 +7310,14 @@  discard block
 block discarded – undo
7310 7310
 
7311 7311
                 switch ($session['visibility']) {
7312 7312
                     case SESSION_VISIBLE_READ_ONLY: //1
7313
-                        $session['visibility'] =  get_lang('ReadOnly');
7313
+                        $session['visibility'] = get_lang('ReadOnly');
7314 7314
                         break;
7315 7315
                     case SESSION_VISIBLE:           //2
7316 7316
                     case SESSION_AVAILABLE:         //4
7317
-                        $session['visibility'] =  get_lang('Visible');
7317
+                        $session['visibility'] = get_lang('Visible');
7318 7318
                         break;
7319 7319
                     case SESSION_INVISIBLE:         //3
7320
-                        $session['visibility'] =  api_ucfirst(get_lang('Invisible'));
7320
+                        $session['visibility'] = api_ucfirst(get_lang('Invisible'));
7321 7321
                         break;
7322 7322
                 }
7323 7323
 
@@ -7393,7 +7393,7 @@  discard block
 block discarded – undo
7393 7393
         if (empty($session)) {
7394 7394
             return false;
7395 7395
         }
7396
-        return api_get_path(WEB_CODE_PATH) . 'session/resume_session.php?id_session=' . $id;
7396
+        return api_get_path(WEB_CODE_PATH).'session/resume_session.php?id_session='.$id;
7397 7397
     }
7398 7398
 
7399 7399
     /**
@@ -7411,7 +7411,7 @@  discard block
 block discarded – undo
7411 7411
             return false;
7412 7412
         }
7413 7413
         if (empty($courseId)) {
7414
-            return api_get_path(WEB_CODE_PATH) . 'session/index.php?session_id=' . $id;
7414
+            return api_get_path(WEB_CODE_PATH).'session/index.php?session_id='.$id;
7415 7415
         } else {
7416 7416
             $courseInfo = api_get_course_info_by_id($courseId);
7417 7417
             if ($courseInfo) {
@@ -7657,7 +7657,7 @@  discard block
 block discarded – undo
7657 7657
             // sort $listCat by catSessionName
7658 7658
             usort($listCat, 'self::compareBySessionName');
7659 7659
             // in each catSession sort sessionList by sessionName
7660
-            foreach($listCat as $i => $listCatSessionInfo) {
7660
+            foreach ($listCat as $i => $listCatSessionInfo) {
7661 7661
                 $listSessionList = $listCatSessionInfo['sessionList'];
7662 7662
                 usort($listSessionList, 'self::compareCatSessionInfo');
7663 7663
                 $listCat[$i]['sessionList'] = $listSessionList;
@@ -7672,8 +7672,8 @@  discard block
 block discarded – undo
7672 7672
             );
7673 7673
 
7674 7674
             $userCatId = intval($userCatId);
7675
-            $listResults[$userCatId]['courseInUserCategoryId'] =  $userCatId;
7676
-            $listResults[$userCatId]['courseInUserCategoryTitle'] =  $userCatTitle;
7675
+            $listResults[$userCatId]['courseInUserCategoryId'] = $userCatId;
7676
+            $listResults[$userCatId]['courseInUserCategoryTitle'] = $userCatTitle;
7677 7677
             $listResults[$userCatId]['courseInUserCatList'][] = $listOneCourse;
7678 7678
         }
7679 7679
 
@@ -7699,7 +7699,7 @@  discard block
 block discarded – undo
7699 7699
     {
7700 7700
         if ($listA['sessionName'] == $listB['sessionName']) {
7701 7701
             return 0;
7702
-        } else if($listA['sessionName'] > $listB['sessionName']) {
7702
+        } else if ($listA['sessionName'] > $listB['sessionName']) {
7703 7703
             return 1;
7704 7704
         } else {
7705 7705
             return -1;
@@ -7719,7 +7719,7 @@  discard block
 block discarded – undo
7719 7719
             return 1;
7720 7720
         } else if ($listA['catSessionName'] == $listB['catSessionName']) {
7721 7721
             return 0;
7722
-        } else if($listA['catSessionName'] > $listB['catSessionName']) {
7722
+        } else if ($listA['catSessionName'] > $listB['catSessionName']) {
7723 7723
             return 1;
7724 7724
         } else {
7725 7725
             return -1;
@@ -7735,7 +7735,7 @@  discard block
 block discarded – undo
7735 7735
     {
7736 7736
         if ($listA['courseInUserCategoryTitle'] == $listB['courseInUserCategoryTitle']) {
7737 7737
             return 0;
7738
-        } else if($listA['courseInUserCategoryTitle'] > $listB['courseInUserCategoryTitle']) {
7738
+        } else if ($listA['courseInUserCategoryTitle'] > $listB['courseInUserCategoryTitle']) {
7739 7739
             return 1;
7740 7740
         } else {
7741 7741
             return -1;
@@ -7751,7 +7751,7 @@  discard block
 block discarded – undo
7751 7751
     {
7752 7752
         if ($listA['title'] == $listB['title']) {
7753 7753
             return 0;
7754
-        } else if($listA['title'] > $listB['title']) {
7754
+        } else if ($listA['title'] > $listB['title']) {
7755 7755
             return 1;
7756 7756
         } else {
7757 7757
             return -1;
@@ -7797,8 +7797,8 @@  discard block
 block discarded – undo
7797 7797
 
7798 7798
                 $marginShift = 20;
7799 7799
                 if ($catSessionName != '') {
7800
-                    $htmlCatSessions .= '<div style="margin-left:'.$marginShift.'px;">' .
7801
-                        CourseManager::course_item_html($listParamsCatSession, true) . '</div>';
7800
+                    $htmlCatSessions .= '<div style="margin-left:'.$marginShift.'px;">'.
7801
+                        CourseManager::course_item_html($listParamsCatSession, true).'</div>';
7802 7802
                     $marginShift = 40;
7803 7803
                 }
7804 7804
 
Please login to merge, or discard this patch.
Braces   +14 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1588,8 +1588,10 @@  discard block
 block discarded – undo
1588 1588
         if (empty($session_visibility)) {
1589 1589
             $session_visibility = $session->getVisibility();
1590 1590
             //default status loaded if empty
1591
-            if (empty($session_visibility))
1592
-                $session_visibility = SESSION_VISIBLE_READ_ONLY; // by default readonly 1
1591
+            if (empty($session_visibility)) {
1592
+                            $session_visibility = SESSION_VISIBLE_READ_ONLY;
1593
+            }
1594
+            // by default readonly 1
1593 1595
         } else {
1594 1596
             if (!in_array($session_visibility, array(SESSION_VISIBLE_READ_ONLY, SESSION_VISIBLE, SESSION_INVISIBLE))) {
1595 1597
                 $session_visibility = SESSION_VISIBLE_READ_ONLY;
@@ -2792,10 +2794,11 @@  discard block
 block discarded – undo
2792 2794
                                 c_id = $courseId AND
2793 2795
                                 user_id = $user_id ";
2794 2796
                     $result = Database::query($sql);
2795
-                    if (Database::affected_rows($result) > 0)
2796
-                        return true;
2797
-                    else
2798
-                        return false;
2797
+                    if (Database::affected_rows($result) > 0) {
2798
+                                            return true;
2799
+                    } else {
2800
+                                            return false;
2801
+                    }
2799 2802
                 } else {
2800 2803
                     // The user is not subscribed to the session, so make sure
2801 2804
                     // he isn't subscribed to a course in this session either
@@ -2806,10 +2809,11 @@  discard block
 block discarded – undo
2806 2809
                                 c_id = $courseId AND
2807 2810
                                 user_id = $user_id ";
2808 2811
                     $result = Database::query($sql);
2809
-                    if (Database::affected_rows($result) > 0)
2810
-                        return true;
2811
-                    else
2812
-                        return false;
2812
+                    if (Database::affected_rows($result) > 0) {
2813
+                                            return true;
2814
+                    } else {
2815
+                                            return false;
2816
+                    }
2813 2817
                 }
2814 2818
             } else {
2815 2819
                 // Assign user as a coach to course
Please login to merge, or discard this patch.
main/inc/lib/skill.lib.php 3 patches
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -326,6 +326,7 @@  discard block
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * Gets an element
329
+     * @param integer $gradebook_id
329 330
      */
330 331
     public function get_skill_info($skill_id, $gradebook_id)
331 332
     {
@@ -544,7 +545,7 @@  discard block
 block discarded – undo
544 545
      * Gets an element
545 546
      * @param int $id
546 547
      *
547
-     * @return array|mixed
548
+     * @return integer
548 549
      */
549 550
     public function get($id)
550 551
     {
@@ -885,7 +886,7 @@  discard block
 block discarded – undo
885 886
     /**
886 887
      * Get user's skills
887 888
      *
888
-     * @param int $userId User's id
889
+     * @param integer $user_id User's id
889 890
      * @param bool $get_skill_data
890 891
      */
891 892
     public function get_user_skills($user_id, $get_skill_data = false)
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -33,11 +33,11 @@  discard block
 block discarded – undo
33 33
     }
34 34
 
35 35
     /**
36
-    * This function is for editing profile info from profile_id.
37
-    * @param int    $profileId
38
-    * @param string $name
39
-    * @param string $description
40
-    */
36
+     * This function is for editing profile info from profile_id.
37
+     * @param int    $profileId
38
+     * @param string $name
39
+     * @param string $description
40
+     */
41 41
     public function updateProfileInfo($profileId, $name, $description)
42 42
     {
43 43
         $profileId = intval($profileId);
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
     }
129 129
 
130 130
     /**
131
-    * This function is for getting profile info from profile_id.
132
-    * @param int $profileId
133
-    */
131
+     * This function is for getting profile info from profile_id.
132
+     * @param int $profileId
133
+     */
134 134
 
135 135
     public function getProfileInfo($profileId)
136 136
     {
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
     {
735 735
         $skill_rel_skill = new SkillRelSkill();
736 736
         $skills = $skill_rel_skill->get_direct_parents($skill_id, true);
737
-        foreach($skills as &$skill) {
737
+        foreach ($skills as &$skill) {
738 738
             $skill['data'] = self::get($skill['skill_id']);
739 739
             $skill_info2 = $skill_rel_skill->get_skill_info($skill['skill_id']);
740 740
             $skill['data']['parent_id'] = $skill_info2['parent_id'];
@@ -772,7 +772,7 @@  discard block
 block discarded – undo
772 772
                     $attributes = array(
773 773
                         'skill_id'      => $skill_id,
774 774
                         'parent_id'     => $parent_id,
775
-                        'relation_type' => (isset($params['relation_type'])?$params['relation_type']:0),
775
+                        'relation_type' => (isset($params['relation_type']) ? $params['relation_type'] : 0),
776 776
                         //'level'         => $params['level'],
777 777
                     );
778 778
                     $skill_rel_skill->save($attributes);
@@ -969,8 +969,8 @@  discard block
 block discarded – undo
969 969
                     // 2nd node
970 970
                     $skills[$skill_id] = $skill_info;
971 971
                     // Uncomment code below to hide the searched skill
972
-                    $skills[$skill_id]['data']['parent_id'] =  $skill_info['extra']['parent_id'];
973
-                    $skills[$skill_id]['parent_id'] =  1;
972
+                    $skills[$skill_id]['data']['parent_id'] = $skill_info['extra']['parent_id'];
973
+                    $skills[$skill_id]['parent_id'] = 1;
974 974
                 }
975 975
             }
976 976
         }
@@ -1033,7 +1033,7 @@  discard block
 block discarded – undo
1033 1033
                     $skill['data']['skill_has_gradebook'] = true;
1034 1034
                 }
1035 1035
                 $refs[$skill['id']] = &$skill;
1036
-                $flat_array[$skill['id']] =  &$skill;
1036
+                $flat_array[$skill['id']] = &$skill;
1037 1037
             }
1038 1038
 
1039 1039
             // Checking family value
@@ -1054,7 +1054,7 @@  discard block
 block discarded – undo
1054 1054
                 $refs['root']['children'][0] = $skills[1];
1055 1055
                 $skills[$skill_id]['data']['family_id'] = 1;
1056 1056
                 $refs['root']['children'][0]['children'][0] = $skills[$skill_id];
1057
-                $flat_array[$skill_id] =  $skills[$skill_id];
1057
+                $flat_array[$skill_id] = $skills[$skill_id];
1058 1058
             } else {
1059 1059
                 // Moving node to the children index of their parents
1060 1060
 
@@ -1063,7 +1063,7 @@  discard block
 block discarded – undo
1063 1063
                         $skill['data']['family_id'] = $new_family_array[$skill['id']];
1064 1064
                     }
1065 1065
                     $refs[$skill['parent_id']]['children'][] = &$skill;
1066
-                    $flat_array[$my_skill_id] =  $skill;
1066
+                    $flat_array[$my_skill_id] = $skill;
1067 1067
                 }
1068 1068
             }
1069 1069
 
@@ -1161,7 +1161,7 @@  discard block
 block discarded – undo
1161 1161
                 INNER JOIN {$this->table_skill_rel_user} su
1162 1162
                 ON (s.id = su.skill_id)
1163 1163
                 WHERE user_id = $user_id";
1164
-        $result  = Database::query($sql);
1164
+        $result = Database::query($sql);
1165 1165
         if (Database::num_rows($result)) {
1166 1166
             $result = Database::fetch_row($result);
1167 1167
             return $result[0];
@@ -1203,7 +1203,7 @@  discard block
 block discarded – undo
1203 1203
      */
1204 1204
     public function get_user_list_skill_ranking_count()
1205 1205
     {
1206
-        $sql    = "SELECT count(*) FROM (
1206
+        $sql = "SELECT count(*) FROM (
1207 1207
                         SELECT count(distinct 1)
1208 1208
                         FROM {$this->table} s
1209 1209
                         INNER JOIN {$this->table_skill_rel_user} su
@@ -1256,7 +1256,7 @@  discard block
 block discarded – undo
1256 1256
                 ON c.code = g.course_code
1257 1257
                 WHERE sg.skill_id = $skill_id
1258 1258
                 AND (g.session_id IS NULL OR g.session_id = 0)";
1259
-        $result   = Database::query($sql);
1259
+        $result = Database::query($sql);
1260 1260
 
1261 1261
         return Database::store_result($result, 'ASSOC');
1262 1262
     }
@@ -1443,7 +1443,7 @@  discard block
 block discarded – undo
1443 1443
                 WHERE sg.skill_id = $skillId
1444 1444
                 AND g.session_id > 0";
1445 1445
 
1446
-        $result   = Database::query($sql);
1446
+        $result = Database::query($sql);
1447 1447
 
1448 1448
         return Database::store_result($result, 'ASSOC');
1449 1449
     }
Please login to merge, or discard this patch.
main/inc/lib/skill.visualizer.lib.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@
 block discarded – undo
30 30
         $this->center_x = intval($offset_x + $this->canvas_x/2 - $this->block_size/2);
31 31
     }
32 32
 
33
+    /**
34
+     * @param string $class
35
+     */
33 36
     function prepare_skill_box($skill, $position, $class)
34 37
     {
35 38
         $block_id = $skill['id'];
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     {
28 28
         $this->skills   = $skills;
29 29
         $this->type     = $type;
30
-        $this->center_x = intval($offset_x + $this->canvas_x/2 - $this->block_size/2);
30
+        $this->center_x = intval($offset_x + $this->canvas_x / 2 - $this->block_size / 2);
31 31
     }
32 32
 
33 33
     function prepare_skill_box($skill, $position, $class)
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
39 39
             $extra_class = 'second_window';
40 40
         }
41 41
 
42
-        $this->html .= '<div id="block_'.$block_id.'" class = "open_block window '.$extra_class.'  '.$class.'" style = "top:' . $position['y'] . 'px; left:' . $position['x'] . 'px;">';
42
+        $this->html .= '<div id="block_'.$block_id.'" class = "open_block window '.$extra_class.'  '.$class.'" style = "top:'.$position['y'].'px; left:'.$position['x'].'px;">';
43 43
 
44
-        $content =  $skill['name'];
44
+        $content = $skill['name'];
45 45
         $content .= '<div class="btn-group">';
46 46
         $content .= Display::url(get_lang('Edit'), '#', array('id'=>'edit_block_'.$block_id, 'class'=>'edit_block btn'));
47 47
         $content .= Display::url('+', '#', array('id'=>'edit_block_'.$block_id, 'class'=>'edit_block btn'));
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
         }
88 88
         //default_arrow_color
89 89
 
90
-        $this->js .= 'var e'.$block_id.' = prepare("block_' . $block_id.'",  '.$end_point.');'."\n";
91
-        $this->js .= 'var e'.$skill['parent_id'].' = prepare("block_' . $skill['parent_id'].'",  '.$end_point.');'."\n";
92
-        $this->js .= 'jsPlumb.connect({source: e'.$block_id.', target:e'.$skill['parent_id'].'});'."\n";;
90
+        $this->js .= 'var e'.$block_id.' = prepare("block_'.$block_id.'",  '.$end_point.');'."\n";
91
+        $this->js .= 'var e'.$skill['parent_id'].' = prepare("block_'.$skill['parent_id'].'",  '.$end_point.');'."\n";
92
+        $this->js .= 'jsPlumb.connect({source: e'.$block_id.', target:e'.$skill['parent_id'].'});'."\n"; ;
93 93
     }
94 94
 
95 95
     /**
@@ -125,10 +125,10 @@  discard block
 block discarded – undo
125 125
         $brothers = array();
126 126
 
127 127
         foreach ($this->skills as &$skill) {
128
-            if (!in_array($skill['parent_id'], array(0,1))) {
128
+            if (!in_array($skill['parent_id'], array(0, 1))) {
129 129
                 continue;
130 130
             }
131
-            $childs = isset($skill['children']) ? count($skill['children']) : 0 ;
131
+            $childs = isset($skill['children']) ? count($skill['children']) : 0;
132 132
 
133 133
             //$x = round($this->offsetX * sin(deg2rad($corner * $count)));
134 134
             //$y = round($this->offsetY * cos(deg2rad($corner * $count)));
@@ -144,10 +144,10 @@  discard block
 block discarded – undo
144 144
             if ($skill['parent_id'] == 0) {
145 145
                 //$x = 130*$childs/2;
146 146
                 //$x = $this->space_between_blocks_x*$childs/2;
147
-                $x = $this->canvas_x/2  - $this->block_size/2;
147
+                $x = $this->canvas_x / 2 - $this->block_size / 2;
148 148
             } else {
149 149
                 $max = isset($this->skills[$skill['parent_id']]['children']) ? count($this->skills[$skill['parent_id']]['children']) : 0;
150
-                foreach($this->skills[$skill['parent_id']]['children'] as  $id => $sk) {
150
+                foreach ($this->skills[$skill['parent_id']]['children'] as  $id => $sk) {
151 151
                     if ($skill['id'] == $sk['id']) {
152 152
                         break;
153 153
                     }
@@ -155,17 +155,17 @@  discard block
 block discarded – undo
155 155
                 }
156 156
                 $parent_x = isset($this->skills[$skill['parent_id']]['x']) ? $this->skills[$skill['parent_id']]['x'] : 0;
157 157
                 //$x = $my_count*$this->space_between_blocks_x + $parent_x  + $this->block_size - ($this->space_between_blocks_x*$max/2) ;
158
-                $x = $my_count*$this->space_between_blocks_x + $parent_x  + $this->block_size - ($this->canvas_x/2 ) ;
158
+                $x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);
159 159
             }
160 160
 
161
-            $y = $skill['level']*$this->space_between_blocks_y;
161
+            $y = $skill['level'] * $this->space_between_blocks_y;
162 162
 
163 163
             $skill['x'] = $x;
164 164
             $skill['y'] = $y;
165 165
 
166 166
             //$skill['description']  = "{$brothers[$skill['parent_id']]} $x - $y";
167 167
             //$skill['name']  =  $skill['name']."  |  $x = $my_count * 150  +  $parent_x - (150* $max/2) - 10*$childs ";
168
-            $this->add_item($skill, array('x' => $this->offset_x + $x, 'y' => $this->offset_y +$y));
168
+            $this->add_item($skill, array('x' => $this->offset_x + $x, 'y' => $this->offset_y + $y));
169 169
         }
170 170
         return $this->get_html();
171 171
     }
Please login to merge, or discard this patch.