save_item() - Code Metrics - Inspection of "LP: Add ScormApi.php class" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4791a8...56927d )

by Julito

created 2021-03-21 11:19 UTC

save_item() F

↳ Parent: Project

Complexity

Conditions

130

Size

Total Lines	506
Code Lines	251

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	130
eloc	251
nop	18
dl	0
loc	506
rs	3.3333
c	0
b	0
f	0

How to fix Long Method Complexity Many Parameters

<?php

/* For licensing terms, see /license.txt */

/**
 * This script contains the server part of the AJAX interaction process.
 * The client part is located * in lp_api.php or other api's.
 *
 * @author Yannick Warnier <[email protected]>
 */

// Flag to allow for anonymous user - needs to be set before global.inc.php.
$use_anonymous = true;
require_once __DIR__.'/../inc/global.inc.php';

api_protect_course_script();

$interactions = [];
if (isset($_REQUEST['interact'])) {
    if (is_array($_REQUEST['interact'])) {
        foreach ($_REQUEST['interact'] as $idx => $interac) {
            $interactions[$idx] = preg_split('/,/', substr($interac, 1, -1));
            if (!isset($interactions[$idx][7])) { // Make sure there are 7 elements.
                $interactions[$idx][7] = '';
            }
        }
    }
}

echo ScormApi::saveItem(
    (!empty($_REQUEST['lid']) ? $_REQUEST['lid'] : null),
    (!empty($_REQUEST['uid']) ? $_REQUEST['uid'] : null),
    (!empty($_REQUEST['vid']) ? $_REQUEST['vid'] : null),
    (!empty($_REQUEST['iid']) ? $_REQUEST['iid'] : null),
    (!empty($_REQUEST['s']) ? $_REQUEST['s'] : null),
    (!empty($_REQUEST['max']) ? $_REQUEST['max'] : null),
    (!empty($_REQUEST['min']) ? $_REQUEST['min'] : null),
    (!empty($_REQUEST['status']) ? $_REQUEST['status'] : null),
    (!empty($_REQUEST['t']) ? $_REQUEST['t'] : null),
    (!empty($_REQUEST['suspend']) ? $_REQUEST['suspend'] : null),
    (!empty($_REQUEST['loc']) ? $_REQUEST['loc'] : null),
    $interactions,
    (!empty($_REQUEST['core_exit']) ? $_REQUEST['core_exit'] : ''),
    (!empty($_REQUEST['session_id']) ? $_REQUEST['session_id'] : ''),
    (!empty($_REQUEST['course_id']) ? $_REQUEST['course_id'] : ''),
    (empty($_REQUEST['finish']) ? 0 : 1),
    (empty($_REQUEST['userNavigatesAway']) ? 0 : 1),
    (empty($_REQUEST['statusSignalReceived']) ? 0 : 1),
    $_REQUEST['switch_next'] ?? 0
);


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			/**
6			* This script contains the server part of the AJAX interaction process.
7			* The client part is located * in lp_api.php or other api's.
8			*
9			* @author Yannick Warnier <[email protected]>
10			*/
11
12			// Flag to allow for anonymous user - needs to be set before global.inc.php.
13			$use_anonymous = true;
14			require_once __DIR__.'/../inc/global.inc.php';
15
16			api_protect_course_script();
17
18			$interactions = [];
19			if (isset($_REQUEST['interact'])) {
20			if (is_array($_REQUEST['interact'])) {
21			foreach ($_REQUEST['interact'] as $idx => $interac) {
22			$interactions[$idx] = preg_split('/,/', substr($interac, 1, -1));
23			if (!isset($interactions[$idx][7])) { // Make sure there are 7 elements.
24			$interactions[$idx][7] = '';
25			}
26			}
27			}
28			}
29
30			echo ScormApi::saveItem(
31			(!empty($_REQUEST['lid']) ? $_REQUEST['lid'] : null),
32			(!empty($_REQUEST['uid']) ? $_REQUEST['uid'] : null),
33			(!empty($_REQUEST['vid']) ? $_REQUEST['vid'] : null),
34			(!empty($_REQUEST['iid']) ? $_REQUEST['iid'] : null),
35			(!empty($_REQUEST['s']) ? $_REQUEST['s'] : null),
36			(!empty($_REQUEST['max']) ? $_REQUEST['max'] : null),
37			(!empty($_REQUEST['min']) ? $_REQUEST['min'] : null),
38			(!empty($_REQUEST['status']) ? $_REQUEST['status'] : null),
39			(!empty($_REQUEST['t']) ? $_REQUEST['t'] : null),
40			(!empty($_REQUEST['suspend']) ? $_REQUEST['suspend'] : null),
41			(!empty($_REQUEST['loc']) ? $_REQUEST['loc'] : null),
42			$interactions,
43			(!empty($_REQUEST['core_exit']) ? $_REQUEST['core_exit'] : ''),
44			(!empty($_REQUEST['session_id']) ? $_REQUEST['session_id'] : ''),
45			(!empty($_REQUEST['course_id']) ? $_REQUEST['course_id'] : ''),
46			(empty($_REQUEST['finish']) ? 0 : 1),
47			(empty($_REQUEST['userNavigatesAway']) ? 0 : 1),
48			(empty($_REQUEST['statusSignalReceived']) ? 0 : 1),
49			$_REQUEST['switch_next'] ?? 0
50			);
51

chamilo / chamilo-lms

Push — master ( 4791a8...56927d )

save_item() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like