GroupVoter::voteOnAttribute() - Code Metrics - Inspection of "Fix group permissions + fix tests" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0cdc5b...b949c4 )

by Julito

created 2021-06-14 13:35 UTC

GroupVoter::voteOnAttribute() D

↳ Parent: GroupVoter

Complexity

Conditions	20
Paths	68

Size

Total Lines	101
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	20
eloc	54
nc	68
nop	3
dl	0
loc	101
rs	4.1666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Security\Authorization\Voter;

use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Repository\Node\CourseRepository;
use Chamilo\CourseBundle\Entity\CGroup;
use Chamilo\CourseBundle\Repository\CGroupRepository;
use Doctrine\ORM\EntityManager;
use GroupManager;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\UserInterface;

class GroupVoter extends Voter
{
    public const VIEW = 'VIEW';
    public const EDIT = 'EDIT';
    public const DELETE = 'DELETE';

    private Security $security;
    private RequestStack $requestStack;

    public function __construct(
        //EntityManager $entityManager,
        //CourseRepository $courseManager,
        //CGroupRepository $groupManager,
        RequestStack $requestStack,
        Security $security
    ) {
        //$this->entityManager = $entityManager;
        //$this->courseManager = $courseManager;
        //$this->groupManager = $groupManager;
        $this->security = $security;
        $this->requestStack = $requestStack;
    }

    protected function supports(string $attribute, $subject): bool
    {
        $options = [
            self::VIEW,
            self::EDIT,
            self::DELETE,
        ];

        return $subject instanceof CGroup && \in_array($attribute, $options, true);
    }

    protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
    {
        /** @var User $user */
        $user = $token->getUser();

        // make sure there is a user object (i.e. that the user is logged in)
        if (!$user instanceof UserInterface) {
            return false;
        }

        if (false === $subject) {
            return false;
        }

        // Admins have access to everything
        if ($this->security->isGranted('ROLE_ADMIN')) {
            return true;
        }

        /** @var CGroup $group */
        $group = $subject;

        // Legacy
        //\GroupManager::userHasAccessToBrowse($user->getId(), $group);
        $isTutor = $group->hasTutor($user);

        switch ($attribute) {
            case self::VIEW:
                if ($isTutor) {
                    $user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_TEACHER);

                    return true;
                }

                if (!$group->getStatus()) {
                    return false;
                }

                $userIsInGroup = $group->hasMember($user);

                if ($userIsInGroup) {
                    $user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_STUDENT);
                }

                // Check if user has access in legacy tool.
                $request = $this->requestStack->getCurrentRequest();
                $requestUri = $request->getRequestUri();

                $tools = [
                    '/main/forum/' => $group->getForumState(),
                    '/documents/' => $group->getDocState(),
                    '/main/calendar/' => $group->getCalendarState(),
                    '/main/announcements/' => $group->getAnnouncementsState(),
                    '/main/work/' => $group->getWorkState(),
                    '/main/wiki/' => $group->getWikiState(),
                    //'/main/chat/' => $group->getAnnouncementsState(),  ??
                ];

                $toolStatus = null;
                foreach ($tools as $path => $status) {
                    if (false !== strpos($requestUri, $path)) {
                        $toolStatus = $status;

                        break;
                    }
                }

                switch ($toolStatus) {
                    case GroupManager::TOOL_NOT_AVAILABLE:
                        return false;
                    case GroupManager::TOOL_PUBLIC:
                        return true;
                    case GroupManager::TOOL_PRIVATE:
                        if ($userIsInGroup) {
                            return true;
                        }

                        break;
                    case GroupManager::TOOL_PRIVATE_BETWEEN_USERS:
                        // Only works for announcements for now
                        if ($userIsInGroup && '/main/announcements/' === $path) {

                            return true;
                        }

                        break;
                }

                break;
            case self::EDIT:
            case self::DELETE:
                if ($isTutor) {
                    $user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_TEACHER);

                    return true;
                }

                break;
        }
        //dump("You don't have access to this group!!");

        return false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Security\Authorization\Voter;
8
9			use Chamilo\CoreBundle\Entity\User;
10			use Chamilo\CoreBundle\Repository\Node\CourseRepository;
11			use Chamilo\CourseBundle\Entity\CGroup;
12			use Chamilo\CourseBundle\Repository\CGroupRepository;
13			use Doctrine\ORM\EntityManager;
14			use GroupManager;
15			use Symfony\Component\HttpFoundation\RequestStack;
16			use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
17			use Symfony\Component\Security\Core\Authorization\Voter\Voter;
18			use Symfony\Component\Security\Core\Security;
19			use Symfony\Component\Security\Core\User\UserInterface;
20
21			class GroupVoter extends Voter
22			{
23			public const VIEW = 'VIEW';
24			public const EDIT = 'EDIT';
25			public const DELETE = 'DELETE';
26
27			private Security $security;
28			private RequestStack $requestStack;
29
30			public function __construct(
31			//EntityManager $entityManager,
32			//CourseRepository $courseManager,
33			//CGroupRepository $groupManager,
34			RequestStack $requestStack,
35			Security $security
36			) {
37			//$this->entityManager = $entityManager;
38			//$this->courseManager = $courseManager;
39			//$this->groupManager = $groupManager;
40			$this->security = $security;
41			$this->requestStack = $requestStack;
42			}
43
44			protected function supports(string $attribute, $subject): bool
45			{
46			$options = [
47			self::VIEW,
48			self::EDIT,
49			self::DELETE,
50			];
51
52			return $subject instanceof CGroup && \in_array($attribute, $options, true);
53			}
54
55			protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
56			{
57			/** @var User $user */
58			$user = $token->getUser();
59
60			// make sure there is a user object (i.e. that the user is logged in)
61			if (!$user instanceof UserInterface) {
62			return false;
63			}
64
65			if (false === $subject) {
66			return false;
67			}
68
69			// Admins have access to everything
70			if ($this->security->isGranted('ROLE_ADMIN')) {
71			return true;
72			}
73
74			/** @var CGroup $group */
75			$group = $subject;
76
77			// Legacy
78			//\GroupManager::userHasAccessToBrowse($user->getId(), $group);
79			$isTutor = $group->hasTutor($user);
80
81			switch ($attribute) {
82			case self::VIEW:
83			if ($isTutor) {
84			$user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_TEACHER);
85
86			return true;
87			}
88
89			if (!$group->getStatus()) {
90			return false;
91			}
92
93			$userIsInGroup = $group->hasMember($user);
94
95			if ($userIsInGroup) {
96			$user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_STUDENT);
97			}
98
99			// Check if user has access in legacy tool.
100			$request = $this->requestStack->getCurrentRequest();
101			$requestUri = $request->getRequestUri();
102
103			$tools = [
104			'/main/forum/' => $group->getForumState(),
105			'/documents/' => $group->getDocState(),
106			'/main/calendar/' => $group->getCalendarState(),
107			'/main/announcements/' => $group->getAnnouncementsState(),
108			'/main/work/' => $group->getWorkState(),
109			'/main/wiki/' => $group->getWikiState(),
110			//'/main/chat/' => $group->getAnnouncementsState(), ??
111			];
112
113			$toolStatus = null;
114			foreach ($tools as $path => $status) {
115			if (false !== strpos($requestUri, $path)) {
116			$toolStatus = $status;
117
118			break;
119			}
120			}
121
122			switch ($toolStatus) {
123			case GroupManager::TOOL_NOT_AVAILABLE:
124			return false;
125			case GroupManager::TOOL_PUBLIC:
126			return true;
127			case GroupManager::TOOL_PRIVATE:
128			if ($userIsInGroup) {
129			return true;
130			}
131
132			break;
133			case GroupManager::TOOL_PRIVATE_BETWEEN_USERS:
134			// Only works for announcements for now
135			if ($userIsInGroup && '/main/announcements/' === $path) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-06-14 13:47 UTC by Report Bug Copy Issue Report The variable `$path` seems to be defined by a `foreach` iteration on line `114`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
136			return true;
137			}
138
139			break;
140			}
141
142			break;
143			case self::EDIT:
144			case self::DELETE:
145			if ($isTutor) {
146			$user->addRole(ResourceNodeVoter::ROLE_CURRENT_COURSE_GROUP_TEACHER);
147
148			return true;
149			}
150
151			break;
152			}
153			//dump("You don't have access to this group!!");
154
155			return false;
156			}
157			}
158

chamilo / chamilo-lms

Push — master ( 0cdc5b...b949c4 )

GroupVoter::voteOnAttribute() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like