chamilo / chamilo-lms

main/inc/lib/pear/HTML/QuickForm/Rule.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      *
      * @param     mixed     Options for the rule
      * @access    public
-     * @return    array     first element is code to setup validation, second is the check itself
+     * @return    string[]     first element is code to setup validation, second is the check itself
      * @abstract
      */
     function getValidationScript($options = null)

Indentation +21 added lines, -21 removed lines

@@ -33,34 +33,34 @@
  */
 class HTML_QuickForm_Rule
 {
-   /**
-    * Name of the rule to use in validate method
-    *
-    * This property is used in more global rules like Callback and Regex
-    * to determine which callback and which regex is to be used for validation
-    *
-    * @var  string
-    * @access   public
-    */
+    /**
+     * Name of the rule to use in validate method
+     *
+     * This property is used in more global rules like Callback and Regex
+     * to determine which callback and which regex is to be used for validation
+     *
+     * @var  string
+     * @access   public
+     */
     var $name;
 
-   /**
-    * Validates a value
-    *
-    * @access public
-    * @abstract
-    */
+    /**
+     * Validates a value
+     *
+     * @access public
+     * @abstract
+     */
     function validate($value, $options)
     {
         return true;
     }
 
-   /**
-    * Sets the rule name
-    *
-    * @param  string    rule name
-    * @access public
-    */
+    /**
+     * Sets the rule name
+     *
+     * @param  string    rule name
+     * @access public
+     */
     function setName($ruleName)
     {
         $this->name = $ruleName;

main/inc/lib/pear/HTML/QuickForm/Rule/Compare.php

Doc Comments +3 added lines

@@ -73,6 +73,9 @@
     }
 
 
+    /**
+     * @param integer[] $values
+     */
     function validate($values, $operator = null)
     {
         $operator = $this->_findOperator($operator);

Indentation +12 added lines, -12 removed lines

@@ -35,11 +35,11 @@ 
  */
 class HTML_QuickForm_Rule_Compare extends HTML_QuickForm_Rule
 {
-   /**
-    * Possible operators to use
-    * @var array
-    * @access private
-    */
+    /**
+     * Possible operators to use
+     * @var array
+     * @access private
+     */
     var $_operators = array(
         'eq'  => '===',
         'neq' => '!==',
@@ -51,13 +51,13 @@ 
         '!='  => '!=='
     );
 
-   /**
-    * Returns the operator to use for comparing the values
-    *
-    * @access private
-    * @param  string     operator name
-    * @return string     operator to use for validation
-    */
+    /**
+     * Returns the operator to use for comparing the values
+     *
+     * @access private
+     * @param  string     operator name
+     * @return string     operator to use for validation
+     */
     function _findOperator($name)
     {
         $name = trim($name);

Spacing +2 added lines, -2 removed lines

@@ -78,9 +78,9 @@
         $operator = $this->_findOperator($operator);
 
         if ('===' != $operator && '!==' != $operator) {
-            $compareFn = create_function('$a, $b', 'return floatval($a) ' . $operator . ' floatval($b);');
+            $compareFn = create_function('$a, $b', 'return floatval($a) '.$operator.' floatval($b);');
         } else {
-            $compareFn = create_function('$a, $b', 'return strval($a) ' . $operator . ' strval($b);');
+            $compareFn = create_function('$a, $b', 'return strval($a) '.$operator.' strval($b);');
         }
 
         return $compareFn($values[0], $values[1]);

main/inc/lib/pear/HTML/QuickForm/Rule/Date.php

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 	/**
 	 * Function to check a date
 	 * @see HTML_QuickForm_Rule
-	 * @param array $date An array with keys F (month), d (day) and Y (year)
+	 * @param string $date An array with keys F (month), d (day) and Y (year)
 	 * @return boolean True if date is valid
 	 */
 	function validate($date, $options)

Indentation +10 added lines, -10 removed lines

@@ -6,15 +6,15 @@
  */
 class Html_Quickform_Rule_Date extends HTML_QuickForm_Rule
 {
-	/**
-	 * Function to check a date
-	 * @see HTML_QuickForm_Rule
-	 * @param array $date An array with keys F (month), d (day) and Y (year)
-	 * @return boolean True if date is valid
-	 */
-	function validate($date, $options)
-	{
-		$compareDate = create_function('$a', 'return checkdate($a[\'M\'],$a[\'d\'],$a[\'Y\']);');
+    /**
+     * Function to check a date
+     * @see HTML_QuickForm_Rule
+     * @param array $date An array with keys F (month), d (day) and Y (year)
+     * @return boolean True if date is valid
+     */
+    function validate($date, $options)
+    {
+        $compareDate = create_function('$a', 'return checkdate($a[\'M\'],$a[\'d\'],$a[\'Y\']);');
         return $compareDate($date);
-	}
+    }
 }

main/inc/lib/pear/HTML/QuickForm/RuleRegistry.php

Doc Comments +2 added lines, -1 removed lines

@@ -174,7 +174,7 @@ 
      * @param     mixed    $values          Can be a scalar or an array of values
      *                                      to be validated
      * @param     mixed    $options         Options used by the rule
-     * @param     mixed    $multiple        Whether to validate an array of values altogether
+     * @param     boolean    $multiple        Whether to validate an array of values altogether
      * @access    public
      * @return    mixed    true if no error found, int of valid values (when an array of values is given) or false if error
      */
@@ -258,6 +258,7 @@ 
     *                                   the value
     * @param  integer                   value's index in the array (only used for
     *                                   multielement rules)
+    * @param integer $index
     * @return array     first item is value javascript, second is reset
     */
     function _getJsValue(&$element, $elementName, $reset = false, $index = null)

Indentation +38 added lines, -38 removed lines

@@ -225,41 +225,41 @@ 
         list ($jsPrefix, $jsCheck) = $rule->getValidationScript($ruleData['format']);
         if (!isset($ruleData['howmany'])) {
             $js = $jsValue . "\n" . $jsPrefix .
-                  "  if (" . str_replace('{jsVar}', 'value', $jsCheck) . " && !errFlag['{$jsField}']) {\n" .
-                  "    errFlag['{$jsField}'] = true;\n" .
-                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
-                  $jsReset .
-                  "  }\n";
+                    "  if (" . str_replace('{jsVar}', 'value', $jsCheck) . " && !errFlag['{$jsField}']) {\n" .
+                    "    errFlag['{$jsField}'] = true;\n" .
+                    "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
+                    $jsReset .
+                    "  }\n";
         } else {
             $js = $jsValue . "\n" . $jsPrefix .
-                  "  var res = 0;\n" .
-                  "  for (var i = 0; i < value.length; i++) {\n" .
-                  "    if (!(" . str_replace('{jsVar}', 'value[i]', $jsCheck) . ")) {\n" .
-                  "      res++;\n" .
-                  "    }\n" .
-                  "  }\n" .
-                  "  if (res < {$ruleData['howmany']} && !errFlag['{$jsField}']) {\n" .
-                  "    errFlag['{$jsField}'] = true;\n" .
-                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
-                  $jsReset .
-                  "  }\n";
+                    "  var res = 0;\n" .
+                    "  for (var i = 0; i < value.length; i++) {\n" .
+                    "    if (!(" . str_replace('{jsVar}', 'value[i]', $jsCheck) . ")) {\n" .
+                    "      res++;\n" .
+                    "    }\n" .
+                    "  }\n" .
+                    "  if (res < {$ruleData['howmany']} && !errFlag['{$jsField}']) {\n" .
+                    "    errFlag['{$jsField}'] = true;\n" .
+                    "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
+                    $jsReset .
+                    "  }\n";
         }
         return $js;
     } // end func getValidationScript
 
 
-   /**
-    * Returns JavaScript to get and to reset the element's value
-    *
-    * @access private
-    * @param  HTML_QuickForm_element    element being processed
-    * @param  string                    element's name
-    * @param  bool                      whether to generate JavaScript to reset
-    *                                   the value
-    * @param  integer                   value's index in the array (only used for
-    *                                   multielement rules)
-    * @return array     first item is value javascript, second is reset
-    */
+    /**
+     * Returns JavaScript to get and to reset the element's value
+     *
+     * @access private
+     * @param  HTML_QuickForm_element    element being processed
+     * @param  string                    element's name
+     * @param  bool                      whether to generate JavaScript to reset
+     *                                   the value
+     * @param  integer                   value's index in the array (only used for
+     *                                   multielement rules)
+     * @return array     first item is value javascript, second is reset
+     */
     function _getJsValue(&$element, $elementName, $reset = false, $index = null)
     {
         $jsIndex = isset($index)? '[' . $index . ']': '';
@@ -270,7 +270,7 @@ 
             for ($i = 0, $count = count($elements); $i < $count; $i++) {
                 $append = ($elements[$i]->getType() == 'select' && $elements[$i]->getMultiple())? '[]': '';
                 $value .= "'" . $element->getElementName($i) . $append . "': true" .
-                          ($i < $count - 1? ', ': '');
+                            ($i < $count - 1? ', ': '');
             }
             $value .=
                 "};\n" .
@@ -363,17 +363,17 @@ 
 
         } elseif ($element->getType() == 'radio') {
             $value = "  value{$jsIndex} = '';\n" .
-                     // Fix for bug #5644
-                     "  var els = 'length' in frm.elements['$elementName']? frm.elements['$elementName']: [ frm.elements['$elementName'] ];\n" .
-                     "  for (var i = 0; i < els.length; i++) {\n" .
-                     "    if (els[i].checked) {\n" .
-                     "      value{$jsIndex} = els[i].value;\n" .
-                     "    }\n" .
-                     "  }";
+                        // Fix for bug #5644
+                        "  var els = 'length' in frm.elements['$elementName']? frm.elements['$elementName']: [ frm.elements['$elementName'] ];\n" .
+                        "  for (var i = 0; i < els.length; i++) {\n" .
+                        "    if (els[i].checked) {\n" .
+                        "      value{$jsIndex} = els[i].value;\n" .
+                        "    }\n" .
+                        "  }";
             if ($reset) {
                 $tmp_reset .= "    for (var i = 0; i < field.length; i++) {\n" .
-                              "      field[i].checked = field[i].defaultChecked;\n" .
-                              "    }";
+                                "      field[i].checked = field[i].defaultChecked;\n" .
+                                "    }";
             }
 
         } else {

Spacing +94 added lines, -94 removed lines

@@ -89,7 +89,7 @@ 
         $type = strtolower($type);
         if ($type == 'regex') {
             // Regular expression
-            $rule =& $this->getRule('regex');
+            $rule = & $this->getRule('regex');
             $rule->addData($ruleName, $data1);
 
         } elseif ($type == 'function' || $type == 'callback') {
@@ -208,7 +208,7 @@ 
      */
     function getValidationScript(&$element, $elementName, $ruleData)
     {
-        $reset =  (isset($ruleData['reset'])) ? $ruleData['reset'] : false;
+        $reset = (isset($ruleData['reset'])) ? $ruleData['reset'] : false;
         $rule  = $this->getRule($ruleData['type']);
         if (!is_array($element)) {
             list($jsValue, $jsReset) = $this->_getJsValue($element, $elementName, $reset, null);
@@ -217,31 +217,31 @@ 
             $jsReset = '';
             for ($i = 0; $i < count($element); $i++) {
                 list($tmp_value, $tmp_reset) = $this->_getJsValue($element[$i], $element[$i]->getName(), $reset, $i);
-                $jsValue .= "\n" . $tmp_value;
+                $jsValue .= "\n".$tmp_value;
                 $jsReset .= $tmp_reset;
             }
         }
-        $jsField = isset($ruleData['group'])? $ruleData['group']: $elementName;
+        $jsField = isset($ruleData['group']) ? $ruleData['group'] : $elementName;
         list ($jsPrefix, $jsCheck) = $rule->getValidationScript($ruleData['format']);
         if (!isset($ruleData['howmany'])) {
-            $js = $jsValue . "\n" . $jsPrefix .
-                  "  if (" . str_replace('{jsVar}', 'value', $jsCheck) . " && !errFlag['{$jsField}']) {\n" .
-                  "    errFlag['{$jsField}'] = true;\n" .
-                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
-                  $jsReset .
+            $js = $jsValue."\n".$jsPrefix.
+                  "  if (".str_replace('{jsVar}', 'value', $jsCheck)." && !errFlag['{$jsField}']) {\n".
+                  "    errFlag['{$jsField}'] = true;\n".
+                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n".
+                  $jsReset.
                   "  }\n";
         } else {
-            $js = $jsValue . "\n" . $jsPrefix .
-                  "  var res = 0;\n" .
-                  "  for (var i = 0; i < value.length; i++) {\n" .
-                  "    if (!(" . str_replace('{jsVar}', 'value[i]', $jsCheck) . ")) {\n" .
-                  "      res++;\n" .
-                  "    }\n" .
-                  "  }\n" .
-                  "  if (res < {$ruleData['howmany']} && !errFlag['{$jsField}']) {\n" .
-                  "    errFlag['{$jsField}'] = true;\n" .
-                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n" .
-                  $jsReset .
+            $js = $jsValue."\n".$jsPrefix.
+                  "  var res = 0;\n".
+                  "  for (var i = 0; i < value.length; i++) {\n".
+                  "    if (!(".str_replace('{jsVar}', 'value[i]', $jsCheck).")) {\n".
+                  "      res++;\n".
+                  "    }\n".
+                  "  }\n".
+                  "  if (res < {$ruleData['howmany']} && !errFlag['{$jsField}']) {\n".
+                  "    errFlag['{$jsField}'] = true;\n".
+                  "    _qfMsg = _qfMsg + '\\n - {$ruleData['message']}';\n".
+                  $jsReset.
                   "  }\n";
         }
         return $js;
@@ -262,72 +262,72 @@ 
     */
     function _getJsValue(&$element, $elementName, $reset = false, $index = null)
     {
-        $jsIndex = isset($index)? '[' . $index . ']': '';
-        $tmp_reset = $reset? "    var field = frm.elements['$elementName'];\n": '';
+        $jsIndex = isset($index) ? '['.$index.']' : '';
+        $tmp_reset = $reset ? "    var field = frm.elements['$elementName'];\n" : '';
         if (is_a($element, 'html_quickform_group')) {
             $value = "  _qfGroups['{$elementName}'] = {";
-            $elements =& $element->getElements();
+            $elements = & $element->getElements();
             for ($i = 0, $count = count($elements); $i < $count; $i++) {
-                $append = ($elements[$i]->getType() == 'select' && $elements[$i]->getMultiple())? '[]': '';
-                $value .= "'" . $element->getElementName($i) . $append . "': true" .
-                          ($i < $count - 1? ', ': '');
+                $append = ($elements[$i]->getType() == 'select' && $elements[$i]->getMultiple()) ? '[]' : '';
+                $value .= "'".$element->getElementName($i).$append."': true".
+                          ($i < $count - 1 ? ', ' : '');
             }
             $value .=
-                "};\n" .
-                "  value{$jsIndex} = new Array();\n" .
-                "  var valueIdx = 0;\n" .
-                "  for (var i = 0; i < frm.elements.length; i++) {\n" .
-                "    var _element = frm.elements[i];\n" .
-                "    if (_element.name in _qfGroups['{$elementName}']) {\n" .
-                "      switch (_element.type) {\n" .
-                "        case 'checkbox':\n" .
-                "        case 'radio':\n" .
-                "          if (_element.checked) {\n" .
-                "            value{$jsIndex}[valueIdx++] = _element.value;\n" .
-                "          }\n" .
-                "          break;\n" .
-                "        case 'select-one':\n" .
-                "          if (-1 != _element.selectedIndex) {\n" .
-                "            value{$jsIndex}[valueIdx++] = _element.options[_element.selectedIndex].value;\n" .
-                "          }\n" .
-                "          break;\n" .
-                "        case 'select-multiple':\n" .
-                "          var tmpVal = new Array();\n" .
-                "          var tmpIdx = 0;\n" .
-                "          for (var j = 0; j < _element.options.length; j++) {\n" .
-                "            if (_element.options[j].selected) {\n" .
-                "              tmpVal[tmpIdx++] = _element.options[j].value;\n" .
-                "            }\n" .
-                "          }\n" .
-                "          if (tmpIdx > 0) {\n" .
-                "            value{$jsIndex}[valueIdx++] = tmpVal;\n" .
-                "          }\n" .
-                "          break;\n" .
-                "        default:\n" .
-                "          value{$jsIndex}[valueIdx++] = _element.value;\n" .
-                "      }\n" .
-                "    }\n" .
+                "};\n".
+                "  value{$jsIndex} = new Array();\n".
+                "  var valueIdx = 0;\n".
+                "  for (var i = 0; i < frm.elements.length; i++) {\n".
+                "    var _element = frm.elements[i];\n".
+                "    if (_element.name in _qfGroups['{$elementName}']) {\n".
+                "      switch (_element.type) {\n".
+                "        case 'checkbox':\n".
+                "        case 'radio':\n".
+                "          if (_element.checked) {\n".
+                "            value{$jsIndex}[valueIdx++] = _element.value;\n".
+                "          }\n".
+                "          break;\n".
+                "        case 'select-one':\n".
+                "          if (-1 != _element.selectedIndex) {\n".
+                "            value{$jsIndex}[valueIdx++] = _element.options[_element.selectedIndex].value;\n".
+                "          }\n".
+                "          break;\n".
+                "        case 'select-multiple':\n".
+                "          var tmpVal = new Array();\n".
+                "          var tmpIdx = 0;\n".
+                "          for (var j = 0; j < _element.options.length; j++) {\n".
+                "            if (_element.options[j].selected) {\n".
+                "              tmpVal[tmpIdx++] = _element.options[j].value;\n".
+                "            }\n".
+                "          }\n".
+                "          if (tmpIdx > 0) {\n".
+                "            value{$jsIndex}[valueIdx++] = tmpVal;\n".
+                "          }\n".
+                "          break;\n".
+                "        default:\n".
+                "          value{$jsIndex}[valueIdx++] = _element.value;\n".
+                "      }\n".
+                "    }\n".
                 "  }\n";
             if ($reset) {
                 $tmp_reset =
-                    "    for (var i = 0; i < frm.elements.length; i++) {\n" .
-                    "      var _element = frm.elements[i];\n" .
-                    "      if (_element.name in _qfGroups['{$elementName}']) {\n" .
-                    "        switch (_element.type) {\n" .
-                    "          case 'checkbox':\n" .
-                    "          case 'radio':\n" .
-                    "            _element.checked = _element.defaultChecked;\n" .
-                    "            break;\n" .
-                    "          case 'select-one':\n" .
-                    "          case 'select-multiple':\n" .
-                    "            for (var j = 0; j < _element.options.length; j++) {\n" .
-                    "              _element.options[j].selected = _element.options[j].defaultSelected;\n" .
-                    "            }\n" .
-                    "            break;\n" .
-                    "          default:\n" .
-                    "            _element.value = _element.defaultValue;\n" .
-                    "        }\n" .
-                    "      }\n" .
+                    "    for (var i = 0; i < frm.elements.length; i++) {\n".
+                    "      var _element = frm.elements[i];\n".
+                    "      if (_element.name in _qfGroups['{$elementName}']) {\n".
+                    "        switch (_element.type) {\n".
+                    "          case 'checkbox':\n".
+                    "          case 'radio':\n".
+                    "            _element.checked = _element.defaultChecked;\n".
+                    "            break;\n".
+                    "          case 'select-one':\n".
+                    "          case 'select-multiple':\n".
+                    "            for (var j = 0; j < _element.options.length; j++) {\n".
+                    "              _element.options[j].selected = _element.options[j].defaultSelected;\n".
+                    "            }\n".
+                    "            break;\n".
+                    "          default:\n".
+                    "            _element.value = _element.defaultValue;\n".
+                    "        }\n".
+                    "      }\n".
                     "    }\n";
             }
 
@@ -335,20 +335,20 @@ 
             if ($element->getMultiple()) {
                 $elementName .= '[]';
                 $value =
-                    "  value{$jsIndex} = new Array();\n" .
-                    "  var valueIdx = 0;\n" .
-                    "  for (var i = 0; i < frm.elements['{$elementName}'].options.length; i++) {\n" .
-                    "    if (frm.elements['{$elementName}'].options[i].selected) {\n" .
-                    "      value{$jsIndex}[valueIdx++] = frm.elements['{$elementName}'].options[i].value;\n" .
-                    "    }\n" .
+                    "  value{$jsIndex} = new Array();\n".
+                    "  var valueIdx = 0;\n".
+                    "  for (var i = 0; i < frm.elements['{$elementName}'].options.length; i++) {\n".
+                    "    if (frm.elements['{$elementName}'].options[i].selected) {\n".
+                    "      value{$jsIndex}[valueIdx++] = frm.elements['{$elementName}'].options[i].value;\n".
+                    "    }\n".
                     "  }\n";
             } else {
                 $value = "  value{$jsIndex} = frm.elements['{$elementName}'].selectedIndex == -1? '': frm.elements['{$elementName}'].options[frm.elements['{$elementName}'].selectedIndex].value;\n";
             }
             if ($reset) {
                 $tmp_reset .=
-                    "    for (var i = 0; i < field.options.length; i++) {\n" .
-                    "      field.options[i].selected = field.options[i].defaultSelected;\n" .
+                    "    for (var i = 0; i < field.options.length; i++) {\n".
+                    "      field.options[i].selected = field.options[i].defaultSelected;\n".
                     "    }\n";
             }
 
@@ -362,17 +362,17 @@ 
             }
 
         } elseif ($element->getType() == 'radio') {
-            $value = "  value{$jsIndex} = '';\n" .
+            $value = "  value{$jsIndex} = '';\n".
                      // Fix for bug #5644
-                     "  var els = 'length' in frm.elements['$elementName']? frm.elements['$elementName']: [ frm.elements['$elementName'] ];\n" .
-                     "  for (var i = 0; i < els.length; i++) {\n" .
-                     "    if (els[i].checked) {\n" .
-                     "      value{$jsIndex} = els[i].value;\n" .
-                     "    }\n" .
+                     "  var els = 'length' in frm.elements['$elementName']? frm.elements['$elementName']: [ frm.elements['$elementName'] ];\n".
+                     "  for (var i = 0; i < els.length; i++) {\n".
+                     "    if (els[i].checked) {\n".
+                     "      value{$jsIndex} = els[i].value;\n".
+                     "    }\n".
                      "  }";
             if ($reset) {
-                $tmp_reset .= "    for (var i = 0; i < field.length; i++) {\n" .
-                              "      field[i].checked = field[i].defaultChecked;\n" .
+                $tmp_reset .= "    for (var i = 0; i < field.length; i++) {\n".
+                              "      field[i].checked = field[i].defaultChecked;\n".
                               "    }";
             }
 

main/inc/lib/pear/HTML/QuickForm/select.php

Doc Comments +5 added lines, -8 removed lines

@@ -145,7 +145,7 @@ 
      *
      * @since     1.0
      * @access    public
-     * @return    array of selected values
+     * @return    string of selected values
      */
     function getSelected()
     {
@@ -208,7 +208,7 @@ 
     /**
      * Sets the value of the form element
      *
-     * @param     mixed    $values  Array or comma delimited string of selected values
+     * @param     mixed    $value  Array or comma delimited string of selected values
      * @since     1.0
      * @access    public
      * @return    void
@@ -226,7 +226,7 @@ 
      *
      * @since     1.0
      * @access    public
-     * @return    array of selected values
+     * @return    string of selected values
      */
     function getValue()
     {
@@ -257,7 +257,7 @@ 
      *
      * @since     1.0
      * @access    public
-     * @return    int
+     * @return    string|null
      */
     function getSize()
     {
@@ -357,12 +357,9 @@ 
         /**
      * Adds a new OPTION to the SELECT
      *
-     * @param     string    $text       Display text for the OPTION
-     * @param     string    $value      Value for the OPTION
-     * @param     mixed     $attributes Either a typical HTML attribute string
-     *                                  or an associative array
      * @since     1.0
      * @access    public
+     * @param string $label
      * @return    void
      */
     function addOptGroup($options, $label)

Indentation +18 added lines, -18 removed lines

@@ -355,16 +355,16 @@ 
 
 
         /**
-     * Adds a new OPTION to the SELECT
-     *
-     * @param     string    $text       Display text for the OPTION
-     * @param     string    $value      Value for the OPTION
-     * @param     mixed     $attributes Either a typical HTML attribute string
-     *                                  or an associative array
-     * @since     1.0
-     * @access    public
-     * @return    void
-     */
+         * Adds a new OPTION to the SELECT
+         *
+         * @param     string    $text       Display text for the OPTION
+         * @param     string    $value      Value for the OPTION
+         * @param     mixed     $attributes Either a typical HTML attribute string
+         *                                  or an associative array
+         * @since     1.0
+         * @access    public
+         * @return    void
+         */
     function addOptGroup($options, $label)
     {
         foreach ($options as $option) {
@@ -614,10 +614,10 @@ 
             }
             foreach ($value as $key => $item) {
                 $html .= '<input' . $this->_getAttrString(array(
-                             'type'  => 'hidden',
-                             'name'  => $name,
-                             'value' => $this->_values[$key]
-                         ) + $idAttr) . ' />';
+                                'type'  => 'hidden',
+                                'name'  => $name,
+                                'value' => $this->_values[$key]
+                            ) + $idAttr) . ' />';
             }
         }
         return $html;
@@ -626,10 +626,10 @@ 
     // }}}
     // {{{ exportValue()
 
-   /**
-    * We check the options and return only the values that _could_ have been
-    * selected. We also return a scalar value if select is not "multiple"
-    */
+    /**
+     * We check the options and return only the values that _could_ have been
+     * selected. We also return a scalar value if select is not "multiple"
+     */
     function exportValue(&$submitValues, $assoc = false)
     {
         $value = $this->_findValue($submitValues);

Spacing +24 added lines, -24 removed lines

@@ -86,7 +86,7 @@ 
             if (!empty($attributes['class'])) {
                 $oldClass = $attributes['class'];
             }
-            $attributes['class'] = $oldClass . ' selectpicker show-tick form-control';
+            $attributes['class'] = $oldClass.' selectpicker show-tick form-control';
             $attributes['data-live-search'] = 'true';
         }
         $columnsSize = isset($attributes['cols-size']) ? $attributes['cols-size'] : null;
@@ -196,7 +196,7 @@ 
     function getPrivateName()
     {
         if ($this->getAttribute('multiple')) {
-            return $this->getName() . '[]';
+            return $this->getName().'[]';
         } else {
             return $this->getName();
         }
@@ -312,7 +312,7 @@ 
      */
     function getMultiple()
     {
-        return (bool)$this->getAttribute('multiple');
+        return (bool) $this->getAttribute('multiple');
     } //end func getMultiple
 
     // }}}
@@ -332,7 +332,7 @@ 
     function addOption($text, $value, $attributes = null, $return_array = false)
     {
         if (null === $attributes) {
-            $attributes = array('value' => (string)$value);
+            $attributes = array('value' => (string) $value);
         } else {
             $attributes = $this->_parseAttributes($attributes);
             if (isset($attributes['selected'])) {
@@ -344,7 +344,7 @@ 
                     $this->_values[] = $value;
                 }
             }
-            $this->_updateAttrArray($attributes, array('value' => (string)$value));
+            $this->_updateAttrArray($attributes, array('value' => (string) $value));
         }
         if ($return_array) {
             return array('text' => $text, 'attr' => $attributes);
@@ -383,7 +383,7 @@ 
      * @return    PEAR_Error on error or true
      * @throws    PEAR_Error
      */
-    function loadArray($arr, $values=null)
+    function loadArray($arr, $values = null)
     {
         if (!is_array($arr)) {
             return PEAR::raiseError('Argument 1 of HTML_Select::loadArray is not a valid array');
@@ -420,7 +420,7 @@ 
      * @return    PEAR_Error on error or true
      * @throws    PEAR_Error
      */
-    function loadDbResult(&$result, $textCol=null, $valueCol=null, $values=null)
+    function loadDbResult(&$result, $textCol = null, $valueCol = null, $values = null)
     {
         if (!is_object($result) || !is_a($result, 'db_result')) {
             return PEAR::raiseError('Argument 1 of HTML_Select::loadDbResult is not a valid DB_result');
@@ -429,7 +429,7 @@ 
             $this->setValue($values);
         }
         $fetchMode = ($textCol && $valueCol) ? DB_FETCHMODE_ASSOC : DB_FETCHMODE_ORDERED;
-        while (is_array($row = $result->fetchRow($fetchMode)) ) {
+        while (is_array($row = $result->fetchRow($fetchMode))) {
             if ($fetchMode == DB_FETCHMODE_ASSOC) {
                 $this->addOption($row[$textCol], $row[$valueCol]);
             } else {
@@ -455,7 +455,7 @@ 
      * @return    void
      * @throws    PEAR_Error
      */
-    function loadQuery(&$conn, $sql, $textCol=null, $valueCol=null, $values=null)
+    function loadQuery(&$conn, $sql, $textCol = null, $valueCol = null, $values = null)
     {
         if (is_string($conn)) {
             require_once('DB.php');
@@ -502,7 +502,7 @@ 
      * @return    PEAR_Error on error or true
      * @throws    PEAR_Error
      */
-    function load(&$options, $param1=null, $param2=null, $param3=null, $param4=null)
+    function load(&$options, $param1 = null, $param2 = null, $param3 = null, $param4 = null)
     {
         switch (true) {
             case is_array($options):
@@ -539,32 +539,32 @@ 
             $strHtml = '';
 
             if ($this->getComment() != '') {
-                $strHtml .= $tabs . '<!-- ' . $this->getComment() . " //-->\n";
+                $strHtml .= $tabs.'<!-- '.$this->getComment()." //-->\n";
             }
 
             if (!$this->getMultiple()) {
                 $attrString = $this->_getAttrString($this->_attributes);
             } else {
                 $myName = $this->getName();
-                $this->setName($myName . '[]');
+                $this->setName($myName.'[]');
                 $attrString = $this->_getAttrString($this->_attributes);
                 $this->setName($myName);
             }
 
-            $strHtml .= $tabs . '<select ' . $attrString . ">\n";
+            $strHtml .= $tabs.'<select '.$attrString.">\n";
 
-            $strValues = is_array($this->_values)? array_map('strval', $this->_values): array();
+            $strValues = is_array($this->_values) ? array_map('strval', $this->_values) : array();
 
             foreach ($this->_options as $option) {
 
                 if (!empty($strValues) && in_array($option['attr']['value'], $strValues, true)) {
                     $option['attr']['selected'] = 'selected';
                 }
-                $strHtml .= $tabs . "<option" . $this->_getAttrString($option['attr']) . '>' .
-                    $option['text'] . "</option>";
+                $strHtml .= $tabs."<option".$this->_getAttrString($option['attr']).'>'.
+                    $option['text']."</option>";
             }
             foreach ($this->_optgroups as $optgroup) {
-                $strHtml .= $tabs . '<optgroup label="' . $optgroup['label'] . '">';
+                $strHtml .= $tabs.'<optgroup label="'.$optgroup['label'].'">';
                 foreach ($optgroup['options'] as $option) {
                     $text = $option['text'];
                     unset($option['text']);
@@ -573,11 +573,11 @@ 
                         $option['selected'] = 'selected';
                     }
 
-                    $strHtml .= $tabs . " <option" . $this->_getAttrString($option) . '>' .$text . "</option>";
+                    $strHtml .= $tabs." <option".$this->_getAttrString($option).'>'.$text."</option>";
                 }
                 $strHtml .= "</optgroup>";
             }
-            return $strHtml . $tabs . '</select>';
+            return $strHtml.$tabs.'</select>';
         }
     }
 
@@ -602,22 +602,22 @@ 
                 }
             }
         }
-        $html = empty($value)? '&nbsp;': join('<br />', $value);
+        $html = empty($value) ? '&nbsp;' : join('<br />', $value);
         if ($this->_persistantFreeze) {
             $name = $this->getPrivateName();
             // Only use id attribute if doing single hidden input
             if (1 == count($value)) {
                 $id     = $this->getAttribute('id');
-                $idAttr = isset($id)? array('id' => $id): array();
+                $idAttr = isset($id) ? array('id' => $id) : array();
             } else {
                 $idAttr = array();
             }
             foreach ($value as $key => $item) {
-                $html .= '<input' . $this->_getAttrString(array(
+                $html .= '<input'.$this->_getAttrString(array(
                              'type'  => 'hidden',
                              'name'  => $name,
                              'value' => $this->_values[$key]
-                         ) + $idAttr) . ' />';
+                         ) + $idAttr).' />';
             }
         }
         return $html;
@@ -635,7 +635,7 @@ 
         $value = $this->_findValue($submitValues);
         if (is_null($value)) {
             $value = $this->getValue();
-        } elseif(!is_array($value)) {
+        } elseif (!is_array($value)) {
             $value = array($value);
         }
         if (is_array($value) && !empty($this->_options)) {

main/inc/lib/pear/HTML/QuickForm/textarea.php

Doc Comments +2 added lines

@@ -54,6 +54,8 @@
      * @param     string    Input field name attribute
      * @param     mixed     Label(s) for a field
      * @param     mixed     Either a typical HTML attribute string or an associative array
+     * @param string $elementName
+     * @param string $elementLabel
      * @since     1.0
      * @access    public
      * @return    void

Indentation +7 added lines, -7 removed lines

@@ -194,13 +194,13 @@
             return $this->getFrozenHtml();
         } else {
             return $this->_getTabs() .
-                   '<textarea' . $this->_getAttrString($this->_attributes) . '>' .
-                   // because we wrap the form later we don't want the text indented
-                   // Modified by Ivan Tcholakov, 16-MAR-2010.
-                   //preg_replace("/(\r\n|\n|\r)/", '&#010;', htmlspecialchars($this->_value)) .
-                   preg_replace("/(\r\n|\n|\r)/", '&#010;', @htmlspecialchars($this->_value, ENT_COMPAT, HTML_Common::charset())) .
-                   //
-                   '</textarea>';
+                    '<textarea' . $this->_getAttrString($this->_attributes) . '>' .
+                    // because we wrap the form later we don't want the text indented
+                    // Modified by Ivan Tcholakov, 16-MAR-2010.
+                    //preg_replace("/(\r\n|\n|\r)/", '&#010;', htmlspecialchars($this->_value)) .
+                    preg_replace("/(\r\n|\n|\r)/", '&#010;', @htmlspecialchars($this->_value, ENT_COMPAT, HTML_Common::charset())) .
+                    //
+                    '</textarea>';
         }
     }
 

Spacing +6 added lines, -6 removed lines

@@ -58,7 +58,7 @@ 
      * @access    public
      * @return    void
      */
-    public function __construct($elementName=null, $elementLabel=null, $attributes=null)
+    public function __construct($elementName = null, $elementLabel = null, $attributes = null)
     {
         $attributes['class'] = isset($attributes['class']) ? $attributes['class'] : 'form-control';
         $columnsSize = isset($attributes['cols-size']) ? $attributes['cols-size'] : null;
@@ -193,12 +193,12 @@ 
         if ($this->_flagFrozen) {
             return $this->getFrozenHtml();
         } else {
-            return $this->_getTabs() .
-                   '<textarea' . $this->_getAttrString($this->_attributes) . '>' .
+            return $this->_getTabs().
+                   '<textarea'.$this->_getAttrString($this->_attributes).'>'.
                    // because we wrap the form later we don't want the text indented
                    // Modified by Ivan Tcholakov, 16-MAR-2010.
                    //preg_replace("/(\r\n|\n|\r)/", '&#010;', htmlspecialchars($this->_value)) .
-                   preg_replace("/(\r\n|\n|\r)/", '&#010;', @htmlspecialchars($this->_value, ENT_COMPAT, HTML_Common::charset())) .
+                   preg_replace("/(\r\n|\n|\r)/", '&#010;', @htmlspecialchars($this->_value, ENT_COMPAT, HTML_Common::charset())).
                    //
                    '</textarea>';
         }
@@ -218,11 +218,11 @@ 
         $value = @htmlspecialchars($this->getValue(), ENT_COMPAT, HTML_Common::charset());
         //
         if ($this->getAttribute('wrap') == 'off') {
-            $html = $this->_getTabs() . '<pre>' . $value."</pre>\n";
+            $html = $this->_getTabs().'<pre>'.$value."</pre>\n";
         } else {
             $html = nl2br($value)."\n";
         }
-        return $html . $this->_getPersistantData();
+        return $html.$this->_getPersistantData();
     }
     
     /**

main/inc/lib/pear/HTML/Table.php

Doc Comments +2 added lines, -2 removed lines

@@ -665,7 +665,7 @@ 
      * Adds a table row and returns the row identifier
      * @param    array     $contents     (optional) Must be a indexed array of
      *                                   valid cell contents
-     * @param    mixed     $attributes   (optional) Associative array or string
+     * @param    string     $attributes   (optional) Associative array or string
      *                                   of table row attributes. This can also
      *                                   be an array of attributes, in which
      *                                   case the attributes will be repeated
@@ -719,7 +719,7 @@ 
     /**
      * Updates the row attributes for an existing row
      * @param    int      $row          Row index
-     * @param    mixed    $attributes   Associative array or string of table row
+     * @param    string    $attributes   Associative array or string of table row
      *                                  attributes
      * @param    bool     $inTR         false if attributes are to be applied in
      *                                  TD tags; true if attributes are to be

Indentation +2 added lines, -3 removed lines

@@ -48,7 +48,6 @@ 
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
  *
  * @category   HTML
  * @package    HTML_Table
@@ -256,7 +255,7 @@ 
 
         $body = $this->_tbodyCount++;
         $this->_tbodies[$body] = new HTML_Table_Storage($this->_tabOffset,
-                                                         $this->_useTGroups);
+                                                            $this->_useTGroups);
         $this->_tbodies[$body]->setAutoFill($this->_autoFill);
         $this->_tbodies[$body]->setAttributes($attributes);
         return $body;
@@ -308,7 +307,7 @@ 
         if (isset($colgroup)) {
             $attributes = $this->_parseAttributes($attributes);
             $this->_colgroup[] = array('attr' => $attributes,
-                                       'contents' => $colgroup);
+                                        'contents' => $colgroup);
         } else {
             $this->_colgroup = array();
         }

Spacing +26 added lines, -26 removed lines

@@ -165,8 +165,8 @@ 
      */
     public function __construct($attributes = null, $tabOffset = 0, $useTGroups = false)
     {
-        parent::__construct($attributes, (int)$tabOffset);
-        $this->_useTGroups = (boolean)$useTGroups;
+        parent::__construct($attributes, (int) $tabOffset);
+        $this->_useTGroups = (boolean) $useTGroups;
         $this->addBody();
         if ($this->_useTGroups) {
             $this->_thead = new HTML_Table_Storage($tabOffset, $this->_useTGroups);
@@ -273,12 +273,12 @@ 
     function _adjustTbodyCount($body, $method)
     {
         if ($this->_autoGrow) {
-            while ($this->_tbodyCount <= (int)$body) {
+            while ($this->_tbodyCount <= (int) $body) {
                 $this->addBody();
             }
         } else {
-            return PEAR::raiseError('Invalid body reference[' .
-                $body . '] in HTML_Table::' . $method);
+            return PEAR::raiseError('Invalid body reference['.
+                $body.'] in HTML_Table::'.$method);
         }
     }
 
@@ -940,26 +940,26 @@ 
             $tBodyMaxColCount = max($tBodyColCounts);
         }
         if ($this->_comment) {
-            $strHtml .= $tabs . "<!-- $this->_comment -->" . $lnEnd;
+            $strHtml .= $tabs."<!-- $this->_comment -->".$lnEnd;
         }
         if ($this->getRowCount() > 0 && $tBodyMaxColCount > 0) {
             $strHtml .=
-                $tabs . '<table' . $this->_getAttrString($this->_attributes) . '>' . $lnEnd;
+                $tabs.'<table'.$this->_getAttrString($this->_attributes).'>'.$lnEnd;
             if (!empty($this->_caption)) {
                 $attr = $this->_caption['attr'];
                 $contents = $this->_caption['contents'];
-                $strHtml .= $tabs . $tab . '<caption' . $this->_getAttrString($attr) . '>';
+                $strHtml .= $tabs.$tab.'<caption'.$this->_getAttrString($attr).'>';
                 if (is_array($contents)) {
                     $contents = implode(', ', $contents);
                 }
                 $strHtml .= $contents;
-                $strHtml .= '</caption>' . $lnEnd;
+                $strHtml .= '</caption>'.$lnEnd;
             }
             if (!empty($this->_colgroup)) {
                 foreach ($this->_colgroup as $g => $col) {
                     $attr = $this->_colgroup[$g]['attr'];
                     $contents = $this->_colgroup[$g]['contents'];
-                    $strHtml .= $tabs . $tab . '<colgroup' . $this->_getAttrString($attr) . '>';
+                    $strHtml .= $tabs.$tab.'<colgroup'.$this->_getAttrString($attr).'>';
                     if (!empty($contents)) {
                         $strHtml .= $lnEnd;
                         if (!is_array($contents)) {
@@ -967,11 +967,11 @@ 
                         }
                         foreach ($contents as $a => $colAttr) {
                             $attr = $this->_parseAttributes($colAttr);
-                            $strHtml .= $tabs . $tab . $tab . '<col' . $this->_getAttrString($attr) . ' />' . $lnEnd;
+                            $strHtml .= $tabs.$tab.$tab.'<col'.$this->_getAttrString($attr).' />'.$lnEnd;
                         }
-                        $strHtml .= $tabs . $tab;
+                        $strHtml .= $tabs.$tab;
                     }
-                    $strHtml .= '</colgroup>' . $lnEnd;
+                    $strHtml .= '</colgroup>'.$lnEnd;
                 }
             }
             if ($this->_useTGroups) {
@@ -987,31 +987,31 @@ 
                 if ($this->_thead !== null) {
                     $this->_thead->setColCount($maxColCount);
                     if ($this->_thead->getRowCount() > 0) {
-                        $strHtml .= $tabs . $tab . '<thead' .
-                                    $this->_getAttrString($this->_thead->_attributes) .
-                                    '>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'<thead'.
+                                    $this->_getAttrString($this->_thead->_attributes).
+                                    '>'.$lnEnd;
                         $strHtml .= $this->_thead->toHtml($tabs, $tab);
-                        $strHtml .= $tabs . $tab . '</thead>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'</thead>'.$lnEnd;
                     }
                 }
                 if ($this->_tfoot !== null) {
                     $this->_tfoot->setColCount($maxColCount);
                     if ($this->_tfoot->getRowCount() > 0) {
-                        $strHtml .= $tabs . $tab . '<tfoot' .
-                                    $this->_getAttrString($this->_tfoot->_attributes) .
-                                    '>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'<tfoot'.
+                                    $this->_getAttrString($this->_tfoot->_attributes).
+                                    '>'.$lnEnd;
                         $strHtml .= $this->_tfoot->toHtml($tabs, $tab);
-                        $strHtml .= $tabs . $tab . '</tfoot>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'</tfoot>'.$lnEnd;
                     }
                 }
                 for ($i = 0; $i < $this->_tbodyCount; $i++) {
                     $this->_tbodies[$i]->setColCount($maxColCount);
                     if ($this->_tbodies[$i]->getRowCount() > 0) {
-                        $strHtml .= $tabs . $tab . '<tbody' .
-                                    $this->_getAttrString($this->_tbodies[$i]->_attributes) .
-                                    '>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'<tbody'.
+                                    $this->_getAttrString($this->_tbodies[$i]->_attributes).
+                                    '>'.$lnEnd;
                         $strHtml .= $this->_tbodies[$i]->toHtml($tabs, $tab);
-                        $strHtml .= $tabs . $tab . '</tbody>' . $lnEnd;
+                        $strHtml .= $tabs.$tab.'</tbody>'.$lnEnd;
                     }
                 }
             } else {
@@ -1020,7 +1020,7 @@ 
                     $strHtml .= $this->_tbodies[$i]->toHtml($tabs, $tab);
                 }
             }
-            $strHtml .= $tabs . '</table>' . $lnEnd;
+            $strHtml .= $tabs.'</table>'.$lnEnd;
         }
         return $strHtml;
     }

main/inc/lib/pear/Image/Text.php

Doc Comments +4 added lines, -4 removed lines

@@ -328,8 +328,8 @@ 
      * the Image_Text object after changing options. For possible options, please
      * take a look at the class options array!
      *
-     * @param array|string $option A single option name or the options array.
-     * @param mixed        $value  Option value if $option is string.
+     * @param string $option A single option name or the options array.
+     * @param string        $value  Option value if $option is string.
      *
      * @return void
      * @see    Image_Text::Image_Text()
@@ -982,7 +982,7 @@ 
      * @param bool $save Save or not the image on printout.
      * @param bool $free Free the image on exit.
      *
-     * @return  bool         True on success
+     * @return  boolean|null         True on success
      * @see Image_Text::save()
      * @throws Image_Text_Exception
      */
@@ -1133,7 +1133,7 @@ 
      * @param string $scolor string of colorcode.
      *
      * @see Image_Text::IMAGE_TEXT_REGEX_HTMLCOLOR
-     * @return bool|array false if string can't be converted to array
+     * @return resource false if string can't be converted to array
      */
     public static function convertString2RGB($scolor)
     {

Switch Indentation +94 added lines, -94 removed lines

@@ -346,19 +346,19 @@ 
         }
         foreach ($option as $opt => $val) {
             switch ($opt) {
-            case 'color':
-                $this->setColors($val);
-                break;
-            case 'text':
-                if (is_array($val)) {
-                    $this->_text = implode('\n', $val);
-                } else {
-                    $this->_text = $val;
-                }
-                break;
-            default:
-                $this->_options[$opt] = $val;
-                break;
+                case 'color':
+                    $this->setColors($val);
+                    break;
+                case 'text':
+                    if (is_array($val)) {
+                        $this->_text = implode('\n', $val);
+                    } else {
+                        $this->_text = $val;
+                    }
+                    break;
+                default:
+                    $this->_options[$opt] = $val;
+                    break;
             }
             if (isset($reInits[$opt])) {
                 $this->_init = false;
@@ -511,45 +511,45 @@ 
         $image_canvas = false;
         switch (true) {
 
-        case (empty($this->_options['canvas'])):
-            // Create new image from width && height of the clipping
-            $this->_img = imagecreatetruecolor(
-                $this->_options['width'], $this->_options['height']
-            );
-            if (!$this->_img) {
-                throw new Image_Text_Exception('Could not create image canvas.');
-            }
-            break;
+            case (empty($this->_options['canvas'])):
+                // Create new image from width && height of the clipping
+                $this->_img = imagecreatetruecolor(
+                    $this->_options['width'], $this->_options['height']
+                );
+                if (!$this->_img) {
+                    throw new Image_Text_Exception('Could not create image canvas.');
+                }
+                break;
 
-        case (is_resource($this->_options['canvas']) &&
-            get_resource_type($this->_options['canvas']) == 'gd'):
-            // The canvas is an image resource
-            $image_canvas = true;
-            $this->_img = $this->_options['canvas'];
-            break;
+            case (is_resource($this->_options['canvas']) &&
+                get_resource_type($this->_options['canvas']) == 'gd'):
+                // The canvas is an image resource
+                $image_canvas = true;
+                $this->_img = $this->_options['canvas'];
+                break;
 
-        case (is_array($this->_options['canvas']) &&
-            isset($this->_options['canvas']['width']) &&
-            isset($this->_options['canvas']['height'])):
+            case (is_array($this->_options['canvas']) &&
+                isset($this->_options['canvas']['width']) &&
+                isset($this->_options['canvas']['height'])):
 
-            // Canvas must be a width and height measure
-            $this->_img = imagecreatetruecolor(
-                $this->_options['canvas']['width'],
-                $this->_options['canvas']['height']
-            );
-            break;
+                // Canvas must be a width and height measure
+                $this->_img = imagecreatetruecolor(
+                    $this->_options['canvas']['width'],
+                    $this->_options['canvas']['height']
+                );
+                break;
 
-        case (is_array($this->_options['canvas']) &&
-            isset($this->_options['canvas']['size']) &&
-            ($this->_options['canvas']['size'] = 'auto')):
+            case (is_array($this->_options['canvas']) &&
+                isset($this->_options['canvas']['size']) &&
+                ($this->_options['canvas']['size'] = 'auto')):
 
-        case (is_string($this->_options['canvas']) &&
-            ($this->_options['canvas'] = 'auto')):
-            $this->_mode = 'auto';
-            break;
+            case (is_string($this->_options['canvas']) &&
+                ($this->_options['canvas'] = 'auto')):
+                $this->_mode = 'auto';
+                break;
 
-        default:
-            throw new Image_Text_Exception('Could not create image canvas.');
+            default:
+                throw new Image_Text_Exception('Could not create image canvas.');
         }
 
         if ($this->_img) {
@@ -889,19 +889,19 @@ 
         $cosR = cos($radians);
 
         switch ($this->_options['valign']) {
-        case self::IMAGE_TEXT_ALIGN_TOP:
-            $valign_space = 0;
-            break;
-        case self::IMAGE_TEXT_ALIGN_MIDDLE:
-            $valign_space = ($this->_options['height']
-                    - $this->_realTextSize['height']) / 2;
-            break;
-        case self::IMAGE_TEXT_ALIGN_BOTTOM:
-            $valign_space = $this->_options['height']
-                - $this->_realTextSize['height'];
-            break;
-        default:
-            $valign_space = 0;
+            case self::IMAGE_TEXT_ALIGN_TOP:
+                $valign_space = 0;
+                break;
+            case self::IMAGE_TEXT_ALIGN_MIDDLE:
+                $valign_space = ($this->_options['height']
+                        - $this->_realTextSize['height']) / 2;
+                break;
+            case self::IMAGE_TEXT_ALIGN_BOTTOM:
+                $valign_space = $this->_options['height']
+                    - $this->_realTextSize['height'];
+                break;
+            default:
+                $valign_space = 0;
         }
 
         $space = (1 + $line_spacing) * $size;
@@ -932,18 +932,18 @@ 
             // Calc the position using the block width, the current line width and
             // obviously the angle. That gives us the offset to slide the line.
             switch ($align) {
-            case self::IMAGE_TEXT_ALIGN_LEFT:
-                $hyp = 0;
-                break;
-            case self::IMAGE_TEXT_ALIGN_RIGHT:
-                $hyp = $block_width - $line_width - $left_margin;
-                break;
-            case self::IMAGE_TEXT_ALIGN_CENTER:
-                $hyp = ($block_width - $line_width) / 2 - $left_margin;
-                break;
-            default:
-                $hyp = 0;
-                break;
+                case self::IMAGE_TEXT_ALIGN_LEFT:
+                    $hyp = 0;
+                    break;
+                case self::IMAGE_TEXT_ALIGN_RIGHT:
+                    $hyp = $block_width - $line_width - $left_margin;
+                    break;
+                case self::IMAGE_TEXT_ALIGN_CENTER:
+                    $hyp = ($block_width - $line_width) / 2 - $left_margin;
+                    break;
+                default:
+                    $hyp = 0;
+                    break;
             }
 
             $posx = $new_posx + $cosR * $hyp;
@@ -997,17 +997,17 @@ 
             throw new Image_Text_Exception('Header already sent.');
         }
         switch ($this->_options['image_type']) {
-        case IMAGETYPE_PNG:
-            $imgout = 'imagepng';
-            break;
-        case IMAGETYPE_JPEG:
-            $imgout = 'imagejpeg';
-            break;
-        case IMAGETYPE_BMP:
-            $imgout = 'imagebmp';
-            break;
-        default:
-            throw new Image_Text_Exception('Unsupported image type.');
+            case IMAGETYPE_PNG:
+                $imgout = 'imagepng';
+                break;
+            case IMAGETYPE_JPEG:
+                $imgout = 'imagejpeg';
+                break;
+            case IMAGETYPE_BMP:
+                $imgout = 'imagebmp';
+                break;
+            default:
+                throw new Image_Text_Exception('Unsupported image type.');
         }
         if ($save) {
             $imgout($this->_img);
@@ -1048,18 +1048,18 @@ 
         }
 
         switch ($this->_options['image_type']) {
-        case IMAGETYPE_PNG:
-            $imgout = 'imagepng';
-            break;
-        case IMAGETYPE_JPEG:
-            $imgout = 'imagejpeg';
-            break;
-        case IMAGETYPE_BMP:
-            $imgout = 'imagebmp';
-            break;
-        default:
-            throw new Image_Text_Exception('Unsupported image type.');
-            break;
+            case IMAGETYPE_PNG:
+                $imgout = 'imagepng';
+                break;
+            case IMAGETYPE_JPEG:
+                $imgout = 'imagejpeg';
+                break;
+            case IMAGETYPE_BMP:
+                $imgout = 'imagebmp';
+                break;
+            default:
+                throw new Image_Text_Exception('Unsupported image type.');
+                break;
         }
 
         $res = $imgout($this->_img, $destFile);

Spacing +6 added lines, -6 removed lines

@@ -683,7 +683,7 @@ 
         $space = (1 + $this->_options['line_spacing'])
             * $this->_options['font_size'];
 
-        $max_lines = (int)$this->_options['max_lines'];
+        $max_lines = (int) $this->_options['max_lines'];
 
         if (($max_lines < 1) && !$force) {
             return false;
@@ -732,7 +732,7 @@ 
                     'color' => $c
                 );
                 $text_width = max($text_width, ($bounds[2] - $bounds[0]));
-                $text_height += (int)$space;
+                $text_height += (int) $space;
                 if (($text_height > $block_height) && !$force) {
                     return false;
                 }
@@ -749,7 +749,7 @@ 
                 $text_line_next = $token;
                 $beginning_of_line = false;
             } else {
-                $text_line_next = $text_line . ' ' . $token;
+                $text_line_next = $text_line.' '.$token;
             }
             $bounds = imagettfbbox($size, 0, $font, $text_line_next);
             $prev_width = isset($prev_width) ? $width : 0;
@@ -776,7 +776,7 @@ 
                     'color' => $c
                 );
                 $text_width = max($text_width, ($bounds[2] - $bounds[0]));
-                $text_height += (int)$space;
+                $text_height += (int) $space;
                 if (($text_height > $block_height) && !$force) {
                     return false;
                 }
@@ -990,7 +990,7 @@ 
     {
         if (!headers_sent()) {
             header(
-                "Content-type: " .
+                "Content-type: ".
                 image_type_to_mime_type($this->_options['image_type'])
             );
         } else {
@@ -1121,7 +1121,7 @@ 
                 $y += $vC[1];
             }
         }
-        return array('x' => (int)round($x, 0), 'y' => (int)round($y, 0));
+        return array('x' => (int) round($x, 0), 'y' => (int) round($y, 0));
     }
 
     /**

main/inc/lib/pear/OLE/OLE.php

Doc Comments +1 added lines, -1 removed lines

@@ -286,7 +286,7 @@
     *
     * @access private
     * @param integer $blockId the block id of the first block
-    * @return mixed true on success, PEAR_Error on failure
+    * @return boolean true on success, PEAR_Error on failure
     */
     function _readPpsWks($blockId)
     {

Indentation +104 added lines, -104 removed lines

@@ -49,74 +49,74 @@ 
 {
 
     /**
-    * The file handle for reading an OLE container
-    * @var resource
-    */
+     * The file handle for reading an OLE container
+     * @var resource
+     */
     var $_file_handle;
 
     /**
-    * Array of PPS's found on the OLE container
-    * @var array
-    */
+     * Array of PPS's found on the OLE container
+     * @var array
+     */
     var $_list;
 
     /**
-    * Root directory of OLE container
-    * @var OLE_PPS_Root
-    */
+     * Root directory of OLE container
+     * @var OLE_PPS_Root
+     */
     var $root;
 
     /**
-    * Big Block Allocation Table
-    * @var array  (blockId => nextBlockId)
-    */
+     * Big Block Allocation Table
+     * @var array  (blockId => nextBlockId)
+     */
     var $bbat;
 
     /**
-    * Short Block Allocation Table
-    * @var array  (blockId => nextBlockId)
-    */
+     * Short Block Allocation Table
+     * @var array  (blockId => nextBlockId)
+     */
     var $sbat;
 
     /**
-    * Size of big blocks. This is usually 512.
-    * @var  int  number of octets per block.
-    */
+     * Size of big blocks. This is usually 512.
+     * @var  int  number of octets per block.
+     */
     var $bigBlockSize;
 
     /**
-    * Size of small blocks. This is usually 64.
-    * @var  int  number of octets per block
-    */
+     * Size of small blocks. This is usually 64.
+     * @var  int  number of octets per block
+     */
     var $smallBlockSize;
 
     /**
-    * Creates a new OLE object
-    * @access public
-    */
+     * Creates a new OLE object
+     * @access public
+     */
     function OLE()
     {
         $this->_list = array();
     }
 
     /**
-    * Destructor (using PEAR)
-    * Just closes the file handle on the OLE file.
-    *
-    * @access private
-    */
+     * Destructor (using PEAR)
+     * Just closes the file handle on the OLE file.
+     *
+     * @access private
+     */
     function _OLE()
     {
         fclose($this->_file_handle);
     }
 
     /**
-    * Reads an OLE container from the contents of the file given.
-    *
-    * @access public
-    * @param string $file
-    * @return mixed true on success, PEAR_Error on failure
-    */
+     * Reads an OLE container from the contents of the file given.
+     *
+     * @access public
+     * @param string $file
+     * @return mixed true on success, PEAR_Error on failure
+     */
     function read($file)
     {
         $fh = @fopen($file, "r");
@@ -281,13 +281,13 @@ 
     }
 
     /**
-    * Gets information about all PPS's on the OLE container from the PPS WK's
-    * creates an OLE_PPS object for each one.
-    *
-    * @access private
-    * @param integer $blockId the block id of the first block
-    * @return mixed true on success, PEAR_Error on failure
-    */
+     * Gets information about all PPS's on the OLE container from the PPS WK's
+     * creates an OLE_PPS object for each one.
+     *
+     * @access private
+     * @param integer $blockId the block id of the first block
+     * @return mixed true on success, PEAR_Error on failure
+     */
     function _readPpsWks($blockId)
     {
         $fh = $this->getStream($blockId);
@@ -307,7 +307,7 @@ 
                 break;
             case OLE_PPS_TYPE_DIR:
                 $pps = new OLE_PPS(null, null, null, null, null,
-                                   null, null, null, null, array());
+                                    null, null, null, null, array());
                 break;
             case OLE_PPS_TYPE_FILE:
                 require_once 'OLE/PPS/File.php';
@@ -360,13 +360,13 @@ 
     }
 
     /**
-    * It checks whether the PPS tree is complete (all PPS's read)
-    * starting with the given PPS (not necessarily root)
-    *
-    * @access private
-    * @param integer $index The index of the PPS from which we are checking
-    * @return boolean Whether the PPS tree for the given PPS is complete
-    */
+     * It checks whether the PPS tree is complete (all PPS's read)
+     * starting with the given PPS (not necessarily root)
+     *
+     * @access private
+     * @param integer $index The index of the PPS from which we are checking
+     * @return boolean Whether the PPS tree for the given PPS is complete
+     */
     function _ppsTreeComplete($index)
     {
         return isset($this->_list[$index]) &&
@@ -380,12 +380,12 @@ 
     }
 
     /**
-    * Checks whether a PPS is a File PPS or not.
-    * If there is no PPS for the index given, it will return false.
-    * @param integer $index The index for the PPS
-    * @return bool true if it's a File PPS, false otherwise
-    * @access public
-    */
+     * Checks whether a PPS is a File PPS or not.
+     * If there is no PPS for the index given, it will return false.
+     * @param integer $index The index for the PPS
+     * @return bool true if it's a File PPS, false otherwise
+     * @access public
+     */
     function isFile($index)
     {
         if (isset($this->_list[$index])) {
@@ -395,12 +395,12 @@ 
     }
 
     /**
-    * Checks whether a PPS is a Root PPS or not.
-    * If there is no PPS for the index given, it will return false.
-    * @param integer $index The index for the PPS.
-    * @return bool true if it's a Root PPS, false otherwise
-    * @access public
-    */
+     * Checks whether a PPS is a Root PPS or not.
+     * If there is no PPS for the index given, it will return false.
+     * @param integer $index The index for the PPS.
+     * @return bool true if it's a Root PPS, false otherwise
+     * @access public
+     */
     function isRoot($index)
     {
         if (isset($this->_list[$index])) {
@@ -410,26 +410,26 @@ 
     }
 
     /**
-    * Gives the total number of PPS's found in the OLE container.
-    * @return integer The total number of PPS's found in the OLE container
-    * @access public
-    */
+     * Gives the total number of PPS's found in the OLE container.
+     * @return integer The total number of PPS's found in the OLE container
+     * @access public
+     */
     function ppsTotal()
     {
         return count($this->_list);
     }
 
     /**
-    * Gets data from a PPS
-    * If there is no PPS for the index given, it will return an empty string.
-    * @param integer $index    The index for the PPS
-    * @param integer $position The position from which to start reading
-    *                          (relative to the PPS)
-    * @param integer $length   The amount of bytes to read (at most)
-    * @return string The binary string containing the data requested
-    * @access public
-    * @see OLE_PPS_File::getStream()
-    */
+     * Gets data from a PPS
+     * If there is no PPS for the index given, it will return an empty string.
+     * @param integer $index    The index for the PPS
+     * @param integer $position The position from which to start reading
+     *                          (relative to the PPS)
+     * @param integer $length   The amount of bytes to read (at most)
+     * @return string The binary string containing the data requested
+     * @access public
+     * @see OLE_PPS_File::getStream()
+     */
     function getData($index, $position, $length)
     {
         // if position is not valid return empty string
@@ -446,12 +446,12 @@ 
     }
 
     /**
-    * Gets the data length from a PPS
-    * If there is no PPS for the index given, it will return 0.
-    * @param integer $index The index for the PPS
-    * @return integer The amount of bytes in data the PPS has
-    * @access public
-    */
+     * Gets the data length from a PPS
+     * If there is no PPS for the index given, it will return 0.
+     * @param integer $index The index for the PPS
+     * @return integer The amount of bytes in data the PPS has
+     * @access public
+     */
     function getDataLength($index)
     {
         if (isset($this->_list[$index])) {
@@ -461,13 +461,13 @@ 
     }
 
     /**
-    * Utility function to transform ASCII text to Unicode
-    *
-    * @access public
-    * @static
-    * @param string $ascii The ASCII string to transform
-    * @return string The string in Unicode
-    */
+     * Utility function to transform ASCII text to Unicode
+     *
+     * @access public
+     * @static
+     * @param string $ascii The ASCII string to transform
+     * @return string The string in Unicode
+     */
     function Asc2Ucs($ascii)
     {
         $rawname = '';
@@ -478,14 +478,14 @@ 
     }
 
     /**
-    * Utility function
-    * Returns a string for the OLE container with the date given
-    *
-    * @access public
-    * @static
-    * @param integer $date A timestamp
-    * @return string The string for the OLE container
-    */
+     * Utility function
+     * Returns a string for the OLE container with the date given
+     *
+     * @access public
+     * @static
+     * @param integer $date A timestamp
+     * @return string The string for the OLE container
+     */
     function LocalDate2OLE($date = null)
     {
         if (!isset($date)) {
@@ -500,7 +500,7 @@ 
         // calculate seconds
         $big_date = $days * 24 * 3600 +
             gmmktime(date("H",$date),date("i",$date),date("s",$date),
-                     date("m",$date),date("d",$date),date("Y",$date));
+                        date("m",$date),date("d",$date),date("Y",$date));
         // multiply just to make MS happy
         $big_date *= 10000000;
 
@@ -525,12 +525,12 @@ 
     }
 
     /**
-    * Returns a timestamp from an OLE container's date
-    * @param integer $string A binary string with the encoded date
-    * @return string The timestamp corresponding to the string
-    * @access public
-    * @static
-    */
+     * Returns a timestamp from an OLE container's date
+     * @param integer $string A binary string with the encoded date
+     * @return string The timestamp corresponding to the string
+     * @access public
+     * @static
+     */
     function OLE2LocalDate($string)
     {
         if (strlen($string) != 8) {

Switch Indentation +15 added lines, -15 removed lines

@@ -300,21 +300,21 @@
             $name = str_replace("\x00", "", $nameUtf16);
             $type = $this->_readInt1($fh);
             switch ($type) {
-            case OLE_PPS_TYPE_ROOT:
-                require_once 'OLE/PPS/Root.php';
-                $pps = new OLE_PPS_Root(null, null, array());
-                $this->root = $pps;
-                break;
-            case OLE_PPS_TYPE_DIR:
-                $pps = new OLE_PPS(null, null, null, null, null,
-                                   null, null, null, null, array());
-                break;
-            case OLE_PPS_TYPE_FILE:
-                require_once 'OLE/PPS/File.php';
-                $pps = new OLE_PPS_File($name);
-                break;
-            default:
-                continue;
+                case OLE_PPS_TYPE_ROOT:
+                    require_once 'OLE/PPS/Root.php';
+                    $pps = new OLE_PPS_Root(null, null, array());
+                    $this->root = $pps;
+                    break;
+                case OLE_PPS_TYPE_DIR:
+                    $pps = new OLE_PPS(null, null, null, null, null,
+                                       null, null, null, null, array());
+                    break;
+                case OLE_PPS_TYPE_FILE:
+                    require_once 'OLE/PPS/File.php';
+                    $pps = new OLE_PPS_File($name);
+                    break;
+                default:
+                    continue;
             }
             fseek($fh, 1, SEEK_CUR);
             $pps->Type    = $type;

Spacing +14 added lines, -14 removed lines

@@ -23,12 +23,12 @@ 
 /**
 * Constants for OLE package
 */
-define('OLE_PPS_TYPE_ROOT',        5);
-define('OLE_PPS_TYPE_DIR',         1);
-define('OLE_PPS_TYPE_FILE',        2);
+define('OLE_PPS_TYPE_ROOT', 5);
+define('OLE_PPS_TYPE_DIR', 1);
+define('OLE_PPS_TYPE_FILE', 2);
 define('OLE_DATA_SIZE_SMALL', 0x1000);
-define('OLE_LONG_INT_SIZE',        4);
-define('OLE_PPS_SIZE',          0x80);
+define('OLE_LONG_INT_SIZE', 4);
+define('OLE_PPS_SIZE', 0x80);
 
 /**
 * Array for storing OLE instances that are accessed from
@@ -183,7 +183,7 @@ 
         for ($i = 0; $i < $bbatBlockCount; $i++) {
             $pos = $this->_getBlockOffset($mbatBlocks[$i]);
             fseek($fh, $pos);
-            for ($j = 0 ; $j < $this->bigBlockSize / 4; $j++) {
+            for ($j = 0; $j < $this->bigBlockSize / 4; $j++) {
                 $this->bbat[] = $this->_readInt4($fh);
             }
         }
@@ -234,12 +234,12 @@ 
         $GLOBALS['_OLE_INSTANCES'][] = $this;
         $instanceId = end(array_keys($GLOBALS['_OLE_INSTANCES']));
 
-        $path = 'ole-chainedblockstream://oleInstanceId=' . $instanceId;
+        $path = 'ole-chainedblockstream://oleInstanceId='.$instanceId;
         if (is_a($blockIdOrPps, 'OLE_PPS')) {
-            $path .= '&blockId=' . $blockIdOrPps->_StartBlock;
-            $path .= '&size=' . $blockIdOrPps->Size;
+            $path .= '&blockId='.$blockIdOrPps->_StartBlock;
+            $path .= '&size='.$blockIdOrPps->Size;
         } else {
-            $path .= '&blockId=' . $blockIdOrPps;
+            $path .= '&blockId='.$blockIdOrPps;
         }
         return fopen($path, 'r');
     }
@@ -472,7 +472,7 @@ 
     {
         $rawname = '';
         for ($i = 0; $i < strlen($ascii); $i++) {
-            $rawname .= $ascii{$i} . "\x00";
+            $rawname .= $ascii{$i}."\x00";
         }
         return $rawname;
     }
@@ -499,8 +499,8 @@ 
         $days = 134774;
         // calculate seconds
         $big_date = $days * 24 * 3600 +
-            gmmktime(date("H",$date),date("i",$date),date("s",$date),
-                     date("m",$date),date("d",$date),date("Y",$date));
+            gmmktime(date("H", $date), date("i", $date), date("s", $date),
+                     date("m", $date), date("d", $date), date("Y", $date));
         // multiply just to make MS happy
         $big_date *= 10000000;
 
@@ -538,7 +538,7 @@ 
         }
 
         // factor used for separating numbers into 4 bytes parts
-        $factor = pow(2,32);
+        $factor = pow(2, 32);
         $high_part = 0;
         for ($i = 0; $i < 4; $i++) {
             list(, $high_part) = unpack('C', $string{(7 - $i)});