survey_question::preSave() - Code Metrics - Inspection of "Remove double declaration" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 9b8b24...6e1754 )

by Julito
created 2018-01-05 12:35 UTC
survey_question::preSave() F

↳ Parent: survey_question
Complexity

Conditions	28
Paths	2304
Size

Total Lines	99
Code Lines	56
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	28
eloc	56
nc	2304
nop	1
dl	0
loc	99
rs	2
c	0
b	0
f	0
How to fix Long Method Complexity

<?php
/* For licensing terms, see /license.txt */

use ChamiloSession as Session;

/**
 * Class survey_question
 */
class survey_question
{
    /** @var FormValidator */
    private $form;
    public $buttonList = array();

    /**
     * Generic part of any survey question: the question field
     * @param array $surveyData
     * @param array $formData
     *
     * @return FormValidator
     */
    public function createForm($surveyData, $formData)
    {
        $action = isset($_GET['action']) ? Security::remove_XSS($_GET['action']) : null;
        $questionId = isset($_GET['question_id']) ? intval($_GET['question_id']) : null;
        $surveyId = isset($_GET['survey_id']) ? intval($_GET['survey_id']) : null;

        $toolName = Display::return_icon(
            SurveyManager::icon_question(Security::remove_XSS($_GET['type'])),
            get_lang(ucfirst(Security::remove_XSS($_GET['type']))),
            array('align' => 'middle', 'height' => '22px')
        ).' ';

        if ($action == 'add') {
            $toolName .= get_lang('AddQuestion').': ';
        } elseif ($action == 'edit') {
            $toolName .= get_lang('EditQuestion').': ';
        }

        switch ($_GET['type']) {
            case 'yesno':
                $toolName .= get_lang('YesNo');
                break;
            case 'multiplechoice':
                $toolName .= get_lang('UniqueSelect');
                break;
            case 'multipleresponse':
                $toolName .= get_lang('MultipleResponse');
                break;
            default:
                $toolName .= get_lang(api_ucfirst(Security::remove_XSS($_GET['type'])));
        }

        $sharedQuestionId = isset($formData['shared_question_id']) ? $formData['shared_question_id'] : null;

        $url = api_get_self().'?action='.$action.'&type='.Security::remove_XSS($_GET['type']).'&survey_id='.$surveyId.'&question_id='.$questionId.'&'.api_get_cidreq();

        $form = new FormValidator('question_form', 'post', $url);
        $form->addHeader($toolName);
        $form->addHidden('survey_id', $surveyId);
        $form->addHidden('question_id', $questionId);
        $form->addHidden('shared_question_id', Security::remove_XSS($sharedQuestionId));
        $form->addHidden('type', Security::remove_XSS($_GET['type']));

        $config = array(
            'ToolbarSet' => 'SurveyQuestion',
            'Width' => '100%',
            'Height' => '120'
        );
        $form->addHtmlEditor(
            'question',
            get_lang('Question'),
            true,
            false,
            $config
        );

        if (api_get_configuration_value('allow_required_survey_questions') &&
            in_array($_GET['type'], ['yesno', 'multiplechoice'])) {
            $form->addCheckBox('is_required', get_lang('IsMandatory'), get_lang('Yes'));
        }

        // When survey type = 1??
        if ($surveyData['survey_type'] == 1) {
            $table_survey_question_group = Database::get_course_table(TABLE_SURVEY_QUESTION_GROUP);
            $sql = 'SELECT id,name FROM '.$table_survey_question_group.'
                    WHERE survey_id = '.(int) $_GET['survey_id'].'
                    ORDER BY name';
            $rs = Database::query($sql);
            $glist = null;
            while ($row = Database::fetch_array($rs, 'NUM')) {
                $glist .= '<option value="'.$row[0].'" >'.$row[1].'</option>';
            }

            $grouplist = $grouplist1 = $grouplist2 = $glist;
            if (!empty($formData['assigned'])) {
                $grouplist = str_replace('<option value="'.$formData['assigned'].'"', '<option value="'.$formData['assigned'].'" selected', $glist);
            }

            if (!empty($formData['assigned1'])) {
                $grouplist1 = str_replace('<option value="'.$formData['assigned1'].'"', '<option value="'.$formData['assigned1'].'" selected', $glist);
            }

            if (!empty($formData['assigned2'])) {
                $grouplist2 = str_replace('<option value="'.$formData['assigned2'].'"', '<option value="'.$formData['assigned2'].'" selected', $glist);
            }

            $this->html .= '	<tr><td colspan="">

			<fieldset style="border:1px solid black"><legend>'.get_lang('Condition').'</legend>

			<b>'.get_lang('Primary').'</b><br />
			'.'<input type="radio" name="choose" value="1" '.(($formData['choose'] == 1) ? 'checked' : '').
                '><select name="assigned">'.$grouplist.'</select><br />';

            $this->html .= '
			<b>'.get_lang('Secondary').'</b><br />
			'.'<input type="radio" name="choose" value="2" '.(($formData['choose'] == 2) ? 'checked' : '').
                '><select name="assigned1">'.$grouplist1.'</select> '.
                '<select name="assigned2">'.$grouplist2.'</select>'
                .'</fieldset><br />';
        }

        $this->setForm($form);

        return $form;
    }

    /**
     * Adds submit button
     *
     */
    public function renderForm()
    {
        if (isset($_GET['question_id']) and !empty($_GET['question_id'])) {

            /**
             * Check if survey has answers first before update it, this is because if you update it, the question
             * options will delete and re-insert in database loosing the iid and question_id to verify the correct answers
             */
            $surveyId = isset($_GET['survey_id']) ? intval($_GET['survey_id']) : 0;
            $answersChecker = SurveyUtil::checkIfSurveyHasAnswers($surveyId);

            if (!$answersChecker) {
                $this->buttonList[] = $this->getForm()->addButtonUpdate(get_lang('ModifyQuestionSurvey'), 'save', true);
            } else {
                $this->getForm()->addHtml('
                    <div class="form-group">
                        <label class="col-sm-2 control-label"></label>
                        <div class="col-sm-8">
                            <div class="alert alert-info">' . get_lang('YouCantNotEditThisQuestionBecauseAlreadyExistAnswers').'</div>
                        </div>
                        <div class="col-sm-2"></div>
                    </div>
                ');
            }
        } else {
            $this->buttonList[] = $this->getForm()->addButtonSave(get_lang('CreateQuestionSurvey'), 'save', true);
        }

        $this->getForm()->addGroup($this->buttonList, 'buttons');
    }

    /**
     * @return FormValidator
     */
    public function getForm()
    {
        return $this->form;
    }

    /**
     * @param FormValidator $form
     */
    public function setForm($form)
    {
        $this->form = $form;
    }

    /**
     * @param array $formData
     *
     * @return mixed
     */
    public function preSave($formData)
    {
        $counter = Session::read('answer_count');
        $answerList = Session::read('answer_list');

        if (empty($answerList)) {
            $answerList = isset($formData['answers']) ? $formData['answers'] : array();
            Session::write('answer_list', $answerList);
            Session::write('answer_list', /** @scrutinizer ignore-type */ $answerList);
        }

        if (isset($_POST['answers'])) {
            $formData['answers'] = $_POST['answers'];
        }

        if (empty($counter)) {
            $counter = count($answerList) - 1;
            Session::write('answer_count', $counter);
        }

        // Moving an answer up
        if (isset($_POST['move_up']) && $_POST['move_up']) {
            foreach ($_POST['move_up'] as $key => & $value) {
                $id1 = $key;
                $content1 = $formData['answers'][$id1];
                $id2 = $key - 1;
                $content2 = $formData['answers'][$id2];
                $formData['answers'][$id1] = $content2;
                $formData['answers'][$id2] = $content1;
            }
        }

        // Moving an answer down
        if (isset($_POST['move_down']) && $_POST['move_down']) {
            foreach ($_POST['move_down'] as $key => & $value) {
                $id1 = $key;
                $content1 = $formData['answers'][$id1];
                $id2 = $key + 1;
                $content2 = $formData['answers'][$id2];
                $formData['answers'][$id1] = $content2;
                $formData['answers'][$id2] = $content1;
            }
        }

        /**
         * This solution is a little bit strange but I could not find a different solution.
         */
        if (isset($_POST['delete_answer'])) {
            $deleted = false;
            foreach ($_POST['delete_answer'] as $key => & $value) {
                $deleted = $key;
                $counter--;
                Session::write('answer_count', $counter);
            }

            foreach ($formData['answers'] as $key => & $value) {
                if ($key > $deleted) {
                    $formData['answers'][$key - 1] = $formData['answers'][$key];
                    unset($formData['answers'][$key]);
                }
            }
        }

        // Adding an answer
        if (isset($_POST['buttons']) && isset($_POST['buttons']['add_answer'])) {
            $counter++;
            Session::write('answer_count', $counter);
        }

        // Removing an answer
        if (isset($_POST['buttons']) && isset($_POST['buttons']['remove_answer'])) {
            $counter--;
            Session::write('answer_count', $counter);
            foreach ($formData['answers'] as $index => &$data) {
                if ($index > $counter) {
                    unset($formData['answers'][$index]);
                }
            }
        }

        if (!isset($_POST['delete_answer'])) {
            if (isset($formData['answers'])) {
                foreach ($formData['answers'] as $index => $data) {
                    if ($index > $counter) {
                        unset($formData['answers'][$index]);
                    }
                }

                for ($i = 0; $i <= $counter; $i++) {
                    if (!isset($formData['answers'][$i])) {
                        $formData['answers'][$i] = '';
                    }
                }
            }
        }

        $formData['answers'] = isset($formData['answers']) ? $formData['answers'] : [];
        Session::write('answer_list', $formData['answers']);

        return $formData;
    }

    /**
     * @param array $surveyData
     * @param array $formData
     *
     * @return mixed
     */
    public function save($surveyData, $formData)
    {
        // Saving a question
        if (isset($_POST['buttons']) && isset($_POST['buttons']['save'])) {
            Session::erase('answer_count');
            Session::erase('answer_list');
            $message = SurveyManager::save_question(
                $surveyData,
                $formData
            );

            if ($message == 'QuestionAdded' || $message == 'QuestionUpdated') {
                header('Location: '.api_get_path(WEB_CODE_PATH).'survey/survey.php?survey_id='.intval($_GET['survey_id']).'&message='.$message.'&'.api_get_cidreq());
                exit;

            }
        }

        return $formData;
    }

    /**
     * Adds two buttons. One to add an option, one to remove an option
     *
     * @param array $data
     *
     */
    public function addRemoveButtons($data)
    {
        $this->buttonList['remove_answer'] = $this->getForm()->createElement(
            'button',
            'remove_answer',
            get_lang('RemoveAnswer'),
            'minus',
            'default'
        );

        if (count($data['answers']) <= 2) {
            $this->buttonList['remove_answer']->updateAttributes(
                array('disabled' => 'disabled')
            );
        }

        $this->buttonList['add_answer'] = $this->getForm()->createElement(
            'button',
            'add_answer',
            get_lang('AddAnswer'),
            'plus',
            'default'
        );
    }

    /**
     * @param FormValidator $form
     * @param array $questionData
     * @param array $answers
     */
    public function render(FormValidator $form, $questionData = array(), $answers = array())
    public function render(FormValidator $form, $questionData = array(), /** @scrutinizer ignore-unused */ $answers = array())
    {
        return null;
    }
}


chamilo / chamilo-lms

Push — master ( 9b8b24...6e1754 )

survey_question::preSave() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
