UserNormalizer::normalize() - Code Metrics - Inspection of "Auth: Add SCIM support" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7302)

by Angel Fernando Quiroz

created 2026-01-02 14:19 UTC

UserNormalizer::normalize() A

↳ Parent: UserNormalizer

Complexity

Conditions	4
Paths	8

Size

Total Lines	60
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	35
c	1
b	0
f	0
nc	8
nop	3
dl	0
loc	60
rs	9.36

How to fix Long Method

<?php

/* For licensing terms, see /license.txt */

declare(strict_types=1);

namespace Chamilo\CoreBundle\Serializer\Normalizer\Scim;

use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Helpers\NameConventionHelper;
use Chamilo\CoreBundle\Helpers\ScimHelper;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;

class UserNormalizer implements NormalizerInterface, NormalizerAwareInterface
{
    use NormalizerAwareTrait;

    public const FORMAT = 'scim';
    private const ALREADY_CALLED = 'SCIM_USER_NORMALIZER_ALREADY_CALLED';

    public function __construct(
        private readonly NameConventionHelper $nameConventionHelper,
        private readonly UrlGeneratorInterface $router,
        private readonly ScimHelper $scimHelper,
    ) {}

    public function normalize(mixed $object, ?string $format = null, array $context = []): array
    {
        /** @var User $user */
        $user = $object;

        $uuid = $user->getUuid();

        $userInfo = [
            'schemas' => ['urn:ietf:params:scim:schemas:core:2.0:User'],
            'id' => $uuid,
            'userName' => $user->getUsername(),
            'name' => [
                'formatted' => $this->nameConventionHelper->getPersonName($user),
                'givenName' => $user->getFirstname(),
                'familyName' => $user->getLastName(),
            ],
            'emails' => [
                [
                    'value' => $user->getEmail(),
                    'type' => 'work',
                    'primary' => true,
                ],
            ],
            'active' => $user->isActive(),
            'timezone' => $user->getTimezone(),
            'meta' => [
                'resourceType' => 'User',
                'created' => $user->getCreatedAt()?->format('c'),
                'lastModified' => $user->getUpdatedAt()?->format('c'),
                'location' => $this->router->generate(
                    'scim_user',
                    ['uuid' => $uuid],
                    UrlGeneratorInterface::ABSOLUTE_URL
                ),
            ],
        ];

        if ($externalId = $this->scimHelper->getExternalId($user)) {
            $userInfo['externalId'] = $externalId;
        }

        if ($phone = $user->getPhone()) {
            $userInfo['phoneNumbers'] = [
                [
                    'type' => 'work',
                    'value' => $phone,
                ],
            ];
        }

        if ($address = $user->getAddress()) {
            $userInfo['addresses'] = [
                [
                    'type' => 'work',
                    'formatted' => $address,
                ]
            ];
        }

        return $userInfo;
    }

    public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
    {
        if (isset($context[self::ALREADY_CALLED])) {
            return false;
        }

        return $data instanceof User && self::FORMAT === $format;
    }

    public function getSupportedTypes(?string $format): array
    {
        return [
            User::class => false,
        ];
    }
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			declare(strict_types=1);
6
7			namespace Chamilo\CoreBundle\Serializer\Normalizer\Scim;
8
9			use Chamilo\CoreBundle\Entity\User;
10			use Chamilo\CoreBundle\Helpers\NameConventionHelper;
11			use Chamilo\CoreBundle\Helpers\ScimHelper;
12			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
13			use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
14			use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
15			use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
16
17			class UserNormalizer implements NormalizerInterface, NormalizerAwareInterface
18			{
19			use NormalizerAwareTrait;
20
21			public const FORMAT = 'scim';
22			private const ALREADY_CALLED = 'SCIM_USER_NORMALIZER_ALREADY_CALLED';
23
24			public function __construct(
25			private readonly NameConventionHelper $nameConventionHelper,
26			private readonly UrlGeneratorInterface $router,
27			private readonly ScimHelper $scimHelper,
28			) {}
29
30			public function normalize(mixed $object, ?string $format = null, array $context = []): array
31			{
32			/** @var User $user */
33			$user = $object;
34
35			$uuid = $user->getUuid();
36
37			$userInfo = [
38			'schemas' => ['urn:ietf:params:scim:schemas:core:2.0:User'],
39			'id' => $uuid,
40			'userName' => $user->getUsername(),
41			'name' => [
42			'formatted' => $this->nameConventionHelper->getPersonName($user),
43			'givenName' => $user->getFirstname(),
44			'familyName' => $user->getLastName(),
45			],
46			'emails' => [
47			[
48			'value' => $user->getEmail(),
49			'type' => 'work',
50			'primary' => true,
51			],
52			],
53			'active' => $user->isActive(),
54			'timezone' => $user->getTimezone(),
55			'meta' => [
56			'resourceType' => 'User',
57			'created' => $user->getCreatedAt()?->format('c'),
58			'lastModified' => $user->getUpdatedAt()?->format('c'),
59			'location' => $this->router->generate(
60			'scim_user',
61			['uuid' => $uuid],
62			UrlGeneratorInterface::ABSOLUTE_URL
63			),
64			],
65			];
66
67			if ($externalId = $this->scimHelper->getExternalId($user)) {
68			$userInfo['externalId'] = $externalId;
69			}
70
71			if ($phone = $user->getPhone()) {
72			$userInfo['phoneNumbers'] = [
73			[
74			'type' => 'work',
75			'value' => $phone,
76			],
77			];
78			}
79
80			if ($address = $user->getAddress()) {
81			$userInfo['addresses'] = [
82			[
83			'type' => 'work',
84			'formatted' => $address,
85			]
86			];
87			}
88
89			return $userInfo;
90			}
91
92			public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
93			{
94			if (isset($context[self::ALREADY_CALLED])) {
95			return false;
96			}
97
98			return $data instanceof User && self::FORMAT === $format;
99			}
100
101			public function getSupportedTypes(?string $format): array
102			{
103			return [
104			User::class => false,
105			];
106			}
107			}
108

chamilo / chamilo-lms

Pull Request — master (#7302)

UserNormalizer::normalize() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like