Conditions | 19 |
Paths | 216 |
Total Lines | 212 |
Code Lines | 130 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
54 | #[Route(path: '/{sid}/about', name: 'chamilo_core_session_about')] |
||
55 | public function about( |
||
56 | Request $request, |
||
57 | Session $session, |
||
58 | IllustrationRepository $illustrationRepo, |
||
59 | UserRepository $userRepo, |
||
60 | EntityManagerInterface $em |
||
61 | ): Response { |
||
62 | $requestSession = $request->getSession(); |
||
63 | $htmlHeadXtra[] = api_get_asset('readmore-js/readmore.js'); |
||
|
|||
64 | |||
65 | $sessionId = $session->getId(); |
||
66 | $courses = []; |
||
67 | $sessionCourses = $session->getCourses(); |
||
68 | |||
69 | /** @var EntityRepository $fieldsRepo */ |
||
70 | $fieldsRepo = $em->getRepository(ExtraField::class); |
||
71 | |||
72 | /** @var TagRepository $tagRepo */ |
||
73 | $tagRepo = $em->getRepository(Tag::class); |
||
74 | |||
75 | /** @var SequenceRepository $sequenceResourceRepo */ |
||
76 | $sequenceResourceRepo = $em->getRepository(SequenceResource::class); |
||
77 | |||
78 | /** @var ExtraField $tagField */ |
||
79 | $tagField = $fieldsRepo->findOneBy([ |
||
80 | 'itemType' => ExtraField::COURSE_FIELD_TYPE, |
||
81 | 'variable' => 'tags', |
||
82 | ]); |
||
83 | |||
84 | $courseValues = new ExtraFieldValue('course'); |
||
85 | $userValues = new ExtraFieldValue('user'); |
||
86 | $sessionValues = new ExtraFieldValue('session'); |
||
87 | |||
88 | /** @var SessionRelCourse $sessionRelCourse */ |
||
89 | foreach ($sessionCourses as $sessionRelCourse) { |
||
90 | $sessionCourse = $sessionRelCourse->getCourse(); |
||
91 | $courseTags = []; |
||
92 | |||
93 | if (null !== $tagField) { |
||
94 | $courseTags = $tagRepo->getTagsByItem($tagField, $sessionCourse->getId()); |
||
95 | } |
||
96 | |||
97 | $courseCoaches = $userRepo->getCoachesForSessionCourse($session, $sessionCourse); |
||
98 | $coachesData = []; |
||
99 | |||
100 | /** @var User $courseCoach */ |
||
101 | foreach ($courseCoaches as $courseCoach) { |
||
102 | $coachData = [ |
||
103 | 'complete_name' => UserManager::formatUserFullName($courseCoach), |
||
104 | 'image' => $illustrationRepo->getIllustrationUrl($courseCoach), |
||
105 | 'diploma' => $courseCoach->getDiplomas(), |
||
106 | 'openarea' => $courseCoach->getOpenarea(), |
||
107 | 'extra_fields' => $userValues->getAllValuesForAnItem( |
||
108 | $courseCoach->getId(), |
||
109 | null, |
||
110 | true |
||
111 | ), |
||
112 | ]; |
||
113 | |||
114 | $coachesData[] = $coachData; |
||
115 | } |
||
116 | |||
117 | $cd = new CourseDescription(); |
||
118 | $cd->set_course_id($sessionCourse->getId()); |
||
119 | $cd->set_session_id($session->getId()); |
||
120 | $descriptionsData = $cd->get_description_data(); |
||
121 | |||
122 | $courseDescription = []; |
||
123 | $courseObjectives = []; |
||
124 | $courseTopics = []; |
||
125 | $courseMethodology = []; |
||
126 | $courseMaterial = []; |
||
127 | $courseResources = []; |
||
128 | $courseAssessment = []; |
||
129 | $courseCustom = []; |
||
130 | |||
131 | if (!empty($descriptionsData)) { |
||
132 | foreach ($descriptionsData as $descriptionInfo) { |
||
133 | $type = $descriptionInfo->getDescriptionType(); |
||
134 | |||
135 | switch ($type) { |
||
136 | case CCourseDescription::TYPE_DESCRIPTION: |
||
137 | $courseDescription[] = $descriptionInfo; |
||
138 | |||
139 | break; |
||
140 | |||
141 | case CCourseDescription::TYPE_OBJECTIVES: |
||
142 | $courseObjectives[] = $descriptionInfo; |
||
143 | |||
144 | break; |
||
145 | |||
146 | case CCourseDescription::TYPE_TOPICS: |
||
147 | $courseTopics[] = $descriptionInfo; |
||
148 | |||
149 | break; |
||
150 | |||
151 | case CCourseDescription::TYPE_METHODOLOGY: |
||
152 | $courseMethodology[] = $descriptionInfo; |
||
153 | |||
154 | break; |
||
155 | |||
156 | case CCourseDescription::TYPE_COURSE_MATERIAL: |
||
157 | $courseMaterial[] = $descriptionInfo; |
||
158 | |||
159 | break; |
||
160 | |||
161 | case CCourseDescription::TYPE_RESOURCES: |
||
162 | $courseResources[] = $descriptionInfo; |
||
163 | |||
164 | break; |
||
165 | |||
166 | case CCourseDescription::TYPE_ASSESSMENT: |
||
167 | $courseAssessment[] = $descriptionInfo; |
||
168 | |||
169 | break; |
||
170 | |||
171 | case CCourseDescription::TYPE_CUSTOM: |
||
172 | $courseCustom[] = $descriptionInfo; |
||
173 | |||
174 | break; |
||
175 | } |
||
176 | } |
||
177 | } |
||
178 | |||
179 | $courses[] = [ |
||
180 | 'course' => $sessionCourse, |
||
181 | 'description' => $courseDescription, |
||
182 | 'image' => Container::getIllustrationRepository()->getIllustrationUrl($sessionCourse), |
||
183 | 'tags' => $courseTags, |
||
184 | 'objectives' => $courseObjectives, |
||
185 | 'topics' => $courseTopics, |
||
186 | 'methodology' => $courseMethodology, |
||
187 | 'material' => $courseMaterial, |
||
188 | 'resources' => $courseResources, |
||
189 | 'assessment' => $courseAssessment, |
||
190 | 'custom' => array_reverse($courseCustom), |
||
191 | 'coaches' => $coachesData, |
||
192 | 'extra_fields' => $courseValues->getAllValuesForAnItem( |
||
193 | $sessionCourse->getId(), |
||
194 | null, |
||
195 | true |
||
196 | ), |
||
197 | ]; |
||
198 | } |
||
199 | |||
200 | $sessionDates = SessionManager::parseSessionDates($session, true); |
||
201 | |||
202 | $hasRequirements = false; |
||
203 | |||
204 | /*$sessionRequirements = $sequenceResourceRepo->getRequirements( |
||
205 | * $session->getId(), |
||
206 | * SequenceResource::SESSION_TYPE |
||
207 | * ); |
||
208 | * foreach ($sessionRequirements as $sequence) { |
||
209 | * if (!empty($sequence['requirements'])) { |
||
210 | * $hasRequirements = true; |
||
211 | * break; |
||
212 | * } |
||
213 | * }*/ |
||
214 | $plugin = BuyCoursesPlugin::create(); |
||
215 | $checker = $plugin->isEnabled(); |
||
216 | $sessionIsPremium = null; |
||
217 | if ($checker) { |
||
218 | $sessionIsPremium = $plugin->getItemByProduct( |
||
219 | $sessionId, |
||
220 | BuyCoursesPlugin::PRODUCT_TYPE_SESSION |
||
221 | ); |
||
222 | if ([] !== $sessionIsPremium) { |
||
223 | $requestSession->set('SessionIsPremium', true); |
||
224 | $requestSession->set('sessionId', $sessionId); |
||
225 | } |
||
226 | } |
||
227 | |||
228 | $redirectToSession = ('true' === Container::getSettingsManager()->getSetting('session.allow_redirect_to_session_after_inscription_about')); |
||
229 | $redirectToSession = $redirectToSession ? '?s='.$sessionId : false; |
||
230 | |||
231 | $coursesInThisSession = SessionManager::get_course_list_by_session_id($sessionId); |
||
232 | $coursesCount = \count($coursesInThisSession); |
||
233 | $redirectToSession = 1 === $coursesCount && $redirectToSession |
||
234 | ? ($redirectToSession.'&cr='.array_values($coursesInThisSession)[0]['directory']) |
||
235 | : $redirectToSession; |
||
236 | |||
237 | $essence = new Essence(); |
||
238 | |||
239 | $params = [ |
||
240 | 'session' => $session, |
||
241 | 'redirect_to_session' => $redirectToSession, |
||
242 | 'courses' => $courses, |
||
243 | 'essence' => $essence, |
||
244 | 'session_extra_fields' => $sessionValues->getAllValuesForAnItem($session->getId(), null, true), |
||
245 | 'has_requirements' => $hasRequirements, |
||
246 | // 'sequences' => $sessionRequirements, |
||
247 | 'is_premium' => $sessionIsPremium, |
||
248 | 'show_tutor' => 'true' === api_get_setting('show_session_coach'), |
||
249 | 'page_url' => api_get_path(WEB_PATH).\sprintf('sessions/%s/about/', $session->getId()), |
||
250 | 'session_date' => $sessionDates, |
||
251 | 'is_subscribed' => SessionManager::isUserSubscribedAsStudent( |
||
252 | $session->getId(), |
||
253 | api_get_user_id() |
||
254 | ), |
||
255 | 'user_session_time' => SessionManager::getDayLeftInSession( |
||
256 | [ |
||
257 | 'id' => $session->getId(), |
||
258 | 'duration' => $session->getDuration(), |
||
259 | ], |
||
260 | api_get_user_id() |
||
261 | ), |
||
262 | 'base_url' => $request->getSchemeAndHttpHost(), |
||
263 | ]; |
||
264 | |||
265 | return $this->render('@ChamiloCore/Session/about.html.twig', $params); |
||
266 | } |
||
358 |