Conditions | 1 |
Paths | 1 |
Total Lines | 54 |
Code Lines | 8 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
19 | public function up(Schema $schema): void |
||
20 | { |
||
21 | $this->addSql(' |
||
22 | CREATE TABLE catalogue_course_rel_access_url_rel_usergroup ( |
||
23 | id INT AUTO_INCREMENT NOT NULL, |
||
24 | course_id INT DEFAULT NULL, |
||
25 | access_url_id INT DEFAULT NULL, |
||
26 | usergroup_id INT DEFAULT NULL, |
||
27 | INDEX IDX_37CC1F8E591CC992 (course_id), |
||
28 | INDEX IDX_37CC1F8E73444FD5 (access_url_id), |
||
29 | INDEX IDX_37CC1F8ED2112630 (usergroup_id), |
||
30 | PRIMARY KEY(id) |
||
31 | ) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci ENGINE = InnoDB ROW_FORMAT = DYNAMIC; |
||
32 | '); |
||
33 | |||
34 | $this->addSql(' |
||
35 | CREATE TABLE catalogue_session_rel_access_url_rel_usergroup ( |
||
36 | id INT AUTO_INCREMENT NOT NULL, |
||
37 | session_id INT DEFAULT NULL, |
||
38 | access_url_id INT DEFAULT NULL, |
||
39 | usergroup_id INT DEFAULT NULL, |
||
40 | INDEX IDX_B143E63A613FECDF (session_id), |
||
41 | INDEX IDX_B143E63A73444FD5 (access_url_id), |
||
42 | INDEX IDX_B143E63AD2112630 (usergroup_id), |
||
43 | PRIMARY KEY(id) |
||
44 | ) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci ENGINE = InnoDB ROW_FORMAT = DYNAMIC; |
||
45 | '); |
||
46 | |||
47 | $this->addSql(' |
||
48 | ALTER TABLE catalogue_course_rel_access_url_rel_usergroup |
||
49 | ADD CONSTRAINT FK_37CC1F8E591CC992 FOREIGN KEY (course_id) REFERENCES course (id) ON DELETE CASCADE; |
||
50 | '); |
||
51 | |||
52 | $this->addSql(' |
||
53 | ALTER TABLE catalogue_course_rel_access_url_rel_usergroup |
||
54 | ADD CONSTRAINT FK_37CC1F8E73444FD5 FOREIGN KEY (access_url_id) REFERENCES access_url (id) ON DELETE CASCADE; |
||
55 | '); |
||
56 | |||
57 | $this->addSql(' |
||
58 | ALTER TABLE catalogue_course_rel_access_url_rel_usergroup |
||
59 | ADD CONSTRAINT FK_37CC1F8ED2112630 FOREIGN KEY (usergroup_id) REFERENCES usergroup (id) ON DELETE SET NULL; |
||
60 | '); |
||
61 | |||
62 | $this->addSql(' |
||
63 | ALTER TABLE catalogue_session_rel_access_url_rel_usergroup |
||
64 | ADD CONSTRAINT FK_B143E63A613FECDF FOREIGN KEY (session_id) REFERENCES session (id) ON DELETE CASCADE; |
||
65 | '); |
||
66 | |||
67 | $this->addSql(' |
||
68 | ALTER TABLE catalogue_session_rel_access_url_rel_usergroup |
||
69 | ADD CONSTRAINT FK_B143E63A73444FD5 FOREIGN KEY (access_url_id) REFERENCES access_url (id) ON DELETE CASCADE; |
||
70 | '); |
||
71 | |||
72 | $this->addSql(' |
||
73 | ALTER TABLE catalogue_session_rel_access_url_rel_usergroup |
||
84 |