Completed
Pull Request — 1.11.x (#1599)
by José
28:19
created
main/inc/lib/fileManage.lib.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -39,8 +39,8 @@  discard block
 block discarded – undo
39 39
  * Deletes a file or a directory
40 40
  *
41 41
  * @author - Hugues Peeters
42
- * @param  $file (String) - the path of file or directory to delete
43
- * @return boolean - true if the delete succeed, false otherwise.
42
+ * @param  string $file (String) - the path of file or directory to delete
43
+ * @return boolean|null - true if the delete succeed, false otherwise.
44 44
  * @see    - delete() uses check_name_exist() and removeDir() functions
45 45
  */
46 46
 function my_delete($file)
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
  * @author Hugues Peeters <[email protected]>
128 128
  * @param  string $file_path complete path of the file or the directory
129 129
  * @param  string $new_file_name new name for the file or the directory
130
- * @return boolean true if succeed, false otherwise
130
+ * @return string|false true if succeed, false otherwise
131 131
  * @see rename() uses the check_name_exist() and php2phps() functions
132 132
  */
133 133
 function my_rename($file_path, $new_file_name) {
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
  * @param  string $target the path of the new area
175 175
  * @param  bool $forceMove Whether to force a move or to make a copy (safer but slower) and then delete the original
176 176
  * @param	bool $moveContent In some cases (including migrations), we need to move the *content* and not the folder itself
177
- * @return bool true if the move succeed, false otherwise.
177
+ * @return boolean|null true if the move succeed, false otherwise.
178 178
  * @see move() uses check_name_exist() and copyDirTo() functions
179 179
  */
180 180
 function move($source, $target, $forceMove = false, $moveContent = false)
Please login to merge, or discard this patch.
main/inc/lib/skill.lib.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -326,6 +326,7 @@  discard block
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * Gets an element
329
+     * @param integer $gradebook_id
329 330
      */
330 331
     public function get_skill_info($skill_id, $gradebook_id)
331 332
     {
@@ -544,7 +545,7 @@  discard block
 block discarded – undo
544 545
      * Gets an element
545 546
      * @param int $id
546 547
      *
547
-     * @return array|mixed
548
+     * @return integer
548 549
      */
549 550
     public function get($id)
550 551
     {
@@ -885,7 +886,7 @@  discard block
 block discarded – undo
885 886
     /**
886 887
      * Get user's skills
887 888
      *
888
-     * @param int $userId User's id
889
+     * @param integer $user_id User's id
889 890
      * @param bool $get_skill_data
890 891
      */
891 892
     public function get_user_skills($user_id, $get_skill_data = false)
@@ -1090,7 +1091,7 @@  discard block
 block discarded – undo
1090 1091
      * @param bool return a flat array or not
1091 1092
      * @param int depth of the skills
1092 1093
      * @param bool filter status
1093
-     * @return json
1094
+     * @return string
1094 1095
      */
1095 1096
     public function get_skills_tree_json($user_id = null, $skill_id = null, $return_flat_array = false, $main_depth = 2, $filter_status = false)
1096 1097
     {
Please login to merge, or discard this patch.
main/inc/lib/system_announcements.lib.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -306,7 +306,7 @@
 block discarded – undo
306 306
      * @param int    Whether the announcement should be visible to anonymous users (1) or not (0)
307 307
      * @param string The language for which the announvement should be shown. Leave null for all langages
308 308
      * @param int    Whether to send an e-mail to all users (1) or not (0)
309
-     * @return mixed  insert_id on success, false on failure
309
+     * @return false|string  insert_id on success, false on failure
310 310
      */
311 311
     public static function add_announcement(
312 312
         $title,
Please login to merge, or discard this patch.
main/inc/lib/system/session.class.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,6 +14,9 @@  discard block
 block discarded – undo
14 14
 class Session implements \ArrayAccess
15 15
 {
16 16
 
17
+    /**
18
+     * @param string $variable
19
+     */
17 20
     static function read($variable, $default = null)
18 21
     {
19 22
         return isset($_SESSION[$variable]) ? $_SESSION[$variable] : $default;
@@ -39,7 +42,7 @@  discard block
 block discarded – undo
39 42
      * Returns true if session has variable set up, false otherwise.
40 43
      *
41 44
      * @param string $variable
42
-     * @return mixed value
45
+     * @return boolean value
43 46
      */
44 47
     static function has($variable)
45 48
     {
Please login to merge, or discard this patch.
main/exercise/export/exercise_import.inc.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -949,7 +949,6 @@
 block discarded – undo
949 949
 /**
950 950
  * Processes an IMS/QTI manifest file: store links to new files to be able to transform them into questions text
951 951
  * @param string $filePath The absolute filepath
952
- * @param array $links List of filepaths changes
953 952
  * @return bool
954 953
  */
955 954
 function qtiProcessManifest($filePath)
Please login to merge, or discard this patch.
main/inc/lib/internationalization.lib.php 1 patch
Doc Comments   +19 added lines, -12 removed lines patch added patch discarded remove patch
@@ -419,6 +419,7 @@  discard block
 block discarded – undo
419 419
  * If null, the timezone will be determined based on user preference,
420 420
  * or timezone chosen by the admin for the platform.
421 421
  * @param string The timezone to be converted from. If null, UTC will be assumed.
422
+ * @param string $to_timezone
422 423
  * @return string The converted time formatted as Y-m-d H:i:s
423 424
  *
424 425
  * @author Guillaume Viguier <[email protected]>
@@ -683,6 +684,8 @@  discard block
 block discarded – undo
683 684
  * @param mixed The time to be converted
684 685
  * @param mixed Format to be used (TIME_NO_SEC_FORMAT, DATE_FORMAT_SHORT, DATE_FORMAT_LONG, DATE_TIME_FORMAT_LONG)
685 686
  * @param string Timezone to be converted from. If null, UTC will be assumed.
687
+ * @param integer $format
688
+ * @param string $from_timezone
686 689
  * @return string Converted and localized date
687 690
  *
688 691
  * @author Guillaume Viguier <[email protected]>
@@ -752,7 +755,7 @@  discard block
 block discarded – undo
752 755
  * @param int|string $format (optional)	The person name format. It may be a pattern-string (for example '%t %l, %f' or '%T %F %L', ...) or some of the constants PERSON_NAME_COMMON_CONVENTION (default), PERSON_NAME_WESTERN_ORDER, PERSON_NAME_EASTERN_ORDER, PERSON_NAME_LIBRARY_ORDER.
753 756
  * @param string $language (optional)	The language id. If it is omitted, the current interface language is assumed. This parameter has meaning with the format PERSON_NAME_COMMON_CONVENTION only.
754 757
  * @param string $encoding (optional)	The used internally by this function character encoding. If it is omitted, the platform character set will be used by default.
755
- * @return bool							The result is sort of full name of the person.
758
+ * @return string							The result is sort of full name of the person.
756 759
  * Sample results:
757 760
  * Peter Ustinoff or Dr. Peter Ustinoff     - the Western order
758 761
  * Ustinoff Peter or Dr. Ustinoff Peter     - the Eastern order
@@ -1071,8 +1074,8 @@  discard block
 block discarded – undo
1071 1074
 
1072 1075
 /**
1073 1076
  * This function returns a string or an array with all occurrences of search in subject (ignoring case) replaced with the given replace value.
1074
- * @param mixed $search					String or array of strings to be found.
1075
- * @param mixed $replace				String or array of strings used for replacement.
1077
+ * @param string $search					String or array of strings to be found.
1078
+ * @param string $replace				String or array of strings used for replacement.
1076 1079
  * @param mixed $subject				String or array of strings being searched.
1077 1080
  * @param int $count (optional)			The number of matched and replaced needles will be returned in count, which is passed by reference.
1078 1081
  * @param string $encoding (optional)	The used internally by this function character encoding.
@@ -1135,10 +1138,10 @@  discard block
 block discarded – undo
1135 1138
 /**
1136 1139
  * Finds first occurrence of a string within another, case insensitive.
1137 1140
  * @param string $haystack					The string from which to get the first occurrence.
1138
- * @param mixed $needle						The string to be found.
1141
+ * @param string $needle						The string to be found.
1139 1142
  * @param bool $before_needle (optional)	Determines which portion of $haystack this function returns. The default value is FALSE.
1140 1143
  * @param string $encoding (optional)		The used internally by this function character encoding. If it is omitted, the platform character set will be used by default.
1141
- * @return mixed							Returns the portion of $haystack, or FALSE if $needle is not found.
1144
+ * @return false|string							Returns the portion of $haystack, or FALSE if $needle is not found.
1142 1145
  * Notes:
1143 1146
  * If $needle is not a string, it is converted to an integer and applied as the ordinal value (codepoint if the encoding is UTF-8) of a character.
1144 1147
  * If $before_needle is set to TRUE, the function returns all of $haystack from the beginning to the first occurrence of $needle.
@@ -1194,7 +1197,7 @@  discard block
 block discarded – undo
1194 1197
  * @param mixed $needle						The string which first character is to be found.
1195 1198
  * @param bool $before_needle (optional)	Determines which portion of $haystack this function returns. The default value is FALSE.
1196 1199
  * @param string $encoding (optional)		The used internally by this function character encoding. If it is omitted, the platform character set will be used by default.
1197
- * @return mixed							Returns the portion of $haystack, or FALSE if the first character from $needle is not found.
1200
+ * @return false|string							Returns the portion of $haystack, or FALSE if the first character from $needle is not found.
1198 1201
  * Notes:
1199 1202
  * If $needle is not a string, it is converted to an integer and applied as the ordinal value (codepoint if the encoding is UTF-8) of a character.
1200 1203
  * If $before_needle is set to TRUE, the function returns all of $haystack from the beginning to the first occurrence.
@@ -1261,7 +1264,7 @@  discard block
 block discarded – undo
1261 1264
  * @param mixed $needle						The string to be found.
1262 1265
  * @param bool $before_needle (optional)	Determines which portion of $haystack this function returns. The default value is FALSE.
1263 1266
  * @param string $encoding (optional)		The used internally by this function character encoding. If it is omitted, the platform character set will be used by default.
1264
- * @return mixed							Returns the portion of $haystack, or FALSE if $needle is not found.
1267
+ * @return false|string							Returns the portion of $haystack, or FALSE if $needle is not found.
1265 1268
  * Notes:
1266 1269
  * If $needle is not a string, it is converted to an integer and applied as the ordinal value (codepoint if the encoding is UTF-8) of a character.
1267 1270
  * If $before_needle is set to TRUE, the function returns all of $haystack from the beginning to the first occurrence of $needle.
@@ -1442,8 +1445,8 @@  discard block
 block discarded – undo
1442 1445
 
1443 1446
 /**
1444 1447
  * Performs a regular expression search and replace, UTF-8 aware when it is applicable.
1445
- * @param string|array $pattern			The pattern to search for. It can be either a string or an array with strings.
1446
- * @param string|array $replacement		The string or an array with strings to replace.
1448
+ * @param string $pattern			The pattern to search for. It can be either a string or an array with strings.
1449
+ * @param string $replacement		The string or an array with strings to replace.
1447 1450
  * @param string|array $subject			The string or an array with strings to search and replace.
1448 1451
  * @param int $limit					The maximum possible replacements for each pattern in each subject string. Defaults to -1 (no limit).
1449 1452
  * @param int &$count					If specified, this variable will be filled with the number of replacements done.
@@ -1591,7 +1594,7 @@  discard block
 block discarded – undo
1591 1594
 
1592 1595
 /**
1593 1596
  * This function checks whether two $encoding are equal (same, equvalent).
1594
- * @param string|array $encoding1		The first encoding
1597
+ * @param string $encoding1		The first encoding
1595 1598
  * @param string|array $encoding2		The second encoding
1596 1599
  * @param bool $strict					When this parameter is TRUE the comparison ignores aliases of encodings.
1597 1600
  * When the parameter is FALSE, aliases are taken into account.
@@ -1695,6 +1698,7 @@  discard block
 block discarded – undo
1695 1698
 /**
1696 1699
  * Checks a string for UTF-8 validity.
1697 1700
  *
1701
+ * @param string $string
1698 1702
  */
1699 1703
 function api_is_valid_utf8(&$string)
1700 1704
 {
@@ -1837,7 +1841,7 @@  discard block
 block discarded – undo
1837 1841
 /**
1838 1842
  * Replaces non-valid formats for person names with the default (English) format.
1839 1843
  * @param string $format	The input format to be verified.
1840
- * @return bool				Returns the same format if is is valid, otherwise returns a valid English format.
1844
+ * @return string				Returns the same format if is is valid, otherwise returns a valid English format.
1841 1845
  */
1842 1846
 function _api_validate_person_name_format($format) {
1843 1847
     if (empty($format) || stripos($format, '%f') === false || stripos($format, '%l') === false) {
@@ -1964,6 +1968,9 @@  discard block
 block discarded – undo
1964 1968
 
1965 1969
 // This function checks whether the function _api_convert_encoding() (the php-
1966 1970
 // implementation) is able to convert from/to a given encoding.
1971
+/**
1972
+ * @param string $encoding
1973
+ */
1967 1974
 function _api_convert_encoding_supports($encoding) {
1968 1975
     static $supports = array();
1969 1976
     if (!isset($supports[$encoding])) {
@@ -1974,7 +1981,7 @@  discard block
 block discarded – undo
1974 1981
 
1975 1982
 /**
1976 1983
  * Given a date object, return a human or ISO format, with or without h:m:s
1977
- * @param object $date The Date object
1984
+ * @param DateTime $date The Date object
1978 1985
  * @param bool $showTime Whether to show the time and date (true) or only the date (false)
1979 1986
  * @param bool $humanForm Whether to show day-month-year (true) or year-month-day (false)
1980 1987
  * @return string Formatted date
Please login to merge, or discard this patch.
main/inc/lib/thematic.lib.php 1 patch
Doc Comments   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -242,6 +242,9 @@  discard block
 block discarded – undo
242 242
     /**
243 243
      * get thematic list
244 244
      * @param	int		Thematic id (optional), get list by id
245
+     * @param integer $thematic_id
246
+     * @param string $course_code
247
+     * @param integer $session_id
245 248
      * @return	array	Thematic data
246 249
      */
247 250
     public static function get_thematic_list(
@@ -799,6 +802,7 @@  discard block
 block discarded – undo
799 802
     /**
800 803
      * delete  thematic advance
801 804
      * @param	int		Thematic advance id
805
+     * @param integer $thematic_advance_id
802 806
      * @return	int		Affected rows
803 807
      */
804 808
     public function thematic_advance_destroy($thematic_advance_id)
@@ -1116,6 +1120,7 @@  discard block
 block discarded – undo
1116 1120
     /**
1117 1121
      * update done thematic advances from thematic details interface
1118 1122
      * @param 	int		Thematic id
1123
+     * @param integer $thematic_advance_id
1119 1124
      * @return	int		Affected rows
1120 1125
      */
1121 1126
     public function update_done_thematic_advances($thematic_advance_id)
@@ -1343,6 +1348,7 @@  discard block
 block discarded – undo
1343 1348
      * Get average of advances by thematic
1344 1349
      * @param	int		Thematic id
1345 1350
      * @param	string	Course code (optional)
1351
+     * @param string $course_code
1346 1352
      * @return 	float	Average of thematic advances
1347 1353
      */
1348 1354
     public function get_average_of_advances_by_thematic($thematic_id, $course_code = null)
@@ -1407,6 +1413,7 @@  discard block
 block discarded – undo
1407 1413
      * @param	string	Content
1408 1414
      * @param	string	Date and time
1409 1415
      * @param	int		Duration in hours
1416
+     * @param integer $id
1410 1417
      * @return void
1411 1418
      */
1412 1419
     public function set_thematic_advance_attributes(
@@ -1437,7 +1444,7 @@  discard block
 block discarded – undo
1437 1444
 
1438 1445
     /**
1439 1446
      * get thematic id
1440
-     * @return void
1447
+     * @return integer
1441 1448
      */
1442 1449
     public function get_thematic_id()
1443 1450
     {
@@ -1446,7 +1453,7 @@  discard block
 block discarded – undo
1446 1453
 
1447 1454
     /**
1448 1455
      * Get thematic plan titles by default
1449
-     * @return array
1456
+     * @return string[]
1450 1457
      */
1451 1458
     public function get_default_thematic_plan_title()
1452 1459
     {
@@ -1463,7 +1470,7 @@  discard block
 block discarded – undo
1463 1470
 
1464 1471
     /**
1465 1472
      * Get thematic plan icons by default
1466
-     * @return array
1473
+     * @return string[]
1467 1474
      */
1468 1475
     public function get_default_thematic_plan_icon()
1469 1476
     {
@@ -1480,7 +1487,7 @@  discard block
 block discarded – undo
1480 1487
 
1481 1488
     /**
1482 1489
      * Get questions by default for help
1483
-     * @return array
1490
+     * @return string[]
1484 1491
      */
1485 1492
     public function get_default_question()
1486 1493
     {
Please login to merge, or discard this patch.
main/gradebook/lib/user_data_generator.class.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,6 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
     /**
74 74
      * Get actual array data
75
+     * @param integer $count
75 76
      * @return array 2-dimensional array - each array contains the elements:
76 77
      * 0: eval/link object
77 78
      * 1: item name
@@ -285,7 +286,7 @@  discard block
 block discarded – undo
285 286
 
286 287
     /**
287 288
      * @param $item
288
-     * @param $ignore_score_color
289
+     * @param boolean $ignore_score_color
289 290
      * @return string
290 291
      */
291 292
     private function build_average_column($item, $ignore_score_color)
@@ -306,7 +307,7 @@  discard block
 block discarded – undo
306 307
 
307 308
     /**
308 309
      * @param $item
309
-     * @param $ignore_score_color
310
+     * @param boolean $ignore_score_color
310 311
      * @return string
311 312
      */
312 313
     private function build_result_column($item, $ignore_score_color)
@@ -323,7 +324,7 @@  discard block
 block discarded – undo
323 324
 
324 325
     /**
325 326
      * @param $item
326
-     * @param $ignore_score_color
327
+     * @param boolean $ignore_score_color
327 328
      * @return string
328 329
      */
329 330
     private function build_mask_column($item, $ignore_score_color)
@@ -339,7 +340,7 @@  discard block
 block discarded – undo
339 340
 
340 341
     /**
341 342
      * @param $coursecode
342
-     * @return mixed
343
+     * @return string
343 344
      */
344 345
     private function get_course_name_from_code_cached($coursecode)
345 346
     {
Please login to merge, or discard this patch.
main/inc/lib/webservices/WebService.class.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@
 block discarded – undo
20 20
 
21 21
     /**
22 22
      * Class constructor
23
-     * @param $username
24
-     * @param $apiKey
23
+     * @param string $username
24
+     * @param string $apiKey
25 25
      */
26 26
     protected function __construct($username, $apiKey)
27 27
     {
Please login to merge, or discard this patch.