ResourceControllerTrait::setBreadCrumb() - Code Metrics - Inspection of "Internal: Refactor resource services definition, u..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( e7429e...db9c88 )

by Julito
created 2020-08-24 10:13 UTC
ResourceControllerTrait::setBreadCrumb() B

↳ Parent: ResourceControllerTrait
Complexity

Conditions	6
Paths	1
Size

Total Lines	79
Code Lines	31
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	6
eloc	31
c	0
b	0
f	0
nc	1
nop	2
dl	0
loc	79
rs	8.8017
How to fix Long Method

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Traits;

use Chamilo\CoreBundle\Entity\AbstractResource;
use Chamilo\CoreBundle\Entity\ResourceInterface;
use Chamilo\CoreBundle\Entity\ResourceNode;
use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Repository\ResourceFactory;
use Chamilo\CoreBundle\Repository\ResourceRepository;
use Doctrine\ORM\EntityNotFoundException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

trait ResourceControllerTrait
{
    public function getRepositoryFromRequest(Request $request): ResourceRepository
    {
        $tool = $request->get('tool');
        $type = $request->get('type');

        return $this->getRepository($tool, $type);
    }

    public function getResourceRepositoryFactory(): ResourceFactory
    {
        return $this->container->get('resource_factory');
    }

    public function getRepository($tool, $type): ResourceRepository
    {
        $name = $this->getResourceRepositoryFactory()->getRepository($tool, $type);

        return $this->container->get($name);
    }

    public function denyAccessUnlessValidResource(AbstractResource $resource)
    {
        if (null === $resource) {
            throw new EntityNotFoundException($this->trans('Resource doesn\'t exists.'));
            throw new EntityNotFoundException($this->/** @scrutinizer ignore-call */ trans('Resource doesn\'t exists.'));
        }

        $resourceNode = $resource->getResourceNode();

        if (null === $resourceNode) {
            throw new EntityNotFoundException($this->trans('Resource doesn\'t have a node.'));
        }
    }

    public function getResourceParams(Request $request): array
    {
        $tool = $request->get('tool');
        $type = $request->get('type');
        $id = (int) $request->get('id');

        $courseId = null;
        $sessionId = null;

        if ($this->hasCourse()) {
        if ($this->/** @scrutinizer ignore-call */ hasCourse()) {
            $courseId = $this->getCourse()->getId();
            $courseId = $this->/** @scrutinizer ignore-call */ getCourse()->getId();
            $session = $this->getCourseSession();
            $session = $this->getCourseSession();
            $sessionId = $session ? $session->getId() : 0;
        }

        return [
            'id' => $id,
            'tool' => $tool,
            'type' => $type,
            'cid' => $courseId,
            'sid' => $sessionId,
        ];
    }

    protected function getParentResourceNode(Request $request): ResourceNode
    {
        $parentNodeId = $request->get('id');

        $parentResourceNode = null;
        if (empty($parentNodeId)) {
            if ($this->hasCourse()) {
                $parentResourceNode = $this->getCourse()->getResourceNode();
            } else {
                if ($this->isGranted('IS_AUTHENTICATED_REMEMBERED')) {
                if ($this->/** @scrutinizer ignore-call */ isGranted('IS_AUTHENTICATED_REMEMBERED')) {
                    /** @var User $user */
                    $parentResourceNode = $this->getUser()->getResourceNode();
                    $parentResourceNode = $this->/** @scrutinizer ignore-call */ getUser()->getResourceNode();
                }
            }
        } else {
            $repo = $this->getDoctrine()->getRepository('ChamiloCoreBundle:ResourceNode');
            $repo = $this->/** @scrutinizer ignore-call */ getDoctrine()->getRepository('ChamiloCoreBundle:ResourceNode');
            $parentResourceNode = $repo->find($parentNodeId);
        }

        if (null === $parentResourceNode) {
            throw new AccessDeniedException();
        }

        return $parentResourceNode;
    }

    private function setBreadCrumb(Request $request, ResourceNode $resourceNode)
    {
        return false;
        $tool = $request->get('tool');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        $resourceNodeId = $request->get('id');
        $routeParams = $this->getResourceParams($request);
        $baseNodeId = $this->getCourse()->getResourceNode()->getId();

        if (!empty($resourceNodeId)) {
            $breadcrumb = $this->getBreadCrumb();
            $toolParams = $routeParams;
            $toolParams['id'] = null;

            // Root tool link
            $breadcrumb->addChild(
                $this->trans($tool),
                [
                    'uri' => $this->generateUrl('chamilo_core_resource_index', $toolParams),
                ]
            );

            $repo = $this->getRepositoryFromRequest($request);
            $settings = $repo->getResourceSettings();

            /** @var ResourceInterface $originalResource */
            //$originalResource = $repo->findOneBy(['resourceNode' => $resourceNodeId]);
            if (null === $resourceNode) {
                return;
            }
            //var_dump($resourceNode->getTitle());            throw new \Exception('22');
            $parentList = $resourceNode->getPathForDisplayToArray($baseNodeId);

//            var_dump($originalParent->getPath(), $originalParent->getPathForDisplay());

//            $parentList = [];
            /*          while (null !== $parent) {
                          if ($type !== $parent->getResourceType()->getName()) {
                              break;
                          }
                          $parent = $parent->getParent();
                          if ($parent) {
                              $resource = $repo->findOneBy(['resourceNode' => $parent->getId()]);
                              if ($resource) {
                                  $parentList[] = $resource;
                              }
                          }
                      }
                      $parentList = array_reverse($parentList);
                      foreach ($parentList as $item) {
                          $params = $routeParams;
                          $params['id'] = $item->getResourceNode()->getId();
                          $breadcrumb->addChild(
                              $item->getResourceName(),
                              [
                                  'uri' => $this->generateUrl('chamilo_core_resource_list', $params),
                              ]
                          );
                      }*/

            foreach ($parentList as $id => $title) {
                $params = $routeParams;
                $params['id'] = $id;
                $breadcrumb->addChild(
                    $title,
                    [
                        'uri' => $this->generateUrl('chamilo_core_resource_list', $params),
                    ]
                );
            }

            $params = $routeParams;
            $params['id'] = $resourceNode->getId();
            if (false === $settings->isAllowNodeCreation() || $resourceNode->hasResourceFile()) {
                $breadcrumb->addChild($resourceNode->getTitle());
            } else {
                $breadcrumb->addChild(
                    $resourceNode->getTitle(),
                    [
                        'uri' => $this->generateUrl('chamilo_core_resource_list', $params),
                    ]
                );
            }
        }
    }
}

chamilo / chamilo-lms

Push — master ( e7429e...db9c88 )

ResourceControllerTrait::setBreadCrumb() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
