chamilo / chamilo-lms

app/Migrations/AbstractMigrationChamilo.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
     }
 
     /**
-     * @param $variable
+     * @param string $variable
      * @return mixed
      */
     public function getConfigurationValue($variable)

main/admin/settings.lib.php

Doc Comments +3 added lines, -3 removed lines

@@ -907,7 +907,7 @@ 
  * display the edit and delete icons in the sortable table
  *
  * @param integer $id the id of the template
- * @return html code for the link to edit and delete the template
+ * @return string code for the link to edit and delete the template
  *
  * @author Patrick Cool <patrick.cool@UGent.be>, Ghent University, Belgium
  * @version August 2008
@@ -923,7 +923,7 @@ 
  * Display the image of the template in the sortable table
  *
  * @param string $image the image
- * @return html code for the image
+ * @return string code for the image
  *
  * @author Patrick Cool <patrick.cool@UGent.be>, Ghent University, Belgium
  * @version August 2008
@@ -1120,7 +1120,7 @@ 
 /**
  * Returns an array containing the list of options used to populate the gradebook_number_decimals variable
  * This function is called through a call_user_func() in the generate_settings_form function.
- * @return array List of gradebook_number_decimals options
+ * @return string[] List of gradebook_number_decimals options
  *
  * @author Guillaume Viguier <guillaume.viguier@beeznest.com>
  */

main/admin/sub_language_add.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
  * @param   string  ISO code (fr_FR, ...)
  * @param   int     Whether the sublanguage is published (0=unpublished, 1=published)
  * @param   int     ID del idioma padre
- * @return  int     New sub language ID or false on error
+ * @return  false|string     New sub language ID or false on error
  */
 function add_sub_language ($original_name,$english_name,$isocode,$sublanguage_available,$parent_id) {
     $tbl_admin_languages    = Database :: get_main_table(TABLE_MAIN_LANGUAGE);

main/admin/user_update_import.php

Doc Comments +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 /**
  * Update users from the imported data
  * @param   array   $users List of users
- * @return  void
+ * @return  false|null
  * @uses global variable $inserted_in_course, which returns the list of courses the user was inserted in
  */
 

Braces +4 added lines, -1 removed lines

@@ -454,7 +454,10 @@
     <blockquote>
         <pre>
             <b>UserName</b>;LastName;FirstName;Email;NewUserName;Password;AuthSource;OfficialCode;PhoneNumber;Status;ExpiryDate;Active;Language;Courses;ClassId;
-            xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) echo implode(';', $list_reponse).';'; ?></span>xxx1|xxx2|xxx3;1;<br />
+            xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) {
+    echo implode(';', $list_reponse).';';
+}
+?></span>xxx1|xxx2|xxx3;1;<br />
         </pre>
     </blockquote>
 <p><?php

main/attendance/attendance_controller.php

Doc Comments +1 added lines, -1 removed lines

@@ -206,7 +206,7 @@
 
     /**
      * Restores an attendance entry and fallback to attendances rendering
-     * @param int	$attendanceId
+     * @param int	$attendance_id
      */
     public function attendance_restore($attendance_id)
     {

Braces +5 added lines, -4 removed lines

@@ -529,10 +529,11 @@
                 $result['full_name'] = api_get_person_name($user['firstname'], $user['lastname']);
                 foreach ($data_array['attendant_calendar'] as $class_day) {
                     if ($class_day['done_attendance'] == 1) {
-                        if ($data_users_presence[$user['user_id']][$class_day['id']]['presence'] == 1)
-                            $result[$class_day['id']] = get_lang('UserAttendedSymbol');
-                        else
-                            $result[$class_day['id']] = '<span style="color:red">'.get_lang('UserNotAttendedSymbol').'</span>';
+                        if ($data_users_presence[$user['user_id']][$class_day['id']]['presence'] == 1) {
+                                                    $result[$class_day['id']] = get_lang('UserAttendedSymbol');
+                        } else {
+                                                    $result[$class_day['id']] = '<span style="color:red">'.get_lang('UserNotAttendedSymbol').'</span>';
+                        }
                     } else {
                         $result[$class_day['id']] = " ";
                     }

main/auth/cas/lib/CAS/PGTStorage/pgt-db.php

Doc Comments +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
   /**

    * This method returns the PEAR DB URL to use to connect to the database.

    *

-   * @return a PEAR DB URL

+   * @return string PEAR DB URL

    *

    * @private

    */

@@ -105,7 +105,7 @@ 
   /**

    * This method returns the name of the table where PGT's are stored.

    *

-   * @return the name of a table.

+   * @return string name of a table.

    *

    * @private

    */

@@ -122,7 +122,7 @@ 
    * This method returns an informational string giving the type of storage

    * used by the object (used for debugging purposes).

    *

-   * @return an informational string.

+   * @return string informational string.

    * @public

    */

   function getStorageType()

@@ -148,7 +148,7 @@ 
   /**

    * The class constructor, called by CASClient::SetPGTStorageDB().

    *

-   * @param $cas_parent the CASClient instance that creates the object.

+   * @param CASClient $cas_parent the CASClient instance that creates the object.

    * @param $user the user to access the data with

    * @param $password the user's password

    * @param $database_type the type of the database hosting the data

Braces +18 added lines, -7 removed lines

@@ -166,11 +166,21 @@ 
       // call the ancestor's constructor

       $this->PGTStorage($cas_parent);

 

-      if ( empty($database_type) ) $database_type = CAS_PGT_STORAGE_DB_DEFAULT_DATABASE_TYPE;

-      if ( empty($hostname) ) $hostname = CAS_PGT_STORAGE_DB_DEFAULT_HOSTNAME;

-      if ( $port==0 ) $port = CAS_PGT_STORAGE_DB_DEFAULT_PORT;

-      if ( empty($database) ) $database = CAS_PGT_STORAGE_DB_DEFAULT_DATABASE;

-      if ( empty($table) ) $table = CAS_PGT_STORAGE_DB_DEFAULT_TABLE;

+      if ( empty($database_type) ) {
+          $database_type = CAS_PGT_STORAGE_DB_DEFAULT_DATABASE_TYPE;
+      }
+      if ( empty($hostname) ) {
+          $hostname = CAS_PGT_STORAGE_DB_DEFAULT_HOSTNAME;
+      }
+      if ( $port==0 ) {
+          $port = CAS_PGT_STORAGE_DB_DEFAULT_PORT;
+      }
+      if ( empty($database) ) {
+          $database = CAS_PGT_STORAGE_DB_DEFAULT_DATABASE;
+      }
+      if ( empty($table) ) {
+          $table = CAS_PGT_STORAGE_DB_DEFAULT_TABLE;
+      }
 

       // build and store the PEAR DB URL

       $this->_url = $database_type.':'.'//'.$user.':'.$password.'@'.$hostname.':'.$port.'/'.$database;

@@ -192,8 +202,9 @@ 
     {

       phpCAS::traceBegin();

       // if the storage has already been initialized, return immediatly

-      if ( $this->isInitialized() )

-		return;

+      if ( $this->isInitialized() ) {
+      		return;
+      }
       // call the ancestor's method (mark as initialized)

       parent::init();

       

main/auth/cas/lib/CAS/PGTStorage/pgt-file.php

Doc Comments +7 added lines, -7 removed lines

@@ -98,7 +98,7 @@ 
    * This method returns an informational string giving the type of storage

    * used by the object (used for debugging purposes).

    *

-   * @return an informational string.

+   * @return string informational string.

    * @public

    */

   function getStorageType()

@@ -110,7 +110,7 @@ 
    * This method returns an informational string giving informations on the

    * parameters of the storage.(used for debugging purposes).

    *

-   * @return an informational string.

+   * @return string informational string.

    * @public

    */

   function getStorageInfo()

@@ -125,9 +125,9 @@ 
   /**

    * The class constructor, called by CASClient::SetPGTStorageFile().

    *

-   * @param $cas_parent the CASClient instance that creates the object.

-   * @param $format the format used to store the PGT's (`plain' and `xml' allowed).

-   * @param $path the path where the PGT's should be stored

+   * @param CASClient $cas_parent the CASClient instance that creates the object.

+   * @param string $format the format used to store the PGT's (`plain' and `xml' allowed).

+   * @param string $path the path where the PGT's should be stored

    *

    * @public

    */

@@ -202,7 +202,7 @@ 
    *

    * @param $pgt_iou the PGT iou.

    *

-   * @return a filename

+   * @return string filename

    * @private

    */

   function getPGTIouFilename($pgt_iou)

@@ -243,7 +243,7 @@ 
    *

    * @param $pgt_iou the PGT iou

    *

-   * @return the corresponding PGT, or FALSE on error

+   * @return false|string corresponding PGT, or FALSE on error

    *

    * @public

    */

Braces +10 added lines, -6 removed lines

@@ -137,8 +137,12 @@ 
       // call the ancestor's constructor

       $this->PGTStorage($cas_parent);

 

-      if (empty($format) ) $format = CAS_PGT_STORAGE_FILE_DEFAULT_FORMAT;

-      if (empty($path) ) $path = CAS_PGT_STORAGE_FILE_DEFAULT_PATH;

+      if (empty($format) ) {
+          $format = CAS_PGT_STORAGE_FILE_DEFAULT_FORMAT;
+      }
+      if (empty($path) ) {
+          $path = CAS_PGT_STORAGE_FILE_DEFAULT_PATH;
+      }
 

       // check that the path is an absolute path

       if (getenv("OS")=="Windows_NT"){

@@ -147,8 +151,7 @@ 
 	     	phpCAS::error('an absolute path is needed for PGT storage to file');

       	}

       	

-      }

-      else

+      } else

       {

       

       	if ( $path[0] != '/' ) {

@@ -186,8 +189,9 @@ 
     {

       phpCAS::traceBegin();

       // if the storage has already been initialized, return immediatly

-      if ( $this->isInitialized() )

-	return;

+      if ( $this->isInitialized() ) {
+      	return;
+      }
       // call the ancestor's method (mark as initialized)

       parent::init();

       phpCAS::traceEnd();      

main/auth/cas/lib/CAS/PGTStorage/pgt-main.php

Doc Comments +2 added lines, -2 removed lines

@@ -126,7 +126,7 @@ 
   /**

    * This method returns an error message set by PGTStorage::setErrorMessage().

    *

-   * @return an error message when set by PGTStorage::setErrorMessage(), FALSE

+   * @return boolean error message when set by PGTStorage::setErrorMessage(), FALSE

    * otherwise.

    *

    * @public

@@ -153,7 +153,7 @@ 
   /**

    * This method tells if the storage has already been intialized.

    *

-   * @return a boolean

+   * @return boolean boolean

    *

    * @protected

    */

main/auth/courses_controller.php

Doc Comments +2 added lines, -1 removed lines

@@ -33,6 +33,7 @@ 
      * render to courses_list view
      * @param string   	action
      * @param string    confirmation message(optional)
+     * @param string $action
      */
     public function courses_list($action, $message = '')
     {
@@ -79,7 +80,7 @@ 
     /**
      * It's used for listing courses with categories,
      * render to courses_categories view
-     * @param $action
+     * @param string $action
      * @param string $category_code
      * @param string $message
      * @param string $error