AccountController::changePassword() - Code Metrics - Inspection of "User: Add improvements to 2FA - refs #6162" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6217)

by Yannick

created 2025-04-22 17:21 UTC

AccountController::changePassword() F

↳ Parent: AccountController

Complexity

Conditions	27
Paths	63

Size

Total Lines	145
Code Lines	104

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	27
eloc	104
c	2
b	0
f	0
nc	63
nop	4
dl	0
loc	145
rs	3.3333

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Form\ChangePasswordType;
use Chamilo\CoreBundle\Form\ProfileType;
use Chamilo\CoreBundle\Repository\Node\IllustrationRepository;
use Chamilo\CoreBundle\Repository\Node\UserRepository;
use Chamilo\CoreBundle\ServiceHelper\UserHelper;
use Chamilo\CoreBundle\Settings\SettingsManager;
use Chamilo\CoreBundle\Traits\ControllerTrait;
use Endroid\QrCode\Builder\Builder;
use Endroid\QrCode\Encoding\Encoding;
use Endroid\QrCode\ErrorCorrectionLevel\ErrorCorrectionLevelHigh;
use Endroid\QrCode\Writer\PngWriter;
use OTPHP\TOTP;
use Security;
use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Attribute\Route;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Csrf\CsrfToken;
use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

/**
 * @author Julio Montoya <[email protected]>
 */
#[Route('/account')]
class AccountController extends BaseController
{
    use ControllerTrait;

    public function __construct(
        private readonly UserHelper $userHelper,
        private readonly TranslatorInterface $translator
    ) {}

    #[Route('/edit', name: 'chamilo_core_account_edit', methods: ['GET', 'POST'])]
    public function edit(Request $request, UserRepository $userRepository, IllustrationRepository $illustrationRepo, SettingsManager $settingsManager): Response
    {
        $user = $this->userHelper->getCurrent();

        if (!\is_object($user) || !$user instanceof UserInterface) {
            throw $this->createAccessDeniedException('This user does not have access to this section');
        }

        /** @var User $user */
        $form = $this->createForm(ProfileType::class, $user);
        $form->setData($user);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            if ($form->has('illustration')) {
                $illustration = $form['illustration']->getData();
                if ($illustration) {
                    $illustrationRepo->deleteIllustration($user);
                    $illustrationRepo->addIllustration($user, $user, $illustration);
                }
            }

            if ($form->has('password')) {
                $password = $form['password']->getData();
                if ($password) {
                    $user->setPlainPassword($password);
                }
            }

            $showTermsIfProfileCompleted = ('true' === $settingsManager->getSetting('show_terms_if_profile_completed'));
            $user->setProfileCompleted($showTermsIfProfileCompleted);

            $userRepository->updateUser($user);
            $this->addFlash('success', $this->trans('Updated'));
            $url = $this->generateUrl('chamilo_core_account_home');

            $request->getSession()->set('_locale_user', $user->getLocale());

            return new RedirectResponse($url);
        }

        return $this->render('@ChamiloCore/Account/edit.html.twig', [
            'form' => $form->createView(),
            'user' => $user,
        ]);
    }

    #[Route('/change-password', name: 'chamilo_core_account_change_password', methods: ['GET', 'POST'])]
    public function changePassword(Request $request, UserRepository $userRepository, CsrfTokenManagerInterface $csrfTokenManager, SettingsManager $settingsManager): Response
    {
        /** @var User $user */
        $user = $this->getUser();

        if (!\is_object($user) || !$user instanceof UserInterface) {
            throw $this->createAccessDeniedException('This user does not have access to this section');
        }

        $form = $this->createForm(ChangePasswordType::class, [
            'enable2FA' => $user->getMfaEnabled(),
        ]);
        $form->handleRequest($request);

        $qrCodeBase64 = null;
        $showQRCode = false;
        if ($user->getMfaEnabled() && 'TOTP' === $user->getMfaService() && $user->getMfaSecret()) {
            $decryptedSecret = $this->decryptTOTPSecret($user->getMfaSecret(), $_ENV['APP_SECRET']);
            $totp = TOTP::create($decryptedSecret);
            $portalName = $settingsManager->getSetting('platform.institution');
            $totp->setLabel($portalName . ' - '. $user->getEmail());
            $qrCodeResult = Builder::create()
                ->writer(new PngWriter())
                ->data($totp->getProvisioningUri())
                ->encoding(new Encoding('UTF-8'))
                ->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
                ->size(300)
                ->margin(10)
                ->build()
            ;

            $qrCodeBase64 = base64_encode($qrCodeResult->getString());
            $showQRCode = true;
        }

        if ($form->isSubmitted() && $form->isValid()) {
            $submittedToken = $request->request->get('_token');

            if (!$csrfTokenManager->isTokenValid(new CsrfToken('change_password', $submittedToken))) {
                $form->addError(new FormError($this->translator->trans('CSRF token is invalid. Please try again.')));
            } else {
                $currentPassword = $form->get('currentPassword')->getData();
                $newPassword = $form->get('newPassword')->getData();
                $confirmPassword = $form->get('confirmPassword')->getData();
                $enable2FA = $form->get('enable2FA')->getData();

                if ($user->getMfaEnabled()) {
                    $enteredCode = $form->get('confirm2FACode')->getData();
                    if (empty($enteredCode) || !$this->isTOTPValid($user, $enteredCode)) {
                        $form->get('confirm2FACode')->addError(new FormError('The 2FA code is invalid.'));
                        return $this->render('@ChamiloCore/Account/change_password.html.twig', [
                            'form' => $form->createView(),
                            'qrCode' => $qrCodeBase64,
                            'user' => $user,
                            'showQRCode' => $qrCodeBase64 !== null || ($form->isSubmitted() && $form->get('enable2FA')->getData()),
                        ]);
                    }
                }

                if ($enable2FA && !$user->getMfaSecret()) {
                    $session = $request->getSession();

                    if (!$session->has('temporary_mfa_secret')) {
                        $totp = TOTP::create();
                        $secret = $totp->getSecret();
                        $session->set('temporary_mfa_secret', $secret);
                    } else {
                        $secret = $session->get('temporary_mfa_secret');
                        $totp = TOTP::create($secret);
                    }

                    $portalName = $settingsManager->getSetting('platform.institution');
                    $totp->setLabel($portalName . ' - '. $user->getEmail());

                    $qrCodeResult = Builder::create()
                        ->writer(new PngWriter())
                        ->data($totp->getProvisioningUri())
                        ->encoding(new Encoding('UTF-8'))
                        ->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
                        ->size(300)
                        ->margin(10)
                        ->build()
                    ;

                    $qrCodeBase64 = base64_encode($qrCodeResult->getString());
                    $enteredCode = $form->get('confirm2FACode')->getData();

                    if (!$enteredCode) {
                        return $this->render('@ChamiloCore/Account/change_password.html.twig', [
                            'form' => $form->createView(),
                            'qrCode' => $qrCodeBase64,
                            'user' => $user,
                            'showQRCode' => true,
                        ]);
                    }

                    if (!$totp->verify($enteredCode)) {
                        $form->get('confirm2FACode')->addError(new FormError('The code is incorrect.'));
                        return $this->render('@ChamiloCore/Account/change_password.html.twig', [
                            'form' => $form->createView(),
                            'qrCode' => $qrCodeBase64,
                            'user' => $user,
                            'showQRCode' => true,
                        ]);
                    }

                    $encryptedSecret = $this->encryptTOTPSecret($secret, $_ENV['APP_SECRET']);
                    $user->setMfaSecret($encryptedSecret);
                    $user->setMfaEnabled(true);
                    $user->setMfaService('TOTP');
                    $userRepository->updateUser($user);
                    $session->remove('temporary_mfa_secret');
                    $this->addFlash('success', '2FA activated successfully.');

                    return $this->redirectToRoute('chamilo_core_account_home');
                }
                if (!$enable2FA) {
                    $user->setMfaEnabled(false);
                    $user->setMfaSecret(null);
                    $userRepository->updateUser($user);
                    $this->addFlash('success', '2FA disabled successfully.');
                }

                if ($newPassword || $confirmPassword || $currentPassword) {
                    if (!$userRepository->isPasswordValid($user, $currentPassword)) {
                        $form->get('currentPassword')->addError(new FormError($this->translator->trans('The current password is incorrect')));
                    } elseif ($newPassword !== $confirmPassword) {
                        $form->get('confirmPassword')->addError(new FormError($this->translator->trans('Passwords do not match')));
                    } else {
                        $user->setPlainPassword($newPassword);
                        $userRepository->updateUser($user);
                        $this->addFlash('success', 'Password updated successfully');
                    }
                }

                return $this->redirectToRoute('chamilo_core_account_home');
            }
        }

        return $this->render('@ChamiloCore/Account/change_password.html.twig', [
            'form' => $form->createView(),
            'qrCode' => $qrCodeBase64,
            'user' => $user,
            'showQRCode' => $qrCodeBase64 !== null || ($form->isSubmitted() && $form->get('enable2FA')->getData()),
        ]);
    }

    /**
     * Encrypts the TOTP secret using AES-256-CBC encryption.
     */
    private function encryptTOTPSecret(string $secret, string $encryptionKey): string
    {
        $cipherMethod = 'aes-256-cbc';
        $iv = openssl_random_pseudo_bytes(openssl_cipher_iv_length($cipherMethod));
        $encryptedSecret = openssl_encrypt($secret, $cipherMethod, $encryptionKey, 0, $iv);

        return base64_encode($iv.'::'.$encryptedSecret);
    }

    /**
     * Validates the provided TOTP code for the given user.
     */
    private function isTOTPValid(User $user, string $totpCode): bool
    {
        $decryptedSecret = $this->decryptTOTPSecret($user->getMfaSecret(), $_ENV['APP_SECRET']);
        $totp = TOTP::create($decryptedSecret);

        return $totp->verify($totpCode);
    }

    /**
     * Decrypts the TOTP secret using AES-256-CBC decryption.
     */
    private function decryptTOTPSecret(string $encryptedSecret, string $encryptionKey): string
    {
        $cipherMethod = 'aes-256-cbc';
        list($iv, $encryptedData) = explode('::', base64_decode($encryptedSecret), 2);

        return openssl_decrypt($encryptedData, $cipherMethod, $encryptionKey, 0, $iv);
    }

    /**
     * Validate the password against the same requirements as the client-side validation.
     */
    private function validatePassword(string $password): array

    {
        $errors = [];
        $minRequirements = Security::getPasswordRequirements()['min'];

        if (\strlen($password) < $minRequirements['length']) {
            $errors[] = $this->translator->trans('Password must be at least %length% characters long.', ['%length%' => $minRequirements['length']]);
        }
        if ($minRequirements['lowercase'] > 0 && !preg_match('/[a-z]/', $password)) {
            $errors[] = $this->translator->trans('Password must contain at least %count% lowercase characters.', ['%count%' => $minRequirements['lowercase']]);
        }
        if ($minRequirements['uppercase'] > 0 && !preg_match('/[A-Z]/', $password)) {
            $errors[] = $this->translator->trans('Password must contain at least %count% uppercase characters.', ['%count%' => $minRequirements['uppercase']]);
        }
        if ($minRequirements['numeric'] > 0 && !preg_match('/[0-9]/', $password)) {
            $errors[] = $this->translator->trans('Password must contain at least %count% numerical (0-9) characters.', ['%count%' => $minRequirements['numeric']]);
        }
        if ($minRequirements['specials'] > 0 && !preg_match('/[\W]/', $password)) {
            $errors[] = $this->translator->trans('Password must contain at least %count% special characters.', ['%count%' => $minRequirements['specials']]);
        }

        return $errors;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Controller;
8
9			use Chamilo\CoreBundle\Entity\User;
10			use Chamilo\CoreBundle\Form\ChangePasswordType;
11			use Chamilo\CoreBundle\Form\ProfileType;
12			use Chamilo\CoreBundle\Repository\Node\IllustrationRepository;
13			use Chamilo\CoreBundle\Repository\Node\UserRepository;
14			use Chamilo\CoreBundle\ServiceHelper\UserHelper;
15			use Chamilo\CoreBundle\Settings\SettingsManager;
16			use Chamilo\CoreBundle\Traits\ControllerTrait;
17			use Endroid\QrCode\Builder\Builder;
18			use Endroid\QrCode\Encoding\Encoding;
19			use Endroid\QrCode\ErrorCorrectionLevel\ErrorCorrectionLevelHigh;
20			use Endroid\QrCode\Writer\PngWriter;
21			use OTPHP\TOTP;
22			use Security;
23			use Symfony\Component\Form\FormError;
24			use Symfony\Component\HttpFoundation\RedirectResponse;
25			use Symfony\Component\HttpFoundation\Request;
26			use Symfony\Component\HttpFoundation\Response;
27			use Symfony\Component\Routing\Attribute\Route;
28			use Symfony\Component\Security\Core\User\UserInterface;
29			use Symfony\Component\Security\Csrf\CsrfToken;
30			use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
31			use Symfony\Contracts\Translation\TranslatorInterface;
32
33			/**
34			* @author Julio Montoya <[email protected]>
35			*/
36			#[Route('/account')]
37			class AccountController extends BaseController
38			{
39			use ControllerTrait;
40
41			public function __construct(
42			private readonly UserHelper $userHelper,
43			private readonly TranslatorInterface $translator
44			) {}
45
46			#[Route('/edit', name: 'chamilo_core_account_edit', methods: ['GET', 'POST'])]
47			public function edit(Request $request, UserRepository $userRepository, IllustrationRepository $illustrationRepo, SettingsManager $settingsManager): Response
48			{
49			$user = $this->userHelper->getCurrent();
50
51			if (!\is_object($user) \|\| !$user instanceof UserInterface) {
52			throw $this->createAccessDeniedException('This user does not have access to this section');
53			}
54
55			/** @var User $user */
56			$form = $this->createForm(ProfileType::class, $user);
57			$form->setData($user);
58			$form->handleRequest($request);
59
60			if ($form->isSubmitted() && $form->isValid()) {
61			if ($form->has('illustration')) {
62			$illustration = $form['illustration']->getData();
63			if ($illustration) {
64			$illustrationRepo->deleteIllustration($user);
65			$illustrationRepo->addIllustration($user, $user, $illustration);
66			}
67			}
68
69			if ($form->has('password')) {
70			$password = $form['password']->getData();
71			if ($password) {
72			$user->setPlainPassword($password);
73			}
74			}
75
76			$showTermsIfProfileCompleted = ('true' === $settingsManager->getSetting('show_terms_if_profile_completed'));
77			$user->setProfileCompleted($showTermsIfProfileCompleted);
78
79			$userRepository->updateUser($user);
80			$this->addFlash('success', $this->trans('Updated'));
81			$url = $this->generateUrl('chamilo_core_account_home');
82
83			$request->getSession()->set('_locale_user', $user->getLocale());
84
85			return new RedirectResponse($url);
86			}
87
88			return $this->render('@ChamiloCore/Account/edit.html.twig', [
89			'form' => $form->createView(),
90			'user' => $user,
91			]);
92			}
93
94			#[Route('/change-password', name: 'chamilo_core_account_change_password', methods: ['GET', 'POST'])]
95			public function changePassword(Request $request, UserRepository $userRepository, CsrfTokenManagerInterface $csrfTokenManager, SettingsManager $settingsManager): Response
96			{
97			/** @var User $user */
98			$user = $this->getUser();
99
100			if (!\is_object($user) \|\| !$user instanceof UserInterface) {
101			throw $this->createAccessDeniedException('This user does not have access to this section');
102			}
103
104			$form = $this->createForm(ChangePasswordType::class, [
105			'enable2FA' => $user->getMfaEnabled(),
106			]);
107			$form->handleRequest($request);
108
109			$qrCodeBase64 = null;
110			$showQRCode = false;
111			if ($user->getMfaEnabled() && 'TOTP' === $user->getMfaService() && $user->getMfaSecret()) {
112			$decryptedSecret = $this->decryptTOTPSecret($user->getMfaSecret(), $_ENV['APP_SECRET']);
113			$totp = TOTP::create($decryptedSecret);
114			$portalName = $settingsManager->getSetting('platform.institution');
115			$totp->setLabel($portalName . ' - '. $user->getEmail());
116			$qrCodeResult = Builder::create()
117			->writer(new PngWriter())
118			->data($totp->getProvisioningUri())
119			->encoding(new Encoding('UTF-8'))
120			->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
121			->size(300)
122			->margin(10)
123			->build()
124			;
125
126			$qrCodeBase64 = base64_encode($qrCodeResult->getString());
127			$showQRCode = true;
128			}
129
130			if ($form->isSubmitted() && $form->isValid()) {
131			$submittedToken = $request->request->get('_token');
132
133			if (!$csrfTokenManager->isTokenValid(new CsrfToken('change_password', $submittedToken))) {
134			$form->addError(new FormError($this->translator->trans('CSRF token is invalid. Please try again.')));
135			} else {
136			$currentPassword = $form->get('currentPassword')->getData();
137			$newPassword = $form->get('newPassword')->getData();
138			$confirmPassword = $form->get('confirmPassword')->getData();
139			$enable2FA = $form->get('enable2FA')->getData();
140
141			if ($user->getMfaEnabled()) {
142			$enteredCode = $form->get('confirm2FACode')->getData();
143			if (empty($enteredCode) \|\| !$this->isTOTPValid($user, $enteredCode)) {
144			$form->get('confirm2FACode')->addError(new FormError('The 2FA code is invalid.'));
145			return $this->render('@ChamiloCore/Account/change_password.html.twig', [
146			'form' => $form->createView(),
147			'qrCode' => $qrCodeBase64,
148			'user' => $user,
149			'showQRCode' => $qrCodeBase64 !== null \|\| ($form->isSubmitted() && $form->get('enable2FA')->getData()),
150			]);
151			}
152			}
153
154			if ($enable2FA && !$user->getMfaSecret()) {
155			$session = $request->getSession();
156
157			if (!$session->has('temporary_mfa_secret')) {
158			$totp = TOTP::create();
159			$secret = $totp->getSecret();
160			$session->set('temporary_mfa_secret', $secret);
161			} else {
162			$secret = $session->get('temporary_mfa_secret');
163			$totp = TOTP::create($secret);
164			}
165
166			$portalName = $settingsManager->getSetting('platform.institution');
167			$totp->setLabel($portalName . ' - '. $user->getEmail());
168
169			$qrCodeResult = Builder::create()
170			->writer(new PngWriter())
171			->data($totp->getProvisioningUri())
172			->encoding(new Encoding('UTF-8'))
173			->errorCorrectionLevel(new ErrorCorrectionLevelHigh())
174			->size(300)
175			->margin(10)
176			->build()
177			;
178
179			$qrCodeBase64 = base64_encode($qrCodeResult->getString());
180			$enteredCode = $form->get('confirm2FACode')->getData();
181
182			if (!$enteredCode) {
183			return $this->render('@ChamiloCore/Account/change_password.html.twig', [
184			'form' => $form->createView(),
185			'qrCode' => $qrCodeBase64,
186			'user' => $user,
187			'showQRCode' => true,
188			]);
189			}
190
191			if (!$totp->verify($enteredCode)) {
192			$form->get('confirm2FACode')->addError(new FormError('The code is incorrect.'));
193			return $this->render('@ChamiloCore/Account/change_password.html.twig', [
194			'form' => $form->createView(),
195			'qrCode' => $qrCodeBase64,
196			'user' => $user,
197			'showQRCode' => true,
198			]);
199			}
200
201			$encryptedSecret = $this->encryptTOTPSecret($secret, $_ENV['APP_SECRET']);
202			$user->setMfaSecret($encryptedSecret);
203			$user->setMfaEnabled(true);
204			$user->setMfaService('TOTP');
205			$userRepository->updateUser($user);
206			$session->remove('temporary_mfa_secret');
207			$this->addFlash('success', '2FA activated successfully.');
208
209			return $this->redirectToRoute('chamilo_core_account_home');
210			}
211			if (!$enable2FA) {
212			$user->setMfaEnabled(false);
213			$user->setMfaSecret(null);
214			$userRepository->updateUser($user);
215			$this->addFlash('success', '2FA disabled successfully.');
216			}
217
218			if ($newPassword \|\| $confirmPassword \|\| $currentPassword) {
219			if (!$userRepository->isPasswordValid($user, $currentPassword)) {
220			$form->get('currentPassword')->addError(new FormError($this->translator->trans('The current password is incorrect')));
221			} elseif ($newPassword !== $confirmPassword) {
222			$form->get('confirmPassword')->addError(new FormError($this->translator->trans('Passwords do not match')));
223			} else {
224			$user->setPlainPassword($newPassword);
225			$userRepository->updateUser($user);
226			$this->addFlash('success', 'Password updated successfully');
227			}
228			}
229
230			return $this->redirectToRoute('chamilo_core_account_home');
231			}
232			}
233
234			return $this->render('@ChamiloCore/Account/change_password.html.twig', [
235			'form' => $form->createView(),
236			'qrCode' => $qrCodeBase64,
237			'user' => $user,
238			'showQRCode' => $qrCodeBase64 !== null \|\| ($form->isSubmitted() && $form->get('enable2FA')->getData()),
239			]);
240			}
241
242			/**
243			* Encrypts the TOTP secret using AES-256-CBC encryption.
244			*/
245			private function encryptTOTPSecret(string $secret, string $encryptionKey): string
246			{
247			$cipherMethod = 'aes-256-cbc';
248			$iv = openssl_random_pseudo_bytes(openssl_cipher_iv_length($cipherMethod));
249			$encryptedSecret = openssl_encrypt($secret, $cipherMethod, $encryptionKey, 0, $iv);
250
251			return base64_encode($iv.'::'.$encryptedSecret);
252			}
253
254			/**
255			* Validates the provided TOTP code for the given user.
256			*/
257			private function isTOTPValid(User $user, string $totpCode): bool
258			{
259			$decryptedSecret = $this->decryptTOTPSecret($user->getMfaSecret(), $_ENV['APP_SECRET']);
260			$totp = TOTP::create($decryptedSecret);
261
262			return $totp->verify($totpCode);
263			}
264
265			/**
266			* Decrypts the TOTP secret using AES-256-CBC decryption.
267			*/
268			private function decryptTOTPSecret(string $encryptedSecret, string $encryptionKey): string
269			{
270			$cipherMethod = 'aes-256-cbc';
271			list($iv, $encryptedData) = explode('::', base64_decode($encryptedSecret), 2);
272
273			return openssl_decrypt($encryptedData, $cipherMethod, $encryptionKey, 0, $iv);
274			}
275
276			/**
277			* Validate the password against the same requirements as the client-side validation.
278			*/
279			private function validatePassword(string $password): array
			0 ignored issues – show Unused Code introduced 2024-10-02 23:28 UTC by Report Bug Copy Issue Report The method `validatePassword()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
280			{
281			$errors = [];
282			$minRequirements = Security::getPasswordRequirements()['min'];
283
284			if (\strlen($password) < $minRequirements['length']) {
285			$errors[] = $this->translator->trans('Password must be at least %length% characters long.', ['%length%' => $minRequirements['length']]);
286			}
287			if ($minRequirements['lowercase'] > 0 && !preg_match('/[a-z]/', $password)) {
288			$errors[] = $this->translator->trans('Password must contain at least %count% lowercase characters.', ['%count%' => $minRequirements['lowercase']]);
289			}
290			if ($minRequirements['uppercase'] > 0 && !preg_match('/[A-Z]/', $password)) {
291			$errors[] = $this->translator->trans('Password must contain at least %count% uppercase characters.', ['%count%' => $minRequirements['uppercase']]);
292			}
293			if ($minRequirements['numeric'] > 0 && !preg_match('/[0-9]/', $password)) {
294			$errors[] = $this->translator->trans('Password must contain at least %count% numerical (0-9) characters.', ['%count%' => $minRequirements['numeric']]);
295			}
296			if ($minRequirements['specials'] > 0 && !preg_match('/[\W]/', $password)) {
297			$errors[] = $this->translator->trans('Password must contain at least %count% special characters.', ['%count%' => $minRequirements['specials']]);
298			}
299
300			return $errors;
301			}
302			}
303

chamilo / chamilo-lms

Pull Request — master (#6217)

AccountController::changePassword() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like