UserDenormalizer::denormalize() - Code Metrics - Inspection of "Auth: Add SCIM support" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7302)

by Angel Fernando Quiroz

created 2026-01-02 21:02 UTC

UserDenormalizer::denormalize() F

↳ Parent: UserDenormalizer

Complexity

Conditions	11
Paths	640

Size

Total Lines	47
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	23
c	1
b	0
f	0
nc	640
nop	4
dl	0
loc	47
rs	3.65

How to fix Complexity

<?php

/* For licensing terms, see /license.txt */

declare(strict_types=1);

namespace Chamilo\CoreBundle\Serializer\Denormalizer\Scim;

use Chamilo\CoreBundle\Entity\User;
use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

class UserDenormalizer implements DenormalizerInterface, DenormalizerAwareInterface
{
    use DenormalizerAwareTrait;

    public const FORMAT = 'scim';
    private const ALREADY_CALLED = 'SCIM_USER_DENORMALIZER_ALREADY_CALLED';

    public function denormalize(mixed $data, string $type, ?string $format = null, array $context = [])
    {
        $context[self::ALREADY_CALLED] = true;

        $user = $context['object_to_populate'] ?? new User();

        if (isset($data['userName'])) {
            $user->setUsername($data['userName']);
        }

        if (isset($data['active'])) {
            $user->setActive((int) $data['active']);
        }

        if (isset($data['name'])) {
            $name = $data['name'];

            if (isset($name['givenName'])) {
                $user->setFirstName($name['givenName']);
            }

            if (isset($name['familyName'])) {
                $user->setLastName($name['familyName']);
            }
        }

        if ($email = self::getPrimaryValue($data, 'emails')) {
            $user->setEmail($email);
        }

        if ($phone = self::getPrimaryValue($data, 'phoneNumbers')) {
            $user->setPhone($phone);
        }

        if ($address = self::getPrimaryValue($data, 'addresses', 'formatted')) {
            $user->setAddress($address);
        }

        if (isset($data['locale'])) {
            $user->setLocale(substr($data['locale'], 0, 10));
        }

        if (isset($data['timezone'])) {
            $user->setTimezone($data['timezone']);
        }

        return $user;
    }

    public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
    {
        if (isset($context[self::ALREADY_CALLED])) {
            return false;
        }

        return User::class === $type
            && \is_array($data)
            && self::FORMAT === $format;
    }

    public function getSupportedTypes(?string $format): array
    {
        return [
            User::class => false,
        ];
    }

    public static function getPrimaryValue(array $values, string $propertyName, string $subPropertyName = 'value'): mixed
    {
        if (!isset($values[$propertyName]) || !is_array($values[$propertyName])) {
            return null;
        }

        foreach ($values[$propertyName] as $value) {
            if (!empty($value['primary']) && true === $value['primary']) {
                return $value[$subPropertyName];
            }
        }

        if (!empty($values[$propertyName][0][$subPropertyName])) {
            return $values[$propertyName][0][$subPropertyName];
        }

        return null;
    }
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			declare(strict_types=1);
6
7			namespace Chamilo\CoreBundle\Serializer\Denormalizer\Scim;
8
9			use Chamilo\CoreBundle\Entity\User;
10			use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
11			use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait;
12			use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
13
14			class UserDenormalizer implements DenormalizerInterface, DenormalizerAwareInterface
15			{
16			use DenormalizerAwareTrait;
17
18			public const FORMAT = 'scim';
19			private const ALREADY_CALLED = 'SCIM_USER_DENORMALIZER_ALREADY_CALLED';
20
21			public function denormalize(mixed $data, string $type, ?string $format = null, array $context = [])
22			{
23			$context[self::ALREADY_CALLED] = true;
24
25			$user = $context['object_to_populate'] ?? new User();
26
27			if (isset($data['userName'])) {
28			$user->setUsername($data['userName']);
29			}
30
31			if (isset($data['active'])) {
32			$user->setActive((int) $data['active']);
33			}
34
35			if (isset($data['name'])) {
36			$name = $data['name'];
37
38			if (isset($name['givenName'])) {
39			$user->setFirstName($name['givenName']);
40			}
41
42			if (isset($name['familyName'])) {
43			$user->setLastName($name['familyName']);
44			}
45			}
46
47			if ($email = self::getPrimaryValue($data, 'emails')) {
48			$user->setEmail($email);
49			}
50
51			if ($phone = self::getPrimaryValue($data, 'phoneNumbers')) {
52			$user->setPhone($phone);
53			}
54
55			if ($address = self::getPrimaryValue($data, 'addresses', 'formatted')) {
56			$user->setAddress($address);
57			}
58
59			if (isset($data['locale'])) {
60			$user->setLocale(substr($data['locale'], 0, 10));
61			}
62
63			if (isset($data['timezone'])) {
64			$user->setTimezone($data['timezone']);
65			}
66
67			return $user;
68			}
69
70			public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
71			{
72			if (isset($context[self::ALREADY_CALLED])) {
73			return false;
74			}
75
76			return User::class === $type
77			&& \is_array($data)
78			&& self::FORMAT === $format;
79			}
80
81			public function getSupportedTypes(?string $format): array
82			{
83			return [
84			User::class => false,
85			];
86			}
87
88			public static function getPrimaryValue(array $values, string $propertyName, string $subPropertyName = 'value'): mixed
89			{
90			if (!isset($values[$propertyName]) \|\| !is_array($values[$propertyName])) {
91			return null;
92			}
93
94			foreach ($values[$propertyName] as $value) {
95			if (!empty($value['primary']) && true === $value['primary']) {
96			return $value[$subPropertyName];
97			}
98			}
99
100			if (!empty($values[$propertyName][0][$subPropertyName])) {
101			return $values[$propertyName][0][$subPropertyName];
102			}
103
104			return null;
105			}
106			}
107

chamilo / chamilo-lms

Pull Request — master (#7302)

UserDenormalizer::denormalize() F

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like