| Conditions | 23 |
| Paths | > 20000 |
| Total Lines | 159 |
| Code Lines | 122 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 161 | public function get_php_data() |
||
| 162 | { |
||
| 163 | $array = array(); |
||
| 164 | |||
| 165 | // General Functions |
||
| 166 | |||
| 167 | $version = phpversion(); |
||
| 168 | $status = $version > REQUIRED_PHP_VERSION ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 169 | $array[] = $this->build_setting($status, '[PHP]', 'phpversion()', 'http://www.php.net/manual/en/function.phpversion.php', phpversion(), '>= '.REQUIRED_PHP_VERSION, null, get_lang('PHPVersionInfo')); |
||
| 170 | |||
| 171 | $setting = ini_get('output_buffering'); |
||
| 172 | $req_setting = 1; |
||
| 173 | $status = $setting >= $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 174 | $array[] = $this->build_setting($status, '[INI]', 'output_buffering', 'http://www.php.net/manual/en/outcontrol.configuration.php#ini.output-buffering', $setting, $req_setting, 'on_off', get_lang('OutputBufferingInfo')); |
||
| 175 | |||
| 176 | $setting = ini_get('file_uploads'); |
||
| 177 | $req_setting = 1; |
||
| 178 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 179 | $array[] = $this->build_setting($status, '[INI]', 'file_uploads', 'http://www.php.net/manual/en/ini.core.php#ini.file-uploads', $setting, $req_setting, 'on_off', get_lang('FileUploadsInfo')); |
||
| 180 | |||
| 181 | $setting = ini_get('magic_quotes_runtime'); |
||
| 182 | $req_setting = 0; |
||
| 183 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 184 | $array[] = $this->build_setting($status, '[INI]', 'magic_quotes_runtime', 'http://www.php.net/manual/en/ini.core.php#ini.magic-quotes-runtime', $setting, $req_setting, 'on_off', get_lang('MagicQuotesRuntimeInfo')); |
||
| 185 | |||
| 186 | $setting = ini_get('safe_mode'); |
||
| 187 | $req_setting = 0; |
||
| 188 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 189 | $array[] = $this->build_setting($status, '[INI]', 'safe_mode', 'http://www.php.net/manual/en/ini.core.php#ini.safe-mode', $setting, $req_setting, 'on_off', get_lang('SafeModeInfo')); |
||
| 190 | |||
| 191 | $setting = ini_get('register_globals'); |
||
| 192 | $req_setting = 0; |
||
| 193 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 194 | $array[] = $this->build_setting($status, '[INI]', 'register_globals', 'http://www.php.net/manual/en/ini.core.php#ini.register-globals', $setting, $req_setting, 'on_off', get_lang('RegisterGlobalsInfo')); |
||
| 195 | |||
| 196 | $setting = ini_get('short_open_tag'); |
||
| 197 | $req_setting = 0; |
||
| 198 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 199 | $array[] = $this->build_setting($status, '[INI]', 'short_open_tag', 'http://www.php.net/manual/en/ini.core.php#ini.short-open-tag', $setting, $req_setting, 'on_off', get_lang('ShortOpenTagInfo')); |
||
| 200 | |||
| 201 | $setting = ini_get('magic_quotes_gpc'); |
||
| 202 | $req_setting = 0; |
||
| 203 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 204 | $array[] = $this->build_setting($status, '[INI]', 'magic_quotes_gpc', 'http://www.php.net/manual/en/ini.core.php#ini.magic_quotes_gpc', $setting, $req_setting, 'on_off', get_lang('MagicQuotesGpcInfo')); |
||
| 205 | |||
| 206 | $setting = ini_get('display_errors'); |
||
| 207 | $req_setting = 0; |
||
| 208 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 209 | $array[] = $this->build_setting($status, '[INI]', 'display_errors', 'http://www.php.net/manual/en/ini.core.php#ini.display_errors', $setting, $req_setting, 'on_off', get_lang('DisplayErrorsInfo')); |
||
| 210 | |||
| 211 | $setting = ini_get('default_charset'); |
||
| 212 | if ($setting == '') |
||
| 213 | $setting = null; |
||
| 214 | $req_setting = null; |
||
| 215 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 216 | $array[] = $this->build_setting($status, '[INI]', 'default_charset', 'http://www.php.net/manual/en/ini.core.php#ini.default-charset', $setting, $req_setting, null, get_lang('DefaultCharsetInfo')); |
||
| 217 | |||
| 218 | $setting = ini_get('max_execution_time'); |
||
| 219 | $req_setting = '300 (' . get_lang('Minimum') . ')'; |
||
| 220 | $status = $setting >= 300 ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 221 | $array[] = $this->build_setting($status, '[INI]', 'max_execution_time', 'http://www.php.net/manual/en/ini.core.php#ini.max-execution-time', $setting, $req_setting, null, get_lang('MaxExecutionTimeInfo')); |
||
| 222 | |||
| 223 | $setting = ini_get('max_input_time'); |
||
| 224 | $req_setting = '300 (' . get_lang('Minimum') . ')'; |
||
| 225 | $status = $setting >= 300 ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 226 | $array[] = $this->build_setting($status, '[INI]', 'max_input_time', 'http://www.php.net/manual/en/ini.core.php#ini.max-input-time', $setting, $req_setting, null, get_lang('MaxInputTimeInfo')); |
||
| 227 | |||
| 228 | $setting = ini_get('memory_limit'); |
||
| 229 | $req_setting = '>= '.REQUIRED_MIN_MEMORY_LIMIT.'M'; |
||
| 230 | $status = self :: STATUS_ERROR; |
||
| 231 | if ((float)$setting >= REQUIRED_MIN_MEMORY_LIMIT) |
||
| 232 | $status = self :: STATUS_OK; |
||
| 233 | $array[] = $this->build_setting($status, '[INI]', 'memory_limit', 'http://www.php.net/manual/en/ini.core.php#ini.memory-limit', $setting, $req_setting, null, get_lang('MemoryLimitInfo')); |
||
| 234 | |||
| 235 | $setting = ini_get('post_max_size'); |
||
| 236 | $req_setting = '>= '.REQUIRED_MIN_POST_MAX_SIZE.'M'; |
||
| 237 | $status = self :: STATUS_ERROR; |
||
| 238 | if ((float)$setting >= REQUIRED_MIN_POST_MAX_SIZE) |
||
| 239 | $status = self :: STATUS_OK; |
||
| 240 | $array[] = $this->build_setting($status, '[INI]', 'post_max_size', 'http://www.php.net/manual/en/ini.core.php#ini.post-max-size', $setting, $req_setting, null, get_lang('PostMaxSizeInfo')); |
||
| 241 | |||
| 242 | $setting = ini_get('upload_max_filesize'); |
||
| 243 | $req_setting = '>= '.REQUIRED_MIN_UPLOAD_MAX_FILESIZE.'M'; |
||
| 244 | $status = self :: STATUS_ERROR; |
||
| 245 | if ((float)$setting >= REQUIRED_MIN_UPLOAD_MAX_FILESIZE) |
||
| 246 | $status = self :: STATUS_OK; |
||
| 247 | $array[] = $this->build_setting($status, '[INI]', 'upload_max_filesize', 'http://www.php.net/manual/en/ini.core.php#ini.upload_max_filesize', $setting, $req_setting, null, get_lang('UploadMaxFilesizeInfo')); |
||
| 248 | |||
| 249 | $setting = ini_get('variables_order'); |
||
| 250 | $req_setting = 'GPCS'; |
||
| 251 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 252 | $array[] = $this->build_setting($status, '[INI]', 'variables_order', 'http://www.php.net/manual/en/ini.core.php#ini.variables-order', $setting, $req_setting, null, get_lang('VariablesOrderInfo')); |
||
| 253 | |||
| 254 | $setting = ini_get('session.gc_maxlifetime'); |
||
| 255 | $req_setting = '4320'; |
||
| 256 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 257 | $array[] = $this->build_setting($status, '[SESSION]', 'session.gc_maxlifetime', 'http://www.php.net/manual/en/ini.core.php#session.gc-maxlifetime', $setting, $req_setting, null, get_lang('SessionGCMaxLifetimeInfo')); |
||
| 258 | |||
| 259 | if (api_check_browscap()){$setting = true;}else{$setting=false;} |
||
| 260 | $req_setting = true; |
||
| 261 | $status = $setting == $req_setting ? self :: STATUS_OK : self :: STATUS_WARNING; |
||
| 262 | $array[] = $this->build_setting($status, '[INI]', 'browscap', 'http://www.php.net/manual/en/misc.configuration.php#ini.browscap', $setting, $req_setting, 'on_off', get_lang('BrowscapInfo')); |
||
| 263 | |||
| 264 | // Extensions |
||
| 265 | $extensions = array( |
||
| 266 | 'gd' => array( |
||
| 267 | 'link' => 'http://www.php.net/gd', |
||
| 268 | 'expected' => 1, |
||
| 269 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 270 | ), |
||
| 271 | 'mysql' => array( |
||
| 272 | 'link' => 'http://www.php.net/mysql', |
||
| 273 | 'expected' => 1, |
||
| 274 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 275 | ), |
||
| 276 | 'pcre' => array( |
||
| 277 | 'link' => 'http://www.php.net/pcre', |
||
| 278 | 'expected' => 1, |
||
| 279 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 280 | ), |
||
| 281 | 'session' => array( |
||
| 282 | 'link' => 'http://www.php.net/session', |
||
| 283 | 'expected' => 1, |
||
| 284 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 285 | ), |
||
| 286 | 'standard' => array( |
||
| 287 | 'link' => 'http://www.php.net/spl', |
||
| 288 | 'expected' => 1, |
||
| 289 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 290 | ), |
||
| 291 | 'zlib' => array( |
||
| 292 | 'link' => 'http://www.php.net/zlib', |
||
| 293 | 'expected' => 1, |
||
| 294 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 295 | ), |
||
| 296 | 'xsl' => array( |
||
| 297 | 'link' => 'http://be2.php.net/xsl', |
||
| 298 | 'expected' => 2, |
||
| 299 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 300 | ), |
||
| 301 | 'curl' => array( |
||
| 302 | 'link' => 'http://www.php.net/curl', |
||
| 303 | 'expected' => 2, |
||
| 304 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 305 | ), |
||
| 306 | ); |
||
| 307 | |||
| 308 | foreach ($extensions as $extension => $data) { |
||
| 309 | $url = $data['link']; |
||
| 310 | $expected_value = $data['expected']; |
||
| 311 | $comment = $data['comment']; |
||
| 312 | |||
| 313 | $loaded = extension_loaded($extension); |
||
| 314 | $status = $loaded ? self :: STATUS_OK : self :: STATUS_ERROR; |
||
| 315 | $array[] = $this->build_setting($status, '[EXTENSION]', get_lang('LoadedExtension') . ': ' . $extension, $url, $loaded, $expected_value, 'yes_no_optional', $comment); |
||
| 316 | } |
||
| 317 | |||
| 318 | return $array; |
||
| 319 | } |
||
| 320 | |||
| 492 |
This checks looks for assignemnts to variables using the
list(...)function, where not all assigned variables are subsequently used.Consider the following code example.
Only the variables
$aand$care used. There was no need to assign$b.Instead, the list call could have been.