learnpathItem::set_terms()

Complexity

Conditions	4
Paths	6

Size

Total Lines	27
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function set_terms($terms)
    {
        global $charset;
        $course_id = api_get_course_int_id();
        $lp_item = Database::get_course_table(TABLE_LP_ITEM);
        $a_terms = preg_split('/,/', $terms);
        $i_terms = preg_split('/,/', $this->get_terms());
        foreach ($i_terms as $term) {
            if (!in_array($term, $a_terms)) {

It seems like $a_terms can also be of type false; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

                array_push($a_terms, $term);

It seems like $a_terms can also be of type false; however, parameter $array of array_push() does only seem to accept array, maybe add an additional type check?

            }
        }
        $new_terms = $a_terms;
        $new_terms_string = implode(',', $new_terms);

It seems like $new_terms can also be of type false; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

        // TODO: Validate csv string.
        $terms = Database::escape_string(api_htmlentities($new_terms_string, ENT_QUOTES, $charset));
        $sql = "UPDATE $lp_item
                SET terms = '$terms'
                WHERE iid=".$this->get_id();
        Database::query($sql);
        // Save it to search engine.
        if (api_get_setting('search_enabled') == 'true') {
            $di = new ChamiloIndexer();
            $di->update_terms($this->get_search_did(), $new_terms, 'T');

It seems like $new_terms can also be of type false; however, parameter $terms of XapianIndexer::update_terms() does only seem to accept array, maybe add an additional type check?

        }
        return true;
    }