GroupRepository::createDefaultGroups() - Code Metrics - Inspection of "Fix migration" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 619086...47480f )

by Julito

created 2021-06-09 10:43 UTC

GroupRepository::createDefaultGroups() B

↳ Parent: GroupRepository

Complexity

Conditions	5
Paths	6

Size

Total Lines	71
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	41
c	2
b	0
f	0
nc	6
nop	1
dl	0
loc	71
rs	8.9528

How to fix Long Method

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Repository;

use Chamilo\CoreBundle\DataFixtures\AccessGroupFixtures;
use Chamilo\CoreBundle\Entity\Group;
use Chamilo\CoreBundle\Entity\User;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

class GroupRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Group::class);
    }

    /**
     * @return User[]
     */
    public function getAdmins()
    {
        $criteria = [
            'name' => 'admins',
        ];
        /** @var Group $group */
        $group = $this->findOneBy($criteria);

        return $group->getUsers();
    }

    public function createDefaultGroups(AccessGroupFixtures $accessGroupFixtures = null): void
    {
        $groups = [
            [
                'code' => 'ADMIN',
                'title' => 'Administrators',
                'roles' => ['ROLE_ADMIN'],
            ],
            [
                'code' => 'STUDENT',
                'title' => 'Students',
                'roles' => ['ROLE_STUDENT'],
            ],
            [
                'code' => 'TEACHER',
                'title' => 'Teachers',
                'roles' => ['ROLE_TEACHER'],
            ],
            [
                'code' => 'RRHH',
                'title' => 'Human resources manager',
                'roles' => ['ROLE_RRHH'],
            ],
            [
                'code' => 'SESSION_MANAGER',
                'title' => 'Session',
                'roles' => ['ROLE_SESSION_MANAGER'],
            ],
            [
                'code' => 'QUESTION_MANAGER',
                'title' => 'Question manager',
                'roles' => ['ROLE_QUESTION_MANAGER'],
            ],
            [
                'code' => 'STUDENT_BOSS',
                'title' => 'Student boss',
                'roles' => ['ROLE_STUDENT_BOSS'],
            ],
            [
                'code' => 'INVITEE',
                'title' => 'Invitee',
                'roles' => ['ROLE_INVITEE'],
            ],
        ];

        $manager = $this->getEntityManager();

        $repo = $manager->getRepository(Group::class);
        foreach ($groups as $groupData) {
            $criteria = [
                'code' => $groupData['code'],
            ];
            $groupExists = $repo->findOneBy($criteria);
            if (!$groupExists) {
                $group = new Group($groupData['title']);
                $group
                    ->setCode($groupData['code'])
                ;

                foreach ($groupData['roles'] as $role) {
                    $group->addRole($role);
                }
                $manager->persist($group);

                if (null !== $accessGroupFixtures) {
                    $accessGroupFixtures->addReference('GROUP_'.$groupData['code'], $group);
                }
            }
        }

        $manager->flush();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Repository;
8
9			use Chamilo\CoreBundle\DataFixtures\AccessGroupFixtures;
10			use Chamilo\CoreBundle\Entity\Group;
11			use Chamilo\CoreBundle\Entity\User;
12			use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
13			use Doctrine\Persistence\ManagerRegistry;
14
15			class GroupRepository extends ServiceEntityRepository
16			{
17			public function __construct(ManagerRegistry $registry)
18			{
19			parent::__construct($registry, Group::class);
20			}
21
22			/**
23			* @return User[]
24			*/
25			public function getAdmins()
26			{
27			$criteria = [
28			'name' => 'admins',
29			];
30			/** @var Group $group */
31			$group = $this->findOneBy($criteria);
32
33			return $group->getUsers();
34			}
35
36			public function createDefaultGroups(AccessGroupFixtures $accessGroupFixtures = null): void
37			{
38			$groups = [
39			[
40			'code' => 'ADMIN',
41			'title' => 'Administrators',
42			'roles' => ['ROLE_ADMIN'],
43			],
44			[
45			'code' => 'STUDENT',
46			'title' => 'Students',
47			'roles' => ['ROLE_STUDENT'],
48			],
49			[
50			'code' => 'TEACHER',
51			'title' => 'Teachers',
52			'roles' => ['ROLE_TEACHER'],
53			],
54			[
55			'code' => 'RRHH',
56			'title' => 'Human resources manager',
57			'roles' => ['ROLE_RRHH'],
58			],
59			[
60			'code' => 'SESSION_MANAGER',
61			'title' => 'Session',
62			'roles' => ['ROLE_SESSION_MANAGER'],
63			],
64			[
65			'code' => 'QUESTION_MANAGER',
66			'title' => 'Question manager',
67			'roles' => ['ROLE_QUESTION_MANAGER'],
68			],
69			[
70			'code' => 'STUDENT_BOSS',
71			'title' => 'Student boss',
72			'roles' => ['ROLE_STUDENT_BOSS'],
73			],
74			[
75			'code' => 'INVITEE',
76			'title' => 'Invitee',
77			'roles' => ['ROLE_INVITEE'],
78			],
79			];
80
81			$manager = $this->getEntityManager();
82
83			$repo = $manager->getRepository(Group::class);
84			foreach ($groups as $groupData) {
85			$criteria = [
86			'code' => $groupData['code'],
87			];
88			$groupExists = $repo->findOneBy($criteria);
89			if (!$groupExists) {
90			$group = new Group($groupData['title']);
91			$group
92			->setCode($groupData['code'])
93			;
94
95			foreach ($groupData['roles'] as $role) {
96			$group->addRole($role);
97			}
98			$manager->persist($group);
99
100			if (null !== $accessGroupFixtures) {
101			$accessGroupFixtures->addReference('GROUP_'.$groupData['code'], $group);
102			}
103			}
104			}
105
106			$manager->flush();
107			}
108			}
109

chamilo / chamilo-lms

Push — master ( 619086...47480f )

GroupRepository::createDefaultGroups() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like