Passed
Push — 1.10.x ( a2cc02...b21e58 )
by Yannick
608:36 queued 565:17
created
main/inc/lib/gradebook.lib.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         $c_id = $c_id ? intval($c_id) : api_get_course_int_id();
59
-        $table  = Database::get_course_table(TABLE_TOOL_LIST);
59
+        $table = Database::get_course_table(TABLE_TOOL_LIST);
60 60
         $sql = "SELECT * from $table
61 61
                 WHERE c_id = $c_id and name='$name'
62 62
                 LIMIT 1";
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $clean_gradebook = array();
114 114
 
115 115
         if (!empty($skill_gradebooks_source)) {
116
-            foreach($skill_gradebooks_source as $source) {
116
+            foreach ($skill_gradebooks_source as $source) {
117 117
                 $clean_gradebook[] = $source['skill_id'];
118 118
             }
119 119
         }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
         $selected_skills = self::get_skills_by_gradebook($gradebook_id);
193 193
         $clean_selected_skills = array();
194 194
         if (!empty($selected_skills)) {
195
-            foreach($selected_skills as $skill) {
195
+            foreach ($selected_skills as $skill) {
196 196
                 $clean_selected_skills[] = $skill['id'];
197 197
             }
198 198
         }
Please login to merge, or discard this patch.
main/inc/lib/database.lib.php 1 patch
Spacing   +18 added lines, -19 removed lines patch added patch discarded remove patch
@@ -115,8 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public static function getUTCDateTimeTypeClass()
117 117
     {
118
-        return isset(self::$utcDateTimeClass) ? self::$utcDateTimeClass :
119
-        'Application\DoctrineExtensions\DBAL\Types\UTCDateTimeType';
118
+        return isset(self::$utcDateTimeClass) ? self::$utcDateTimeClass : 'Application\DoctrineExtensions\DBAL\Types\UTCDateTimeType';
120 119
     }
121 120
 
122 121
     /**
@@ -393,7 +392,7 @@  discard block
 block discarded – undo
393 392
 
394 393
         if (!empty($params)) {
395 394
             $sql = 'INSERT INTO '.$table_name.' ('.implode(',', $params).')
396
-                    VALUES (:'.implode(', :' ,$params).')';
395
+                    VALUES (:'.implode(', :', $params).')';
397 396
 
398 397
             $statement = self::getManager()->getConnection()->prepare($sql);
399 398
             $result = $statement->execute($attributes);
@@ -434,7 +433,7 @@  discard block
 block discarded – undo
434 433
             foreach ($attributes as $key => $value) {
435 434
                 $update_sql .= "$key = :$key ";
436 435
                 if ($count < count($attributes)) {
437
-                    $update_sql.=', ';
436
+                    $update_sql .= ', ';
438 437
                 }
439 438
                 $count++;
440 439
             }
@@ -481,7 +480,7 @@  discard block
 block discarded – undo
481 480
             if ($columns == '*') {
482 481
                 $clean_columns = '*';
483 482
             } else {
484
-                $clean_columns = (string)$columns;
483
+                $clean_columns = (string) $columns;
485 484
             }
486 485
         }
487 486
 
@@ -527,9 +526,9 @@  discard block
 block discarded – undo
527 526
                     foreach ($condition_data as $condition => $value_array) {
528 527
                         if (is_array($value_array)) {
529 528
                             $clean_values = array();
530
-                            foreach($value_array as $item) {
529
+                            foreach ($value_array as $item) {
531 530
                                 $item = Database::escape_string($item);
532
-                                $clean_values[]= $item;
531
+                                $clean_values[] = $item;
533 532
                             }
534 533
                         } else {
535 534
                             $value_array = Database::escape_string($value_array);
@@ -537,23 +536,23 @@  discard block
 block discarded – undo
537 536
                         }
538 537
 
539 538
                         if (!empty($condition) && $clean_values != '') {
540
-                            $condition = str_replace('%',"'@percentage@'", $condition); //replace "%"
541
-                            $condition = str_replace("'?'","%s", $condition);
542
-                            $condition = str_replace("?","%s", $condition);
539
+                            $condition = str_replace('%', "'@percentage@'", $condition); //replace "%"
540
+                            $condition = str_replace("'?'", "%s", $condition);
541
+                            $condition = str_replace("?", "%s", $condition);
543 542
 
544
-                            $condition = str_replace("@%s@","@-@", $condition);
545
-                            $condition = str_replace("%s","'%s'", $condition);
546
-                            $condition = str_replace("@-@","@%s@", $condition);
543
+                            $condition = str_replace("@%s@", "@-@", $condition);
544
+                            $condition = str_replace("%s", "'%s'", $condition);
545
+                            $condition = str_replace("@-@", "@%s@", $condition);
547 546
 
548 547
                             // Treat conditions as string
549 548
                             $condition = vsprintf($condition, $clean_values);
550
-                            $condition = str_replace('@percentage@','%', $condition); //replace "%"
549
+                            $condition = str_replace('@percentage@', '%', $condition); //replace "%"
551 550
                             $where_return .= $condition;
552 551
                         }
553 552
                     }
554 553
 
555 554
                     if (!empty($where_return)) {
556
-                        $return_value = " WHERE $where_return" ;
555
+                        $return_value = " WHERE $where_return";
557 556
                     }
558 557
                     break;
559 558
                 case 'order':
@@ -565,7 +564,7 @@  discard block
 block discarded – undo
565 564
                         $new_order_array = explode(',', $order_array);
566 565
                         $temp_value = array();
567 566
 
568
-                        foreach($new_order_array as $element) {
567
+                        foreach ($new_order_array as $element) {
569 568
                             $element = explode(' ', $element);
570 569
                             $element = array_filter($element);
571 570
                             $element = array_values($element);
@@ -576,10 +575,10 @@  discard block
 block discarded – undo
576 575
                                 if (in_array($element[1], array('desc', 'asc'))) {
577 576
                                     $order = $element[1];
578 577
                                 }
579
-                                $temp_value[]= $element[0].' '.$order.' ';
578
+                                $temp_value[] = $element[0].' '.$order.' ';
580 579
                             } else {
581 580
                                 //by default DESC
582
-                                $temp_value[]= $element[0].' DESC ';
581
+                                $temp_value[] = $element[0].' DESC ';
583 582
                             }
584 583
                         }
585 584
                         if (!empty($temp_value)) {
@@ -594,7 +593,7 @@  discard block
 block discarded – undo
594 593
                     if (!empty($limit_array)) {
595 594
                         if (count($limit_array) > 1) {
596 595
                             $return_value .= ' LIMIT '.intval($limit_array[0]).' , '.intval($limit_array[1]);
597
-                        }  else {
596
+                        } else {
598 597
                             $return_value .= ' LIMIT '.intval($limit_array[0]);
599 598
                         }
600 599
                     }
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/svg-editor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
  * @since 25/september/2010
6 6
  */
7 7
 
8
-require_once '../../../inc/global.inc.php';//hack for Chamilo
8
+require_once '../../../inc/global.inc.php'; //hack for Chamilo
9 9
 api_protect_course_script();
10 10
 api_block_anonymous_users();
11 11
 if (!isset($_SESSION['draw_dir'])) {
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/savefile_config.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -19,21 +19,21 @@  discard block
 block discarded – undo
19 19
 api_protect_course_script();
20 20
 api_block_anonymous_users();
21 21
 
22
-if(!isset($_POST['output_svg']) && !isset($_POST['output_png'])) {
23
-    api_not_allowed();//from Chamilo
22
+if (!isset($_POST['output_svg']) && !isset($_POST['output_png'])) {
23
+    api_not_allowed(); //from Chamilo
24 24
     die();
25 25
 }
26 26
 
27 27
 $file = '';
28
-$suffix = isset($_POST['output_svg'])?'svg':'png';
28
+$suffix = isset($_POST['output_svg']) ? 'svg' : 'png';
29 29
 
30
-if(isset($_POST['filename']) && strlen($_POST['filename']) > 0) {
30
+if (isset($_POST['filename']) && strlen($_POST['filename']) > 0) {
31 31
     $file = $_POST['filename'];
32 32
 } else {
33 33
     $file = 'image';
34 34
 }
35 35
 
36
-if($suffix == 'svg') {
36
+if ($suffix == 'svg') {
37 37
     $mime = 'image/svg+xml';
38 38
     $contents = rawurldecode($_POST['output_svg']);
39 39
 } else {
@@ -44,25 +44,25 @@  discard block
 block discarded – undo
44 44
 }
45 45
 
46 46
 //get SVG-Edit values
47
-$filename=$file;//from svg-edit
48
-$extension=$suffix;// from svg-edit
49
-$content=$contents;//from svg-edit
47
+$filename = $file; //from svg-edit
48
+$extension = $suffix; // from svg-edit
49
+$content = $contents; //from svg-edit
50 50
 
51
-$title = Database::escape_string(str_replace('_',' ',$filename));
51
+$title = Database::escape_string(str_replace('_', ' ', $filename));
52 52
 
53 53
 //get Chamilo variables
54 54
 
55
-if(!isset($_SESSION['draw_dir']) && !isset($_SESSION['whereami'])) {
56
-    api_not_allowed();//from Chamilo
55
+if (!isset($_SESSION['draw_dir']) && !isset($_SESSION['whereami'])) {
56
+    api_not_allowed(); //from Chamilo
57 57
     die();
58 58
 }
59 59
 
60 60
 $current_session_id = api_get_session_id();
61
-$groupId    =  api_get_group_id();
62
-$relativeUrlPath=$_SESSION['draw_dir'];
63
-$currentTool=$_SESSION['whereami'];
61
+$groupId    = api_get_group_id();
62
+$relativeUrlPath = $_SESSION['draw_dir'];
63
+$currentTool = $_SESSION['whereami'];
64 64
 $dirBaseDocuments = api_get_path(SYS_COURSE_PATH).$_course['path'].'/document';
65
-$saveDir=$dirBaseDocuments.$_SESSION['draw_dir'];
65
+$saveDir = $dirBaseDocuments.$_SESSION['draw_dir'];
66 66
 
67 67
 //a bit title security
68 68
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 */
96 96
 
97 97
 //checks if the file exists, then rename the new
98
-if (file_exists($saveDir.'/'.$filename.$i.'.'.$extension) && $currentTool=='document/createdraw') {
98
+if (file_exists($saveDir.'/'.$filename.$i.'.'.$extension) && $currentTool == 'document/createdraw') {
99 99
     $message = get_lang('FileExistsChangeToSave');
100 100
     $params = array(
101 101
         'message' => $message,
@@ -111,21 +111,21 @@  discard block
 block discarded – undo
111 111
 $documentPath = $saveDir.'/'.$drawFileName;
112 112
 
113 113
 //add new document to disk
114
-file_put_contents( $documentPath, $contents );
114
+file_put_contents($documentPath, $contents);
115 115
 
116
-if ($currentTool=='document/createdraw') {
116
+if ($currentTool == 'document/createdraw') {
117 117
     //add document to database
118 118
     $doc_id = add_document($_course, $relativeUrlPath.'/'.$drawFileName, 'file', filesize($documentPath), $title);
119 119
     api_item_property_update($_course, TOOL_DOCUMENT, $doc_id, 'DocumentAdded', $_user['user_id'], $groupId, null, null, null, $current_session_id);
120 120
 
121
-} elseif($currentTool=='document/editdraw') {
121
+} elseif ($currentTool == 'document/editdraw') {
122 122
 
123 123
     //check path
124
-    if (!isset($_SESSION['draw_file'])){
125
-        api_not_allowed();//from Chamilo
124
+    if (!isset($_SESSION['draw_file'])) {
125
+        api_not_allowed(); //from Chamilo
126 126
         die();
127 127
     }
128
-    if ($_SESSION['draw_file'] == $drawFileName ){
128
+    if ($_SESSION['draw_file'] == $drawFileName) {
129 129
         $document_id = DocumentManager::get_document_id($_course, $relativeUrlPath.'/'.$drawFileName);
130 130
         update_existing_document($_course, $document_id, filesize($documentPath), null);
131 131
         api_item_property_update($_course, TOOL_DOCUMENT, $document_id, 'DocumentUpdated', $_user['user_id'], $groupId, null, null, null, $current_session_id);
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/fileopen.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 		if (!in_array($info['mime'], $allowedMimeTypesBySuffix)) {
32 32
 			exit;
33 33
 		}
34
-		$prefix = 'data:' . $info['mime'] . ';base64,';
34
+		$prefix = 'data:'.$info['mime'].';base64,';
35 35
 	}
36 36
 ?>
37 37
 <html xmlns="http://www.w3.org/1999/xhtml">
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 top.svgEditor.processFile("<?php
43 43
 
44 44
 // This should be safe since SVG edit does its own filtering (e.g., if an SVG file contains scripts)
45
-echo $prefix . base64_encode($output);
45
+echo $prefix.base64_encode($output);
46 46
 
47 47
 ?>", "<?php echo $type; ?>");
48 48
 </script>
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/filesave.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -9,12 +9,12 @@  discard block
 block discarded – undo
9 9
  *
10 10
  */
11 11
 exit;
12
-function encodeRFC5987ValueChars ($str) {
12
+function encodeRFC5987ValueChars($str) {
13 13
 	// See http://tools.ietf.org/html/rfc5987#section-3.2.1
14 14
 	// For better readability within headers, add back the characters escaped by rawurlencode but still allowable
15 15
 	// Although RFC3986 reserves "!" (%21), RFC5987 does not
16
-	return preg_replace_callback('@%(2[1346B]|5E|60|7C)@', function ($matches) {
17
-		return chr('0x' . $matches[1]);
16
+	return preg_replace_callback('@%(2[1346B]|5E|60|7C)@', function($matches) {
17
+		return chr('0x'.$matches[1]);
18 18
 	}, rawurlencode($str));
19 19
 }
20 20
 
@@ -28,12 +28,12 @@  discard block
 block discarded – undo
28 28
 
29 29
 $file = '';
30 30
 
31
-$suffix = '.' . array_search($mime, $allowedMimeTypesBySuffix);
31
+$suffix = '.'.array_search($mime, $allowedMimeTypesBySuffix);
32 32
 
33 33
 if (isset($_POST['filename']) && strlen($_POST['filename']) > 0) {
34
-	$file = $_POST['filename'] . $suffix;
34
+	$file = $_POST['filename'].$suffix;
35 35
 } else {
36
-	$file = 'image' . $suffix;
36
+	$file = 'image'.$suffix;
37 37
 }
38 38
 
39 39
 if ($suffix == '.svg') {
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
 header("Content-Description: File Transfer");
49 49
 
50 50
 // See http://tools.ietf.org/html/rfc6266#section-4.1
51
-header("Content-Disposition: attachment; filename*=UTF-8''" . encodeRFC5987ValueChars(
51
+header("Content-Disposition: attachment; filename*=UTF-8''".encodeRFC5987ValueChars(
52 52
 	// preg_replace('@[\\\\/:*?"<>|]@', '', $file) // If we wanted to strip Windows-disallowed characters server-side (but not a security issue, so we can strip client-side instead)
53 53
 	$file
54 54
 ));
55
-header("Content-Type: " .  $mime);
55
+header("Content-Type: ".$mime);
56 56
 header("Content-Transfer-Encoding: binary");
57 57
 
58 58
 echo $contents;
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/savefile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 		exit;
9 9
 	}
10 10
 	$svg = $_POST['output_svg'];
11
-	$filename = (isset($_POST['filename']) && !empty($_POST['filename']) ? preg_replace('@[\\\\/:*?"<>|]@u', '_', $_POST['filename']) : 'saved') . '.svg'; // These characters are indicated as prohibited by Windows
11
+	$filename = (isset($_POST['filename']) && !empty($_POST['filename']) ? preg_replace('@[\\\\/:*?"<>|]@u', '_', $_POST['filename']) : 'saved').'.svg'; // These characters are indicated as prohibited by Windows
12 12
 
13 13
 	$fh = fopen($filename, 'w') or die("Can't open file");
14 14
 	fwrite($fh, $svg);
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/imagelib/index.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 
13 13
 $is_allowed_to_edit = api_is_allowed_to_edit(null, true);
14 14
 
15
-$curdirpath='/images/gallery'; //path of library directory
15
+$curdirpath = '/images/gallery'; //path of library directory
16 16
 
17 17
 $course_info = api_get_course_info();
18 18
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 		$slideshow_extension = strrchr($file, '.');
37 37
 		$slideshow_extension = strtolower($slideshow_extension);
38 38
 		if (in_array($slideshow_extension, $accepted_extensions)) {
39
-			$png_svg_files[] =$file;
39
+			$png_svg_files[] = $file;
40 40
 		}
41 41
 	}
42 42
 }
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 $style = '<style>';
48 48
 $style .= '@import "'.api_get_path(WEB_CSS_PATH).'base.css";';
49 49
 $style .= '@import "'.api_get_path(WEB_CSS_PATH).'themes/'.api_get_visual_theme().'/default.css";';
50
-$style .='</style>';
50
+$style .= '</style>';
51 51
 
52 52
 ?>
53 53
 <!doctype html>
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
 if (!empty($png_svg_files)) {
60 60
 	echo '<h3>'.get_lang('SelectSVGEditImage').'</h3>';
61 61
 	echo '<ul>';
62
-	foreach($png_svg_files as $filename) {
63
-		$image=$disk_path.$filename;
62
+	foreach ($png_svg_files as $filename) {
63
+		$image = $disk_path.$filename;
64 64
 
65
-		if (strpos($filename, "svg")){
65
+		if (strpos($filename, "svg")) {
66 66
 			$new_sizes['width'] = 60;
67 67
 			$new_sizes['height'] = 60;
68 68
 		}
Please login to merge, or discard this patch.
main/inc/lib/svg-edit/extensions/imagelib/groups.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $slideshow_extension = strrchr($file, '.');
48 48
         $slideshow_extension = strtolower($slideshow_extension);
49 49
         if (in_array($slideshow_extension, $accepted_extensions)) {
50
-            $png_svg_files[] =$file;
50
+            $png_svg_files[] = $file;
51 51
         }
52 52
     }
53 53
 }
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 $style = '<style>';
56 56
 $style .= '@import "'.api_get_path(WEB_CSS_PATH).'base.css";';
57 57
 $style .= '@import "'.api_get_path(WEB_CSS_PATH).'themes/'.api_get_visual_theme().'/default.css";';
58
-$style .='</style>';
58
+$style .= '</style>';
59 59
 
60 60
 ?>
61 61
 <!doctype html>
@@ -68,15 +68,15 @@  discard block
 block discarded – undo
68 68
 if ((
69 69
         $group_properties['doc_state'] == 2 &&
70 70
         ($is_allowed_to_edit || GroupManager :: is_user_in_group($_user['user_id'], $groupId))) || $group_properties['doc_state'] == 1
71
-){
71
+) {
72 72
 
73 73
 	if (!empty($png_svg_files)) {
74 74
 		echo '<h3>'.get_lang('SelectSVGEditImage').'</h3>';
75 75
 		echo '<ul>';
76
-		foreach($png_svg_files as $filename) {
76
+		foreach ($png_svg_files as $filename) {
77 77
 			$image = $group_disk_path.$filename;
78 78
 
79
-			if (strpos($filename, "svg")){
79
+			if (strpos($filename, "svg")) {
80 80
 				$new_sizes['width'] = 60;
81 81
 				$new_sizes['height'] = 60;
82 82
 			} else {
Please login to merge, or discard this patch.