CourseDescriptionController::edit()

Complexity

Conditions	25
Paths	8101

Size

Total Lines	197
Code Lines	130

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function edit($id, $description_type)
    {
        $course_description = new CourseDescription();
        $session_id = api_get_session_id();
        $course_description->set_session_id($session_id);
        $data = [];
        $affected_rows = null;
        if ('POST' === strtoupper($_SERVER['REQUEST_METHOD'])) {
            if (!empty($_POST['title']) && !empty($_POST['contentDescription'])) {
                $title            = $_POST['title'];
                $content          = $_POST['contentDescription'];
                $description_type = $_POST['description_type'];
                $id               = $_POST['id'];

                if (empty($id)) {
                    $description = $course_description->get_data_by_description_type($description_type);
                    if (count($description) > 0) {
                        $id = $description['iid'];
                    }
                }

                $progress = isset($_POST['progress']) ? $_POST['progress'] : 0;

                $searchEnabled = api_get_setting('search.search_enabled');
                $enableSearch  = $searchEnabled === 'true' && !empty($_POST['enable_search']);

                $repo = Container::getCourseDescriptionRepository();

                /** @var CCourseDescription|null $courseDescription */
                $courseDescription = $repo->find($id);

                if ($courseDescription) {
                    if ($searchEnabled === 'true') {
                        // If checkbox is unchecked => skip search index for this request.
                        $courseDescription->setSkipSearchIndex(!$enableSearch);
                    }

                    $courseDescription
                        ->setTitle($title)
                        ->setProgress((int) $progress)
                        ->setContent($content)
                    ;

                    $repo->update($courseDescription);
                } else {
                    $course_description->set_description_type($description_type);
                    $course_description->set_title($title);
                    $course_description->set_progress($progress);
                    $course_description->set_content($content);

                    // Pass the flag down to insert (see next section).
                    $course_description->insert($enableSearch);
                }

                Display::addFlash(
                    Display::return_message(
                        get_lang('The description has been updated')
                    )
                );

                $url = api_get_path(WEB_CODE_PATH).'course_description/index.php?'.api_get_cidreq();
                api_location($url);
            }
        } else {
            $default_description_titles = $course_description->get_default_description_title();
            $default_description_title_editable = $course_description->get_default_description_title_editable();
            $default_description_icon = $course_description->get_default_description_icon();
            $question = $course_description->get_default_question();
            $information = $course_description->get_default_information();
            $description_type = $description_type;
            if (empty($id)) {
                // If the ID was not provided, find the first matching description item given the item type
                $description = $course_description->get_data_by_description_type($description_type);
                if (count($description) > 0) {
                    $id = $description['iid'];
                }
                // If no corresponding description is found, edit a new one
            }
            if (!empty($id)) {
                if (isset($_GET['id_session'])) {
                    $session_id = intval($_GET['id_session']);
                }
                $course_description_data = $course_description->get_data_by_id(
                    $id,
                    null,
                    $session_id
                );
                $description_type = $course_description_data['description_type'];
                $description_title = $course_description_data['description_title'];
                $description_content = $course_description_data['description_content'];
                $progress = $course_description_data['progress'];
                $descriptions = $course_description->get_data_by_description_type(
                    $description_type,
                    null,
                    $session_id
                );
            }

            if (empty($id)) {
                $id = isset($_REQUEST['id']) ? intval($_REQUEST['id']) : '';
                if (empty($id)) {
                    // If the ID was not provided, find the first matching description item given the item type
                    $course_description = new CourseDescription();
                    $description = $course_description->get_data_by_description_type($description_type);
                    if (count($description) > 0) {
                        $id = $description['id'];
                    }
                    // If no corresponding description is found, edit a new one
                    unset($course_description);
                }
            }
            $original_id = $id;
            // display categories
            $categories = [];
            foreach ($default_description_titles as $id => $title) {

$id is overwriting one of the parameters of this function.

                $categories[$id] = $title;
            }
            $categories[ADD_BLOCK] = get_lang('Other');

            // default header title form
            $description_type = intval($description_type);
            $header = $default_description_titles[$description_type];
            if ($description_type >= ADD_BLOCK) {
                $header = $default_description_titles[ADD_BLOCK];
            }

            // display form
            $form = new FormValidator(
                'course_description',
                'POST',
                'index.php?action=edit&id='.$original_id.'&description_type='.$description_type.'&'.api_get_cidreq()
            );
            $form->addElement('header', $header);
            $form->addElement('hidden', 'id', $original_id);
            $form->addElement('hidden', 'description_type', $description_type);
            //$form->addElement('hidden', 'sec_token', $token);

            if ('true' === api_get_setting('editor.save_titles_as_html')) {
                $form->addHtmlEditor(
                    'title',
                    get_lang('Title'),
                    true,
                    false,
                    ['ToolbarSet' => 'TitleAsHtml']
                );
            } else {
                $form->addText('title', get_lang('Title'));
                $form->applyFilter('title', 'html_filter');
            }
            $form->addHtmlEditor(
                'contentDescription',
                get_lang('Content'),
                true,
                false,
                [
                    'ToolbarSet' => 'Basic',
                    'Width' => '100%',
                    'Height' => '200',
                ]
            );

            if ('true' === api_get_setting('search.search_enabled')) {
                $form->addCheckBox(
                    'enable_search',
                    null,
                    get_lang('Index this description in global search')
                );

                // Default: checked
                $default['enable_search'] = 1;

$default was never initialized. Although not strictly required by PHP, it is generally a good practice to add $default = array(); before regardless.

            }

            $form->addButtonCreate(get_lang('Save'));

            $actions = self::getToolbar();

The method CourseDescriptionController::getToolbar() is not static, but was called statically.

            // Set some default values
            if (!empty($description_title)) {
                $default['title'] = Security::remove_XSS($description_title);
            }
            if (!empty($description_content)) {
                $default['contentDescription'] = Security::remove_XSS($description_content, COURSEMANAGERLOWSECURITY);
            }
            $default['description_type'] = $description_type;

            $form->setDefaults($default);

            if (isset($question[$description_type])) {
                $message = '<strong>'.get_lang('Help').'</strong><br />';
                $message .= $question[$description_type];
                Display::addFlash(Display::return_message($message, 'normal', false));
            }
            $tpl = new Template(get_lang('Description'));
            //$tpl->assign('is_allowed_to_edit', $is_allowed_to_edit);
            $tpl->assign('actions', $actions);
            $tpl->assign('session_id', $session_id);
            $tpl->assign('content', $form->returnForm());
            $tpl->display_one_col_template();
        }