chamilo / chamilo-lms

main/gradebook/lib/fe/userform.class.php

Braces +1 added lines, -2 removed lines

@@ -32,8 +32,7 @@
         }
         if ($this->form_type == self :: TYPE_USER_INFO) {
             $this->build_user_info_form();
-        }
-        elseif ($this->form_type == self :: TYPE_SIMPLE_SEARCH) {
+        } elseif ($this->form_type == self :: TYPE_SIMPLE_SEARCH) {
             $this->build_simple_search();
         }
         $this->setDefaults();

main/gradebook/lib/user_data_generator.class.php

Braces +4 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
         // sort users array
         if ($sorting & self :: UDG_SORT_TYPE) {
             usort($allitems, array('UserDataGenerator', 'sort_by_type'));
-        }elseif ($sorting & self :: UDG_SORT_NAME) {
+        } elseif ($sorting & self :: UDG_SORT_NAME) {
             usort($allitems, array('UserDataGenerator', 'sort_by_name'));
         } elseif ($sorting & self :: UDG_SORT_COURSE) {
             usort($allitems, array('UserDataGenerator', 'sort_by_course'));
@@ -148,8 +148,9 @@ 
             $row[] = $this->build_category_name($item);
             $row[] = $this->build_average_column($item, $ignore_score_color);
             $row[] = $this->build_result_column($item, $ignore_score_color);
-            if ($scoredisplay->is_custom())
-                $row[] = $this->build_mask_column($item, $ignore_score_color);
+            if ($scoredisplay->is_custom()) {
+                            $row[] = $this->build_mask_column($item, $ignore_score_color);
+            }
             $data[] = $row;
         }
         return $data;

main/dropbox/dropbox_class.inc.php

Braces +9 added lines, -3 removed lines

@@ -496,13 +496,19 @@
 		$id = intval($id);
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_file']."
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
-		if (!Database::query($sql)) return false;
+		if (!Database::query($sql)) {
+		    return false;
+		}
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_category']."
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
-		if (!Database::query($sql)) return false;
+		if (!Database::query($sql)) {
+		    return false;
+		}
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_post']."
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
-		if (!Database::query($sql)) return false;
+		if (!Database::query($sql)) {
+		    return false;
+		}
 		return true;
 	}
 

main/dropbox/dropbox_functions.inc.php

Braces +9 added lines, -4 removed lines

@@ -750,10 +750,15 @@
             ";
     $result = Database::query($sql);
 
-    if (!($res = Database::fetch_array($result)))
-        die(get_lang('GeneralError').' (code 901)');
-    if ($owner == 0) return $res['uploader_id'];
-    if ($res['uploader_id'] == $owner) return true;
+    if (!($res = Database::fetch_array($result))) {
+            die(get_lang('GeneralError').' (code 901)');
+    }
+    if ($owner == 0) {
+        return $res['uploader_id'];
+    }
+    if ($res['uploader_id'] == $owner) {
+        return true;
+    }
     die(get_lang('GeneralError').' (code '.$or_die.')');
 }
 

main/lp/learnpath.class.php

Braces +100 added lines, -68 removed lines

@@ -3938,8 +3938,9 @@ 
                 WHERE c_id = ".$course_id."
                 ORDER BY display_order";
         $res = Database::query($sql);
-        if ($res === false)
-            return false;
+        if ($res === false) {
+                    return false;
+        }
         $lps = array ();
         $lp_order = array ();
         $num = Database :: num_rows($res);
@@ -4539,8 +4540,9 @@ 
         if ($this->debug > 0) {
             error_log('New LP - In learnpath::set_maker()', 0);
         }
-        if (empty ($name))
-            return false;
+        if (empty ($name)) {
+                    return false;
+        }
         $this->maker = $name;
         $lp_table = Database :: get_course_table(TABLE_LP_MAIN);
         $course_id = api_get_course_int_id();
@@ -4605,8 +4607,9 @@ 
     public function set_terms_by_prefix($terms_string, $prefix)
     {
         $course_id = api_get_course_int_id();
-        if (api_get_setting('search_enabled') !== 'true')
-            return false;
+        if (api_get_setting('search_enabled') !== 'true') {
+                    return false;
+        }
 
         if (!extension_loaded('xapian')) {
             return false;
@@ -4619,8 +4622,9 @@ 
         $stored_terms = $this->get_common_index_terms_by_prefix($prefix);
 
         // Don't do anything if no change, verify only at DB, not the search engine.
-        if ((count(array_diff($terms, $stored_terms)) == 0) && (count(array_diff($stored_terms, $terms)) == 0))
-            return false;
+        if ((count(array_diff($terms, $stored_terms)) == 0) && (count(array_diff($stored_terms, $terms)) == 0)) {
+                    return false;
+        }
 
         require_once 'xapian.php'; // TODO: Try catch every xapian use or make wrappers on API.
         require_once api_get_path(LIBRARY_PATH).'search/ChamiloIndexer.class.php';
@@ -4812,8 +4816,9 @@ 
         if ($this->debug > 0) {
             error_log('New LP - In learnpath::set_proximity()', 0);
         }
-        if (empty ($name))
-            return false;
+        if (empty ($name)) {
+                    return false;
+        }
 
         $this->proximity = $name;
         $lp_table = Database :: get_course_table(TABLE_LP_MAIN);
@@ -5157,8 +5162,9 @@ 
 
         $sql = "SELECT * FROM $lp_table WHERE c_id = ".$course_id." ORDER BY display_order";
         $res = Database::query($sql);
-        if ($res === false)
-            return false;
+        if ($res === false) {
+                    return false;
+        }
 
         $num = Database :: num_rows($res);
         // First check the order is correct, globally (might be wrong because
@@ -5469,8 +5475,9 @@ 
             $position[$key] = $row['display_order'];
         }
 
-        if (count($array) > 0)
-            array_multisort($parent, SORT_ASC, $position, SORT_ASC, $array);
+        if (count($array) > 0) {
+                    array_multisort($parent, SORT_ASC, $position, SORT_ASC, $array);
+        }
 
         return $array;
     }
@@ -6242,10 +6249,12 @@ 
                     if ($new_comment || $new_title) {
                         $tbl_doc = Database :: get_course_table(TABLE_DOCUMENT);
                         $ct = '';
-                        if ($new_comment)
-                            $ct .= ", comment='" . Database::escape_string($new_comment). "'";
-                        if ($new_title)
-                            $ct .= ", title='" . Database::escape_string($new_title)."' ";
+                        if ($new_comment) {
+                                                    $ct .= ", comment='" . Database::escape_string($new_comment). "'";
+                        }
+                        if ($new_title) {
+                                                    $ct .= ", title='" . Database::escape_string($new_title)."' ";
+                        }
 
                         $sql = "UPDATE " . $tbl_doc ." SET " . substr($ct, 1)."
                                WHERE c_id = ".$course_id." AND id = " . $document_id;
@@ -6269,17 +6278,21 @@ 
         // Please, do not modify this dirname formatting.
         $dir = isset($_GET['dir']) ? $_GET['dir'] : $_POST['dir'];
 
-        if (strstr($dir, '..'))
-            $dir = '/';
+        if (strstr($dir, '..')) {
+                    $dir = '/';
+        }
 
-        if ($dir[0] == '.')
-            $dir = substr($dir, 1);
+        if ($dir[0] == '.') {
+                    $dir = substr($dir, 1);
+        }
 
-        if ($dir[0] != '/')
-            $dir = '/' . $dir;
+        if ($dir[0] != '/') {
+                    $dir = '/' . $dir;
+        }
 
-        if ($dir[strlen($dir) - 1] != '/')
-            $dir .= '/';
+        if ($dir[strlen($dir) - 1] != '/') {
+                    $dir .= '/';
+        }
 
         $filepath = api_get_path(SYS_COURSE_PATH) . $_course['path'] . '/document' . $dir;
 
@@ -6344,8 +6357,9 @@ 
                 }
                 $return .= '<div style="padding:10px;">';
 
-                if ($msg != '')
-                    $return .= $msg;
+                if ($msg != '') {
+                                    $return .= $msg;
+                }
 
                 $return .= '<h3>'.$row['title'].'</h3>';
                 switch ($row['item_type']) {
@@ -6606,10 +6620,11 @@ 
         $item_title			= Security::remove_XSS($item_title);
         $item_description 	= Security::remove_XSS($item_description);
 
-        if ($id != 0 && is_array($extra_info))
-            $parent = $extra_info['parent_item_id'];
-        else
-            $parent = 0;
+        if ($id != 0 && is_array($extra_info)) {
+                    $parent = $extra_info['parent_item_id'];
+        } else {
+                    $parent = 0;
+        }
 
         $sql = "SELECT * FROM " . $tbl_lp_item . "
                 WHERE c_id = ".$course_id." AND lp_id = " . $this->lp_id;
@@ -6909,8 +6924,9 @@ 
                         $arrHide[] = $arrLP[$i]['id'];
                     }
                 } else {
-                    if ($arrLP[$i]['item_type'] == 'dir')
-                        $return .= '<option ' . (($parent == $arrLP[$i]['id']) ? 'selected="selected" ' : '') . 'style="padding-left:' . ($arrLP[$i]['depth'] * 10) . 'px;" value="' . $arrLP[$i]['id'] . '">' . $arrLP[$i]['title'] . '</option>';
+                    if ($arrLP[$i]['item_type'] == 'dir') {
+                                            $return .= '<option ' . (($parent == $arrLP[$i]['id']) ? 'selected="selected" ' : '') . 'style="padding-left:' . ($arrLP[$i]['depth'] * 10) . 'px;" value="' . $arrLP[$i]['id'] . '">' . $arrLP[$i]['title'] . '</option>';
+                    }
                 }
             }
 
@@ -6928,11 +6944,13 @@ 
 
         for ($i = 0; $i < count($arrLP); $i++) {
             if ($arrLP[$i]['parent_item_id'] == $parent && $arrLP[$i]['id'] != $id) {
-                if ($extra_info['previous_item_id'] == $arrLP[$i]['id'])
+                if ($extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                    $selected = 'selected="selected" ';
+                } elseif ($action == 'add') {
                     $selected = 'selected="selected" ';
-                elseif ($action == 'add') $selected = 'selected="selected" ';
-                else
-                    $selected = '';
+                } else {
+                                    $selected = '';
+                }
 
                 $return .= '<option ' . $selected . 'value="' . $arrLP[$i]['id'] . '">' . get_lang('After') . ' "' . $arrLP[$i]['title'] . '"</option>';
             }
@@ -6959,9 +6977,11 @@ 
                 $arrHide = array ();
                 for ($i = 0; $i < count($arrLP); $i++) {
                     if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir') {
-                        if ($extra_info['previous_item_id'] == $arrLP[$i]['id'])
-                            $s_selected_position = $arrLP[$i]['id'];
-                        elseif ($action == 'add') $s_selected_position = 0;
+                        if ($extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                                    $s_selected_position = $arrLP[$i]['id'];
+                        } elseif ($action == 'add') {
+                            $s_selected_position = 0;
+                        }
                         $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
                     }
                 }
@@ -7153,9 +7173,11 @@ 
             $arrHide = array();
             for ($i = 0; $i < count($arrLP); $i++) {
                 if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir') {
-                    if (isset($extra_info['previous_item_id']) && $extra_info['previous_item_id'] == $arrLP[$i]['id'])
-                        $s_selected_position = $arrLP[$i]['id'];
-                    elseif ($action == 'add') $s_selected_position = 0;
+                    if (isset($extra_info['previous_item_id']) && $extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                            $s_selected_position = $arrLP[$i]['id'];
+                    } elseif ($action == 'add') {
+                        $s_selected_position = 0;
+                    }
                     $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
                 }
             }
@@ -7350,9 +7372,11 @@ 
 
             for ($i = 0; $i < count($arrLP); $i++) {
                 if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir') {
-                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id'])
-                        $s_selected_position = $arrLP[$i]['id'];
-                    elseif ($action == 'add') $s_selected_position = 0;
+                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                            $s_selected_position = $arrLP[$i]['id'];
+                    } elseif ($action == 'add') {
+                        $s_selected_position = 0;
+                    }
                     $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
 
                 }
@@ -7386,8 +7410,7 @@ 
 
         if (is_numeric($extra_info)) {
             $form->addHidden('path', $extra_info);
-        }
-        elseif (is_array($extra_info)) {
+        } elseif (is_array($extra_info)) {
             $form->addHidden('path', $extra_info['path']);
         }
 
@@ -7440,8 +7463,9 @@ 
                     lp_id = " . $this->lp_id . " AND
                     id != $id";
 
-        if ($item_type == 'dir')
-            $sql .= " AND parent_item_id = 0";
+        if ($item_type == 'dir') {
+                    $sql .= " AND parent_item_id = 0";
+        }
 
         $result = Database::query($sql);
         $arrLP = array ();
@@ -7842,9 +7866,11 @@ 
             $arrHide = array();
             for ($i = 0; $i < count($arrLP); $i++) {
                 if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir' && $arrLP[$i]['item_type'] !== TOOL_LP_FINAL_ITEM) {
-                    if (isset($extra_info['previous_item_id']) && $extra_info['previous_item_id'] == $arrLP[$i]['id'])
+                    if (isset($extra_info['previous_item_id']) && $extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                            $s_selected_position = $arrLP[$i]['id'];
+                    } elseif ($action == 'add') {
                         $s_selected_position = $arrLP[$i]['id'];
-                    elseif ($action == 'add') $s_selected_position = $arrLP[$i]['id'];
+                    }
 
                     $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
 
@@ -7855,17 +7881,18 @@ 
                 $item_type = isset($extra_info['item_type']) ? $extra_info['item_type'] : null;
                 $edit = isset($_GET['edit']) ? $_GET['edit'] : null;
                 if (($extra_info == 'new' || $item_type == TOOL_DOCUMENT || $item_type == TOOL_LP_FINAL_ITEM || $edit == 'true')) {
-                    if (isset ($_POST['content']))
-                        $content = stripslashes($_POST['content']);
-                    elseif (is_array($extra_info)) {
+                    if (isset ($_POST['content'])) {
+                                            $content = stripslashes($_POST['content']);
+                    } elseif (is_array($extra_info)) {
                         //If it's an html document or a text file
                         if (!$no_display_edit_textarea) {
                             $content = $this->display_document($extra_info['path'], false, false);
                         }
-                    } elseif (is_numeric($extra_info))
-                        $content = $this->display_document($extra_info, false, false);
-                    else
-                        $content = '';
+                    } elseif (is_numeric($extra_info)) {
+                                            $content = $this->display_document($extra_info, false, false);
+                    } else {
+                                            $content = '';
+                    }
 
                     if (!$no_display_edit_textarea) {
                         // We need to calculate here some specific settings for the online editor.
@@ -8129,9 +8156,11 @@ 
             $arrHide = array();
             for ($i = 0; $i < count($arrLP); $i++) {
                 if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir') {
-                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id'])
-                        $s_selected_position = $arrLP[$i]['id'];
-                    elseif ($action == 'add') $s_selected_position = 0;
+                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                            $s_selected_position = $arrLP[$i]['id'];
+                    } elseif ($action == 'add') {
+                        $s_selected_position = 0;
+                    }
                     $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
 
                 }
@@ -8327,9 +8356,11 @@ 
             $arrHide = array ();
             for ($i = 0; $i < count($arrLP); $i++) {
                 if ($arrLP[$i]['id'] != $id && $arrLP[$i]['item_type'] != 'dir') {
-                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id'])
-                        $s_selected_position = $arrLP[$i]['id'];
-                    elseif ($action == 'add') $s_selected_position = 0;
+                    if ($extra_info['previous_item_id'] == $arrLP[$i]['id']) {
+                                            $s_selected_position = $arrLP[$i]['id'];
+                    } elseif ($action == 'add') {
+                        $s_selected_position = 0;
+                    }
                     $arrHide[$arrLP[$i]['id']]['value'] = $arrLP[$i]['title'];
 
                 }
@@ -9381,10 +9412,11 @@ 
 
                 // Dependency to other files - not yet supported.
                 $i = 1;
-                if ($inc_docs)
-                foreach ($inc_docs as $doc_info) {
+                if ($inc_docs) {
+                                foreach ($inc_docs as $doc_info) {
                     if (count($doc_info) < 1 || empty($doc_info[0])) {
                         continue;
+                }
                     }
                     $my_dep = $xmldoc->createElement('resource');
                     $res_id = 'RESOURCE_'.$item->get_id().'_'.$i;

main/inc/lib/sessionmanager.lib.php

Braces +9 added lines, -6 removed lines

@@ -1604,8 +1604,10 @@ 
         if (empty($session_visibility)) {
             $session_visibility = $session->getVisibility();
             //default status loaded if empty
-            if (empty($session_visibility))
-                $session_visibility = SESSION_VISIBLE_READ_ONLY; // by default readonly 1
+            if (empty($session_visibility)) {
+                            $session_visibility = SESSION_VISIBLE_READ_ONLY;
+            }
+            // by default readonly 1
         } else {
             if (!in_array($session_visibility, array(SESSION_VISIBLE_READ_ONLY, SESSION_VISIBLE, SESSION_INVISIBLE))) {
                 $session_visibility = SESSION_VISIBLE_READ_ONLY;
@@ -2819,10 +2821,11 @@ 
                                 c_id = $courseId AND
                                 user_id = $user_id ";
                     $result = Database::query($sql);
-                    if (Database::affected_rows($result) > 0)
-                        return true;
-                    else
-                        return false;
+                    if (Database::affected_rows($result) > 0) {
+                                            return true;
+                    } else {
+                                            return false;
+                    }
                 } else {
                     // The user is not subscribed to the session, so make sure
                     // he isn't subscribed to a course in this session either

main/session/session_category_edit.php

Braces +354 added lines, -88 removed lines

@@ -84,7 +84,12 @@ 
         <div class="form-group">
             <label class="col-sm-3 control-label"><?php echo get_lang('SessionName') ?></label>
             <div class="col-sm-6">
-                <input class="form-control" type="text" name="name" size="50" maxlength="50" value="<?php if($formSent) echo api_htmlentities($name,ENT_QUOTES,$charset); else echo api_htmlentities($infos['name'],ENT_QUOTES,$charset); ?>">
+                <input class="form-control" type="text" name="name" size="50" maxlength="50" value="<?php if($formSent) {
+    echo api_htmlentities($name,ENT_QUOTES,$charset);
+} else {
+    echo api_htmlentities($infos['name'],ENT_QUOTES,$charset);
+}
+?>">
             </div>
             <div class="col-sm-3"></div>
         </div>
@@ -100,58 +105,184 @@ 
                 <div class="col-sm-6">
                     <select name="day_start">
                         <option value="1">01</option>
-                        <option value="2" <?php if($day_start == 2) echo 'selected="selected"'; ?> >02</option>
-                        <option value="3" <?php if($day_start == 3) echo 'selected="selected"'; ?> >03</option>
-                        <option value="4" <?php if($day_start == 4) echo 'selected="selected"'; ?> >04</option>
-                        <option value="5" <?php if($day_start == 5) echo 'selected="selected"'; ?> >05</option>
-                        <option value="6" <?php if($day_start == 6) echo 'selected="selected"'; ?> >06</option>
-                        <option value="7" <?php if($day_start == 7) echo 'selected="selected"'; ?> >07</option>
-                        <option value="8" <?php if($day_start == 8) echo 'selected="selected"'; ?> >08</option>
-                        <option value="9" <?php if($day_start == 9) echo 'selected="selected"'; ?> >09</option>
-                        <option value="10" <?php if($day_start == 10) echo 'selected="selected"'; ?> >10</option>
-                        <option value="11" <?php if($day_start == 11) echo 'selected="selected"'; ?> >11</option>
-                        <option value="12" <?php if($day_start == 12) echo 'selected="selected"'; ?> >12</option>
-                        <option value="13" <?php if($day_start == 13) echo 'selected="selected"'; ?> >13</option>
-                        <option value="14" <?php if($day_start == 14) echo 'selected="selected"'; ?> >14</option>
-                        <option value="15" <?php if($day_start == 15) echo 'selected="selected"'; ?> >15</option>
-                        <option value="16" <?php if($day_start == 16) echo 'selected="selected"'; ?> >16</option>
-                        <option value="17" <?php if($day_start == 17) echo 'selected="selected"'; ?> >17</option>
-                        <option value="18" <?php if($day_start == 18) echo 'selected="selected"'; ?> >18</option>
-                        <option value="19" <?php if($day_start == 19) echo 'selected="selected"'; ?> >19</option>
-                        <option value="20" <?php if($day_start == 20) echo 'selected="selected"'; ?> >20</option>
-                        <option value="21" <?php if($day_start == 21) echo 'selected="selected"'; ?> >21</option>
-                        <option value="22" <?php if($day_start == 22) echo 'selected="selected"'; ?> >22</option>
-                        <option value="23" <?php if($day_start == 23) echo 'selected="selected"'; ?> >23</option>
-                        <option value="24" <?php if($day_start == 24) echo 'selected="selected"'; ?> >24</option>
-                        <option value="25" <?php if($day_start == 25) echo 'selected="selected"'; ?> >25</option>
-                        <option value="26" <?php if($day_start == 26) echo 'selected="selected"'; ?> >26</option>
-                        <option value="27" <?php if($day_start == 27) echo 'selected="selected"'; ?> >27</option>
-                        <option value="28" <?php if($day_start == 28) echo 'selected="selected"'; ?> >28</option>
-                        <option value="29" <?php if($day_start == 29) echo 'selected="selected"'; ?> >29</option>
-                        <option value="30" <?php if($day_start == 30) echo 'selected="selected"'; ?> >30</option>
-                        <option value="31" <?php if($day_start == 31) echo 'selected="selected"'; ?> >31</option>
+                        <option value="2" <?php if($day_start == 2) {
+    echo 'selected="selected"';
+}
+?> >02</option>
+                        <option value="3" <?php if($day_start == 3) {
+    echo 'selected="selected"';
+}
+?> >03</option>
+                        <option value="4" <?php if($day_start == 4) {
+    echo 'selected="selected"';
+}
+?> >04</option>
+                        <option value="5" <?php if($day_start == 5) {
+    echo 'selected="selected"';
+}
+?> >05</option>
+                        <option value="6" <?php if($day_start == 6) {
+    echo 'selected="selected"';
+}
+?> >06</option>
+                        <option value="7" <?php if($day_start == 7) {
+    echo 'selected="selected"';
+}
+?> >07</option>
+                        <option value="8" <?php if($day_start == 8) {
+    echo 'selected="selected"';
+}
+?> >08</option>
+                        <option value="9" <?php if($day_start == 9) {
+    echo 'selected="selected"';
+}
+?> >09</option>
+                        <option value="10" <?php if($day_start == 10) {
+    echo 'selected="selected"';
+}
+?> >10</option>
+                        <option value="11" <?php if($day_start == 11) {
+    echo 'selected="selected"';
+}
+?> >11</option>
+                        <option value="12" <?php if($day_start == 12) {
+    echo 'selected="selected"';
+}
+?> >12</option>
+                        <option value="13" <?php if($day_start == 13) {
+    echo 'selected="selected"';
+}
+?> >13</option>
+                        <option value="14" <?php if($day_start == 14) {
+    echo 'selected="selected"';
+}
+?> >14</option>
+                        <option value="15" <?php if($day_start == 15) {
+    echo 'selected="selected"';
+}
+?> >15</option>
+                        <option value="16" <?php if($day_start == 16) {
+    echo 'selected="selected"';
+}
+?> >16</option>
+                        <option value="17" <?php if($day_start == 17) {
+    echo 'selected="selected"';
+}
+?> >17</option>
+                        <option value="18" <?php if($day_start == 18) {
+    echo 'selected="selected"';
+}
+?> >18</option>
+                        <option value="19" <?php if($day_start == 19) {
+    echo 'selected="selected"';
+}
+?> >19</option>
+                        <option value="20" <?php if($day_start == 20) {
+    echo 'selected="selected"';
+}
+?> >20</option>
+                        <option value="21" <?php if($day_start == 21) {
+    echo 'selected="selected"';
+}
+?> >21</option>
+                        <option value="22" <?php if($day_start == 22) {
+    echo 'selected="selected"';
+}
+?> >22</option>
+                        <option value="23" <?php if($day_start == 23) {
+    echo 'selected="selected"';
+}
+?> >23</option>
+                        <option value="24" <?php if($day_start == 24) {
+    echo 'selected="selected"';
+}
+?> >24</option>
+                        <option value="25" <?php if($day_start == 25) {
+    echo 'selected="selected"';
+}
+?> >25</option>
+                        <option value="26" <?php if($day_start == 26) {
+    echo 'selected="selected"';
+}
+?> >26</option>
+                        <option value="27" <?php if($day_start == 27) {
+    echo 'selected="selected"';
+}
+?> >27</option>
+                        <option value="28" <?php if($day_start == 28) {
+    echo 'selected="selected"';
+}
+?> >28</option>
+                        <option value="29" <?php if($day_start == 29) {
+    echo 'selected="selected"';
+}
+?> >29</option>
+                        <option value="30" <?php if($day_start == 30) {
+    echo 'selected="selected"';
+}
+?> >30</option>
+                        <option value="31" <?php if($day_start == 31) {
+    echo 'selected="selected"';
+}
+?> >31</option>
                   </select>
                   /
                   <select name="month_start">
                         <option value="1">01</option>
-                        <option value="2" <?php if($month_start == 2) echo 'selected="selected"'; ?> >02</option>
-                        <option value="3" <?php if($month_start == 3) echo 'selected="selected"'; ?> >03</option>
-                        <option value="4" <?php if($month_start == 4) echo 'selected="selected"'; ?> >04</option>
-                        <option value="5" <?php if($month_start == 5) echo 'selected="selected"'; ?> >05</option>
-                        <option value="6" <?php if($month_start == 6) echo 'selected="selected"'; ?> >06</option>
-                        <option value="7" <?php if($month_start == 7) echo 'selected="selected"'; ?> >07</option>
-                        <option value="8" <?php if($month_start == 8) echo 'selected="selected"'; ?> >08</option>
-                        <option value="9" <?php if($month_start == 9) echo 'selected="selected"'; ?> >09</option>
-                        <option value="10" <?php if($month_start == 10) echo 'selected="selected"'; ?> >10</option>
-                        <option value="11" <?php if($month_start == 11) echo 'selected="selected"'; ?> >11</option>
-                        <option value="12" <?php if($month_start == 12) echo 'selected="selected"'; ?> >12</option>
+                        <option value="2" <?php if($month_start == 2) {
+    echo 'selected="selected"';
+}
+?> >02</option>
+                        <option value="3" <?php if($month_start == 3) {
+    echo 'selected="selected"';
+}
+?> >03</option>
+                        <option value="4" <?php if($month_start == 4) {
+    echo 'selected="selected"';
+}
+?> >04</option>
+                        <option value="5" <?php if($month_start == 5) {
+    echo 'selected="selected"';
+}
+?> >05</option>
+                        <option value="6" <?php if($month_start == 6) {
+    echo 'selected="selected"';
+}
+?> >06</option>
+                        <option value="7" <?php if($month_start == 7) {
+    echo 'selected="selected"';
+}
+?> >07</option>
+                        <option value="8" <?php if($month_start == 8) {
+    echo 'selected="selected"';
+}
+?> >08</option>
+                        <option value="9" <?php if($month_start == 9) {
+    echo 'selected="selected"';
+}
+?> >09</option>
+                        <option value="10" <?php if($month_start == 10) {
+    echo 'selected="selected"';
+}
+?> >10</option>
+                        <option value="11" <?php if($month_start == 11) {
+    echo 'selected="selected"';
+}
+?> >11</option>
+                        <option value="12" <?php if($month_start == 12) {
+    echo 'selected="selected"';
+}
+?> >12</option>
                   </select>
                   /
                 <select name="year_start">
                         <?php
                         for($i=$thisYear-5;$i <= ($thisYear+5);$i++)
                         { ?>
-                                <option value="<?php echo $i; ?>" <?php if($year_start == $i) echo 'selected="selected"'; ?> ><?php echo $i; ?></option>
+                                <option value="<?php echo $i; ?>" <?php if($year_start == $i) {
+    echo 'selected="selected"';
+}
+?> ><?php echo $i; ?></option>
                         <?php
                         } ?>
                 </select>
@@ -163,53 +294,182 @@ 
                 <div class="col-sm-6">
                     <select name="day_end">
                         <option value="0">--</option>
-                        <option value="1" <?php if($day_end == 1) echo 'selected="selected"'; ?> >01</option>
-                        <option value="2" <?php if($day_end == 2) echo 'selected="selected"'; ?> >02</option>
-                        <option value="3" <?php if($day_end == 3) echo 'selected="selected"'; ?> >03</option>
-                        <option value="4" <?php if($day_end == 4) echo 'selected="selected"'; ?> >04</option>
-                        <option value="5" <?php if($day_end == 5) echo 'selected="selected"'; ?> >05</option>
-                        <option value="6" <?php if($day_end == 6) echo 'selected="selected"'; ?> >06</option>
-                        <option value="7" <?php if($day_end == 7) echo 'selected="selected"'; ?> >07</option>
-                        <option value="8" <?php if($day_end == 8) echo 'selected="selected"'; ?> >08</option>
-                        <option value="9" <?php if($day_end == 9) echo 'selected="selected"'; ?> >09</option>
-                        <option value="10" <?php if($day_end == 10) echo 'selected="selected"'; ?> >10</option>
-                        <option value="11" <?php if($day_end == 11) echo 'selected="selected"'; ?> >11</option>
-                        <option value="12" <?php if($day_end == 12) echo 'selected="selected"'; ?> >12</option>
-                        <option value="13" <?php if($day_end == 13) echo 'selected="selected"'; ?> >13</option>
-                        <option value="14" <?php if($day_end == 14) echo 'selected="selected"'; ?> >14</option>
-                        <option value="15" <?php if($day_end == 15) echo 'selected="selected"'; ?> >15</option>
-                        <option value="16" <?php if($day_end == 16) echo 'selected="selected"'; ?> >16</option>
-                        <option value="17" <?php if($day_end == 17) echo 'selected="selected"'; ?> >17</option>
-                        <option value="18" <?php if($day_end == 18) echo 'selected="selected"'; ?> >18</option>
-                        <option value="19" <?php if($day_end == 19) echo 'selected="selected"'; ?> >19</option>
-                        <option value="20" <?php if($day_end == 20) echo 'selected="selected"'; ?> >20</option>
-                        <option value="21" <?php if($day_end == 21) echo 'selected="selected"'; ?> >21</option>
-                        <option value="22" <?php if($day_end == 22) echo 'selected="selected"'; ?> >22</option>
-                        <option value="23" <?php if($day_end == 23) echo 'selected="selected"'; ?> >23</option>
-                        <option value="24" <?php if($day_end == 24) echo 'selected="selected"'; ?> >24</option>
-                        <option value="25" <?php if($day_end == 25) echo 'selected="selected"'; ?> >25</option>
-                        <option value="26" <?php if($day_end == 26) echo 'selected="selected"'; ?> >26</option>
-                        <option value="27" <?php if($day_end == 27) echo 'selected="selected"'; ?> >27</option>
-                        <option value="28" <?php if($day_end == 28) echo 'selected="selected"'; ?> >28</option>
-                        <option value="29" <?php if($day_end == 29) echo 'selected="selected"'; ?> >29</option>
-                        <option value="30" <?php if($day_end == 30) echo 'selected="selected"'; ?> >30</option>
-                        <option value="31" <?php if($day_end == 31) echo 'selected="selected"'; ?> >31</option>
+                        <option value="1" <?php if($day_end == 1) {
+    echo 'selected="selected"';
+}
+?> >01</option>
+                        <option value="2" <?php if($day_end == 2) {
+    echo 'selected="selected"';
+}
+?> >02</option>
+                        <option value="3" <?php if($day_end == 3) {
+    echo 'selected="selected"';
+}
+?> >03</option>
+                        <option value="4" <?php if($day_end == 4) {
+    echo 'selected="selected"';
+}
+?> >04</option>
+                        <option value="5" <?php if($day_end == 5) {
+    echo 'selected="selected"';
+}
+?> >05</option>
+                        <option value="6" <?php if($day_end == 6) {
+    echo 'selected="selected"';
+}
+?> >06</option>
+                        <option value="7" <?php if($day_end == 7) {
+    echo 'selected="selected"';
+}
+?> >07</option>
+                        <option value="8" <?php if($day_end == 8) {
+    echo 'selected="selected"';
+}
+?> >08</option>
+                        <option value="9" <?php if($day_end == 9) {
+    echo 'selected="selected"';
+}
+?> >09</option>
+                        <option value="10" <?php if($day_end == 10) {
+    echo 'selected="selected"';
+}
+?> >10</option>
+                        <option value="11" <?php if($day_end == 11) {
+    echo 'selected="selected"';
+}
+?> >11</option>
+                        <option value="12" <?php if($day_end == 12) {
+    echo 'selected="selected"';
+}
+?> >12</option>
+                        <option value="13" <?php if($day_end == 13) {
+    echo 'selected="selected"';
+}
+?> >13</option>
+                        <option value="14" <?php if($day_end == 14) {
+    echo 'selected="selected"';
+}
+?> >14</option>
+                        <option value="15" <?php if($day_end == 15) {
+    echo 'selected="selected"';
+}
+?> >15</option>
+                        <option value="16" <?php if($day_end == 16) {
+    echo 'selected="selected"';
+}
+?> >16</option>
+                        <option value="17" <?php if($day_end == 17) {
+    echo 'selected="selected"';
+}
+?> >17</option>
+                        <option value="18" <?php if($day_end == 18) {
+    echo 'selected="selected"';
+}
+?> >18</option>
+                        <option value="19" <?php if($day_end == 19) {
+    echo 'selected="selected"';
+}
+?> >19</option>
+                        <option value="20" <?php if($day_end == 20) {
+    echo 'selected="selected"';
+}
+?> >20</option>
+                        <option value="21" <?php if($day_end == 21) {
+    echo 'selected="selected"';
+}
+?> >21</option>
+                        <option value="22" <?php if($day_end == 22) {
+    echo 'selected="selected"';
+}
+?> >22</option>
+                        <option value="23" <?php if($day_end == 23) {
+    echo 'selected="selected"';
+}
+?> >23</option>
+                        <option value="24" <?php if($day_end == 24) {
+    echo 'selected="selected"';
+}
+?> >24</option>
+                        <option value="25" <?php if($day_end == 25) {
+    echo 'selected="selected"';
+}
+?> >25</option>
+                        <option value="26" <?php if($day_end == 26) {
+    echo 'selected="selected"';
+}
+?> >26</option>
+                        <option value="27" <?php if($day_end == 27) {
+    echo 'selected="selected"';
+}
+?> >27</option>
+                        <option value="28" <?php if($day_end == 28) {
+    echo 'selected="selected"';
+}
+?> >28</option>
+                        <option value="29" <?php if($day_end == 29) {
+    echo 'selected="selected"';
+}
+?> >29</option>
+                        <option value="30" <?php if($day_end == 30) {
+    echo 'selected="selected"';
+}
+?> >30</option>
+                        <option value="31" <?php if($day_end == 31) {
+    echo 'selected="selected"';
+}
+?> >31</option>
                   </select>
                   /
                   <select name="month_end">
                         <option value="0">--</option>
-                        <option value="1" <?php if($month_end == 1) echo 'selected="selected"'; ?> >01</option>
-                        <option value="2" <?php if($month_end == 2) echo 'selected="selected"'; ?> >02</option>
-                        <option value="3" <?php if($month_end == 3) echo 'selected="selected"'; ?> >03</option>
-                        <option value="4" <?php if($month_end == 4) echo 'selected="selected"'; ?> >04</option>
-                        <option value="5" <?php if($month_end == 5) echo 'selected="selected"'; ?> >05</option>
-                        <option value="6" <?php if($month_end == 6) echo 'selected="selected"'; ?> >06</option>
-                        <option value="7" <?php if($month_end == 7) echo 'selected="selected"'; ?> >07</option>
-                        <option value="8" <?php if($month_end == 8) echo 'selected="selected"'; ?> >08</option>
-                        <option value="9" <?php if($month_end == 9) echo 'selected="selected"'; ?> >09</option>
-                        <option value="10" <?php if($month_end == 10) echo 'selected="selected"'; ?> >10</option>
-                        <option value="11" <?php if($month_end == 11) echo 'selected="selected"'; ?> >11</option>
-                        <option value="12" <?php if($month_end == 12) echo 'selected="selected"'; ?> >12</option>
+                        <option value="1" <?php if($month_end == 1) {
+    echo 'selected="selected"';
+}
+?> >01</option>
+                        <option value="2" <?php if($month_end == 2) {
+    echo 'selected="selected"';
+}
+?> >02</option>
+                        <option value="3" <?php if($month_end == 3) {
+    echo 'selected="selected"';
+}
+?> >03</option>
+                        <option value="4" <?php if($month_end == 4) {
+    echo 'selected="selected"';
+}
+?> >04</option>
+                        <option value="5" <?php if($month_end == 5) {
+    echo 'selected="selected"';
+}
+?> >05</option>
+                        <option value="6" <?php if($month_end == 6) {
+    echo 'selected="selected"';
+}
+?> >06</option>
+                        <option value="7" <?php if($month_end == 7) {
+    echo 'selected="selected"';
+}
+?> >07</option>
+                        <option value="8" <?php if($month_end == 8) {
+    echo 'selected="selected"';
+}
+?> >08</option>
+                        <option value="9" <?php if($month_end == 9) {
+    echo 'selected="selected"';
+}
+?> >09</option>
+                        <option value="10" <?php if($month_end == 10) {
+    echo 'selected="selected"';
+}
+?> >10</option>
+                        <option value="11" <?php if($month_end == 11) {
+    echo 'selected="selected"';
+}
+?> >11</option>
+                        <option value="12" <?php if($month_end == 12) {
+    echo 'selected="selected"';
+}
+?> >12</option>
                   </select>
                   /
                   <select name="year_end">
@@ -217,7 +477,10 @@ 
                         <?php
                         for($i=$thisYear-5;$i <= ($thisYear+5);$i++)
                         { ?>
-                         <option value="<?php echo $i; ?>" <?php if($year_end == $i) echo 'selected="selected"'; ?> ><?php echo $i; ?></option>
+                         <option value="<?php echo $i; ?>" <?php if($year_end == $i) {
+    echo 'selected="selected"';
+}
+?> ><?php echo $i; ?></option>
                         <?php
                         } ?>
                  </select>
@@ -238,7 +501,10 @@ 
 
 
 <script>
-<?php if($year_start=="0000") echo "setDisable(document.form.nolimit);\r\n"; ?>
+<?php if($year_start=="0000") {
+    echo "setDisable(document.form.nolimit);\r\n";
+}
+?>
 function setDisable(select){
 	document.form.day_start.disabled = (select.checked) ? true : false;
 	document.form.month_start.disabled = (select.checked) ? true : false;

main/webservices/registration.soap.php

Braces +186 added lines, -64 removed lines

@@ -63,14 +63,16 @@ 
         list($ip1) = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
         $ip = trim($ip1);
     }
-    if ($debug)
-        error_log("ip: $ip");
+    if ($debug) {
+            error_log("ip: $ip");
+    }
     // Check if a file that limits access from webservices exists and contains
     // the restraining check
     if (is_file('webservice-auth-ip.conf.php')) {
         include 'webservice-auth-ip.conf.php';
-        if ($debug)
-            error_log("webservice-auth-ip.conf.php file included");
+        if ($debug) {
+                    error_log("webservice-auth-ip.conf.php file included");
+        }
         if (!empty($ws_auth_ip)) {
             $check_ip = true;
             $ip_matches = api_check_ip_in_range($ip, $ws_auth_ip);
@@ -554,7 +556,9 @@ 
 
     // First check wether the login already exists
     if (!UserManager::is_username_available($loginName)) {
-        if ($debug) error_log("Username $loginName is not available");
+        if ($debug) {
+            error_log("Username $loginName is not available");
+        }
         return 0;
     }
 
@@ -1045,9 +1049,15 @@ 
         );
     }
 
-    if ($debug) error_log('$userId found: '. $userId);
-    if ($debug) error_log('$courseId found: '. $courseId);
-    if ($debug) error_log('$sessionId found: '. $sessionId);
+    if ($debug) {
+        error_log('$userId found: '. $userId);
+    }
+    if ($debug) {
+        error_log('$courseId found: '. $courseId);
+    }
+    if ($debug) {
+        error_log('$sessionId found: '. $sessionId);
+    }
 
     return [
         'user_id' => $userId,
@@ -1077,13 +1087,17 @@ 
 {
     global $debug;
 
-    if ($debug) error_log('WSSubscribeTeacherToSessionCourse');
+    if ($debug) {
+        error_log('WSSubscribeTeacherToSessionCourse');
+    }
 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
 
-    if ($debug) error_log('Params '. print_r($params, 1));
+    if ($debug) {
+        error_log('Params '. print_r($params, 1));
+    }
 
     $params = parseCourseSessionUserParams($params);
 
@@ -1096,13 +1110,17 @@ 
     $result = 0;
 
     if (!empty($coaches)) {
-        if ($debug) error_log('Coaches:  '. print_r($coaches, 1));
+        if ($debug) {
+            error_log('Coaches:  '. print_r($coaches, 1));
+        }
         if (in_array($userId, $coaches)) {
             $result = 1;
         }
     }
 
-    if ($debug) error_log('Result:  '. $result);
+    if ($debug) {
+        error_log('Result:  '. $result);
+    }
 
     return $result;
 }
@@ -1128,13 +1146,17 @@ 
 {
     global $debug;
 
-    if ($debug) error_log('WSSubscribeTeacherToSessionCourse');
+    if ($debug) {
+        error_log('WSSubscribeTeacherToSessionCourse');
+    }
 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
 
-    if ($debug) error_log('Params '. print_r($params, 1));
+    if ($debug) {
+        error_log('Params '. print_r($params, 1));
+    }
 
     $params = parseCourseSessionUserParams($params);
 
@@ -1148,7 +1170,9 @@ 
     $result = 0;
 
     if (!empty($coaches)) {
-        if ($debug) error_log('Coaches:  ' . print_r($coaches, 1));
+        if ($debug) {
+            error_log('Coaches:  ' . print_r($coaches, 1));
+        }
         if (!in_array($userId, $coaches)) {
             $result = 1;
         }
@@ -1156,7 +1180,9 @@ 
         $result = 1;
     }
 
-    if ($debug) error_log('Final Result: '. $result);
+    if ($debug) {
+        error_log('Final Result: '. $result);
+    }
 
     return $result;
 }
@@ -1208,8 +1234,12 @@ 
 {
     global $_user, $_configuration, $debug;
     $debug = 1;
-    if ($debug) error_log('WSCreateUserPasswordCrypted');
-    if ($debug) error_log(print_r($params,1));
+    if ($debug) {
+        error_log('WSCreateUserPasswordCrypted');
+    }
+    if ($debug) {
+        error_log(print_r($params,1));
+    }
 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
@@ -1241,22 +1271,30 @@ 
         if ($_configuration['password_encryption'] === $encrypt_method ) {
             if ($encrypt_method == 'md5' && !preg_match('/^[A-Fa-f0-9]{32}$/', $password)) {
                 $msg = "Encryption $encrypt_method is invalid";
-                if ($debug) error_log($msg);
+                if ($debug) {
+                    error_log($msg);
+                }
                 return $msg;
 
             } else if ($encrypt_method == 'sha1' && !preg_match('/^[A-Fa-f0-9]{40}$/', $password)) {
                 $msg = "Encryption $encrypt_method is invalid";
-                if ($debug) error_log($msg);
+                if ($debug) {
+                    error_log($msg);
+                }
                 return $msg;
             }
         } else {
             $msg = "This encryption $encrypt_method is not configured";
-            if ($debug) error_log($msg);
+            if ($debug) {
+                error_log($msg);
+            }
             return $msg;
         }
     } else {
         $msg = 'The chamilo setting $_configuration["password_encryption"] is not configured';
-        if ($debug) error_log($msg);
+        if ($debug) {
+            error_log($msg);
+        }
         return $msg;
     }
 
@@ -1276,10 +1314,14 @@ 
         $original_user_id_name
     );
 
-    if ($debug) error_log('Ready to create user');
+    if ($debug) {
+        error_log('Ready to create user');
+    }
 
     if ($user_id > 0) {
-        if ($debug) error_log('User found with id: '.$user_id);
+        if ($debug) {
+            error_log('User found with id: '.$user_id);
+        }
 
         // Check whether user is not active
         //@todo why this condition exists??
@@ -1290,7 +1332,9 @@ 
         $count_check_user = Database::num_rows($resu);
         if ($count_check_user > 0) {
 
-            if ($debug) error_log('User id: '.$user_id.' exists and is NOT active. Updating user and setting setting active = 1');
+            if ($debug) {
+                error_log('User id: '.$user_id.' exists and is NOT active. Updating user and setting setting active = 1');
+            }
 
             $sql = "UPDATE $table_user SET
                     lastname='".Database::escape_string($lastName)."',
@@ -1311,7 +1355,9 @@ 
                     hr_dept_id=".intval($hr_dept_id)." 
                 WHERE user_id='".$r_check_user[0]."'";
 
-            if ($debug) error_log($sql);
+            if ($debug) {
+                error_log($sql);
+            }
             Database::query($sql);
 
             if (is_array($extra_list) && count($extra_list) > 0) {
@@ -1328,11 +1374,15 @@ 
             }
             return $r_check_user[0];
         } else {
-            if ($debug) error_log('User exists but is active. Cant be updated');
+            if ($debug) {
+                error_log('User exists but is active. Cant be updated');
+            }
             return 0;
         }
     } else {
-        if ($debug) error_log("User not found with original_id = $original_user_id_value and original_name = $original_user_id_name");
+        if ($debug) {
+            error_log("User not found with original_id = $original_user_id_value and original_name = $original_user_id_name");
+        }
     }
 
     // Default language.
@@ -1348,12 +1398,16 @@ 
 
     // First check wether the login already exists
     if (!UserManager::is_username_available($loginName)) {
-        if ($debug) error_log("Username $loginName is not available");
+        if ($debug) {
+            error_log("Username $loginName is not available");
+        }
         return 0;
     }
 
     $queryExpirationDate = '';
-    if (!empty($params['expiration_date'])) $queryExpirationDate = "expiration_date     = '".Database::escape_string($expiration_date)."', ";
+    if (!empty($params['expiration_date'])) {
+        $queryExpirationDate = "expiration_date     = '".Database::escape_string($expiration_date)."', ";
+    }
 
     $sql = "INSERT INTO $table_user SET
             lastname            = '".Database::escape_string(trim($lastName))."',
@@ -1373,7 +1427,9 @@ 
             ".$queryExpirationDate."
             hr_dept_id          = '".Database::escape_string($hr_dept_id)."',
             active              = '".Database::escape_string($active)."'";
-    if ($debug) error_log($sql);
+    if ($debug) {
+        error_log($sql);
+    }
 
     Database::query($sql);
     $return = Database::insert_id();
@@ -1385,7 +1441,9 @@ 
 
         $url_id = api_get_current_access_url_id();
         UrlManager::add_user_to_url($return, $url_id);
-        if ($debug) error_log("Adding user_id = $return to URL id $url_id ");
+        if ($debug) {
+            error_log("Adding user_id = $return to URL id $url_id ");
+        }
 
         // Create extra field for the original_user_id_name
         UserManager::create_extra_field(
@@ -1422,7 +1480,9 @@ 
             }
         }
     } else {
-        if ($debug) error_log('Error while inserting a user');
+        if ($debug) {
+            error_log('Error while inserting a user');
+        }
 
         return 0;
     }
@@ -4504,7 +4564,9 @@ 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
-    if ($debug) error_log('WSSubscribeUserToCourse params: '.print_r($params,1));
+    if ($debug) {
+        error_log('WSSubscribeUserToCourse params: '.print_r($params,1));
+    }
 
     $results = array();
     $userscourses = $params['userscourses'];
@@ -4523,7 +4585,9 @@ 
             $original_user_id['original_user_id_value'],
             $original_user_id['original_user_id_name']
         );
-        if ($debug) error_log('WSSubscribeUserToCourse user_id: '.$user_id);
+        if ($debug) {
+            error_log('WSSubscribeUserToCourse user_id: '.$user_id);
+        }
 
         if ($user_id == 0) {
             // If user was not found, there was a problem
@@ -4541,13 +4605,19 @@ 
                 // Course was not found
                 $resultValue = 0;
             } else {
-                if ($debug) error_log('WSSubscribeUserToCourse courseCode: '.$courseCode);
+                if ($debug) {
+                    error_log('WSSubscribeUserToCourse courseCode: '.$courseCode);
+                }
                 $result = CourseManager::add_user_to_course($user_id, $courseCode, $status, false);
                 if ($result) {
                     $resultValue = 1;
-                    if ($debug) error_log('WSSubscribeUserToCourse subscribed');
+                    if ($debug) {
+                        error_log('WSSubscribeUserToCourse subscribed');
+                    }
                 } else {
-                    if ($debug) error_log('WSSubscribeUserToCourse NOT subscribed: ');
+                    if ($debug) {
+                        error_log('WSSubscribeUserToCourse NOT subscribed: ');
+                    }
                 }
             }
         }
@@ -4606,8 +4676,12 @@ 
 function WSSubscribeUserToCourseSimple($params) {
     global $debug;
 
-    if ($debug) error_log('WSSubscribeUserToCourseSimple');
-    if ($debug) error_log('Params '. print_r($params, 1));
+    if ($debug) {
+        error_log('WSSubscribeUserToCourseSimple');
+    }
+    if ($debug) {
+        error_log('Params '. print_r($params, 1));
+    }
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
@@ -4625,7 +4699,9 @@ 
     if (empty($user_data)) {
         // If user was not found, there was a problem
         $result = "User $user_id does not exist";
-        if ($debug) error_log($result);
+        if ($debug) {
+            error_log($result);
+        }
         return $result;
     }
     if (!empty($course_code)) {
@@ -4633,14 +4709,22 @@ 
         if (empty($course_data)) {
             // Course was not found
             $result = "Course $course_code does not exist in the platform ";
-            if ($debug) error_log($result);
+            if ($debug) {
+                error_log($result);
+            }
         } else {
-            if ($debug) error_log('Try to register: user_id= '.$user_id.' to course: '.$course_data['code']);
+            if ($debug) {
+                error_log('Try to register: user_id= '.$user_id.' to course: '.$course_data['code']);
+            }
             if (!CourseManager::add_user_to_course($user_id, $course_data['code'], $status)) {
                 $result = 'User was not registered possible reasons: User already registered to the course, Course visibility doesnt allow user subscriptions ';
-                if ($debug) error_log($result);
+                if ($debug) {
+                    error_log($result);
+                }
             } else {
-                if ($debug) error_log('User registered to the course: '.$course_data['code']);
+                if ($debug) {
+                    error_log('User registered to the course: '.$course_data['code']);
+                }
                 $result = 1;
             }
         }
@@ -4693,8 +4777,12 @@ 
 function WSGetUser($params)
 {
     global $debug;
-    if ($debug) error_log('WSGetUser');
-    if ($debug) error_log('$params: '.print_r($params, 1));
+    if ($debug) {
+        error_log('WSGetUser');
+    }
+    if ($debug) {
+        error_log('$params: '.print_r($params, 1));
+    }
 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
@@ -4748,8 +4836,12 @@ 
 function WSGetUserFromUsername($params)
 {
     global $debug;
-    if ($debug) error_log('WSGetUserFromUsername');
-    if ($debug) error_log('$params: '.print_r($params, 1));
+    if ($debug) {
+        error_log('WSGetUserFromUsername');
+    }
+    if ($debug) {
+        error_log('$params: '.print_r($params, 1));
+    }
 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
@@ -5216,7 +5308,9 @@ 
                 SessionManager::suscribe_users_to_session($sessionId, array($user_id), SESSION_VISIBLE_READ_ONLY, false);
                 $results[] = 1;
 
-                if ($debug) error_log("subscribe user:$user_id to session $sessionId");
+                if ($debug) {
+                    error_log("subscribe user:$user_id to session $sessionId");
+                }
             }
         }
     } // end principal foreach
@@ -5300,7 +5394,9 @@ 
                 SESSION_VISIBLE_READ_ONLY,
                 false
             );
-            if ($debug) error_log('User registered to the course: '.$session_id);
+            if ($debug) {
+                error_log('User registered to the course: '.$session_id);
+            }
             $result = 1;
         }
     }
@@ -5448,7 +5544,9 @@ 
 
                 $results[] = 1;
 
-                if ($debug) error_log("Unsubscribe user:$user_id to session:$id_session");
+                if ($debug) {
+                    error_log("Unsubscribe user:$user_id to session:$id_session");
+                }
             }
         }
     } // end principal foreach
@@ -5595,7 +5693,9 @@ 
         return returnError(WS_ERROR_SECRET_KEY);
     }
 
-    if ($debug) error_log('WSSuscribeCoursesToSession: '.print_r($params, 1));
+    if ($debug) {
+        error_log('WSSuscribeCoursesToSession: '.print_r($params, 1));
+    }
 
     $coursessessions_params = $params['coursessessions'];
     $results = array();
@@ -5641,7 +5741,9 @@ 
                     array($courseInfo['real_id']),
                     false
                 );
-                if ($debug) error_log("add_courses_to_session: course:$courseCode to session:$sessionId");
+                if ($debug) {
+                    error_log("add_courses_to_session: course:$courseCode to session:$sessionId");
+                }
 
                 $results[] = 1;
             }
@@ -6914,7 +7016,9 @@ 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
-    if ($debug) error_log('WSAddUserVisibilityToCourseCatalogue params: '.print_r($params, 1));
+    if ($debug) {
+        error_log('WSAddUserVisibilityToCourseCatalogue params: '.print_r($params, 1));
+    }
 
     $results = array();
     $userscourses = $params['userscourses'];
@@ -6930,7 +7034,9 @@ 
             $original_user_id['original_user_id_value'],
             $original_user_id['original_user_id_name']
         );
-        if ($debug) error_log('WSAddUserVisibilityToCourseCatalogue userId: '.$userId);
+        if ($debug) {
+            error_log('WSAddUserVisibilityToCourseCatalogue userId: '.$userId);
+        }
 
         if ($userId == 0) {
             // If user was not found, there was a problem
@@ -6947,13 +7053,19 @@ 
                 // Course was not found
                 $resultValue = 0;
             } else {
-                if ($debug) error_log('WSAddUserVisibilityToCourseCatalogue courseCode: '.$courseCode);
+                if ($debug) {
+                    error_log('WSAddUserVisibilityToCourseCatalogue courseCode: '.$courseCode);
+                }
                 $result = CourseManager::addUserVisibilityToCourseInCatalogue($userId, $courseCode, $visible);
                 if ($result) {
                     $resultValue = 1;
-                    if ($debug) error_log('WSAddUserVisibilityToCourseCatalogue registered');
+                    if ($debug) {
+                        error_log('WSAddUserVisibilityToCourseCatalogue registered');
+                    }
                 } else {
-                    if ($debug) error_log('WSAddUserVisibilityToCourseCatalogue NOT registered: ');
+                    if ($debug) {
+                        error_log('WSAddUserVisibilityToCourseCatalogue NOT registered: ');
+                    }
                 }
             }
         }
@@ -6986,7 +7098,9 @@ 
     if (!WSHelperVerifyKey($params)) {
         return returnError(WS_ERROR_SECRET_KEY);
     }
-    if ($debug) error_log('WSRemoveUserVisibilityToCourseInCatalogue params: '.print_r($params, 1));
+    if ($debug) {
+        error_log('WSRemoveUserVisibilityToCourseInCatalogue params: '.print_r($params, 1));
+    }
 
     $results = array();
     $userscourses = $params['userscourses'];
@@ -7002,7 +7116,9 @@ 
             $original_user_id['original_user_id_value'],
             $original_user_id['original_user_id_name']
         );
-        if ($debug) error_log('WSRemoveUserVisibilityToCourseInCatalogue user_id: '.$userId);
+        if ($debug) {
+            error_log('WSRemoveUserVisibilityToCourseInCatalogue user_id: '.$userId);
+        }
 
         if ($userId == 0) {
             // If user was not found, there was a problem
@@ -7020,13 +7136,19 @@ 
                 // Course was not found
                 $resultValue = 0;
             } else {
-                if ($debug) error_log('WSRemoveUserVisibilityToCourseInCatalogue courseCode: '.$courseCode);
+                if ($debug) {
+                    error_log('WSRemoveUserVisibilityToCourseInCatalogue courseCode: '.$courseCode);
+                }
                 $result = CourseManager::removeUserVisibilityToCourseInCatalogue($userId, $courseCode, $visible);
                 if ($result) {
                     $resultValue = 1;
-                    if ($debug) error_log('WSRemoveUserVisibilityToCourseInCatalogue removed');
+                    if ($debug) {
+                        error_log('WSRemoveUserVisibilityToCourseInCatalogue removed');
+                    }
                 } else {
-                    if ($debug) error_log('WSRemoveUserVisibilityToCourseInCatalogue NOT removed: ');
+                    if ($debug) {
+                        error_log('WSRemoveUserVisibilityToCourseInCatalogue NOT removed: ');
+                    }
                 }
             }
         }

plugin/ims_lti/OAuthSimple.php

Braces +7 added lines, -12 removed lines

@@ -74,8 +74,7 @@ 
         if (empty($this->_parameters))
 		{
 			$this->_parameters = $parameters;
-		}
-        else if (!empty($parameters))
+		} else if (!empty($parameters))
 		{
 			$this->_parameters = array_merge($this->_parameters,$parameters);
 		}
@@ -324,8 +323,7 @@ 
                 {
                     $result .= $pName .'="' . self::_oauthEscape($val) . '", ';
                 }
-            }
-            else
+            } else
             {
                 $result .= $pName . '="' . self::_oauthEscape($pValue) . '", ';
             }
@@ -350,14 +348,13 @@ 
                 if (!is_array($result[$key]))
 				{
                     $result[$key] = array($result[$key],$token);
-				}
-                else
+				} else
 				{
                     array_push($result[$key],$token);
 				}
+            } else {
+                            $result[$key]=$token;
             }
-            else
-                $result[$key]=$token;
         }
         return $result;
     }
@@ -447,8 +444,7 @@ 
 					{
 						array_push($normalized_keys[self::_oauthEscape($paramName)],  self::_oauthEscape($item));
 					}
-				}
-				else
+				} else
 				{
 					$normalized_keys[self::_oauthEscape($paramName)] = self::_oauthEscape($paramValue);
 				}
@@ -466,8 +462,7 @@ 
 				{
 					array_push($return_array, $key . "=" . $element);
 				}
-			}
-			else
+			} else
 			{
 				array_push($return_array, $key .'='. $val);
 			}