chamilo /
chamilo-lms
| Conditions | 10 |
| Paths | 12 |
| Total Lines | 29 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function __construct($type = 'config', $params) |
||
| 26 | { |
||
| 27 | if (isset($params)) { |
||
| 28 | switch ($type) { |
||
| 29 | case 'db': |
||
| 30 | // TODO: Implement this way of object creation. |
||
| 31 | break; |
||
| 32 | case 'config': // Do the same as the default. |
||
| 33 | default: |
||
| 34 | foreach ($params as $a => $value) { |
||
| 35 | switch ($a) { |
||
| 36 | case 'system_id': |
||
| 37 | $this->identifier = strtolower($value); |
||
| 38 | break; |
||
| 39 | case 'member': |
||
| 40 | if (strstr($value, ',') !== false) { |
||
| 41 | $temp = explode(',', $value); |
||
| 42 | foreach ($temp as $val) { |
||
| 43 | if (!empty($val)) { |
||
| 44 | $this->members[] = $val; |
||
| 45 | } |
||
| 46 | } |
||
| 47 | } |
||
| 48 | break; |
||
| 49 | } |
||
| 50 | } |
||
| 51 | } |
||
| 52 | } |
||
| 53 | } |
||
| 54 | } |
||
| 55 |
