chamilo / chamilo-lms

src/Chamilo/CoreBundle/Entity/ExtraField.php

Indentation +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
  *
  * @ORM\MappedSuperclass
  */
- class ExtraField// extends BaseAttribute
+    class ExtraField// extends BaseAttribute
 {
     const USER_FIELD_TYPE = 1;
     const COURSE_FIELD_TYPE = 2;
@@ -263,9 +263,9 @@ 
         return $this;
     }
 
-     /**
-     * @return boolean
-     */
+        /**
+         * @return boolean
+         */
     public function isChangeable()
     {
         return $this->changeable;

Braces +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
  * @ORM\MappedSuperclass
  */
  class ExtraField// extends BaseAttribute
-{
+ {
     const USER_FIELD_TYPE = 1;
     const COURSE_FIELD_TYPE = 2;
     const SESSION_FIELD_TYPE = 3;

main/gradebook/lib/user_data_generator.class.php

Doc Comments +4 added lines, -4 removed lines

@@ -285,7 +285,7 @@ 
 
     /**
      * @param $item
-     * @param $ignore_score_color
+     * @param boolean $ignore_score_color
      * @return string
      */
     private function build_average_column($item, $ignore_score_color)
@@ -306,7 +306,7 @@ 
 
     /**
      * @param $item
-     * @param $ignore_score_color
+     * @param boolean $ignore_score_color
      * @return string
      */
     private function build_result_column($item, $ignore_score_color)
@@ -323,7 +323,7 @@ 
 
     /**
      * @param $item
-     * @param $ignore_score_color
+     * @param boolean $ignore_score_color
      * @return string
      */
     private function build_mask_column($item, $ignore_score_color)
@@ -339,7 +339,7 @@ 
 
     /**
      * @param $coursecode
-     * @return mixed
+     * @return string
      */
     private function get_course_name_from_code_cached($coursecode)
     {

src/Chamilo/SettingsBundle/Manager/SettingsManager.php

Doc Comments +8 added lines, -5 removed lines

@@ -125,7 +125,7 @@ 
 
     /**
      * Get variables and categories as in 1.11.x
-     * @return array
+     * @return string
      */
     public function getVariablesAndCategories()
     {
@@ -428,7 +428,7 @@ 
     /**
      * Rename old variable with variable used in Chamilo 2.0
      * @param string $variable
-     * @return mixed
+     * @return string
      */
     public function renameVariable($variable)
     {
@@ -464,7 +464,7 @@ 
      * Replace old Chamilo 1.x category with 2.0 version
      * @param string $variable
      * @param string $defaultCategory
-     * @return mixed
+     * @return string
      */
     public function fixCategory($variable, $defaultCategory)
     {
@@ -558,8 +558,8 @@ 
     }
 
     /**
-     * @param $name
-     * @return mixed
+     * @param string $name
+     * @return string
      * @throws \InvalidArgumentException
      */
     public function getSetting($name)
@@ -843,6 +843,9 @@ 
         return $parameters;
     }
 
+    /**
+     * @param string $namespace
+     */
     public function getParametersFromKeyword($namespace, $keyword = '')
     {
         $criteria = array('category' => $namespace);

Spacing +3 added lines, -3 removed lines

@@ -141,7 +141,7 @@ 
             'Institution' => 'Platform',
             'InstitutionUrl' => 'Platform',
             'siteName' => 'Platform',
-            'emailAdministrator' => 'admin',//'emailAdministrator' => 'Platform',
+            'emailAdministrator' => 'admin', //'emailAdministrator' => 'Platform',
             'administratorSurname' => 'admin',
             'administratorTelephone' => 'admin',
             'administratorName' => 'admin',
@@ -252,11 +252,11 @@ 
             'allow_send_message_to_all_platform_users' => 'Tools',
             'message_max_upload_filesize' => 'Tools',
             'use_users_timezone' => 'profile', //'use_users_timezone' => 'Timezones',
-            'timezone_value' => 'platform',//'timezone_value' => 'Timezones',
+            'timezone_value' => 'platform', //'timezone_value' => 'Timezones',
             'allow_user_course_subscription_by_course_admin' => 'Security',
             'show_link_bug_notification' => 'Platform',
             'show_link_ticket_notification' => 'Platform',
-            'course_validation' => 'course',//'course_validation' => 'Platform',
+            'course_validation' => 'course', //'course_validation' => 'Platform',
             'course_validation_terms_and_conditions_url' => 'Platform',
             'sso_authentication' => 'Security',
             'sso_authentication_domain' => 'Security',

Indentation +1 added lines, -1 removed lines

@@ -686,7 +686,7 @@
             $settings->setSchemaAlias($schemaAlias);
         }
 
-         // We need to get a plain parameters array since we use the options resolver on it
+            // We need to get a plain parameters array since we use the options resolver on it
         //$parameters = $settings->getParameters();
         $parameters = $this->getParameters($schemaAliasNoPrefix);
 

main/inc/lib/fileManage.lib.php

Indentation +41 added lines, -41 removed lines

@@ -132,38 +132,38 @@ 
  */
 function my_rename($file_path, $new_file_name) {
 
-	$save_dir = getcwd();
-	$path = dirname($file_path);
-	$old_file_name = basename($file_path);
-	$new_file_name = api_replace_dangerous_char($new_file_name);
+    $save_dir = getcwd();
+    $path = dirname($file_path);
+    $old_file_name = basename($file_path);
+    $new_file_name = api_replace_dangerous_char($new_file_name);
 
-	// If no extension, take the old one
-	if ((strpos($new_file_name, '.') === false) && ($dotpos = strrpos($old_file_name, '.'))) {
-		$new_file_name .= substr($old_file_name, $dotpos);
-	}
+    // If no extension, take the old one
+    if ((strpos($new_file_name, '.') === false) && ($dotpos = strrpos($old_file_name, '.'))) {
+        $new_file_name .= substr($old_file_name, $dotpos);
+    }
 
-	// Note: still possible: 'xx.yy' -rename-> '.yy' -rename-> 'zz'
-	// This is useful for folder names, where otherwise '.' would be sticky
+    // Note: still possible: 'xx.yy' -rename-> '.yy' -rename-> 'zz'
+    // This is useful for folder names, where otherwise '.' would be sticky
 
-	// Extension PHP is not allowed, change to PHPS
-	$new_file_name = php2phps($new_file_name);
+    // Extension PHP is not allowed, change to PHPS
+    $new_file_name = php2phps($new_file_name);
 
-	if ($new_file_name == $old_file_name) {
-		return $old_file_name;
-	}
+    if ($new_file_name == $old_file_name) {
+        return $old_file_name;
+    }
 
-	if (strtolower($new_file_name) != strtolower($old_file_name) && check_name_exist($path.'/'.$new_file_name)) {
-		return false;
-	}
-	// On a Windows server, it would be better not to do the above check
-	// because it succeeds for some new names resembling the old name.
-	// But on Unix/Linux the check must be done because rename overwrites.
+    if (strtolower($new_file_name) != strtolower($old_file_name) && check_name_exist($path.'/'.$new_file_name)) {
+        return false;
+    }
+    // On a Windows server, it would be better not to do the above check
+    // because it succeeds for some new names resembling the old name.
+    // But on Unix/Linux the check must be done because rename overwrites.
 
-	chdir($path);
-	$res = rename($old_file_name, $new_file_name) ? $new_file_name : false;
-	chdir($save_dir);
+    chdir($path);
+    $res = rename($old_file_name, $new_file_name) ? $new_file_name : false;
+    chdir($save_dir);
 
-	return $res;
+    return $res;
 }
 
 /**
@@ -185,7 +185,7 @@ 
         $file_name = basename($source);
         // move onto self illegal: mv a/b/c a/b/c or mv a/b/c a/b
         if (strcasecmp($target, dirname($source)) === 0) {
-               return false;
+                return false;
         }
         $isWindowsOS = api_is_windows_os();
         $canExec = function_exists('exec');
@@ -265,8 +265,8 @@ 
  */
 function getextension($filename)
 {
-	$bouts = explode('.', $filename);
-	return array(array_pop($bouts), implode('.', $bouts));
+    $bouts = explode('.', $filename);
+    return array(array_pop($bouts), implode('.', $bouts));
 }
 
 /**
@@ -277,17 +277,17 @@ 
  * @param 	boolean $recursive if true , include subdirectory in total
  */
 function dirsize($root, $recursive = true) {
-	$dir = @opendir($root);
-	$size = 0;
-	while ($file = @readdir($dir)) {
-		if (!in_array($file, array('.', '..'))) {
-			if (is_dir($root.'/'.$file)) {
-				$size += $recursive ? dirsize($root.'/'.$file) : 0;
-			} else {
-				$size += @filesize($root.'/'.$file);
-			}
-		}
-	}
-	@closedir($dir);
-	return $size;
+    $dir = @opendir($root);
+    $size = 0;
+    while ($file = @readdir($dir)) {
+        if (!in_array($file, array('.', '..'))) {
+            if (is_dir($root.'/'.$file)) {
+                $size += $recursive ? dirsize($root.'/'.$file) : 0;
+            } else {
+                $size += @filesize($root.'/'.$file);
+            }
+        }
+    }
+    @closedir($dir);
+    return $size;
 }

Doc Comments +4 added lines, -4 removed lines

@@ -39,8 +39,8 @@ 
  * Deletes a file or a directory
  *
  * @author - Hugues Peeters
- * @param  $file (String) - the path of file or directory to delete
- * @return boolean - true if the delete succeed, false otherwise.
+ * @param  string $file (String) - the path of file or directory to delete
+ * @return boolean|null - true if the delete succeed, false otherwise.
  * @see    - delete() uses check_name_exist() and removeDir() functions
  */
 function my_delete($file)
@@ -127,7 +127,7 @@ 
  * @author Hugues Peeters <peeters@ipm.ucl.ac.be>
  * @param  string $file_path complete path of the file or the directory
  * @param  string $new_file_name new name for the file or the directory
- * @return boolean true if succeed, false otherwise
+ * @return string|false true if succeed, false otherwise
  * @see rename() uses the check_name_exist() and php2phps() functions
  */
 function my_rename($file_path, $new_file_name) {
@@ -174,7 +174,7 @@ 
  * @param  string $target the path of the new area
  * @param  bool $forceMove Whether to force a move or to make a copy (safer but slower) and then delete the original
  * @param	bool $moveContent In some cases (including migrations), we need to move the *content* and not the folder itself
- * @return bool true if the move succeed, false otherwise.
+ * @return boolean|null true if the move succeed, false otherwise.
  * @see move() uses check_name_exist() and copyDirTo() functions
  */
 function move($source, $target, $forceMove = true, $moveContent = false)

Braces +8 added lines, -4 removed lines

@@ -46,10 +46,12 @@ 
 function my_delete($file)
 {
     if (check_name_exist($file)) {
-        if (is_file($file)) { // FILE CASE
+        if (is_file($file)) {
+// FILE CASE
             unlink($file);
             return true;
-        } elseif (is_dir($file)) { // DIRECTORY CASE
+        } elseif (is_dir($file)) {
+// DIRECTORY CASE
             removeDir($file);
             return true;
         }
@@ -130,7 +132,8 @@ 
  * @return boolean true if succeed, false otherwise
  * @see rename() uses the check_name_exist() and php2phps() functions
  */
-function my_rename($file_path, $new_file_name) {
+function my_rename($file_path, $new_file_name)
+{
 
 	$save_dir = getcwd();
 	$path = dirname($file_path);
@@ -276,7 +279,8 @@ 
  * @param 	string	$root path of dir to measure
  * @param 	boolean $recursive if true , include subdirectory in total
  */
-function dirsize($root, $recursive = true) {
+function dirsize($root, $recursive = true)
+{
 	$dir = @opendir($root);
 	$size = 0;
 	while ($file = @readdir($dir)) {

src/Chamilo/SettingsBundle/Twig/SettingsExtension.php

Indentation +6 added lines, -6 removed lines

@@ -31,9 +31,9 @@ 
     public function getFunctions()
     {
         return array(
-             new \Twig_SimpleFunction('chamilo_settings_all', array($this, 'getSettings')),
-             new \Twig_SimpleFunction('chamilo_settings_get', array($this, 'getSettingsParameter')),
-             new \Twig_SimpleFunction('chamilo_settings_has', [$this, 'hasSettingsParameter']),
+                new \Twig_SimpleFunction('chamilo_settings_all', array($this, 'getSettings')),
+                new \Twig_SimpleFunction('chamilo_settings_get', array($this, 'getSettingsParameter')),
+                new \Twig_SimpleFunction('chamilo_settings_has', [$this, 'hasSettingsParameter']),
         );
     }
 
@@ -44,9 +44,9 @@ 
     public function getFilters()
     {
         return array(
-             //new \Twig_SimpleFunction('chamilo_settings_all', array($this, 'getSettings')),
-             new \Twig_SimpleFilter('get_setting', array($this, 'getSettingsParameter')),
-             //new \Twig_SimpleFunction('chamilo_settings_has', [$this, 'hasSettingsParameter']),
+                //new \Twig_SimpleFunction('chamilo_settings_all', array($this, 'getSettings')),
+                new \Twig_SimpleFilter('get_setting', array($this, 'getSettingsParameter')),
+                //new \Twig_SimpleFunction('chamilo_settings_has', [$this, 'hasSettingsParameter']),
         );
     }
 

Doc Comments +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
      *
      * @param string $namespace
      *
-     * @return array
+     * @return \Sylius\Bundle\SettingsBundle\Model\SettingsInterface
      */
     public function getSettings($namespace)
     {
@@ -65,7 +65,7 @@ 
 
     /**
      * @param $name
-     * @return mixed
+     * @return string
      */
     public function getSettingsParameter($name)
     {

main/inc/lib/course_home.lib.php

Indentation +1 added lines, -1 removed lines

@@ -996,7 +996,7 @@
             }
         }
 
-         return array(
+            return array(
             'content' => $html,
             'tool_list' => $items
         );

Doc Comments +3 added lines, -2 removed lines

@@ -218,7 +218,7 @@ 
     /**
      * Displays the tools of a certain category.
      *
-     * @return void
+     * @return string
      * @param string $course_tool_category	contains the category of tools to display:
      * "Public", "PublicButHide", "courseAdmin", "claroAdmin"
      */
@@ -1014,6 +1014,7 @@ 
      * Shows the general data for a particular meeting
      *
      * @param id	session id
+     * @param integer $id_session
      * @return string	session data
      */
     public static function show_session_data($id_session)
@@ -1517,7 +1518,7 @@ 
 
     /**
      * Available tools
-     * @return array
+     * @return string[]
      */
     public static function availableTools()
     {

Spacing +2 added lines, -2 removed lines

@@ -1179,8 +1179,8 @@
 
         $toolName = api_underscore_to_camel_case($toolName);
 
-        if (isset($GLOBALS['Tool' . $toolName])) {
-            return get_lang('Tool' . $toolName);
+        if (isset($GLOBALS['Tool'.$toolName])) {
+            return get_lang('Tool'.$toolName);
         }
 
         return $toolName;

main/inc/lib/MoodleImport.php

Doc Comments +8 added lines, -8 removed lines

@@ -403,7 +403,7 @@ 
      * Read and validate the quiz module XML
      *
      * @param resource $moduleXml XML file
-     * @return mixed | array if is a valid xml file, false otherwise
+     * @return string | array if is a valid xml file, false otherwise
      */
     public function readQuizModule($moduleXml)
     {
@@ -621,7 +621,7 @@ 
      * Fix moodle files that contains spaces
      * @param array $importedFiles
      * @param string $text
-     * @return mixed
+     * @return string
      */
     public function fixPathInText($importedFiles, &$text)
     {
@@ -642,10 +642,10 @@ 
      *
      * @param array $questionList
      * @param string $questionType
-     * @param object $questionInstance Question/Answer instance
+     * @param Question $questionInstance Question/Answer instance
      * @param array $currentQuestion
      * @param array $importedFiles
-     * @return integer db response
+     * @return boolean|null db response
      */
     public function processAnswers($questionList, $questionType, $questionInstance, $currentQuestion, $importedFiles)
     {
@@ -800,7 +800,7 @@ 
     /**
      * Process Chamilo Unique Answer
      *
-     * @param object $objAnswer
+     * @param Answer $objAnswer
      * @param array $answerValues
      * @param integer $position
      * @param integer $questionWeighting
@@ -836,7 +836,7 @@ 
     /**
      * Process Chamilo True False
      *
-     * @param object $objAnswer
+     * @param Answer $objAnswer
      * @param array $answerValues
      * @param integer $position
      * @param integer $questionWeighting
@@ -873,7 +873,7 @@ 
     /**
      * Process Chamilo FillBlanks
      *
-     * @param object $objAnswer
+     * @param Answer $objAnswer
      * @param array $questionType
      * @param array $answerValues
      * @param string $placeholder
@@ -1026,7 +1026,7 @@ 
      * Litle utility to delete the unuseful tags
      *
      * @param $array
-     * @param $keys
+     * @param string[] $keys
      */
     public function traverseArray(&$array, $keys)
     {

plugin/vchamilo/lib/Virtual.php

Doc Comments +9 added lines, -7 removed lines

@@ -184,7 +184,7 @@ 
     * provides a side connection to a vchamilo database
     * @param array $_configuration
      *
-    * @return \Doctrine\DBAL\Driver\Connection
+    * @return string
     */
     public static function bootConnection(&$_configuration)
     {
@@ -372,7 +372,7 @@ 
 
     /**
     * get a proper SQLdump command
-    * @param object $vchamilodata the complete new host information
+    * @param stdClass $vchamilodata the complete new host information
     * @return string the shell command
     */
     public static function getDatabaseDumpCmd($vchamilodata)
@@ -456,8 +456,8 @@ 
 
     /**
      * Backups a database for having a snapshot.
-     * @param        $vchamilo    object        The Vchamilo object.
-     * @param        $outputfilerad    string        The output SQL file radical.
+     * @param        stdClass $vchamilo    object        The Vchamilo object.
+     * @param        string $outputfilerad    string        The output SQL file radical.
      * @return        bool    If TRUE, dumping database was a success, otherwise FALSE.
      */
     public static function backupDatabase($vchamilo, $outputfilerad)
@@ -619,6 +619,8 @@ 
     * this function set will map standard moodle API calls to chamilo
     * internal primitives. This avoids too many changes to do in imported
     * code
+    * @param string $module
+    * @param string $key
     */
     public static function getConfig($module, $key, $isplugin = true)
     {
@@ -698,7 +700,7 @@ 
     /**
      * @param string $path
      *
-     * @return mixed
+     * @return string
      */
     public static function chopLastSlash($path)
     {
@@ -852,7 +854,7 @@ 
 
     /**
      * @param object $instance
-     * @return bool|\Doctrine\DBAL\Connection
+     * @return Doctrine\ORM\EntityManagerInterface
      */
     public static function getConnectionFromInstance($instance, $getManager = false)
     {
@@ -1297,7 +1299,7 @@ 
     /**
      * @param stdClass $instance
      *
-     * @return bool|string returns the original version of the app
+     * @return string|false returns the original version of the app
      */
     public static function canBeUpgraded($instance)
     {

Indentation +20 added lines, -20 removed lines

@@ -186,11 +186,11 @@ 
     }
 
     /**
-    * provides a side connection to a vchamilo database
-    * @param array $_configuration
+     * provides a side connection to a vchamilo database
+     * @param array $_configuration
      *
-    * @return \Doctrine\DBAL\Driver\Connection
-    */
+     * @return \Doctrine\DBAL\Driver\Connection
+     */
     public static function bootConnection(&$_configuration)
     {
         $dbParams = array(
@@ -298,10 +298,10 @@ 
     }
 
     /**
-    * drop a vchamilo instance databases using the physical connection
-    * @param stdClass $params
-    * return an array of errors or false if ok
-    */
+     * drop a vchamilo instance databases using the physical connection
+     * @param stdClass $params
+     * return an array of errors or false if ok
+     */
     public static function dropDatabase($params)
     {
         $params = clone $params;
@@ -376,10 +376,10 @@ 
     }
 
     /**
-    * get a proper SQLdump command
-    * @param object $vchamilodata the complete new host information
-    * @return string the shell command
-    */
+     * get a proper SQLdump command
+     * @param object $vchamilodata the complete new host information
+     * @return string the shell command
+     */
     public static function getDatabaseDumpCmd($vchamilodata)
     {
         $pgm = self::getConfig('vchamilo', 'mysql_cmd');
@@ -536,8 +536,8 @@ 
     }
 
     /**
-    * read manifest values in vchamilo template.
-    */
+     * read manifest values in vchamilo template.
+     */
     public static function getVmanifest($version)
     {
         $templatewwwroot = '';
@@ -558,8 +558,8 @@ 
     }
 
     /**
-    * make a fake vchamilo that represents the current host
-    */
+     * make a fake vchamilo that represents the current host
+     */
     public static function makeThis()
     {
         global $_configuration;
@@ -623,10 +623,10 @@ 
     }
 
     /**
-    * this function set will map standard moodle API calls to chamilo
-    * internal primitives. This avoids too many changes to do in imported
-    * code
-    */
+     * this function set will map standard moodle API calls to chamilo
+     * internal primitives. This avoids too many changes to do in imported
+     * code
+     */
     public static function getConfig($module, $key, $isplugin = true)
     {
         if ($isplugin) {

Braces +2 added lines, -1 removed lines

@@ -173,7 +173,8 @@
         $_configuration['vchamilo_web_root'] = "{$protocol}://".@$_SERVER['HTTP_HOST'].$contentPrefix;
 
         $_configuration['vchamilo_name'] = @$_SERVER['HTTP_HOST'];
-        if (empty($_configuration['vchamilo_name'])) { // try again with another source if has failed
+        if (empty($_configuration['vchamilo_name'])) {
+// try again with another source if has failed
             $_configuration['vchamilo_name'] = "{$protocol}://".$_SERVER['SERVER_NAME'];
             if ($_SERVER['SERVER_PORT'] != 80) {
                 $_configuration['vchamilo_name'] .= ':'.$_SERVER['SERVER_PORT'];

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -667,7 +667,7 @@ 
 
         // get the protocol free hostname
         Display::addFlash(
-            Display::return_message("Copying {$templateDir}/data/courses => $coursePath")
+            Display::return_message("copying {$templateDir}/data/courses => $coursePath")
         );
 
         copyDirTo(
@@ -677,7 +677,7 @@ 
         );
 
         Display::addFlash(
-            Display::return_message("Copying {$templateDir}/data/archive => $archivePath")
+            Display::return_message("copying {$templateDir}/data/archive => $archivePath")
         );
 
         copyDirTo(
@@ -687,7 +687,7 @@ 
         );
 
         Display::addFlash(
-            Display::return_message("Copying {$templateDir}/data/home => $homePath")
+            Display::return_message("copying {$templateDir}/data/home => $homePath")
         );
 
         copyDirTo(
@@ -698,7 +698,7 @@ 
 
         // Upload
         Display::addFlash(
-            Display::return_message("Copying {$templateDir}/data/upload => $uploadPath")
+            Display::return_message("copying {$templateDir}/data/upload => $uploadPath")
         );
 
         copyDirTo(
@@ -1029,13 +1029,13 @@ 
         $sitename = Database::escape_string($data->sitename);
         $institution = Database::escape_string($data->institution);
 
-        $sqls[] = "UPDATE {$settingstable} SET selected_value = '{$sitename}' 
+        $sqls[] = "update {$settingstable} SET selected_value = '{$sitename}' 
                    WHERE variable = 'siteName' AND category = 'Platform' ";
 
-        $sqls[] = "UPDATE {$settingstable} SET selected_value = '{$institution}' 
+        $sqls[] = "update {$settingstable} SET selected_value = '{$institution}' 
                    WHERE variable = 'institution' AND category = 'Platform' ";
 
-        $sqls[] = "UPDATE {$accessurltable} SET url = '{$data->root_web}' WHERE id = '1' ";
+        $sqls[] = "update {$accessurltable} SET url = '{$data->root_web}' WHERE id = '1' ";
 
         foreach ($sqls as $sql) {
             Database::query($sql);

plugin/google_maps/src/GoogleMapsPlugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     /**
      * Install the plugin
-     * @return void
+     * @return boolean
      */
     public function install()
     {
@@ -52,7 +52,7 @@ 
 
     /**
      * Uninstall the plugin
-     * @return void
+     * @return boolean
      */
     public function uninstall()
     {