chamilo / chamilo-lms

main/lp/openoffice_document.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -186,9 +186,9 @@
 
     /**
      * Get images files from remote host (with webservices)
-     * @param   array $file current ppt file details
+     * @param   string $file current ppt file details
      * @param   string  $size The expected final size of the rendered slides
-     * @return  array images files
+     * @return  string images files
      */
     private function _get_remote_ppt2lp_files($file, $size = null)
     {

Indentation +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         // Create the directory
         $result = $this->generate_lp_folder($_course, $this->file_name);
 
-         // Create the directory
+            // Create the directory
         $this->base_work_dir = api_get_path(SYS_COURSE_PATH).$_course['path'].'/document';
         ///learning_path/ppt_dirname directory
         $this->created_dir = $result['dir'];

Braces +8 added lines, -4 removed lines

@@ -103,7 +103,8 @@ 
             //var_dump( $this->base_work_dir.$this->created_dir.$this->file_path);
             $perm = api_get_setting('permissions_for_new_files');
 
-            if (IS_WINDOWS_OS) { // IS_WINDOWS_OS has been defined in main_api.lib.php
+            if (IS_WINDOWS_OS) {
+// IS_WINDOWS_OS has been defined in main_api.lib.php
                 $converter_path = str_replace('/', '\\', api_get_path(SYS_PATH).'main/inc/lib/ppt2png');
                 $class_path = $converter_path.';'.$converter_path.'/jodconverter-2.2.2.jar;'.$converter_path.'/jodconverter-cli-2.2.2.jar';
                 //$cmd = 'java -cp "'.$class_path.'" DokeosConverter';
@@ -130,7 +131,8 @@ 
             $return = 0;
             $shell = exec($cmd, $files, $return);
 
-            if ($return != 0) { // If the java application returns an error code.
+            if ($return != 0) {
+// If the java application returns an error code.
                 switch ($return) {
                     case 1:
                         // Can't connect to openoffice.
@@ -285,7 +287,8 @@ 
         }
 
         if ($ppt2lpHost == 'localhost') {
-            if (IS_WINDOWS_OS) { // IS_WINDOWS_OS has been defined in main_api.lib.php
+            if (IS_WINDOWS_OS) {
+// IS_WINDOWS_OS has been defined in main_api.lib.php
                 $converterPath = str_replace('/', '\\', api_get_path(SYS_PATH).'main/inc/lib/ppt2png');
                 $classPath = $converterPath.';'.$converterPath.'/jodconverter-2.2.2.jar;'.$converterPath.'/jodconverter-cli-2.2.2.jar';
                 $cmd = 'java -Dfile.encoding=UTF-8 -jar "'.$classPath.'/jodconverter-2.2.2.jar"';
@@ -312,7 +315,8 @@ 
             @chown($this->base_work_dir.'/'.$this->created_dir, 'www-data');
             @chmod($this->base_work_dir.'/'.$this->created_dir, $permissionFile);
 
-            if ($return != 0) { // If the java application returns an error code.
+            if ($return != 0) {
+// If the java application returns an error code.
                 switch ($return) {
                     case 1:
                         // Can't connect to openoffice.

main/exercise/hotpotatoes_exercise_report.php

Indentation +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
 }
 
 if (!$is_allowedToEdit) {
-   // api_not_allowed();
+    // api_not_allowed();
 }
 
 if (!empty($_REQUEST['path'])) {
@@ -189,8 +189,8 @@ 
         get_lang('Actions')
     );
 
-  // Column config
-  // @todo fix search firstname/lastname that doesn't work. rmove search for the moment
+    // Column config
+    // @todo fix search firstname/lastname that doesn't work. rmove search for the moment
     $column_model = array(
         array('name' => 'firstname', 'index' => 'firstname', 'width' => '50', 'align' => 'left', 'search' => 'false'),
         array(

main/lp/learnpathItem.class.php

Doc Comments +5 added lines, -5 removed lines

@@ -1869,7 +1869,7 @@ 
 
     /**
      * Get the extra terms (tags) that identify this item
-     * @return mixed
+     * @return string
      */
     public function get_terms()
     {
@@ -2069,7 +2069,7 @@ 
 
     /**
      * Opens/launches the item. Initialises runtime values.
-     * @return    boolean    True on success, false on failure.
+     * @return    boolean|null    True on success, false on failure.
      */
     public function open($allow_new_attempt = false)
     {
@@ -3504,7 +3504,7 @@ 
 
     /**
      * Checks if the current status is part of the list of status given
-     * @param  array  $list  An array of status to check for.
+     * @param  string[]  $list  An array of status to check for.
      * If the current status is one of the strings, return true
      *
      * @return boolean True if the status was one of the given strings,
@@ -3681,7 +3681,7 @@ 
     /**
      * Write objectives to DB. This method is separate from write_to_db() because otherwise
      * objectives are lost as a side effect to AJAX and session concurrent access
-     * @return    boolean        True or false on error
+     * @return    boolean|null        True or false on error
      */
     public function write_objectives_to_db()
     {
@@ -4322,7 +4322,7 @@ 
      * Removes the relation between the current item and an audio file. The file
      * is only removed from the lp_item table, but remains in the document table
      * and directory
-     * @return bool
+     * @return false|null
      */
     public function remove_audio()
     {

Braces +9 added lines, -6 removed lines

@@ -752,7 +752,8 @@ 
     public function get_lesson_mode()
     {
         $mode = 'normal';
-        if ($this->get_prevent_reinit() != 0) { // If prevent_reinit == 0
+        if ($this->get_prevent_reinit() != 0) {
+// If prevent_reinit == 0
             $my_status = $this->get_status();
             if ($my_status != $this->possible_status[0]
                     && $my_status != $this->possible_status[1]) {
@@ -2044,11 +2045,13 @@ 
         $restart = 1;
         $mystatus = $this->get_status(true);
         if ($this->get_prevent_reinit() > 0
-        ) { // If prevent_reinit == 1 (or more)
+        ) {
+// If prevent_reinit == 1 (or more)
             // If status is not attempted or incomplete, authorize retaking (of the same) anyway. Otherwise:
             if ($mystatus != $this->possible_status[0] && $mystatus != $this->possible_status[1]) {
                 $restart = -1;
-            } else { //status incompleted or not attempted
+            } else {
+//status incompleted or not attempted
                 $restart = 0;
             }
         } else {
@@ -2989,7 +2992,8 @@ 
                     // Do nothing, just let the local attributes be used.
                 }
             }
-        } else { // If not SCO, such messages should not be expected.
+        } else {
+// If not SCO, such messages should not be expected.
             $type = strtolower($this->type);
             switch ($type) {
                 case 'asset':
@@ -3429,8 +3433,7 @@ 
         }
         if ($scorm_time == '0'
                 and ($this->type != 'sco')
-                and $this->current_start_time != 0)
-        {
+                and $this->current_start_time != 0) {
             $my_time = time() - $this->current_start_time;
             if ($my_time > 0) {
                 $this->update_time($my_time);

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -3386,7 +3386,7 @@ 
 
         // TODO: Validate csv string.
         $terms = Database::escape_string(api_htmlentities($new_terms_string, ENT_QUOTES, $charset));
-        $sql = "UPDATE $lp_item
+        $sql = "update $lp_item
                 SET terms = '$terms'
                 WHERE
                     c_id = $course_id AND
@@ -3653,7 +3653,7 @@ 
         if ($this->seriousgame_mode != 1 ||
             !in_array($row['status'], $case_completed)
         ) {
-            $sql = "UPDATE $item_view_table
+            $sql = "update $item_view_table
                       SET total_time = '$total_time'
                     WHERE 
                         c_id = $course_id AND 
@@ -3733,7 +3733,7 @@ 
                         // Update (or don't).
                         $iva_row = Database::fetch_array($iva_res);
                         $iva_id = $iva_row[0];
-                        $ivau_sql = "UPDATE $iva_table ".
+                        $ivau_sql = "update $iva_table ".
                             "SET objective_id = '".Database::escape_string($objective[0])."',".
                             "status = '".Database::escape_string($objective[1])."',".
                             "score_raw = '".Database::escape_string($objective[2])."',".
@@ -3756,7 +3756,7 @@ 
 
                         $insertId = Database::insert($iva_table, $params);
 
-                        $sql = "UPDATE $iva_table SET id = iid WHERE iid = $insertId";
+                        $sql = "update $iva_table SET id = iid WHERE iid = $insertId";
                         Database::query($sql);
                     }
                 }
@@ -3862,7 +3862,7 @@ 
                 $this->db_item_view_id = Database::insert($item_view_table, $params);
 
                 if ($this->db_item_view_id) {
-                    $sql = "UPDATE $item_view_table SET id = iid
+                    $sql = "update $item_view_table SET id = iid
                             WHERE iid = ".$this->db_item_view_id;
                     Database::query($sql);
                     $inserted = true;
@@ -3911,7 +3911,7 @@ 
                 $this->db_item_view_id = Database::insert($item_view_table, $params);
 
                 if ($this->db_item_view_id) {
-                    $sql = "UPDATE $item_view_table SET id = iid
+                    $sql = "update $item_view_table SET id = iid
                             WHERE iid = ".$this->db_item_view_id;
                     Database::query($sql);
                 }
@@ -4058,7 +4058,7 @@ 
                         //IF scorm scorm_update_time has already updated total_time in db
                         //" . //start_time = ".$this->get_current_start_time().", " . //scorm_init_time does it
                         ////" max_time_allowed = '".$this->get_max_time_allowed()."'," .
-                        $sql = "UPDATE $item_view_table SET
+                        $sql = "update $item_view_table SET
                                     score = ".$this->get_score().",
                                     $my_status
                                     max_score = '".$this->get_max()."',
@@ -4072,7 +4072,7 @@ 
 
                     } else {
                         //" max_time_allowed = '".$this->get_max_time_allowed()."'," .
-                        $sql = "UPDATE $item_view_table SET
+                        $sql = "update $item_view_table SET
                                     $total_time
                                     start_time = ".$this->get_current_start_time().",
                                     score = " . $this->get_score().",
@@ -4198,7 +4198,7 @@ 
 
                             $insertId = Database::insert($iva_table, $params);
                             if ($insertId) {
-                                $sql = "UPDATE $iva_table SET id = iid
+                                $sql = "update $iva_table SET id = iid
                                         WHERE iid = $insertId";
                                 Database::query($sql);
                             }
@@ -4284,7 +4284,7 @@ 
 
             // Store the mp3 file in the lp_item table.
             $tbl_lp_item = Database::get_course_table(TABLE_LP_ITEM);
-            $sql = "UPDATE $tbl_lp_item SET
+            $sql = "update $tbl_lp_item SET
                         audio = '".Database::escape_string($file_path)."'
                     WHERE
                         c_id = {$course_info['real_id']} AND
@@ -4312,7 +4312,7 @@ 
             $file_path = basename($document_data['path']);
             // Store the mp3 file in the lp_item table.
             $tbl_lp_item = Database::get_course_table(TABLE_LP_ITEM);
-            $sql = "UPDATE $tbl_lp_item SET
+            $sql = "update $tbl_lp_item SET
                         audio = '".Database::escape_string($file_path)."'
                     WHERE
                         c_id = {$course_info['real_id']} AND
@@ -4335,7 +4335,7 @@ 
         if (empty($this->db_id)) {
             return false;
         }
-        $sql = "UPDATE $tbl_lp_item SET
+        $sql = "update $tbl_lp_item SET
                 audio = ''
                 WHERE c_id = $course_id AND id IN (".$this->db_id.")";
         Database::query($sql);

main/lp/lp_edit.php

Indentation +2 added lines, -2 removed lines

@@ -178,8 +178,8 @@
 );
 $display_date = 'none';
 if (!empty($expired_on)) {
-	$display_date = 'block';
-	$defaults['activate_end_date_check'] = 1;
+    $display_date = 'block';
+    $defaults['activate_end_date_check'] = 1;
 }
 
 $form->addElement('html', '<div id="end_date_div" style="display:'.$display_date.';">');

app/SymfonyRequirements.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
      * Adds an optional recommendation in form of a php.ini configuration.
      *
      * @param string        $cfgName           The configuration name used for ini_get()
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.

src/Chamilo/CoreBundle/Entity/SkillRelSkill.php

Doc Comments +1 added lines

@@ -52,6 +52,7 @@
     /**
      * Set id
      *
+     * @param integer $id
      * @return integer
      */
     public function setId($id)

src/Chamilo/CoreBundle/EventListener/LogoutSuccessHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     /**
      * @param UrlGeneratorInterface $urlGenerator
      * @param AuthorizationChecker $checker
-     * @param Storage $storage
+     * @param TokenStorage $storage
      */
     public function __construct(
         UrlGeneratorInterface $urlGenerator,

Spacing +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
                 LIMIT 0,1";
         $row = Database::query($sql);
         $loginId = null;
-        if (Database::num_rows($row)>0) {
+        if (Database::num_rows($row) > 0) {
             $loginId = Database::result($row, 0, "login_id");
         }
 
@@ -77,7 +77,7 @@ 
 
         $online_table = Database::get_main_table(TABLE_STATISTIC_TRACK_E_ONLINE);
 
-        $query = "DELETE FROM " . $online_table . " WHERE login_user_id = $userId";
+        $query = "DELETE FROM ".$online_table." WHERE login_user_id = $userId";
         Database::query($query);
 
         /*require_once api_get_path(SYS_PATH) . 'main/chat/chat_functions.lib.php';

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         $loginAs = $this->checker->isGranted('ROLE_PREVIOUS_ADMIN');
         if (!$loginAs) {
             $current_date = api_get_utc_datetime();
-            $sql = "UPDATE $tbl_track_login
+            $sql = "update $tbl_track_login
                     SET logout_date='".$current_date."'
         		    WHERE login_id='$loginId'";
             Database::query($sql);

src/Chamilo/ContactBundle/Entity/Category.php

Indentation +3 added lines, -3 removed lines

@@ -43,9 +43,9 @@
         return $this->proxyCurrentLocaleTranslation($method, $arguments);
     }
 
-     /**
-     * @return string
-     */
+        /**
+         * @return string
+         */
     public function __toString()
     {
         return (string) $this->getName();

main/gradebook/lib/fe/dataform.class.php

Indentation +12 added lines, -12 removed lines

@@ -8,19 +8,19 @@
  */
 class DataForm extends FormValidator
 {
-	const TYPE_IMPORT = 1;
-	const TYPE_EXPORT = 2;
-	const TYPE_EXPORT_PDF = 3;
+    const TYPE_IMPORT = 1;
+    const TYPE_EXPORT = 2;
+    const TYPE_EXPORT_PDF = 3;
 
-	/**
-	 * Builds a form containing form items based on a given parameter
-	 * @param int form_type 1=import, 2=export
-	 * @param obj cat_obj the category object
-	 * @param obj res_obj the result object
-	 * @param string form name
-	 * @param method
-	 * @param action
-	 */
+    /**
+     * Builds a form containing form items based on a given parameter
+     * @param int form_type 1=import, 2=export
+     * @param obj cat_obj the category object
+     * @param obj res_obj the result object
+     * @param string form name
+     * @param method
+     * @param action
+     */
     public function __construct($form_type, $form_name, $method = 'post', $action = null, $target = '', $locked_status)
     {
         parent:: __construct($form_name, $method, $action, $target);