chamilo / chamilo-lms

main/lp/storageapi.php

Switch Indentation +46 added lines, -46 removed lines

@@ -15,52 +15,52 @@
 }
 
 switch ($_REQUEST['action']) {
-    case "get":
-        print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "set":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "getall":
-        print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
-        break;
-    case "stackpush":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "stackpop":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stacklength":
-        print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "stackclear":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "getposition":
-        print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
-        break;
-    case "getleaders":
-        print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
-        break;
-    case "usersgetall":
-// security issue
-        print "NOT allowed, security issue, see sources";
-//		print storage_get_all_users();
-        break;
-    default:
-        // Do nothing
+        case "get":
+            print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "set":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "getall":
+            print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
+            break;
+        case "stackpush":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "stackpop":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stacklength":
+            print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "stackclear":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stackgetall":
+            if (storage_can_set($_REQUEST['svuser']))
+                print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "getposition":
+            print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
+            break;
+        case "getleaders":
+            print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
+            break;
+        case "usersgetall":
+    // security issue
+            print "NOT allowed, security issue, see sources";
+    //		print storage_get_all_users();
+            break;
+        default:
+            // Do nothing
 }
 
 function storage_can_set($sv_user) {

Braces +30 added lines, -20 removed lines

@@ -45,8 +45,9 @@ 
         }
         break;
     case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        if (storage_can_set($_REQUEST['svuser'])) {
+                    print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        }
         break;
     case "getposition":
         print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
@@ -63,7 +64,8 @@ 
         // Do nothing
 }
 
-function storage_can_set($sv_user) {
+function storage_can_set($sv_user)
+{
     // platform admin can change any user's stored values, other users can only change their own values
     $allowed = ((api_is_platform_admin()) || ($sv_user == api_get_user_id()));
     if (!$allowed) {
@@ -72,7 +74,8 @@ 
     return $allowed;
 }
 
-function storage_get($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_get($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select sv_value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         where user_id= '$sv_user'
@@ -87,13 +90,13 @@ 
         } else {
             return $row['sv_value'];
         }
-    }
-    else {
+    } else {
         return null;
     }
 }
 
-function storage_get_leaders($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length) {
+function storage_get_leaders($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length)
+{
 
     // get leaders
     $sql_leaders = "select u.user_id, firstname, lastname, email, username, sv_value as value
@@ -127,7 +130,8 @@ 
     return json_encode($result);
 }
 
-function storage_get_position($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length) {
+function storage_get_position($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length)
+{
     $sql = "select count(list.user_id) as position
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)." search,
             ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)." list
@@ -144,13 +148,13 @@ 
     if (Database::num_rows($res) > 0) {
         $row = Database::fetch_assoc($res);
         return $row['position'];
-    }
-    else {
+    } else {
         return null;
     }
 }
 
-function storage_set($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value) {
+function storage_set($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value)
+{
     $sv_value = Database::escape_string($sv_value);
     $sql = "replace into ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         (user_id, sco_id, course_id, sv_key, sv_value)
@@ -160,7 +164,8 @@ 
     return Database::affected_rows($res);
 }
 
-function storage_getall($sv_user, $sv_course, $sv_sco) {
+function storage_getall($sv_user, $sv_course, $sv_sco)
+{
     $sql = "select sv_key, sv_value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         where user_id= '$sv_user'
@@ -177,7 +182,8 @@ 
     return json_encode($data);
 }
 
-function storage_stack_push($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value) {
+function storage_stack_push($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value)
+{
     $sv_value = Database::escape_string($sv_value);
     Database::query("start transaction");
     $sqlorder = "select ifnull((select max(stack_order)
@@ -198,14 +204,14 @@ 
     if ($resorder && $resinsert) {
         Database::query("commit");
         return 1;
-    }
-    else {
+    } else {
         Database::query("rollback");
         return 0;
     }
 }
 
-function storage_stack_pop($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_pop($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     Database::query("start transaction");
     $sqlselect = "select sv_value, stack_order
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
@@ -239,7 +245,8 @@ 
     }
 }
 
-function storage_stack_length($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_length($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select count(*) as length
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -251,7 +258,8 @@ 
     return $row['length'];
 }
 
-function storage_stack_clear($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_clear($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "delete
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -262,7 +270,8 @@ 
     return Database::num_rows($res);
 }
 
-function storage_stack_getall($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_getall($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select stack_order as stack_order, sv_value as value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -280,7 +289,8 @@ 
     return json_encode($results);
 }
 
-function storage_get_all_users() {
+function storage_get_all_users()
+{
     $sql = "select user_id, username, firstname, lastname
         from ".Database::get_main_table(TABLE_MAIN_USER)."
         order by user_id asc";

main/lp/scormOrganization.class.php

Indentation +15 added lines, -15 removed lines

@@ -38,14 +38,14 @@ 
                     //if ($first_item->type == XML_ELEMENT_NODE) this is already check prior to the call to this function.
                     $children = $element->childNodes;
                     foreach ($children as $child) {
-                         switch ($child->nodeType) {
+                            switch ($child->nodeType) {
                             case XML_ELEMENT_NODE:
                                 switch ($child->tagName) {
                                     case 'item':
                                          $oItem = new scormItem('manifest', $child);
-                                         if ($oItem->identifier != '') {
+                                            if ($oItem->identifier != '') {
                                             $this->items[$oItem->identifier] = $oItem;
-                                         }
+                                            }
                                         break;
                                     case 'metadata':
                                         $this->metadata = new scormMetadata('manifest', $child);
@@ -58,24 +58,24 @@ 
                                         break;
                                 }
                                 break;
-                             case XML_TEXT_NODE:
+                                case XML_TEXT_NODE:
                                  break;
-                         }
+                            }
                     }
 
                     if ($element->hasAttributes()) {
-                         $attributes = $element->attributes;
-                         //$keep_href = '';
-                         foreach ($attributes as $attrib) {
-                             switch ($attrib->name) {
-                                 case 'identifier':
+                            $attributes = $element->attributes;
+                            //$keep_href = '';
+                            foreach ($attributes as $attrib) {
+                                switch ($attrib->name) {
+                                    case 'identifier':
                                      $this->identifier = $attrib->value;
-                                     break;
-                                 case 'structure':
+                                        break;
+                                    case 'structure':
                                      $this->structure = $attrib->value;
-                                     break;
-                             }
-                         }
+                                        break;
+                                }
+                            }
                     }
 
                     return true;

main/lp/aicc_api.php

Indentation +8 added lines, -8 removed lines

@@ -142,7 +142,7 @@ 
           <?php
             $who = addslashes(api_get_person_name($_user['firstName'], $_user['lastName']));
             echo "result='$who';";
-          ?>
+            ?>
     }else if(param == 'cmi.core.lesson_location'){
         result=lesson_location;
     }else if(param == 'cmi.core.total_time'){
@@ -198,7 +198,7 @@ 
           <?php
             $who = addslashes(api_get_person_name($_user['firstName'], $_user['lastName']));
             echo "result='$who';";
-          ?>	break;
+            ?>	break;
         case 'cmi.core.lesson_location'	:
             result='';
             break;
@@ -322,12 +322,12 @@ 
 }
 <?php
 /**
- * Chamilo-specific code that deals with event handling and inter-frames
- * messaging/refreshing.
- * Note that from now on, the Chamilo JS code in this library will act as
- * a controller, of the MVC pattern, and receive all requests for frame
- * updates, then redispatch to any frame concerned.
- */
+     * Chamilo-specific code that deals with event handling and inter-frames
+     * messaging/refreshing.
+     * Note that from now on, the Chamilo JS code in this library will act as
+     * a controller, of the MVC pattern, and receive all requests for frame
+     * updates, then redispatch to any frame concerned.
+     */
 ?>
 /**
  * Defining the AJAX-object class to be made available from other frames.

main/admin/settings.lib.php

Doc Comments +4 added lines, -3 removed lines

@@ -1154,7 +1154,7 @@ 
 /**
  * Returns an array containing the list of options used to populate the gradebook_number_decimals variable
  * This function is called through a call_user_func() in the generate_settings_form function.
- * @return array List of gradebook_number_decimals options
+ * @return string[] List of gradebook_number_decimals options
  *
  * @author Guillaume Viguier <guillaume.viguier@beeznest.com>
  */
@@ -1575,8 +1575,9 @@ 
 }
 /**
  * Helper function to generates a form elements group
- * @param object $form The form where the elements group has to be added
+ * @param FormValidator $form The form where the elements group has to be added
  * @param array $values Values to browse through
+ * @param string $elementName
  * @return array
  */
 function formGenerateElementsGroup($form, $values = array(), $elementName)
@@ -1592,7 +1593,7 @@ 
 }
 /**
  * Helper function with allowed file types for CSS
- * @return  array Array of file types (no indexes)
+ * @return  string[] Array of file types (no indexes)
  */
 function getAllowedFileTypes()
 {

Braces +4 added lines, -2 removed lines

@@ -962,7 +962,8 @@ 
  * @version August 2008
  * @since v1.8.6
  */
-function actionsFilter($id) {
+function actionsFilter($id)
+{
     $return = '<a href="settings.php?category=Templates&action=edit&id='.Security::remove_XSS($id).'">'.Display::return_icon('edit.png', get_lang('Edit'), '', ICON_SIZE_SMALL).'</a>';
     $return .= '<a href="settings.php?category=Templates&action=delete&id='.Security::remove_XSS($id).'" onClick="javascript:if(!confirm('."'".get_lang('ConfirmYourChoice')."'".')) return false;">'.Display::return_icon('delete.png', get_lang('Delete'), '', ICON_SIZE_SMALL).'</a>';
     return $return;
@@ -1178,7 +1179,8 @@ 
  *
  * @author Guillaume Viguier <guillaume.viguier@beeznest.com>
  */
-function select_gradebook_number_decimals() {
+function select_gradebook_number_decimals()
+{
     return array('0', '1', '2');
 }
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1108,7 +1108,7 @@
                 echo '<a href="settings.php?category=Templates&action=add">'.Display::return_icon('new_template.png', get_lang('AddTemplate'), '', ICON_SIZE_MEDIUM).'</a>';
             } else {
                 $content_template = '<head>{CSS}<style type="text/css">.text{font-weight: normal;}</style></head><body>'.Database::escape_string($values['template_text']).'</body>';
-                $sql = "UPDATE $table_system_template set title = '".Database::escape_string($values['title'])."', content = '".$content_template."'";
+                $sql = "update $table_system_template set title = '".Database::escape_string($values['title'])."', content = '".$content_template."'";
                 if (!empty($new_file_name)) {
                     $sql .= ", image = '".Database::escape_string($new_file_name)."'";
                 }

Spacing +1 added lines, -1 removed lines

@@ -674,7 +674,7 @@
     // Get a list of all current 'Plugins' settings
     $plugin_list = $appPlugin->read_plugins_from_path();
 
-    var_dump($plugin_list);exit;
+    var_dump($plugin_list); exit;
     $installed_plugins = array();
 
     foreach ($plugin_list as $plugin) {

main/inc/lib/CourseChatUtils.php

Doc Comments +2 added lines, -2 removed lines

@@ -1415,7 +1415,7 @@ 
 
     /**
      * Get the emoji list to include in chat
-     * @return array
+     * @return string[]
      */
     public static function getEmojisToInclude()
     {
@@ -1738,7 +1738,7 @@ 
 
     /**
      * Get the number of users connected in chat
-     * @return mixed
+     * @return integer
      */
     public function countUsersOnline()
     {

Spacing +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
             return '';
         }
 
-        Emojione\Emojione::$imagePathPNG = api_get_path(WEB_PUBLIC_PATH) . 'bundles/chamilocore/js/emojione/png/';
+        Emojione\Emojione::$imagePathPNG = api_get_path(WEB_PUBLIC_PATH).'bundles/chamilocore/js/emojione/png/';
         Emojione\Emojione::$ascii = true;
 
         $message = trim($message);
@@ -1394,7 +1394,7 @@ 
     {
         return [
             ':bowtie:',
-            ':smile:'|
+            ':smile:' |
             ':laughing:',
             ':blush:',
             ':smiley:',

main/inc/lib/glossary.lib.php

Doc Comments +3 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
      *
      * @param array  $values  Array of title + description (name => $title, description => $comment)
      *
-     * @return mixed   Term id on success, false on failure
+     * @return false|string   Term id on success, false on failure
      *
      */
     public static function save_glossary($values, $showMessage = true)
@@ -448,7 +448,7 @@ 
 
     /**
      * Display the glossary terms in a list
-     * @return bool true
+     * @return string true
      */
     public static function displayGlossaryList()
     {
@@ -585,7 +585,7 @@ 
      * Update action icons column
      *
      * @param integer $glossary_id
-     * @param array   $url_params Parameters to use to affect links
+     * @param string   $url_params Parameters to use to affect links
      * @param array   $row The line of results from a query on the glossary table
      *
      * @return string HTML string for the action icons columns

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -134,7 +134,7 @@ 
             $id = Database::insert($t_glossary, $params);
 
             if ($id) {
-                $sql = "UPDATE $t_glossary SET glossary_id = $id WHERE iid = $id";
+                $sql = "update $t_glossary SET glossary_id = $id WHERE iid = $id";
                 Database::query($sql);
 
                 //insert into item_property
@@ -180,7 +180,7 @@ 
 
             return false;
         } else {
-            $sql = "UPDATE $t_glossary SET
+            $sql = "update $t_glossary SET
                         name = '".Database::escape_string($values['name'])."',
                         description	= '".Database::escape_string($values['description'])."'
 					WHERE
@@ -639,7 +639,7 @@ 
 
         $i = 1;
         while ($data = Database::fetch_array($res)) {
-            $sql = "UPDATE $t_glossary SET display_order = $i
+            $sql = "update $t_glossary SET display_order = $i
                     WHERE c_id = $course_id AND glossary_id = '".intval($data['glossary_id'])."'";
             Database::query($sql);
             $i++;
@@ -682,9 +682,9 @@ 
                 $found = true;
             }
         }
-        $sql1 = "UPDATE $t_glossary SET display_order = '".Database::escape_string($next_display_order)."'
+        $sql1 = "update $t_glossary SET display_order = '".Database::escape_string($next_display_order)."'
                  WHERE c_id = $course_id  AND glossary_id = '".Database::escape_string($current_id)."'";
-        $sql2 = "UPDATE $t_glossary SET display_order = '".Database::escape_string($current_display_order)."'
+        $sql2 = "update $t_glossary SET display_order = '".Database::escape_string($current_display_order)."'
                  WHERE c_id = $course_id  AND glossary_id = '".Database::escape_string($next_id)."'";
         Database::query($sql1);
         Database::query($sql2);

main/inc/lib/extra_field.lib.php

Doc Comments +7 added lines, -7 removed lines

@@ -140,7 +140,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getValidExtraFieldTypes()
     {
@@ -217,7 +217,7 @@ 
 
     /**
      * @param array $conditions
-     * @param null  $order_field_options_by
+     * @param string  $order_field_options_by
      *
      * @return array
      */
@@ -375,7 +375,7 @@ 
     /**
      * @param string $handler
      *
-     * @return array
+     * @return string[]
      */
     public static function get_extra_fields_by_handler($handler)
     {
@@ -574,7 +574,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function get_field_types()
     {
@@ -584,7 +584,7 @@ 
     /**
      * @param int $id
      *
-     * @return null
+     * @return string|null
      */
     public function get_field_type_by_id($id)
     {
@@ -1826,7 +1826,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getJqgridColumnNames()
     {
@@ -2086,7 +2086,7 @@ 
     }
 
     /**
-     * @param array $columns
+     * @param string[] $columns
      * @param array  $column_model
      * @param array  $extraFields
      * @return array

Indentation +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
         'changeable',
         'filter',
         'extra_field_type',
-         /* Enable this when field_loggeable is introduced as a table field (2.0)
+            /* Enable this when field_loggeable is introduced as a table field (2.0)
         'field_loggeable',
          */
         'created_at'
@@ -2000,7 +2000,7 @@ 
                 'align' => 'left',
                 'sortable' => 'true',
             ),
-             array(
+                array(
                 'name' => 'visible_to_others',
                 'index' => 'visible_to_others',
                 'width' => '35',

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -2230,7 +2230,7 @@ 
             <a href="?action=edit&type={$this->type}&id=' + options.rowId + '" class="btn btn-link btn-xs">\
                 $editIcon\
             </a>
-JAVASCRIPT;
+javascript;
         $deleteButton = <<<JAVASCRIPT
             <a \
                 onclick="if (!confirm(\'$confirmMessage\')) {return false;}" \
@@ -2238,7 +2238,7 @@ 
                 class="btn btn-link btn-xs">\
                 $deleteIcon\
             </a>
-JAVASCRIPT;
+javascript;
 
         return "function action_formatter(cellvalue, options, rowObject) {        
             return '$editButton $deleteButton';

app/check.php

Doc Comments +3 added lines

@@ -96,6 +96,9 @@
     echo PHP_EOL;
 }
 
+/**
+ * @param string $message
+ */
 function echo_style($style, $message)
 {
     // ANSI color codes

main/exercise/hotspot_updatescore.inc.php

Indentation +7 added lines, -7 removed lines

@@ -20,16 +20,16 @@
 $exerciseId = $objExercise->selectId();
 if ($_GET['answerId'] == "0") { // click is NOT on a hotspot
     $hit = 0;
-	$answerId = $hotspotId;
+    $answerId = $hotspotId;
 
-	// remove from session
-	unset($_SESSION['exerciseResult'][$questionId][$answerId]);
+    // remove from session
+    unset($_SESSION['exerciseResult'][$questionId][$answerId]);
 } else { // user clicked ON a hotspot
-	$hit = 1;
-	$answerId = $hotspotId;
+    $hit = 1;
+    $answerId = $hotspotId;
 
-	// Save into session
-	$_SESSION['exerciseResult'][$questionId][$answerId] = $hit;
+    // Save into session
+    $_SESSION['exerciseResult'][$questionId][$answerId] = $hit;
 }
 
 //round-up the coordinates

Braces +4 added lines, -2 removed lines

@@ -18,13 +18,15 @@
 $objExercise = Session::read('objExercise');
 $hotspotId = $_GET['hotspotId'];
 $exerciseId = $objExercise->selectId();
-if ($_GET['answerId'] == "0") { // click is NOT on a hotspot
+if ($_GET['answerId'] == "0") {
+// click is NOT on a hotspot
     $hit = 0;
 	$answerId = $hotspotId;
 
 	// remove from session
 	unset($_SESSION['exerciseResult'][$questionId][$answerId]);
-} else { // user clicked ON a hotspot
+} else {
+// user clicked ON a hotspot
 	$hit = 1;
 	$answerId = $hotspotId;
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 
 // update db
 $update_id = $_SESSION['exerciseResult'][$questionId]['ids'][$answerId];
-$sql = "UPDATE $TBL_TRACK_E_HOTSPOT 
+$sql = "update $TBL_TRACK_E_HOTSPOT 
         SET coordinate = '".Database::escape_string($coordinates)."'
         WHERE id = ".intval($update_id)." 
         LIMIT 1";