SubscribeUserToSessionFromUsernameTest::testSubscribeWithoutUnsubscribe()

Complexity

Conditions	1
Paths	1

Size

Total Lines	36
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function testSubscribeWithoutUnsubscribe()
    {
        // create a test session
        $sessionId = SessionManager::create_session(
            'Session to subscribe'.time(),
            '2019-01-01 00:00',
            '2019-08-31 00:00',
            '2019-01-01 00:00',
            '2019-08-31 00:00',
            '2019-01-01 00:00',
            '2019-08-31 00:00',
            null,
            null
        );

        // create a test user
        $loginName = 'tester'.time();
        $userId = UserManager::create_user('Tester', 'Tester', 5, 'tester@local', $loginName, 'xXxxXxxXX');

        // create another user and subscribe it to the session
        $anotherUserId = UserManager::create_user('Tester 2', 'Tester 2', 5, 'tester2@local', $loginName.'t2', 'xXxxX');
        SessionManager::subscribeUsersToSession($sessionId, [$anotherUserId]);

It seems like $sessionId can also be of type false and string; however, parameter $sessionId of SessionManager::subscribeUsersToSession() does only seem to accept integer, maybe add an additional type check?

        // call the webservice to subscribe the first user to the session
        $subscribed = $this->boolean(['sessionId' => $sessionId, 'loginname' => $loginName]);
        $this->assertTrue($subscribed);

        // assert we now have two users subscribed to the session
        $sessionRelUsers = Database::getManager()
            ->getRepository('ChamiloCoreBundle:SessionRelUser')
            ->findBy(['session' => $sessionId]);
        $this->assertSame(2, count($sessionRelUsers));

        // clean up
        UserManager::delete_users([$userId, $anotherUserId]);
        SessionManager::delete($sessionId);

It seems like $sessionId can also be of type false and integer and string; however, parameter $id_checked of SessionManager::delete() does only seem to accept array, maybe add an additional type check?

    }