Total Complexity | 40 |
Total Lines | 626 |
Duplicated Lines | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Complex classes like ResourceController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResourceController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
44 | class ResourceController extends AbstractResourceController implements CourseControllerInterface |
||
45 | { |
||
46 | use CourseControllerTrait; |
||
47 | use ResourceControllerTrait; |
||
48 | use ControllerTrait; |
||
49 | |||
50 | private string $fileContentName = 'file_content'; |
||
51 | |||
52 | /** |
||
53 | * @deprecated Use Vue |
||
54 | * |
||
55 | * @Route("/{tool}/{type}/{id}/new_folder", methods={"GET", "POST"}, name="chamilo_core_resource_new_folder") |
||
56 | */ |
||
57 | /*public function newFolderAction(Request $request): Response |
||
58 | { |
||
59 | return $this->createResource($request, 'folder'); |
||
60 | }*/ |
||
61 | |||
62 | /** |
||
63 | * @deprecated Use Vue |
||
64 | * |
||
65 | * @Route("/{tool}/{type}/{id}/new", methods={"GET", "POST"}, name="chamilo_core_resource_new") |
||
66 | */ |
||
67 | /*public function newAction(Request $request): Response |
||
68 | { |
||
69 | return $this->createResource($request, 'file'); |
||
70 | }*/ |
||
71 | |||
72 | /** |
||
73 | * @Route("/{tool}/{type}/{id}/disk_space", methods={"GET", "POST"}, name="chamilo_core_resource_disk_space") |
||
74 | */ |
||
75 | public function diskSpaceAction(Request $request): Response |
||
76 | { |
||
77 | $nodeId = $request->get('id'); |
||
78 | $repository = $this->getRepositoryFromRequest($request); |
||
79 | |||
80 | /** @var ResourceNode $resourceNode */ |
||
81 | $resourceNode = $repository->getResourceNodeRepository()->find($nodeId); |
||
82 | |||
83 | $this->denyAccessUnlessGranted( |
||
84 | ResourceNodeVoter::VIEW, |
||
85 | $resourceNode, |
||
86 | $this->trans('Unauthorised access to resource') |
||
87 | ); |
||
88 | |||
89 | $this->setBreadCrumb($request, $resourceNode); |
||
90 | |||
91 | $course = $this->getCourse(); |
||
92 | $totalSize = 0; |
||
93 | if (null !== $course) { |
||
94 | $totalSize = $course->getDiskQuota(); |
||
95 | } |
||
96 | |||
97 | $size = $repository->getResourceNodeRepository()->getSize( |
||
98 | $resourceNode, |
||
99 | $repository->getResourceType(), |
||
100 | $course |
||
101 | ); |
||
102 | |||
103 | $labels[] = $course->getTitle(); |
||
|
|||
104 | $data[] = $size; |
||
105 | $sessions = $course->getSessions(); |
||
106 | |||
107 | foreach ($sessions as $sessionRelCourse) { |
||
108 | $session = $sessionRelCourse->getSession(); |
||
109 | |||
110 | $labels[] = $course->getTitle().' - '.$session->getName(); |
||
111 | $size = $repository->getResourceNodeRepository()->getSize( |
||
112 | $resourceNode, |
||
113 | $repository->getResourceType(), |
||
114 | $course, |
||
115 | $session |
||
116 | ); |
||
117 | $data[] = $size; |
||
118 | } |
||
119 | |||
120 | /*$groups = $course->getGroups(); |
||
121 | foreach ($groups as $group) { |
||
122 | $labels[] = $course->getTitle().' - '.$group->getName(); |
||
123 | $size = $repository->getResourceNodeRepository()->getSize( |
||
124 | $resourceNode, |
||
125 | $repository->getResourceType(), |
||
126 | $course, |
||
127 | null, |
||
128 | $group |
||
129 | ); |
||
130 | $data[] = $size; |
||
131 | }*/ |
||
132 | |||
133 | $used = array_sum($data); |
||
134 | $labels[] = $this->trans('Free'); |
||
135 | $data[] = $totalSize - $used; |
||
136 | |||
137 | return $this->render( |
||
138 | $repository->getTemplates()->getFromAction(__FUNCTION__), |
||
139 | [ |
||
140 | 'resourceNode' => $resourceNode, |
||
141 | 'labels' => $labels, |
||
142 | 'data' => $data, |
||
143 | ] |
||
144 | ); |
||
145 | } |
||
146 | |||
147 | /** |
||
148 | * @deprecated Use Vue |
||
149 | * |
||
150 | * @Route("/{tool}/{type}/{id}/edit", methods={"GET", "POST"}) |
||
151 | */ |
||
152 | public function editAction(Request $request, IllustrationRepository $illustrationRepo): Response |
||
153 | { |
||
154 | $resourceNodeId = $request->get('id'); |
||
155 | |||
156 | $repository = $this->getRepositoryFromRequest($request); |
||
157 | $resource = $repository->getResourceFromResourceNode($resourceNodeId); |
||
158 | $this->denyAccessUnlessValidResource($resource); |
||
159 | $settings = $repository->getResourceSettings(); |
||
160 | $resourceNode = $resource->getResourceNode(); |
||
161 | |||
162 | $this->denyAccessUnlessGranted( |
||
163 | ResourceNodeVoter::EDIT, |
||
164 | $resourceNode, |
||
165 | $this->trans('Unauthorised access to resource') |
||
166 | ); |
||
167 | |||
168 | $this->setBreadCrumb($request, $resourceNode); |
||
169 | $resourceNodeParentId = $resourceNode->getId(); |
||
170 | |||
171 | $routeParams = $this->getResourceParams($request); |
||
172 | $routeParams['id'] = $resourceNodeParentId; |
||
173 | |||
174 | $form = $repository->getForm($this->container->get('form.factory'), $resource); |
||
175 | |||
176 | if ($resourceNode->hasEditableTextContent() && $settings->isAllowToSaveEditorToResourceFile()) { |
||
177 | /*$form->add( |
||
178 | $this->fileContentName, |
||
179 | CKEditorType::class, |
||
180 | [ |
||
181 | 'mapped' => false, |
||
182 | 'config' => [ |
||
183 | 'filebrowserImageBrowseRoute' => 'resources_filemanager', |
||
184 | 'filebrowserImageBrowseRouteParameters' => $routeParams, |
||
185 | ], |
||
186 | ] |
||
187 | ); |
||
188 | $content = $repository->getResourceNodeFileContent($resourceNode); |
||
189 | $form->get($this->fileContentName)->setData($content);*/ |
||
190 | } |
||
191 | |||
192 | $form->handleRequest($request); |
||
193 | |||
194 | if ($form->isSubmitted() && $form->isValid()) { |
||
195 | /** @var AbstractResource|ResourceInterface $newResource */ |
||
196 | $newResource = $form->getData(); |
||
197 | |||
198 | if ($form->has($this->fileContentName)) { |
||
199 | $data = $form->get($this->fileContentName)->getData(); |
||
200 | $repository->updateResourceFileContent($newResource, $data); |
||
201 | } |
||
202 | |||
203 | $repository->updateNodeForResource($newResource); |
||
204 | |||
205 | if ($form->has('illustration')) { |
||
206 | $illustration = $form->get('illustration')->getData(); |
||
207 | if ($illustration) { |
||
208 | $illustrationRepo->addIllustration($newResource, $this->getUser(), $illustration); |
||
209 | } |
||
210 | } |
||
211 | |||
212 | $this->addFlash('success', $this->trans('Updated')); |
||
213 | $resourceNodeParentId = $newResource->getResourceNode()->getParent()->getId(); |
||
214 | $routeParams['id'] = $resourceNodeParentId; |
||
215 | |||
216 | return $this->redirectToRoute('chamilo_core_resource_list', $routeParams); |
||
217 | } |
||
218 | |||
219 | return $this->render( |
||
220 | $repository->getTemplates()->getFromAction(__FUNCTION__), |
||
221 | [ |
||
222 | 'form' => $form->createView(), |
||
223 | 'parent' => $resourceNodeParentId, |
||
224 | ] |
||
225 | ); |
||
226 | } |
||
227 | |||
228 | /** |
||
229 | * @deprecated use Vue |
||
230 | * |
||
231 | * Shows a resource information |
||
232 | * |
||
233 | * @Route("/{tool}/{type}/{id}/info", methods={"GET", "POST"}, name="chamilo_core_resource_info") |
||
234 | */ |
||
235 | /*public function infoAction(Request $request): Response |
||
236 | { |
||
237 | $nodeId = $request->get('id'); |
||
238 | $repository = $this->getRepositoryFromRequest($request); |
||
239 | |||
240 | $resource = $repository->getResourceFromResourceNode($nodeId); |
||
241 | $this->denyAccessUnlessValidResource($resource); |
||
242 | $resourceNode = $resource->getResourceNode(); |
||
243 | |||
244 | $this->denyAccessUnlessGranted( |
||
245 | ResourceNodeVoter::VIEW, |
||
246 | $resourceNode, |
||
247 | $this->trans(sprintf('Unauthorised access to resource #%s', $nodeId)) |
||
248 | ); |
||
249 | |||
250 | $this->setBreadCrumb($request, $resourceNode); |
||
251 | |||
252 | $tool = $request->get('tool'); |
||
253 | $type = $request->get('type'); |
||
254 | |||
255 | $form = $this->createForm(ResourceCommentType::class, null); |
||
256 | |||
257 | $params = [ |
||
258 | 'resource' => $resource, |
||
259 | 'course' => $this->getCourse(), |
||
260 | // 'illustration' => $illustration, |
||
261 | 'tool' => $tool, |
||
262 | 'type' => $type, |
||
263 | 'comment_form' => $form->createView(), |
||
264 | ]; |
||
265 | |||
266 | return $this->render( |
||
267 | $repository->getTemplates()->getFromAction(__FUNCTION__, $request->isXmlHttpRequest()), |
||
268 | $params |
||
269 | ); |
||
270 | }*/ |
||
271 | |||
272 | /** |
||
273 | * Preview a file. Mostly used when using a modal. |
||
274 | * |
||
275 | * @Route("/{tool}/{type}/{id}/preview", methods={"GET"}, name="chamilo_core_resource_preview") |
||
276 | */ |
||
277 | /*public function previewAction(Request $request): Response |
||
278 | { |
||
279 | $nodeId = $request->get('id'); |
||
280 | $repository = $this->getRepositoryFromRequest($request); |
||
281 | |||
282 | $resource = $repository->getResourceFromResourceNode($nodeId); |
||
283 | $this->denyAccessUnlessValidResource($resource); |
||
284 | |||
285 | $resourceNode = $resource->getResourceNode(); |
||
286 | $this->denyAccessUnlessGranted( |
||
287 | ResourceNodeVoter::VIEW, |
||
288 | $resourceNode, |
||
289 | $this->trans('Unauthorised access to resource') |
||
290 | ); |
||
291 | |||
292 | $this->setBreadCrumb($request, $resourceNode); |
||
293 | |||
294 | $tool = $request->get('tool'); |
||
295 | $type = $request->get('type'); |
||
296 | |||
297 | $params = [ |
||
298 | 'resource' => $resource, |
||
299 | 'tool' => $tool, |
||
300 | 'type' => $type, |
||
301 | ]; |
||
302 | |||
303 | return $this->render($repository->getTemplates()->getFromAction(__FUNCTION__), $params); |
||
304 | }*/ |
||
305 | |||
306 | /** |
||
307 | * @deprecated use vue |
||
308 | * |
||
309 | * @Route("/{tool}/{type}/{id}/change_visibility", name="chamilo_core_resource_change_visibility") |
||
310 | */ |
||
311 | public function changeVisibilityAction(Request $request): Response |
||
312 | { |
||
313 | $id = (int) $request->get('id'); |
||
314 | |||
315 | $repository = $this->getRepositoryFromRequest($request); |
||
316 | |||
317 | $resource = $repository->getResourceFromResourceNode($id); |
||
318 | $this->denyAccessUnlessValidResource($resource); |
||
319 | /** @var AbstractResource $resource */ |
||
320 | $resourceNode = $resource->getResourceNode(); |
||
321 | |||
322 | $this->denyAccessUnlessGranted( |
||
323 | ResourceNodeVoter::EDIT, |
||
324 | $resourceNode, |
||
325 | $this->trans('Unauthorised access to resource') |
||
326 | ); |
||
327 | |||
328 | if ($this->hasCourse()) { |
||
329 | $link = $resource->getFirstResourceLinkFromCourseSession($this->getCourse(), $this->getSession()); |
||
330 | } else { |
||
331 | $link = $resource->getFirstResourceLink(); |
||
332 | } |
||
333 | |||
334 | // Use repository to change settings easily. |
||
335 | if ($link && ResourceLink::VISIBILITY_PUBLISHED === $link->getVisibility()) { |
||
336 | $repository->setVisibilityDraft($resource); |
||
337 | } else { |
||
338 | $repository->setVisibilityPublished($resource); |
||
339 | } |
||
340 | |||
341 | $result = [ |
||
342 | 'visibility' => $link->getVisibility(), |
||
343 | 'ok' => true, |
||
344 | ]; |
||
345 | |||
346 | return new JsonResponse($result); |
||
347 | } |
||
348 | |||
349 | /** |
||
350 | * @deprecated Use Vue + api platform |
||
351 | * |
||
352 | * @Route("/{tool}/{type}/{id}/delete", name="chamilo_core_resource_delete") |
||
353 | */ |
||
354 | public function deleteAction(Request $request): Response |
||
385 | } |
||
386 | |||
387 | /** |
||
388 | * Shows the associated resource file. |
||
389 | * |
||
390 | * @deprecated use vue |
||
391 | * |
||
392 | * @Route("/{tool}/{type}/{id}/view_resource", methods={"GET"}, name="chamilo_core_resource_view_resource") |
||
393 | */ |
||
394 | /*public function viewResourceAction(Request $request, RouterInterface $router): Response |
||
395 | { |
||
396 | $id = $request->get('id'); |
||
397 | |||
398 | $resourceNode = $this->getResourceNodeRepository()->find($id); |
||
399 | |||
400 | if (null === $resourceNode) { |
||
401 | throw new FileNotFoundException('Resource not found'); |
||
402 | } |
||
403 | |||
404 | $this->denyAccessUnlessGranted( |
||
405 | ResourceNodeVoter::VIEW, |
||
406 | $resourceNode, |
||
407 | $this->trans('Unauthorised access to resource') |
||
408 | ); |
||
409 | |||
410 | $repository = $this->getRepositoryFromRequest($request); |
||
411 | |||
412 | $resource = $repository->getResourceFromResourceNode($id); |
||
413 | |||
414 | $tool = $request->get('tool'); |
||
415 | $type = $request->get('type'); |
||
416 | $this->setBreadCrumb($request, $resourceNode); |
||
417 | |||
418 | $params = [ |
||
419 | 'resource' => $resource, |
||
420 | 'tool' => $tool, |
||
421 | 'type' => $type, |
||
422 | ]; |
||
423 | |||
424 | return $this->render($repository->getTemplates()->getFromAction(__FUNCTION__), $params); |
||
425 | }*/ |
||
426 | |||
427 | /** |
||
428 | * View file of a resource node. |
||
429 | * |
||
430 | * @Route("/{tool}/{type}/{id}/view", methods={"GET"}, name="chamilo_core_resource_view") |
||
431 | */ |
||
432 | public function viewAction(Request $request): Response |
||
443 | } |
||
444 | |||
445 | /** |
||
446 | * Redirect resource to link. |
||
447 | * |
||
448 | * @Route("/{tool}/{type}/{id}/link", methods={"GET"}, name="chamilo_core_resource_link") |
||
449 | * |
||
450 | * @return RedirectResponse|void |
||
451 | */ |
||
452 | public function linkAction(Request $request, RouterInterface $router) |
||
453 | { |
||
454 | $id = $request->get('id'); |
||
455 | $resourceNode = $this->getResourceNodeRepository()->find($id); |
||
456 | |||
457 | if (null === $resourceNode) { |
||
458 | throw new FileNotFoundException('Resource not found'); |
||
459 | } |
||
460 | |||
461 | $repo = $this->getRepositoryFromRequest($request); |
||
462 | if ($repo instanceof ResourceWithLinkInterface) { |
||
463 | $resource = $repo->getResourceFromResourceNode($resourceNode->getId()); |
||
464 | $url = $repo->getLink($resource, $router, $this->getCourseUrlQueryToArray()); |
||
465 | |||
466 | return $this->redirect($url); |
||
467 | } |
||
468 | |||
469 | $this->abort('No redirect'); |
||
470 | } |
||
471 | |||
472 | /** |
||
473 | * Download file of a resource node. |
||
474 | * |
||
475 | * @Route("/{tool}/{type}/{id}/download", methods={"GET"}, name="chamilo_core_resource_download") |
||
476 | * |
||
477 | * @return RedirectResponse|StreamedResponse |
||
478 | */ |
||
479 | public function downloadAction(Request $request) |
||
555 | } |
||
556 | |||
557 | /** |
||
558 | * @return mixed|StreamedResponse |
||
559 | */ |
||
560 | private function processFile(Request $request, ResourceNode $resourceNode, string $mode = 'show', string $filter = '') |
||
672 |