| Conditions | 23 |
| Paths | > 20000 |
| Total Lines | 360 |
| Code Lines | 295 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 262 | public function get_php_data() |
||
| 263 | { |
||
| 264 | $array = []; |
||
| 265 | |||
| 266 | // General Functions |
||
| 267 | |||
| 268 | $version = phpversion(); |
||
| 269 | $status = $version > REQUIRED_PHP_VERSION ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 270 | $array[] = $this->build_setting( |
||
| 271 | $status, |
||
| 272 | '[PHP]', |
||
| 273 | 'phpversion()', |
||
| 274 | 'http://www.php.net/manual/en/function.phpversion.php', |
||
| 275 | phpversion(), |
||
| 276 | '>= '.REQUIRED_PHP_VERSION, |
||
| 277 | null, |
||
| 278 | get_lang('PHPVersionInfo') |
||
| 279 | ); |
||
| 280 | |||
| 281 | $setting = ini_get('output_buffering'); |
||
| 282 | $req_setting = 1; |
||
| 283 | $status = $setting >= $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 284 | $array[] = $this->build_setting( |
||
| 285 | $status, |
||
| 286 | '[INI]', |
||
| 287 | 'output_buffering', |
||
| 288 | 'http://www.php.net/manual/en/outcontrol.configuration.php#ini.output-buffering', |
||
| 289 | $setting, |
||
| 290 | $req_setting, |
||
| 291 | 'on_off', |
||
| 292 | get_lang('OutputBufferingInfo') |
||
| 293 | ); |
||
| 294 | |||
| 295 | $setting = ini_get('file_uploads'); |
||
| 296 | $req_setting = 1; |
||
| 297 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 298 | $array[] = $this->build_setting( |
||
| 299 | $status, |
||
| 300 | '[INI]', |
||
| 301 | 'file_uploads', |
||
| 302 | 'http://www.php.net/manual/en/ini.core.php#ini.file-uploads', |
||
| 303 | $setting, |
||
| 304 | $req_setting, |
||
| 305 | 'on_off', |
||
| 306 | get_lang('FileUploadsInfo') |
||
| 307 | ); |
||
| 308 | |||
| 309 | $setting = ini_get('magic_quotes_runtime'); |
||
| 310 | $req_setting = 0; |
||
| 311 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 312 | $array[] = $this->build_setting( |
||
| 313 | $status, |
||
| 314 | '[INI]', |
||
| 315 | 'magic_quotes_runtime', |
||
| 316 | 'http://www.php.net/manual/en/ini.core.php#ini.magic-quotes-runtime', |
||
| 317 | $setting, |
||
| 318 | $req_setting, |
||
| 319 | 'on_off', |
||
| 320 | get_lang('MagicQuotesRuntimeInfo') |
||
| 321 | ); |
||
| 322 | |||
| 323 | $setting = ini_get('safe_mode'); |
||
| 324 | $req_setting = 0; |
||
| 325 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 326 | $array[] = $this->build_setting( |
||
| 327 | $status, |
||
| 328 | '[INI]', |
||
| 329 | 'safe_mode', |
||
| 330 | 'http://www.php.net/manual/en/ini.core.php#ini.safe-mode', |
||
| 331 | $setting, |
||
| 332 | $req_setting, |
||
| 333 | 'on_off', |
||
| 334 | get_lang('SafeModeInfo') |
||
| 335 | ); |
||
| 336 | |||
| 337 | $setting = ini_get('register_globals'); |
||
| 338 | $req_setting = 0; |
||
| 339 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 340 | $array[] = $this->build_setting( |
||
| 341 | $status, |
||
| 342 | '[INI]', |
||
| 343 | 'register_globals', |
||
| 344 | 'http://www.php.net/manual/en/ini.core.php#ini.register-globals', |
||
| 345 | $setting, |
||
| 346 | $req_setting, |
||
| 347 | 'on_off', |
||
| 348 | get_lang('RegisterGlobalsInfo') |
||
| 349 | ); |
||
| 350 | |||
| 351 | $setting = ini_get('short_open_tag'); |
||
| 352 | $req_setting = 0; |
||
| 353 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 354 | $array[] = $this->build_setting( |
||
| 355 | $status, |
||
| 356 | '[INI]', |
||
| 357 | 'short_open_tag', |
||
| 358 | 'http://www.php.net/manual/en/ini.core.php#ini.short-open-tag', |
||
| 359 | $setting, |
||
| 360 | $req_setting, |
||
| 361 | 'on_off', |
||
| 362 | get_lang('ShortOpenTagInfo') |
||
| 363 | ); |
||
| 364 | |||
| 365 | $setting = ini_get('magic_quotes_gpc'); |
||
| 366 | $req_setting = 0; |
||
| 367 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 368 | $array[] = $this->build_setting( |
||
| 369 | $status, |
||
| 370 | '[INI]', |
||
| 371 | 'magic_quotes_gpc', |
||
| 372 | 'http://www.php.net/manual/en/ini.core.php#ini.magic_quotes_gpc', |
||
| 373 | $setting, |
||
| 374 | $req_setting, |
||
| 375 | 'on_off', |
||
| 376 | get_lang('MagicQuotesGpcInfo') |
||
| 377 | ); |
||
| 378 | |||
| 379 | $setting = ini_get('display_errors'); |
||
| 380 | $req_setting = 0; |
||
| 381 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 382 | $array[] = $this->build_setting( |
||
| 383 | $status, |
||
| 384 | '[INI]', |
||
| 385 | 'display_errors', |
||
| 386 | 'http://www.php.net/manual/en/ini.core.php#ini.display_errors', |
||
| 387 | $setting, |
||
| 388 | $req_setting, |
||
| 389 | 'on_off', |
||
| 390 | get_lang('DisplayErrorsInfo') |
||
| 391 | ); |
||
| 392 | |||
| 393 | $setting = ini_get('default_charset'); |
||
| 394 | if ($setting == '') { |
||
| 395 | $setting = null; |
||
| 396 | } |
||
| 397 | $req_setting = 'UTF-8'; |
||
| 398 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 399 | $array[] = $this->build_setting( |
||
| 400 | $status, |
||
| 401 | '[INI]', |
||
| 402 | 'default_charset', |
||
| 403 | 'http://www.php.net/manual/en/ini.core.php#ini.default-charset', |
||
| 404 | $setting, |
||
| 405 | $req_setting, |
||
| 406 | null, |
||
| 407 | get_lang('DefaultCharsetInfo') |
||
| 408 | ); |
||
| 409 | |||
| 410 | $setting = ini_get('max_execution_time'); |
||
| 411 | $req_setting = '300 ('.get_lang('Minimum').')'; |
||
| 412 | $status = $setting >= 300 ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 413 | $array[] = $this->build_setting( |
||
| 414 | $status, |
||
| 415 | '[INI]', |
||
| 416 | 'max_execution_time', |
||
| 417 | 'http://www.php.net/manual/en/ini.core.php#ini.max-execution-time', |
||
| 418 | $setting, |
||
| 419 | $req_setting, |
||
| 420 | null, |
||
| 421 | get_lang('MaxExecutionTimeInfo') |
||
| 422 | ); |
||
| 423 | |||
| 424 | $setting = ini_get('max_input_time'); |
||
| 425 | $req_setting = '300 ('.get_lang('Minimum').')'; |
||
| 426 | $status = $setting >= 300 ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 427 | $array[] = $this->build_setting( |
||
| 428 | $status, |
||
| 429 | '[INI]', |
||
| 430 | 'max_input_time', |
||
| 431 | 'http://www.php.net/manual/en/ini.core.php#ini.max-input-time', |
||
| 432 | $setting, |
||
| 433 | $req_setting, |
||
| 434 | null, |
||
| 435 | get_lang('MaxInputTimeInfo') |
||
| 436 | ); |
||
| 437 | |||
| 438 | $setting = ini_get('memory_limit'); |
||
| 439 | $req_setting = '>= '.REQUIRED_MIN_MEMORY_LIMIT.'M'; |
||
| 440 | $status = self::STATUS_ERROR; |
||
| 441 | if ((float) $setting >= REQUIRED_MIN_MEMORY_LIMIT) { |
||
| 442 | $status = self::STATUS_OK; |
||
| 443 | } |
||
| 444 | $array[] = $this->build_setting( |
||
| 445 | $status, |
||
| 446 | '[INI]', |
||
| 447 | 'memory_limit', |
||
| 448 | 'http://www.php.net/manual/en/ini.core.php#ini.memory-limit', |
||
| 449 | $setting, |
||
| 450 | $req_setting, |
||
| 451 | null, |
||
| 452 | get_lang('MemoryLimitInfo') |
||
| 453 | ); |
||
| 454 | |||
| 455 | $setting = ini_get('post_max_size'); |
||
| 456 | $req_setting = '>= '.REQUIRED_MIN_POST_MAX_SIZE.'M'; |
||
| 457 | $status = self::STATUS_ERROR; |
||
| 458 | if ((float) $setting >= REQUIRED_MIN_POST_MAX_SIZE) { |
||
| 459 | $status = self::STATUS_OK; |
||
| 460 | } |
||
| 461 | $array[] = $this->build_setting( |
||
| 462 | $status, |
||
| 463 | '[INI]', |
||
| 464 | 'post_max_size', |
||
| 465 | 'http://www.php.net/manual/en/ini.core.php#ini.post-max-size', |
||
| 466 | $setting, |
||
| 467 | $req_setting, |
||
| 468 | null, |
||
| 469 | get_lang('PostMaxSizeInfo') |
||
| 470 | ); |
||
| 471 | |||
| 472 | $setting = ini_get('upload_max_filesize'); |
||
| 473 | $req_setting = '>= '.REQUIRED_MIN_UPLOAD_MAX_FILESIZE.'M'; |
||
| 474 | $status = self::STATUS_ERROR; |
||
| 475 | if ((float) $setting >= REQUIRED_MIN_UPLOAD_MAX_FILESIZE) { |
||
| 476 | $status = self::STATUS_OK; |
||
| 477 | } |
||
| 478 | $array[] = $this->build_setting( |
||
| 479 | $status, |
||
| 480 | '[INI]', |
||
| 481 | 'upload_max_filesize', |
||
| 482 | 'http://www.php.net/manual/en/ini.core.php#ini.upload_max_filesize', |
||
| 483 | $setting, |
||
| 484 | $req_setting, |
||
| 485 | null, |
||
| 486 | get_lang('UploadMaxFilesizeInfo') |
||
| 487 | ); |
||
| 488 | |||
| 489 | $setting = ini_get('upload_tmp_dir'); |
||
| 490 | $status = self::STATUS_OK; |
||
| 491 | $array[] = $this->build_setting( |
||
| 492 | $status, |
||
| 493 | '[INI]', |
||
| 494 | 'upload_tmp_dir', |
||
| 495 | 'http://www.php.net/manual/en/ini.core.php#ini.upload_tmp_dir', |
||
| 496 | $setting, |
||
| 497 | '', |
||
| 498 | null, |
||
| 499 | get_lang('UploadTmpDirInfo') |
||
| 500 | ); |
||
| 501 | |||
| 502 | $setting = ini_get('variables_order'); |
||
| 503 | $req_setting = 'GPCS'; |
||
| 504 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 505 | $array[] = $this->build_setting( |
||
| 506 | $status, |
||
| 507 | '[INI]', |
||
| 508 | 'variables_order', |
||
| 509 | 'http://www.php.net/manual/en/ini.core.php#ini.variables-order', |
||
| 510 | $setting, |
||
| 511 | $req_setting, |
||
| 512 | null, |
||
| 513 | get_lang('VariablesOrderInfo') |
||
| 514 | ); |
||
| 515 | |||
| 516 | $setting = ini_get('session.gc_maxlifetime'); |
||
| 517 | $req_setting = '4320'; |
||
| 518 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 519 | $array[] = $this->build_setting( |
||
| 520 | $status, |
||
| 521 | '[SESSION]', |
||
| 522 | 'session.gc_maxlifetime', |
||
| 523 | 'http://www.php.net/manual/en/ini.core.php#session.gc-maxlifetime', |
||
| 524 | $setting, |
||
| 525 | $req_setting, |
||
| 526 | null, |
||
| 527 | get_lang('SessionGCMaxLifetimeInfo') |
||
| 528 | ); |
||
| 529 | |||
| 530 | if (api_check_browscap()) { |
||
| 531 | $setting = true; |
||
| 532 | } else { |
||
| 533 | $setting = false; |
||
| 534 | } |
||
| 535 | $req_setting = true; |
||
| 536 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 537 | $array[] = $this->build_setting( |
||
| 538 | $status, |
||
| 539 | '[INI]', |
||
| 540 | 'browscap', |
||
| 541 | 'http://www.php.net/manual/en/misc.configuration.php#ini.browscap', |
||
| 542 | $setting, |
||
| 543 | $req_setting, |
||
| 544 | 'on_off', |
||
| 545 | get_lang('BrowscapInfo') |
||
| 546 | ); |
||
| 547 | |||
| 548 | // Extensions |
||
| 549 | $extensions = [ |
||
| 550 | 'gd' => [ |
||
| 551 | 'link' => 'http://www.php.net/gd', |
||
| 552 | 'expected' => 1, |
||
| 553 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 554 | ], |
||
| 555 | 'pdo_mysql' => [ |
||
| 556 | 'link' => 'http://php.net/manual/en/ref.pdo-mysql.php', |
||
| 557 | 'expected' => 1, |
||
| 558 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 559 | ], |
||
| 560 | 'pcre' => [ |
||
| 561 | 'link' => 'http://www.php.net/pcre', |
||
| 562 | 'expected' => 1, |
||
| 563 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 564 | ], |
||
| 565 | 'session' => [ |
||
| 566 | 'link' => 'http://www.php.net/session', |
||
| 567 | 'expected' => 1, |
||
| 568 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 569 | ], |
||
| 570 | 'standard' => [ |
||
| 571 | 'link' => 'http://www.php.net/spl', |
||
| 572 | 'expected' => 1, |
||
| 573 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 574 | ], |
||
| 575 | 'zlib' => [ |
||
| 576 | 'link' => 'http://www.php.net/zlib', |
||
| 577 | 'expected' => 1, |
||
| 578 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 579 | ], |
||
| 580 | 'xsl' => [ |
||
| 581 | 'link' => 'http://be2.php.net/xsl', |
||
| 582 | 'expected' => 2, |
||
| 583 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 584 | ], |
||
| 585 | 'curl' => [ |
||
| 586 | 'link' => 'http://www.php.net/curl', |
||
| 587 | 'expected' => 2, |
||
| 588 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 589 | ], |
||
| 590 | 'Zend OPcache' => [ |
||
| 591 | 'link' => 'http://www.php.net/opcache', |
||
| 592 | 'expected' => 2, |
||
| 593 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 594 | ], |
||
| 595 | 'apcu' => [ |
||
| 596 | 'link' => 'http://www.php.net/apcu', |
||
| 597 | 'expected' => 2, |
||
| 598 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 599 | ], |
||
| 600 | ]; |
||
| 601 | |||
| 602 | foreach ($extensions as $extension => $data) { |
||
| 603 | $url = $data['link']; |
||
| 604 | $expected_value = $data['expected']; |
||
| 605 | $comment = $data['comment']; |
||
| 606 | |||
| 607 | $loaded = extension_loaded($extension); |
||
| 608 | $status = $loaded ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 609 | $array[] = $this->build_setting( |
||
| 610 | $status, |
||
| 611 | '[EXTENSION]', |
||
| 612 | get_lang('LoadedExtension').': '.$extension, |
||
| 613 | $url, |
||
| 614 | $loaded, |
||
| 615 | $expected_value, |
||
| 616 | 'yes_no_optional', |
||
| 617 | $comment |
||
| 618 | ); |
||
| 619 | } |
||
| 620 | |||
| 621 | return $array; |
||
| 622 | } |
||
| 905 |