| Conditions | 1 |
| Paths | 1 |
| Total Lines | 109 |
| Code Lines | 104 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 131 | public static function getFilesToDelete() |
||
| 132 | { |
||
| 133 | $files = [ |
||
| 134 | __DIR__.'/../../../../main/admin/statistics/statistics.lib.php', |
||
| 135 | __DIR__.'/../../../../main/admin/add_users_to_group.php', |
||
| 136 | __DIR__.'/../../../../main/admin/group_add.php', |
||
| 137 | __DIR__.'/../../../../main/admin/group_edit.php', |
||
| 138 | __DIR__.'/../../../../main/admin/group_list.php', |
||
| 139 | __DIR__.'/../../../../main/admin/admin_page.class.php', |
||
| 140 | __DIR__.'/../../../../main/admin/system_management.php', |
||
| 141 | __DIR__.'/../../../../main/announcements/resources/announcements.inc.php', |
||
| 142 | __DIR__.'/../../../../main/announcements/resources/announcements_email.class.php', |
||
| 143 | __DIR__.'/../../../../main/auth/external_login/facebook-php-sdk/src/base_facebook.php', |
||
| 144 | __DIR__.'/../../../../main/auth/external_login/facebook-php-sdk/src/facebook.php', |
||
| 145 | __DIR__.'/../../../../main/auth/external_login/facebook-php-sdk/src/base_facebook.php', |
||
| 146 | __DIR__.'/../../../../main/course_description/ajax_controller.class.php', |
||
| 147 | __DIR__.'/../../../../main/course_description/controller.class.php', |
||
| 148 | __DIR__.'/../../../../main/course_description/course_description.class.php', |
||
| 149 | __DIR__.'/../../../../main/course_description/course_description_form.class.php', |
||
| 150 | __DIR__.'/../../../../main/course_description/course_description_repository.class.php', |
||
| 151 | __DIR__.'/../../../../main/course_description/course_description_type.class.php', |
||
| 152 | __DIR__.'/../../../../main/course_description/course_description_type_repository.class.php', |
||
| 153 | __DIR__.'/../../../../main/course_description/course_import.class.php', |
||
| 154 | __DIR__.'/../../../../main/course_description/csv_reader.class.php', |
||
| 155 | __DIR__.'/../../../../main/course_description/csv_writer.class.php', |
||
| 156 | __DIR__.'/../../../../main/course_description/request.class.php', |
||
| 157 | __DIR__.'/../../../../main/course_description/upload_file_form.class.php', |
||
| 158 | __DIR__.'/../../../../main/calendar/agenda.inc.php', |
||
| 159 | __DIR__.'/../../../../main/calendar/agenda.lib.php', |
||
| 160 | __DIR__.'/../../../../main/exercice/addlimits.php', |
||
| 161 | __DIR__.'/../../../../main/exercice/testcategory.class.php', |
||
| 162 | __DIR__.'/../../../../main/exercice/export/scorm/scorm_export.php', |
||
| 163 | __DIR__.'/../../../../main/exercice/testheaderpage.php', |
||
| 164 | __DIR__.'/../../../../main/inc/lib/main_api.lib.php', |
||
| 165 | //__DIR__.'/../../../../main/inc/lib/nusoap/class.soapclient.php', |
||
| 166 | __DIR__.'/../../../../main/inc/lib/nusoap/nusoap.php', |
||
| 167 | __DIR__.'/../../../../main/inc/lib/autoload.class.php', |
||
| 168 | __DIR__.'/../../../../main/inc/autoload.inc.php', |
||
| 169 | __DIR__.'/../../../../main/inc/lib/uri.class.php', |
||
| 170 | __DIR__.'/../../../../main/inc/lib/db.class.php', |
||
| 171 | __DIR__.'/../../../../main/inc/lib/xht.lib.php', |
||
| 172 | __DIR__.'/../../../../main/inc/lib/xmd.lib.php', |
||
| 173 | __DIR__.'/../../../../main/inc/lib/entity.class.php', |
||
| 174 | __DIR__.'/../../../../main/inc/lib/entity_repository.class.php', |
||
| 175 | __DIR__.'/../../../../main/inc/lib/javascript.class.php', |
||
| 176 | __DIR__.'/../../../../main/inc/lib/course.class.php', |
||
| 177 | __DIR__.'/../../../../main/inc/lib/document.class.php', |
||
| 178 | __DIR__.'/../../../../main/inc/lib/item_property.class.php', |
||
| 179 | __DIR__.'/../../../../main/inc/lib/chamilo.class.php', |
||
| 180 | __DIR__.'/../../../../main/inc/lib/events.lib.inc.php', |
||
| 181 | __DIR__.'/../../../../main/inc/lib/current_user.class.php', |
||
| 182 | __DIR__.'/../../../../main/inc/lib/current_course.class.php', |
||
| 183 | __DIR__.'/../../../../main/inc/lib/response.class.php', |
||
| 184 | __DIR__.'/../../../../main/inc/lib/result_set.class.php', |
||
| 185 | __DIR__.'/../../../../main/inc/lib/session_handler.class.php', |
||
| 186 | __DIR__.'/../../../../main/inc/lib/WCAG/WCAG_rendering.php', |
||
| 187 | __DIR__.'/../../../../main/inc/lib/zip.class.php', |
||
| 188 | __DIR__.'/../../../../main/inc/lib/student_publication.class.php', |
||
| 189 | __DIR__.'/../../../../main/inc/lib/ajax_controller.class.php', |
||
| 190 | __DIR__.'/../../../../main/inc/lib/system/closure_compiler.class.php', |
||
| 191 | __DIR__.'/../../../../main/inc/lib/system/code_utilities.class.php', |
||
| 192 | __DIR__.'/../../../../main/inc/lib/controller.class.php', |
||
| 193 | __DIR__.'/../../../../main/inc/lib/system/text/converter.class.php', |
||
| 194 | __DIR__.'/../../../../main/inc/lib/course_entity_repository.class.php', |
||
| 195 | __DIR__.'/../../../../main/inc/lib/course_entity.class.php', |
||
| 196 | __DIR__.'/../../../../main/inc/lib/cache.class.php', |
||
| 197 | __DIR__.'/../../../../main/inc/lib/system/web/request_server.class.php', |
||
| 198 | __DIR__.'/../../../../main/inc/lib/page.class.php', |
||
| 199 | __DIR__.'/../../../../main/inc/lib/sortabletable.class.php', |
||
| 200 | __DIR__.'/../../../../main/inc/lib/mail.lib.inc.php', |
||
| 201 | __DIR__.'/../../../../main/install/i_database.class.php', |
||
| 202 | __DIR__.'/../../../../main/install/install.class.php', |
||
| 203 | __DIR__.'/../../../../main/inc/latex.php', |
||
| 204 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/calendar_popup.php', |
||
| 205 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/datepickerdate.php', |
||
| 206 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/html_editor.php', |
||
| 207 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/select_language.php', |
||
| 208 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/select_theme.php', |
||
| 209 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/style_button.php', |
||
| 210 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/style_reset_button.php', |
||
| 211 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/style_submit_button.php', |
||
| 212 | __DIR__.'/../../../../main/inc/lib/formvalidator/Element/tbl_change.js.php', |
||
| 213 | __DIR__.'/../../../../main/inc/lib/SequenceManager.php', |
||
| 214 | __DIR__.'/../../../../main/inc/lib/SequenceResourceManager.php', |
||
| 215 | __DIR__.'/../../../../main/lp/resourcelinker.php', |
||
| 216 | __DIR__.'/../../../../main/lp/resourcelinker.inc.php', |
||
| 217 | __DIR__.'/../../../../main/lp/learnpath_functions.inc.php', |
||
| 218 | __DIR__.'/../../../../main/lp/lp_list_search.css', |
||
| 219 | __DIR__.'/../../../../main/tracking/toolaccess_details.php', |
||
| 220 | __DIR__.'/../../../../main/tracking/course_access_details.php', |
||
| 221 | __DIR__.'/../../../../src/Chamilo/CoreBundle/Entity/GroupRelGroup.php', |
||
| 222 | __DIR__.'/../../../../src/Chamilo/CoreBundle/Entity/GroupRelTag.php', |
||
| 223 | __DIR__.'/../../../../src/Chamilo/CoreBundle/Entity/GroupRelUser.php', |
||
| 224 | __DIR__.'/../../../../src/Chamilo/CoreBundle/Entity/Groups.php', |
||
| 225 | __DIR__.'/../../../../src/Chamilo/UserBundle/Entity/Repository/UserRepository.php', |
||
| 226 | __DIR__.'/../../../../src/Chamilo/CoreBundle/Entity/Manager/SequenceResourceManager.php', |
||
| 227 | __DIR__.'/../../../../app/Resources/public/assets/bootstrap/Gemfile', |
||
| 228 | __DIR__.'/../../../../app/Resources/public/assets/bootstrap/Gemfile.lock', |
||
| 229 | __DIR__.'/../../../../app/Resources/public/assets/bootstrap/Gruntfile.js', |
||
| 230 | __DIR__.'/../../../../app/Resources/public/assets/bootstrap/package.js', |
||
| 231 | __DIR__.'/../../../../app/Resources/public/assets/bootstrap/package.json', |
||
| 232 | __DIR__.'/../../../../web/assets/bootstrap/Gemfile', |
||
| 233 | __DIR__.'/../../../../web/assets/bootstrap/Gemfile.lock', |
||
| 234 | __DIR__.'/../../../../web/assets/bootstrap/Gruntfile.js', |
||
| 235 | __DIR__.'/../../../../web/assets/bootstrap/package.js', |
||
| 236 | __DIR__.'/../../../../web/assets/bootstrap/package.json', |
||
| 237 | ]; |
||
| 238 | |||
| 239 | return $files; |
||
| 240 | } |
||
| 354 |
When comparing two booleans, it is generally considered safer to use the strict comparison operator.