CNotebookRepository::findByUser() - Code Metrics - Inspection of "Use autowire to load Entity repos" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cf75f9...66ca98 )

by Julito

created 2018-11-14 11:42 UTC

CNotebookRepository::findByUser() B

↳ Parent: CNotebookRepository

Complexity

Conditions	6
Paths	16

Size

Total Lines	53
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	31
nc	16
nop	5
dl	0
loc	53
rs	8.8017
c	0
b	0
f	0

How to fix Long Method

<?php
/* For licensing terms, see /license.txt */

namespace Chamilo\CourseBundle\Repository;

use Chamilo\CoreBundle\Entity\Course;
use Chamilo\CoreBundle\Entity\Session;
use Chamilo\CourseBundle\Entity\CNotebook;
use Chamilo\UserBundle\Entity\User;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Common\Persistence\ManagerRegistry;

/**
 * Class CNotebookRepository.
 *
 * @package Chamilo\CourseBundle\Repository
 */
class CNotebookRepository extends ServiceEntityRepository
{
    /**
     * CNotebookRepository constructor.
     *
     * @param ManagerRegistry $registry
     */
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, CNotebook::class);
    }

    /**
     * Get the user notebooks in a course.
     *
     * @param User         $user
     * @param Course       $course
     * @param Session|null $session
     * @param string       $orderField
     * @param string       $orderDirection
     *
     * @return array
     */
    public function findByUser(
        User $user,
        Course $course,
        Session $session = null,
        $orderField = 'creation_date',
        $orderDirection = 'DESC'
    ) {
        switch ($orderField) {
            case 'creation_date':
                $orderField = 'N.creationDate';
                break;
            case 'update_date':
                $orderField = 'N.updateDate';
                break;
            case 'title':
                $orderField = 'N.title';
                break;
        }

        $qb = $this->createQueryBuilder('N');
        $qb
            ->where(
                $qb->expr()->andX(
                    $qb->expr()->eq('N.userId', $user->getId()),
                    $qb->expr()->eq('N.cId', $course->getId())
                )
            );

        if ($session) {
            $qb->andWhere(
                $qb->expr()->eq('N.sessionId', $session->getId())
            );
        } else {
            $qb->andWhere(
                $qb->expr()->orX(
                    $qb->expr()->eq('N.sessionId', 0),
                    $qb->expr()->isNull('N.sessionId')
                )
            );
        }

        if ($orderField === 'N.updateDate') {
            $qb->andWhere(
                $qb->expr()->orX(
                    $qb->expr()->neq('N.updateDate', ''),
                    $qb->expr()->isNotNull('N.updateDate')
                )
            );
        }

        $qb->orderBy($orderField, $orderDirection);

        return $qb->getQuery()->getResult();
    }
}


1			<?php
2			/* For licensing terms, see /license.txt */
3
4			namespace Chamilo\CourseBundle\Repository;
5
6			use Chamilo\CoreBundle\Entity\Course;
7			use Chamilo\CoreBundle\Entity\Session;
8			use Chamilo\CourseBundle\Entity\CNotebook;
9			use Chamilo\UserBundle\Entity\User;
10			use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
11			use Doctrine\Common\Persistence\ManagerRegistry;
12
13			/**
14			* Class CNotebookRepository.
15			*
16			* @package Chamilo\CourseBundle\Repository
17			*/
18			class CNotebookRepository extends ServiceEntityRepository
19			{
20			/**
21			* CNotebookRepository constructor.
22			*
23			* @param ManagerRegistry $registry
24			*/
25			public function __construct(ManagerRegistry $registry)
26			{
27			parent::__construct($registry, CNotebook::class);
28			}
29
30			/**
31			* Get the user notebooks in a course.
32			*
33			* @param User $user
34			* @param Course $course
35			* @param Session\|null $session
36			* @param string $orderField
37			* @param string $orderDirection
38			*
39			* @return array
40			*/
41			public function findByUser(
42			User $user,
43			Course $course,
44			Session $session = null,
45			$orderField = 'creation_date',
46			$orderDirection = 'DESC'
47			) {
48			switch ($orderField) {
49			case 'creation_date':
50			$orderField = 'N.creationDate';
51			break;
52			case 'update_date':
53			$orderField = 'N.updateDate';
54			break;
55			case 'title':
56			$orderField = 'N.title';
57			break;
58			}
59
60			$qb = $this->createQueryBuilder('N');
61			$qb
62			->where(
63			$qb->expr()->andX(
64			$qb->expr()->eq('N.userId', $user->getId()),
65			$qb->expr()->eq('N.cId', $course->getId())
66			)
67			);
68
69			if ($session) {
70			$qb->andWhere(
71			$qb->expr()->eq('N.sessionId', $session->getId())
72			);
73			} else {
74			$qb->andWhere(
75			$qb->expr()->orX(
76			$qb->expr()->eq('N.sessionId', 0),
77			$qb->expr()->isNull('N.sessionId')
78			)
79			);
80			}
81
82			if ($orderField === 'N.updateDate') {
83			$qb->andWhere(
84			$qb->expr()->orX(
85			$qb->expr()->neq('N.updateDate', ''),
86			$qb->expr()->isNotNull('N.updateDate')
87			)
88			);
89			}
90
91			$qb->orderBy($orderField, $orderDirection);
92
93			return $qb->getQuery()->getResult();
94			}
95			}
96

chamilo / chamilo-lms

Push — master ( cf75f9...66ca98 )

CNotebookRepository::findByUser() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like