chamilo / chamilo-lms

main/install/index.php

Braces +4 added lines, -1 removed lines

@@ -445,7 +445,10 @@
     }
 }
     ?>
-    <input type="hidden" name="updatePath"         value="<?php if (!$badUpdatePath) echo api_htmlentities($proposedUpdatePath, ENT_QUOTES); ?>" />
+    <input type="hidden" name="updatePath"         value="<?php if (!$badUpdatePath) {
+    echo api_htmlentities($proposedUpdatePath, ENT_QUOTES);
+}
+?>" />
     <input type="hidden" name="urlAppendPath"      value="<?php echo api_htmlentities($urlAppendPath, ENT_QUOTES); ?>" />
     <input type="hidden" name="pathForm"           value="<?php echo api_htmlentities($pathForm, ENT_QUOTES); ?>" />
     <input type="hidden" name="urlForm"            value="<?php echo api_htmlentities($urlForm, ENT_QUOTES); ?>" />

main/lp/storageapi.php

Switch Indentation +46 added lines, -46 removed lines

@@ -15,52 +15,52 @@
 }
 
 switch ($_REQUEST['action']) {
-    case "get":
-        print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "set":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "getall":
-        print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
-        break;
-    case "stackpush":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "stackpop":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stacklength":
-        print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "stackclear":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "getposition":
-        print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
-        break;
-    case "getleaders":
-        print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
-        break;
-    case "usersgetall":
-// security issue
-        print "NOT allowed, security issue, see sources";
-//		print storage_get_all_users();
-        break;
-    default:
-        // Do nothing
+        case "get":
+            print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "set":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "getall":
+            print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
+            break;
+        case "stackpush":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "stackpop":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stacklength":
+            print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "stackclear":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stackgetall":
+            if (storage_can_set($_REQUEST['svuser']))
+                print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "getposition":
+            print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
+            break;
+        case "getleaders":
+            print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
+            break;
+        case "usersgetall":
+    // security issue
+            print "NOT allowed, security issue, see sources";
+    //		print storage_get_all_users();
+            break;
+        default:
+            // Do nothing
 }
 
 function storage_can_set($sv_user) {

Braces +30 added lines, -20 removed lines

@@ -45,8 +45,9 @@ 
         }
         break;
     case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        if (storage_can_set($_REQUEST['svuser'])) {
+                    print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        }
         break;
     case "getposition":
         print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
@@ -63,7 +64,8 @@ 
         // Do nothing
 }
 
-function storage_can_set($sv_user) {
+function storage_can_set($sv_user)
+{
     // platform admin can change any user's stored values, other users can only change their own values
     $allowed = ((api_is_platform_admin()) || ($sv_user == api_get_user_id()));
     if (!$allowed) {
@@ -72,7 +74,8 @@ 
     return $allowed;
 }
 
-function storage_get($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_get($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select sv_value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         where user_id= '$sv_user'
@@ -87,13 +90,13 @@ 
         } else {
             return $row['sv_value'];
         }
-    }
-    else {
+    } else {
         return null;
     }
 }
 
-function storage_get_leaders($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length) {
+function storage_get_leaders($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length)
+{
 
     // get leaders
     $sql_leaders = "select u.user_id, firstname, lastname, email, username, sv_value as value
@@ -127,7 +130,8 @@ 
     return json_encode($result);
 }
 
-function storage_get_position($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length) {
+function storage_get_position($sv_user, $sv_course, $sv_sco, $sv_key, $sv_asc, $sv_length)
+{
     $sql = "select count(list.user_id) as position
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)." search,
             ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)." list
@@ -144,13 +148,13 @@ 
     if (Database::num_rows($res) > 0) {
         $row = Database::fetch_assoc($res);
         return $row['position'];
-    }
-    else {
+    } else {
         return null;
     }
 }
 
-function storage_set($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value) {
+function storage_set($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value)
+{
     $sv_value = Database::escape_string($sv_value);
     $sql = "replace into ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         (user_id, sco_id, course_id, sv_key, sv_value)
@@ -160,7 +164,8 @@ 
     return Database::affected_rows($res);
 }
 
-function storage_getall($sv_user, $sv_course, $sv_sco) {
+function storage_getall($sv_user, $sv_course, $sv_sco)
+{
     $sql = "select sv_key, sv_value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)."
         where user_id= '$sv_user'
@@ -177,7 +182,8 @@ 
     return json_encode($data);
 }
 
-function storage_stack_push($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value) {
+function storage_stack_push($sv_user, $sv_course, $sv_sco, $sv_key, $sv_value)
+{
     $sv_value = Database::escape_string($sv_value);
     Database::query("start transaction");
     $sqlorder = "select ifnull((select max(stack_order)
@@ -198,14 +204,14 @@ 
     if ($resorder && $resinsert) {
         Database::query("commit");
         return 1;
-    }
-    else {
+    } else {
         Database::query("rollback");
         return 0;
     }
 }
 
-function storage_stack_pop($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_pop($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     Database::query("start transaction");
     $sqlselect = "select sv_value, stack_order
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
@@ -239,7 +245,8 @@ 
     }
 }
 
-function storage_stack_length($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_length($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select count(*) as length
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -251,7 +258,8 @@ 
     return $row['length'];
 }
 
-function storage_stack_clear($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_clear($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "delete
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -262,7 +270,8 @@ 
     return Database::num_rows($res);
 }
 
-function storage_stack_getall($sv_user, $sv_course, $sv_sco, $sv_key) {
+function storage_stack_getall($sv_user, $sv_course, $sv_sco, $sv_key)
+{
     $sql = "select stack_order as stack_order, sv_value as value
         from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES_STACK)."
         where user_id= '$sv_user'
@@ -280,7 +289,8 @@ 
     return json_encode($results);
 }
 
-function storage_get_all_users() {
+function storage_get_all_users()
+{
     $sql = "select user_id, username, firstname, lastname
         from ".Database::get_main_table(TABLE_MAIN_USER)."
         order by user_id asc";

main/upload/upload.php

Switch Indentation +10 added lines, -10 removed lines

@@ -31,14 +31,14 @@
  * Redirect to the correct script to handle this type of upload
  */
 switch ($toolFromSession) {
-    case TOOL_LEARNPATH:
-        require 'upload.scorm.php';
-        break;
-    //the following cases need to be distinguished later on
-    case TOOL_DROPBOX:
-    case TOOL_STUDENTPUBLICATION:
-    case TOOL_DOCUMENT:
-    default:
-        require 'upload.document.php';
-        break;
+        case TOOL_LEARNPATH:
+            require 'upload.scorm.php';
+            break;
+        //the following cases need to be distinguished later on
+        case TOOL_DROPBOX:
+        case TOOL_STUDENTPUBLICATION:
+        case TOOL_DOCUMENT:
+        default:
+            require 'upload.document.php';
+            break;
 }

main/user/user_export.php

Switch Indentation +11 added lines, -11 removed lines

@@ -149,15 +149,15 @@
 }
 
 switch ($file_type) {
-    case 'xml':
-        Export::arrayToXml($data, $filename, 'Contact', 'Contacts');
-        exit;
-        break;
-    case 'csv':
-        Export::arrayToCsv($data, $filename);
-        exit;
-    case 'xls':
-        Export::arrayToXls($data, $filename);
-        exit;
-        break;
+        case 'xml':
+            Export::arrayToXml($data, $filename, 'Contact', 'Contacts');
+            exit;
+            break;
+        case 'csv':
+            Export::arrayToCsv($data, $filename);
+            exit;
+        case 'xls':
+            Export::arrayToXls($data, $filename);
+            exit;
+            break;
 }
\ No newline at end of file

main/admin/user_update_import.php

Braces +4 added lines, -1 removed lines

@@ -464,7 +464,10 @@
 <blockquote>
     <pre>
         <b>UserName</b>;LastName;FirstName;Email;NewUserName;Password;AuthSource;OfficialCode;PhoneNumber;Status;ExpiryDate;Active;Language;Courses;ClassId;
-        xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;YYYY-MM-DD 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) echo implode(';', $list_reponse).';'; ?></span>xxx1|xxx2|xxx3;1;<br />
+        xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;YYYY-MM-DD 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) {
+    echo implode(';', $list_reponse).';';
+}
+?></span>xxx1|xxx2|xxx3;1;<br />
     </pre>
 </blockquote>
 <p><?php

plugin/buycourses/src/configuration.php

Braces +2 added lines, -2 removed lines

@@ -40,12 +40,12 @@
 $tpl->assign('sessions_are_included', $includeSession);

 $tpl->assign('services_are_included', $includeServices);

 

-if ($includeSession) {

+if ($includeSession) {
     $sessions = $plugin->getSessionsForConfiguration();

     $tpl->assign('sessions', $sessions);

 }

 

-if ($includeServices) {

+if ($includeServices) {
     $services = $plugin->getServices();

     $tpl->assign('services', $services);

 }

plugin/buycourses/src/course_catalog.php

Braces +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
     FormValidator::LAYOUT_INLINE

 );

 

-if ($form->validate()) {

+if ($form->validate()) {
     $formValues = $form->getSubmitValues();

     $nameFilter = isset($formValues['name']) ? $formValues['name'] : null;

     $minFilter = isset($formValues['min']) ? $formValues['min'] : 0;

@@ -54,7 +54,7 @@ 
 $courseList = $plugin->getCatalogCourseList($nameFilter, $minFilter, $maxFilter);

 

 //View

-if (api_is_platform_admin()) {

+if (api_is_platform_admin()) {
     $interbreadcrumb[] = [

         'url' => 'configuration.php',

         'name' => $plugin->get_lang('AvailableCoursesConfiguration')

@@ -63,7 +63,7 @@ 
         'url' => 'paymentsetup.php',

         'name' => $plugin->get_lang('PaymentsConfiguration')

     ];

-} else {

+} else {
     $interbreadcrumb[] = [

         'url' => 'course_panel.php',

         'name' => get_lang('TabsDashboard')

plugin/buycourses/src/index.buycourses.php

Braces +2 added lines, -2 removed lines

@@ -9,9 +9,9 @@
 $plugin = BuyCoursesPlugin::create();

 $guess_enable = $plugin->get('unregistered_users_enable');

 

-if ($guess_enable == "true" || isset($_SESSION['_user'])) {

+if ($guess_enable == "true" || isset($_SESSION['_user'])) {
     // If the user is NOT an administrator, redirect it to course/session buy list

-    if (!api_is_platform_admin()) {

+    if (!api_is_platform_admin()) {
         header('Location: src/course_panel.php');

         exit;

     }

plugin/buycourses/src/paymentsetup.php

Braces +9 added lines, -9 removed lines

@@ -18,8 +18,8 @@ 
 $commissionsEnable = $plugin->get('commissions_enable');

 $culqiEnable = $plugin->get('culqi_enable');

 

-if (isset($_GET['action'], $_GET['id'])) {

-    if ($_GET['action'] == 'delete_taccount') {

+if (isset($_GET['action'], $_GET['id'])) {
+    if ($_GET['action'] == 'delete_taccount') {
         $plugin->deleteTransferAccount($_GET['id']);

 

         Display::addFlash(

@@ -33,7 +33,7 @@ 
 

 $currencyForm = new FormValidator('currency');

 

-if ($currencyForm->validate()) {

+if ($currencyForm->validate()) {
     $currencyFormValues = $currencyForm->getSubmitValues();

 

     $plugin->selectCurrency($currencyFormValues['currency']);

@@ -59,7 +59,7 @@ 
     [get_lang('Select')]

 );

 

-foreach ($currencies as $currency) {

+foreach ($currencies as $currency) {
     $currencyText = implode(

         ' => ',

         [

@@ -71,7 +71,7 @@ 
 

     $currencySelect->addOption($currencyText, $currencyValue);

 

-    if ($currency['status']) {

+    if ($currency['status']) {
         $currencySelect->setSelected($currencyValue);

     }

 }

@@ -84,7 +84,7 @@ 
 

 $paypalForm = new FormValidator('paypal');

 

-if ($paypalForm->validate()) {

+if ($paypalForm->validate()) {
     $paypalFormValues = $paypalForm->getSubmitValues();

 

     $plugin->savePaypalParams($paypalFormValues);

@@ -123,7 +123,7 @@ 
 

 $commissionForm = new FormValidator('commissions');

 

-if ($commissionForm->validate()) {

+if ($commissionForm->validate()) {
     $commissionFormValues = $commissionForm->getSubmitValues();

 

     $plugin->updateCommission($commissionFormValues);

@@ -149,7 +149,7 @@ 
 

 $transferForm = new FormValidator('transfer_account');

 

-if ($transferForm->validate()) {

+if ($transferForm->validate()) {
     $transferFormValues = $transferForm->getSubmitValues();

 

     $plugin->saveTransferAccount($transferFormValues);

@@ -188,7 +188,7 @@ 
 

 $culqiForm = new FormValidator('culqi_config');

 

-if ($culqiForm->validate()) {

+if ($culqiForm->validate()) {
     $culqiFormValues = $culqiForm->getSubmitValues();

 

     $plugin->saveCulqiParameters($culqiFormValues);