chamilo / chamilo-lms

main/lp/learnpathItem.class.php

Doc Comments +5 added lines, -5 removed lines

@@ -1869,7 +1869,7 @@ 
 
     /**
      * Get the extra terms (tags) that identify this item
-     * @return mixed
+     * @return string
      */
     public function get_terms()
     {
@@ -2069,7 +2069,7 @@ 
 
     /**
      * Opens/launches the item. Initialises runtime values.
-     * @return    boolean    True on success, false on failure.
+     * @return    boolean|null    True on success, false on failure.
      */
     public function open($allow_new_attempt = false)
     {
@@ -3504,7 +3504,7 @@ 
 
     /**
      * Checks if the current status is part of the list of status given
-     * @param  array  $list  An array of status to check for.
+     * @param  string[]  $list  An array of status to check for.
      * If the current status is one of the strings, return true
      *
      * @return boolean True if the status was one of the given strings,
@@ -3681,7 +3681,7 @@ 
     /**
      * Write objectives to DB. This method is separate from write_to_db() because otherwise
      * objectives are lost as a side effect to AJAX and session concurrent access
-     * @return    boolean        True or false on error
+     * @return    boolean|null        True or false on error
      */
     public function write_objectives_to_db()
     {
@@ -4322,7 +4322,7 @@ 
      * Removes the relation between the current item and an audio file. The file
      * is only removed from the lp_item table, but remains in the document table
      * and directory
-     * @return bool
+     * @return false|null
      */
     public function remove_audio()
     {

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -3386,7 +3386,7 @@ 
 
         // TODO: Validate csv string.
         $terms = Database::escape_string(api_htmlentities($new_terms_string, ENT_QUOTES, $charset));
-        $sql = "UPDATE $lp_item
+        $sql = "update $lp_item
                 SET terms = '$terms'
                 WHERE
                     c_id = $course_id AND
@@ -3653,7 +3653,7 @@ 
         if ($this->seriousgame_mode != 1 ||
             !in_array($row['status'], $case_completed)
         ) {
-            $sql = "UPDATE $item_view_table
+            $sql = "update $item_view_table
                       SET total_time = '$total_time'
                     WHERE 
                         c_id = $course_id AND 
@@ -3733,7 +3733,7 @@ 
                         // Update (or don't).
                         $iva_row = Database::fetch_array($iva_res);
                         $iva_id = $iva_row[0];
-                        $ivau_sql = "UPDATE $iva_table ".
+                        $ivau_sql = "update $iva_table ".
                             "SET objective_id = '".Database::escape_string($objective[0])."',".
                             "status = '".Database::escape_string($objective[1])."',".
                             "score_raw = '".Database::escape_string($objective[2])."',".
@@ -3756,7 +3756,7 @@ 
 
                         $insertId = Database::insert($iva_table, $params);
 
-                        $sql = "UPDATE $iva_table SET id = iid WHERE iid = $insertId";
+                        $sql = "update $iva_table SET id = iid WHERE iid = $insertId";
                         Database::query($sql);
                     }
                 }
@@ -3862,7 +3862,7 @@ 
                 $this->db_item_view_id = Database::insert($item_view_table, $params);
 
                 if ($this->db_item_view_id) {
-                    $sql = "UPDATE $item_view_table SET id = iid
+                    $sql = "update $item_view_table SET id = iid
                             WHERE iid = ".$this->db_item_view_id;
                     Database::query($sql);
                     $inserted = true;
@@ -3911,7 +3911,7 @@ 
                 $this->db_item_view_id = Database::insert($item_view_table, $params);
 
                 if ($this->db_item_view_id) {
-                    $sql = "UPDATE $item_view_table SET id = iid
+                    $sql = "update $item_view_table SET id = iid
                             WHERE iid = ".$this->db_item_view_id;
                     Database::query($sql);
                 }
@@ -4058,7 +4058,7 @@ 
                         //IF scorm scorm_update_time has already updated total_time in db
                         //" . //start_time = ".$this->get_current_start_time().", " . //scorm_init_time does it
                         ////" max_time_allowed = '".$this->get_max_time_allowed()."'," .
-                        $sql = "UPDATE $item_view_table SET
+                        $sql = "update $item_view_table SET
                                     score = ".$this->get_score().",
                                     $my_status
                                     max_score = '".$this->get_max()."',
@@ -4072,7 +4072,7 @@ 
 
                     } else {
                         //" max_time_allowed = '".$this->get_max_time_allowed()."'," .
-                        $sql = "UPDATE $item_view_table SET
+                        $sql = "update $item_view_table SET
                                     $total_time
                                     start_time = ".$this->get_current_start_time().",
                                     score = " . $this->get_score().",
@@ -4198,7 +4198,7 @@ 
 
                             $insertId = Database::insert($iva_table, $params);
                             if ($insertId) {
-                                $sql = "UPDATE $iva_table SET id = iid
+                                $sql = "update $iva_table SET id = iid
                                         WHERE iid = $insertId";
                                 Database::query($sql);
                             }
@@ -4284,7 +4284,7 @@ 
 
             // Store the mp3 file in the lp_item table.
             $tbl_lp_item = Database::get_course_table(TABLE_LP_ITEM);
-            $sql = "UPDATE $tbl_lp_item SET
+            $sql = "update $tbl_lp_item SET
                         audio = '".Database::escape_string($file_path)."'
                     WHERE
                         c_id = {$course_info['real_id']} AND
@@ -4312,7 +4312,7 @@ 
             $file_path = basename($document_data['path']);
             // Store the mp3 file in the lp_item table.
             $tbl_lp_item = Database::get_course_table(TABLE_LP_ITEM);
-            $sql = "UPDATE $tbl_lp_item SET
+            $sql = "update $tbl_lp_item SET
                         audio = '".Database::escape_string($file_path)."'
                     WHERE
                         c_id = {$course_info['real_id']} AND
@@ -4335,7 +4335,7 @@ 
         if (empty($this->db_id)) {
             return false;
         }
-        $sql = "UPDATE $tbl_lp_item SET
+        $sql = "update $tbl_lp_item SET
                 audio = ''
                 WHERE c_id = $course_id AND id IN (".$this->db_id.")";
         Database::query($sql);

Braces +8 added lines, -4 removed lines

@@ -745,7 +745,8 @@ 
     public function get_lesson_mode()
     {
         $mode = 'normal';
-        if ($this->get_prevent_reinit() != 0) { // If prevent_reinit == 0
+        if ($this->get_prevent_reinit() != 0) {
+// If prevent_reinit == 0
             $my_status = $this->get_status();
             if ($my_status != $this->possible_status[0]
                     && $my_status != $this->possible_status[1]) {
@@ -2037,11 +2038,13 @@ 
         $restart = 1;
         $mystatus = $this->get_status(true);
         if ($this->get_prevent_reinit() > 0
-        ) { // If prevent_reinit == 1 (or more)
+        ) {
+// If prevent_reinit == 1 (or more)
             // If status is not attempted or incomplete, authorize retaking (of the same) anyway. Otherwise:
             if ($mystatus != $this->possible_status[0] && $mystatus != $this->possible_status[1]) {
                 $restart = -1;
-            } else { //status incompleted or not attempted
+            } else {
+//status incompleted or not attempted
                 $restart = 0;
             }
         } else {
@@ -2982,7 +2985,8 @@ 
                     // Do nothing, just let the local attributes be used.
                 }
             }
-        } else { // If not SCO, such messages should not be expected.
+        } else {
+// If not SCO, such messages should not be expected.
             $type = strtolower($this->type);
             switch ($type) {
                 case 'asset':

Spacing +2 added lines, -2 removed lines

@@ -1207,7 +1207,7 @@ 
                                                     );
                                                 }
                                             } elseif (strpos($second_part, '=') > 0) {
-                                                if (substr($second_part,0,1) === '/') {
+                                                if (substr($second_part, 0, 1) === '/') {
                                                     // Link starts with a /, making it absolute (relative to DocumentRoot).
                                                     $files_list[] = array(
                                                         $second_part,
@@ -1251,7 +1251,7 @@ 
                                                     }
                                                 } else {
                                                     // No starting '/', making it relative to current document's path.
-                                                    if (substr($second_part, 0,2) == './') {
+                                                    if (substr($second_part, 0, 2) == './') {
                                                         $second_part = substr(
                                                             $second_part,
                                                             2

src/Chamilo/UserBundle/Entity/User.php

Doc Comments +4 added lines, -4 removed lines

@@ -995,7 +995,7 @@ 
     /**
      * Get pictureUri
      *
-     * @return Media
+     * @return string
      */
     public function getPictureUri()
     {
@@ -1303,7 +1303,7 @@ 
     }
 
     /**
-     * @return Media
+     * @return string
      */
     public function getAvatar()
     {
@@ -2078,7 +2078,7 @@ 
       /**
      * Returns the user roles
      *
-     * @return array The roles
+     * @return string[] The roles
      */
     public function getRoles()
     {
@@ -2403,7 +2403,7 @@ 
     /**
      * Check if the user has the skill
      * @param Skill $skill The skill
-     * @return boolean
+     * @return boolean|null
      */
     public function hasSkill(Skill $skill)
     {

Indentation +10 added lines, -10 removed lines

@@ -1891,11 +1891,11 @@ 
         return $this->locale;
     }
 
-     /**
-     * @param string $timezone
-     *
-     * @return User
-     */
+        /**
+         * @param string $timezone
+         *
+         * @return User
+         */
     public function setTimezone($timezone)
     {
         $this->timezone = $timezone;
@@ -2073,11 +2073,11 @@ 
         }
     }
 
-      /**
-     * Returns the user roles
-     *
-     * @return array The roles
-     */
+        /**
+         * Returns the user roles
+         *
+         * @return array The roles
+         */
     public function getRoles()
     {
         $roles = $this->roles;

main/lp/lp_view_item.php

Indentation +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
 // Theme calls
 $show_learn_path = true;
 if (isset($_SESSION['oLP']) && is_object($_SESSION['oLP'])) {
-	$lp_theme_css = $_SESSION['oLP']->get_theme();
+    $lp_theme_css = $_SESSION['oLP']->get_theme();
 }
 
 if ($mode == 'fullpage') {

main/admin/filler.php

Indentation +2 added lines, -2 removed lines

@@ -53,8 +53,8 @@
     $result .= '<table>';
     foreach ($output as $line) {
         $result .= '<tr>';
-	    $result .= '<td class="filler-report-data-init">'.$line['line-init'].' </td><td class="filler-report-data">'.$line['line-info'].'</td>';
-	    $result .= '</tr>';
+        $result .= '<td class="filler-report-data-init">'.$line['line-init'].' </td><td class="filler-report-data">'.$line['line-info'].'</td>';
+        $result .= '</tr>';
     }
     $result .= '</table>';
     $result .= '</div>';

main/inc/lib/webservices/WebService.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -20,8 +20,8 @@
 
     /**
      * Class constructor
-     * @param $username
-     * @param $apiKey
+     * @param string $username
+     * @param string $apiKey
      */
     protected function __construct($username, $apiKey)
     {

main/inc/lib/webservices/Rest.php

Doc Comments -1 removed lines

@@ -318,7 +318,6 @@
     }
 
     /**
-     * @param int $courseId
      * @return array
      * @throws Exception
      */

Braces +2 added lines, -1 removed lines

@@ -809,7 +809,8 @@
      * @param string $encoded
      * @return array
      */
-    public static function decodeParams($encoded) {
+    public static function decodeParams($encoded)
+    {
         $decoded = str_replace(['-', '_', '.'], ['+', '/', '='], $encoded);
         $mod4 = strlen($decoded) % 4;
 

Spacing +1 added lines, -1 removed lines

@@ -483,7 +483,7 @@
         $notebooks = $notebooksRepo->findByUser($this->user, $this->course, $this->session);
 
         return array_map(
-            function (CNotebook $notebook) {
+            function(CNotebook $notebook) {
                 return [
                     'id' => $notebook->getIid(),
                     'title' => $notebook->getTitle(),

src/Chamilo/CoreBundle/Composer/ScriptHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getFoldersToDelete()
     {
@@ -95,7 +95,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getFilesToDelete()
     {

plugin/ims_lti/ImsLtiPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * Get the class instance
      * @staticvar MsiLtiPlugin $result
-     * @return MsiLtiPlugin
+     * @return ImsLtiPlugin
      */
     public static function create()
     {

plugin/ims_lti/ImsLtiTool.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
         return $this->id;
     }
 
+    /**
+     * @return string
+     */
     public function getName()
     {
         return $this->name;