chamilo / chamilo-lms

main/inc/lib/login.lib.php

Braces +22 added lines, -11 removed lines

@@ -80,7 +80,8 @@ 
     {
         $email_subject = "[".api_get_setting('siteName')."] ".get_lang('LoginRequest'); // SUBJECT
 
-        if ($by_username) { // Show only for lost password
+        if ($by_username) {
+// Show only for lost password
             $user_account_list = self::get_user_account_list($user, false, $by_username); // BODY
             $email_to = $user['email'];
         } else {
@@ -284,7 +285,8 @@ 
         global $is_allowedCreateCourse;
         global $_user;
 
-        if (isset($reset) && $reset) {    // session data refresh requested
+        if (isset($reset) && $reset) {
+// session data refresh requested
             unset($_SESSION['_user']['uidReset']);
             $is_platformAdmin = false;
             $is_allowedCreateCourse = false;
@@ -335,14 +337,16 @@ 
                     header('location:'.api_get_path(WEB_PATH));
                     //exit("WARNING UNDEFINED UID !! ");
                 }
-            } else { // no uid => logout or Anonymous
+            } else {
+// no uid => logout or Anonymous
                 Session::erase('_user');
                 Session::erase('_uid');
             }
 
             Session::write('is_platformAdmin', $is_platformAdmin);
             Session::write('is_allowedCreateCourse', $is_allowedCreateCourse);
-        } else { // continue with the previous values
+        } else {
+// continue with the previous values
             $_user = $_SESSION['_user'];
             $is_platformAdmin = $_SESSION['is_platformAdmin'];
             $is_allowedCreateCourse = $_SESSION['is_allowedCreateCourse'];
@@ -481,7 +485,8 @@ 
             }
         } else {
             // Continue with the previous values
-            if (empty($_SESSION['_course']) or empty($_SESSION['_cid'])) { //no previous values...
+            if (empty($_SESSION['_course']) or empty($_SESSION['_cid'])) {
+//no previous values...
                 $_cid = -1; //set default values that will be caracteristic of being unset
                 $_course = -1;
             } else {
@@ -654,7 +659,8 @@ 
                         $is_courseAdmin = true;
                     }
                 }
-            } else { // keys missing => not anymore in the course - user relation
+            } else {
+// keys missing => not anymore in the course - user relation
                 // course
                 $is_courseMember = false;
                 $is_courseAdmin = false;
@@ -746,12 +752,15 @@ 
         global $_course;
         global $_gid;
 
-        if ($reset) { // session data refresh requested
-            if ($group_id && $_cid && !empty($_course['real_id'])) { // have keys to search data
+        if ($reset) {
+// session data refresh requested
+            if ($group_id && $_cid && !empty($_course['real_id'])) {
+// have keys to search data
                 $group_table = Database::get_course_table(TABLE_GROUP);
                 $sql = "SELECT * FROM $group_table WHERE c_id = ".$_course['real_id']." AND id = '$group_id'";
                 $result = Database::query($sql);
-                if (Database::num_rows($result) > 0) { // This group has recorded status related to this course
+                if (Database::num_rows($result) > 0) {
+// This group has recorded status related to this course
                     $gpData = Database::fetch_array($result);
                     $_gid = $gpData ['id'];
                     Session::write('_gid', $_gid);
@@ -762,9 +771,11 @@ 
                 // Keys missing => not anymore in the group - course relation
                 Session::erase('_gid');
             }
-        } elseif (isset($_SESSION['_gid'])) { // continue with the previous values
+        } elseif (isset($_SESSION['_gid'])) {
+// continue with the previous values
             $_gid = $_SESSION ['_gid'];
-        } else { //if no previous value, assign caracteristic undefined value
+        } else {
+//if no previous value, assign caracteristic undefined value
             $_gid = -1;
         }
 

main/inc/lib/baker.lib.php

Braces +9 added lines, -4 removed lines

@@ -97,8 +97,9 @@ 
         // Read the magic bytes and verify
         $retval = substr($png, 0, 8);
         $ipos = 8;
-        if ($retval != "\x89PNG\x0d\x0a\x1a\x0a")
-            throw new Exception('Is not a valid PNG image');
+        if ($retval != "\x89PNG\x0d\x0a\x1a\x0a") {
+                    throw new Exception('Is not a valid PNG image');
+        }
         // Loop through the chunks. Byte 0-3 is length, Byte 4-7 is type
         $chunkHeader = substr($png, $ipos, 8);
         $ipos = $ipos + 8;
@@ -110,13 +111,17 @@ 
                 $data = substr($png, $ipos, $chunk['size']);
                 $sections = explode("\0", $data);
                 print_r($sections);
-                if ($sections[0] == $key) $skip = true;
+                if ($sections[0] == $key) {
+                    $skip = true;
+                }
             }
             // Extract the data and the CRC
             $data = substr($png, $ipos, $chunk['size'] + 4);
             $ipos = $ipos + $chunk['size'] + 4;
             // Add in the header, data, and CRC
-            if (!$skip) $retval = $retval.$chunkHeader.$data;
+            if (!$skip) {
+                $retval = $retval.$chunkHeader.$data;
+            }
             // Read next chunk header
             $chunkHeader = substr($png, $ipos, 8);
             $ipos = $ipos + 8;

main/social/require_user_linking.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 if ($form->validate()) {
     $values = $form->exportValues();
     //Avoid self-subscribe as request
-    $usersId = array_filter($values['users'], function ($userId) use ($hrm) {
+    $usersId = array_filter($values['users'], function($userId) use ($hrm) {
         return (int) $userId != $hrm->getId();
     });
 

main/exercise/exercise_report.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -211,7 +211,7 @@ 
         $tot += $row['marks'];
     }
 
-    $sql = "UPDATE $TBL_TRACK_EXERCISES
+    $sql = "update $TBL_TRACK_EXERCISES
             SET exe_result = '".floatval($tot)."'
             WHERE exe_id = ".$id;
 
@@ -240,7 +240,7 @@ 
 
     // Updating LP score here
     if (in_array($origin, array('tracking_course', 'user_course', 'correct_exercise_in_lp'))) {
-        $sql = "UPDATE $TBL_LP_ITEM_VIEW 
+        $sql = "update $TBL_LP_ITEM_VIEW 
                 SET score = '".floatval($tot)."'
                 WHERE c_id = ".$course_id." AND id = ".$lp_item_view_id;
         Database::query($sql);
@@ -358,7 +358,7 @@ 
 ) {
     // Close the user attempt otherwise left pending
     $exe_id = intval($_GET['id']);
-    $sql = "UPDATE $TBL_TRACK_EXERCISES SET status = '' 
+    $sql = "update $TBL_TRACK_EXERCISES SET status = '' 
             WHERE exe_id = $exe_id AND status = 'incomplete'";
     Database::query($sql);
 }

main/tracking/course_log_resources.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     $csvData = TrackingCourseLog::get_item_resources_data(0, 0, '', '');
     array_walk(
         $csvData,
-        function (&$item) {
+        function(&$item) {
             $item[0] = strip_tags($item[0]);
             $item[2] = strip_tags(preg_replace('/\<br(\s*)?\/?\>/i', PHP_EOL, $item[2]));
             $item[3] = strip_tags($item[3]);

main/attendance/index.php

Switch Indentation +103 added lines, -103 removed lines

@@ -228,113 +228,113 @@
 }
 
 switch ($action) {
-    case 'attendance_list':
-        $attendanceController->attendance_list();
-        break;
-    case 'attendance_add':
-        if ($allowToEdit) {
-            $attendanceController->attendance_add();
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'attendance_edit':
-        if ($allowToEdit) {
-            $attendanceController->attendance_edit($attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'attendance_delete':
-        if ($allowToEdit) {
-            $attendanceController->attendance_delete($attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'attendance_set_invisible':
-        if ($allowToEdit) {
-            $attendanceController->attendanceSetInvisible($attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'attendance_set_visible':
-        if ($allowToEdit) {
-            $attendanceController->attendanceSetVisible($attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    /*case 'attendance_restore':
+        case 'attendance_list':
+            $attendanceController->attendance_list();
+            break;
+        case 'attendance_add':
+            if ($allowToEdit) {
+                $attendanceController->attendance_add();
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'attendance_edit':
+            if ($allowToEdit) {
+                $attendanceController->attendance_edit($attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'attendance_delete':
+            if ($allowToEdit) {
+                $attendanceController->attendance_delete($attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'attendance_set_invisible':
+            if ($allowToEdit) {
+                $attendanceController->attendanceSetInvisible($attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'attendance_set_visible':
+            if ($allowToEdit) {
+                $attendanceController->attendanceSetVisible($attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        /*case 'attendance_restore':
         if ($allowToEdit) {
             $attendanceController->attendance_restore($attendance_id);
         } else {
             api_not_allowed(true);
         }
         break;*/
-    case 'attendance_sheet_list':
-        $attendanceController->attendance_sheet(
-            $action,
-            $attendance_id,
-            $student_id,
-            true
-        );
-        break;
-    case 'attendance_sheet_list_no_edit':
-        $attendanceController->attendance_sheet(
-            $action,
-            $attendance_id,
-            $student_id,
-            false
-        );
-        break;
-    case 'attendance_sheet_export_to_pdf':
-        $attendanceController->attendance_sheet_export_to_pdf(
-            $action,
-            $attendance_id,
-            $student_id,
-            $course_id
-        );
-        break;
-    case 'attendance_sheet_add':
-        if ($allowToEdit) {
-            $attendanceController->attendance_sheet($action, $attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'lock_attendance':
-    case 'unlock_attendance':
-        if ($allowToEdit) {
-            $attendanceController->lock_attendance($action, $attendance_id);
-        } else {
-            api_not_allowed(true);
-        }
-        break;
-    case 'calendar_add':
-        //no break
-    case 'calendar_edit':
-        //no break
-    case 'calendar_all_delete':
-        //no break
-    case 'calendar_delete':
-        if (!$allowToEdit) {
-            api_not_allowed(true);
-        }
-        //no break
-    case 'calendar_list':
-        $attendanceController->attendance_calendar(
-            $action,
-            $attendance_id,
-            $calendar_id
-        );
-        break;
-    case 'calendar_logins':
-        if (api_is_course_admin() || api_is_drh()) {
-            $attendanceController->getAttendanceBaseInLogin(false, true);
-        }
-        break;
-    default:
-        $attendanceController->attendance_list();
+        case 'attendance_sheet_list':
+            $attendanceController->attendance_sheet(
+                $action,
+                $attendance_id,
+                $student_id,
+                true
+            );
+            break;
+        case 'attendance_sheet_list_no_edit':
+            $attendanceController->attendance_sheet(
+                $action,
+                $attendance_id,
+                $student_id,
+                false
+            );
+            break;
+        case 'attendance_sheet_export_to_pdf':
+            $attendanceController->attendance_sheet_export_to_pdf(
+                $action,
+                $attendance_id,
+                $student_id,
+                $course_id
+            );
+            break;
+        case 'attendance_sheet_add':
+            if ($allowToEdit) {
+                $attendanceController->attendance_sheet($action, $attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'lock_attendance':
+        case 'unlock_attendance':
+            if ($allowToEdit) {
+                $attendanceController->lock_attendance($action, $attendance_id);
+            } else {
+                api_not_allowed(true);
+            }
+            break;
+        case 'calendar_add':
+            //no break
+        case 'calendar_edit':
+            //no break
+        case 'calendar_all_delete':
+            //no break
+        case 'calendar_delete':
+            if (!$allowToEdit) {
+                api_not_allowed(true);
+            }
+            //no break
+        case 'calendar_list':
+            $attendanceController->attendance_calendar(
+                $action,
+                $attendance_id,
+                $calendar_id
+            );
+            break;
+        case 'calendar_logins':
+            if (api_is_course_admin() || api_is_drh()) {
+                $attendanceController->getAttendanceBaseInLogin(false, true);
+            }
+            break;
+        default:
+            $attendanceController->attendance_list();
 }

main/inc/lib/certificate.lib.php

Doc Comments +3 added lines, -3 removed lines

@@ -273,7 +273,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function notificationTags()
     {
@@ -297,7 +297,7 @@ 
      * @param array $courseInfo
      * @param array $certificateInfo
      *
-     * @return bool
+     * @return false|null
      */
     public static function sendNotification(
         $subject,
@@ -395,7 +395,7 @@ 
      * Generates a QR code for the certificate. The QR code embeds the text given
      * @param string $text Text to be added in the QR code
      * @param string $path file path of the image
-     * @return bool
+     * @return null|false
      **/
     public function generateQRImage($text, $path)
     {

Indentation +8 added lines, -8 removed lines

@@ -351,12 +351,12 @@ 
     }
 
     /**
-    * update user info about certificate
-    * @param int $cat_id category id
-    * @param int $user_id user id
-    * @param string $path_certificate the path name of the certificate
-    * @return void
-    */
+     * update user info about certificate
+     * @param int $cat_id category id
+     * @param int $user_id user id
+     * @param string $path_certificate the path name of the certificate
+     * @return void
+     */
     public function updateUserCertificateInfo(
         $cat_id,
         $user_id,
@@ -518,8 +518,8 @@ 
     }
 
     /**
-    * Shows the student's certificate (HTML file)
-    */
+     * Shows the student's certificate (HTML file)
+     */
     public function show()
     {
         header('Content-Type: text/html; charset='.api_get_system_encoding());

plugin/bbb/lib/bbb.lib.php

Doc Comments +5 added lines, -5 removed lines

@@ -401,7 +401,7 @@ 
      * Save a participant in a meeting room
      * @param int $meetingId
      * @param int $participantId
-     * @return false|int The last inserted ID. Otherwise return false
+     * @return false|string The last inserted ID. Otherwise return false
      */
     public function saveParticipant($meetingId, $participantId)
     {
@@ -478,7 +478,7 @@ 
     /**
      * Returns a meeting "join" URL
      * @param string The name of the meeting (usually the course code)
-     * @return mixed The URL to join the meeting, or false on error
+     * @return false|string The URL to join the meeting, or false on error
      * @todo implement moderator pass
      * @assert ('') === false
      * @assert ('abcdefghijklmnopqrstuvwxyzabcdefghijklmno') === false
@@ -872,7 +872,7 @@ 
      * @param string The internal ID of the meeting (id field for this meeting)
      * @param string $courseCode
      *
-     * @return void
+     * @return false|null
      * @assert (0) === false
      */
     public function endMeeting($id, $courseCode = null)
@@ -1358,7 +1358,7 @@ 
      * @param array $recordInfo
      * @param bool $isGlobal
      * @param bool $isAdminReport
-     * @return array
+     * @return string[]
      */
     private function getActionLinks($meetingInfo, $recordInfo, $isGlobal = false, $isAdminReport = false)
     {
@@ -1488,7 +1488,7 @@ 
 
     /**
      * @param array $userInfo
-     * @return bool
+     * @return boolean|null
      */
     public static function showGlobalConferenceLink($userInfo)
     {

main/inc/lib/chat.lib.php

Doc Comments +3 added lines

@@ -63,6 +63,9 @@
         );
     }
 
+    /**
+     * @param integer $latestMessages
+     */
     public function getLatestChat($currentUserId, $userId, $latestMessages)
     {
         $items = self::getPreviousMessages(

Indentation +10 added lines, -10 removed lines

@@ -48,12 +48,12 @@ 
     }
 
     /**
-    * Set user chat status
-    * @param int 0 if disconnected, 1 if connected
-    * @param integer $status
+     * Set user chat status
+     * @param int 0 if disconnected, 1 if connected
+     * @param integer $status
      *
-    * @return void
-    */
+     * @return void
+     */
     public function setUserStatus($status)
     {
         UserManager::update_extra_field_value(
@@ -324,10 +324,10 @@ 
     }
 
     /**
-    * Returns an array of messages inside a chat session with a specific user
-    * @param int The ID of the user with whom the current user is chatting
-    * @return array Messages list
-    */
+     * Returns an array of messages inside a chat session with a specific user
+     * @param int The ID of the user with whom the current user is chatting
+     * @return array Messages list
+     */
     public function box_session($user_id)
     {
         $items = array();
@@ -476,7 +476,7 @@ 
             }
         }
 
-         return false;
+            return false;
     }
 
     /**