chamilo / chamilo-lms

plugin/sepe/ws/service.php

Doc Comments +4 added lines

@@ -35,6 +35,10 @@
         $this->setReturnResponse(true);
     }
 
+    /**
+     * @param string $tag
+     * @param string $namespace
+     */
     private function addNamespaceToTag($response, $tag, $namespace)
     {
         return str_replace(

Indentation +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
             return false;
         }
     } else {
-         return false;
+            return false;
     }
 }
 

Braces +2 added lines, -1 removed lines

@@ -93,7 +93,8 @@
 
     if (Database::num_rows($result) > 0) {
         $row = Database::fetch_row($result);
-        if ($row[1] == '4') { //UserManager::is_admin($row[0])) {
+        if ($row[1] == '4') {
+//UserManager::is_admin($row[0])) {
             return true;
         } else {
             return false;

main/inc/lib/timeline.lib.php

Indentation +9 added lines, -9 removed lines

@@ -25,10 +25,10 @@ 
     );
     public $is_course_model = true;
 
-	public function __construct()
+    public function __construct()
     {
         $this->table = Database::get_course_table(TABLE_TIMELINE);
-	}
+    }
 
     /**
      * Get the count of elements
@@ -68,16 +68,16 @@ 
     /**
      * Displays the title + grid
      */
-	public function listing()
+    public function listing()
     {
-		// action links
-		$html = '<div class="actions">';
+        // action links
+        $html = '<div class="actions">';
         //$html .= '<a href="career_dashboard.php">'.Display::return_icon('back.png',get_lang('Back'),'','32').'</a>';
-		$html .= '<a href="'.api_get_self().'?action=add">'.Display::return_icon('add.png', get_lang('Add'), '', '32').'</a>';
-		$html .= '</div>';
+        $html .= '<a href="'.api_get_self().'?action=add">'.Display::return_icon('add.png', get_lang('Add'), '', '32').'</a>';
+        $html .= '</div>';
         $html .= Display::grid_html('timelines');
         return $html;
-	}
+    }
 
     public function get_status_list()
     {
@@ -260,7 +260,7 @@ 
         $item['asset'] = array('media'     => $item['media'],
                                 'credit'    => $item['media_credit'],
                                 'caption'   => $item['media_caption'],
-         );
+            );
 
         //Cleaning items
         unset($item['id']);

Braces +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
     public $is_course_model = true;
 
 	public function __construct()
-    {
+	{
         $this->table = Database::get_course_table(TABLE_TIMELINE);
 	}
 
@@ -69,7 +69,7 @@ 
      * Displays the title + grid
      */
 	public function listing()
-    {
+	{
 		// action links
 		$html = '<div class="actions">';
         //$html .= '<a href="career_dashboard.php">'.Display::return_icon('back.png',get_lang('Back'),'','32').'</a>';

main/exercise/export/qti2/qti2_export.php

Indentation +90 added lines, -90 removed lines

@@ -26,10 +26,10 @@ 
     public $answer;
 
     /**
-    * Constructor.
-    *
-    * @param Ims2Question $question Ims2Question object we want to export.
-    */
+     * Constructor.
+     *
+     * @param Ims2Question $question Ims2Question object we want to export.
+     */
     public function __construct($question)
     {
         $this->question = $question;
@@ -38,11 +38,11 @@ 
     }
 
     /**
-    * Start the XML flow.
-    *
-    * This opens the <item> block, with correct attributes.
-    *
-    */
+     * Start the XML flow.
+     *
+     * This opens the <item> block, with correct attributes.
+     *
+     */
     public function start_item()
     {
         $categoryTitle = '';
@@ -66,49 +66,49 @@ 
     }
 
     /**
-    * End the XML flow, closing the </item> tag.
-    *
-    */
+     * End the XML flow, closing the </item> tag.
+     *
+     */
     public function end_item()
     {
         return "</assessmentItem>\n";
     }
 
     /**
-    * Start the itemBody
-    *
-    */
+     * Start the itemBody
+     *
+     */
     public function start_item_body()
     {
         return '  <itemBody>'."\n";
     }
 
     /**
-    * End the itemBody part.
-    *
-    */
+     * End the itemBody part.
+     *
+     */
     public function end_item_body()
     {
         return "  </itemBody>\n";
     }
 
     /**
-    * add the response processing template used.
-    *
-    */
+     * add the response processing template used.
+     *
+     */
     public function add_response_processing()
     {
         return '  <responseProcessing template="http://www.imsglobal.org/question/qti_v2p1/rptemplates/map_correct"/>'."\n";
     }
 
     /**
-    * Export the question as an IMS/QTI Item.
-    *
-    * This is a default behaviour, some classes may want to override this.
-    *
-    * @param $standalone: Boolean stating if it should be exported as a stand-alone question
-    * @return string string, the XML flow for an Item.
-    */
+     * Export the question as an IMS/QTI Item.
+     *
+     * This is a default behaviour, some classes may want to override this.
+     *
+     * @param $standalone: Boolean stating if it should be exported as a stand-alone question
+     * @return string string, the XML flow for an Item.
+     */
     public function export($standalone = false)
     {
         $head = $foot = '';
@@ -201,8 +201,8 @@ 
     public function export_presentation()
     {
         $out = "<presentation_material><flow_mat><material>\n"
-             . "  <mattext><![CDATA[".formatExerciseQtiDescription($this->exercise->selectDescription())."]]></mattext>\n"
-             . "</material></flow_mat></presentation_material>\n";
+                . "  <mattext><![CDATA[".formatExerciseQtiDescription($this->exercise->selectDescription())."]]></mattext>\n"
+                . "</material></flow_mat></presentation_material>\n";
         return $out;
     }
 
@@ -216,15 +216,15 @@ 
         $out = '';
         if ($n = $this->exercise->getShuffle()) {
             $out .= "<selection_ordering>"
-                 . "  <selection>\n"
-                 . "    <selection_number>".$n."</selection_number>\n"
-                 . "  </selection>\n"
-                 . '  <order order_type="Random" />'
-                 . "\n</selection_ordering>\n";
+                    . "  <selection>\n"
+                    . "    <selection_number>".$n."</selection_number>\n"
+                    . "  </selection>\n"
+                    . '  <order order_type="Random" />'
+                    . "\n</selection_ordering>\n";
         } else {
             $out .= '<selection_ordering sequence_type="Normal">'."\n"
-                 . "  <selection />\n"
-                 . "</selection_ordering>\n";
+                    . "  <selection />\n"
+                    . "</selection_ordering>\n";
         }
 
         return $out;
@@ -255,18 +255,18 @@ 
         $head = $foot = '';
         if ($standalone) {
             $head = '<?xml version = "1.0" encoding = "UTF-8" standalone = "no"?>'."\n"
-                  . '<!DOCTYPE questestinterop SYSTEM "ims_qtiasiv2p1.dtd">'."\n"
-                  . "<questestinterop>\n";
+                    . '<!DOCTYPE questestinterop SYSTEM "ims_qtiasiv2p1.dtd">'."\n"
+                    . "<questestinterop>\n";
             $foot = "</questestinterop>\n";
         }
         $out = $head
-             . $this->start_section()
-             . $this->export_duration()
-             . $this->export_presentation()
-             . $this->export_ordering()
-             . $this->export_questions()
-             . $this->end_section()
-             . $foot;
+                . $this->start_section()
+                . $this->export_duration()
+                . $this->export_presentation()
+                . $this->export_ordering()
+                . $this->export_questions()
+                . $this->end_section()
+                . $foot;
 
         return $out;
     }
@@ -307,11 +307,11 @@ 
     public $answer;
 
     /**
-    * Constructor.
-    *
-    * @param Question $question The Question object we want to export.
-    * @author Anamd Tihon
-    */
+     * Constructor.
+     *
+     * @param Question $question The Question object we want to export.
+     * @author Anamd Tihon
+     */
     public function __construct($question)
     {
         $this->question = $question;
@@ -320,35 +320,35 @@ 
     }
 
     /**
-    * Start the XML flow.
-    *
-    * This opens the <item> block, with correct attributes.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * Start the XML flow.
+     *
+     * This opens the <item> block, with correct attributes.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function start_item()
     {
         return '<item title="'.cleanAttribute(formatExerciseQtiDescription($this->question->selectTitle())).'" ident="'.$this->questionIdent.'">'."\n";
     }
 
     /**
-    * End the XML flow, closing the </item> tag.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * End the XML flow, closing the </item> tag.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function end_item()
     {
         return "</item>\n";
     }
 
     /**
-    * Create the opening, with the question itself.
-    *
-    * This means it opens the <presentation> but doesn't close it, as this is the role of end_presentation().
-    * In between, the export_responses from the subclass should have been called.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * Create the opening, with the question itself.
+     *
+     * This means it opens the <presentation> but doesn't close it, as this is the role of end_presentation().
+     * In between, the export_responses from the subclass should have been called.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function start_presentation()
     {
         return '<presentation label="'.$this->questionIdent.'"><flow>'."\n"
@@ -356,44 +356,44 @@ 
     }
 
     /**
-    * End the </presentation> part, opened by export_header.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * End the </presentation> part, opened by export_header.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function end_presentation()
     {
         return "</flow></presentation>\n";
     }
 
     /**
-    * Start the response processing, and declare the default variable, SCORE, at 0 in the outcomes.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * Start the response processing, and declare the default variable, SCORE, at 0 in the outcomes.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function start_processing()
     {
         return '<resprocessing><outcomes><decvar vartype="Integer" defaultval="0" /></outcomes>'."\n";
     }
 
     /**
-    * End the response processing part.
-    *
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * End the response processing part.
+     *
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function end_processing()
     {
         return "</resprocessing>\n";
     }
 
     /**
-    * Export the question as an IMS/QTI Item.
-    *
-    * This is a default behaviour, some classes may want to override this.
-    *
-    * @param $standalone: Boolean stating if it should be exported as a stand-alone question
-    * @return string string, the XML flow for an Item.
-    * @author Amand Tihon <amand@alrj.org>
-    */
+     * Export the question as an IMS/QTI Item.
+     *
+     * This is a default behaviour, some classes may want to override this.
+     *
+     * @param $standalone: Boolean stating if it should be exported as a stand-alone question
+     * @return string string, the XML flow for an Item.
+     * @author Amand Tihon <amand@alrj.org>
+     */
     public function export($standalone = False)
     {
         global $charset;
@@ -401,8 +401,8 @@ 
 
         if ($standalone) {
             $head = '<?xml version = "1.0" encoding = "'.$charset.'" standalone = "no"?>'."\n"
-                  . '<!DOCTYPE questestinterop SYSTEM "ims_qtiasiv2p1.dtd">'."\n"
-                  . "<questestinterop>\n";
+                    . '<!DOCTYPE questestinterop SYSTEM "ims_qtiasiv2p1.dtd">'."\n"
+                    . "<questestinterop>\n";
             $foot = "</questestinterop>\n";
         }
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -394,7 +394,7 @@
     * @return string string, the XML flow for an Item.
     * @author Amand Tihon <amand@alrj.org>
     */
-    public function export($standalone = False)
+    public function export($standalone = false)
     {
         global $charset;
         $head = $foot = "";

main/lp/openoffice_text_document.class.php

Doc Comments +3 added lines, -1 removed lines

@@ -42,7 +42,7 @@ 
     /**
      * Gets html pages and compose them into a learning path
      * @param	array	The files that will compose the generated learning path. Unused so far.
-     * @return	boolean	False if file does not exit. Nothing otherwise.
+     * @return	false|null	False if file does not exit. Nothing otherwise.
      */
     public function make_lp($files = array())
     {
@@ -100,6 +100,7 @@ 
      * Manages dir/chapter splitting
      * @param	string	Chapter header
      * @param	string	Content
+     * @param string $content
      * @return	void
      */
     public function dealPerChapter($header, $content)
@@ -191,6 +192,7 @@ 
      * Manages page splitting
      * @param	string	Page header
      * @param	string	Page body
+     * @param string $body
      * @return	void
      */
     public function dealPerPage($header, $body)

main/gradebook/lib/be/forumthreadlink.class.php

Indentation +3 added lines, -3 removed lines

@@ -121,9 +121,9 @@
     }
 
     /**
-    * Has anyone done this exercise yet ?
-    * @return boolean
-    */
+     * Has anyone done this exercise yet ?
+     * @return boolean
+     */
     public function has_results()
     {
         $table = Database::get_course_table(TABLE_FORUM_POST);

main/inc/lib/fileManage.lib.php

Doc Comments +4 added lines, -4 removed lines

@@ -39,8 +39,8 @@ 
  * Deletes a file or a directory
  *
  * @author - Hugues Peeters
- * @param  $file (String) - the path of file or directory to delete
- * @return boolean - true if the delete succeed, false otherwise.
+ * @param  string $file (String) - the path of file or directory to delete
+ * @return boolean|null - true if the delete succeed, false otherwise.
  * @see    - delete() uses check_name_exist() and removeDir() functions
  */
 function my_delete($file)
@@ -127,7 +127,7 @@ 
  * @author Hugues Peeters <peeters@ipm.ucl.ac.be>
  * @param  string $file_path complete path of the file or the directory
  * @param  string $new_file_name new name for the file or the directory
- * @return boolean true if succeed, false otherwise
+ * @return string|false true if succeed, false otherwise
  * @see rename() uses the check_name_exist() and php2phps() functions
  */
 function my_rename($file_path, $new_file_name)
@@ -174,7 +174,7 @@ 
  * @param  string $target the path of the new area
  * @param  bool $forceMove Whether to force a move or to make a copy (safer but slower) and then delete the original
  * @param	bool $moveContent In some cases (including migrations), we need to move the *content* and not the folder itself
- * @return bool true if the move succeed, false otherwise.
+ * @return boolean|null true if the move succeed, false otherwise.
  * @see move() uses check_name_exist() and copyDirTo() functions
  */
 function move($source, $target, $forceMove = true, $moveContent = false)

Indentation +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
         $file_name = basename($source);
         // move onto self illegal: mv a/b/c a/b/c or mv a/b/c a/b
         if (strcasecmp($target, dirname($source)) === 0) {
-               return false;
+                return false;
         }
         $isWindowsOS = api_is_windows_os();
         $canExec = function_exists('exec');

Braces +4 added lines, -2 removed lines

@@ -46,10 +46,12 @@
 function my_delete($file)
 {
     if (check_name_exist($file)) {
-        if (is_file($file)) { // FILE CASE
+        if (is_file($file)) {
+// FILE CASE
             unlink($file);
             return true;
-        } elseif (is_dir($file)) { // DIRECTORY CASE
+        } elseif (is_dir($file)) {
+// DIRECTORY CASE
             removeDir($file);
             return true;
         }

plugin/sepe/update.php

Braces +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  */

 require_once __DIR__.'/config.php';

 

-if (!api_is_platform_admin()) {

+if (!api_is_platform_admin()) {
     die ('You must have admin permissions to install plugins');

 }

 

plugin/sepe/src/sepe-administration-menu.php

Braces +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 $title = $plugin->get_lang('AdministratorSepe');

 $pluginPath = api_get_path(WEB_PLUGIN_PATH).'sepe/src/';

 

-if (api_is_platform_admin() && $enable) {

+if (api_is_platform_admin() && $enable) {
     $htmlText = '';

     $htmlText .= '<div class="panel panel-default">';

         $htmlText .= '<div class="panel-heading" role="tab">';

@@ -56,6 +56,6 @@ 
     $content = $tpl->fetch($listing_tpl);

     $tpl->assign('content', $content);

     $tpl->display_one_col_template();

-} else {

+} else {
     header('Location:'.api_get_path(WEB_PATH));

 }

plugin/sepe/src/formative-actions-list.php

Braces +4 added lines, -4 removed lines

@@ -10,16 +10,16 @@ 
 

 $plugin = SepePlugin::create();

 

-if (api_is_platform_admin()) {

+if (api_is_platform_admin()) {
     $templateName = $plugin->get_lang('FormativesActionsList');

     $interbreadcrumb[] = array("url" => "/plugin/sepe/src/sepe-administration-menu.php", "name" => $plugin->get_lang('MenuSepe'));

     $tpl = new Template($templateName);

     

-    if (isset($_SESSION['sepe_message_info'])) {

+    if (isset($_SESSION['sepe_message_info'])) {
         $tpl->assign('message_info', $_SESSION['sepe_message_info']);    

         unset($_SESSION['sepe_message_info']);

     }

-    if (isset($_SESSION['sepe_message_error'])) {

+    if (isset($_SESSION['sepe_message_error'])) {
         $tpl->assign('message_error', $_SESSION['sepe_message_error']);    

         unset($_SESSION['sepe_message_error']);

     }

@@ -35,6 +35,6 @@ 
     $content = $tpl->fetch($listing_tpl);

     $tpl->assign('content', $content);

     $tpl->display_one_col_template();

-} else {

+} else {
     header('Location:'.api_get_path(WEB_PATH));

 }