chamilo / chamilo-lms

main/session/add_users_to_session.php

Indentation +2 added lines, -2 removed lines

@@ -628,8 +628,8 @@
     </div>
     <form name="formulaire" method="post"
           action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if (!empty($addProcess)) {
-              echo '&add=true';
-          } ?>" <?php if ($ajax_search) {
+                echo '&add=true';
+            } ?>" <?php if ($ajax_search) {
         echo ' onsubmit="valide();"';
     } ?>>
         <?php echo '<legend>'.$tool_name.' ('.$session_info['name'].') </legend>'; ?>

main/user/add_users_to_session.php

Indentation +6 added lines, -6 removed lines

@@ -538,7 +538,7 @@ 
                 <div id="content_source">
                 <?php
                 if (!($add_type == 'multiple')) {
-                  ?>
+                    ?>
                   <input type="text" id="user_to_add" onkeyup="xajax_search_users(this.value,'single')" />
                   <div id="ajax_list_users_single"></div>
                   <?php
@@ -547,12 +547,12 @@ 
                 <div id="ajax_list_users_multiple">
                 <select id="origin_users" name="nosessionUsersList[]" multiple="multiple" size="15" class="span5">
                   <?php
-                  foreach ($nosessionUsersList as $uid => $enreg) {
-                  ?>
+                    foreach ($nosessionUsersList as $uid => $enreg) {
+                    ?>
                       <option value="<?php echo $uid; ?>" <?php if (in_array($uid, $UserList)) echo 'selected="selected"'; ?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
                   <?php
-                  }
-                  ?>
+                    }
+                    ?>
                 </select>
                 </div>
                     <input type="checkbox" onchange="checked_in_no_session(this.checked);" name="user_with_any_session" id="user_with_any_session_id">
@@ -560,7 +560,7 @@ 
                 <?php
                 }
                 unset($nosessionUsersList);
-               ?>
+                ?>
             </div>
         </div>
 

Braces +8 added lines, -2 removed lines

@@ -488,7 +488,10 @@ 
     <div class="actions">
         <?php echo $link_add_type_unique ?>&nbsp;|&nbsp;<?php echo $link_add_type_multiple ?>&nbsp;|&nbsp;<?php echo $link_add_group; ?>
     </div>
-    <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if (!empty($_GET['add'])) echo '&add=true'; ?>" style="margin:0px;" <?php if ($ajax_search) {echo ' onsubmit="valide();"'; }?>>
+    <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if (!empty($_GET['add'])) {
+    echo '&add=true';
+}
+?>" style="margin:0px;" <?php if ($ajax_search) {echo ' onsubmit="valide();"'; }?>>
     <?php echo '<legend>'.$tool_name.' ('.$session->getName().') </legend>'; ?>
     <?php
     if ($add_type === 'multiple') {
@@ -549,7 +552,10 @@ 
                   <?php
                   foreach ($nosessionUsersList as $uid => $enreg) {
                   ?>
-                      <option value="<?php echo $uid; ?>" <?php if (in_array($uid, $UserList)) echo 'selected="selected"'; ?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
+                      <option value="<?php echo $uid; ?>" <?php if (in_array($uid, $UserList)) {
+    echo 'selected="selected"';
+}
+?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
                   <?php
                   }
                   ?>

main/tracking/question_course_report.php

Indentation +107 added lines, -107 removed lines

@@ -14,20 +14,20 @@ 
 $is_allowedToTrack = $is_courseAdmin || $is_platformAdmin || $is_session_general_coach || $is_sessionAdmin;
 
 if (!$is_allowedToTrack) {
-	Display::display_header(null);
-	api_not_allowed();
-	Display::display_footer();
+    Display::display_header(null);
+    api_not_allowed();
+    Display::display_footer();
 }
 
 $export_to_xls = false;
 if (isset($_GET['export'])) {
-	$export_to_xls = true;
+    $export_to_xls = true;
 }
 
 if (api_is_platform_admin()) {
-	$global = true;
+    $global = true;
 } else {
-	$global = false;
+    $global = false;
 }
 $global = true;
 
@@ -45,14 +45,14 @@ 
 $session_id = isset($_REQUEST['session_id']) ? intval($_REQUEST['session_id']) : null;
 
 if (empty($session_id)) {
-	$temp_course_list = CourseManager::get_courses_list();
+    $temp_course_list = CourseManager::get_courses_list();
 } else {
-	$temp_course_list = SessionManager::get_course_list_by_session_id($session_id);
+    $temp_course_list = SessionManager::get_course_list_by_session_id($session_id);
 }
 
 foreach ($temp_course_list  as $temp_course_item) {
-	$course_item = api_get_course_info($temp_course_item['code']);
-	$course_select_list[$temp_course_item['code']] = $course_item['title'];
+    $course_item = api_get_course_info($temp_course_item['code']);
+    $course_select_list[$temp_course_item['code']] = $course_item['title'];
 }
 
 //Get session list
@@ -95,132 +95,132 @@ 
 $course_info = api_get_course_info($course_code);
 
 if (!empty($course_info)) {
-	$list = new LearnpathList('', $course_code);
-	$lp_list = $list->get_flat_list();
+    $list = new LearnpathList('', $course_code);
+    $lp_list = $list->get_flat_list();
 
-	$main_question_list = array();
+    $main_question_list = array();
 
-	foreach ($lp_list as $lp_id => $lp) {
+    foreach ($lp_list as $lp_id => $lp) {
         $exercise_list = Event::get_all_exercises_from_lp(
             $lp_id,
             $course_info['real_id']
         );
 
-		foreach ($exercise_list as $exercise) {
-			$my_exercise = new Exercise($course_info['real_id']);
-			$my_exercise->read($exercise['path']);
-			$question_list = $my_exercise->selectQuestionList();
-
-			$exercise_stats = Event::get_all_exercise_event_from_lp(
-				$exercise['path'],
-				$course_info['real_id'],
-				$session_id
-			);
-
-			foreach ($question_list as $question_id) {
-				$question_data = Question::read($question_id);
-				$main_question_list[$question_id] = $question_data;
-				$quantity_exercises = 0;
-				$question_result = 0;
-
-				foreach ($exercise_stats as $stats) {
-					if (!empty($stats['question_list'])) {
-						foreach ($stats['question_list'] as $my_question_stat) {
-							if ($question_id == $my_question_stat['question_id']) {
-								$question_result = $question_result + $my_question_stat['marks'];
-								$quantity_exercises++;
-							}
-						}
-					}
-				}
-
-				if (!empty($quantity_exercises)) {
-					// Score % average
-					$main_question_list[$question_id]->results = ($question_result / ($quantity_exercises));
-				} else {
-					$main_question_list[$question_id]->results = 0;
-				}
-
-				$main_question_list[$question_id]->quantity = $quantity_exercises;
-			}
-		}
-	}
+        foreach ($exercise_list as $exercise) {
+            $my_exercise = new Exercise($course_info['real_id']);
+            $my_exercise->read($exercise['path']);
+            $question_list = $my_exercise->selectQuestionList();
+
+            $exercise_stats = Event::get_all_exercise_event_from_lp(
+                $exercise['path'],
+                $course_info['real_id'],
+                $session_id
+            );
+
+            foreach ($question_list as $question_id) {
+                $question_data = Question::read($question_id);
+                $main_question_list[$question_id] = $question_data;
+                $quantity_exercises = 0;
+                $question_result = 0;
+
+                foreach ($exercise_stats as $stats) {
+                    if (!empty($stats['question_list'])) {
+                        foreach ($stats['question_list'] as $my_question_stat) {
+                            if ($question_id == $my_question_stat['question_id']) {
+                                $question_result = $question_result + $my_question_stat['marks'];
+                                $quantity_exercises++;
+                            }
+                        }
+                    }
+                }
+
+                if (!empty($quantity_exercises)) {
+                    // Score % average
+                    $main_question_list[$question_id]->results = ($question_result / ($quantity_exercises));
+                } else {
+                    $main_question_list[$question_id]->results = 0;
+                }
+
+                $main_question_list[$question_id]->quantity = $quantity_exercises;
+            }
+        }
+    }
 }
 
 if (!$export_to_xls) {
-	Display::display_header(get_lang("MySpace"));
-	echo '<div class="actions">';
-	if ($global) {
-		echo MySpace::getTopMenu();
-	} else {
-		echo '<div style="float:left; clear:left">
+    Display::display_header(get_lang("MySpace"));
+    echo '<div class="actions">';
+    if ($global) {
+        echo MySpace::getTopMenu();
+    } else {
+        echo '<div style="float:left; clear:left">
 				<a href="courseLog.php?'.api_get_cidreq().'&studentlist=true">'.
                     get_lang('StudentsTracking').'</a>&nbsp;|
 				<a href="courseLog.php?'.api_get_cidreq().'&studentlist=false">'.
                     get_lang('CourseTracking').'</a>&nbsp;';
-		echo '</div>';
-	}
-	echo '</div>';
+        echo '</div>';
+    }
+    echo '</div>';
 
-	if (api_is_platform_admin()) {
-		echo MySpace::getAdminActions();
-	}
-	echo '<br />';
-	echo '<h2>'.get_lang('LPQuestionListResults').'</h2>';
+    if (api_is_platform_admin()) {
+        echo MySpace::getAdminActions();
+    }
+    echo '<br />';
+    echo '<h2>'.get_lang('LPQuestionListResults').'</h2>';
 
-	$form->display();
+    $form->display();
 
-	if (empty($course_code)) {
-		echo Display::return_message(get_lang('PleaseSelectACourse'), 'warning');
-	}
+    if (empty($course_code)) {
+        echo Display::return_message(get_lang('PleaseSelectACourse'), 'warning');
+    }
 }
 
 $course_average = array();
 $counter = 0;
 
 if (!empty($main_question_list) && is_array($main_question_list)) {
-	$html_result .= '<table  class="data_table">';
-	$html_result .= '<tr><th>'.get_lang('Question').
+    $html_result .= '<table  class="data_table">';
+    $html_result .= '<tr><th>'.get_lang('Question').
                     Display::return_icon('info3.gif', get_lang('QuestionsAreTakenFromLPExercises'), array('align' => 'absmiddle', 'hspace' => '3px')).'</th>';
-	$html_result .= '<th>'.$course_info['visual_code'].' '.get_lang('AverageScore').Display::return_icon('info3.gif', get_lang('AllStudentsAttemptsAreConsidered'), array('align' => 'absmiddle', 'hspace' => '3px')).' </th>';
-	$html_result .= '<th>'.get_lang('Quantity').'</th>';
-
-	foreach ($main_question_list as $question) {
-		$total_student = 0;
-		$counter++;
-		$s_css_class = 'row_even';
-		if ($counter % 2 == 0) {
-			$s_css_class = 'row_odd';
-		}
-		$html_result .= "<tr class='$s_css_class'>
+    $html_result .= '<th>'.$course_info['visual_code'].' '.get_lang('AverageScore').Display::return_icon('info3.gif', get_lang('AllStudentsAttemptsAreConsidered'), array('align' => 'absmiddle', 'hspace' => '3px')).' </th>';
+    $html_result .= '<th>'.get_lang('Quantity').'</th>';
+
+    foreach ($main_question_list as $question) {
+        $total_student = 0;
+        $counter++;
+        $s_css_class = 'row_even';
+        if ($counter % 2 == 0) {
+            $s_css_class = 'row_odd';
+        }
+        $html_result .= "<tr class='$s_css_class'>
 							<td >";
-		$question_title = trim($question->question);
-		if (empty($question_title)) {
-			$html_result .= get_lang('Untitled').' '.get_lang('Question').' #'.$question->id;
-		} else {
-			$html_result .= $question->question;
-		}
-
-		$html_result .= "</td>";
-		$html_result .= "<td>";
-		$html_result .= round($question->results, 2).' / '.$question->weighting;
-		$html_result .= "</td>";
-
-		$html_result .= "<td>";
-		$html_result .= $question->quantity;
-		$html_result .= "</td>";
-	}
-
-	$html_result .= "</tr>";
-	$html_result .= '</table>';
+        $question_title = trim($question->question);
+        if (empty($question_title)) {
+            $html_result .= get_lang('Untitled').' '.get_lang('Question').' #'.$question->id;
+        } else {
+            $html_result .= $question->question;
+        }
+
+        $html_result .= "</td>";
+        $html_result .= "<td>";
+        $html_result .= round($question->results, 2).' / '.$question->weighting;
+        $html_result .= "</td>";
+
+        $html_result .= "<td>";
+        $html_result .= $question->quantity;
+        $html_result .= "</td>";
+    }
+
+    $html_result .= "</tr>";
+    $html_result .= '</table>';
 } else {
-	if (!empty($course_code)) {
-		echo Display::return_message(get_lang('NoResults'), 'warning');
-	}
+    if (!empty($course_code)) {
+        echo Display::return_message(get_lang('NoResults'), 'warning');
+    }
 }
 
 if (!$export_to_xls) {
-	echo $html_result;
+    echo $html_result;
 }
 
 Display::display_footer();

main/session/add_courses_to_session.php

Braces +8 added lines, -2 removed lines

@@ -205,7 +205,10 @@ 
 
 unset($Courses);
 ?>
-<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $sessionId; ?><?php if (!empty($_GET['add'])) echo '&add=true'; ?>" style="margin:0px;" <?php if ($ajax_search) {echo ' onsubmit="valide();"'; }?>>
+<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $sessionId; ?><?php if (!empty($_GET['add'])) {
+    echo '&add=true';
+}
+?>" style="margin:0px;" <?php if ($ajax_search) {echo ' onsubmit="valide();"'; }?>>
     <legend><?php echo $tool_name.' ('.$session_info['name'].')'; ?></legend>
     <input type="hidden" name="formSent" value="1" />
     <div id="multiple-add-session" class="row">
@@ -222,7 +225,10 @@ 
                 <div id="ajax_list_courses_multiple">
                     <select id="origin" name="NoSessionCoursesList[]" multiple="multiple" size="20" class="form-control">
                         <?php foreach ($nosessionCourses as $enreg) { ?>
-                            <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['title'].' ('.$enreg['visual_code'].')', ENT_QUOTES).'"'; if (in_array($enreg['code'], $CourseList)) echo 'selected="selected"'; ?>>
+                            <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['title'].' ('.$enreg['visual_code'].')', ENT_QUOTES).'"'; if (in_array($enreg['code'], $CourseList)) {
+    echo 'selected="selected"';
+}
+?>>
                                 <?php echo $enreg['title'].' ('.$enreg['visual_code'].')'; ?>
                             </option>
                         <?php } ?>

main/inc/lib/sessionmanager.lib.php

Spacing +1 added lines, -1 removed lines

@@ -1944,7 +1944,7 @@
         foreach ($user_list as $enreg_user) {
             $isUserSubscribed = self::isUserSubscribedAsStudent($id_session, $enreg_user);
             if ($isUserSubscribed === false) {
-                $enreg_user = (int)$enreg_user;
+                $enreg_user = (int) $enreg_user;
                 $nbr_users++;
                 $sql = "INSERT IGNORE INTO $tbl_session_rel_user (relation_type, session_id, user_id, registered_at)
                         VALUES (0, $id_session, $enreg_user, '".api_get_utc_datetime()."')";

Doc Comments +21 added lines, -17 removed lines

@@ -1770,7 +1770,7 @@ 
      * @param array $user_list
      * @param int $session_visibility
      * @param bool $empty_users
-     * @return bool
+     * @return false|null
      */
     public static function subscribe_users_to_session(
         $id_session,
@@ -2115,7 +2115,7 @@ 
      * @param array $courseInfo
      * @param int $status
      * @param bool $updateTotal
-     * @return bool
+     * @return false|null
      */
     public static function removeUsersFromCourseSession(
         $userList,
@@ -2181,7 +2181,7 @@ 
      * @param string $course_code
      * @param int $session_visibility
      * @param bool $removeUsersNotInList
-     * @return bool
+     * @return false|null
      */
     public static function subscribe_users_to_session_course(
         $user_list,
@@ -2364,7 +2364,7 @@ 
      * @param   bool $removeExistingCoursesWithUsers Whether to unsubscribe
      * existing courses and users (true, default) or not (false)
      * @param bool $copyEvaluation from base course to session course
-     * @return    void    Nothing, or false on error
+     * @return    false|null    Nothing, or false on error
      * */
     public static function add_courses_to_session(
         $sessionId,
@@ -2673,7 +2673,7 @@ 
      * @param int $fieldType Field's type
      * @param string $displayText Field's language var name
      * @param string $default Field's default value
-     * @return int     new extra field id
+     * @return boolean     new extra field id
      */
     public static function create_session_extra_field(
         $variable,
@@ -2767,7 +2767,7 @@ 
      * @param integer        year_end
      * @param integer        month_end
      * @param integer        day_end
-     * @return int session ID
+     * @return string|false session ID
      * */
     public static function create_category_session(
         $sname,
@@ -2843,7 +2843,7 @@ 
      * @param integer        year_end
      * @param integer        month_end
      * @param integer        day_end
-     * @return bool
+     * @return string|boolean
      * The parameter id is a primary key
      * */
     public static function edit_category_session(
@@ -2907,7 +2907,7 @@ 
      * @param	array	id_checked
      * @param	bool	include delete session
      * @param	bool	optional, true if the function is called by a webservice, false otherwise.
-     * @return	void	Nothing, or false on error
+     * @return	boolean	Nothing, or false on error
      * The parameters is a array to delete sessions
      * */
     public static function delete_session_category($id_checked, $delete_session = false, $from_ws = false)
@@ -3677,8 +3677,8 @@ 
     /**
      * Gets the list of courses by session filtered by access_url
      *
-     * @param $userId
-     * @param $sessionId
+     * @param integer $userId
+     * @param null|integer $sessionId
      * @param null $from
      * @param null $limit
      * @param null $column
@@ -3802,6 +3802,7 @@ 
     /**
      * Gets the count of courses by session filtered by access_url
      * @param int session id
+     * @param integer $session_id
      * @return array list of courses
      */
     public static function getCourseCountBySessionId($session_id, $keyword = null)
@@ -4056,6 +4057,7 @@ 
      * Updates a session status
      * @param	int 	session id
      * @param	int 	status
+     * @param integer $status
      */
     public static function set_session_status($session_id, $status)
     {
@@ -4248,6 +4250,7 @@ 
     /**
      * Get the number of sessions
      * @param  int ID of the URL we want to filter on (optional)
+     * @param integer $access_url_id
      * @return int Number of sessions
      */
     public static function count_sessions($access_url_id = null)
@@ -4268,7 +4271,7 @@ 
      * Protect a session to be edited.
      * @param int $id
      * @param bool $checkSession
-     * @return mixed | bool true if pass the check, api_not_allowed otherwise
+     * @return boolean|null | bool true if pass the check, api_not_allowed otherwise
      */
     public static function protectSession($id, $checkSession = true)
     {
@@ -4376,7 +4379,7 @@ 
 
     /**
      * @param $id
-     * @return bool
+     * @return null|boolean
      */
     public static function protect_teacher_session_edit($id)
     {
@@ -4453,7 +4456,7 @@ 
      *  true: if the session exists it will be updated.
      *  false: if session exists a new session will be created adding a counter session1, session2, etc
      * @param int $defaultUserId
-     * @param mixed $logger
+     * @param Logger $logger
      * @param array $extraFields convert a file row to an extra field. Example in CSV file there's a SessionID then it will
      * converted to extra_external_session_id if you set this: array('SessionId' => 'extra_external_session_id')
      * @param string $extraFieldId
@@ -5992,7 +5995,7 @@ 
     /**
      * Get the list of course tools that have to be dealt with in case of
      * registering any course to a session
-     * @return array The list of tools to be dealt with (literal names)
+     * @return string[] The list of tools to be dealt with (literal names)
      */
     public static function getCourseToolToBeManaged()
     {
@@ -6006,7 +6009,7 @@ 
      * Calls the methods bound to each tool when a course is registered into a session
      * @param int $sessionId
      * @param int $courseId
-     * @return void
+     * @return boolean|null
      */
     public static function installCourse($sessionId, $courseId)
     {
@@ -6664,6 +6667,7 @@ 
      * @param int $categoryId The internal ID of the session category
      * @param string $target Value to search for in the session field values
      * @param array $extraFields A list of fields to be scanned and returned
+     * @param DateTime $publicationDate
      * @return mixed
      */
     public static function getShortSessionListAndExtraByCategory(
@@ -8139,7 +8143,7 @@ 
     /**
      * Get link to the admin page for this session
      * @param   int $id Session ID
-     * @return mixed    URL to the admin page to manage the session, or false on error
+     * @return false|string    URL to the admin page to manage the session, or false on error
      */
     public static function getAdminPath($id)
     {
@@ -8156,7 +8160,7 @@ 
      * If a course is provided, build the link to the course
      * @param   int $id Session ID
      * @param   int $courseId Course ID (optional) in case the link has to send straight to the course
-     * @return mixed    URL to the page to use the session, or false on error
+     * @return false|string    URL to the page to use the session, or false on error
      */
     public static function getPath($id, $courseId = 0)
     {

Indentation +11 added lines, -11 removed lines

@@ -581,7 +581,7 @@ 
                         true
                     );
                 }
-                 $url = api_get_path(WEB_CODE_PATH)."session/resume_session.php?id_session=".$session['id'];
+                    $url = api_get_path(WEB_CODE_PATH)."session/resume_session.php?id_session=".$session['id'];
                 if (api_is_drh()) {
                     $url = api_get_path(WEB_CODE_PATH)."session/about.php?session_id=".$session['id'];
                 }
@@ -2063,16 +2063,16 @@ 
         return $existingUsers;
     }
 
-     /**
-     * Returns user list of the current users subscribed in the course-session
-     * @param array $sessionList
-     * @param array $courseList
-     * @param int $status
-     * @param int $start
-     * @param int $limit
-     *
-     * @return array
-     */
+        /**
+         * Returns user list of the current users subscribed in the course-session
+         * @param array $sessionList
+         * @param array $courseList
+         * @param int $status
+         * @param int $start
+         * @param int $limit
+         *
+         * @return array
+         */
     public static function getUsersByCourseAndSessionList(
         $sessionList,
         $courseList,

Braces +6 added lines, -3 removed lines

@@ -4691,7 +4691,8 @@ 
                     if ($debug) {
                         if ($session_id) {
                             foreach ($enreg as $key => $value) {
-                                if (substr($key, 0, 6) == 'extra_') { //an extra field
+                                if (substr($key, 0, 6) == 'extra_') {
+//an extra field
                                     self::update_session_extra_field_value($session_id, substr($key, 6), $value);
                                 }
                             }
@@ -4738,7 +4739,8 @@ 
 
                         if ($session_id) {
                             foreach ($enreg as $key => $value) {
-                                if (substr($key, 0, 6) == 'extra_') { //an extra field
+                                if (substr($key, 0, 6) == 'extra_') {
+//an extra field
                                     self::update_session_extra_field_value($session_id, substr($key, 6), $value);
                                 }
                             }
@@ -4836,7 +4838,8 @@ 
                             Database::update($tbl_session, $params, array('id = ?' => $session_id));
 
                             foreach ($enreg as $key => $value) {
-                                if (substr($key, 0, 6) == 'extra_') { //an extra field
+                                if (substr($key, 0, 6) == 'extra_') {
+//an extra field
                                     self::update_session_extra_field_value($session_id, substr($key, 6), $value);
                                 }
                             }

Upper-Lower-Casing +31 added lines, -31 removed lines

@@ -238,7 +238,7 @@ 
                 $duration = intval($duration);
 
                 if (!empty($duration)) {
-                    $sql = "UPDATE $tbl_session SET
+                    $sql = "update $tbl_session SET
                         access_start_date = NULL,
                         access_end_date = NULL,
                         display_start_date = NULL,
@@ -249,7 +249,7 @@ 
                     WHERE id = $session_id";
                     Database::query($sql);
                 } else {
-                    $sql = "UPDATE $tbl_session
+                    $sql = "update $tbl_session
                         SET duration = 0
                         WHERE id = $session_id";
                     Database::query($sql);
@@ -1727,7 +1727,7 @@ 
         Database::query("DELETE FROM $trackCourseAccess WHERE session_id IN($id_checked)");
         Database::query("DELETE FROM $trackAccess WHERE access_session_id IN($id_checked)");
 
-        $sql = "UPDATE $ticket SET session_id = NULL WHERE session_id IN ($id_checked)";
+        $sql = "update $ticket SET session_id = NULL WHERE session_id IN ($id_checked)";
         Database::query($sql);
 
         $sql = "DELETE FROM $tbl_session WHERE id IN ($id_checked)";
@@ -1762,7 +1762,7 @@ 
     {
         $tbl_session = Database::get_main_table(TABLE_MAIN_SESSION);
         $id = intval($id);
-        $sql = "UPDATE $tbl_session 
+        $sql = "update $tbl_session 
                 SET promotion_id = 0
                 WHERE promotion_id = $id";
         if (Database::query($sql)) {
@@ -1984,7 +1984,7 @@ 
             $rs = Database::query($sql);
             list($nbr_users) = Database::fetch_array($rs);
             // update the session-course relation to add the users total
-            $sql = "UPDATE $tbl_session_rel_course SET nbr_users = $nbr_users
+            $sql = "update $tbl_session_rel_course SET nbr_users = $nbr_users
                     WHERE session_id = $id_session AND c_id = $courseId";
             Database::query($sql);
         }
@@ -2013,11 +2013,11 @@ 
         $nbr_users = count($user_list);
         if ($empty_users) {
             // update number of users in the session
-            $sql = "UPDATE $tbl_session SET nbr_users= $nbr_users
+            $sql = "update $tbl_session SET nbr_users= $nbr_users
                     WHERE id = $id_session ";
             Database::query($sql);
         } else {
-            $sql = "UPDATE $tbl_session SET nbr_users = nbr_users + $nbr_users
+            $sql = "update $tbl_session SET nbr_users = nbr_users + $nbr_users
                     WHERE id = $id_session";
             Database::query($sql);
         }
@@ -2109,7 +2109,7 @@ 
         if (!is_null($start) && !is_null($limit)) {
             $start = (int) $start;
             $limit = (int) $limit;
-            $sql .= "LIMIT $start, $limit";
+            $sql .= "limit $start, $limit";
         }
         $result = Database::query($sql);
         $existingUsers = array();
@@ -2176,7 +2176,7 @@ 
             list($userCount) = Database::fetch_array($result);
 
             // update the session-course relation to add the users total
-            $sql = "UPDATE $tableSessionCourse
+            $sql = "update $tableSessionCourse
                     SET nbr_users = $userCount
                     WHERE
                         session_id = $sessionId AND
@@ -2283,7 +2283,7 @@ 
                         VALUES ($session_id, $enreg_user, '".api_get_utc_datetime()."')";
                 Database::query($sql);
 
-                $sql = "UPDATE $tbl_session SET nbr_users = nbr_users + 1
+                $sql = "update $tbl_session SET nbr_users = nbr_users + 1
                         WHERE id = $session_id ";
                 Database::query($sql);
             }
@@ -2296,7 +2296,7 @@ 
         $rs = Database::query($sql);
         list($nbr_users) = Database::fetch_array($rs);
         // update the session-course relation to add the users total
-        $sql = "UPDATE $tbl_session_rel_course
+        $sql = "update $tbl_session_rel_course
                 SET nbr_users = $nbr_users
                 WHERE session_id = $session_id AND c_id = $courseId";
         Database::query($sql);
@@ -2328,7 +2328,7 @@ 
         $return = Database::affected_rows($result);
 
         // Update number of users
-        $sql = "UPDATE $tbl_session
+        $sql = "update $tbl_session
                 SET nbr_users = nbr_users - $return
                 WHERE id = $session_id ";
         Database::query($sql);
@@ -2356,7 +2356,7 @@ 
 
                 if (Database::affected_rows($result)) {
                     // Update number of users in this relation
-                    $sql = "UPDATE $tbl_session_rel_course SET 
+                    $sql = "update $tbl_session_rel_course SET 
                             nbr_users = nbr_users - 1
                             WHERE session_id = $session_id AND c_id = $courseId";
                     Database::query($sql);
@@ -2611,14 +2611,14 @@ 
                         $nbr_users++;
                     }
                 }
-                $sql = "UPDATE $tbl_session_rel_course
+                $sql = "update $tbl_session_rel_course
                         SET nbr_users = $nbr_users
                         WHERE session_id = $sessionId AND c_id = $courseId";
                 Database::query($sql);
             }
         }
 
-        $sql = "UPDATE $tbl_session
+        $sql = "update $tbl_session
                 SET nbr_courses = $nbr_courses
                 WHERE id = $sessionId";
         Database::query($sql);
@@ -2670,7 +2670,7 @@ 
 
         if ($nb_affected > 0) {
             // Update number of courses in the session
-            $sql = "UPDATE $tbl_session SET nbr_courses= nbr_courses - $nb_affected
+            $sql = "update $tbl_session SET nbr_courses= nbr_courses - $nb_affected
                     WHERE id = $session_id";
             Database::query($sql);
             return true;
@@ -2896,14 +2896,14 @@ 
             return $msg;
         }
         if ($date_end <> null) {
-            $sql = "UPDATE $tbl_session_category
+            $sql = "update $tbl_session_category
                     SET
                         name = '".Database::escape_string($name)."',
                         date_start = '$date_start' ,
                         date_end = '$date_end'
                     WHERE id= $id";
         } else {
-            $sql = "UPDATE $tbl_session_category SET
+            $sql = "update $tbl_session_category SET
                         name = '".Database::escape_string($name)."',
                         date_start = '$date_start',
                         date_end = NULL
@@ -2933,7 +2933,7 @@ 
         }
 
         //Setting session_category_id to 0
-        $sql = "UPDATE $tbl_session SET session_category_id = NULL
+        $sql = "update $tbl_session SET session_category_id = NULL
                 WHERE session_category_id IN (".$id_checked.")";
         Database::query($sql);
 
@@ -3046,7 +3046,7 @@ 
         if (!is_null($from) && !is_null($to)) {
             $to = intval($to);
             $from = intval($from);
-            $sql_query .= "LIMIT $from, $to";
+            $sql_query .= "limit $from, $to";
         }
 
         $sql_result = Database::query($sql_query);
@@ -3153,7 +3153,7 @@ 
                 // The user is already subscribed to the session. Change the
                 // record so the user is NOT a coach for this course anymore
                 // and then exit
-                $sql = "UPDATE $tblSessionRelCourseRelUser
+                $sql = "update $tblSessionRelCourseRelUser
                         SET status = 0
                         WHERE
                             session_id = $sessionId AND
@@ -3188,7 +3188,7 @@ 
 
         // Then update or insert.
         if (Database::num_rows($rs_check) > 0) {
-            $sql = "UPDATE $tblSessionRelCourseRelUser SET status = 2
+            $sql = "update $tblSessionRelCourseRelUser SET status = 2
                     WHERE
                         session_id = $sessionId AND
                         c_id = $courseId AND
@@ -3625,7 +3625,7 @@ 
         }
 
         // select the courses
-        $sql = "SELECT $sqlSelect
+        $sql = "select $sqlSelect
                 FROM $tbl_course c
                 INNER JOIN $tbl_session_rel_course src
                 ON (c.id = src.c_id)
@@ -3880,7 +3880,7 @@ 
             $selectedField = 'count(1) AS count';
         }
 
-        $sql = "SELECT $selectedField
+        $sql = "select $selectedField
                 FROM $tbl_user u
                 INNER JOIN $tbl_session_rel_user su
                 ON u.user_id = su.user_id AND
@@ -4195,7 +4195,7 @@ 
                                 $quiz_table = Database::get_course_table(TABLE_QUIZ_TEST);
                                 $course_id = $course_info['real_id'];
                                 //@todo check this query
-                                $sql = "UPDATE $quiz_table SET active = 0
+                                $sql = "update $quiz_table SET active = 0
                                         WHERE c_id = $course_id AND session_id = $sid";
                                 Database::query($sql);
                             }
@@ -4803,7 +4803,7 @@ 
                             $session_id = $sessionId;
                             if (!empty($enreg['SessionName'])) {
                                 $sessionName = Database::escape_string($enreg['SessionName']);
-                                $sql = "UPDATE $tbl_session SET name = '$sessionName' WHERE id = $session_id";
+                                $sql = "update $tbl_session SET name = '$sessionName' WHERE id = $session_id";
                                 Database::query($sql);
                             }
                         } else {
@@ -5341,7 +5341,7 @@ 
                 }
                 $access_url_id = api_get_current_access_url_id();
                 UrlManager::add_session_to_url($session_id, $access_url_id);
-                $sql = "UPDATE $tbl_session SET nbr_users = '$user_counter', nbr_courses = '$course_counter' 
+                $sql = "update $tbl_session SET nbr_users = '$user_counter', nbr_courses = '$course_counter' 
                         WHERE id = '$session_id'";
                 Database::query($sql);
             }
@@ -5521,7 +5521,7 @@ 
         if (isset($from) && isset($numberItems)) {
             $from = intval($from);
             $numberItems = intval($numberItems);
-            $limitCondition = "LIMIT $from, $numberItems";
+            $limitCondition = "limit $from, $numberItems";
         }
 
         $urlId = api_get_current_access_url_id();
@@ -6272,7 +6272,7 @@ 
             }
             $position[$course['code']] = $course['position'];
             // Saving current order.
-            $sql = "UPDATE $table SET position = $count
+            $sql = "update $table SET position = $count
                     WHERE session_id = $sessionId AND c_id = '".$course['real_id']."'";
             Database::query($sql);
             $count++;
@@ -6305,11 +6305,11 @@ 
             }
         }
 
-        $sql1 = "UPDATE $table SET position = '".intval($nextOrder)."'
+        $sql1 = "update $table SET position = '".intval($nextOrder)."'
                  WHERE session_id = $sessionId AND c_id =  $thisCourseCode";
         Database::query($sql1);
 
-        $sql2 = "UPDATE $table SET position = '".intval($thisOrder)."'
+        $sql2 = "update $table SET position = '".intval($thisOrder)."'
                  WHERE session_id = $sessionId AND c_id = $nextId";
         Database::query($sql2);
 

main/inc/lib/ScheduledAnnouncement.php

Doc Comments +1 added lines, -1 removed lines

@@ -312,7 +312,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getTags()
     {

main/session/scheduled_announcement.php

Switch Indentation +52 added lines, -52 removed lines

@@ -43,26 +43,26 @@ 
 }
 
 switch ($action) {
-    case 'run':
-        $messagesSent = $object->sendPendingMessages();
+        case 'run':
+            $messagesSent = $object->sendPendingMessages();
+
+            Display::addFlash(
+                Display::return_message(
+                    get_lang('MessageSent').': '.$messagesSent,
+                    'confirmation'
+                )
+            );
+            $content = $object->getGrid($sessionId);
 
-        Display::addFlash(
-            Display::return_message(
-                get_lang('MessageSent').': '.$messagesSent,
-                'confirmation'
-            )
-        );
-        $content = $object->getGrid($sessionId);
+            break;
+        case 'add':
+            $url  = api_get_self().'?action='.Security::remove_XSS($_GET['action']).'&session_id='.$sessionId;
+            $form = $object->returnForm($url, 'add', $sessionInfo);
 
-        break;
-    case 'add':
-        $url  = api_get_self().'?action='.Security::remove_XSS($_GET['action']).'&session_id='.$sessionId;
-        $form = $object->returnForm($url, 'add', $sessionInfo);
-
-        // The validation or display
-        if ($form->validate()) {
-            $values = $form->getSubmitValues();
-            switch ($values['type']) {
+            // The validation or display
+            if ($form->validate()) {
+                $values = $form->getSubmitValues();
+                switch ($values['type']) {
                 case 'base_date':
                     $numberDays = (int) $values['days'];
                     switch ($values['base_date']) {
@@ -73,20 +73,20 @@ 
                             $baseDate = new DateTime($sessionInfo['access_end_date']);
                             break;
                     }
-                    $interval = new DateInterval('P'.$numberDays.'D');
-                    switch ($values['moment_type']) {
+                        $interval = new DateInterval('P'.$numberDays.'D');
+                        switch ($values['moment_type']) {
                         case 'after':
                             $newDate = $baseDate->add($interval);
                             break;
                         case 'before':
                             $newDate = $baseDate->sub($interval);
                             break;
-                    }
+                        }
                     $values['date'] = $newDate->format('Y-m-d h:i:s');
                     break;
-                case 'specific_date':
-                    $values['date'] = api_get_utc_datetime($values['date']);
-                    break;
+                    case 'specific_date':
+                        $values['date'] = api_get_utc_datetime($values['date']);
+                        break;
             }
 
             $res = $object->save($values);
@@ -110,34 +110,34 @@ 
             $content .= $form->returnForm();
         }
         break;
-    case 'edit':
-        // Action handling: Editing
-        $url  = api_get_self().'?action='.Security::remove_XSS($_GET['action']).'&id='.intval($_GET['id']).'&session_id='.$sessionId;
-        $form = $object->returnSimpleForm($url, 'edit', $sessionInfo);
-        if ($form->validate()) {
-            $values = $form->getSubmitValues();
-            $values['id'] = $id;
-            $values['sent'] = isset($values['sent']) ? 1 : '';
-            $values['date'] = api_get_utc_datetime($values['date']);
-            $res = $object->update($values);
-
-            Display::addFlash(Display::return_message(
-                get_lang('Updated'),
-                'confirmation'
-            ));
-        }
-        $item = $object->get($id);
-        $item['date'] = api_get_local_time($item['date']);
-        $form->setDefaults($item);
-        $content = $form->returnForm();
-        break;
-    case 'delete':
-        $object->delete($_GET['id']);
-        $content = $object->getGrid($sessionId);
-        break;
-    default:
-        $content = $object->getGrid($sessionId);
-        break;
+        case 'edit':
+            // Action handling: Editing
+            $url  = api_get_self().'?action='.Security::remove_XSS($_GET['action']).'&id='.intval($_GET['id']).'&session_id='.$sessionId;
+            $form = $object->returnSimpleForm($url, 'edit', $sessionInfo);
+            if ($form->validate()) {
+                $values = $form->getSubmitValues();
+                $values['id'] = $id;
+                $values['sent'] = isset($values['sent']) ? 1 : '';
+                $values['date'] = api_get_utc_datetime($values['date']);
+                $res = $object->update($values);
+
+                Display::addFlash(Display::return_message(
+                    get_lang('Updated'),
+                    'confirmation'
+                ));
+            }
+            $item = $object->get($id);
+            $item['date'] = api_get_local_time($item['date']);
+            $form->setDefaults($item);
+            $content = $form->returnForm();
+            break;
+        case 'delete':
+            $object->delete($_GET['id']);
+            $content = $object->getGrid($sessionId);
+            break;
+        default:
+            $content = $object->getGrid($sessionId);
+            break;
 }
 
 $url = api_get_path(WEB_AJAX_PATH).'model.ajax.php?a=get_programmed_announcements&session_id='.$sessionId;

main/lp/aiccItem.class.php

Doc Comments +1 added lines

@@ -34,6 +34,7 @@
      * object from database records or from the array given as second parameter
      * @param	string	Type of construction needed ('db' or 'config', default = 'config')
      * @param	mixed	Depending on the type given, DB id for the lp_item or parameters array
+     * @param integer $course_id
      */
     public function __construct($type = 'config', $params = array(), $course_id = null)
     {

main/forum/newthread.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
         });
     });
     </script>
-JS;
+js;
 
 $form = show_add_post_form(
     $current_forum,