chamilo / chamilo-lms

main/webservices/user_import/import.lib.php

Doc Comments +3 added lines, -1 removed lines

@@ -1,6 +1,7 @@ 
 <?php
 /**
  * Validates imported data.
+ * @param Ddeboer\DataImport\Reader\CsvReader $users
  */
 function validate_data($users)
 {
@@ -85,6 +86,7 @@ 
 
 /**
  * Save the imported data
+ * @param Ddeboer\DataImport\Reader\CsvReader $users
  */
 function save_data($users)
 {
@@ -143,7 +145,7 @@ 
 /**
  * Reads the CSV-file.
  * @param string $file Path to the CSV-file
- * @return array All user information read from the file
+ * @return Ddeboer\DataImport\Reader\CsvReader All user information read from the file
  */
 function parse_csv_data($file)
 {

src/Chamilo/ThemeBundle/EventListener/SidebarSetupMenuDemoListener.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
         return $this->activateByRoute($request->get('_route'), $rootItems);
     }
 
+    /**
+     * @param MenuItemModel[] $items
+     */
     protected function activateByRoute($route, $items)
     {
         foreach ($items as $item) { /** @var $item MenuItemModel */

main/inc/lib/access_url_edit_courses_to_url_functions.lib.php

Indentation +6 added lines, -6 removed lines

@@ -38,17 +38,17 @@
             $needle = Database::escape_string($needle);
             // search courses where username or firstname or lastname begins likes $needle
             $sql = 'SELECT code, title FROM '.$tbl_course.' u '.
-                   ' WHERE (title LIKE "'.$needle.'%" '.
-                   ' OR code LIKE "'.$needle.'%" '.
-                   ' ) '.
-                   ' ORDER BY title, code '.
-                   ' LIMIT 11';
+                    ' WHERE (title LIKE "'.$needle.'%" '.
+                    ' OR code LIKE "'.$needle.'%" '.
+                    ' ) '.
+                    ' ORDER BY title, code '.
+                    ' LIMIT 11';
             $rs = Database::query($sql);
             $i = 0;
             while ($course = Database::fetch_array($rs)) {
                 $i++;
                 if ($i <= 10) {
-                     $return .= '<a href="javascript: void(0);" onclick="javascript: add_user_to_url(\''.addslashes($course['code']).'\',\''.addslashes($course['title']).' ('.addslashes($course['code']).')'.'\')">'.$course['title'].' ('.$course['code'].')</a><br />';
+                        $return .= '<a href="javascript: void(0);" onclick="javascript: add_user_to_url(\''.addslashes($course['code']).'\',\''.addslashes($course['title']).' ('.addslashes($course['code']).')'.'\')">'.$course['title'].' ('.$course['code'].')</a><br />';
                 } else {
                     $return .= '...<br />';
                 }

main/install/install.lib.php

Indentation +2 added lines, -2 removed lines

@@ -1756,7 +1756,7 @@ 
         $html .= '<label class="checkbox-inline">
                         <input type="radio" name="allowSelfReg" value="false" id="allowSelfReg0" '. ($allowSelfReg == 'false' ? '' : 'checked="checked" ').' /> '.get_lang('No').'
                     </label>';
-         $html .= '<label class="checkbox-inline">
+            $html .= '<label class="checkbox-inline">
                     <input type="radio" name="allowSelfReg" value="approval" id="allowSelfReg2" '. ($allowSelfReg == 'approval' ? '' : 'checked="checked" ').' /> '.get_lang('AfterApproval').'
                 </label>';
         $html .= '</div>';
@@ -1790,7 +1790,7 @@ 
     </div>';
 
     echo panel($html, get_lang('Platform'), 'platform');
- ?>
+    ?>
     <div class='form-group'>
         <div class="col-sm-6">
             <button type="submit" class="btn btn-default pull-right" name="step3" value="&lt; <?php echo get_lang('Previous'); ?>" ><em class="fa fa-backward"> </em> <?php echo get_lang('Previous'); ?></button>

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -1880,7 +1880,7 @@ 
     $access_url_locked_settings = api_get_locked_settings();
     $table = Database::get_main_table(TABLE_MAIN_SETTINGS_CURRENT);
     foreach ($access_url_locked_settings as $setting) {
-        $sql = "UPDATE $table SET access_url_locked = 1 WHERE variable  = '$setting'";
+        $sql = "update $table SET access_url_locked = 1 WHERE variable  = '$setting'";
         Database::query($sql);
     }
 }
@@ -1894,11 +1894,11 @@ 
     $permissions_for_new_directories = isset($_SESSION['permissions_for_new_directories']) ? $_SESSION['permissions_for_new_directories'] : 0770;
     $permissions_for_new_files = isset($_SESSION['permissions_for_new_files']) ? $_SESSION['permissions_for_new_files'] : 0660;
     // use decoct() to store as string
-    $sql = "UPDATE $table SET selected_value = '0".decoct($permissions_for_new_directories)."'
+    $sql = "update $table SET selected_value = '0".decoct($permissions_for_new_directories)."'
               WHERE variable  = 'permissions_for_new_directories'";
     Database::query($sql);
 
-    $sql = "UPDATE $table SET selected_value = '0".decoct($permissions_for_new_files)."' WHERE variable  = 'permissions_for_new_files'";
+    $sql = "update $table SET selected_value = '0".decoct($permissions_for_new_files)."' WHERE variable  = 'permissions_for_new_files'";
     Database::query($sql);
 
     if (isset($_SESSION['permissions_for_new_directories'])) {
@@ -1977,7 +1977,7 @@ 
                 //Check fsockopen (not sure it works with https). If that is your case, you might want to try the
                 // suggestion at https://support.chamilo.org/issues/8260#note-3 (although it ignores SSL peer checks)
                 if ($fp = @fsockopen(str_replace('http://', $scheme, $url), $port, $sock_errno, $sock_errmsg, 60)) {
-                    $out  = "GET $path HTTP/1.1\r\n";
+                    $out  = "get $path HTTP/1.1\r\n";
                     $out .= "Host: $host\r\n";
                     $out .= "Connection: Close\r\n\r\n";
 
@@ -2285,7 +2285,7 @@ 
                 $data = $connection->fetchAssoc($sql);
                 if (!empty($data)) {
                     $newGroupId = $data['iid'];
-                    $sql = "UPDATE $table SET group_id = $newGroupId
+                    $sql = "update $table SET group_id = $newGroupId
                             WHERE iid = $iid";
                     $connection->executeQuery($sql);
                 } else {
@@ -2481,7 +2481,7 @@ 
                     $path['dir']
                 );
                 $command = "mv {$path['dir']} $newPath ";
-                error_log("Executing $command");
+                error_log("executing $command");
                 system($command);
             }
         }

Doc Comments +15 added lines, -6 removed lines

@@ -123,7 +123,7 @@ 
  * This function return the value of a php.ini setting if not "" or if exists,
  * otherwise return false
  * @param   string  $phpSetting The name of a PHP setting
- * @return  mixed   The value of the setting, or false if not found
+ * @return  string|false   The value of the setting, or false if not found
  */
 function checkPhpSettingExists($phpSetting)
 {
@@ -154,7 +154,7 @@ 
  * Returns a textual value ('ON' or 'OFF') based on a requester 2-state ini- configuration setting.
  *
  * @param string $val a php ini value
- * @return bool ON or OFF
+ * @return string ON or OFF
  * @author Joomla <http://www.joomla.org>
  */
 function getPhpSetting($val)
@@ -1358,6 +1358,10 @@ 
  * @param   string  Extra notice (to show on the right side)
  * @param   boolean Whether to display in update mode
  * @param   string  Additional attribute for the <tr> element
+ * @param string $installType
+ * @param string $parameterName
+ * @param string $formFieldName
+ * @param string $extra_notice
  * @return  void    Direct output
  */
 function displayDatabaseParameter(
@@ -1561,6 +1565,11 @@ 
     <?php
 }
 
+/**
+ * @param string $content
+ * @param string $title
+ * @param string $id
+ */
 function panel($content = null, $title = null, $id = null, $style = null)
 {
     $html = '';
@@ -1924,8 +1933,8 @@ 
 }
 
 /**
- * @param $current_value
- * @param $wanted_value
+ * @param string $current_value
+ * @param string $wanted_value
  * @return string
  */
 function compare_setting_values($current_value, $wanted_value)
@@ -1942,8 +1951,8 @@ 
 }
 
 /**
- * @param $course_dir
- * @param $course_attempt_name
+ * @param string $course_dir
+ * @param string $course_attempt_name
  * @param string $file
  * @return bool
  */

Braces +36 added lines, -18 removed lines

@@ -70,7 +70,8 @@ 
     $returnFailure = 'No',
     $optional = false,
     $enabledTerm = ''
-) {
+)
+{
     if (extension_loaded($extensionName)) {
         if (!empty($enabledTerm)) {
             $isEnabled = ini_get($enabledTerm);
@@ -109,7 +110,8 @@ 
     $recommendedValue,
     $returnSuccess = false,
     $returnFailure = false
-) {
+)
+{
     $currentPhpValue = getPhpSetting($phpSetting);
     if ($currentPhpValue == $recommendedValue) {
         return Display::label($currentPhpValue.' '.$returnSuccess, 'success');
@@ -563,7 +565,8 @@ 
     $dbPassForm,
     $dbNameForm,
     $dbPortForm = 3306
-) {
+)
+{
     $dbParams = array(
         'driver' => 'pdo_mysql',
         'host' => $dbHostForm,
@@ -610,7 +613,8 @@ 
 function display_language_selection_box(
     $name = 'language_list',
     $default_language = 'english'
-) {
+)
+{
     // Reading language list.
     $language_list = get_language_folder_list();
 
@@ -712,7 +716,8 @@ 
     $badUpdatePath,
     $updatePath = '',
     $update_from_version_8 = array()
-) {
+)
+{
     global $_setting;
     echo '<div class="RequirementHeading"><h2>'.display_step_sequence().get_lang('Requirements')."</h2></div>";
     echo '<div class="RequirementText">';
@@ -1032,8 +1037,7 @@ 
                 <?php echo get_lang('Error'); ?>!<br />
                 Chamilo <?php echo implode('|', $update_from_version_8).' '.get_lang('HasNotBeenFoundInThatDir'); ?>.
             </div>
-        <?php }
-        else {
+        <?php } else {
             echo '<br />';
         }
         ?>
@@ -1153,7 +1157,10 @@ 
         <button type="submit" name="step1" class="btn btn-default" onclick="javascript: window.location='index.php'; return false;" value="<?php echo get_lang('Previous'); ?>" >
             <em class="fa fa-backward"> </em> <?php echo get_lang('Previous'); ?>
         </button>
-        <button type="submit" name="step2_install" class="btn btn-success" value="<?php echo get_lang("NewInstallation"); ?>" <?php if ($error) echo 'disabled="disabled"'; ?> >
+        <button type="submit" name="step2_install" class="btn btn-success" value="<?php echo get_lang("NewInstallation"); ?>" <?php if ($error) {
+    echo 'disabled="disabled"';
+}
+?> >
             <em class="fa fa-forward"> </em> <?php echo get_lang('NewInstallation'); ?>
         </button>
         <input type="hidden" name="is_executable" id="is_executable" value="-" />
@@ -1368,7 +1375,8 @@ 
     $extra_notice,
     $displayWhenUpdate = true,
     $tr_attribute = ''
-) {
+)
+{
     //echo "<tr ".$tr_attribute.">";
     echo "<label class='col-sm-4'>$parameterName</label>";
 
@@ -1409,7 +1417,8 @@ 
     $dbNameForm,
     $dbPortForm = 3306,
     $installationProfile = ''
-) {
+)
+{
     if ($installType == 'update') {
         global $_configuration;
         $dbHostForm = $_configuration['db_host'];
@@ -1532,9 +1541,12 @@ 
             Database port: <strong><?php echo $manager->getConnection()->getPort(); ?></strong><br/>
             Database driver: <strong><?php echo $manager->getConnection()->getDriver()->getName(); ?></strong><br/>
         </div>
-    <?php else: ?>
+    <?php else {
+    : ?>
         <div id="db_status" class="alert alert-danger">
-            <p><?php echo get_lang('FailedConectionDatabase'); ?></strong></p>
+            <p><?php echo get_lang('FailedConectionDatabase');
+}
+?></strong></p>
             <code><?php echo $database_exists_text ?></code>
         </div>
     <?php endif; ?>
@@ -1594,7 +1606,8 @@ 
     $formFieldName,
     $parameterValue,
     $displayWhenUpdate = 'true'
-) {
+)
+{
     $html = '<div class="form-group">';
     $html .= '<label class="col-sm-6 control-label">'.$parameterName.'</label>';
     if ($installType == INSTALL_TYPE_UPDATE && $displayWhenUpdate) {
@@ -1641,7 +1654,8 @@ 
     $allowSelfRegProf,
     $loginForm,
     $passForm
-) {
+)
+{
     if ($installType != 'update' && empty($languageForm)) {
         $languageForm = $_SESSION['install_language'];
     }
@@ -1678,7 +1692,8 @@ 
     if ($installType == 'update') {
         $html .= '<input type="hidden" name="languageForm" value="'.api_htmlentities($languageForm, ENT_QUOTES).'" />'.$languageForm;
 
-    } else { // new installation
+    } else {
+// new installation
         $html .= '<div class="col-sm-6">';
         $html .= display_language_selection_box('languageForm', $languageForm);
         $html .= '</div>';
@@ -1951,7 +1966,8 @@ 
     $course_dir,
     $course_attempt_name,
     $file = 'test.php'
-) {
+)
+{
     $output = false;
     //Write in file
     $file_name = $course_dir.'/'.$file;
@@ -2061,7 +2077,8 @@ 
     $allowRegistration,
     $allowTeacherSelfRegistration,
     $installationProfile = ''
-) {
+)
+{
     $allowTeacherSelfRegistration = $allowTeacherSelfRegistration ? 'true' : 'false';
 
     // Use PHP 5.3 to avoid issue with weird peripherical auto-installers like travis-ci
@@ -2759,7 +2776,8 @@ 
     $allowSelfReg,
     $allowSelfRegProf,
     $installationProfile = ''
-) {
+)
+{
     $sysPath = !empty($sysPath) ? $sysPath : api_get_path(SYS_PATH);
 
     $connection = $manager->getConnection();

main/exercise/hotpotatoes_exercise_result.class.php

Indentation +4 added lines, -5 removed lines

@@ -102,7 +102,6 @@ 
      * Exports the complete report as a CSV file
      * @param string $document_path Document path inside the document tool
      * @param string $hotpotato_name
-
      * @return	boolean		False on error
      */
     public function exportCompleteReportCSV($document_path = '', $hotpotato_name = '')
@@ -140,11 +139,11 @@ 
         // Results
         foreach ($this->results as $row) {
             if (api_is_western_name_order()) {
-              $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['first_name']), ENT_QUOTES, $charset)).';';
-              $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['last_name']), ENT_QUOTES, $charset)).';';
+                $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['first_name']), ENT_QUOTES, $charset)).';';
+                $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['last_name']), ENT_QUOTES, $charset)).';';
             } else {
-              $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['last_name']), ENT_QUOTES, $charset)).';';
-              $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['first_name']), ENT_QUOTES, $charset)).';';
+                $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['last_name']), ENT_QUOTES, $charset)).';';
+                $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['first_name']), ENT_QUOTES, $charset)).';';
             }
 
             $data .= str_replace("\r\n", '  ', api_html_entity_decode(strip_tags($row['email']), ENT_QUOTES, $charset)).';';

Doc Comments +1 added lines

@@ -19,6 +19,7 @@
      * @param    string        The document path (for HotPotatoes retrieval)
      * @param    integer        User ID. Optional. If no user ID is provided, we take all the results. Defauts to null
      * @param string $document_path
+     * @param string|null $hotpotato_name
      * @return bool
      */
     public function getExercisesReporting($document_path, $hotpotato_name)

plugin/buycourses/src/service_sales_report.php

Braces +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
 $servicesSales = $plugin->getServiceSale();

 $serviceSaleList = [];

 

-foreach ($servicesSales as $sale) {

+foreach ($servicesSales as $sale) {
     $serviceSaleList[] = [

         'id' => $sale['id'],

         'reference' => $sale['reference'],

@@ -51,7 +51,7 @@ 
 

 $template = new Template($templateName);

 

-if ($paypalEnable == 'true' && $commissionsEnable == 'true') {

+if ($paypalEnable == 'true' && $commissionsEnable == 'true') {
     $toolbar = Display::toolbarButton(

         $plugin->get_lang('PaypalPayoutCommissions'),

         api_get_path(WEB_PLUGIN_PATH).'buycourses/src/paypal_payout.php',

@@ -66,7 +66,7 @@ 
     );

 }

 

-if ($commissionsEnable == 'true') {

+if ($commissionsEnable == 'true') {
     $toolbar = Display::toolbarButton(

         $plugin->get_lang('PayoutReport'),

         api_get_path(WEB_PLUGIN_PATH).'buycourses/src/payout_report.php',

plugin/buycourses/src/sales_report.php

Braces +10 added lines, -10 removed lines

@@ -18,16 +18,16 @@ 
 $commissionsEnable = $plugin->get('commissions_enable');

 $includeServices = $plugin->get('include_services');

 

-if (isset($_GET['order'])) {

+if (isset($_GET['order'])) {
     $sale = $plugin->getSale($_GET['order']);

 

-    if (empty($sale)) {

+    if (empty($sale)) {
         api_not_allowed(true);

     }

 

     $urlToRedirect = api_get_self().'?';

 

-    switch ($_GET['action']) {

+    switch ($_GET['action']) {
         case 'confirm':

             $plugin->completeSale($sale['id']);

             $plugin->storePayouts($sale['id']);

@@ -75,16 +75,16 @@ 
 

 $form = new FormValidator('search', 'get');

 

-if ($form->validate()) {

+if ($form->validate()) {
     $selectedFilterType = $form->getSubmitValue('filter_type');

     $selectedStatus = $form->getSubmitValue('status');

     $searchTerm = $form->getSubmitValue('user');

 

-    if ($selectedStatus === false) {

+    if ($selectedStatus === false) {
         $selectedStatus = BuyCoursesPlugin::SALE_STATUS_PENDING;

     }

 

-    if ($selectedFilterType === false) {

+    if ($selectedFilterType === false) {
         $selectedFilterType = '0';

     }

 }

@@ -106,7 +106,7 @@ 
     'status' => $selectedStatus

 ]);

 

-switch ($selectedFilterType) {

+switch ($selectedFilterType) {
     case '0':

         $sales = $plugin->getSaleListByStatus($selectedStatus);

         break;

@@ -117,7 +117,7 @@ 
 

 $saleList = [];

 

-foreach ($sales as $sale) {

+foreach ($sales as $sale) {
     $saleList[] = [

         'id' => $sale['id'],

         'reference' => $sale['reference'],

@@ -139,7 +139,7 @@ 
 

 $template = new Template($templateName);

 

-if ($paypalEnable == "true" && $commissionsEnable == "true") {

+if ($paypalEnable == "true" && $commissionsEnable == "true") {
     $toolbar = Display::toolbarButton(

         $plugin->get_lang('PaypalPayoutCommissions'),

         api_get_path(WEB_PLUGIN_PATH).'buycourses/src/paypal_payout.php',

@@ -154,7 +154,7 @@ 
     );

 }

 

-if ($commissionsEnable == "true") {

+if ($commissionsEnable == "true") {
     $toolbar = Display::toolbarButton(

         $plugin->get_lang('PayoutReport'),

         api_get_path(WEB_PLUGIN_PATH).'buycourses/src/payout_report.php',

main/dropbox/dropbox_class.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -615,7 +615,7 @@
      *
      * @param string $id
      * @param string $text
-     * @return bool
+     * @return false|null
      */
     public function updateFeedback($id, $text)
     {

src/Chamilo/CourseBundle/Component/CourseCopy/CourseSelectForm.php

Braces +3 added lines, -2 removed lines

@@ -553,8 +553,8 @@ 
                         // Mark folders to import which are not selected by the user to import,
                         // but in which a document was selected.
                         $documents = isset($_POST['resource'][RESOURCE_DOCUMENT]) ? $_POST['resource'][RESOURCE_DOCUMENT] : null;
-                        if (!empty($resources) && is_array($resources))
-                            foreach ($resources as $id => $obj) {
+                        if (!empty($resources) && is_array($resources)) {
+                                                    foreach ($resources as $id => $obj) {
                                 if (isset($obj->file_type) && $obj->file_type == 'folder' &&
                                     !isset($_POST['resource'][RESOURCE_DOCUMENT][$id]) &&
                                     is_array($documents)
@@ -562,6 +562,7 @@ 
                                     foreach ($documents as $id_to_check => $post_value) {
                                         if (isset($resources[$id_to_check])) {
                                             $obj_to_check = $resources[$id_to_check];
+                        }
                                             $shared_path_part = substr(
                                                 $obj_to_check->path,
                                                 0,