chamilo / chamilo-lms

main/lp/aicc.class.php

Indentation +1 added lines, -1 removed lines

@@ -359,7 +359,7 @@
         $current_dir = api_replace_dangerous_char(trim($current_dir)); // Current dir we are in, inside scorm/
         if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Current_dir = '.$current_dir, 0); }
 
-         //$uploaded_filename = $_FILES['userFile']['name'];
+            //$uploaded_filename = $_FILES['userFile']['name'];
         // Get the name of the zip file without the extension.
         if ($this->debug > 0) { error_log('New LP - aicc::import_package() - Received zip file name: '.$zip_file_path, 0); }
         $file_info = pathinfo($zip_file_name);

Doc Comments +6 added lines, -4 removed lines

@@ -224,7 +224,7 @@ 
     /**
      * Import the aicc object (as a result from the parse_config_files function) into the database structure
      * @param    string $course_code
-     * @return    bool    Returns -1 on error
+     * @return    false|null    Returns -1 on error
      */
     public function import_aicc($course_code)
     {
@@ -641,7 +641,7 @@ 
     /**
      * Sets the Author LP in the database
      * @param    string $author
-     * @return true
+     * @return boolean
      */
     public function set_author($author = '')
     {
@@ -811,7 +811,8 @@ 
      * Static function to parse AICC ini files.
      * Based on work by sinedeo at gmail dot com published on php.net (parse_ini_file()).
      * @param	string	File path
-     * @return	array	Structured array
+     * @param string $f
+     * @return	string	Structured array
      */
     public function parse_ini_file_quotes_safe($f)
     {
@@ -864,7 +865,7 @@ 
      * @param		string	INI File string
      * @param		array	List of names of sections that should be considered
      * as containing only hard string data (no variables), provided in lower case
-     * @return	array	Structured array
+     * @return	string	Structured array
      */
     public function parse_ini_string_quotes_safe($s, $pure_strings = array())
     {
@@ -928,6 +929,7 @@ 
      * @param	string	CSV delimiter
      * @param	string	CSV enclosure
      * @param	boolean	Might one field name happen more than once on the same line? (then split by comma in the values)
+     * @param string $f
      * @return array	Simple structured array
      */
     public function parse_csv_file($f, $delim = ',', $enclosure = '"', $multiples = false)

Braces +7 added lines, -3 removed lines

@@ -532,7 +532,9 @@ 
                     if ($file != '.' && $file != '..') {
                         $filetype = 'file';
 
-                        if (is_dir($course_sys_dir.$new_dir.$file)) $filetype = 'folder';
+                        if (is_dir($course_sys_dir.$new_dir.$file)) {
+                            $filetype = 'folder';
+                        }
 
                         // TODO: RENAMING FILES CAN BE VERY DANGEROUS AICC-WISE, avoid that as much as possible!
                         //$safe_file = api_replace_dangerous_char($file, 'strict');
@@ -844,7 +846,8 @@ 
                         $v = @substr($v, 1, @strlen($v) - 2);
                     }
                     if ($sec) {
-                        if (api_strtolower($sec) == 'course_description') { // A special case.
+                        if (api_strtolower($sec) == 'course_description') {
+// A special case.
                             $r[api_strtolower($sec)] = $k;
                         } else {
                             $r[api_strtolower($sec)][api_strtolower($k)] = $v;
@@ -906,7 +909,8 @@ 
                         if ($pure_data) {
                             $r[api_strtolower($sec)] .= $f[$i];
                         } else {
-                            if (api_strtolower($sec) == 'course_description') { // A special case.
+                            if (api_strtolower($sec) == 'course_description') {
+// A special case.
                                 $r[api_strtolower($sec)] = $k;
                             } else {
                                 $r[api_strtolower($sec)][api_strtolower($k)] = $v;

Upper-Lower-Casing +8 added lines, -8 removed lines

@@ -264,7 +264,7 @@ 
         $lp_id = Database::insert_id();
 
         if ($lp_id) {
-            $sql = "UPDATE $new_lp SET id = iid  WHERE iid = $lp_id";
+            $sql = "update $new_lp SET id = iid  WHERE iid = $lp_id";
             Database::query($sql);
 
             $this->lp_id = $lp_id;
@@ -318,13 +318,13 @@ 
             $item_id = Database::insert_id();
 
             if ($item_id) {
-                $sql = "UPDATE $new_lp_item SET id = iid WHERE iid = $lp_id";
+                $sql = "update $new_lp_item SET id = iid WHERE iid = $lp_id";
                 Database::query($sql);
             }
 
             // Now update previous item to change next_item_id.
             if ($previous != 0) {
-                $upd = "UPDATE $new_lp_item SET next_item_id = $item_id WHERE c_id = $course_id AND id = $previous";
+                $upd = "update $new_lp_item SET next_item_id = $item_id WHERE c_id = $course_id AND id = $previous";
                 Database::query($upd);
                 // Update the previous item id.
             }
@@ -589,7 +589,7 @@ 
         $lp = $this->get_id();
         if ($lp != 0) {
             $tbl_lp = Database::get_course_table(TABLE_LP_MAIN);
-            $sql = "UPDATE $tbl_lp SET content_local = '$proxy' WHERE c_id = ".$course_id." id = ".$lp;
+            $sql = "update $tbl_lp SET content_local = '$proxy' WHERE c_id = ".$course_id." id = ".$lp;
             Database::query($sql);
             return true;
         } else {
@@ -609,7 +609,7 @@ 
         $lp = $this->get_id();
         if ($lp != 0) {
             $tbl_lp = Database::get_course_table(TABLE_LP_MAIN);
-            $sql = "UPDATE $tbl_lp SET theme = '$theme' WHERE c_id = ".$course_id." id = ".$lp;
+            $sql = "update $tbl_lp SET theme = '$theme' WHERE c_id = ".$course_id." id = ".$lp;
             $res = Database::query($sql);
             return true;
         } else {
@@ -629,7 +629,7 @@ 
         $lp = $this->get_id();
         if ($lp != 0) {
             $tbl_lp = Database::get_course_table(TABLE_LP_MAIN);
-            $sql = "UPDATE $tbl_lp SET preview_image = '$preview_image' 
+            $sql = "update $tbl_lp SET preview_image = '$preview_image' 
                     WHERE c_id = ".$course_id." id = ".$lp;
             Database::query($sql);
             return true;
@@ -650,7 +650,7 @@ 
         $lp = $this->get_id();
         if ($lp != 0) {
             $tbl_lp = Database::get_course_table(TABLE_LP_MAIN);
-            $sql = "UPDATE $tbl_lp SET author = '$author' 
+            $sql = "update $tbl_lp SET author = '$author' 
                     WHERE c_id = ".$course_id." id = ".$lp;
             Database::query($sql);
             return true;
@@ -671,7 +671,7 @@ 
         $lp = $this->get_id();
         if ($lp != 0) {
             $tbl_lp = Database::get_course_table(TABLE_LP_MAIN);
-            $sql = "UPDATE $tbl_lp SET content_maker = '$maker' 
+            $sql = "update $tbl_lp SET content_maker = '$maker' 
                     WHERE c_id = ".$course_id." id = ".$lp;
             Database::query($sql);
             return true;

main/user/subscribe_user.php

Indentation +1 added lines, -1 removed lines

@@ -480,7 +480,7 @@
             }
             $sql .= " AND access_url_id = $url_access_id";
         } else {
-             // adding a teacher NOT through a session
+                // adding a teacher NOT through a session
             $sql = "SELECT $select_fields
                     FROM $user_table u
                     LEFT JOIN $course_user_table cu

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -450,7 +450,7 @@ 
     if (isset($_REQUEST['type']) && $_REQUEST['type'] == COURSEMANAGER) {
         // adding a teacher through a session
         if (!empty($sessionId)) {
-            $sql = "SELECT $select_fields
+            $sql = "select $select_fields
                     FROM $user_table u
                     LEFT JOIN $tbl_session_rel_course_user cu
                     ON
@@ -481,7 +481,7 @@ 
             $sql .= " AND access_url_id = $url_access_id";
         } else {
              // adding a teacher NOT through a session
-            $sql = "SELECT $select_fields
+            $sql = "select $select_fields
                     FROM $user_table u
                     LEFT JOIN $course_user_table cu
                     ON u.user_id = cu.user_id AND c_id = '".$courseId."'";
@@ -505,7 +505,7 @@ 
             // adding a teacher NOT trough a session on a portal with multiple URLs
             if (api_is_multiple_url_enabled()) {
                 if ($url_access_id != -1) {
-                    $sql = "SELECT $select_fields
+                    $sql = "select $select_fields
                             FROM $user_table u
                             LEFT JOIN $course_user_table cu
                             ON u.user_id = cu.user_id and c_id='".$courseId."'
@@ -535,7 +535,7 @@ 
     } else {
         // adding a student
         if (!empty($sessionId)) {
-            $sql = "SELECT $select_fields
+            $sql = "select $select_fields
                     FROM $user_table u
                     LEFT JOIN $tbl_session_rel_course_user cu
                     ON
@@ -571,7 +571,7 @@ 
                 $sql .= "AND access_url_id = $url_access_id";
             }
         } else {
-            $sql = "SELECT $select_fields
+            $sql = "select $select_fields
                     FROM $user_table u
                     LEFT JOIN $course_user_table cu
                     ON
@@ -596,7 +596,7 @@ 
             //showing only the courses of the current Chamilo access_url_id
             if (api_is_multiple_url_enabled()) {
                 if ($url_access_id != -1) {
-                    $sql = "SELECT $select_fields
+                    $sql = "select $select_fields
                         FROM $user_table u
                         LEFT JOIN $course_user_table cu
                         ON u.user_id = cu.user_id AND c_id='".$courseId."'

main/gradebook/lib/be/evaluation.class.php

Doc Comments +4 added lines, -1 removed lines

@@ -120,6 +120,9 @@ 
         return $this->created_at;
     }
 
+    /**
+     * @return string
+     */
     public function get_weight()
     {
         return $this->weight;
@@ -271,7 +274,7 @@ 
     }
 
     /**
-     * @param array $result
+     * @param Doctrine\DBAL\Driver\Statement $result
      * @return array
      */
     private static function create_evaluation_objects_from_sql_result($result)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -813,7 +813,7 @@
     public function lock($locked)
     {
         $table_evaluation = Database::get_main_table(TABLE_MAIN_GRADEBOOK_EVALUATION);
-        $sql = "UPDATE $table_evaluation 
+        $sql = "update $table_evaluation 
                 SET locked = '".intval($locked)."' 
                 WHERE id='".intval($this->id)."'";
         Database::query($sql);

main/inc/lib/extra_field_option.lib.php

Doc Comments +4 added lines, -4 removed lines

@@ -115,7 +115,7 @@ 
      * Delete all the options of a specific field
      * @param int $field_id
      *
-     * @return void
+     * @return Statement
      * @assert (-1) === false
      */
     public function delete_all_options_by_field_id($field_id)
@@ -412,7 +412,7 @@ 
      * Gets an array of options for a specific field
      * @param int $field_id The field ID
      * @param bool $add_id_in_array Whether to add the row ID in the result
-     * @param null $ordered_by Extra ordering query bit
+     * @param null|string $ordered_by Extra ordering query bit
      * @return array The options if they exists. Otherwise return false
      */
     public function get_field_options_by_field($field_id, $add_id_in_array = false, $ordered_by = null)
@@ -784,8 +784,8 @@ 
     }
 
     /**
-     * @param $defaultDisplayText
-     * @return mixed|string
+     * @param string $defaultDisplayText
+     * @return string
      */
     public static function getLanguageVariable($defaultDisplayText)
     {

main/user/resume_session.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -97,24 +97,24 @@
                 $nbr_affected_rows = Database::affected_rows($result);
 
                 Database::query("DELETE FROM $tbl_session_rel_course_rel_user WHERE session_id='$id_session' AND c_id IN($idChecked)");
-                Database::query("UPDATE $tbl_session SET nbr_courses=nbr_courses-$nbr_affected_rows WHERE id='$id_session'");
+                Database::query("update $tbl_session SET nbr_courses=nbr_courses-$nbr_affected_rows WHERE id='$id_session'");
             }
 
             if (!empty($_GET['class'])) {
                 $result = Database::query("DELETE FROM $tbl_session_rel_class WHERE session_id='$id_session' AND class_id=".intval($_GET['class']));
                 $nbr_affected_rows = Database::affected_rows($result);
-                Database::query("UPDATE $tbl_session SET nbr_classes=nbr_classes-$nbr_affected_rows WHERE id='$id_session'");
+                Database::query("update $tbl_session SET nbr_classes=nbr_classes-$nbr_affected_rows WHERE id='$id_session'");
             }
 
             if (!empty($_GET['user'])) {
                 $result = Database::query("DELETE FROM $tbl_session_rel_user WHERE relation_type<>".SESSION_RELATION_TYPE_RRHH." AND session_id ='$id_session' AND user_id=".intval($_GET['user']));
                 $nbr_affected_rows = Database::affected_rows($result);
-                Database::query("UPDATE $tbl_session SET nbr_users=nbr_users-$nbr_affected_rows WHERE id='$id_session'");
+                Database::query("update $tbl_session SET nbr_users=nbr_users-$nbr_affected_rows WHERE id='$id_session'");
 
                 $result = Database::query("DELETE FROM $tbl_session_rel_course_rel_user WHERE session_id ='$id_session' AND user_id=".intval($_GET['user']));
                 $nbr_affected_rows = Database::affected_rows($result);
 
-                Database::query("UPDATE $tbl_session_rel_course SET nbr_users=nbr_users-$nbr_affected_rows WHERE session_id ='$id_session'");
+                Database::query("update $tbl_session_rel_course SET nbr_users=nbr_users-$nbr_affected_rows WHERE session_id ='$id_session'");
             }
             break;
     }

Braces +7 added lines, -1 removed lines

@@ -189,12 +189,18 @@
             <?php echo api_ucfirst(get_lang('SessionVisibility')) ?> :
         </td>
         <td>
-            <?php if ($session['visibility'] == 1) echo get_lang('ReadOnly'); elseif ($session['visibility'] == 2) echo get_lang('Visible'); elseif ($session['visibility'] == 3) echo api_ucfirst(get_lang('Invisible'))  ?>
+            <?php if ($session['visibility'] == 1) {
+    echo get_lang('ReadOnly');
+} elseif ($session['visibility'] == 2) {
+    echo get_lang('Visible');
+} elseif ($session['visibility'] == 3) {
+    echo api_ucfirst(get_lang('Invisible'))  ?>
         </td>
     </tr>
     <?php
 
     $multiple_url_is_on = api_get_multiple_access_url();
+}
     if ($multiple_url_is_on) {
         echo '<tr><td>';
         echo 'URL';

main/session/add_many_session_to_category.php

Braces +13 added lines, -6 removed lines

@@ -195,10 +195,11 @@ 
         <?php
         if (!empty($rows_session_category)) {
             foreach ($rows_session_category as $category) {
-                if ($category['id'] == $categoryId)
-                        echo '<option value="'.$category['id'].'" selected>'.$category['name'].'</option>';
-                    else
-                        echo '<option value="'.$category['id'].'">'.$category['name'].'</option>';
+                if ($category['id'] == $categoryId) {
+                                        echo '<option value="'.$category['id'].'" selected>'.$category['name'].'</option>';
+                } else {
+                                            echo '<option value="'.$category['id'].'">'.$category['name'].'</option>';
+                    }
             }
         }
             ?>
@@ -222,7 +223,10 @@ 
     <?php
     foreach ($rows_session as $enreg) {
     ?>
-        <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['name'], ENT_QUOTES).'"'; if (in_array($enreg['id'], $CourseList)) echo 'selected="selected"'; ?>><?php echo $enreg['name']; ?></option>
+        <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['name'], ENT_QUOTES).'"'; if (in_array($enreg['id'], $CourseList)) {
+    echo 'selected="selected"';
+}
+?>><?php echo $enreg['name']; ?></option>
     <?php } ?>
     </select></div>
 <?php unset($nosessionCourses); ?>
@@ -244,7 +248,10 @@ 
   <select id='destination' name="SessionCategoryList[]" multiple="multiple" size="20" style="width:320px;">
     <?php
     foreach ($rows_category_session as $enreg) { ?>
-        <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['name'], ENT_QUOTES).'"'; if (in_array($enreg['id'], $CourseList)) echo 'selected="selected"'; ?>><?php echo $enreg['name']; ?></option>
+        <option value="<?php echo $enreg['id']; ?>" <?php echo 'title="'.htmlspecialchars($enreg['name'], ENT_QUOTES).'"'; if (in_array($enreg['id'], $CourseList)) {
+    echo 'selected="selected"';
+}
+?>><?php echo $enreg['name']; ?></option>
     <?php } ?>
   </select></td>
 </tr>

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -92,13 +92,13 @@
 
     if ($categoryId != 0 && count($sessionCategoryList) > 0) {
         // Removing all
-        $sql = "UPDATE $tbl_session SET session_category_id = NULL WHERE session_category_id = $categoryId";
+        $sql = "update $tbl_session SET session_category_id = NULL WHERE session_category_id = $categoryId";
         Database::query($sql);
         // Adding new
         $sessionCategoryList = array_map('intval', $sessionCategoryList);
         $session_id = join(',', $sessionCategoryList);
 
-        $sql = "UPDATE $tbl_session SET session_category_id = $categoryId WHERE id in ($session_id) ";
+        $sql = "update $tbl_session SET session_category_id = $categoryId WHERE id in ($session_id) ";
         Database::query($sql);
         header('Location: add_many_session_to_category.php?id_category='.$categoryId.'&msg=ok');
         exit;

plugin/search_course/lib/register_course_widget.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     /**
      * Handle the subscribe action.
      *
-     * @return bool
+     * @return null|boolean
      */
     function action_subscribe_user()
     {

Braces +6 added lines, -12 removed lines

@@ -62,26 +62,22 @@ 
     function action_subscribe_user()
     {
         $action = self::get('action');
-        if ($action != self::ACTION_SUBSCRIBE)
-        {
+        if ($action != self::ACTION_SUBSCRIBE) {
             return false;
         }
 
         $course_code = self::post(self::PARAM_SUBSCRIBE);
-        if (empty($course_code))
-        {
+        if (empty($course_code)) {
             return false;
         }
 
         $registration_code = self::post(self::PARAM_PASSCODE);
 
-        if ($this->subscribe_user($course_code, $registration_code))
-        {
+        if ($this->subscribe_user($course_code, $registration_code)) {
             echo Display::return_message(get_lang('EnrollToCourseSuccessful'), 'confirmation');
             return;
         }
-        if (!empty($registration_code))
-        {
+        if (!empty($registration_code)) {
             echo Display::return_message(get_lang('CourseRegistrationCodeIncorrect'), 'error');
         }
         $this->display_form($course_code);
@@ -101,13 +97,11 @@ 
     {
         $course = api_get_course_info($course_code);
         $course_regisration_code = $course['registration_code'];
-        if (!empty($course_regisration_code) && $registration_code != $course_regisration_code)
-        {
+        if (!empty($course_regisration_code) && $registration_code != $course_regisration_code) {
             return false;
         }
 
-        if (empty($user_id))
-        {
+        if (empty($user_id)) {
             global $_user;
             $user_id = $_user['user_id'];
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
             <input type="hidden" name="subscribe" value="$course_code" />
             <input type="text" name="course_registration_code" value="$registration_code" />
             <input type="Submit" name="submit_course_registration_code" value="OK" alt="$submit_registration_code_label" /></form>
-EOT;
+eot;
         echo $result;
     }
 }

main/inc/lib/table_sort.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
      * @param string $direction The direction to sort (SORT_ASC (default) orSORT_DESC)
      * @param array $column_show The columns that we will show in the table i.e: $column_show = array('1','0','1') we will show the 1st and the 3th column.
      * @param array $column_order Changes how the columns will be sorted ie. $column_order = array('0','3','2','3') The column [1] will be sorted like the column [3]
-     * @param constant $type How should data be sorted (SORT_REGULAR, SORT_NUMERIC, SORT_STRING, SORT_DATE, SORT_IMAGE)
+     * @param integer $type How should data be sorted (SORT_REGULAR, SORT_NUMERIC, SORT_STRING, SORT_DATE, SORT_IMAGE)
      * @return array The sorted dataset
      * @author bart.mollet@hogent.be
      */

Indentation +9 added lines, -9 removed lines

@@ -16,15 +16,15 @@
 class TableSort
 {
     /**
-    * Sorts 2-dimensional table.
-    * @param array $data The data to be sorted.
-    * @param int $column The column on which the data should be sorted (default = 0)
-    * @param int $direction The direction to sort (SORT_ASC (default) or SORT_DESC)
-    * @param int $type How should data be sorted (SORT_REGULAR, SORT_NUMERIC,
-    * SORT_STRING,SORT_DATE,SORT_IMAGE)
-    * @return array The sorted dataset
-    * @author bart.mollet@hogent.be
-    */
+     * Sorts 2-dimensional table.
+     * @param array $data The data to be sorted.
+     * @param int $column The column on which the data should be sorted (default = 0)
+     * @param int $direction The direction to sort (SORT_ASC (default) or SORT_DESC)
+     * @param int $type How should data be sorted (SORT_REGULAR, SORT_NUMERIC,
+     * SORT_STRING,SORT_DATE,SORT_IMAGE)
+     * @return array The sorted dataset
+     * @author bart.mollet@hogent.be
+     */
     public static function sort_table(
         $data,
         $column = 0,

src/Chamilo/CoreBundle/Component/Utils/ChamiloApi.php

Doc Comments +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
     /**
      * Like strip_tags(), but leaves an additional space and removes only the given tags
      * @param string $string
-     * @param array $tags Tags to be removed
+     * @param string[] $tags Tags to be removed
      * @return  string The original string without the given tags
      */
     public static function stripGivenTags($string, $tags)