chamilo / chamilo-lms

main/webservices/lp.php

Indentation +1 added lines, -1 removed lines

@@ -581,7 +581,7 @@
     /*$sessionIdName = isset($params['session_id_name']) ? $params['session_id_name'] : null;
     $sessionIdValue = isset($params['session_id_value']) ? $params['session_id_value'] : null;*/
 
-     $courseInfo = CourseManager::getCourseInfoFromOriginalId(
+        $courseInfo = CourseManager::getCourseInfoFromOriginalId(
         $courseIdValue,
         $courseIdName
     );

Braces +50 added lines, -21 removed lines

@@ -20,7 +20,8 @@ 
 
 define('WS_ERROR_SECRET_KEY', 1);
 
-function return_error($code) {
+function return_error($code)
+{
     $fault = null;
     switch ($code) {
         case WS_ERROR_SECRET_KEY:
@@ -48,19 +49,22 @@ 
         list($ip1) = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
         $ip = trim($ip1);
     }
-    if ($debug)
-        error_log("ip: $ip");
+    if ($debug) {
+            error_log("ip: $ip");
+    }
     // Check if a file that limits access from webservices exists and contains
     // the restraining check
     if (is_file('webservice-auth-ip.conf.php')) {
         include 'webservice-auth-ip.conf.php';
-        if ($debug)
-            error_log("webservice-auth-ip.conf.php file included");
+        if ($debug) {
+                    error_log("webservice-auth-ip.conf.php file included");
+        }
         if (!empty($ws_auth_ip)) {
             $check_ip = true;
             $ip_matches = api_check_ip_in_range($ip, $ws_auth_ip);
-            if ($debug)
-                error_log("ip_matches: $ip_matches");
+            if ($debug) {
+                            error_log("ip_matches: $ip_matches");
+            }
         }
     }
 
@@ -76,8 +80,9 @@ 
     }
     $result = api_is_valid_secret_key($secret_key, $security_key);
     //error_log($secret_key.'-'.$security_key);
-    if ($debug)
-        error_log('WSHelperVerifyKey result: '.intval($result));
+    if ($debug) {
+            error_log('WSHelperVerifyKey result: '.intval($result));
+    }
     return $result;
 }
 
@@ -140,7 +145,9 @@ 
     if (!WSHelperVerifyKey($params)) {
         return return_error(WS_ERROR_SECRET_KEY);
     }
-    if ($debug) error_log('WSImportLP');
+    if ($debug) {
+        error_log('WSImportLP');
+    }
 
     $courseIdName = $params['course_id_name'];
     $courseIdValue = $params['course_id_value'];
@@ -156,7 +163,9 @@ 
     $courseId = $courseInfo['real_id'];
 
     if (empty($courseInfo)) {
-        if ($debug) error_log('Course not found');
+        if ($debug) {
+            error_log('Course not found');
+        }
         return 'Course not found';
     }
 
@@ -169,7 +178,9 @@ 
 
         if (empty($sessionId)) {
 
-            if ($debug) error_log('Session not found');
+            if ($debug) {
+                error_log('Session not found');
+            }
             return 'Session not found';
         }
     }
@@ -196,7 +207,9 @@ 
     $manifest = $oScorm->import_package($fileInfo, '', $courseInfo);
 
     if (!$manifest) {
-        if ($debug) error_log('manifest.xml file not found');
+        if ($debug) {
+            error_log('manifest.xml file not found');
+        }
         return 'manifest.xml file not found';
     }
 
@@ -214,10 +227,14 @@ 
         $oScorm->set_maker($maker, $courseId);
         //$oScorm->set_jslib('scorm_api.php');
 
-        if ($debug) error_log('scorm was added');
+        if ($debug) {
+            error_log('scorm was added');
+        }
         return 1;
     } else {
-        if ($debug) error_log('manifest data empty');
+        if ($debug) {
+            error_log('manifest data empty');
+        }
         return 'manifest data empty';
     }
 }
@@ -310,7 +327,9 @@ 
     );
 
     if (empty($courseInfo)) {
-        if ($debug) error_log("Course not found: $courseIdName : $courseIdValue");
+        if ($debug) {
+            error_log("Course not found: $courseIdName : $courseIdValue");
+        }
         return 'Course not found';
     }
 
@@ -324,7 +343,9 @@ 
         );
 
         if (empty($sessionId)) {
-            if ($debug) error_log('Session not found');
+            if ($debug) {
+                error_log('Session not found');
+            }
             return 'Session not found';
         }
     }
@@ -405,7 +426,9 @@ 
     );
 
     if (empty($courseInfo)) {
-        if ($debug) error_log("Course not found: $courseIdName : $courseIdValue");
+        if ($debug) {
+            error_log("Course not found: $courseIdName : $courseIdValue");
+        }
         return 'Course not found';
     }
     $courseId = $courseInfo['real_id'];
@@ -430,7 +453,9 @@ 
 
     $lp = new learnpath($courseCode, $lpId, null);
     if ($lp) {
-        if ($debug) error_log("LP deleted $lpId");
+        if ($debug) {
+            error_log("LP deleted $lpId");
+        }
 
         $course_dir = $courseInfo['directory'].'/document';
         $sys_course_path = api_get_path(SYS_COURSE_PATH);
@@ -446,7 +471,9 @@ 
                 if ($item) {
                     $documentId = $item->get_path();
 
-                    if ($debug) error_log("lp item id found #$itemId");
+                    if ($debug) {
+                        error_log("lp item id found #$itemId");
+                    }
 
                     $documentInfo = DocumentManager::get_document_data_by_id(
                         $documentId,
@@ -472,7 +499,9 @@ 
                         }
                     }
                 } else {
-                    if ($debug) error_log("Document not found #$itemId");
+                    if ($debug) {
+                        error_log("Document not found #$itemId");
+                    }
                 }
             }
         }

main/admin/promotions.php

Indentation +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
 <script>
 $(function() {
 <?php
-     echo Display::grid_js('promotions', $url, $columns, $column_model, $extra_params, array(), $action_links, true);
+        echo Display::grid_js('promotions', $url, $columns, $column_model, $extra_params, array(), $action_links, true);
 ?>
 });
 </script>

main/inc/ajax/exercise.ajax.php

Indentation +1 added lines, -1 removed lines

@@ -488,7 +488,7 @@
                     $remind_list
                 );
 
-                 // Destruction of the Question object
+                    // Destruction of the Question object
                 unset($objQuestionTmp);
                 if ($debug) {
                     error_log(" -- end question -- ");

main/inc/local.inc.php

Indentation +1 added lines, -1 removed lines

@@ -758,7 +758,7 @@
     //    $gidReset = true;
 } // end else
 
- // Now check for anonymous user mode
+    // Now check for anonymous user mode
 if (isset($use_anonymous) && $use_anonymous) {
     //if anonymous mode is set, then try to set the current user as anonymous
     //if he doesn't have a login yet

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -183,7 +183,7 @@ 
         $cidReq = $c;
     }
     if (empty($cidReset)) {
-        if (!isset($_SESSION['_cid']) OR (isset($_SESSION['_cid']) && $cidReq != $_SESSION['_cid'])) {
+        if (!isset($_SESSION['_cid']) or (isset($_SESSION['_cid']) && $cidReq != $_SESSION['_cid'])) {
             $cidReset = $cidReq;
         }
     }
@@ -1479,7 +1479,7 @@ 
 if (isset($_cid)) {
     $tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
     $time = api_get_utc_datetime();
-    $sql = "UPDATE $tbl_course SET last_visit = '$time' WHERE code='$_cid'";
+    $sql = "update $tbl_course SET last_visit = '$time' WHERE code='$_cid'";
     Database::query($sql);
 }
 

Braces +12 added lines, -6 removed lines

@@ -544,7 +544,8 @@ 
                 // see configuration.php to define these
                 include_once($extAuthSource[$key]['login']);
                 /* >>>>>>>> External authentication modules <<<<<<<<< */
-            } else { // no standard Chamilo login - try external authentification
+            } else {
+// no standard Chamilo login - try external authentification
                 //huh... nothing to do... we shouldn't get here
                 error_log(
                     'Chamilo Authentication file defined in'.
@@ -891,7 +892,8 @@ 
     }
     Session::write('is_platformAdmin', $is_platformAdmin);
     Session::write('is_allowedCreateCourse', $is_allowedCreateCourse);
-} else { // continue with the previous values
+} else {
+// continue with the previous values
     $_user = $_SESSION['_user'];
     $is_platformAdmin = isset($_SESSION['is_platformAdmin']) ? $_SESSION['is_platformAdmin'] : false;
     $is_allowedCreateCourse = isset($_SESSION['is_allowedCreateCourse']) ? $_SESSION['is_allowedCreateCourse'] : false;
@@ -1017,7 +1019,8 @@ 
         }
     }
 
-    if (empty($_SESSION['_course']) || empty($_SESSION['_cid'])) { //no previous values...
+    if (empty($_SESSION['_course']) || empty($_SESSION['_cid'])) {
+//no previous values...
         $_cid = -1; // Set default values
         $_course = -1;
     } else {
@@ -1045,7 +1048,8 @@ 
             $sql = "SELECT * FROM $group_table
                     WHERE c_id = ".$_course['real_id']." AND id = '$gidReq'";
             $result = Database::query($sql);
-            if (Database::num_rows($result) > 0) { // This group has recorded status related to this course
+            if (Database::num_rows($result) > 0) {
+// This group has recorded status related to this course
                 $gpData = Database::fetch_array($result);
                 $_gid = $gpData ['id'];
                 Session::write('_gid', $_gid);
@@ -1169,7 +1173,8 @@ 
         $result = Database::query($sql);
 
         $cuData = null;
-        if (Database::num_rows($result) > 0) { // this  user have a recorded state for this course
+        if (Database::num_rows($result) > 0) {
+// this  user have a recorded state for this course
             $cuData = Database::fetch_array($result, 'ASSOC');
 
             $is_courseAdmin = (bool) ($cuData['status'] == 1);
@@ -1327,7 +1332,8 @@ 
                 }
             }
         }
-    } else { // keys missing => not anymore in the course - user relation
+    } else {
+// keys missing => not anymore in the course - user relation
         // course
         $is_courseMember = false;
         $is_courseAdmin = false;

main/inc/lib/extra_field_value.lib.php

Indentation +5 added lines, -6 removed lines

@@ -720,11 +720,11 @@ 
         return false;
     }
 
-     /**
-     * @param int $itemId
-     * @param int $fieldId
-     * @return array
-     */
+        /**
+         * @param int $itemId
+         * @param int $fieldId
+         * @return array
+         */
     public function getAllValuesByItemAndField($itemId, $fieldId)
     {
         $fieldId = intval($fieldId);
@@ -847,7 +847,6 @@ 
     /**
      * Deletes all values from an item
      * @param int $itemId (session id, course id, etc)
-
      * @assert (-1,-1) == null
      */
     public function deleteValuesByItem($itemId)

Doc Comments +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
      * This function is used with $extraField->addElements()
      * @param array $params array for the insertion into the *_field_values table
      * @param bool $showQuery
-     * @return mixed false on empty params, void otherwise
+     * @return false|null false on empty params, void otherwise
      * @assert (array()) === false
      */
     public function saveFieldValues($params, $showQuery = false)
@@ -529,7 +529,7 @@ 
      * @param int $item_id Item ID (It could be a session_id, course_id or user_id)
      * @param int $field_id Field ID (the ID from the *_field table)
      * @param bool $transform Whether to transform the result to a human readable strings
-     * @return mixed A structured array with the field_id and field_value, or false on error
+     * @return string A structured array with the field_id and field_value, or false on error
      * @assert (-1,-1) === false
      */
     public function get_values_by_handler_and_field_id($item_id, $field_id, $transform = false)

main/inc/lib/pdf.lib.php

Indentation -1 removed lines

@@ -73,7 +73,6 @@
      * Export the given HTML to PDF, using a global template
      *
      * @uses export/table_pdf.tpl
-
      * @param $content
      * @param bool|false $saveToFile
      * @param bool|false $returnHtml

Braces +3 added lines, -2 removed lines

@@ -546,8 +546,9 @@
             }
         } else {
             $store_path = api_get_path(SYS_CODE_PATH).'default_course_document/images/'.api_get_current_access_url_id().'_pdf_watermark.png'; // course path
-            if (file_exists($store_path))
-                $web_path = api_get_path(WEB_CODE_PATH).'default_course_document/images/'.api_get_current_access_url_id().'_pdf_watermark.png';
+            if (file_exists($store_path)) {
+                            $web_path = api_get_path(WEB_CODE_PATH).'default_course_document/images/'.api_get_current_access_url_id().'_pdf_watermark.png';
+            }
         }
         return $web_path;
     }

Doc Comments +1 added lines, -1 removed lines

@@ -574,7 +574,7 @@
      * @param	string	$filename filename
      * @param	string	$source_file path of the file
      * @param	string	$course_code
-     * @return 	mixed	web path of the file if sucess, false otherwise
+     * @return 	string|boolean	web path of the file if sucess, false otherwise
      */
     public function upload_watermark($filename, $source_file, $course_code = null)
     {

main/install/index.php

Braces +4 added lines, -1 removed lines

@@ -445,7 +445,10 @@
     }
 }
     ?>
-    <input type="hidden" name="updatePath"         value="<?php if (!$badUpdatePath) echo api_htmlentities($proposedUpdatePath, ENT_QUOTES); ?>" />
+    <input type="hidden" name="updatePath"         value="<?php if (!$badUpdatePath) {
+    echo api_htmlentities($proposedUpdatePath, ENT_QUOTES);
+}
+?>" />
     <input type="hidden" name="urlAppendPath"      value="<?php echo api_htmlentities($urlAppendPath, ENT_QUOTES); ?>" />
     <input type="hidden" name="pathForm"           value="<?php echo api_htmlentities($pathForm, ENT_QUOTES); ?>" />
     <input type="hidden" name="urlForm"            value="<?php echo api_htmlentities($urlForm, ENT_QUOTES); ?>" />

main/admin/access_url_edit_users_to_url.php

Indentation +1 added lines, -1 removed lines

@@ -261,7 +261,7 @@
     ?>
     <option value="<?php echo $enreg['user_id']; ?>"><?php echo $enreg['username'].' - '.api_get_person_name($enreg['firstname'], $enreg['lastname']); ?></option>
     <?php
-     }
+        }
     unset($nosessionUsersList);
     ?>
     </select>

main/inc/ajax/skill.ajax.php

Indentation +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
                     //$gradebook['name'] = $gradebook['name'];
                     //$gradebook_list[]  = $gradebook;
                 } else {
-                  //  $gradebook['name'] = $gradebook_list[$gradebook['parent_id']]['name'].' > '.$gradebook['name'];
+                    //  $gradebook['name'] = $gradebook_list[$gradebook['parent_id']]['name'].' > '.$gradebook['name'];
                     //$gradebook_list[]  = $gradebook;
                 }
             }