chamilo / chamilo-lms

main/inc/lib/skill.lib.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     public function updateProfileInfo($profileId, $name, $description)
     {
         $profileId = intval($profileId);
-        $sql = "UPDATE $this->table SET
+        $sql = "update $this->table SET
                     name = '$name',
                     description = '$description'
                 WHERE id = $profileId ";

Doc Comments +5 added lines, -4 removed lines

@@ -365,6 +365,7 @@ 
 
     /**
      * Gets an element
+     * @param integer $gradebook_id
      */
     public function get_skill_info($skill_id, $gradebook_id)
     {
@@ -612,7 +613,7 @@ 
      * Gets an element
      * @param int $id
      *
-     * @return array|mixed
+     * @return integer
      */
     public function get($id)
     {
@@ -1182,7 +1183,7 @@ 
      * @param int skill id
      * @param bool return a flat array or not
      * @param int depth of the skills
-     * @return json
+     * @return string
      */
     public function get_skills_tree_json(
         $user_id = null,
@@ -1677,8 +1678,8 @@ 
     }
 
     /**
-     * @param $currentUserId
-     * @param $studentId
+     * @param integer $currentUserId
+     * @param integer $studentId
      * @return bool
      */
     public static function hasAccessToUserSkill($currentUserId, $studentId)

main/inc/lib/online.inc.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 
     if (!isset($_SESSION['login_as'])) {
         $current_date = api_get_utc_datetime();
-        $sql = "UPDATE $tbl_track_login SET logout_date='".$current_date."'
+        $sql = "update $tbl_track_login SET logout_date='".$current_date."'
         		WHERE login_id='$i_id_last_connection'";
         Database::query($sql);
     }

Indentation +2 added lines, -2 removed lines

@@ -295,8 +295,8 @@
         }
     }
 
-	//This query will show all registered users. Only for dev purposes.
-	/*$query = "SELECT DISTINCT u.id as login_user_id, login_date
+    //This query will show all registered users. Only for dev purposes.
+    /*$query = "SELECT DISTINCT u.id as login_user_id, login_date
 	        FROM $track_online_table e, $table_user u
             GROUP by u.id
             ORDER BY $column $direction

Braces +4 added lines, -2 removed lines

@@ -214,7 +214,8 @@ 
     $direction = null,
     $time_limit = null,
     $friends = false
-) {
+)
+{
     // Time limit in seconds?
     if (empty($time_limit)) {
         $time_limit = api_get_setting('time_limit_whosonline');
@@ -442,7 +443,8 @@ 
     $uid,
     $time_limit,
     $coursecode = null
-) {
+)
+{
     if (empty($coursecode)) {
         return false;
     }

main/inc/lib/display.lib.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -2533,7 +2533,7 @@
                         </div>
                     </div>
                 </div>
-HTML;
+html;
         } else {
             if (!empty($id)) {
                 $params['id'] = $id;

Indentation +12 added lines, -12 removed lines

@@ -50,12 +50,12 @@ 
         );
     }
 
-     /**
-     * Displays the page header
-     * @param string The name of the page (will be showed in the page title)
-     * @param string Optional help file name
-     * @param string $page_header
-     */
+        /**
+         * Displays the page header
+         * @param string The name of the page (will be showed in the page title)
+         * @param string Optional help file name
+         * @param string $page_header
+         */
     public static function display_header(
         $tool_name = '',
         $help = null,
@@ -726,7 +726,7 @@ 
      * @param array    additional attributes (for instance height, width, onclick, ...)
      * @param integer  The wanted width of the icon (to be looked for in the corresponding img/icons/ folder)
      * @return void
-    */
+     */
     public static function display_icon(
         $image,
         $alt_text = '',
@@ -762,7 +762,7 @@ 
      * @author Julio Montoya 2010 Function improved, adding image constants
      * @author Yannick Warnier 2011 Added size handler
      * @version Feb 2011
-    */
+     */
     public static function return_icon(
         $image,
         $alt_text = '',
@@ -1073,7 +1073,7 @@ 
      * in the $htmlHeadXtra variable before the display_header
      * Add this script
      * @example
-             * <script>
+     * <script>
                     $(function() {
                         $( "#tabs" ).tabs();
                     });
@@ -1780,8 +1780,8 @@ 
         return self::page_header($title, $second_title);
     }
 
-     public static function page_subheader_and_translate($title, $second_title = null)
-     {
+        public static function page_subheader_and_translate($title, $second_title = null)
+        {
         $title = get_lang($title);
         return self::page_subheader($title, $second_title);
     }
@@ -2593,7 +2593,7 @@ 
      */
     public static function dateToStringAgoAndLongDate($dateTime)
     {
-       if (empty($dateTime) || $dateTime === '0000-00-00 00:00:00') {
+        if (empty($dateTime) || $dateTime === '0000-00-00 00:00:00') {
             return '';
         }
 

Doc Comments +23 added lines, -17 removed lines

@@ -33,7 +33,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function toolList()
     {
@@ -307,7 +307,6 @@ 
      *                    'page_nr' = The page to display
      *                    'hide_navigation' =  true to hide the navigation
      * @param array $query_vars Additional variables to add in the query-string
-     * @param array $form actions Additional variables to add in the query-string
      * @param mixed An array with bool values to know which columns show.
      * i.e: $visibility_options= array(true, false) we will only show the first column
      *                Can be also only a bool value. TRUE: show all columns, FALSE: show nothing
@@ -348,7 +347,6 @@ 
      *                    'page_nr' = The page to display
      *                    'hide_navigation' =  true to hide the navigation
      * @param array $query_vars Additional variables to add in the query-string
-     * @param array $form actions Additional variables to add in the query-string
      * @param mixed An array with bool values to know which columns show. i.e:
      *  $visibility_options= array(true, false) we will only show the first column
      *    Can be also only a bool value. TRUE: show all columns, FALSE: show nothing
@@ -403,10 +401,11 @@ 
      *  'per_page' = number of items to show per page
      *  'page_nr' = The page to display
      * @param array $query_vars Additional variables to add in the query-string
-     * @param array $column_show Array of binaries 1= show columns 0. hide a column
+     * @param integer[] $column_show Array of binaries 1= show columns 0. hide a column
      * @param array $column_order An array of integers that let us decide how the columns are going to be sort.
      *    i.e:  $column_order=array('1''4','3','4'); The 2nd column will be order like the 4th column
      * @param array $form_actions Set optional forms actions
+     * @param string $table_name
      *
      * @author Julio Montoya
      */
@@ -462,7 +461,7 @@ 
      * @deprecated Use <code>Display::addFlash(Display::return_message($message, 'normal'));</code>
      *  Or <code>echo Display::return_message($message, 'normal')</code>
      *
-     * @return void
+     * @return string|null
      */
     public static function display_normal_message(
         $message,
@@ -500,7 +499,7 @@ 
      * Displays an confirmation message. Use this if something has been done successfully
      * @param bool    Filter (true) or not (false)
      * @deprecated use Display::addFlash(Display::return_message($message, 'confirm'));
-     * @return void
+     * @return string|null
      */
     public static function display_confirmation_message(
         $message,
@@ -522,7 +521,7 @@ 
      * @param bool    Filter (true) or not (false)
      * @deprecated use Display::addFlash(Display::return_message($message, 'error'));
      *
-     * @return void
+     * @return string|null
      */
     public static function display_error_message(
         $message,
@@ -725,6 +724,7 @@ 
      * @param string   The alt text (probably a language variable)
      * @param array    additional attributes (for instance height, width, onclick, ...)
      * @param integer  The wanted width of the icon (to be looked for in the corresponding img/icons/ folder)
+     * @param string $image
      * @return void
     */
     public static function display_icon(
@@ -976,6 +976,7 @@ 
 
     /**
      * Displays an HTML input tag
+     * @param string $type
      */
     public static function input($type, $name, $value, $attributes = array())
     {
@@ -992,8 +993,8 @@ 
     }
 
     /**
-     * @param $name
-     * @param $value
+     * @param string $name
+     * @param string $value
      * @param array $attributes
      * @return string
      */
@@ -1008,6 +1009,7 @@ 
     /**
      * Displays an HTML select tag
      *
+     * @param string $blank_item_text
      */
     public static function select(
         $name,
@@ -1078,8 +1080,8 @@ 
                         $( "#tabs" ).tabs();
                     });
                 </script>
-     * @param   array   $headers list of the tab titles
-     * @param   array   $items
+     * @param   string[]   $headers list of the tab titles
+     * @param   string[]   $items
      * @param   string  $id id of the container of the tab in the example "tabs"
      * @param   array   $attributes for the ul
      * @param array $ul_attributes
@@ -1159,7 +1161,7 @@ 
 
     /**
      * @param $headers
-     * @param null $selected
+     * @param integer $selected
      *
      * @return string
      */
@@ -1202,6 +1204,7 @@ 
      * As you can see both function use the same "my_grid_name" this is very important otherwise nothing will work
      *
      * @param   string  the div id, this value must be the same with the first parameter of Display::grid_js()
+     * @param string $div_id
      * @return  string  html
      *
      */
@@ -1795,6 +1798,9 @@ 
         return '<'.$size.'>'.Security::remove_XSS($title).'</'.$size.'>';
     }
 
+    /**
+     * @param string $title
+     */
     public static function page_subheader2($title, $second_title = null)
     {
         return self::page_header($title, $second_title, 'h4');
@@ -2443,7 +2449,7 @@ 
 
     /**
      * @param string $id
-     * @param array $content
+     * @param string[] $content
      * @param array $colsWidth Optional. Columns width
      * @return string
      */
@@ -2484,7 +2490,7 @@ 
     /**
      * Get a HTML code for a icon by Font Awesome
      * @param string $name The icon name
-     * @param int|string $size Optional. The size for the icon. (Example: lg, 2, 3, 4, 5)
+     * @param integer $size Optional. The size for the icon. (Example: lg, 2, 3, 4, 5)
      * @param boolean $fixWidth Optional. Whether add the fw class
      * @param string $additionalClass Optional. Additional class
      *
@@ -2529,10 +2535,10 @@ 
     /**
      * @param string $title
      * @param string $content
-     * @param null $id
+     * @param string $id
      * @param array $params
-     * @param null $idAccordion
-     * @param null $idCollapse
+     * @param string $idAccordion
+     * @param string $idCollapse
      * @param bool|true $open
      * @param bool|false $fullClickable
      * @return null|string

main/inc/lib/notebook.lib.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
         $id = Database::insert($table, $params);
 
         if ($id > 0) {
-            $sql = "UPDATE $table SET notebook_id = $id WHERE iid = $id";
+            $sql = "update $table SET notebook_id = $id WHERE iid = $id";
             Database::query($sql);
 
             //insert into item_property

main/inc/lib/database.lib.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -481,7 +481,7 @@ 
                 //Parsing and cleaning the where conditions
                 $whereReturn = self::parse_where_conditions($whereConditions);
 
-                $sql = "UPDATE $tableName SET $updateSql $whereReturn ";
+                $sql = "update $tableName SET $updateSql $whereReturn ";
 
                 $statement = self::getManager()->getConnection()->prepare($sql);
 
@@ -531,7 +531,7 @@ 
             }
         }
 
-        $sql = "SELECT $clean_columns FROM $table_name $conditions";
+        $sql = "select $clean_columns FROM $table_name $conditions";
         $result = self::query($sql);
         $array = array();
 

Spacing +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
         );*/
 
         AnnotationRegistry::registerLoader(
-            function ($class) use ($sysPath) {
+            function($class) use ($sysPath) {
                 $file = str_replace("\\", DIRECTORY_SEPARATOR, $class).".php";
                 $file = str_replace('Symfony/Component/Validator', '', $file);
                 $file = str_replace('Symfony\Component\Validator', '', $file);

main/inc/lib/myspace.lib.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -2242,11 +2242,11 @@
                            WHERE session_id='$id_session' AND c_id='$enreg_course'";
             $rs = Database::query($sql_select);
             list($nbr_users) = Database::fetch_array($rs);
-            $sql_update = "UPDATE $tbl_session_rel_course SET nbr_users=$nbr_users
+            $sql_update = "update $tbl_session_rel_course SET nbr_users=$nbr_users
                            WHERE session_id='$id_session' AND c_id='$enreg_course'";
             Database::query($sql_update);
 
-            $sql_update = "UPDATE $tbl_session SET nbr_users= '$nbr_users' WHERE id='$id_session'";
+            $sql_update = "update $tbl_session SET nbr_users= '$nbr_users' WHERE id='$id_session'";
             Database::query($sql_update);
         }
 

Doc Comments +4 added lines

@@ -2272,6 +2272,7 @@ 
 
     /**
      * Adds missing user-information (which isn't required, like password, etc).
+     * @return integer
      */
     function complete_missing_data($user)
     {
@@ -2872,6 +2873,9 @@ 
     return $result;
 }
 
+/**
+ * @param string|null $end_date
+ */
 function add_day_to($end_date)
 {
     $foo_date = strtotime($end_date);

Braces +15 added lines, -7 removed lines

@@ -1059,11 +1059,13 @@ 
             );
             if ($last_login_date_tmp != false &&
                 $last_login_date == false
-            ) { // TODO: To be cleaned
+            ) {
+// TODO: To be cleaned
                 $last_login_date = $last_login_date_tmp;
             } elseif ($last_login_date_tmp != false &&
                 $last_login_date != false
-            ) { // TODO: Repeated previous condition. To be cleaned.
+            ) {
+// TODO: Repeated previous condition. To be cleaned.
                 // Find the max and assign it to first_login_date
                 if (strtotime($last_login_date_tmp) > strtotime($last_login_date)) {
                     $last_login_date = $last_login_date_tmp;
@@ -1246,9 +1248,11 @@ 
                     null,
                     false
                 );
-                if ($last_login_date_tmp != false && $last_login_date == false) { // TODO: To be cleaned.
+                if ($last_login_date_tmp != false && $last_login_date == false) {
+// TODO: To be cleaned.
                     $last_login_date = $last_login_date_tmp;
-                } elseif ($last_login_date_tmp != false && $last_login_date == false) { // TODO: Repeated previous condition. To be cleaned.
+                } elseif ($last_login_date_tmp != false && $last_login_date == false) {
+// TODO: Repeated previous condition. To be cleaned.
                     // Find the max and assign it to first_login_date
                     if (strtotime($last_login_date_tmp) > strtotime($last_login_date)) {
                         $last_login_date = $last_login_date_tmp;
@@ -1634,9 +1638,11 @@ 
                         $session_id,
                         false
                     );
-                    if ($last_login_date_tmp != false && $last_login_date == false) { // TODO: To be cleaned.
+                    if ($last_login_date_tmp != false && $last_login_date == false) {
+// TODO: To be cleaned.
                         $last_login_date = $last_login_date_tmp;
-                    } else if ($last_login_date_tmp != false && $last_login_date == false) { // TODO: Repeated previous condition. To be cleaned.
+                    } else if ($last_login_date_tmp != false && $last_login_date == false) {
+// TODO: Repeated previous condition. To be cleaned.
                         // Find the max and assign it to first_login_date
                         if (strtotime($last_login_date_tmp) > strtotime($last_login_date)) {
                             $last_login_date = $last_login_date_tmp;
@@ -1906,7 +1912,9 @@ 
                 FROM $tbl_course course
                 WHERE course.code IN (".implode(',', $courses_code).")";
 
-        if (!in_array($direction, array('ASC', 'DESC'))) $direction = 'ASC';
+        if (!in_array($direction, array('ASC', 'DESC'))) {
+            $direction = 'ASC';
+        }
 
         $column = intval($column);
         $from = intval($from);

main/inc/lib/formvalidator/Element/SelectAjax.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
                     });
                 });
             </script>
-JS;
+js;
 
         $this->removeAttribute('formatResult');
         $this->removeAttribute('minimumInputLength');

main/inc/lib/formvalidator/Element/Color.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -47,6 +47,6 @@
                     })
                 });
             </script>
-JS;
+js;
     }
 }

main/inc/lib/formvalidator/Rule/allowed_tags.inc.php

Braces +2 added lines, -1 removed lines

@@ -936,7 +936,8 @@
 
 // HTMLPURIFIER-COMPATIBLE SETTINGS
 
-function convert_kses_to_htmlpurifier($allowed_tags) {
+function convert_kses_to_htmlpurifier($allowed_tags)
+{
     $allowed_html = array();
     foreach ($allowed_tags as $key1 => & $value1) {
         $result[0][] = $key1;